Re: [PATCH 1/2] audit: add filtering for io_uring records, addendum
by kernel test robot
Hi Richard,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on pcmoore-audit/next]
[also build test ERROR on v5.13-rc4 next-20210528]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Richard-Guy-Briggs/audit-add-fil...
base: https://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/audit.git next
config: arm64-randconfig-r021-20210531 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project bc6799f2f79f0ae87e9f1ebf9d25ba799fbd25a9)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/0day-ci/linux/commit/07a3e22a2f984838bc98b43b58e8ef08e...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Richard-Guy-Briggs/audit-add-filtering-for-io_uring-records-addendum/20210531-214941
git checkout 07a3e22a2f984838bc98b43b58e8ef08e9353483
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> kernel/auditfilter.c:155:24: error: use of undeclared identifier 'AUDIT_FILTER_URING_EXIT'
krule->listnr != AUDIT_FILTER_URING_EXIT) ||
^
kernel/auditfilter.c:252:7: error: use of undeclared identifier 'AUDIT_FILTER_URING_EXIT'
case AUDIT_FILTER_URING_EXIT:
^
kernel/auditfilter.c:986:28: error: use of undeclared identifier 'AUDIT_FILTER_URING_EXIT'
entry->rule.listnr == AUDIT_FILTER_URING_EXIT) {
^
3 errors generated.
--
>> kernel/audit_watch.c:187:24: error: use of undeclared identifier 'AUDIT_FILTER_URING_EXIT'
krule->listnr != AUDIT_FILTER_URING_EXIT) ||
^
1 error generated.
--
>> kernel/audit_tree.c:731:23: error: use of undeclared identifier 'AUDIT_FILTER_URING_EXIT'
rule->listnr != AUDIT_FILTER_URING_EXIT) ||
^
1 error generated.
vim +/AUDIT_FILTER_URING_EXIT +155 kernel/auditfilter.c
149
150 /* Translate an inode field to kernel representation. */
151 static inline int audit_to_inode(struct audit_krule *krule,
152 struct audit_field *f)
153 {
154 if ((krule->listnr != AUDIT_FILTER_EXIT &&
> 155 krule->listnr != AUDIT_FILTER_URING_EXIT) ||
156 krule->inode_f || krule->watch || krule->tree ||
157 (f->op != Audit_equal && f->op != Audit_not_equal))
158 return -EINVAL;
159
160 krule->inode_f = f;
161 return 0;
162 }
163
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
3 months, 3 weeks
Re: [PATCH 1/2] audit: add filtering for io_uring records, addendum
by kernel test robot
Hi Richard,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on pcmoore-audit/next]
[also build test ERROR on v5.13-rc4 next-20210528]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Richard-Guy-Briggs/audit-add-fil...
base: https://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/audit.git next
config: parisc-randconfig-r015-20210531 (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/07a3e22a2f984838bc98b43b58e8ef08e...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Richard-Guy-Briggs/audit-add-filtering-for-io_uring-records-addendum/20210531-214941
git checkout 07a3e22a2f984838bc98b43b58e8ef08e9353483
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=parisc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
kernel/auditfilter.c: In function 'audit_to_inode':
>> kernel/auditfilter.c:155:24: error: 'AUDIT_FILTER_URING_EXIT' undeclared (first use in this function); did you mean 'AUDIT_FILTER_EXIT'?
155 | krule->listnr != AUDIT_FILTER_URING_EXIT) ||
| ^~~~~~~~~~~~~~~~~~~~~~~
| AUDIT_FILTER_EXIT
kernel/auditfilter.c:155:24: note: each undeclared identifier is reported only once for each function it appears in
kernel/auditfilter.c: In function 'audit_to_entry_common':
kernel/auditfilter.c:252:7: error: 'AUDIT_FILTER_URING_EXIT' undeclared (first use in this function); did you mean 'AUDIT_FILTER_EXIT'?
252 | case AUDIT_FILTER_URING_EXIT:
| ^~~~~~~~~~~~~~~~~~~~~~~
| AUDIT_FILTER_EXIT
kernel/auditfilter.c: In function 'audit_add_rule':
kernel/auditfilter.c:986:28: error: 'AUDIT_FILTER_URING_EXIT' undeclared (first use in this function); did you mean 'AUDIT_FILTER_EXIT'?
986 | entry->rule.listnr == AUDIT_FILTER_URING_EXIT) {
| ^~~~~~~~~~~~~~~~~~~~~~~
| AUDIT_FILTER_EXIT
--
kernel/audit_watch.c: In function 'audit_to_watch':
>> kernel/audit_watch.c:187:24: error: 'AUDIT_FILTER_URING_EXIT' undeclared (first use in this function); did you mean 'AUDIT_FILTER_EXIT'?
187 | krule->listnr != AUDIT_FILTER_URING_EXIT) ||
| ^~~~~~~~~~~~~~~~~~~~~~~
| AUDIT_FILTER_EXIT
kernel/audit_watch.c:187:24: note: each undeclared identifier is reported only once for each function it appears in
--
kernel/audit_tree.c: In function 'audit_make_tree':
>> kernel/audit_tree.c:731:23: error: 'AUDIT_FILTER_URING_EXIT' undeclared (first use in this function); did you mean 'AUDIT_FILTER_EXIT'?
731 | rule->listnr != AUDIT_FILTER_URING_EXIT) ||
| ^~~~~~~~~~~~~~~~~~~~~~~
| AUDIT_FILTER_EXIT
kernel/audit_tree.c:731:23: note: each undeclared identifier is reported only once for each function it appears in
vim +155 kernel/auditfilter.c
149
150 /* Translate an inode field to kernel representation. */
151 static inline int audit_to_inode(struct audit_krule *krule,
152 struct audit_field *f)
153 {
154 if ((krule->listnr != AUDIT_FILTER_EXIT &&
> 155 krule->listnr != AUDIT_FILTER_URING_EXIT) ||
156 krule->inode_f || krule->watch || krule->tree ||
157 (f->op != Audit_equal && f->op != Audit_not_equal))
158 return -EINVAL;
159
160 krule->inode_f = f;
161 return 0;
162 }
163
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
3 months, 3 weeks
[thomash:topic/ttm_branch_v5 7/15] drivers/gpu/drm/drm_cache.c:386:54: error: 'has_movntdqa' undeclared
by kernel test robot
tree: git://people.freedesktop.org/~thomash/linux topic/ttm_branch_v5
head: 9f73f48e82d8cc2d9a3f649b8d86d290bc76f1be
commit: 4f04be58645eac4d7d401dffff634ed246a6b6b9 [7/15] drm: Add a prefetching memcpy_from_wc
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git remote add thomash git://people.freedesktop.org/~thomash/linux
git fetch --no-tags thomash topic/ttm_branch_v5
git checkout 4f04be58645eac4d7d401dffff634ed246a6b6b9
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from include/linux/init.h:5,
from include/linux/io.h:10,
from include/linux/dma-buf-map.h:9,
from drivers/gpu/drm/drm_cache.c:31:
drivers/gpu/drm/drm_cache.c: In function 'drm_memcpy_from_wc':
>> drivers/gpu/drm/drm_cache.c:386:54: error: 'has_movntdqa' undeclared (first use in this function)
386 | if (IS_ENABLED(CONFIG_X86) && static_branch_likely(&has_movntdqa)) {
| ^~~~~~~~~~~~
include/linux/compiler.h:77:40: note: in definition of macro 'likely'
77 | # define likely(x) __builtin_expect(!!(x), 1)
| ^
include/linux/jump_label.h:495:34: note: in expansion of macro 'likely_notrace'
495 | #define static_branch_likely(x) likely_notrace(static_key_enabled(&(x)->key))
| ^~~~~~~~~~~~~~
include/linux/jump_label.h:495:49: note: in expansion of macro 'static_key_enabled'
495 | #define static_branch_likely(x) likely_notrace(static_key_enabled(&(x)->key))
| ^~~~~~~~~~~~~~~~~~
drivers/gpu/drm/drm_cache.c:386:32: note: in expansion of macro 'static_branch_likely'
386 | if (IS_ENABLED(CONFIG_X86) && static_branch_likely(&has_movntdqa)) {
| ^~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/drm_cache.c:386:54: note: each undeclared identifier is reported only once for each function it appears in
386 | if (IS_ENABLED(CONFIG_X86) && static_branch_likely(&has_movntdqa)) {
| ^~~~~~~~~~~~
include/linux/compiler.h:77:40: note: in definition of macro 'likely'
77 | # define likely(x) __builtin_expect(!!(x), 1)
| ^
include/linux/jump_label.h:495:34: note: in expansion of macro 'likely_notrace'
495 | #define static_branch_likely(x) likely_notrace(static_key_enabled(&(x)->key))
| ^~~~~~~~~~~~~~
include/linux/jump_label.h:495:49: note: in expansion of macro 'static_key_enabled'
495 | #define static_branch_likely(x) likely_notrace(static_key_enabled(&(x)->key))
| ^~~~~~~~~~~~~~~~~~
drivers/gpu/drm/drm_cache.c:386:32: note: in expansion of macro 'static_branch_likely'
386 | if (IS_ENABLED(CONFIG_X86) && static_branch_likely(&has_movntdqa)) {
| ^~~~~~~~~~~~~~~~~~~~
>> drivers/gpu/drm/drm_cache.c:387:3: error: implicit declaration of function '__drm_memcpy_from_wc'; did you mean 'drm_memcpy_from_wc'? [-Werror=implicit-function-declaration]
387 | __drm_memcpy_from_wc(dst->is_iomem ?
| ^~~~~~~~~~~~~~~~~~~~
| drm_memcpy_from_wc
cc1: some warnings being treated as errors
vim +/has_movntdqa +386 drivers/gpu/drm/drm_cache.c
371
372 /**
373 * drm_memcpy_from_wc - Perform the fastest available memcpy from a source
374 * that may be WC.
375 * @dst: The destination pointer
376 * @src: The source pointer
377 * @len: The size of the area o transfer in bytes
378 *
379 * Tries an arch optimized memcpy for prefetching reading out of a WC region,
380 * and if no such beast is available, falls back to a normal memcpy.
381 */
382 void drm_memcpy_from_wc(struct dma_buf_map *dst,
383 const struct dma_buf_map *src,
384 unsigned long len)
385 {
> 386 if (IS_ENABLED(CONFIG_X86) && static_branch_likely(&has_movntdqa)) {
> 387 __drm_memcpy_from_wc(dst->is_iomem ?
388 (void __force *)dst->vaddr_iomem :
389 dst->vaddr,
390 src->is_iomem ?
391 (void const __force *)src->vaddr_iomem :
392 src->vaddr,
393 len);
394 return;
395 }
396
397 memcpy_fallback(dst, src, len);
398 }
399 EXPORT_SYMBOL(drm_memcpy_from_wc);
400
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
3 months, 3 weeks
[asm-generic:clkdev 4/5] drivers/clk/clk.c:723:6: error: redefinition of 'clk_rate_exclusive_put'
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/arnd/asm-generic.git clkdev
head: 3c150d2578b204c2e18c7ac6d967b43a614befbe
commit: b82125f4dd714ff85c00fdf585722f02a6929ade [4/5] clkdev: remove CONFIG_CLKDEV_LOOKUP
config: powerpc-randconfig-r016-20210531 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project bc6799f2f79f0ae87e9f1ebf9d25ba799fbd25a9)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install powerpc cross compiling tool for clang build
# apt-get install binutils-powerpc-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/arnd/asm-generic.git/comm...
git remote add asm-generic https://git.kernel.org/pub/scm/linux/kernel/git/arnd/asm-generic.git
git fetch --no-tags asm-generic clkdev
git checkout b82125f4dd714ff85c00fdf585722f02a6929ade
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from drivers/clk/clk.c:9:
In file included from include/linux/clk.h:13:
In file included from include/linux/kernel.h:12:
In file included from include/linux/bitops.h:32:
In file included from arch/powerpc/include/asm/bitops.h:62:
arch/powerpc/include/asm/barrier.h:49:9: warning: '__lwsync' macro redefined [-Wmacro-redefined]
#define __lwsync() __asm__ __volatile__ (stringify_in_c(LWSYNC) : : :"memory")
^
<built-in>:308:9: note: previous definition is here
#define __lwsync __builtin_ppc_lwsync
^
>> drivers/clk/clk.c:723:6: error: redefinition of 'clk_rate_exclusive_put'
void clk_rate_exclusive_put(struct clk *clk)
^
include/linux/clk.h:861:20: note: previous definition is here
static inline void clk_rate_exclusive_put(struct clk *clk) {}
^
>> drivers/clk/clk.c:789:5: error: redefinition of 'clk_rate_exclusive_get'
int clk_rate_exclusive_get(struct clk *clk)
^
include/linux/clk.h:856:19: note: previous definition is here
static inline int clk_rate_exclusive_get(struct clk *clk)
^
>> drivers/clk/clk.c:993:6: error: redefinition of 'clk_disable'
void clk_disable(struct clk *clk)
^
include/linux/clk.h:874:20: note: previous definition is here
static inline void clk_disable(struct clk *clk) {}
^
>> drivers/clk/clk.c:1106:5: error: redefinition of 'clk_save_context'
int clk_save_context(void)
^
include/linux/clk.h:936:19: note: previous definition is here
static inline int clk_save_context(void)
^
>> drivers/clk/clk.c:1133:6: error: redefinition of 'clk_restore_context'
void clk_restore_context(void)
^
include/linux/clk.h:941:20: note: previous definition is here
static inline void clk_restore_context(void) {}
^
>> drivers/clk/clk.c:1158:5: error: redefinition of 'clk_enable'
int clk_enable(struct clk *clk)
^
include/linux/clk.h:863:19: note: previous definition is here
static inline int clk_enable(struct clk *clk)
^
>> drivers/clk/clk.c:1458:6: error: redefinition of 'clk_round_rate'
long clk_round_rate(struct clk *clk, unsigned long rate)
^
include/linux/clk.h:895:20: note: previous definition is here
static inline long clk_round_rate(struct clk *clk, unsigned long rate)
^
>> drivers/clk/clk.c:1652:15: error: redefinition of 'clk_get_rate'
unsigned long clk_get_rate(struct clk *clk)
^
include/linux/clk.h:880:29: note: previous definition is here
static inline unsigned long clk_get_rate(struct clk *clk)
^
>> drivers/clk/clk.c:2243:5: error: redefinition of 'clk_set_rate'
int clk_set_rate(struct clk *clk, unsigned long rate)
^
include/linux/clk.h:885:19: note: previous definition is here
static inline int clk_set_rate(struct clk *clk, unsigned long rate)
^
>> drivers/clk/clk.c:2286:5: error: redefinition of 'clk_set_rate_exclusive'
int clk_set_rate_exclusive(struct clk *clk, unsigned long rate)
^
include/linux/clk.h:890:19: note: previous definition is here
static inline int clk_set_rate_exclusive(struct clk *clk, unsigned long rate)
^
>> drivers/clk/clk.c:2322:5: error: redefinition of 'clk_set_rate_range'
int clk_set_rate_range(struct clk *clk, unsigned long min, unsigned long max)
^
include/linux/clk.h:905:19: note: previous definition is here
static inline int clk_set_rate_range(struct clk *clk, unsigned long min,
^
>> drivers/clk/clk.c:2394:5: error: redefinition of 'clk_set_min_rate'
int clk_set_min_rate(struct clk *clk, unsigned long rate)
^
include/linux/clk.h:911:19: note: previous definition is here
static inline int clk_set_min_rate(struct clk *clk, unsigned long rate)
^
>> drivers/clk/clk.c:2412:5: error: redefinition of 'clk_set_max_rate'
int clk_set_max_rate(struct clk *clk, unsigned long rate)
^
include/linux/clk.h:916:19: note: previous definition is here
static inline int clk_set_max_rate(struct clk *clk, unsigned long rate)
^
>> drivers/clk/clk.c:2429:13: error: redefinition of 'clk_get_parent'
struct clk *clk_get_parent(struct clk *clk)
^
include/linux/clk.h:926:27: note: previous definition is here
static inline struct clk *clk_get_parent(struct clk *clk)
^
>> drivers/clk/clk.c:2481:6: error: redefinition of 'clk_has_parent'
bool clk_has_parent(struct clk *clk, struct clk *parent)
^
include/linux/clk.h:900:20: note: previous definition is here
static inline bool clk_has_parent(struct clk *clk, struct clk *parent)
^
>> drivers/clk/clk.c:2593:5: error: redefinition of 'clk_set_parent'
int clk_set_parent(struct clk *clk, struct clk *parent)
^
include/linux/clk.h:921:19: note: previous definition is here
static inline int clk_set_parent(struct clk *clk, struct clk *parent)
^
1 warning and 16 errors generated.
vim +/clk_rate_exclusive_put +723 drivers/clk/clk.c
e55a839a7a1c56 Jerome Brunet 2017-12-01 704
55e9b8b7b806ec Jerome Brunet 2017-12-01 705 /**
55e9b8b7b806ec Jerome Brunet 2017-12-01 706 * clk_rate_exclusive_put - release exclusivity over clock rate control
55e9b8b7b806ec Jerome Brunet 2017-12-01 707 * @clk: the clk over which the exclusivity is released
55e9b8b7b806ec Jerome Brunet 2017-12-01 708 *
55e9b8b7b806ec Jerome Brunet 2017-12-01 709 * clk_rate_exclusive_put() completes a critical section during which a clock
55e9b8b7b806ec Jerome Brunet 2017-12-01 710 * consumer cannot tolerate any other consumer making any operation on the
55e9b8b7b806ec Jerome Brunet 2017-12-01 711 * clock which could result in a rate change or rate glitch. Exclusive clocks
55e9b8b7b806ec Jerome Brunet 2017-12-01 712 * cannot have their rate changed, either directly or indirectly due to changes
55e9b8b7b806ec Jerome Brunet 2017-12-01 713 * further up the parent chain of clocks. As a result, clocks up parent chain
55e9b8b7b806ec Jerome Brunet 2017-12-01 714 * also get under exclusive control of the calling consumer.
55e9b8b7b806ec Jerome Brunet 2017-12-01 715 *
55e9b8b7b806ec Jerome Brunet 2017-12-01 716 * If exlusivity is claimed more than once on clock, even by the same consumer,
55e9b8b7b806ec Jerome Brunet 2017-12-01 717 * the rate effectively gets locked as exclusivity can't be preempted.
55e9b8b7b806ec Jerome Brunet 2017-12-01 718 *
55e9b8b7b806ec Jerome Brunet 2017-12-01 719 * Calls to clk_rate_exclusive_put() must be balanced with calls to
55e9b8b7b806ec Jerome Brunet 2017-12-01 720 * clk_rate_exclusive_get(). Calls to this function may sleep, and do not return
55e9b8b7b806ec Jerome Brunet 2017-12-01 721 * error status.
55e9b8b7b806ec Jerome Brunet 2017-12-01 722 */
55e9b8b7b806ec Jerome Brunet 2017-12-01 @723 void clk_rate_exclusive_put(struct clk *clk)
55e9b8b7b806ec Jerome Brunet 2017-12-01 724 {
55e9b8b7b806ec Jerome Brunet 2017-12-01 725 if (!clk)
55e9b8b7b806ec Jerome Brunet 2017-12-01 726 return;
55e9b8b7b806ec Jerome Brunet 2017-12-01 727
55e9b8b7b806ec Jerome Brunet 2017-12-01 728 clk_prepare_lock();
55e9b8b7b806ec Jerome Brunet 2017-12-01 729
55e9b8b7b806ec Jerome Brunet 2017-12-01 730 /*
55e9b8b7b806ec Jerome Brunet 2017-12-01 731 * if there is something wrong with this consumer protect count, stop
55e9b8b7b806ec Jerome Brunet 2017-12-01 732 * here before messing with the provider
55e9b8b7b806ec Jerome Brunet 2017-12-01 733 */
55e9b8b7b806ec Jerome Brunet 2017-12-01 734 if (WARN_ON(clk->exclusive_count <= 0))
55e9b8b7b806ec Jerome Brunet 2017-12-01 735 goto out;
55e9b8b7b806ec Jerome Brunet 2017-12-01 736
55e9b8b7b806ec Jerome Brunet 2017-12-01 737 clk_core_rate_unprotect(clk->core);
55e9b8b7b806ec Jerome Brunet 2017-12-01 738 clk->exclusive_count--;
55e9b8b7b806ec Jerome Brunet 2017-12-01 739 out:
55e9b8b7b806ec Jerome Brunet 2017-12-01 740 clk_prepare_unlock();
55e9b8b7b806ec Jerome Brunet 2017-12-01 741 }
55e9b8b7b806ec Jerome Brunet 2017-12-01 742 EXPORT_SYMBOL_GPL(clk_rate_exclusive_put);
55e9b8b7b806ec Jerome Brunet 2017-12-01 743
e55a839a7a1c56 Jerome Brunet 2017-12-01 744 static void clk_core_rate_protect(struct clk_core *core)
e55a839a7a1c56 Jerome Brunet 2017-12-01 745 {
e55a839a7a1c56 Jerome Brunet 2017-12-01 746 lockdep_assert_held(&prepare_lock);
e55a839a7a1c56 Jerome Brunet 2017-12-01 747
e55a839a7a1c56 Jerome Brunet 2017-12-01 748 if (!core)
e55a839a7a1c56 Jerome Brunet 2017-12-01 749 return;
e55a839a7a1c56 Jerome Brunet 2017-12-01 750
e55a839a7a1c56 Jerome Brunet 2017-12-01 751 if (core->protect_count == 0)
e55a839a7a1c56 Jerome Brunet 2017-12-01 752 clk_core_rate_protect(core->parent);
e55a839a7a1c56 Jerome Brunet 2017-12-01 753
e55a839a7a1c56 Jerome Brunet 2017-12-01 754 core->protect_count++;
e55a839a7a1c56 Jerome Brunet 2017-12-01 755 }
e55a839a7a1c56 Jerome Brunet 2017-12-01 756
e55a839a7a1c56 Jerome Brunet 2017-12-01 757 static void clk_core_rate_restore_protect(struct clk_core *core, int count)
e55a839a7a1c56 Jerome Brunet 2017-12-01 758 {
e55a839a7a1c56 Jerome Brunet 2017-12-01 759 lockdep_assert_held(&prepare_lock);
e55a839a7a1c56 Jerome Brunet 2017-12-01 760
e55a839a7a1c56 Jerome Brunet 2017-12-01 761 if (!core)
e55a839a7a1c56 Jerome Brunet 2017-12-01 762 return;
e55a839a7a1c56 Jerome Brunet 2017-12-01 763
e55a839a7a1c56 Jerome Brunet 2017-12-01 764 if (count == 0)
e55a839a7a1c56 Jerome Brunet 2017-12-01 765 return;
e55a839a7a1c56 Jerome Brunet 2017-12-01 766
e55a839a7a1c56 Jerome Brunet 2017-12-01 767 clk_core_rate_protect(core);
e55a839a7a1c56 Jerome Brunet 2017-12-01 768 core->protect_count = count;
e55a839a7a1c56 Jerome Brunet 2017-12-01 769 }
e55a839a7a1c56 Jerome Brunet 2017-12-01 770
55e9b8b7b806ec Jerome Brunet 2017-12-01 771 /**
55e9b8b7b806ec Jerome Brunet 2017-12-01 772 * clk_rate_exclusive_get - get exclusivity over the clk rate control
55e9b8b7b806ec Jerome Brunet 2017-12-01 773 * @clk: the clk over which the exclusity of rate control is requested
55e9b8b7b806ec Jerome Brunet 2017-12-01 774 *
a37a5a9d715f0d Andy Shevchenko 2020-03-10 775 * clk_rate_exclusive_get() begins a critical section during which a clock
55e9b8b7b806ec Jerome Brunet 2017-12-01 776 * consumer cannot tolerate any other consumer making any operation on the
55e9b8b7b806ec Jerome Brunet 2017-12-01 777 * clock which could result in a rate change or rate glitch. Exclusive clocks
55e9b8b7b806ec Jerome Brunet 2017-12-01 778 * cannot have their rate changed, either directly or indirectly due to changes
55e9b8b7b806ec Jerome Brunet 2017-12-01 779 * further up the parent chain of clocks. As a result, clocks up parent chain
55e9b8b7b806ec Jerome Brunet 2017-12-01 780 * also get under exclusive control of the calling consumer.
55e9b8b7b806ec Jerome Brunet 2017-12-01 781 *
55e9b8b7b806ec Jerome Brunet 2017-12-01 782 * If exlusivity is claimed more than once on clock, even by the same consumer,
55e9b8b7b806ec Jerome Brunet 2017-12-01 783 * the rate effectively gets locked as exclusivity can't be preempted.
55e9b8b7b806ec Jerome Brunet 2017-12-01 784 *
55e9b8b7b806ec Jerome Brunet 2017-12-01 785 * Calls to clk_rate_exclusive_get() should be balanced with calls to
55e9b8b7b806ec Jerome Brunet 2017-12-01 786 * clk_rate_exclusive_put(). Calls to this function may sleep.
55e9b8b7b806ec Jerome Brunet 2017-12-01 787 * Returns 0 on success, -EERROR otherwise
55e9b8b7b806ec Jerome Brunet 2017-12-01 788 */
55e9b8b7b806ec Jerome Brunet 2017-12-01 @789 int clk_rate_exclusive_get(struct clk *clk)
55e9b8b7b806ec Jerome Brunet 2017-12-01 790 {
55e9b8b7b806ec Jerome Brunet 2017-12-01 791 if (!clk)
55e9b8b7b806ec Jerome Brunet 2017-12-01 792 return 0;
55e9b8b7b806ec Jerome Brunet 2017-12-01 793
55e9b8b7b806ec Jerome Brunet 2017-12-01 794 clk_prepare_lock();
55e9b8b7b806ec Jerome Brunet 2017-12-01 795 clk_core_rate_protect(clk->core);
55e9b8b7b806ec Jerome Brunet 2017-12-01 796 clk->exclusive_count++;
55e9b8b7b806ec Jerome Brunet 2017-12-01 797 clk_prepare_unlock();
55e9b8b7b806ec Jerome Brunet 2017-12-01 798
55e9b8b7b806ec Jerome Brunet 2017-12-01 799 return 0;
55e9b8b7b806ec Jerome Brunet 2017-12-01 800 }
55e9b8b7b806ec Jerome Brunet 2017-12-01 801 EXPORT_SYMBOL_GPL(clk_rate_exclusive_get);
55e9b8b7b806ec Jerome Brunet 2017-12-01 802
:::::: The code at line 723 was first introduced by commit
:::::: 55e9b8b7b806ec3f9a8817e13596682a5981c19c clk: add clk_rate_exclusive api
:::::: TO: Jerome Brunet <jbrunet(a)baylibre.com>
:::::: CC: Michael Turquette <mturquette(a)baylibre.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
3 months, 3 weeks
[hch-block:alloc_disk-part3 59/60] arch/um/drivers/ubd_kern.c:247:7: warning: variable 'major' set but not used
by kernel test robot
tree: git://git.infradead.org/users/hch/block.git alloc_disk-part3
head: 92eea9c8466f585a79e99bef97404389d1e6eb87
commit: 6e11b3a51b107394b94b87170401d748a7d1bf17 [59/60] ubd: remove the code to register as the legacy IDE driver
config: um-randconfig-r014-20210531 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
git remote add hch-block git://git.infradead.org/users/hch/block.git
git fetch --no-tags hch-block alloc_disk-part3
git checkout 6e11b3a51b107394b94b87170401d748a7d1bf17
# save the attached .config to linux build tree
make W=1 ARCH=um
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
arch/um/drivers/ubd_kern.c: In function 'ubd_setup_common':
>> arch/um/drivers/ubd_kern.c:247:7: warning: variable 'major' set but not used [-Wunused-but-set-variable]
247 | int major;
| ^~~~~
vim +/major +247 arch/um/drivers/ubd_kern.c
^1da177e4c3f41 Linus Torvalds 2005-04-16 231
d8d7c28ec0b50a Paolo 'Blaisorblade' Giarrusso 2006-10-30 232 /* If *index_out == -1 at exit, the passed option was a general one;
d8d7c28ec0b50a Paolo 'Blaisorblade' Giarrusso 2006-10-30 233 * otherwise, the str pointer is used (and owned) inside ubd_devs array, so it
d8d7c28ec0b50a Paolo 'Blaisorblade' Giarrusso 2006-10-30 234 * should not be freed on exit.
d8d7c28ec0b50a Paolo 'Blaisorblade' Giarrusso 2006-10-30 235 */
f28169d2000177 Jeff Dike 2007-02-10 236 static int ubd_setup_common(char *str, int *index_out, char **error_out)
^1da177e4c3f41 Linus Torvalds 2005-04-16 237 {
7d314e346d6081 Paolo 'Blaisorblade' Giarrusso 2006-10-30 238 struct ubd *ubd_dev;
^1da177e4c3f41 Linus Torvalds 2005-04-16 239 struct openflags flags = global_openflags;
ef3ba87cb7c911 Christopher Obbard 2020-11-23 240 char *file, *backing_file, *serial;
b8831a1d2c78c0 Jeff Dike 2007-02-10 241 int n, err = 0, i;
^1da177e4c3f41 Linus Torvalds 2005-04-16 242
^1da177e4c3f41 Linus Torvalds 2005-04-16 243 if(index_out) *index_out = -1;
^1da177e4c3f41 Linus Torvalds 2005-04-16 244 n = *str;
^1da177e4c3f41 Linus Torvalds 2005-04-16 245 if(n == '='){
^1da177e4c3f41 Linus Torvalds 2005-04-16 246 char *end;
^1da177e4c3f41 Linus Torvalds 2005-04-16 @247 int major;
^1da177e4c3f41 Linus Torvalds 2005-04-16 248
^1da177e4c3f41 Linus Torvalds 2005-04-16 249 str++;
^1da177e4c3f41 Linus Torvalds 2005-04-16 250 if(!strcmp(str, "sync")){
^1da177e4c3f41 Linus Torvalds 2005-04-16 251 global_openflags = of_sync(global_openflags);
9ca55299f2ee0a Daniel Walter 2019-04-02 252 return err;
^1da177e4c3f41 Linus Torvalds 2005-04-16 253 }
b8831a1d2c78c0 Jeff Dike 2007-02-10 254
b8831a1d2c78c0 Jeff Dike 2007-02-10 255 err = -EINVAL;
^1da177e4c3f41 Linus Torvalds 2005-04-16 256 major = simple_strtoul(str, &end, 0);
^1da177e4c3f41 Linus Torvalds 2005-04-16 257 if((*end != '\0') || (end == str)){
f28169d2000177 Jeff Dike 2007-02-10 258 *error_out = "Didn't parse major number";
9ca55299f2ee0a Daniel Walter 2019-04-02 259 return err;
^1da177e4c3f41 Linus Torvalds 2005-04-16 260 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 261
6e11b3a51b1073 Christoph Hellwig 2021-05-04 262 pr_warn("fake major not supported any more\n");
6e11b3a51b1073 Christoph Hellwig 2021-05-04 263 return 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16 264 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 265
^1da177e4c3f41 Linus Torvalds 2005-04-16 266 n = parse_unit(&str);
^1da177e4c3f41 Linus Torvalds 2005-04-16 267 if(n < 0){
f28169d2000177 Jeff Dike 2007-02-10 268 *error_out = "Couldn't parse device number";
f28169d2000177 Jeff Dike 2007-02-10 269 return -EINVAL;
^1da177e4c3f41 Linus Torvalds 2005-04-16 270 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 271 if(n >= MAX_DEV){
f28169d2000177 Jeff Dike 2007-02-10 272 *error_out = "Device number out of range";
f28169d2000177 Jeff Dike 2007-02-10 273 return 1;
^1da177e4c3f41 Linus Torvalds 2005-04-16 274 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 275
f28169d2000177 Jeff Dike 2007-02-10 276 err = -EBUSY;
d7fb2c3865ca0f Paolo 'Blaisorblade' Giarrusso 2006-10-30 277 mutex_lock(&ubd_lock);
^1da177e4c3f41 Linus Torvalds 2005-04-16 278
7d314e346d6081 Paolo 'Blaisorblade' Giarrusso 2006-10-30 279 ubd_dev = &ubd_devs[n];
7d314e346d6081 Paolo 'Blaisorblade' Giarrusso 2006-10-30 280 if(ubd_dev->file != NULL){
f28169d2000177 Jeff Dike 2007-02-10 281 *error_out = "Device is already configured";
^1da177e4c3f41 Linus Torvalds 2005-04-16 282 goto out;
^1da177e4c3f41 Linus Torvalds 2005-04-16 283 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 284
^1da177e4c3f41 Linus Torvalds 2005-04-16 285 if (index_out)
^1da177e4c3f41 Linus Torvalds 2005-04-16 286 *index_out = n;
^1da177e4c3f41 Linus Torvalds 2005-04-16 287
f28169d2000177 Jeff Dike 2007-02-10 288 err = -EINVAL;
50109b5a03b402 Anton Ivanov 2018-11-14 289 for (i = 0; i < sizeof("rscdt="); i++) {
^1da177e4c3f41 Linus Torvalds 2005-04-16 290 switch (*str) {
^1da177e4c3f41 Linus Torvalds 2005-04-16 291 case 'r':
^1da177e4c3f41 Linus Torvalds 2005-04-16 292 flags.w = 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16 293 break;
^1da177e4c3f41 Linus Torvalds 2005-04-16 294 case 's':
^1da177e4c3f41 Linus Torvalds 2005-04-16 295 flags.s = 1;
^1da177e4c3f41 Linus Torvalds 2005-04-16 296 break;
^1da177e4c3f41 Linus Torvalds 2005-04-16 297 case 'd':
7d314e346d6081 Paolo 'Blaisorblade' Giarrusso 2006-10-30 298 ubd_dev->no_cow = 1;
^1da177e4c3f41 Linus Torvalds 2005-04-16 299 break;
6c29256c5703ad Jeff Dike 2006-03-27 300 case 'c':
7d314e346d6081 Paolo 'Blaisorblade' Giarrusso 2006-10-30 301 ubd_dev->shared = 1;
6c29256c5703ad Jeff Dike 2006-03-27 302 break;
50109b5a03b402 Anton Ivanov 2018-11-14 303 case 't':
50109b5a03b402 Anton Ivanov 2018-11-14 304 ubd_dev->no_trim = 1;
50109b5a03b402 Anton Ivanov 2018-11-14 305 break;
^1da177e4c3f41 Linus Torvalds 2005-04-16 306 case '=':
^1da177e4c3f41 Linus Torvalds 2005-04-16 307 str++;
^1da177e4c3f41 Linus Torvalds 2005-04-16 308 goto break_loop;
^1da177e4c3f41 Linus Torvalds 2005-04-16 309 default:
f28169d2000177 Jeff Dike 2007-02-10 310 *error_out = "Expected '=' or flag letter "
50109b5a03b402 Anton Ivanov 2018-11-14 311 "(r, s, c, t or d)";
^1da177e4c3f41 Linus Torvalds 2005-04-16 312 goto out;
^1da177e4c3f41 Linus Torvalds 2005-04-16 313 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 314 str++;
^1da177e4c3f41 Linus Torvalds 2005-04-16 315 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 316
^1da177e4c3f41 Linus Torvalds 2005-04-16 317 if (*str == '=')
f28169d2000177 Jeff Dike 2007-02-10 318 *error_out = "Too many flags specified";
^1da177e4c3f41 Linus Torvalds 2005-04-16 319 else
f28169d2000177 Jeff Dike 2007-02-10 320 *error_out = "Missing '='";
^1da177e4c3f41 Linus Torvalds 2005-04-16 321 goto out;
^1da177e4c3f41 Linus Torvalds 2005-04-16 322
^1da177e4c3f41 Linus Torvalds 2005-04-16 323 break_loop:
ef3ba87cb7c911 Christopher Obbard 2020-11-23 324 file = strsep(&str, ",:");
ef3ba87cb7c911 Christopher Obbard 2020-11-23 325 if (*file == '\0')
ef3ba87cb7c911 Christopher Obbard 2020-11-23 326 file = NULL;
ef3ba87cb7c911 Christopher Obbard 2020-11-23 327
ef3ba87cb7c911 Christopher Obbard 2020-11-23 328 backing_file = strsep(&str, ",:");
94c41b3a7c370b Hajime Tazaki 2020-12-21 329 if (backing_file && *backing_file == '\0')
ef3ba87cb7c911 Christopher Obbard 2020-11-23 330 backing_file = NULL;
^1da177e4c3f41 Linus Torvalds 2005-04-16 331
ef3ba87cb7c911 Christopher Obbard 2020-11-23 332 serial = strsep(&str, ",:");
94c41b3a7c370b Hajime Tazaki 2020-12-21 333 if (serial && *serial == '\0')
ef3ba87cb7c911 Christopher Obbard 2020-11-23 334 serial = NULL;
^1da177e4c3f41 Linus Torvalds 2005-04-16 335
ef3ba87cb7c911 Christopher Obbard 2020-11-23 336 if (backing_file && ubd_dev->no_cow) {
f28169d2000177 Jeff Dike 2007-02-10 337 *error_out = "Can't specify both 'd' and a cow file";
f28169d2000177 Jeff Dike 2007-02-10 338 goto out;
f28169d2000177 Jeff Dike 2007-02-10 339 }
ef3ba87cb7c911 Christopher Obbard 2020-11-23 340
f28169d2000177 Jeff Dike 2007-02-10 341 err = 0;
ef3ba87cb7c911 Christopher Obbard 2020-11-23 342 ubd_dev->file = file;
7d314e346d6081 Paolo 'Blaisorblade' Giarrusso 2006-10-30 343 ubd_dev->cow.file = backing_file;
ef3ba87cb7c911 Christopher Obbard 2020-11-23 344 ubd_dev->serial = serial;
7d314e346d6081 Paolo 'Blaisorblade' Giarrusso 2006-10-30 345 ubd_dev->boot_openflags = flags;
^1da177e4c3f41 Linus Torvalds 2005-04-16 346 out:
d7fb2c3865ca0f Paolo 'Blaisorblade' Giarrusso 2006-10-30 347 mutex_unlock(&ubd_lock);
f28169d2000177 Jeff Dike 2007-02-10 348 return err;
^1da177e4c3f41 Linus Torvalds 2005-04-16 349 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 350
:::::: The code at line 247 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2
:::::: TO: Linus Torvalds <torvalds(a)ppc970.osdl.org>
:::::: CC: Linus Torvalds <torvalds(a)ppc970.osdl.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
3 months, 3 weeks
[asm-generic:clkdev 1/5] arch/mips/ar7/clock.c:428:28: error: array type has incomplete element type 'struct clkdev_table'
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/arnd/asm-generic.git clkdev
head: 3c150d2578b204c2e18c7ac6d967b43a614befbe
commit: 991cb086b5cfcd6ad953a64c6ce384bbd8595ded [1/5] mips: ar7: convert to clkdev_lookup
config: mips-ar7_defconfig (attached as .config)
compiler: mipsel-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/arnd/asm-generic.git/comm...
git remote add asm-generic https://git.kernel.org/pub/scm/linux/kernel/git/arnd/asm-generic.git
git fetch --no-tags asm-generic clkdev
git checkout 991cb086b5cfcd6ad953a64c6ce384bbd8595ded
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> arch/mips/ar7/clock.c:428:28: error: array type has incomplete element type 'struct clkdev_table'
428 | static struct clkdev_table clkdev_table[] = {
| ^~~~~~~~~~~~
In file included from arch/mips/ar7/clock.c:17:
>> include/linux/clkdev.h:28:3: error: field name not in record or union initializer
28 | .dev_id = d, \
| ^
arch/mips/ar7/clock.c:429:2: note: in expansion of macro 'CLKDEV_INIT'
429 | CLKDEV_INIT(NULL, "bus", &bus_clk),
| ^~~~~~~~~~~
include/linux/clkdev.h:28:3: note: (near initialization for 'clkdev_table')
28 | .dev_id = d, \
| ^
arch/mips/ar7/clock.c:429:2: note: in expansion of macro 'CLKDEV_INIT'
429 | CLKDEV_INIT(NULL, "bus", &bus_clk),
| ^~~~~~~~~~~
include/linux/clkdev.h:29:3: error: field name not in record or union initializer
29 | .con_id = n, \
| ^
arch/mips/ar7/clock.c:429:2: note: in expansion of macro 'CLKDEV_INIT'
429 | CLKDEV_INIT(NULL, "bus", &bus_clk),
| ^~~~~~~~~~~
include/linux/clkdev.h:29:3: note: (near initialization for 'clkdev_table')
29 | .con_id = n, \
| ^
arch/mips/ar7/clock.c:429:2: note: in expansion of macro 'CLKDEV_INIT'
429 | CLKDEV_INIT(NULL, "bus", &bus_clk),
| ^~~~~~~~~~~
include/linux/clkdev.h:30:3: error: field name not in record or union initializer
30 | .clk = c, \
| ^
arch/mips/ar7/clock.c:429:2: note: in expansion of macro 'CLKDEV_INIT'
429 | CLKDEV_INIT(NULL, "bus", &bus_clk),
| ^~~~~~~~~~~
include/linux/clkdev.h:30:3: note: (near initialization for 'clkdev_table')
30 | .clk = c, \
| ^
arch/mips/ar7/clock.c:429:2: note: in expansion of macro 'CLKDEV_INIT'
429 | CLKDEV_INIT(NULL, "bus", &bus_clk),
| ^~~~~~~~~~~
>> include/linux/clkdev.h:28:3: error: field name not in record or union initializer
28 | .dev_id = d, \
| ^
arch/mips/ar7/clock.c:431:2: note: in expansion of macro 'CLKDEV_INIT'
431 | CLKDEV_INIT("cpmac.0", "cpmac", &vbus_clk),
| ^~~~~~~~~~~
include/linux/clkdev.h:28:3: note: (near initialization for 'clkdev_table')
28 | .dev_id = d, \
| ^
arch/mips/ar7/clock.c:431:2: note: in expansion of macro 'CLKDEV_INIT'
431 | CLKDEV_INIT("cpmac.0", "cpmac", &vbus_clk),
| ^~~~~~~~~~~
include/linux/clkdev.h:29:3: error: field name not in record or union initializer
29 | .con_id = n, \
| ^
arch/mips/ar7/clock.c:431:2: note: in expansion of macro 'CLKDEV_INIT'
431 | CLKDEV_INIT("cpmac.0", "cpmac", &vbus_clk),
| ^~~~~~~~~~~
include/linux/clkdev.h:29:3: note: (near initialization for 'clkdev_table')
29 | .con_id = n, \
| ^
arch/mips/ar7/clock.c:431:2: note: in expansion of macro 'CLKDEV_INIT'
431 | CLKDEV_INIT("cpmac.0", "cpmac", &vbus_clk),
| ^~~~~~~~~~~
include/linux/clkdev.h:30:3: error: field name not in record or union initializer
30 | .clk = c, \
| ^
arch/mips/ar7/clock.c:431:2: note: in expansion of macro 'CLKDEV_INIT'
431 | CLKDEV_INIT("cpmac.0", "cpmac", &vbus_clk),
| ^~~~~~~~~~~
include/linux/clkdev.h:30:3: note: (near initialization for 'clkdev_table')
30 | .clk = c, \
| ^
arch/mips/ar7/clock.c:431:2: note: in expansion of macro 'CLKDEV_INIT'
431 | CLKDEV_INIT("cpmac.0", "cpmac", &vbus_clk),
| ^~~~~~~~~~~
>> include/linux/clkdev.h:28:3: error: field name not in record or union initializer
28 | .dev_id = d, \
| ^
arch/mips/ar7/clock.c:432:2: note: in expansion of macro 'CLKDEV_INIT'
432 | CLKDEV_INIT("cpmac.1", "cpmac", &vbus_clk),
| ^~~~~~~~~~~
include/linux/clkdev.h:28:3: note: (near initialization for 'clkdev_table')
28 | .dev_id = d, \
| ^
arch/mips/ar7/clock.c:432:2: note: in expansion of macro 'CLKDEV_INIT'
432 | CLKDEV_INIT("cpmac.1", "cpmac", &vbus_clk),
| ^~~~~~~~~~~
include/linux/clkdev.h:29:3: error: field name not in record or union initializer
29 | .con_id = n, \
| ^
arch/mips/ar7/clock.c:432:2: note: in expansion of macro 'CLKDEV_INIT'
432 | CLKDEV_INIT("cpmac.1", "cpmac", &vbus_clk),
| ^~~~~~~~~~~
include/linux/clkdev.h:29:3: note: (near initialization for 'clkdev_table')
29 | .con_id = n, \
| ^
arch/mips/ar7/clock.c:432:2: note: in expansion of macro 'CLKDEV_INIT'
432 | CLKDEV_INIT("cpmac.1", "cpmac", &vbus_clk),
| ^~~~~~~~~~~
include/linux/clkdev.h:30:3: error: field name not in record or union initializer
30 | .clk = c, \
| ^
arch/mips/ar7/clock.c:432:2: note: in expansion of macro 'CLKDEV_INIT'
432 | CLKDEV_INIT("cpmac.1", "cpmac", &vbus_clk),
| ^~~~~~~~~~~
include/linux/clkdev.h:30:3: note: (near initialization for 'clkdev_table')
30 | .clk = c, \
| ^
arch/mips/ar7/clock.c:432:2: note: in expansion of macro 'CLKDEV_INIT'
432 | CLKDEV_INIT("cpmac.1", "cpmac", &vbus_clk),
| ^~~~~~~~~~~
>> include/linux/clkdev.h:28:3: error: field name not in record or union initializer
28 | .dev_id = d, \
| ^
arch/mips/ar7/clock.c:433:2: note: in expansion of macro 'CLKDEV_INIT'
433 | CLKDEV_INIT(NULL, "cpu", &cpu_clk)
| ^~~~~~~~~~~
include/linux/clkdev.h:28:3: note: (near initialization for 'clkdev_table')
28 | .dev_id = d, \
| ^
arch/mips/ar7/clock.c:433:2: note: in expansion of macro 'CLKDEV_INIT'
433 | CLKDEV_INIT(NULL, "cpu", &cpu_clk)
| ^~~~~~~~~~~
include/linux/clkdev.h:29:3: error: field name not in record or union initializer
29 | .con_id = n, \
| ^
arch/mips/ar7/clock.c:433:2: note: in expansion of macro 'CLKDEV_INIT'
433 | CLKDEV_INIT(NULL, "cpu", &cpu_clk)
| ^~~~~~~~~~~
include/linux/clkdev.h:29:3: note: (near initialization for 'clkdev_table')
29 | .con_id = n, \
| ^
arch/mips/ar7/clock.c:433:2: note: in expansion of macro 'CLKDEV_INIT'
433 | CLKDEV_INIT(NULL, "cpu", &cpu_clk)
| ^~~~~~~~~~~
include/linux/clkdev.h:30:3: error: field name not in record or union initializer
30 | .clk = c, \
| ^
arch/mips/ar7/clock.c:433:2: note: in expansion of macro 'CLKDEV_INIT'
433 | CLKDEV_INIT(NULL, "cpu", &cpu_clk)
| ^~~~~~~~~~~
include/linux/clkdev.h:30:3: note: (near initialization for 'clkdev_table')
30 | .clk = c, \
| ^
arch/mips/ar7/clock.c:433:2: note: in expansion of macro 'CLKDEV_INIT'
433 | CLKDEV_INIT(NULL, "cpu", &cpu_clk)
| ^~~~~~~~~~~
>> include/linux/clkdev.h:27:2: error: expected '}' before '{' token
27 | { \
| ^
arch/mips/ar7/clock.c:434:2: note: in expansion of macro 'CLKDEV_INIT'
434 | CLKDEV_INIT(NULL, "dsp", &dsp_clk),
| ^~~~~~~~~~~
arch/mips/ar7/clock.c:428:45: note: to match this '{'
428 | static struct clkdev_table clkdev_table[] = {
| ^
In file included from include/linux/bits.h:22,
from include/linux/bitops.h:6,
from include/linux/kernel.h:12,
from arch/mips/ar7/clock.c:8:
arch/mips/ar7/clock.c: In function 'ar7_init_clocks':
>> include/linux/build_bug.h:16:51: error: bit-field '<anonymous>' width not an integer constant
16 | #define BUILD_BUG_ON_ZERO(e) ((int)(sizeof(struct { int:(-!!(e)); })))
| ^
include/linux/compiler.h:240:28: note: in expansion of macro 'BUILD_BUG_ON_ZERO'
240 | #define __must_be_array(a) BUILD_BUG_ON_ZERO(__same_type((a), &(a)[0]))
| ^~~~~~~~~~~~~~~~~
include/linux/kernel.h:42:59: note: in expansion of macro '__must_be_array'
42 | #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr))
| ^~~~~~~~~~~~~~~
arch/mips/ar7/clock.c:455:34: note: in expansion of macro 'ARRAY_SIZE'
455 | clkdev_add_table(&clkdev_table, ARRAY_SIZE(clkdev_table);
| ^~~~~~~~~~
>> arch/mips/ar7/clock.c:455:58: error: expected ')' before ';' token
455 | clkdev_add_table(&clkdev_table, ARRAY_SIZE(clkdev_table);
| ^
>> arch/mips/ar7/clock.c:455:59: error: expected ';' before '}' token
455 | clkdev_add_table(&clkdev_table, ARRAY_SIZE(clkdev_table);
| ^
| ;
456 | }
| ~
At top level:
arch/mips/ar7/clock.c:428:28: warning: 'clkdev_table' defined but not used [-Wunused-variable]
428 | static struct clkdev_table clkdev_table[] = {
| ^~~~~~~~~~~~
vim +428 arch/mips/ar7/clock.c
427
> 428 static struct clkdev_table clkdev_table[] = {
429 CLKDEV_INIT(NULL, "bus", &bus_clk),
430 /* cpmac and vbus share the same rate */
431 CLKDEV_INIT("cpmac.0", "cpmac", &vbus_clk),
432 CLKDEV_INIT("cpmac.1", "cpmac", &vbus_clk),
433 CLKDEV_INIT(NULL, "cpu", &cpu_clk)
434 CLKDEV_INIT(NULL, "dsp", &dsp_clk),
435 CLKDEV_INIT(NULL, "vbus", &vbus_clk),
436 };
437
438 void __init ar7_init_clocks(void)
439 {
440 switch (ar7_chip_id()) {
441 case AR7_CHIP_7100:
442 case AR7_CHIP_7200:
443 tnetd7200_init_clocks();
444 break;
445 case AR7_CHIP_7300:
446 dsp_clk.rate = tnetd7300_dsp_clock();
447 tnetd7300_init_clocks();
448 break;
449 default:
450 break;
451 }
452 /* adjust vbus clock rate */
453 vbus_clk.rate = bus_clk.rate / 2;
454
> 455 clkdev_add_table(&clkdev_table, ARRAY_SIZE(clkdev_table);
456 }
457
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
3 months, 3 weeks