[mkl-can-next:testing 5/28] net/can/j1939/transport.c:811:25: error: 'skcb' undeclared
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git testing
head: ca9280f6324bf09ec5d3667579f7dd3f7567e809
commit: a2ea50608a02ac48371a9fab0167c1b44457913e [5/28] can: j1939: j1939_session_tx_dat(): use consistent name se_skcb for session skb control buffer
config: i386-randconfig-a011-20210628 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git/co...
git remote add mkl-can-next https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git
git fetch --no-tags mkl-can-next testing
git checkout a2ea50608a02ac48371a9fab0167c1b44457913e
# save the attached .config to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from include/net/sock.h:46,
from include/linux/can/skb.h:17,
from net/can/j1939/transport.c:11:
net/can/j1939/transport.c: In function 'j1939_session_tx_dat':
>> net/can/j1939/transport.c:811:25: error: 'skcb' undeclared (first use in this function)
811 | __func__, session, skcb->offset,
| ^~~~
include/linux/netdevice.h:5255:36: note: in definition of macro 'netdev_level_once'
5255 | netdev_printk(level, dev, fmt, ##__VA_ARGS__); \
| ^~~~~~~~~~~
net/can/j1939/transport.c:809:4: note: in expansion of macro 'netdev_err_once'
809 | netdev_err_once(priv->ndev,
| ^~~~~~~~~~~~~~~
net/can/j1939/transport.c:811:25: note: each undeclared identifier is reported only once for each function it appears in
811 | __func__, session, skcb->offset,
| ^~~~
include/linux/netdevice.h:5255:36: note: in definition of macro 'netdev_level_once'
5255 | netdev_printk(level, dev, fmt, ##__VA_ARGS__); \
| ^~~~~~~~~~~
net/can/j1939/transport.c:809:4: note: in expansion of macro 'netdev_err_once'
809 | netdev_err_once(priv->ndev,
| ^~~~~~~~~~~~~~~
vim +/skcb +811 net/can/j1939/transport.c
9d71dd0c700999 The j1939 authors 2018-10-08 775
9d71dd0c700999 The j1939 authors 2018-10-08 776 static int j1939_session_tx_dat(struct j1939_session *session)
9d71dd0c700999 The j1939 authors 2018-10-08 777 {
9d71dd0c700999 The j1939 authors 2018-10-08 778 struct j1939_priv *priv = session->priv;
a2ea50608a02ac Marc Kleine-Budde 2021-05-21 779 struct j1939_sk_buff_cb *se_skcb;
9d71dd0c700999 The j1939 authors 2018-10-08 780 int offset, pkt_done, pkt_end;
9d71dd0c700999 The j1939 authors 2018-10-08 781 unsigned int len, pdelay;
9d71dd0c700999 The j1939 authors 2018-10-08 782 struct sk_buff *se_skb;
9d71dd0c700999 The j1939 authors 2018-10-08 783 const u8 *tpdat;
9d71dd0c700999 The j1939 authors 2018-10-08 784 int ret = 0;
9d71dd0c700999 The j1939 authors 2018-10-08 785 u8 dat[8];
9d71dd0c700999 The j1939 authors 2018-10-08 786
2030043e616cab Oleksij Rempel 2021-05-21 787 se_skb = j1939_session_skb_get_by_offset(session, session->pkt.tx * 7);
9d71dd0c700999 The j1939 authors 2018-10-08 788 if (!se_skb)
9d71dd0c700999 The j1939 authors 2018-10-08 789 return -ENOBUFS;
9d71dd0c700999 The j1939 authors 2018-10-08 790
a2ea50608a02ac Marc Kleine-Budde 2021-05-21 791 se_skcb = j1939_skb_to_cb(se_skb);
9d71dd0c700999 The j1939 authors 2018-10-08 792 tpdat = se_skb->data;
9d71dd0c700999 The j1939 authors 2018-10-08 793 ret = 0;
9d71dd0c700999 The j1939 authors 2018-10-08 794 pkt_done = 0;
9d71dd0c700999 The j1939 authors 2018-10-08 795 if (session->skcb.addr.type != J1939_ETP &&
9d71dd0c700999 The j1939 authors 2018-10-08 796 j1939_cb_is_broadcast(&session->skcb))
9d71dd0c700999 The j1939 authors 2018-10-08 797 pkt_end = session->pkt.total;
9d71dd0c700999 The j1939 authors 2018-10-08 798 else
9d71dd0c700999 The j1939 authors 2018-10-08 799 pkt_end = session->pkt.last;
9d71dd0c700999 The j1939 authors 2018-10-08 800
9d71dd0c700999 The j1939 authors 2018-10-08 801 while (session->pkt.tx < pkt_end) {
9d71dd0c700999 The j1939 authors 2018-10-08 802 dat[0] = session->pkt.tx - session->pkt.dpo + 1;
a2ea50608a02ac Marc Kleine-Budde 2021-05-21 803 offset = (session->pkt.tx * 7) - se_skcb->offset;
9d71dd0c700999 The j1939 authors 2018-10-08 804 len = se_skb->len - offset;
9d71dd0c700999 The j1939 authors 2018-10-08 805 if (len > 7)
9d71dd0c700999 The j1939 authors 2018-10-08 806 len = 7;
9d71dd0c700999 The j1939 authors 2018-10-08 807
cd3b3636c99fca Oleksij Rempel 2020-08-07 808 if (offset + len > se_skb->len) {
cd3b3636c99fca Oleksij Rempel 2020-08-07 809 netdev_err_once(priv->ndev,
cd3b3636c99fca Oleksij Rempel 2020-08-07 810 "%s: 0x%p: requested data outside of queued buffer: offset %i, len %i, pkt.tx: %i\n",
563289f4161c81 Marc Kleine-Budde 2021-06-16 @811 __func__, session, skcb->offset,
563289f4161c81 Marc Kleine-Budde 2021-06-16 812 se_skb->len , session->pkt.tx);
2030043e616cab Oleksij Rempel 2021-05-21 813 ret = -EOVERFLOW;
2030043e616cab Oleksij Rempel 2021-05-21 814 goto out_free;
cd3b3636c99fca Oleksij Rempel 2020-08-07 815 }
cd3b3636c99fca Oleksij Rempel 2020-08-07 816
cd3b3636c99fca Oleksij Rempel 2020-08-07 817 if (!len) {
cd3b3636c99fca Oleksij Rempel 2020-08-07 818 ret = -ENOBUFS;
cd3b3636c99fca Oleksij Rempel 2020-08-07 819 break;
cd3b3636c99fca Oleksij Rempel 2020-08-07 820 }
cd3b3636c99fca Oleksij Rempel 2020-08-07 821
9d71dd0c700999 The j1939 authors 2018-10-08 822 memcpy(&dat[1], &tpdat[offset], len);
9d71dd0c700999 The j1939 authors 2018-10-08 823 ret = j1939_tp_tx_dat(session, dat, len + 1);
9d71dd0c700999 The j1939 authors 2018-10-08 824 if (ret < 0) {
9d71dd0c700999 The j1939 authors 2018-10-08 825 /* ENOBUS == CAN interface TX queue is full */
9d71dd0c700999 The j1939 authors 2018-10-08 826 if (ret != -ENOBUFS)
9d71dd0c700999 The j1939 authors 2018-10-08 827 netdev_alert(priv->ndev,
9d71dd0c700999 The j1939 authors 2018-10-08 828 "%s: 0x%p: queue data error: %i\n",
9d71dd0c700999 The j1939 authors 2018-10-08 829 __func__, session, ret);
9d71dd0c700999 The j1939 authors 2018-10-08 830 break;
9d71dd0c700999 The j1939 authors 2018-10-08 831 }
9d71dd0c700999 The j1939 authors 2018-10-08 832
9d71dd0c700999 The j1939 authors 2018-10-08 833 session->last_txcmd = 0xff;
9d71dd0c700999 The j1939 authors 2018-10-08 834 pkt_done++;
9d71dd0c700999 The j1939 authors 2018-10-08 835 session->pkt.tx++;
9d71dd0c700999 The j1939 authors 2018-10-08 836 pdelay = j1939_cb_is_broadcast(&session->skcb) ? 50 :
9d71dd0c700999 The j1939 authors 2018-10-08 837 j1939_tp_packet_delay;
9d71dd0c700999 The j1939 authors 2018-10-08 838
9d71dd0c700999 The j1939 authors 2018-10-08 839 if (session->pkt.tx < session->pkt.total && pdelay) {
9d71dd0c700999 The j1939 authors 2018-10-08 840 j1939_tp_schedule_txtimer(session, pdelay);
9d71dd0c700999 The j1939 authors 2018-10-08 841 break;
9d71dd0c700999 The j1939 authors 2018-10-08 842 }
9d71dd0c700999 The j1939 authors 2018-10-08 843 }
9d71dd0c700999 The j1939 authors 2018-10-08 844
9d71dd0c700999 The j1939 authors 2018-10-08 845 if (pkt_done)
9d71dd0c700999 The j1939 authors 2018-10-08 846 j1939_tp_set_rxtimeout(session, 250);
9d71dd0c700999 The j1939 authors 2018-10-08 847
2030043e616cab Oleksij Rempel 2021-05-21 848 out_free:
2030043e616cab Oleksij Rempel 2021-05-21 849 if (ret)
2030043e616cab Oleksij Rempel 2021-05-21 850 kfree_skb(se_skb);
2030043e616cab Oleksij Rempel 2021-05-21 851 else
2030043e616cab Oleksij Rempel 2021-05-21 852 consume_skb(se_skb);
2030043e616cab Oleksij Rempel 2021-05-21 853
9d71dd0c700999 The j1939 authors 2018-10-08 854 return ret;
9d71dd0c700999 The j1939 authors 2018-10-08 855 }
9d71dd0c700999 The j1939 authors 2018-10-08 856
:::::: The code at line 811 was first introduced by commit
:::::: 563289f4161c81b55ce19c05cd8ba2737fb26240 can: j1939: fix checkpatch warnings
:::::: TO: Marc Kleine-Budde <mkl(a)pengutronix.de>
:::::: CC: Marc Kleine-Budde <mkl(a)pengutronix.de>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
10 months, 2 weeks
[linux-next:master 5384/13831] drivers/scsi/mpi3mr/mpi3mr_os.c:873 mpi3mr_update_tgtdev() error: we previously assumed 'mrioc->shost' could be null (see line 870)
by Dan Carpenter
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 3579aa488520feeda433ceca23ef4704bf8cd280
commit: 74e1f30a28680978fa9ddfb5360d0cc644cd348e [5384/13831] scsi: mpi3mr: Add EEDP DIF DIX support
config: i386-randconfig-m021-20210628 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
smatch warnings:
drivers/scsi/mpi3mr/mpi3mr_os.c:873 mpi3mr_update_tgtdev() error: we previously assumed 'mrioc->shost' could be null (see line 870)
vim +873 drivers/scsi/mpi3mr/mpi3mr_os.c
13ef29ea4aa065 Kashyap Desai 2021-05-20 800 static void mpi3mr_update_tgtdev(struct mpi3mr_ioc *mrioc,
13ef29ea4aa065 Kashyap Desai 2021-05-20 801 struct mpi3mr_tgt_dev *tgtdev, struct mpi3_device_page0 *dev_pg0)
13ef29ea4aa065 Kashyap Desai 2021-05-20 802 {
13ef29ea4aa065 Kashyap Desai 2021-05-20 803 u16 flags = 0;
13ef29ea4aa065 Kashyap Desai 2021-05-20 804 struct mpi3mr_stgt_priv_data *scsi_tgt_priv_data;
74e1f30a286809 Kashyap Desai 2021-05-20 805 u8 prot_mask = 0;
13ef29ea4aa065 Kashyap Desai 2021-05-20 806
13ef29ea4aa065 Kashyap Desai 2021-05-20 807 tgtdev->perst_id = le16_to_cpu(dev_pg0->persistent_id);
13ef29ea4aa065 Kashyap Desai 2021-05-20 808 tgtdev->dev_handle = le16_to_cpu(dev_pg0->dev_handle);
13ef29ea4aa065 Kashyap Desai 2021-05-20 809 tgtdev->dev_type = dev_pg0->device_form;
13ef29ea4aa065 Kashyap Desai 2021-05-20 810 tgtdev->encl_handle = le16_to_cpu(dev_pg0->enclosure_handle);
13ef29ea4aa065 Kashyap Desai 2021-05-20 811 tgtdev->parent_handle = le16_to_cpu(dev_pg0->parent_dev_handle);
13ef29ea4aa065 Kashyap Desai 2021-05-20 812 tgtdev->slot = le16_to_cpu(dev_pg0->slot);
13ef29ea4aa065 Kashyap Desai 2021-05-20 813 tgtdev->q_depth = le16_to_cpu(dev_pg0->queue_depth);
13ef29ea4aa065 Kashyap Desai 2021-05-20 814 tgtdev->wwid = le64_to_cpu(dev_pg0->wwid);
13ef29ea4aa065 Kashyap Desai 2021-05-20 815
13ef29ea4aa065 Kashyap Desai 2021-05-20 816 flags = le16_to_cpu(dev_pg0->flags);
13ef29ea4aa065 Kashyap Desai 2021-05-20 817 tgtdev->is_hidden = (flags & MPI3_DEVICE0_FLAGS_HIDDEN);
13ef29ea4aa065 Kashyap Desai 2021-05-20 818
13ef29ea4aa065 Kashyap Desai 2021-05-20 819 if (tgtdev->starget && tgtdev->starget->hostdata) {
13ef29ea4aa065 Kashyap Desai 2021-05-20 820 scsi_tgt_priv_data = (struct mpi3mr_stgt_priv_data *)
13ef29ea4aa065 Kashyap Desai 2021-05-20 821 tgtdev->starget->hostdata;
13ef29ea4aa065 Kashyap Desai 2021-05-20 822 scsi_tgt_priv_data->perst_id = tgtdev->perst_id;
13ef29ea4aa065 Kashyap Desai 2021-05-20 823 scsi_tgt_priv_data->dev_handle = tgtdev->dev_handle;
13ef29ea4aa065 Kashyap Desai 2021-05-20 824 scsi_tgt_priv_data->dev_type = tgtdev->dev_type;
13ef29ea4aa065 Kashyap Desai 2021-05-20 825 }
13ef29ea4aa065 Kashyap Desai 2021-05-20 826
13ef29ea4aa065 Kashyap Desai 2021-05-20 827 switch (tgtdev->dev_type) {
13ef29ea4aa065 Kashyap Desai 2021-05-20 828 case MPI3_DEVICE_DEVFORM_SAS_SATA:
13ef29ea4aa065 Kashyap Desai 2021-05-20 829 {
13ef29ea4aa065 Kashyap Desai 2021-05-20 830 struct mpi3_device0_sas_sata_format *sasinf =
13ef29ea4aa065 Kashyap Desai 2021-05-20 831 &dev_pg0->device_specific.sas_sata_format;
13ef29ea4aa065 Kashyap Desai 2021-05-20 832 u16 dev_info = le16_to_cpu(sasinf->device_info);
13ef29ea4aa065 Kashyap Desai 2021-05-20 833
13ef29ea4aa065 Kashyap Desai 2021-05-20 834 tgtdev->dev_spec.sas_sata_inf.dev_info = dev_info;
13ef29ea4aa065 Kashyap Desai 2021-05-20 835 tgtdev->dev_spec.sas_sata_inf.sas_address =
13ef29ea4aa065 Kashyap Desai 2021-05-20 836 le64_to_cpu(sasinf->sas_address);
13ef29ea4aa065 Kashyap Desai 2021-05-20 837 if ((dev_info & MPI3_SAS_DEVICE_INFO_DEVICE_TYPE_MASK) !=
13ef29ea4aa065 Kashyap Desai 2021-05-20 838 MPI3_SAS_DEVICE_INFO_DEVICE_TYPE_END_DEVICE)
13ef29ea4aa065 Kashyap Desai 2021-05-20 839 tgtdev->is_hidden = 1;
13ef29ea4aa065 Kashyap Desai 2021-05-20 840 else if (!(dev_info & (MPI3_SAS_DEVICE_INFO_STP_SATA_TARGET |
13ef29ea4aa065 Kashyap Desai 2021-05-20 841 MPI3_SAS_DEVICE_INFO_SSP_TARGET)))
13ef29ea4aa065 Kashyap Desai 2021-05-20 842 tgtdev->is_hidden = 1;
13ef29ea4aa065 Kashyap Desai 2021-05-20 843 break;
13ef29ea4aa065 Kashyap Desai 2021-05-20 844 }
8e653455547a47 Kashyap Desai 2021-05-20 845 case MPI3_DEVICE_DEVFORM_PCIE:
8e653455547a47 Kashyap Desai 2021-05-20 846 {
8e653455547a47 Kashyap Desai 2021-05-20 847 struct mpi3_device0_pcie_format *pcieinf =
8e653455547a47 Kashyap Desai 2021-05-20 848 &dev_pg0->device_specific.pcie_format;
8e653455547a47 Kashyap Desai 2021-05-20 849 u16 dev_info = le16_to_cpu(pcieinf->device_info);
8e653455547a47 Kashyap Desai 2021-05-20 850
8e653455547a47 Kashyap Desai 2021-05-20 851 tgtdev->dev_spec.pcie_inf.capb =
8e653455547a47 Kashyap Desai 2021-05-20 852 le32_to_cpu(pcieinf->capabilities);
8e653455547a47 Kashyap Desai 2021-05-20 853 tgtdev->dev_spec.pcie_inf.mdts = MPI3MR_DEFAULT_MDTS;
8e653455547a47 Kashyap Desai 2021-05-20 854 /* 2^12 = 4096 */
8e653455547a47 Kashyap Desai 2021-05-20 855 tgtdev->dev_spec.pcie_inf.pgsz = 12;
8e653455547a47 Kashyap Desai 2021-05-20 856 if (dev_pg0->access_status == MPI3_DEVICE0_ASTATUS_NO_ERRORS) {
8e653455547a47 Kashyap Desai 2021-05-20 857 tgtdev->dev_spec.pcie_inf.mdts =
8e653455547a47 Kashyap Desai 2021-05-20 858 le32_to_cpu(pcieinf->maximum_data_transfer_size);
8e653455547a47 Kashyap Desai 2021-05-20 859 tgtdev->dev_spec.pcie_inf.pgsz = pcieinf->page_size;
8e653455547a47 Kashyap Desai 2021-05-20 860 tgtdev->dev_spec.pcie_inf.reset_to =
8e653455547a47 Kashyap Desai 2021-05-20 861 pcieinf->controller_reset_to;
8e653455547a47 Kashyap Desai 2021-05-20 862 tgtdev->dev_spec.pcie_inf.abort_to =
8e653455547a47 Kashyap Desai 2021-05-20 863 pcieinf->nv_me_abort_to;
8e653455547a47 Kashyap Desai 2021-05-20 864 }
8e653455547a47 Kashyap Desai 2021-05-20 865 if (tgtdev->dev_spec.pcie_inf.mdts > (1024 * 1024))
8e653455547a47 Kashyap Desai 2021-05-20 866 tgtdev->dev_spec.pcie_inf.mdts = (1024 * 1024);
8e653455547a47 Kashyap Desai 2021-05-20 867 if ((dev_info & MPI3_DEVICE0_PCIE_DEVICE_INFO_TYPE_MASK) !=
8e653455547a47 Kashyap Desai 2021-05-20 868 MPI3_DEVICE0_PCIE_DEVICE_INFO_TYPE_NVME_DEVICE)
8e653455547a47 Kashyap Desai 2021-05-20 869 tgtdev->is_hidden = 1;
74e1f30a286809 Kashyap Desai 2021-05-20 @870 if (mrioc->shost)
^^^^^^^^^^^^
Check for NULL
74e1f30a286809 Kashyap Desai 2021-05-20 871 prot_mask = scsi_host_get_prot(mrioc->shost);
74e1f30a286809 Kashyap Desai 2021-05-20 872 if (prot_mask & SHOST_DIX_TYPE0_PROTECTION) {
74e1f30a286809 Kashyap Desai 2021-05-20 @873 scsi_host_set_prot(mrioc->shost, prot_mask & 0x77);
^^^^^^^^^^^^
Do we need to check here as well?
74e1f30a286809 Kashyap Desai 2021-05-20 874 ioc_info(mrioc,
74e1f30a286809 Kashyap Desai 2021-05-20 875 "%s : Disabling DIX0 prot capability\n", __func__);
74e1f30a286809 Kashyap Desai 2021-05-20 876 ioc_info(mrioc,
74e1f30a286809 Kashyap Desai 2021-05-20 877 "because HBA does not support DIX0 operation on NVME drives\n");
74e1f30a286809 Kashyap Desai 2021-05-20 878 }
8e653455547a47 Kashyap Desai 2021-05-20 879 break;
8e653455547a47 Kashyap Desai 2021-05-20 880 }
13ef29ea4aa065 Kashyap Desai 2021-05-20 881 case MPI3_DEVICE_DEVFORM_VD:
13ef29ea4aa065 Kashyap Desai 2021-05-20 882 {
13ef29ea4aa065 Kashyap Desai 2021-05-20 883 struct mpi3_device0_vd_format *vdinf =
13ef29ea4aa065 Kashyap Desai 2021-05-20 884 &dev_pg0->device_specific.vd_format;
13ef29ea4aa065 Kashyap Desai 2021-05-20 885
13ef29ea4aa065 Kashyap Desai 2021-05-20 886 tgtdev->dev_spec.vol_inf.state = vdinf->vd_state;
13ef29ea4aa065 Kashyap Desai 2021-05-20 887 if (vdinf->vd_state == MPI3_DEVICE0_VD_STATE_OFFLINE)
13ef29ea4aa065 Kashyap Desai 2021-05-20 888 tgtdev->is_hidden = 1;
13ef29ea4aa065 Kashyap Desai 2021-05-20 889 break;
13ef29ea4aa065 Kashyap Desai 2021-05-20 890 }
13ef29ea4aa065 Kashyap Desai 2021-05-20 891 default:
13ef29ea4aa065 Kashyap Desai 2021-05-20 892 break;
13ef29ea4aa065 Kashyap Desai 2021-05-20 893 }
13ef29ea4aa065 Kashyap Desai 2021-05-20 894 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
10 months, 3 weeks
Re: [PATCH 2/3] vDPA/ifcvf: implement management netlink framework for ifcvf
by kernel test robot
Hi Zhu,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v5.13 next-20210630]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Zhu-Lingshan/vDPA-ifcvf-implemen...
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 007b350a58754a93ca9fe50c498cc27780171153
config: x86_64-randconfig-a015-20210630 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 8d21d5472501460933e78aead04cf59579025ba4)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://github.com/0day-ci/linux/commit/7ea782fbd896e1a5b3c01b29f49297737...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Zhu-Lingshan/vDPA-ifcvf-implement-management-netlink-framework/20210630-162940
git checkout 7ea782fbd896e1a5b3c01b29f4929773748a525f
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/vdpa/ifcvf/ifcvf_main.c:612:14: warning: variable 'adapter' is uninitialized when used here [-Wuninitialized]
put_device(&adapter->vdpa.dev);
^~~~~~~
drivers/vdpa/ifcvf/ifcvf_main.c:546:31: note: initialize the variable 'adapter' to silence this warning
struct ifcvf_adapter *adapter;
^
= NULL
1 warning generated.
vim +/adapter +612 drivers/vdpa/ifcvf/ifcvf_main.c
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 541
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 542 static int ifcvf_probe(struct pci_dev *pdev, const struct pci_device_id *id)
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 543 {
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 544 struct ifcvf_vdpa_mgmt_dev *ifcvf_mgmt_dev;
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 545 struct device *dev = &pdev->dev;
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 546 struct ifcvf_adapter *adapter;
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 547 u32 dev_type;
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 548 int ret;
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 549
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 550 ifcvf_mgmt_dev = kzalloc(sizeof(struct ifcvf_vdpa_mgmt_dev), GFP_KERNEL);
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 551 if (!ifcvf_mgmt_dev) {
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 552 IFCVF_ERR(pdev, "Failed to alloc memory for the vDPA management device\n");
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 553 return -ENOMEM;
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 554 }
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 555
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 556 dev_type = get_dev_type(pdev);
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 557 switch (dev_type) {
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 558 case VIRTIO_ID_NET:
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 559 ifcvf_mgmt_dev->mdev.id_table = id_table_net;
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 560 break;
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 561 case VIRTIO_ID_BLOCK:
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 562 ifcvf_mgmt_dev->mdev.id_table = id_table_blk;
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 563 break;
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 564 default:
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 565 IFCVF_ERR(pdev, "VIRTIO ID %u not supported\n", dev_type);
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 566 ret = -EOPNOTSUPP;
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 567 goto err;
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 568 }
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 569
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 570 ifcvf_mgmt_dev->mdev.ops = &ifcvf_vdpa_mgmt_dev_ops;
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 571 ifcvf_mgmt_dev->mdev.device = dev;
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 572 ifcvf_mgmt_dev->pdev = pdev;
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 573
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 574 ret = pcim_enable_device(pdev);
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 575 if (ret) {
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 576 IFCVF_ERR(pdev, "Failed to enable device\n");
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 577 goto err;
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 578 }
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 579
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 580 ret = pcim_iomap_regions(pdev, BIT(0) | BIT(2) | BIT(4),
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 581 IFCVF_DRIVER_NAME);
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 582 if (ret) {
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 583 IFCVF_ERR(pdev, "Failed to request MMIO region\n");
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 584 goto err;
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 585 }
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 586
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 587 ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64));
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 588 if (ret) {
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 589 IFCVF_ERR(pdev, "No usable DMA configuration\n");
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 590 goto err;
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 591 }
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 592
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 593 ret = devm_add_action_or_reset(dev, ifcvf_free_irq_vectors, pdev);
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 594 if (ret) {
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 595 IFCVF_ERR(pdev,
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 596 "Failed for adding devres for freeing irq vectors\n");
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 597 goto err;
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 598 }
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 599
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 600 pci_set_master(pdev);
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 601
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 602 ret = vdpa_mgmtdev_register(&ifcvf_mgmt_dev->mdev);
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 603 if (ret) {
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 604 IFCVF_ERR(pdev,
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 605 "Failed to initialize the management interfaces\n");
5a2414bc454e89 drivers/virtio/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2020-03-26 606 goto err;
5a2414bc454e89 drivers/virtio/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2020-03-26 607 }
5a2414bc454e89 drivers/virtio/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2020-03-26 608
5a2414bc454e89 drivers/virtio/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2020-03-26 609 return 0;
5a2414bc454e89 drivers/virtio/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2020-03-26 610
5a2414bc454e89 drivers/virtio/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2020-03-26 611 err:
5a2414bc454e89 drivers/virtio/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2020-03-26 @612 put_device(&adapter->vdpa.dev);
7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 613 kfree(ifcvf_mgmt_dev);
5a2414bc454e89 drivers/virtio/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2020-03-26 614 return ret;
5a2414bc454e89 drivers/virtio/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2020-03-26 615 }
5a2414bc454e89 drivers/virtio/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2020-03-26 616
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
10 months, 4 weeks
Online Assignment Help
by lucibranden0590＠gmail.com
Online Assignment Help (https://www.allassignmenthelp.com/uk/) affiliations award students to score boundless etchings in their undertaking comfort and help them with refreshing their game-plan. Submitting persuading schoolwork each time is astounding contemplating some unavoidable conditions.
10 months, 4 weeks
arch/arm64/include/asm/cpufeature.h:273:2: warning: initialized field overwritten
by kernel test robot
Hi Marc,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 007b350a58754a93ca9fe50c498cc27780171153
commit: ed888cb0d1ebce69f12794e89fbd5e2c86d40b8d arm64: Allow CPUs unffected by ARM erratum 1418040 to come in late
date: 10 months ago
config: arm64-buildonly-randconfig-r002-20210630 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit...
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout ed888cb0d1ebce69f12794e89fbd5e2c86d40b8d
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
arch/arm64/kernel/cpu_errata.c:295:13: warning: no previous prototype for 'arm64_update_smccc_conduit' [-Wmissing-prototypes]
295 | void __init arm64_update_smccc_conduit(struct alt_instr *alt,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
arch/arm64/kernel/cpu_errata.c:317:13: warning: no previous prototype for 'arm64_enable_wa2_handling' [-Wmissing-prototypes]
317 | void __init arm64_enable_wa2_handling(struct alt_instr *alt,
| ^~~~~~~~~~~~~~~~~~~~~~~~~
arch/arm64/kernel/cpu_errata.c:486:13: warning: initialized field overwritten [-Woverride-init]
486 | .matches = is_affected_midr_range, \
| ^~~~~~~~~~~~~~~~~~~~~~
arch/arm64/kernel/cpu_errata.c:498:2: note: in expansion of macro 'CAP_MIDR_RANGE'
498 | CAP_MIDR_RANGE(model, v_min, r_min, v_max, r_max)
| ^~~~~~~~~~~~~~
arch/arm64/kernel/cpu_errata.c:506:2: note: in expansion of macro 'ERRATA_MIDR_RANGE'
506 | ERRATA_MIDR_RANGE(m, var, r_min, var, r_max)
| ^~~~~~~~~~~~~~~~~
arch/arm64/kernel/cpu_errata.c:747:3: note: in expansion of macro 'ERRATA_MIDR_REV_RANGE'
747 | ERRATA_MIDR_REV_RANGE(MIDR_CORTEX_A53, 0, 0, 4),
| ^~~~~~~~~~~~~~~~~~~~~
arch/arm64/kernel/cpu_errata.c:486:13: note: (near initialization for 'erratum_843419_list[0].matches')
486 | .matches = is_affected_midr_range, \
| ^~~~~~~~~~~~~~~~~~~~~~
arch/arm64/kernel/cpu_errata.c:498:2: note: in expansion of macro 'CAP_MIDR_RANGE'
498 | CAP_MIDR_RANGE(model, v_min, r_min, v_max, r_max)
| ^~~~~~~~~~~~~~
arch/arm64/kernel/cpu_errata.c:506:2: note: in expansion of macro 'ERRATA_MIDR_RANGE'
506 | ERRATA_MIDR_RANGE(m, var, r_min, var, r_max)
| ^~~~~~~~~~~~~~~~~
arch/arm64/kernel/cpu_errata.c:747:3: note: in expansion of macro 'ERRATA_MIDR_REV_RANGE'
747 | ERRATA_MIDR_REV_RANGE(MIDR_CORTEX_A53, 0, 0, 4),
| ^~~~~~~~~~~~~~~~~~~~~
arch/arm64/kernel/cpu_errata.c:486:13: warning: initialized field overwritten [-Woverride-init]
486 | .matches = is_affected_midr_range, \
| ^~~~~~~~~~~~~~~~~~~~~~
arch/arm64/kernel/cpu_errata.c:498:2: note: in expansion of macro 'CAP_MIDR_RANGE'
498 | CAP_MIDR_RANGE(model, v_min, r_min, v_max, r_max)
| ^~~~~~~~~~~~~~
arch/arm64/kernel/cpu_errata.c:510:2: note: in expansion of macro 'ERRATA_MIDR_RANGE'
510 | ERRATA_MIDR_RANGE(model, var, rev, var, rev)
| ^~~~~~~~~~~~~~~~~
arch/arm64/kernel/cpu_errata.c:753:3: note: in expansion of macro 'ERRATA_MIDR_REV'
753 | ERRATA_MIDR_REV(MIDR_BRAHMA_B53, 0, 0),
| ^~~~~~~~~~~~~~~
arch/arm64/kernel/cpu_errata.c:486:13: note: (near initialization for 'erratum_843419_list[1].matches')
486 | .matches = is_affected_midr_range, \
| ^~~~~~~~~~~~~~~~~~~~~~
arch/arm64/kernel/cpu_errata.c:498:2: note: in expansion of macro 'CAP_MIDR_RANGE'
498 | CAP_MIDR_RANGE(model, v_min, r_min, v_max, r_max)
| ^~~~~~~~~~~~~~
arch/arm64/kernel/cpu_errata.c:510:2: note: in expansion of macro 'ERRATA_MIDR_RANGE'
510 | ERRATA_MIDR_RANGE(model, var, rev, var, rev)
| ^~~~~~~~~~~~~~~~~
arch/arm64/kernel/cpu_errata.c:753:3: note: in expansion of macro 'ERRATA_MIDR_REV'
753 | ERRATA_MIDR_REV(MIDR_BRAHMA_B53, 0, 0),
| ^~~~~~~~~~~~~~~
In file included from arch/arm64/include/asm/ptrace.h:11,
from arch/arm64/include/asm/irqflags.h:10,
from include/linux/irqflags.h:16,
from include/linux/rcupdate.h:26,
from include/linux/rculist.h:11,
from include/linux/pid.h:5,
from include/linux/sched.h:14,
from include/linux/ratelimit.h:6,
from include/linux/dev_printk.h:16,
from include/linux/device.h:15,
from include/linux/node.h:18,
from include/linux/cpu.h:17,
from arch/arm64/kernel/cpu_errata.c:10:
>> arch/arm64/include/asm/cpufeature.h:273:2: warning: initialized field overwritten [-Woverride-init]
273 | (ARM64_CPUCAP_SCOPE_LOCAL_CPU | \
| ^
arch/arm64/kernel/cpu_errata.c:918:11: note: in expansion of macro 'ARM64_CPUCAP_WEAK_LOCAL_CPU_FEATURE'
918 | .type = ARM64_CPUCAP_WEAK_LOCAL_CPU_FEATURE,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/arm64/include/asm/cpufeature.h:273:2: note: (near initialization for 'arm64_errata[9].type')
273 | (ARM64_CPUCAP_SCOPE_LOCAL_CPU | \
| ^
arch/arm64/kernel/cpu_errata.c:918:11: note: in expansion of macro 'ARM64_CPUCAP_WEAK_LOCAL_CPU_FEATURE'
918 | .type = ARM64_CPUCAP_WEAK_LOCAL_CPU_FEATURE,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/arm64/kernel/cpu_errata.c:942:14: warning: initialized field overwritten [-Woverride-init]
942 | .matches = needs_tx2_tvm_workaround,
| ^~~~~~~~~~~~~~~~~~~~~~~~
arch/arm64/kernel/cpu_errata.c:942:14: note: (near initialization for 'arm64_errata[11].matches')
vim +273 arch/arm64/include/asm/cpufeature.h
5b4747c5dce7a8 Suzuki K Poulose 2018-03-26 249
5b4747c5dce7a8 Suzuki K Poulose 2018-03-26 250 /*
5b4747c5dce7a8 Suzuki K Poulose 2018-03-26 251 * CPU errata workarounds that need to be enabled at boot time if one or
5b4747c5dce7a8 Suzuki K Poulose 2018-03-26 252 * more CPUs in the system requires it. When one of these capabilities
5b4747c5dce7a8 Suzuki K Poulose 2018-03-26 253 * has been enabled, it is safe to allow any CPU to boot that doesn't
5b4747c5dce7a8 Suzuki K Poulose 2018-03-26 254 * require the workaround. However, it is not safe if a "late" CPU
5b4747c5dce7a8 Suzuki K Poulose 2018-03-26 255 * requires a workaround and the system hasn't enabled it already.
5b4747c5dce7a8 Suzuki K Poulose 2018-03-26 256 */
5b4747c5dce7a8 Suzuki K Poulose 2018-03-26 257 #define ARM64_CPUCAP_LOCAL_CPU_ERRATUM \
5b4747c5dce7a8 Suzuki K Poulose 2018-03-26 258 (ARM64_CPUCAP_SCOPE_LOCAL_CPU | ARM64_CPUCAP_OPTIONAL_FOR_LATE_CPU)
5b4747c5dce7a8 Suzuki K Poulose 2018-03-26 259 /*
5b4747c5dce7a8 Suzuki K Poulose 2018-03-26 260 * CPU feature detected at boot time based on system-wide value of a
5b4747c5dce7a8 Suzuki K Poulose 2018-03-26 261 * feature. It is safe for a late CPU to have this feature even though
ca7f686ac9fe87 Will Deacon 2018-06-15 262 * the system hasn't enabled it, although the feature will not be used
5b4747c5dce7a8 Suzuki K Poulose 2018-03-26 263 * by Linux in this case. If the system has enabled this feature already,
5b4747c5dce7a8 Suzuki K Poulose 2018-03-26 264 * then every late CPU must have it.
5b4747c5dce7a8 Suzuki K Poulose 2018-03-26 265 */
5b4747c5dce7a8 Suzuki K Poulose 2018-03-26 266 #define ARM64_CPUCAP_SYSTEM_FEATURE \
5b4747c5dce7a8 Suzuki K Poulose 2018-03-26 267 (ARM64_CPUCAP_SCOPE_SYSTEM | ARM64_CPUCAP_PERMITTED_FOR_LATE_CPU)
5c137714dd8cae Suzuki K Poulose 2018-03-26 268 /*
5c137714dd8cae Suzuki K Poulose 2018-03-26 269 * CPU feature detected at boot time based on feature of one or more CPUs.
5c137714dd8cae Suzuki K Poulose 2018-03-26 270 * All possible conflicts for a late CPU are ignored.
5c137714dd8cae Suzuki K Poulose 2018-03-26 271 */
5c137714dd8cae Suzuki K Poulose 2018-03-26 272 #define ARM64_CPUCAP_WEAK_LOCAL_CPU_FEATURE \
5c137714dd8cae Suzuki K Poulose 2018-03-26 @273 (ARM64_CPUCAP_SCOPE_LOCAL_CPU | \
5c137714dd8cae Suzuki K Poulose 2018-03-26 274 ARM64_CPUCAP_OPTIONAL_FOR_LATE_CPU | \
5c137714dd8cae Suzuki K Poulose 2018-03-26 275 ARM64_CPUCAP_PERMITTED_FOR_LATE_CPU)
5b4747c5dce7a8 Suzuki K Poulose 2018-03-26 276
:::::: The code at line 273 was first introduced by commit
:::::: 5c137714dd8cae464dbd5f028c07af149e6d09fc arm64: capabilities: Introduce weak features based on local CPU
:::::: TO: Suzuki K Poulose <suzuki.poulose(a)arm.com>
:::::: CC: Will Deacon <will.deacon(a)arm.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
10 months, 4 weeks
[linux-stable-rc:linux-4.4.y 1401/1774] drivers/spi/spi-s3c24xx-fiq.S:52: Error: bad instruction `subsne pc,lr,#4'
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.4.y
head: 38c92ba3580f0d00e57a55caf8f880aa1a0f2a50
commit: 10a0c6746644a4fcaf1ffe2916387e17ba059517 [1401/1774] ARM: s3c: fix fiq for clang IAS
config: arm-randconfig-r034-20210630 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 7.5.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gi...
git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
git fetch --no-tags linux-stable-rc linux-4.4.y
git checkout 10a0c6746644a4fcaf1ffe2916387e17ba059517
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-7.5.0 make.cross O=build_dir ARCH=arm SHELL=/bin/bash drivers/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
drivers/spi/spi-s3c24xx-fiq.S: Assembler messages:
>> drivers/spi/spi-s3c24xx-fiq.S:52: Error: bad instruction `subsne pc,lr,#4'
drivers/spi/spi-s3c24xx-fiq.S:78: Error: bad instruction `subsne pc,lr,#4'
drivers/spi/spi-s3c24xx-fiq.S:102: Error: bad instruction `subsne pc,lr,#4'
vim +52 drivers/spi/spi-s3c24xx-fiq.S
21
22 .text
23
24 @ entry to these routines is as follows, with the register names
25 @ defined in fiq.h so that they can be shared with the C files which
26 @ setup the calling registers.
27 @
28 @ fiq_rirq The base of the IRQ registers to find S3C2410_SRCPND
29 @ fiq_rtmp Temporary register to hold tx/rx data
30 @ fiq_rspi The base of the SPI register block
31 @ fiq_rtx The tx buffer pointer
32 @ fiq_rrx The rx buffer pointer
33 @ fiq_rcount The number of bytes to move
34
35 @ each entry starts with a word entry of how long it is
36 @ and an offset to the irq acknowledgment word
37
38 ENTRY(s3c24xx_spi_fiq_rx)
39 .word fiq_rx_end - fiq_rx_start
40 .word fiq_rx_irq_ack - fiq_rx_start
41 fiq_rx_start:
42 ldr fiq_rtmp, fiq_rx_irq_ack
43 str fiq_rtmp, [ fiq_rirq, # S3C2410_SRCPND - S3C24XX_VA_IRQ ]
44
45 ldrb fiq_rtmp, [ fiq_rspi, # S3C2410_SPRDAT ]
46 strb fiq_rtmp, [ fiq_rrx ], #1
47
48 mov fiq_rtmp, #0xff
49 strb fiq_rtmp, [ fiq_rspi, # S3C2410_SPTDAT ]
50
51 subs fiq_rcount, fiq_rcount, #1
> 52 subsne pc, lr, #4 @@ return, still have work to do
53
54 @@ set IRQ controller so that next op will trigger IRQ
55 mov fiq_rtmp, #0
56 str fiq_rtmp, [ fiq_rirq, # S3C2410_INTMOD - S3C24XX_VA_IRQ ]
57 subs pc, lr, #4
58
59 fiq_rx_irq_ack:
60 .word 0
61 fiq_rx_end:
62
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
10 months, 4 weeks
