Re: [PATCH] decnet: af_decnet: pmc should not be referenced when it's NULL
by kernel test robot
Hi,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on net-next/master]
[also build test ERROR on net/master linus/master v5.13-rc7 next-20210622]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/13145886936-163-com/decnet-af_de...
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 38f75922a6905b010f597fc70dbb5db28398728e
config: ia64-randconfig-r005-20210622 (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/684dced1c59e94a4ef160061073d0cb92...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review 13145886936-163-com/decnet-af_decnet-pmc-should-not-be-referenced-when-it-s-NULL/20210623-113728
git checkout 684dced1c59e94a4ef160061073d0cb928b370e4
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
net/decnet/af_decnet.c: In function 'dn_ioctl':
>> net/decnet/af_decnet.c:1240:3: error: expected expression before '}' token
1240 | }
| ^
vim +1240 net/decnet/af_decnet.c
^1da177e4c3f41 Linus Torvalds 2005-04-16 1203
^1da177e4c3f41 Linus Torvalds 2005-04-16 1204 static int dn_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg)
^1da177e4c3f41 Linus Torvalds 2005-04-16 1205 {
^1da177e4c3f41 Linus Torvalds 2005-04-16 1206 struct sock *sk = sock->sk;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1207 struct dn_scp *scp = DN_SK(sk);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1208 int err = -EOPNOTSUPP;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1209 long amount = 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1210 struct sk_buff *skb;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1211 int val;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1212
684dced1c59e94 gushengxian 2021-06-22 1213 switch (cmd) {
^1da177e4c3f41 Linus Torvalds 2005-04-16 1214 case SIOCGIFADDR:
^1da177e4c3f41 Linus Torvalds 2005-04-16 1215 case SIOCSIFADDR:
^1da177e4c3f41 Linus Torvalds 2005-04-16 1216 return dn_dev_ioctl(cmd, (void __user *)arg);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1217
^1da177e4c3f41 Linus Torvalds 2005-04-16 1218 case SIOCATMARK:
^1da177e4c3f41 Linus Torvalds 2005-04-16 1219 lock_sock(sk);
b03efcfb218028 David S. Miller 2005-07-08 1220 val = !skb_queue_empty(&scp->other_receive_queue);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1221 if (scp->state != DN_RUN)
^1da177e4c3f41 Linus Torvalds 2005-04-16 1222 val = -ENOTCONN;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1223 release_sock(sk);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1224 return val;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1225
^1da177e4c3f41 Linus Torvalds 2005-04-16 1226 case TIOCOUTQ:
31e6d363abcd0d Eric Dumazet 2009-06-17 1227 amount = sk->sk_sndbuf - sk_wmem_alloc_get(sk);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1228 if (amount < 0)
^1da177e4c3f41 Linus Torvalds 2005-04-16 1229 amount = 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1230 err = put_user(amount, (int __user *)arg);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1231 break;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1232
^1da177e4c3f41 Linus Torvalds 2005-04-16 1233 case TIOCINQ:
^1da177e4c3f41 Linus Torvalds 2005-04-16 1234 lock_sock(sk);
e57c624be8f99e Hannes Eder 2009-02-25 1235 skb = skb_peek(&scp->other_receive_queue);
e57c624be8f99e Hannes Eder 2009-02-25 1236 if (skb) {
^1da177e4c3f41 Linus Torvalds 2005-04-16 1237 amount = skb->len;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1238 } else {
bec571ec762a4c David S. Miller 2009-05-28 1239 skb_queue_walk(&sk->sk_receive_queue, skb)
^1da177e4c3f41 Linus Torvalds 2005-04-16 @1240 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 1241 release_sock(sk);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1242 err = put_user(amount, (int __user *)arg);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1243 break;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1244
^1da177e4c3f41 Linus Torvalds 2005-04-16 1245 default:
b5e5fa5e093e42 Christoph Hellwig 2006-01-03 1246 err = -ENOIOCTLCMD;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1247 break;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1248 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 1249
^1da177e4c3f41 Linus Torvalds 2005-04-16 1250 return err;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1251 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 1252
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 2 months
[intel-linux-intel-lts:4.19/android_r 18600/23451] drivers/usb/host/xhci-dbgcap.c:191:6: warning: no previous prototype for 'xhci_dbc_flush_requests'
by kernel test robot
Hi Prabhat,
FYI, the error/warning still remains.
tree: https://github.com/intel/linux-intel-lts.git 4.19/android_r
head: 71dbe8b787e34f3ce300217fc6ca5a2ec4aef447
commit: b88d999a5b9ae9022e12e1a5810b12b21cb77996 [18600/23451] usb: xhci: dbc: make DbC modular, introducing dbc_function structure
config: h8300-randconfig-r031-20210622 (attached as .config)
compiler: h8300-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel/linux-intel-lts/commit/b88d999a5b9ae9022e12e1a58...
git remote add intel-linux-intel-lts https://github.com/intel/linux-intel-lts.git
git fetch --no-tags intel-linux-intel-lts 4.19/android_r
git checkout b88d999a5b9ae9022e12e1a5810b12b21cb77996
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=h8300
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
In file included from include/linux/string.h:6,
from include/linux/dma-mapping.h:6,
from drivers/usb/host/xhci-dbgcap.c:9:
include/linux/scatterlist.h: In function 'sg_set_buf':
include/asm-generic/page.h:93:50: warning: ordered comparison of pointer with null pointer [-Wextra]
93 | #define virt_addr_valid(kaddr) (((void *)(kaddr) >= (void *)PAGE_OFFSET) && \
| ^~
include/linux/compiler.h:77:42: note: in definition of macro 'unlikely'
77 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
include/linux/scatterlist.h:143:2: note: in expansion of macro 'BUG_ON'
143 | BUG_ON(!virt_addr_valid(buf));
| ^~~~~~
include/linux/scatterlist.h:143:10: note: in expansion of macro 'virt_addr_valid'
143 | BUG_ON(!virt_addr_valid(buf));
| ^~~~~~~~~~~~~~~
include/linux/dma-mapping.h: In function 'dma_map_resource':
include/asm-generic/page.h:91:32: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
91 | #define pfn_valid(pfn) ((pfn) >= ARCH_PFN_OFFSET && ((pfn) - ARCH_PFN_OFFSET) < max_mapnr)
| ^~
include/linux/compiler.h:77:42: note: in definition of macro 'unlikely'
77 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
include/linux/dma-mapping.h:329:2: note: in expansion of macro 'BUG_ON'
329 | BUG_ON(pfn_valid(PHYS_PFN(phys_addr)));
| ^~~~~~
include/linux/dma-mapping.h:329:9: note: in expansion of macro 'pfn_valid'
329 | BUG_ON(pfn_valid(PHYS_PFN(phys_addr)));
| ^~~~~~~~~
drivers/usb/host/xhci-dbgcap.c: In function 'xhci_dbc_populate_strings':
drivers/usb/host/xhci-dbgcap.c:50:36: warning: taking address of packed member of 'struct usb_string_descriptor' may result in an unaligned pointer value [-Waddress-of-packed-member]
50 | UTF16_LITTLE_ENDIAN, (wchar_t *)s_desc->wData,
| ^~~~~~
drivers/usb/host/xhci-dbgcap.c:61:36: warning: taking address of packed member of 'struct usb_string_descriptor' may result in an unaligned pointer value [-Waddress-of-packed-member]
61 | UTF16_LITTLE_ENDIAN, (wchar_t *)s_desc->wData,
| ^~~~~~
drivers/usb/host/xhci-dbgcap.c:73:36: warning: taking address of packed member of 'struct usb_string_descriptor' may result in an unaligned pointer value [-Waddress-of-packed-member]
73 | UTF16_LITTLE_ENDIAN, (wchar_t *)s_desc->wData,
| ^~~~~~
drivers/usb/host/xhci-dbgcap.c: At top level:
>> drivers/usb/host/xhci-dbgcap.c:191:6: warning: no previous prototype for 'xhci_dbc_flush_requests' [-Wmissing-prototypes]
191 | void xhci_dbc_flush_requests(struct xhci_dbc *dbc)
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/usb/host/xhci-dbgcap.c: In function 'xhci_dbc_handle_events':
drivers/usb/host/xhci-dbgcap.c:794:8: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
794 | int ret;
| ^~~
drivers/usb/host/xhci-dbgcap.c:18: warning: cannot understand function prototype: 'struct dbc_function *dbc_registered_func; '
vim +/xhci_dbc_flush_requests +191 drivers/usb/host/xhci-dbgcap.c
189
190
> 191 void xhci_dbc_flush_requests(struct xhci_dbc *dbc)
192 {
193 xhci_dbc_flush_endpoint_requests(&dbc->eps[BULK_OUT]);
194 xhci_dbc_flush_endpoint_requests(&dbc->eps[BULK_IN]);
195 }
196 EXPORT_SYMBOL_GPL(xhci_dbc_flush_requests);
197
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 2 months
[chrome-os:chromeos-5.10 5/5] drivers/gpu/arm/valhall/backend/gpu/mali_kbase_irq_linux.c:180:13: warning: no previous prototype for 'kbase_gpu_irq_test_handler'
by kernel test robot
tree: https://chromium.googlesource.com/chromiumos/third_party/kernel chromeos-5.10
head: 10cd017481f1fa5fd8308956be32117a4103519f
commit: 10cd017481f1fa5fd8308956be32117a4103519f [5/5] CHROMIUM: MALI: Include kutf modules
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git remote add chrome-os https://chromium.googlesource.com/chromiumos/third_party/kernel
git fetch --no-tags chrome-os chromeos-5.10
git checkout 10cd017481f1fa5fd8308956be32117a4103519f
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
cc1: warning: drivers/gpu/arm/valhall/../../../base: No such file or directory [-Wmissing-include-dirs]
cc1: warning: drivers/gpu/arm/valhall/../../../base: No such file or directory [-Wmissing-include-dirs]
>> drivers/gpu/arm/valhall/backend/gpu/mali_kbase_irq_linux.c:180:13: warning: no previous prototype for 'kbase_gpu_irq_test_handler' [-Wmissing-prototypes]
180 | irqreturn_t kbase_gpu_irq_test_handler(int irq, void *data, u32 val)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/backend/gpu/mali_kbase_irq_linux.c:208:5: warning: no previous prototype for 'kbase_set_custom_irq_handler' [-Wmissing-prototypes]
208 | int kbase_set_custom_irq_handler(struct kbase_device *kbdev,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/gpu/arm/valhall/mali_kbase_defs.h:37,
from drivers/gpu/arm/valhall/mali_kbase.h:57,
from drivers/gpu/arm/valhall/backend/gpu/mali_kbase_irq_linux.c:23:
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:625:33: warning: 'base_hw_issues_model_tE2x' defined but not used [-Wunused-const-variable=]
625 | static const enum base_hw_issue base_hw_issues_model_tE2x[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:615:33: warning: 'base_hw_issues_tE2x_r0p0' defined but not used [-Wunused-const-variable=]
615 | static const enum base_hw_issue base_hw_issues_tE2x_r0p0[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:607:33: warning: 'base_hw_issues_model_tTUx' defined but not used [-Wunused-const-variable=]
607 | static const enum base_hw_issue base_hw_issues_model_tTUx[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:600:33: warning: 'base_hw_issues_tTUx_r0p0' defined but not used [-Wunused-const-variable=]
600 | static const enum base_hw_issue base_hw_issues_tTUx_r0p0[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:592:33: warning: 'base_hw_issues_model_tVAx' defined but not used [-Wunused-const-variable=]
592 | static const enum base_hw_issue base_hw_issues_model_tVAx[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:585:33: warning: 'base_hw_issues_tVAx_r0p0' defined but not used [-Wunused-const-variable=]
585 | static const enum base_hw_issue base_hw_issues_tVAx_r0p0[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:577:33: warning: 'base_hw_issues_model_tGRx' defined but not used [-Wunused-const-variable=]
577 | static const enum base_hw_issue base_hw_issues_model_tGRx[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:570:33: warning: 'base_hw_issues_tGRx_r0p0' defined but not used [-Wunused-const-variable=]
570 | static const enum base_hw_issue base_hw_issues_tGRx_r0p0[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:562:33: warning: 'base_hw_issues_model_tODx' defined but not used [-Wunused-const-variable=]
562 | static const enum base_hw_issue base_hw_issues_model_tODx[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:555:33: warning: 'base_hw_issues_tODx_r0p0' defined but not used [-Wunused-const-variable=]
555 | static const enum base_hw_issue base_hw_issues_tODx_r0p0[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:545:33: warning: 'base_hw_issues_model_tDUx' defined but not used [-Wunused-const-variable=]
545 | static const enum base_hw_issue base_hw_issues_model_tDUx[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:535:33: warning: 'base_hw_issues_tDUx_r0p0' defined but not used [-Wunused-const-variable=]
535 | static const enum base_hw_issue base_hw_issues_tDUx_r0p0[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:522:33: warning: 'base_hw_issues_lBEx_r1p1' defined but not used [-Wunused-const-variable=]
522 | static const enum base_hw_issue base_hw_issues_lBEx_r1p1[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:508:33: warning: 'base_hw_issues_lBEx_r1p0' defined but not used [-Wunused-const-variable=]
508 | static const enum base_hw_issue base_hw_issues_lBEx_r1p0[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:496:33: warning: 'base_hw_issues_model_tBEx' defined but not used [-Wunused-const-variable=]
496 | static const enum base_hw_issue base_hw_issues_model_tBEx[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:483:33: warning: 'base_hw_issues_tBEx_r1p1' defined but not used [-Wunused-const-variable=]
483 | static const enum base_hw_issue base_hw_issues_tBEx_r1p1[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:470:33: warning: 'base_hw_issues_tBEx_r1p0' defined but not used [-Wunused-const-variable=]
470 | static const enum base_hw_issue base_hw_issues_tBEx_r1p0[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:457:33: warning: 'base_hw_issues_tBEx_r0p1' defined but not used [-Wunused-const-variable=]
457 | static const enum base_hw_issue base_hw_issues_tBEx_r0p1[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:443:33: warning: 'base_hw_issues_tBEx_r0p0' defined but not used [-Wunused-const-variable=]
443 | static const enum base_hw_issue base_hw_issues_tBEx_r0p0[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:431:33: warning: 'base_hw_issues_model_tNAx' defined but not used [-Wunused-const-variable=]
431 | static const enum base_hw_issue base_hw_issues_model_tNAx[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:416:33: warning: 'base_hw_issues_tNAx_r0p1' defined but not used [-Wunused-const-variable=]
416 | static const enum base_hw_issue base_hw_issues_tNAx_r0p1[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:400:33: warning: 'base_hw_issues_tNAx_r0p0' defined but not used [-Wunused-const-variable=]
400 | static const enum base_hw_issue base_hw_issues_tNAx_r0p0[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:388:33: warning: 'base_hw_issues_model_tTRx' defined but not used [-Wunused-const-variable=]
388 | static const enum base_hw_issue base_hw_issues_model_tTRx[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:373:33: warning: 'base_hw_issues_tTRx_r0p2' defined but not used [-Wunused-const-variable=]
373 | static const enum base_hw_issue base_hw_issues_tTRx_r0p2[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:357:33: warning: 'base_hw_issues_tTRx_r0p1' defined but not used [-Wunused-const-variable=]
357 | static const enum base_hw_issue base_hw_issues_tTRx_r0p1[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:341:33: warning: 'base_hw_issues_tTRx_r0p0' defined but not used [-Wunused-const-variable=]
341 | static const enum base_hw_issue base_hw_issues_tTRx_r0p0[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:331:33: warning: 'base_hw_issues_model_tGOx' defined but not used [-Wunused-const-variable=]
331 | static const enum base_hw_issue base_hw_issues_model_tGOx[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:319:33: warning: 'base_hw_issues_tGOx_r1p0' defined but not used [-Wunused-const-variable=]
319 | static const enum base_hw_issue base_hw_issues_tGOx_r1p0[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:307:33: warning: 'base_hw_issues_tGOx_r0p0' defined but not used [-Wunused-const-variable=]
307 | static const enum base_hw_issue base_hw_issues_tGOx_r0p0[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:297:33: warning: 'base_hw_issues_model_tNOx' defined but not used [-Wunused-const-variable=]
297 | static const enum base_hw_issue base_hw_issues_model_tNOx[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:285:33: warning: 'base_hw_issues_tNOx_r0p0' defined but not used [-Wunused-const-variable=]
285 | static const enum base_hw_issue base_hw_issues_tNOx_r0p0[] = {
--
cc1: warning: drivers/gpu/arm/valhall/../../../base: No such file or directory [-Wmissing-include-dirs]
drivers/gpu/arm/valhall/tests/kutf/kutf_utils.c: In function 'kutf_dsprintf':
>> drivers/gpu/arm/valhall/tests/kutf/kutf_utils.c:47:2: warning: function 'kutf_dsprintf' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
47 | len = vsnprintf(tmp_buffer, sizeof(tmp_buffer), fmt, args);
| ^~~
--
cc1: warning: drivers/gpu/arm/valhall/../../../base: No such file or directory [-Wmissing-include-dirs]
>> drivers/gpu/arm/valhall/tests/mali_kutf_irq_test/mali_kutf_irq_test_main.c:239:5: warning: no previous prototype for 'mali_kutf_irq_test_main_init' [-Wmissing-prototypes]
239 | int mali_kutf_irq_test_main_init(void)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/gpu/arm/valhall/tests/mali_kutf_irq_test/mali_kutf_irq_test_main.c:268:6: warning: no previous prototype for 'mali_kutf_irq_test_main_exit' [-Wmissing-prototypes]
268 | void mali_kutf_irq_test_main_exit(void)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/gpu/arm/valhall/mali_kbase_defs.h:37,
from drivers/gpu/arm/valhall/mali_kbase.h:57,
from drivers/gpu/arm/valhall/tests/mali_kutf_irq_test/mali_kutf_irq_test_main.c:27:
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:625:33: warning: 'base_hw_issues_model_tE2x' defined but not used [-Wunused-const-variable=]
625 | static const enum base_hw_issue base_hw_issues_model_tE2x[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:615:33: warning: 'base_hw_issues_tE2x_r0p0' defined but not used [-Wunused-const-variable=]
615 | static const enum base_hw_issue base_hw_issues_tE2x_r0p0[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:607:33: warning: 'base_hw_issues_model_tTUx' defined but not used [-Wunused-const-variable=]
607 | static const enum base_hw_issue base_hw_issues_model_tTUx[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:600:33: warning: 'base_hw_issues_tTUx_r0p0' defined but not used [-Wunused-const-variable=]
600 | static const enum base_hw_issue base_hw_issues_tTUx_r0p0[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:592:33: warning: 'base_hw_issues_model_tVAx' defined but not used [-Wunused-const-variable=]
592 | static const enum base_hw_issue base_hw_issues_model_tVAx[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:585:33: warning: 'base_hw_issues_tVAx_r0p0' defined but not used [-Wunused-const-variable=]
585 | static const enum base_hw_issue base_hw_issues_tVAx_r0p0[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:577:33: warning: 'base_hw_issues_model_tGRx' defined but not used [-Wunused-const-variable=]
577 | static const enum base_hw_issue base_hw_issues_model_tGRx[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:570:33: warning: 'base_hw_issues_tGRx_r0p0' defined but not used [-Wunused-const-variable=]
570 | static const enum base_hw_issue base_hw_issues_tGRx_r0p0[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:562:33: warning: 'base_hw_issues_model_tODx' defined but not used [-Wunused-const-variable=]
562 | static const enum base_hw_issue base_hw_issues_model_tODx[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:555:33: warning: 'base_hw_issues_tODx_r0p0' defined but not used [-Wunused-const-variable=]
555 | static const enum base_hw_issue base_hw_issues_tODx_r0p0[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:545:33: warning: 'base_hw_issues_model_tDUx' defined but not used [-Wunused-const-variable=]
545 | static const enum base_hw_issue base_hw_issues_model_tDUx[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:535:33: warning: 'base_hw_issues_tDUx_r0p0' defined but not used [-Wunused-const-variable=]
535 | static const enum base_hw_issue base_hw_issues_tDUx_r0p0[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:522:33: warning: 'base_hw_issues_lBEx_r1p1' defined but not used [-Wunused-const-variable=]
522 | static const enum base_hw_issue base_hw_issues_lBEx_r1p1[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:508:33: warning: 'base_hw_issues_lBEx_r1p0' defined but not used [-Wunused-const-variable=]
508 | static const enum base_hw_issue base_hw_issues_lBEx_r1p0[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:496:33: warning: 'base_hw_issues_model_tBEx' defined but not used [-Wunused-const-variable=]
496 | static const enum base_hw_issue base_hw_issues_model_tBEx[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:483:33: warning: 'base_hw_issues_tBEx_r1p1' defined but not used [-Wunused-const-variable=]
483 | static const enum base_hw_issue base_hw_issues_tBEx_r1p1[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:470:33: warning: 'base_hw_issues_tBEx_r1p0' defined but not used [-Wunused-const-variable=]
470 | static const enum base_hw_issue base_hw_issues_tBEx_r1p0[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:457:33: warning: 'base_hw_issues_tBEx_r0p1' defined but not used [-Wunused-const-variable=]
457 | static const enum base_hw_issue base_hw_issues_tBEx_r0p1[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:443:33: warning: 'base_hw_issues_tBEx_r0p0' defined but not used [-Wunused-const-variable=]
443 | static const enum base_hw_issue base_hw_issues_tBEx_r0p0[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:431:33: warning: 'base_hw_issues_model_tNAx' defined but not used [-Wunused-const-variable=]
431 | static const enum base_hw_issue base_hw_issues_model_tNAx[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:416:33: warning: 'base_hw_issues_tNAx_r0p1' defined but not used [-Wunused-const-variable=]
416 | static const enum base_hw_issue base_hw_issues_tNAx_r0p1[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:400:33: warning: 'base_hw_issues_tNAx_r0p0' defined but not used [-Wunused-const-variable=]
400 | static const enum base_hw_issue base_hw_issues_tNAx_r0p0[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:388:33: warning: 'base_hw_issues_model_tTRx' defined but not used [-Wunused-const-variable=]
388 | static const enum base_hw_issue base_hw_issues_model_tTRx[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:373:33: warning: 'base_hw_issues_tTRx_r0p2' defined but not used [-Wunused-const-variable=]
373 | static const enum base_hw_issue base_hw_issues_tTRx_r0p2[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:357:33: warning: 'base_hw_issues_tTRx_r0p1' defined but not used [-Wunused-const-variable=]
357 | static const enum base_hw_issue base_hw_issues_tTRx_r0p1[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:341:33: warning: 'base_hw_issues_tTRx_r0p0' defined but not used [-Wunused-const-variable=]
341 | static const enum base_hw_issue base_hw_issues_tTRx_r0p0[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:331:33: warning: 'base_hw_issues_model_tGOx' defined but not used [-Wunused-const-variable=]
331 | static const enum base_hw_issue base_hw_issues_model_tGOx[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:319:33: warning: 'base_hw_issues_tGOx_r1p0' defined but not used [-Wunused-const-variable=]
319 | static const enum base_hw_issue base_hw_issues_tGOx_r1p0[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:307:33: warning: 'base_hw_issues_tGOx_r0p0' defined but not used [-Wunused-const-variable=]
307 | static const enum base_hw_issue base_hw_issues_tGOx_r0p0[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:297:33: warning: 'base_hw_issues_model_tNOx' defined but not used [-Wunused-const-variable=]
297 | static const enum base_hw_issue base_hw_issues_model_tNOx[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:285:33: warning: 'base_hw_issues_tNOx_r0p0' defined but not used [-Wunused-const-variable=]
285 | static const enum base_hw_issue base_hw_issues_tNOx_r0p0[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/arm/valhall/mali_base_hwconfig_issues.h:275:33: warning: 'base_hw_issues_model_tDVx' defined but not used [-Wunused-const-variable=]
275 | static const enum base_hw_issue base_hw_issues_model_tDVx[] = {
vim +/kbase_gpu_irq_test_handler +180 drivers/gpu/arm/valhall/backend/gpu/mali_kbase_irq_linux.c
166
167 /**
168 * kbase_gpu_irq_test_handler - Variant (for test) of kbase_gpu_irq_handler()
169 * @irq: IRQ number
170 * @data: Data associated with this IRQ (i.e. kbdev)
171 * @val: Value of the GPU_CONTROL_REG(GPU_IRQ_STATUS)
172 *
173 * Handle the GPU device interrupt source requests reflected in the
174 * given source bit-pattern. The test code caller is responsible for
175 * undertaking the required device power maintenace.
176 *
177 * Return: IRQ_HANDLED if the requests are from the GPU device,
178 * IRQ_NONE otherwise
179 */
> 180 irqreturn_t kbase_gpu_irq_test_handler(int irq, void *data, u32 val)
181 {
182 struct kbase_device *kbdev = kbase_untag(data);
183
184 if (!val)
185 return IRQ_NONE;
186
187 dev_dbg(kbdev->dev, "%s: irq %d irqstatus 0x%x\n", __func__, irq, val);
188
189 kbase_gpu_interrupt(kbdev, val);
190
191 return IRQ_HANDLED;
192 }
193
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 2 months
[ast:timer 4/4] kernel/bpf/helpers.c:1022:6: warning: variable 'ret' set but not used
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/ast/bpf.git timer
head: eb86df61cd52ea2e05357f8ae2b77e9bf6d63463
commit: eb86df61cd52ea2e05357f8ae2b77e9bf6d63463 [4/4] bpf: Implement verifier support for validation of async callbacks.
config: parisc-randconfig-s032-20210622 (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.3-341-g8af24329-dirty
# https://git.kernel.org/pub/scm/linux/kernel/git/ast/bpf.git/commit/?id=eb...
git remote add ast https://git.kernel.org/pub/scm/linux/kernel/git/ast/bpf.git
git fetch --no-tags ast timer
git checkout eb86df61cd52ea2e05357f8ae2b77e9bf6d63463
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=parisc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
kernel/bpf/helpers.c: In function 'bpf_timer_cb':
>> kernel/bpf/helpers.c:1022:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
1022 | int ret;
| ^~~
In file included from <command-line>:
In function '____bpf_timer_init',
inlined from 'bpf_timer_init' at kernel/bpf/helpers.c:1064:1:
include/linux/compiler_types.h:328:38: error: call to '__compiletime_assert_353' declared with attribute error: BUILD_BUG_ON failed: __alignof__(struct bpf_timer_kern) != __alignof__(struct bpf_timer)
328 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^
include/linux/compiler_types.h:309:4: note: in definition of macro '__compiletime_assert'
309 | prefix ## suffix(); \
| ^~~~~~
include/linux/compiler_types.h:328:2: note: in expansion of macro '_compiletime_assert'
328 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert'
39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
| ^~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:50:2: note: in expansion of macro 'BUILD_BUG_ON_MSG'
50 | BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition)
| ^~~~~~~~~~~~~~~~
kernel/bpf/helpers.c:1073:2: note: in expansion of macro 'BUILD_BUG_ON'
1073 | BUILD_BUG_ON(__alignof__(struct bpf_timer_kern) != __alignof__(struct bpf_timer));
| ^~~~~~~~~~~~
vim +/ret +1022 kernel/bpf/helpers.c
7e26a76313f427 Alexei Starovoitov 2021-05-17 1011
7e26a76313f427 Alexei Starovoitov 2021-05-17 1012 static enum hrtimer_restart bpf_timer_cb(struct hrtimer *hrtimer)
7e26a76313f427 Alexei Starovoitov 2021-05-17 1013 {
7e26a76313f427 Alexei Starovoitov 2021-05-17 1014 struct bpf_hrtimer *t = container_of(hrtimer, struct bpf_hrtimer, timer);
7e26a76313f427 Alexei Starovoitov 2021-05-17 1015 struct bpf_map *map = t->map;
7e26a76313f427 Alexei Starovoitov 2021-05-17 1016 void *value = t->value;
7e26a76313f427 Alexei Starovoitov 2021-05-17 1017 struct bpf_timer_kern *timer = value + map->timer_off;
7e26a76313f427 Alexei Starovoitov 2021-05-17 1018 struct bpf_prog *prog;
7e26a76313f427 Alexei Starovoitov 2021-05-17 1019 void *callback_fn;
7e26a76313f427 Alexei Starovoitov 2021-05-17 1020 void *key;
7e26a76313f427 Alexei Starovoitov 2021-05-17 1021 u32 idx;
7e26a76313f427 Alexei Starovoitov 2021-05-17 @1022 int ret;
7e26a76313f427 Alexei Starovoitov 2021-05-17 1023
7e26a76313f427 Alexei Starovoitov 2021-05-17 1024 ____bpf_spin_lock(&timer->lock);
7e26a76313f427 Alexei Starovoitov 2021-05-17 1025 /* callback_fn and prog need to match. They're updated together
7e26a76313f427 Alexei Starovoitov 2021-05-17 1026 * and have to be read under lock.
7e26a76313f427 Alexei Starovoitov 2021-05-17 1027 */
7e26a76313f427 Alexei Starovoitov 2021-05-17 1028 prog = t->prog;
7e26a76313f427 Alexei Starovoitov 2021-05-17 1029 callback_fn = t->callback_fn;
7e26a76313f427 Alexei Starovoitov 2021-05-17 1030
7e26a76313f427 Alexei Starovoitov 2021-05-17 1031 /* wrap bpf subprog invocation with prog->refcnt++ and -- to make
7e26a76313f427 Alexei Starovoitov 2021-05-17 1032 * sure that refcnt doesn't become zero when subprog is executing.
7e26a76313f427 Alexei Starovoitov 2021-05-17 1033 * Do it under lock to make sure that bpf_timer_start doesn't drop
7e26a76313f427 Alexei Starovoitov 2021-05-17 1034 * prev prog refcnt to zero before timer_cb has a chance to bump it.
7e26a76313f427 Alexei Starovoitov 2021-05-17 1035 */
7e26a76313f427 Alexei Starovoitov 2021-05-17 1036 bpf_prog_inc(prog);
7e26a76313f427 Alexei Starovoitov 2021-05-17 1037 ____bpf_spin_unlock(&timer->lock);
7e26a76313f427 Alexei Starovoitov 2021-05-17 1038
7e26a76313f427 Alexei Starovoitov 2021-05-17 1039 /* bpf_timer_cb() runs in hrtimer_run_softirq. It doesn't migrate and
7e26a76313f427 Alexei Starovoitov 2021-05-17 1040 * cannot be preempted by another bpf_timer_cb() on the same cpu.
7e26a76313f427 Alexei Starovoitov 2021-05-17 1041 * Remember the timer this callback is servicing to prevent
7e26a76313f427 Alexei Starovoitov 2021-05-17 1042 * deadlock if callback_fn() calls bpf_timer_cancel() on the same timer.
7e26a76313f427 Alexei Starovoitov 2021-05-17 1043 */
7e26a76313f427 Alexei Starovoitov 2021-05-17 1044 this_cpu_write(hrtimer_running, t);
7e26a76313f427 Alexei Starovoitov 2021-05-17 1045 if (map->map_type == BPF_MAP_TYPE_ARRAY) {
7e26a76313f427 Alexei Starovoitov 2021-05-17 1046 struct bpf_array *array = container_of(map, struct bpf_array, map);
7e26a76313f427 Alexei Starovoitov 2021-05-17 1047
7e26a76313f427 Alexei Starovoitov 2021-05-17 1048 /* compute the key */
7e26a76313f427 Alexei Starovoitov 2021-05-17 1049 idx = ((char *)value - array->value) / array->elem_size;
7e26a76313f427 Alexei Starovoitov 2021-05-17 1050 key = &idx;
7e26a76313f427 Alexei Starovoitov 2021-05-17 1051 } else { /* hash or lru */
7e26a76313f427 Alexei Starovoitov 2021-05-17 1052 key = value - round_up(map->key_size, 8);
7e26a76313f427 Alexei Starovoitov 2021-05-17 1053 }
7e26a76313f427 Alexei Starovoitov 2021-05-17 1054
7e26a76313f427 Alexei Starovoitov 2021-05-17 1055 ret = BPF_CAST_CALL(callback_fn)((u64)(long)map,
7e26a76313f427 Alexei Starovoitov 2021-05-17 1056 (u64)(long)key,
7e26a76313f427 Alexei Starovoitov 2021-05-17 1057 (u64)(long)value, 0, 0);
7e26a76313f427 Alexei Starovoitov 2021-05-17 1058 bpf_prog_put(prog);
7e26a76313f427 Alexei Starovoitov 2021-05-17 1059
7e26a76313f427 Alexei Starovoitov 2021-05-17 1060 this_cpu_write(hrtimer_running, NULL);
7e26a76313f427 Alexei Starovoitov 2021-05-17 1061 return HRTIMER_NORESTART;
7e26a76313f427 Alexei Starovoitov 2021-05-17 1062 }
7e26a76313f427 Alexei Starovoitov 2021-05-17 1063
:::::: The code at line 1022 was first introduced by commit
:::::: 7e26a76313f4274c6013a7565411f3f7b6773b29 bpf: Introduce bpf_timer
:::::: TO: Alexei Starovoitov <ast(a)kernel.org>
:::::: CC: Alexei Starovoitov <ast(a)kernel.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 2 months
drivers/dma/dw-edma/dw-edma-v0-core.c:326 dw_edma_v0_core_write_chunk() warn: inconsistent indenting
by kernel test robot
Hi Gustavo,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 0c18f29aae7ce3dadd26d8ee3505d07cc982df75
commit: e0c1d53891c43a70c9fa85ddb3174ab5afd7e2ec dmaengine: dw-edma: Add support for the HDMA feature
date: 3 months ago
config: powerpc64-randconfig-m031-20210622 (attached as .config)
compiler: powerpc64le-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
New smatch warnings:
drivers/dma/dw-edma/dw-edma-v0-core.c:326 dw_edma_v0_core_write_chunk() warn: inconsistent indenting
drivers/dma/dw-edma/dw-edma-v0-core.c:418 dw_edma_v0_core_start() warn: inconsistent indenting
Old smatch warnings:
drivers/dma/dw-edma/dw-edma-v0-core.c:350 dw_edma_v0_core_write_chunk() warn: inconsistent indenting
vim +326 drivers/dma/dw-edma/dw-edma-v0-core.c
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 300
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 301 static void dw_edma_v0_core_write_chunk(struct dw_edma_chunk *chunk)
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 302 {
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 303 struct dw_edma_burst *child;
756c3ef93492af Arnd Bergmann 2019-07-22 304 struct dw_edma_v0_lli __iomem *lli;
756c3ef93492af Arnd Bergmann 2019-07-22 305 struct dw_edma_v0_llp __iomem *llp;
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 306 u32 control = 0, i = 0;
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 307 int j;
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 308
756c3ef93492af Arnd Bergmann 2019-07-22 309 lli = chunk->ll_region.vaddr;
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 310
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 311 if (chunk->cb)
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 312 control = DW_EDMA_V0_CB;
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 313
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 314 j = chunk->bursts_alloc;
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 315 list_for_each_entry(child, &chunk->burst->list, list) {
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 316 j--;
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 317 if (!j)
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 318 control |= (DW_EDMA_V0_LIE | DW_EDMA_V0_RIE);
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 319
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 320 /* Channel control */
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 321 SET_LL_32(&lli[i].control, control);
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 322 /* Transfer size */
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 323 SET_LL_32(&lli[i].transfer_size, child->sz);
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 324 /* SAR */
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 325 #ifdef CONFIG_64BIT
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 @326 SET_LL_64(&lli[i].sar.reg, child->sar);
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 327 #else /* CONFIG_64BIT */
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 328 SET_LL_32(&lli[i].sar.lsb, lower_32_bits(child->sar));
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 329 SET_LL_32(&lli[i].sar.msb, upper_32_bits(child->sar));
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 330 #endif /* CONFIG_64BIT */
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 331 /* DAR */
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 332 #ifdef CONFIG_64BIT
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 333 SET_LL_64(&lli[i].dar.reg, child->dar);
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 334 #else /* CONFIG_64BIT */
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 335 SET_LL_32(&lli[i].dar.lsb, lower_32_bits(child->dar));
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 336 SET_LL_32(&lli[i].dar.msb, upper_32_bits(child->dar));
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 337 #endif /* CONFIG_64BIT */
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 338 i++;
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 339 }
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 340
756c3ef93492af Arnd Bergmann 2019-07-22 341 llp = (void __iomem *)&lli[i];
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 342 control = DW_EDMA_V0_LLP | DW_EDMA_V0_TCB;
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 343 if (!chunk->cb)
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 344 control |= DW_EDMA_V0_CB;
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 345
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 346 /* Channel control */
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 347 SET_LL_32(&llp->control, control);
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 348 /* Linked list */
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 349 #ifdef CONFIG_64BIT
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 350 SET_LL_64(&llp->llp.reg, chunk->ll_region.paddr);
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 351 #else /* CONFIG_64BIT */
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 352 SET_LL_32(&llp->llp.lsb, lower_32_bits(chunk->ll_region.paddr));
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 353 SET_LL_32(&llp->llp.msb, upper_32_bits(chunk->ll_region.paddr));
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 354 #endif /* CONFIG_64BIT */
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 355 }
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 356
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 357 void dw_edma_v0_core_start(struct dw_edma_chunk *chunk, bool first)
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 358 {
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 359 struct dw_edma_chan *chan = chunk->chan;
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 360 struct dw_edma *dw = chan->chip->dw;
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 361 u32 tmp;
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 362
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 363 dw_edma_v0_core_write_chunk(chunk);
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 364
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 365 if (first) {
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 366 /* Enable engine */
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 367 SET_RW_32(dw, chan->dir, engine_en, BIT(0));
e0c1d53891c43a Gustavo Pimentel 2021-02-18 368 if (dw->mf == EDMA_MF_HDMA_COMPAT) {
e0c1d53891c43a Gustavo Pimentel 2021-02-18 369 switch (chan->id) {
e0c1d53891c43a Gustavo Pimentel 2021-02-18 370 case 0:
e0c1d53891c43a Gustavo Pimentel 2021-02-18 371 SET_RW_COMPAT(dw, chan->dir, ch0_pwr_en,
e0c1d53891c43a Gustavo Pimentel 2021-02-18 372 BIT(0));
e0c1d53891c43a Gustavo Pimentel 2021-02-18 373 break;
e0c1d53891c43a Gustavo Pimentel 2021-02-18 374 case 1:
e0c1d53891c43a Gustavo Pimentel 2021-02-18 375 SET_RW_COMPAT(dw, chan->dir, ch1_pwr_en,
e0c1d53891c43a Gustavo Pimentel 2021-02-18 376 BIT(0));
e0c1d53891c43a Gustavo Pimentel 2021-02-18 377 break;
e0c1d53891c43a Gustavo Pimentel 2021-02-18 378 case 2:
e0c1d53891c43a Gustavo Pimentel 2021-02-18 379 SET_RW_COMPAT(dw, chan->dir, ch2_pwr_en,
e0c1d53891c43a Gustavo Pimentel 2021-02-18 380 BIT(0));
e0c1d53891c43a Gustavo Pimentel 2021-02-18 381 break;
e0c1d53891c43a Gustavo Pimentel 2021-02-18 382 case 3:
e0c1d53891c43a Gustavo Pimentel 2021-02-18 383 SET_RW_COMPAT(dw, chan->dir, ch3_pwr_en,
e0c1d53891c43a Gustavo Pimentel 2021-02-18 384 BIT(0));
e0c1d53891c43a Gustavo Pimentel 2021-02-18 385 break;
e0c1d53891c43a Gustavo Pimentel 2021-02-18 386 case 4:
e0c1d53891c43a Gustavo Pimentel 2021-02-18 387 SET_RW_COMPAT(dw, chan->dir, ch4_pwr_en,
e0c1d53891c43a Gustavo Pimentel 2021-02-18 388 BIT(0));
e0c1d53891c43a Gustavo Pimentel 2021-02-18 389 break;
e0c1d53891c43a Gustavo Pimentel 2021-02-18 390 case 5:
e0c1d53891c43a Gustavo Pimentel 2021-02-18 391 SET_RW_COMPAT(dw, chan->dir, ch5_pwr_en,
e0c1d53891c43a Gustavo Pimentel 2021-02-18 392 BIT(0));
e0c1d53891c43a Gustavo Pimentel 2021-02-18 393 break;
e0c1d53891c43a Gustavo Pimentel 2021-02-18 394 case 6:
e0c1d53891c43a Gustavo Pimentel 2021-02-18 395 SET_RW_COMPAT(dw, chan->dir, ch6_pwr_en,
e0c1d53891c43a Gustavo Pimentel 2021-02-18 396 BIT(0));
e0c1d53891c43a Gustavo Pimentel 2021-02-18 397 break;
e0c1d53891c43a Gustavo Pimentel 2021-02-18 398 case 7:
e0c1d53891c43a Gustavo Pimentel 2021-02-18 399 SET_RW_COMPAT(dw, chan->dir, ch7_pwr_en,
e0c1d53891c43a Gustavo Pimentel 2021-02-18 400 BIT(0));
e0c1d53891c43a Gustavo Pimentel 2021-02-18 401 break;
e0c1d53891c43a Gustavo Pimentel 2021-02-18 402 }
e0c1d53891c43a Gustavo Pimentel 2021-02-18 403 }
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 404 /* Interrupt unmask - done, abort */
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 405 tmp = GET_RW_32(dw, chan->dir, int_mask);
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 406 tmp &= ~FIELD_PREP(EDMA_V0_DONE_INT_MASK, BIT(chan->id));
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 407 tmp &= ~FIELD_PREP(EDMA_V0_ABORT_INT_MASK, BIT(chan->id));
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 408 SET_RW_32(dw, chan->dir, int_mask, tmp);
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 409 /* Linked list error */
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 410 tmp = GET_RW_32(dw, chan->dir, linked_list_err_en);
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 411 tmp |= FIELD_PREP(EDMA_V0_LINKED_LIST_ERR_MASK, BIT(chan->id));
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 412 SET_RW_32(dw, chan->dir, linked_list_err_en, tmp);
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 413 /* Channel control */
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 414 SET_CH_32(dw, chan->dir, chan->id, ch_control1,
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 415 (DW_EDMA_V0_CCS | DW_EDMA_V0_LLE));
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 416 /* Linked list */
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 417 #ifdef CONFIG_64BIT
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 @418 SET_CH_64(dw, chan->dir, chan->id, llp.reg,
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 419 chunk->ll_region.paddr);
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 420 #else /* CONFIG_64BIT */
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 421 SET_CH_32(dw, chan->dir, chan->id, llp.lsb,
6f4722b1d1ebf2 Arnd Bergmann 2019-07-22 422 lower_32_bits(chunk->ll_region.paddr));
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 423 SET_CH_32(dw, chan->dir, chan->id, llp.msb,
6f4722b1d1ebf2 Arnd Bergmann 2019-07-22 424 upper_32_bits(chunk->ll_region.paddr));
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 425 #endif /* CONFIG_64BIT */
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 426 }
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 427 /* Doorbell */
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 428 SET_RW_32(dw, chan->dir, doorbell,
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 429 FIELD_PREP(EDMA_V0_DOORBELL_CH_MASK, chan->id));
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 430 }
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 431
:::::: The code at line 326 was first introduced by commit
:::::: 04e0a39fc10f82a71b84af73351333b184cee578 dmaengine: dw-edma: Add writeq() and readq() for 64 bits architectures
:::::: TO: Gustavo Pimentel <Gustavo.Pimentel(a)synopsys.com>
:::::: CC: Vinod Koul <vkoul(a)kernel.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 2 months
[ragnatech:media-next 189/399] ths8200.c:undefined reference to `v4l2_async_unregister_subdev'
by kernel test robot
tree: git://git.ragnatech.se/linux media-next
head: 86734f2e678a40a0d5b1f6f4d82e66c32d22a72b
commit: ff3cc65cadb5d7333fde557b38cbb60b3a6cf496 [189/399] media: v4l: async, fwnode: Improve module organisation
config: arc-randconfig-p002-20210623 (attached as .config)
compiler: arceb-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git remote add ragnatech git://git.ragnatech.se/linux
git fetch --no-tags ragnatech media-next
git checkout ff3cc65cadb5d7333fde557b38cbb60b3a6cf496
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
arceb-elf-ld: drivers/media/i2c/ths8200.o: in function `ths8200_remove':
>> ths8200.c:(.text+0x2da): undefined reference to `v4l2_async_unregister_subdev'
>> arceb-elf-ld: ths8200.c:(.text+0x2da): undefined reference to `v4l2_async_unregister_subdev'
arceb-elf-ld: drivers/media/i2c/ths8200.o: in function `ths8200_probe':
>> ths8200.c:(.text+0x442): undefined reference to `v4l2_async_register_subdev'
>> arceb-elf-ld: ths8200.c:(.text+0x442): undefined reference to `v4l2_async_register_subdev'
arceb-elf-ld: drivers/media/i2c/tw9910.o: in function `tw9910_remove':
>> tw9910.c:(.text+0x154): undefined reference to `v4l2_async_unregister_subdev'
>> arceb-elf-ld: tw9910.c:(.text+0x154): undefined reference to `v4l2_async_unregister_subdev'
arceb-elf-ld: drivers/media/i2c/tw9910.o: in function `tw9910_probe':
>> tw9910.c:(.text+0x898): undefined reference to `v4l2_async_register_subdev'
>> arceb-elf-ld: tw9910.c:(.text+0x898): undefined reference to `v4l2_async_register_subdev'
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 2 months
arch/powerpc/sysdev/xive/common.c:1161 xive_request_ipi() warn: unsigned 'xid->irq' is never less than zero.
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 0c18f29aae7ce3dadd26d8ee3505d07cc982df75
commit: fd6db2892ebaa1383a93b4a609c65b96e615510a powerpc/xive: Modernize XIVE-IPI domain with an 'alloc' handler
date: 2 months ago
config: powerpc64-randconfig-m031-20210622 (attached as .config)
compiler: powerpc64le-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
smatch warnings:
arch/powerpc/sysdev/xive/common.c:1161 xive_request_ipi() warn: unsigned 'xid->irq' is never less than zero.
vim +1161 arch/powerpc/sysdev/xive/common.c
1126
1127 static int __init xive_request_ipi(void)
1128 {
1129 struct fwnode_handle *fwnode;
1130 struct irq_domain *ipi_domain;
1131 unsigned int node;
1132 int ret = -ENOMEM;
1133
1134 fwnode = irq_domain_alloc_named_fwnode("XIVE-IPI");
1135 if (!fwnode)
1136 goto out;
1137
1138 ipi_domain = irq_domain_create_linear(fwnode, nr_node_ids,
1139 &xive_ipi_irq_domain_ops, NULL);
1140 if (!ipi_domain)
1141 goto out_free_fwnode;
1142
1143 xive_ipis = kcalloc(nr_node_ids, sizeof(*xive_ipis), GFP_KERNEL | __GFP_NOFAIL);
1144 if (!xive_ipis)
1145 goto out_free_domain;
1146
1147 for_each_node(node) {
1148 struct xive_ipi_desc *xid = &xive_ipis[node];
1149 struct xive_ipi_alloc_info info = { node };
1150
1151 /* Skip nodes without CPUs */
1152 if (cpumask_empty(cpumask_of_node(node)))
1153 continue;
1154
1155 /*
1156 * Map one IPI interrupt per node for all cpus of that node.
1157 * Since the HW interrupt number doesn't have any meaning,
1158 * simply use the node number.
1159 */
1160 xid->irq = irq_domain_alloc_irqs(ipi_domain, 1, node, &info);
> 1161 if (xid->irq < 0) {
1162 ret = xid->irq;
1163 goto out_free_xive_ipis;
1164 }
1165
1166 snprintf(xid->name, sizeof(xid->name), "IPI-%d", node);
1167
1168 ret = request_irq(xid->irq, xive_muxed_ipi_action,
1169 IRQF_PERCPU | IRQF_NO_THREAD, xid->name, NULL);
1170
1171 WARN(ret < 0, "Failed to request IPI %d: %d\n", xid->irq, ret);
1172 }
1173
1174 return ret;
1175
1176 out_free_xive_ipis:
1177 kfree(xive_ipis);
1178 out_free_domain:
1179 irq_domain_remove(ipi_domain);
1180 out_free_fwnode:
1181 irq_domain_free_fwnode(fwnode);
1182 out:
1183 return ret;
1184 }
1185
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 2 months
[linux-next:master 8061/12271] sl3516-ce-core.c:undefined reference to `devm_platform_ioremap_resource'
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 4238b1710eadd18dd16de0288a2bc5bb84614b4e
commit: 46c5338db7bd45b2cf99570560f00389d60fd6b4 [8061/12271] crypto: sl3516 - Add sl3516 crypto engine
config: s390-randconfig-r001-20210623 (attached as .config)
compiler: s390-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commi...
git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git fetch --no-tags linux-next master
git checkout 46c5338db7bd45b2cf99570560f00389d60fd6b4
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=s390
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
s390-linux-ld: kernel/dma/coherent.o: in function `dma_init_coherent_memory':
coherent.c:(.text+0x24c): undefined reference to `memremap'
s390-linux-ld: coherent.c:(.text+0x2f4): undefined reference to `memunmap'
s390-linux-ld: kernel/dma/coherent.o: in function `dma_declare_coherent_memory':
coherent.c:(.text+0x636): undefined reference to `memunmap'
s390-linux-ld: drivers/irqchip/irq-al-fic.o: in function `al_fic_init_dt':
irq-al-fic.c:(.init.text+0x48): undefined reference to `of_iomap'
s390-linux-ld: irq-al-fic.c:(.init.text+0x282): undefined reference to `iounmap'
s390-linux-ld: drivers/clk/clk-fixed-mmio.o: in function `fixed_mmio_clk_setup':
clk-fixed-mmio.c:(.text+0x34): undefined reference to `of_iomap'
s390-linux-ld: clk-fixed-mmio.c:(.text+0x4c): undefined reference to `iounmap'
s390-linux-ld: drivers/char/xillybus/xillybus_of.o: in function `xilly_drv_probe':
xillybus_of.c:(.text+0x138): undefined reference to `devm_platform_ioremap_resource'
s390-linux-ld: drivers/pcmcia/cistpl.o: in function `set_cis_map':
cistpl.c:(.text+0x26c): undefined reference to `iounmap'
s390-linux-ld: cistpl.c:(.text+0x27e): undefined reference to `ioremap'
s390-linux-ld: cistpl.c:(.text+0x2e0): undefined reference to `ioremap'
s390-linux-ld: cistpl.c:(.text+0x2fa): undefined reference to `iounmap'
s390-linux-ld: drivers/pcmcia/cistpl.o: in function `release_cis_mem':
cistpl.c:(.text+0xd08): undefined reference to `iounmap'
s390-linux-ld: drivers/crypto/gemini/sl3516-ce-core.o: in function `sl3516_ce_probe':
>> sl3516-ce-core.c:(.text+0x160): undefined reference to `devm_platform_ioremap_resource'
s390-linux-ld: drivers/clocksource/timer-of.o: in function `timer_of_init':
timer-of.c:(.init.text+0x40): undefined reference to `of_iomap'
s390-linux-ld: timer-of.c:(.init.text+0x32a): undefined reference to `iounmap'
s390-linux-ld: drivers/clocksource/timer-of.o: in function `timer_of_cleanup':
timer-of.c:(.init.text+0x3f0): undefined reference to `iounmap'
s390-linux-ld: drivers/clocksource/timer-microchip-pit64b.o: in function `mchp_pit64b_dt_init_timer':
timer-microchip-pit64b.c:(.init.text+0x8c): undefined reference to `of_iomap'
s390-linux-ld: timer-microchip-pit64b.c:(.init.text+0x4fa): undefined reference to `iounmap'
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 2 months
[chrome-os:chromeos-5.10 14536/14856] drivers/clk/clk.c:855:6: error: redefinition of 'clk_unprepare'
by kernel test robot
Hi Samuel,
First bad commit (maybe != root cause):
tree: https://chromium.googlesource.com/chromiumos/third_party/kernel chromeos-5.10
head: 612cdee6fa88b0d6c76a79b26383c5c48d80b726
commit: ca3596b15a4a9f7c074103860660094efac1395b [14536/14856] UPSTREAM: ASoC: sun8i-codec: Protect the clock rate while streams are open
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git remote add chrome-os https://chromium.googlesource.com/chromiumos/third_party/kernel
git fetch --no-tags chrome-os chromeos-5.10
git checkout ca3596b15a4a9f7c074103860660094efac1395b
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> drivers/clk/clk.c:855:6: error: redefinition of 'clk_unprepare'
855 | void clk_unprepare(struct clk *clk)
| ^~~~~~~~~~~~~
In file included from drivers/clk/clk.c:9:
include/linux/clk.h:263:20: note: previous definition of 'clk_unprepare' was here
263 | static inline void clk_unprepare(struct clk *clk)
| ^~~~~~~~~~~~~
>> drivers/clk/clk.c:936:5: error: redefinition of 'clk_prepare'
936 | int clk_prepare(struct clk *clk)
| ^~~~~~~~~~~
In file included from drivers/clk/clk.c:9:
include/linux/clk.h:236:19: note: previous definition of 'clk_prepare' was here
236 | static inline int clk_prepare(struct clk *clk)
| ^~~~~~~~~~~
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for COMMON_CLK
Depends on !HAVE_LEGACY_CLK
Selected by
- SND_SUN8I_CODEC && SOUND && !UML && SND && SND_SOC && (ARCH_SUNXI || COMPILE_TEST && OF && (MACH_SUN8I || ARM64 && ARCH_SUNXI || COMPILE_TEST
WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_PDC
Depends on SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && HAS_DMA
Selected by
- SND_ATMEL_SOC_SSC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC
- SND_ATMEL_SOC_SSC_PDC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && ATMEL_SSC
vim +/clk_unprepare +855 drivers/clk/clk.c
a6adc30ba7bef8 Dong Aisheng 2016-06-30 843
4dff95dc9477a3 Stephen Boyd 2015-04-30 844 /**
4dff95dc9477a3 Stephen Boyd 2015-04-30 845 * clk_unprepare - undo preparation of a clock source
4dff95dc9477a3 Stephen Boyd 2015-04-30 846 * @clk: the clk being unprepared
4dff95dc9477a3 Stephen Boyd 2015-04-30 847 *
4dff95dc9477a3 Stephen Boyd 2015-04-30 848 * clk_unprepare may sleep, which differentiates it from clk_disable. In a
4dff95dc9477a3 Stephen Boyd 2015-04-30 849 * simple case, clk_unprepare can be used instead of clk_disable to gate a clk
4dff95dc9477a3 Stephen Boyd 2015-04-30 850 * if the operation may sleep. One example is a clk which is accessed over
4dff95dc9477a3 Stephen Boyd 2015-04-30 851 * I2c. In the complex case a clk gate operation may require a fast and a slow
4dff95dc9477a3 Stephen Boyd 2015-04-30 852 * part. It is this reason that clk_unprepare and clk_disable are not mutually
4dff95dc9477a3 Stephen Boyd 2015-04-30 853 * exclusive. In fact clk_disable must be called before clk_unprepare.
4dff95dc9477a3 Stephen Boyd 2015-04-30 854 */
4dff95dc9477a3 Stephen Boyd 2015-04-30 @855 void clk_unprepare(struct clk *clk)
b2476490ef1113 Mike Turquette 2012-03-15 856 {
4dff95dc9477a3 Stephen Boyd 2015-04-30 857 if (IS_ERR_OR_NULL(clk))
4dff95dc9477a3 Stephen Boyd 2015-04-30 858 return;
b2476490ef1113 Mike Turquette 2012-03-15 859
a6adc30ba7bef8 Dong Aisheng 2016-06-30 860 clk_core_unprepare_lock(clk->core);
1e435256d625c2 Olof Johansson 2013-04-27 861 }
4dff95dc9477a3 Stephen Boyd 2015-04-30 862 EXPORT_SYMBOL_GPL(clk_unprepare);
1e435256d625c2 Olof Johansson 2013-04-27 863
4dff95dc9477a3 Stephen Boyd 2015-04-30 864 static int clk_core_prepare(struct clk_core *core)
4dff95dc9477a3 Stephen Boyd 2015-04-30 865 {
4dff95dc9477a3 Stephen Boyd 2015-04-30 866 int ret = 0;
b2476490ef1113 Mike Turquette 2012-03-15 867
a63347251907d7 Stephen Boyd 2015-05-06 868 lockdep_assert_held(&prepare_lock);
a63347251907d7 Stephen Boyd 2015-05-06 869
4dff95dc9477a3 Stephen Boyd 2015-04-30 870 if (!core)
4dff95dc9477a3 Stephen Boyd 2015-04-30 871 return 0;
b2476490ef1113 Mike Turquette 2012-03-15 872
4dff95dc9477a3 Stephen Boyd 2015-04-30 873 if (core->prepare_count == 0) {
9a34b45397e5a3 Marek Szyprowski 2017-08-21 874 ret = clk_pm_runtime_get(core);
4dff95dc9477a3 Stephen Boyd 2015-04-30 875 if (ret)
4dff95dc9477a3 Stephen Boyd 2015-04-30 876 return ret;
b2476490ef1113 Mike Turquette 2012-03-15 877
9a34b45397e5a3 Marek Szyprowski 2017-08-21 878 ret = clk_core_prepare(core->parent);
9a34b45397e5a3 Marek Szyprowski 2017-08-21 879 if (ret)
9a34b45397e5a3 Marek Szyprowski 2017-08-21 880 goto runtime_put;
9a34b45397e5a3 Marek Szyprowski 2017-08-21 881
4dff95dc9477a3 Stephen Boyd 2015-04-30 882 trace_clk_prepare(core);
1c155b3dfe0835 Ulf Hansson 2013-03-12 883
4dff95dc9477a3 Stephen Boyd 2015-04-30 884 if (core->ops->prepare)
4dff95dc9477a3 Stephen Boyd 2015-04-30 885 ret = core->ops->prepare(core->hw);
1c155b3dfe0835 Ulf Hansson 2013-03-12 886
4dff95dc9477a3 Stephen Boyd 2015-04-30 887 trace_clk_prepare_complete(core);
b2476490ef1113 Mike Turquette 2012-03-15 888
9a34b45397e5a3 Marek Szyprowski 2017-08-21 889 if (ret)
9a34b45397e5a3 Marek Szyprowski 2017-08-21 890 goto unprepare;
b2476490ef1113 Mike Turquette 2012-03-15 891 }
b2476490ef1113 Mike Turquette 2012-03-15 892
4dff95dc9477a3 Stephen Boyd 2015-04-30 893 core->prepare_count++;
b2476490ef1113 Mike Turquette 2012-03-15 894
9461f7b33d11cb Jerome Brunet 2018-06-19 895 /*
9461f7b33d11cb Jerome Brunet 2018-06-19 896 * CLK_SET_RATE_GATE is a special case of clock protection
9461f7b33d11cb Jerome Brunet 2018-06-19 897 * Instead of a consumer claiming exclusive rate control, it is
9461f7b33d11cb Jerome Brunet 2018-06-19 898 * actually the provider which prevents any consumer from making any
9461f7b33d11cb Jerome Brunet 2018-06-19 899 * operation which could result in a rate change or rate glitch while
9461f7b33d11cb Jerome Brunet 2018-06-19 900 * the clock is prepared.
9461f7b33d11cb Jerome Brunet 2018-06-19 901 */
9461f7b33d11cb Jerome Brunet 2018-06-19 902 if (core->flags & CLK_SET_RATE_GATE)
9461f7b33d11cb Jerome Brunet 2018-06-19 903 clk_core_rate_protect(core);
9461f7b33d11cb Jerome Brunet 2018-06-19 904
4dff95dc9477a3 Stephen Boyd 2015-04-30 905 return 0;
9a34b45397e5a3 Marek Szyprowski 2017-08-21 906 unprepare:
9a34b45397e5a3 Marek Szyprowski 2017-08-21 907 clk_core_unprepare(core->parent);
9a34b45397e5a3 Marek Szyprowski 2017-08-21 908 runtime_put:
9a34b45397e5a3 Marek Szyprowski 2017-08-21 909 clk_pm_runtime_put(core);
9a34b45397e5a3 Marek Szyprowski 2017-08-21 910 return ret;
b2476490ef1113 Mike Turquette 2012-03-15 911 }
b2476490ef1113 Mike Turquette 2012-03-15 912
a6adc30ba7bef8 Dong Aisheng 2016-06-30 913 static int clk_core_prepare_lock(struct clk_core *core)
a6adc30ba7bef8 Dong Aisheng 2016-06-30 914 {
a6adc30ba7bef8 Dong Aisheng 2016-06-30 915 int ret;
a6adc30ba7bef8 Dong Aisheng 2016-06-30 916
a6adc30ba7bef8 Dong Aisheng 2016-06-30 917 clk_prepare_lock();
a6adc30ba7bef8 Dong Aisheng 2016-06-30 918 ret = clk_core_prepare(core);
a6adc30ba7bef8 Dong Aisheng 2016-06-30 919 clk_prepare_unlock();
a6adc30ba7bef8 Dong Aisheng 2016-06-30 920
a6adc30ba7bef8 Dong Aisheng 2016-06-30 921 return ret;
a6adc30ba7bef8 Dong Aisheng 2016-06-30 922 }
a6adc30ba7bef8 Dong Aisheng 2016-06-30 923
4dff95dc9477a3 Stephen Boyd 2015-04-30 924 /**
4dff95dc9477a3 Stephen Boyd 2015-04-30 925 * clk_prepare - prepare a clock source
4dff95dc9477a3 Stephen Boyd 2015-04-30 926 * @clk: the clk being prepared
4dff95dc9477a3 Stephen Boyd 2015-04-30 927 *
4dff95dc9477a3 Stephen Boyd 2015-04-30 928 * clk_prepare may sleep, which differentiates it from clk_enable. In a simple
4dff95dc9477a3 Stephen Boyd 2015-04-30 929 * case, clk_prepare can be used instead of clk_enable to ungate a clk if the
4dff95dc9477a3 Stephen Boyd 2015-04-30 930 * operation may sleep. One example is a clk which is accessed over I2c. In
4dff95dc9477a3 Stephen Boyd 2015-04-30 931 * the complex case a clk ungate operation may require a fast and a slow part.
4dff95dc9477a3 Stephen Boyd 2015-04-30 932 * It is this reason that clk_prepare and clk_enable are not mutually
4dff95dc9477a3 Stephen Boyd 2015-04-30 933 * exclusive. In fact clk_prepare must be called before clk_enable.
4dff95dc9477a3 Stephen Boyd 2015-04-30 934 * Returns 0 on success, -EERROR otherwise.
4dff95dc9477a3 Stephen Boyd 2015-04-30 935 */
4dff95dc9477a3 Stephen Boyd 2015-04-30 @936 int clk_prepare(struct clk *clk)
b2476490ef1113 Mike Turquette 2012-03-15 937 {
035a61c314eb3d Tomeu Vizoso 2015-01-23 938 if (!clk)
4dff95dc9477a3 Stephen Boyd 2015-04-30 939 return 0;
035a61c314eb3d Tomeu Vizoso 2015-01-23 940
a6adc30ba7bef8 Dong Aisheng 2016-06-30 941 return clk_core_prepare_lock(clk->core);
7ef3dcc8145263 James Hogan 2013-07-29 942 }
4dff95dc9477a3 Stephen Boyd 2015-04-30 943 EXPORT_SYMBOL_GPL(clk_prepare);
035a61c314eb3d Tomeu Vizoso 2015-01-23 944
:::::: The code at line 855 was first introduced by commit
:::::: 4dff95dc9477a34de77d24c59dcf1dc593687fcf clk: Remove forward declared function prototypes
:::::: TO: Stephen Boyd <sboyd(a)codeaurora.org>
:::::: CC: Stephen Boyd <sboyd(a)codeaurora.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 2 months