June 2021 - kbuild-all

Re: [PATCH 15/15] RFC: drm/amdgpu: Implement a proper implicit fencing uapi

by kernel test robot

Hi Daniel, [FYI, it's a private test report for your RFC patch.] [auto build test WARNING on drm-tip/drm-tip] [cannot apply to sunxi/sunxi/for-next drm-intel/for-linux-next linus/master linux-arm/drm-armada-devel linux-arm/drm-armada-fixes v5.13-rc7 next-20210622] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Daniel-Vetter/implicit-fencing-d... base: git://anongit.freedesktop.org/drm/drm-tip drm-tip config: x86_64-randconfig-s031-20210622 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.3-341-g8af24329-dirty # https://github.com/0day-ci/linux/commit/42de2bd7635cf7c6d79494a3a35512c53... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Daniel-Vetter/implicit-fencing-dma-resv-rules-for-shared-buffers/20210623-005623 git checkout 42de2bd7635cf7c6d79494a3a35512c53196524f # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com> All warnings (new ones prefixed by >>): >> drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c:1727:5: warning: no previous prototype for 'amdgpu_setparam_ioctl' [-Wmissing-prototypes] 1727 | int amdgpu_setparam_ioctl(struct drm_device *dev, void *data, | ^~~~~~~~~~~~~~~~~~~~~ vim +/amdgpu_setparam_ioctl +1727 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c 1726 > 1727 int amdgpu_setparam_ioctl(struct drm_device *dev, void *data, 1728 struct drm_file *filp) 1729 { 1730 struct drm_amdgpu_setparam *setparam = data; 1731 struct amdgpu_fpriv *fpriv = filp->driver_priv; 1732 1733 switch (setparam->param) { 1734 case AMDGPU_SETPARAM_NO_IMPLICIT_SYNC: 1735 if (setparam->value) 1736 WRITE_ONCE(fpriv->vm.no_implicit_sync, true); 1737 else 1738 WRITE_ONCE(fpriv->vm.no_implicit_sync, false); 1739 break; 1740 default: 1741 return -EINVAL; 1742 } 1743 1744 return 0; 1745 } 1746 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

1 year, 2 months

1
0
0 / 0

[ti:ti-linux-5.10.y 6232/6239] drivers/net/ethernet/ti/cpsw.c:916:15: warning: variable 'len' set but not used

by kernel test robot

tree: git://git.ti.com/ti-linux-kernel/ti-linux-kernel.git ti-linux-5.10.y head: f7b090401f267663c4885c918e959557b43c91f9 commit: 6853acd9be4e17522e3c3b2ec30c3ce8e46b6b9e [6232/6239] HACK: net: ethernet: ti: cpsw: allow to configure min tx packet size config: arm-randconfig-p001-20210622 (attached as .config) compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git remote add ti git://git.ti.com/ti-linux-kernel/ti-linux-kernel.git git fetch --no-tags ti ti-linux-5.10.y git checkout 6853acd9be4e17522e3c3b2ec30c3ce8e46b6b9e # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com> All warnings (new ones prefixed by >>): drivers/net/ethernet/ti/cpsw.c: In function 'cpsw_ndo_start_xmit': >> drivers/net/ethernet/ti/cpsw.c:916:15: warning: variable 'len' set but not used [-Wunused-but-set-variable] 916 | unsigned int len; | ^~~ cppcheck possible warnings: (new ones prefixed by >>, may not real problems) ^ >> drivers/net/ethernet/ti/cpsw_priv.h:406:21: warning: Unused variable: ndev [unusedVariable] struct net_device *ndev; ^ >> drivers/net/ethernet/ti/cpsw_priv.h:407:6: warning: Unused variable: ch [unusedVariable] int ch; ^ vim +/len +916 drivers/net/ethernet/ti/cpsw.c 907 908 static netdev_tx_t cpsw_ndo_start_xmit(struct sk_buff *skb, 909 struct net_device *ndev) 910 { 911 struct cpsw_priv *priv = netdev_priv(ndev); 912 struct cpsw_common *cpsw = priv->cpsw; 913 struct cpts *cpts = cpsw->cpts; 914 struct netdev_queue *txq; 915 struct cpdma_chan *txch; > 916 unsigned int len; 917 int ret, q_idx; 918 919 if (skb_padto(skb, tx_packet_min)) { 920 cpsw_err(priv, tx_err, "packet pad failed\n"); 921 ndev->stats.tx_dropped++; 922 return NET_XMIT_DROP; 923 } 924 925 len = skb->len < tx_packet_min ? tx_packet_min : skb->len; 926 927 if (skb_shinfo(skb)->tx_flags & SKBTX_HW_TSTAMP && 928 priv->tx_ts_enabled && cpts_can_timestamp(cpts, skb)) 929 skb_shinfo(skb)->tx_flags |= SKBTX_IN_PROGRESS; 930 931 q_idx = skb_get_queue_mapping(skb); 932 if (q_idx >= cpsw->tx_ch_num) 933 q_idx = q_idx % cpsw->tx_ch_num; 934 935 txch = cpsw->txv[q_idx].ch; 936 txq = netdev_get_tx_queue(ndev, q_idx); 937 skb_tx_timestamp(skb); 938 ret = cpdma_chan_submit(txch, skb, skb->data, skb->len, 939 priv->emac_port + cpsw->data.dual_emac); 940 if (unlikely(ret != 0)) { 941 cpsw_err(priv, tx_err, "desc submit failed\n"); 942 goto fail; 943 } 944 945 /* If there is no more tx desc left free then we need to 946 * tell the kernel to stop sending us tx frames. 947 */ 948 if (unlikely(!cpdma_check_free_tx_desc(txch))) { 949 netif_tx_stop_queue(txq); 950 951 /* Barrier, so that stop_queue visible to other cpus */ 952 smp_mb__after_atomic(); 953 954 if (cpdma_check_free_tx_desc(txch)) 955 netif_tx_wake_queue(txq); 956 } 957 958 return NETDEV_TX_OK; 959 fail: 960 ndev->stats.tx_dropped++; 961 netif_tx_stop_queue(txq); 962 963 /* Barrier, so that stop_queue visible to other cpus */ 964 smp_mb__after_atomic(); 965 966 if (cpdma_check_free_tx_desc(txch)) 967 netif_tx_wake_queue(txq); 968 969 return NETDEV_TX_BUSY; 970 } 971 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

1 year, 2 months

1
0
0 / 0

[peterz-queue:perf/core 10/10] kernel/events/core.c:3831:30: warning: 'cpuctx' is used uninitialized in this function

by kernel test robot

tree: https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git perf/core head: a918097a296b40b4e4f7a75edf4380a293b84eb5 commit: a918097a296b40b4e4f7a75edf4380a293b84eb5 [10/10] perf: Fix task context PMU for Hetero config: nds32-randconfig-r002-20210622 (attached as .config) compiler: nds32le-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git/commit/?... git remote add peterz-queue https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git git fetch --no-tags peterz-queue perf/core git checkout a918097a296b40b4e4f7a75edf4380a293b84eb5 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nds32 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com> All warnings (new ones prefixed by >>): kernel/events/core.c: In function 'perf_event_context_sched_in': >> kernel/events/core.c:3831:30: warning: 'cpuctx' is used uninitialized in this function [-Wuninitialized] 3831 | pmu = ctx->pmu = cpuctx->ctx.pmu; | ~~~~~~~~~~~^~~~ vim +/cpuctx +3831 kernel/events/core.c 3820 3821 static void perf_event_context_sched_in(struct perf_event_context *ctx, 3822 struct task_struct *task) 3823 { 3824 struct perf_cpu_context *cpuctx; 3825 struct pmu *pmu; 3826 3827 /* 3828 * HACK: for HETEROGENEOUS the task context might have switched to a 3829 * different PMU, force (re)set the context, 3830 */ > 3831 pmu = ctx->pmu = cpuctx->ctx.pmu; 3832 3833 cpuctx = __get_cpu_context(ctx); 3834 if (cpuctx->task_ctx == ctx) { 3835 if (cpuctx->sched_cb_usage) 3836 __perf_pmu_sched_task(cpuctx, true); 3837 return; 3838 } 3839 3840 perf_ctx_lock(cpuctx, ctx); 3841 /* 3842 * We must check ctx->nr_events while holding ctx->lock, such 3843 * that we serialize against perf_install_in_context(). 3844 */ 3845 if (!ctx->nr_events) 3846 goto unlock; 3847 3848 perf_pmu_disable(pmu); 3849 /* 3850 * We want to keep the following priority order: 3851 * cpu pinned (that don't need to move), task pinned, 3852 * cpu flexible, task flexible. 3853 * 3854 * However, if task's ctx is not carrying any pinned 3855 * events, no need to flip the cpuctx's events around. 3856 */ 3857 if (!RB_EMPTY_ROOT(&ctx->pinned_groups.tree)) 3858 cpu_ctx_sched_out(cpuctx, EVENT_FLEXIBLE); 3859 perf_event_sched_in(cpuctx, ctx, task); 3860 3861 if (cpuctx->sched_cb_usage && pmu->sched_task) 3862 pmu->sched_task(cpuctx->task_ctx, true); 3863 3864 perf_pmu_enable(pmu); 3865 3866 unlock: 3867 perf_ctx_unlock(cpuctx, ctx); 3868 } 3869 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

1 year, 2 months

1
0
0 / 0

[xiang-linux:misc 2/2] arc-elf-ld: nfs3proc.c:undefined reference to `get_acl'

by kernel test robot

tree: https://git.kernel.org/pub/scm/linux/kernel/git/xiang/linux.git misc head: 42e87120aa8e1fc3b67db346fa291bede4c6b2b6 commit: 42e87120aa8e1fc3b67db346fa291bede4c6b2b6 [2/2] nfs: NFSv3: fix SGID bit dropped when inheriting ACLs config: arc-haps_hs_smp_defconfig (attached as .config) compiler: arc-elf-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://git.kernel.org/pub/scm/linux/kernel/git/xiang/linux.git/commit/?i... git remote add xiang-linux https://git.kernel.org/pub/scm/linux/kernel/git/xiang/linux.git git fetch --no-tags xiang-linux misc git checkout 42e87120aa8e1fc3b67db346fa291bede4c6b2b6 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com> All errors (new ones prefixed by >>): arc-elf-ld: fs/nfs/nfs3proc.o: in function `nfs3_proc_mkdir': nfs3proc.c:(.text+0xb8e): undefined reference to `get_acl' >> arc-elf-ld: nfs3proc.c:(.text+0xb8e): undefined reference to `get_acl' arc-elf-ld: fs/nfs/nfs3proc.o: in function `nfs3_proc_mknod': nfs3proc.c:(.text+0xf90): undefined reference to `get_acl' arc-elf-ld: nfs3proc.c:(.text+0xf90): undefined reference to `get_acl' arc-elf-ld: fs/nfs/nfs3proc.o: in function `nfs3_proc_create': nfs3proc.c:(.text+0x11a2): undefined reference to `get_acl' arc-elf-ld: fs/nfs/nfs3proc.o:nfs3proc.c:(.text+0x11a2): more undefined references to `get_acl' follow --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

1 year, 2 months

1
0
0 / 0

[xiang-linux:misc 2/2] ERROR: modpost: "get_acl" [fs/nfs/nfsv3.ko] undefined!

by kernel test robot

tree: https://git.kernel.org/pub/scm/linux/kernel/git/xiang/linux.git misc head: 42e87120aa8e1fc3b67db346fa291bede4c6b2b6 commit: 42e87120aa8e1fc3b67db346fa291bede4c6b2b6 [2/2] nfs: NFSv3: fix SGID bit dropped when inheriting ACLs config: parisc-defconfig (attached as .config) compiler: hppa-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://git.kernel.org/pub/scm/linux/kernel/git/xiang/linux.git/commit/?i... git remote add xiang-linux https://git.kernel.org/pub/scm/linux/kernel/git/xiang/linux.git git fetch --no-tags xiang-linux misc git checkout 42e87120aa8e1fc3b67db346fa291bede4c6b2b6 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=parisc If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com> All errors (new ones prefixed by >>, old ones prefixed by <<): >> ERROR: modpost: "get_acl" [fs/nfs/nfsv3.ko] undefined! --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

1 year, 2 months

1
0
0 / 0

[peterz-queue:perf/core 10/10] kernel/events/core.c:3831:19: warning: variable 'cpuctx' is uninitialized when used here

by kernel test robot

tree: https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git perf/core head: a918097a296b40b4e4f7a75edf4380a293b84eb5 commit: a918097a296b40b4e4f7a75edf4380a293b84eb5 [10/10] perf: Fix task context PMU for Hetero config: x86_64-randconfig-a002-20210622 (attached as .config) compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project b3634d3e88b7f26534a5057bff182b7dced584fc) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu # https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git/commit/?... git remote add peterz-queue https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git git fetch --no-tags peterz-queue perf/core git checkout a918097a296b40b4e4f7a75edf4380a293b84eb5 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com> All warnings (new ones prefixed by >>): >> kernel/events/core.c:3831:19: warning: variable 'cpuctx' is uninitialized when used here [-Wuninitialized] pmu = ctx->pmu = cpuctx->ctx.pmu; ^~~~~~ kernel/events/core.c:3824:33: note: initialize the variable 'cpuctx' to silence this warning struct perf_cpu_context *cpuctx; ^ = NULL kernel/events/core.c:1097:1: warning: unused function 'perf_cgroup_switch' [-Wunused-function] perf_cgroup_switch(struct task_struct *task, struct task_struct *next) ^ 2 warnings generated. vim +/cpuctx +3831 kernel/events/core.c 3820 3821 static void perf_event_context_sched_in(struct perf_event_context *ctx, 3822 struct task_struct *task) 3823 { 3824 struct perf_cpu_context *cpuctx; 3825 struct pmu *pmu; 3826 3827 /* 3828 * HACK: for HETEROGENEOUS the task context might have switched to a 3829 * different PMU, force (re)set the context, 3830 */ > 3831 pmu = ctx->pmu = cpuctx->ctx.pmu; 3832 3833 cpuctx = __get_cpu_context(ctx); 3834 if (cpuctx->task_ctx == ctx) { 3835 if (cpuctx->sched_cb_usage) 3836 __perf_pmu_sched_task(cpuctx, true); 3837 return; 3838 } 3839 3840 perf_ctx_lock(cpuctx, ctx); 3841 /* 3842 * We must check ctx->nr_events while holding ctx->lock, such 3843 * that we serialize against perf_install_in_context(). 3844 */ 3845 if (!ctx->nr_events) 3846 goto unlock; 3847 3848 perf_pmu_disable(pmu); 3849 /* 3850 * We want to keep the following priority order: 3851 * cpu pinned (that don't need to move), task pinned, 3852 * cpu flexible, task flexible. 3853 * 3854 * However, if task's ctx is not carrying any pinned 3855 * events, no need to flip the cpuctx's events around. 3856 */ 3857 if (!RB_EMPTY_ROOT(&ctx->pinned_groups.tree)) 3858 cpu_ctx_sched_out(cpuctx, EVENT_FLEXIBLE); 3859 perf_event_sched_in(cpuctx, ctx, task); 3860 3861 if (cpuctx->sched_cb_usage && pmu->sched_task) 3862 pmu->sched_task(cpuctx->task_ctx, true); 3863 3864 perf_pmu_enable(pmu); 3865 3866 unlock: 3867 perf_ctx_unlock(cpuctx, ctx); 3868 } 3869 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

1 year, 2 months

1
0
0 / 0

[linux-next:master 11974/12271] drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn31/display_rq_dlg_calc_31.c:939:13: warning: stack frame size of 2400 bytes in function 'dml_rq_dlg_get_dlg_params'

by kernel test robot

Hi Alex, First bad commit (maybe != root cause): tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 4238b1710eadd18dd16de0288a2bc5bb84614b4e commit: 2631b42588c114dbb29d06934cfa742e5fe0897f [11974/12271] drm/amdgpu/display: fold DRM_AMD_DC_DCN3_1 into DRM_AMD_DC_DCN config: powerpc64-randconfig-r001-20210622 (attached as .config) compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project b3634d3e88b7f26534a5057bff182b7dced584fc) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install powerpc64 cross compiling tool for clang build # apt-get install binutils-powerpc64-linux-gnu # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commi... git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git git fetch --no-tags linux-next master git checkout 2631b42588c114dbb29d06934cfa742e5fe0897f # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com> All warnings (new ones prefixed by >>): In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn31/display_rq_dlg_calc_31.c:26: In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn31/../display_mode_lib.h:28: In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dm_services.h:35: In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dm_services_types.h:29: In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/os_types.h:30: In file included from include/linux/kgdb.h:18: In file included from include/linux/atomic.h:7: In file included from arch/powerpc/include/asm/atomic.h:11: In file included from arch/powerpc/include/asm/cmpxchg.h:8: In file included from include/linux/bug.h:5: In file included from arch/powerpc/include/asm/bug.h:109: In file included from include/asm-generic/bug.h:20: In file included from include/linux/kernel.h:12: In file included from include/linux/bitops.h:32: In file included from arch/powerpc/include/asm/bitops.h:62: arch/powerpc/include/asm/barrier.h:49:9: warning: '__lwsync' macro redefined [-Wmacro-redefined] #define __lwsync() __asm__ __volatile__ (stringify_in_c(LWSYNC) : : :"memory") ^ <built-in>:309:9: note: previous definition is here #define __lwsync __builtin_ppc_lwsync ^ drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn31/display_rq_dlg_calc_31.c:1006:15: warning: variable 'dppclk_delay_subtotal' set but not used [-Wunused-but-set-variable] unsigned int dppclk_delay_subtotal; ^ drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn31/display_rq_dlg_calc_31.c:1007:15: warning: variable 'dispclk_delay_subtotal' set but not used [-Wunused-but-set-variable] unsigned int dispclk_delay_subtotal; ^ >> drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn31/display_rq_dlg_calc_31.c:939:13: warning: stack frame size of 2400 bytes in function 'dml_rq_dlg_get_dlg_params' [-Wframe-larger-than] static void dml_rq_dlg_get_dlg_params( ^ 4 warnings generated. vim +/dml_rq_dlg_get_dlg_params +939 drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn31/display_rq_dlg_calc_31.c 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 936 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 937 // Note: currently taken in as is. 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 938 // Nice to decouple code from hw register implement and extract code that are repeated for luma and chroma. 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 @939 static void dml_rq_dlg_get_dlg_params( 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 940 struct display_mode_lib *mode_lib, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 941 const display_e2e_pipe_params_st *e2e_pipe_param, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 942 const unsigned int num_pipes, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 943 const unsigned int pipe_idx, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 944 display_dlg_regs_st *disp_dlg_regs, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 945 display_ttu_regs_st *disp_ttu_regs, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 946 const display_rq_dlg_params_st rq_dlg_param, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 947 const display_dlg_sys_params_st dlg_sys_param, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 948 const bool cstate_en, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 949 const bool pstate_en, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 950 const bool vm_en, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 951 const bool ignore_viewport_pos, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 952 const bool immediate_flip_support) 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 953 { 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 954 const display_pipe_source_params_st *src = &e2e_pipe_param[pipe_idx].pipe.src; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 955 const display_pipe_dest_params_st *dst = &e2e_pipe_param[pipe_idx].pipe.dest; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 956 const display_output_params_st *dout = &e2e_pipe_param[pipe_idx].dout; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 957 const display_clocks_and_cfg_st *clks = &e2e_pipe_param[pipe_idx].clks_cfg; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 958 const scaler_ratio_depth_st *scl = &e2e_pipe_param[pipe_idx].pipe.scale_ratio_depth; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 959 const scaler_taps_st *taps = &e2e_pipe_param[pipe_idx].pipe.scale_taps; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 960 unsigned int pipe_index_in_combine[DC__NUM_PIPES__MAX]; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 961 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 962 // ------------------------- 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 963 // Section 1.15.2.1: OTG dependent Params 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 964 // ------------------------- 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 965 // Timing 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 966 unsigned int htotal = dst->htotal; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 967 unsigned int hblank_end = dst->hblank_end; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 968 unsigned int vblank_start = dst->vblank_start; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 969 unsigned int vblank_end = dst->vblank_end; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 970 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 971 double dppclk_freq_in_mhz = clks->dppclk_mhz; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 972 double refclk_freq_in_mhz = clks->refclk_mhz; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 973 double pclk_freq_in_mhz = dst->pixel_rate_mhz; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 974 bool interlaced = dst->interlaced; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 975 double ref_freq_to_pix_freq = refclk_freq_in_mhz / pclk_freq_in_mhz; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 976 double min_ttu_vblank; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 977 unsigned int dlg_vblank_start; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 978 bool dual_plane; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 979 bool mode_422; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 980 unsigned int access_dir; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 981 unsigned int vp_height_l; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 982 unsigned int vp_width_l; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 983 unsigned int vp_height_c; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 984 unsigned int vp_width_c; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 985 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 986 // Scaling 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 987 unsigned int htaps_l; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 988 unsigned int htaps_c; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 989 double hratio_l; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 990 double hratio_c; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 991 double vratio_l; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 992 double vratio_c; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 993 bool scl_enable; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 994 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 995 unsigned int swath_width_ub_l; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 996 unsigned int dpte_groups_per_row_ub_l; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 997 unsigned int swath_width_ub_c; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 998 unsigned int dpte_groups_per_row_ub_c; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 999 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1000 unsigned int meta_chunks_per_row_ub_l; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1001 unsigned int meta_chunks_per_row_ub_c; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1002 unsigned int vupdate_offset; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1003 unsigned int vupdate_width; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1004 unsigned int vready_offset; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1005 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1006 unsigned int dppclk_delay_subtotal; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1007 unsigned int dispclk_delay_subtotal; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1008 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1009 unsigned int vstartup_start; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1010 unsigned int dst_x_after_scaler; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1011 unsigned int dst_y_after_scaler; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1012 double dst_y_prefetch; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1013 double dst_y_per_vm_vblank; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1014 double dst_y_per_row_vblank; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1015 double dst_y_per_vm_flip; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1016 double dst_y_per_row_flip; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1017 double max_dst_y_per_vm_vblank; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1018 double max_dst_y_per_row_vblank; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1019 double vratio_pre_l; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1020 double vratio_pre_c; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1021 unsigned int req_per_swath_ub_l; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1022 unsigned int req_per_swath_ub_c; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1023 unsigned int meta_row_height_l; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1024 unsigned int meta_row_height_c; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1025 unsigned int swath_width_pixels_ub_l; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1026 unsigned int swath_width_pixels_ub_c; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1027 unsigned int scaler_rec_in_width_l; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1028 unsigned int scaler_rec_in_width_c; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1029 unsigned int dpte_row_height_l; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1030 unsigned int dpte_row_height_c; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1031 double hscale_pixel_rate_l; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1032 double hscale_pixel_rate_c; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1033 double min_hratio_fact_l; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1034 double min_hratio_fact_c; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1035 double refcyc_per_line_delivery_pre_l; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1036 double refcyc_per_line_delivery_pre_c; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1037 double refcyc_per_line_delivery_l; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1038 double refcyc_per_line_delivery_c; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1039 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1040 double refcyc_per_req_delivery_pre_l; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1041 double refcyc_per_req_delivery_pre_c; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1042 double refcyc_per_req_delivery_l; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1043 double refcyc_per_req_delivery_c; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1044 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1045 unsigned int full_recout_width; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1046 double refcyc_per_req_delivery_pre_cur0; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1047 double refcyc_per_req_delivery_cur0; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1048 double refcyc_per_req_delivery_pre_cur1; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1049 double refcyc_per_req_delivery_cur1; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1050 int unsigned vba__min_dst_y_next_start = get_min_dst_y_next_start(mode_lib, e2e_pipe_param, num_pipes, pipe_idx); // FROM VBA 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1051 int unsigned vba__vready_after_vcount0 = get_vready_at_or_after_vsync(mode_lib, e2e_pipe_param, num_pipes, pipe_idx); // From VBA 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1052 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1053 float vba__refcyc_per_line_delivery_pre_l = get_refcyc_per_line_delivery_pre_l_in_us(mode_lib, e2e_pipe_param, num_pipes, pipe_idx) * refclk_freq_in_mhz; // From VBA 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1054 float vba__refcyc_per_line_delivery_l = get_refcyc_per_line_delivery_l_in_us(mode_lib, e2e_pipe_param, num_pipes, pipe_idx) * refclk_freq_in_mhz; // From VBA 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1055 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1056 float vba__refcyc_per_req_delivery_pre_l = get_refcyc_per_req_delivery_pre_l_in_us(mode_lib, e2e_pipe_param, num_pipes, pipe_idx) * refclk_freq_in_mhz; // From VBA 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1057 float vba__refcyc_per_req_delivery_l = get_refcyc_per_req_delivery_l_in_us(mode_lib, e2e_pipe_param, num_pipes, pipe_idx) * refclk_freq_in_mhz; // From VBA 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1058 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1059 memset(disp_dlg_regs, 0, sizeof(*disp_dlg_regs)); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1060 memset(disp_ttu_regs, 0, sizeof(*disp_ttu_regs)); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1061 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1062 dml_print("DML_DLG: %s: cstate_en = %d\n", __func__, cstate_en); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1063 dml_print("DML_DLG: %s: pstate_en = %d\n", __func__, pstate_en); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1064 dml_print("DML_DLG: %s: vm_en = %d\n", __func__, vm_en); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1065 dml_print("DML_DLG: %s: ignore_viewport_pos = %d\n", __func__, ignore_viewport_pos); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1066 dml_print("DML_DLG: %s: immediate_flip_support = %d\n", __func__, immediate_flip_support); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1067 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1068 dml_print("DML_DLG: %s: dppclk_freq_in_mhz = %3.2f\n", __func__, dppclk_freq_in_mhz); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1069 dml_print("DML_DLG: %s: refclk_freq_in_mhz = %3.2f\n", __func__, refclk_freq_in_mhz); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1070 dml_print("DML_DLG: %s: pclk_freq_in_mhz = %3.2f\n", __func__, pclk_freq_in_mhz); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1071 dml_print("DML_DLG: %s: interlaced = %d\n", __func__, interlaced); ASSERT(ref_freq_to_pix_freq < 4.0); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1072 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1073 disp_dlg_regs->ref_freq_to_pix_freq = (unsigned int) (ref_freq_to_pix_freq * dml_pow(2, 19)); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1074 disp_dlg_regs->refcyc_per_htotal = (unsigned int) (ref_freq_to_pix_freq * (double) htotal * dml_pow(2, 8)); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1075 disp_dlg_regs->dlg_vblank_end = interlaced ? (vblank_end / 2) : vblank_end; // 15 bits 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1076 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1077 //set_prefetch_mode(mode_lib, cstate_en, pstate_en, ignore_viewport_pos, immediate_flip_support); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1078 min_ttu_vblank = get_min_ttu_vblank_in_us(mode_lib, e2e_pipe_param, num_pipes, pipe_idx); // From VBA 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1079 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1080 dlg_vblank_start = interlaced ? (vblank_start / 2) : vblank_start; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1081 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1082 disp_dlg_regs->min_dst_y_next_start = (unsigned int) (((double) dlg_vblank_start) * dml_pow(2, 2)); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1083 ASSERT(disp_dlg_regs->min_dst_y_next_start < (unsigned int)dml_pow(2, 18)); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1084 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1085 dml_print("DML_DLG: %s: min_ttu_vblank (us) = %3.2f\n", __func__, min_ttu_vblank); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1086 dml_print("DML_DLG: %s: min_dst_y_next_start = 0x%0x\n", __func__, disp_dlg_regs->min_dst_y_next_start); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1087 dml_print("DML_DLG: %s: dlg_vblank_start = 0x%0x\n", __func__, dlg_vblank_start); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1088 dml_print("DML_DLG: %s: ref_freq_to_pix_freq = %3.2f\n", __func__, ref_freq_to_pix_freq); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1089 dml_print("DML_DLG: %s: vba__min_dst_y_next_start = 0x%0x\n", __func__, vba__min_dst_y_next_start); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1090 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1091 //old_impl_vs_vba_impl("min_dst_y_next_start", dlg_vblank_start, vba__min_dst_y_next_start); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1092 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1093 // ------------------------- 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1094 // Section 1.15.2.2: Prefetch, Active and TTU 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1095 // ------------------------- 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1096 // Prefetch Calc 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1097 // Source 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1098 dual_plane = is_dual_plane((enum source_format_class) (src->source_format)); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1099 mode_422 = 0; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1100 access_dir = (src->source_scan == dm_vert); // vp access direction: horizontal or vertical accessed 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1101 vp_height_l = src->viewport_height; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1102 vp_width_l = src->viewport_width; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1103 vp_height_c = src->viewport_height_c; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1104 vp_width_c = src->viewport_width_c; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1105 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1106 // Scaling 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1107 htaps_l = taps->htaps; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1108 htaps_c = taps->htaps_c; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1109 hratio_l = scl->hscl_ratio; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1110 hratio_c = scl->hscl_ratio_c; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1111 vratio_l = scl->vscl_ratio; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1112 vratio_c = scl->vscl_ratio_c; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1113 scl_enable = scl->scl_enable; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1114 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1115 swath_width_ub_l = rq_dlg_param.rq_l.swath_width_ub; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1116 dpte_groups_per_row_ub_l = rq_dlg_param.rq_l.dpte_groups_per_row_ub; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1117 swath_width_ub_c = rq_dlg_param.rq_c.swath_width_ub; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1118 dpte_groups_per_row_ub_c = rq_dlg_param.rq_c.dpte_groups_per_row_ub; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1119 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1120 meta_chunks_per_row_ub_l = rq_dlg_param.rq_l.meta_chunks_per_row_ub; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1121 meta_chunks_per_row_ub_c = rq_dlg_param.rq_c.meta_chunks_per_row_ub; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1122 vupdate_offset = dst->vupdate_offset; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1123 vupdate_width = dst->vupdate_width; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1124 vready_offset = dst->vready_offset; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1125 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1126 dppclk_delay_subtotal = mode_lib->ip.dppclk_delay_subtotal; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1127 dispclk_delay_subtotal = mode_lib->ip.dispclk_delay_subtotal; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1128 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1129 if (scl_enable) 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1130 dppclk_delay_subtotal += mode_lib->ip.dppclk_delay_scl; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1131 else 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1132 dppclk_delay_subtotal += mode_lib->ip.dppclk_delay_scl_lb_only; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1133 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1134 dppclk_delay_subtotal += mode_lib->ip.dppclk_delay_cnvc_formatter + src->num_cursors * mode_lib->ip.dppclk_delay_cnvc_cursor; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1135 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1136 if (dout->dsc_enable) { 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1137 double dsc_delay = get_dsc_delay(mode_lib, e2e_pipe_param, num_pipes, pipe_idx); // FROM VBA 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1138 dispclk_delay_subtotal += dsc_delay; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1139 } 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1140 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1141 vstartup_start = dst->vstartup_start; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1142 if (interlaced) { 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1143 if (vstartup_start / 2.0 - (double) (vready_offset + vupdate_width + vupdate_offset) / htotal <= vblank_end / 2.0) 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1144 disp_dlg_regs->vready_after_vcount0 = 1; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1145 else 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1146 disp_dlg_regs->vready_after_vcount0 = 0; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1147 } else { 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1148 if (vstartup_start - (double) (vready_offset + vupdate_width + vupdate_offset) / htotal <= vblank_end) 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1149 disp_dlg_regs->vready_after_vcount0 = 1; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1150 else 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1151 disp_dlg_regs->vready_after_vcount0 = 0; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1152 } 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1153 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1154 dml_print("DML_DLG: %s: vready_after_vcount0 = %d\n", __func__, disp_dlg_regs->vready_after_vcount0); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1155 dml_print("DML_DLG: %s: vba__vready_after_vcount0 = %d\n", __func__, vba__vready_after_vcount0); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1156 //old_impl_vs_vba_impl("vready_after_vcount0", disp_dlg_regs->vready_after_vcount0, vba__vready_after_vcount0); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1157 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1158 if (interlaced) 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1159 vstartup_start = vstartup_start / 2; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1160 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1161 dst_x_after_scaler = get_dst_x_after_scaler(mode_lib, e2e_pipe_param, num_pipes, pipe_idx); // From VBA 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1162 dst_y_after_scaler = get_dst_y_after_scaler(mode_lib, e2e_pipe_param, num_pipes, pipe_idx); // From VBA 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1163 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1164 // do some adjustment on the dst_after scaler to account for odm combine mode 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1165 dml_print("DML_DLG: %s: input dst_x_after_scaler = %d\n", __func__, dst_x_after_scaler); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1166 dml_print("DML_DLG: %s: input dst_y_after_scaler = %d\n", __func__, dst_y_after_scaler); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1167 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1168 // need to figure out which side of odm combine we're in 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1169 if (dst->odm_combine) { 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1170 // figure out which pipes go together 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1171 bool visited[DC__NUM_PIPES__MAX]; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1172 unsigned int i, j, k; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1173 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1174 for (k = 0; k < num_pipes; ++k) { 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1175 visited[k] = false; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1176 pipe_index_in_combine[k] = 0; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1177 } 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1178 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1179 for (i = 0; i < num_pipes; i++) { 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1180 if (e2e_pipe_param[i].pipe.src.is_hsplit && !visited[i]) { 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1181 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1182 unsigned int grp = e2e_pipe_param[i].pipe.src.hsplit_grp; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1183 unsigned int grp_idx = 0; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1184 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1185 for (j = i; j < num_pipes; j++) { 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1186 if (e2e_pipe_param[j].pipe.src.hsplit_grp == grp && e2e_pipe_param[j].pipe.src.is_hsplit && !visited[j]) { 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1187 pipe_index_in_combine[j] = grp_idx; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1188 dml_print("DML_DLG: %s: pipe[%d] is in grp %d idx %d\n", __func__, j, grp, grp_idx); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1189 grp_idx++; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1190 visited[j] = true; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1191 } 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1192 } 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1193 } 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1194 } 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1195 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1196 } 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1197 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1198 if (dst->odm_combine == dm_odm_combine_mode_disabled) { 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1199 disp_dlg_regs->refcyc_h_blank_end = (unsigned int) ((double) hblank_end * ref_freq_to_pix_freq); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1200 } else { 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1201 unsigned int odm_combine_factor = (dst->odm_combine == dm_odm_combine_mode_2to1 ? 2 : 4); // TODO: We should really check that 4to1 is supported before setting it to 4 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1202 unsigned int odm_pipe_index = pipe_index_in_combine[pipe_idx]; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1203 disp_dlg_regs->refcyc_h_blank_end = (unsigned int) (((double) hblank_end + odm_pipe_index * (double) dst->hactive / odm_combine_factor) * ref_freq_to_pix_freq); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1204 } ASSERT(disp_dlg_regs->refcyc_h_blank_end < (unsigned int)dml_pow(2, 13)); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1205 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1206 dml_print("DML_DLG: %s: htotal = %d\n", __func__, htotal); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1207 dml_print("DML_DLG: %s: dst_x_after_scaler[%d] = %d\n", __func__, pipe_idx, dst_x_after_scaler); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1208 dml_print("DML_DLG: %s: dst_y_after_scaler[%d] = %d\n", __func__, pipe_idx, dst_y_after_scaler); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1209 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1210 dst_y_prefetch = get_dst_y_prefetch(mode_lib, e2e_pipe_param, num_pipes, pipe_idx); // From VBA 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1211 dst_y_per_vm_vblank = get_dst_y_per_vm_vblank(mode_lib, e2e_pipe_param, num_pipes, pipe_idx); // From VBA 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1212 dst_y_per_row_vblank = get_dst_y_per_row_vblank(mode_lib, e2e_pipe_param, num_pipes, pipe_idx); // From VBA 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1213 dst_y_per_vm_flip = get_dst_y_per_vm_flip(mode_lib, e2e_pipe_param, num_pipes, pipe_idx); // From VBA 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1214 dst_y_per_row_flip = get_dst_y_per_row_flip(mode_lib, e2e_pipe_param, num_pipes, pipe_idx); // From VBA 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1215 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1216 max_dst_y_per_vm_vblank = 32.0; //U5.2 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1217 max_dst_y_per_row_vblank = 16.0; //U4.2 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1218 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1219 // magic! 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1220 if (htotal <= 75) { 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1221 max_dst_y_per_vm_vblank = 100.0; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1222 max_dst_y_per_row_vblank = 100.0; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1223 } 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1224 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1225 dml_print("DML_DLG: %s: dst_y_prefetch (after rnd) = %3.2f\n", __func__, dst_y_prefetch); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1226 dml_print("DML_DLG: %s: dst_y_per_vm_flip = %3.2f\n", __func__, dst_y_per_vm_flip); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1227 dml_print("DML_DLG: %s: dst_y_per_row_flip = %3.2f\n", __func__, dst_y_per_row_flip); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1228 dml_print("DML_DLG: %s: dst_y_per_vm_vblank = %3.2f\n", __func__, dst_y_per_vm_vblank); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1229 dml_print("DML_DLG: %s: dst_y_per_row_vblank = %3.2f\n", __func__, dst_y_per_row_vblank); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1230 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1231 ASSERT(dst_y_per_vm_vblank < max_dst_y_per_vm_vblank); ASSERT(dst_y_per_row_vblank < max_dst_y_per_row_vblank); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1232 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1233 ASSERT(dst_y_prefetch > (dst_y_per_vm_vblank + dst_y_per_row_vblank)); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1234 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1235 vratio_pre_l = get_vratio_prefetch_l(mode_lib, e2e_pipe_param, num_pipes, pipe_idx); // From VBA 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1236 vratio_pre_c = get_vratio_prefetch_c(mode_lib, e2e_pipe_param, num_pipes, pipe_idx); // From VBA 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1237 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1238 dml_print("DML_DLG: %s: vratio_pre_l = %3.2f\n", __func__, vratio_pre_l); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1239 dml_print("DML_DLG: %s: vratio_pre_c = %3.2f\n", __func__, vratio_pre_c); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1240 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1241 // Active 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1242 req_per_swath_ub_l = rq_dlg_param.rq_l.req_per_swath_ub; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1243 req_per_swath_ub_c = rq_dlg_param.rq_c.req_per_swath_ub; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1244 meta_row_height_l = rq_dlg_param.rq_l.meta_row_height; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1245 meta_row_height_c = rq_dlg_param.rq_c.meta_row_height; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1246 swath_width_pixels_ub_l = 0; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1247 swath_width_pixels_ub_c = 0; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1248 scaler_rec_in_width_l = 0; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1249 scaler_rec_in_width_c = 0; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1250 dpte_row_height_l = rq_dlg_param.rq_l.dpte_row_height; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1251 dpte_row_height_c = rq_dlg_param.rq_c.dpte_row_height; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1252 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1253 if (mode_422) { 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1254 swath_width_pixels_ub_l = swath_width_ub_l * 2; // *2 for 2 pixel per element 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1255 swath_width_pixels_ub_c = swath_width_ub_c * 2; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1256 } else { 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1257 swath_width_pixels_ub_l = swath_width_ub_l * 1; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1258 swath_width_pixels_ub_c = swath_width_ub_c * 1; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1259 } 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1260 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1261 hscale_pixel_rate_l = 0.; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1262 hscale_pixel_rate_c = 0.; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1263 min_hratio_fact_l = 1.0; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1264 min_hratio_fact_c = 1.0; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1265 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1266 if (hratio_l <= 1) 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1267 min_hratio_fact_l = 2.0; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1268 else if (htaps_l <= 6) { 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1269 if ((hratio_l * 2.0) > 4.0) 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1270 min_hratio_fact_l = 4.0; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1271 else 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1272 min_hratio_fact_l = hratio_l * 2.0; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1273 } else { 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1274 if (hratio_l > 4.0) 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1275 min_hratio_fact_l = 4.0; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1276 else 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1277 min_hratio_fact_l = hratio_l; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1278 } 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1279 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1280 hscale_pixel_rate_l = min_hratio_fact_l * dppclk_freq_in_mhz; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1281 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1282 dml_print("DML_DLG: %s: hratio_l = %3.2f\n", __func__, hratio_l); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1283 dml_print("DML_DLG: %s: min_hratio_fact_l = %3.2f\n", __func__, min_hratio_fact_l); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1284 dml_print("DML_DLG: %s: hscale_pixel_rate_l = %3.2f\n", __func__, hscale_pixel_rate_l); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1285 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1286 if (hratio_c <= 1) 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1287 min_hratio_fact_c = 2.0; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1288 else if (htaps_c <= 6) { 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1289 if ((hratio_c * 2.0) > 4.0) 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1290 min_hratio_fact_c = 4.0; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1291 else 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1292 min_hratio_fact_c = hratio_c * 2.0; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1293 } else { 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1294 if (hratio_c > 4.0) 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1295 min_hratio_fact_c = 4.0; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1296 else 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1297 min_hratio_fact_c = hratio_c; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1298 } 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1299 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1300 hscale_pixel_rate_c = min_hratio_fact_c * dppclk_freq_in_mhz; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1301 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1302 refcyc_per_line_delivery_pre_l = 0.; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1303 refcyc_per_line_delivery_pre_c = 0.; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1304 refcyc_per_line_delivery_l = 0.; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1305 refcyc_per_line_delivery_c = 0.; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1306 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1307 refcyc_per_req_delivery_pre_l = 0.; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1308 refcyc_per_req_delivery_pre_c = 0.; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1309 refcyc_per_req_delivery_l = 0.; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1310 refcyc_per_req_delivery_c = 0.; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1311 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1312 full_recout_width = 0; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1313 // In ODM 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1314 if (src->is_hsplit) { 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1315 // This "hack" is only allowed (and valid) for MPC combine. In ODM 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1316 // combine, you MUST specify the full_recout_width...according to Oswin 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1317 if (dst->full_recout_width == 0 && !dst->odm_combine) { 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1318 dml_print("DML_DLG: %s: Warning: full_recout_width not set in hsplit mode\n", __func__); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1319 full_recout_width = dst->recout_width * 2; // assume half split for dcn1 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1320 } else 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1321 full_recout_width = dst->full_recout_width; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1322 } else 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1323 full_recout_width = dst->recout_width; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1324 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1325 // As of DCN2, mpc_combine and odm_combine are mutually exclusive 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1326 refcyc_per_line_delivery_pre_l = get_refcyc_per_delivery( 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1327 mode_lib, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1328 refclk_freq_in_mhz, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1329 pclk_freq_in_mhz, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1330 dst->odm_combine, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1331 full_recout_width, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1332 dst->hactive, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1333 vratio_pre_l, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1334 hscale_pixel_rate_l, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1335 swath_width_pixels_ub_l, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1336 1); // per line 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1337 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1338 refcyc_per_line_delivery_l = get_refcyc_per_delivery( 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1339 mode_lib, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1340 refclk_freq_in_mhz, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1341 pclk_freq_in_mhz, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1342 dst->odm_combine, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1343 full_recout_width, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1344 dst->hactive, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1345 vratio_l, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1346 hscale_pixel_rate_l, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1347 swath_width_pixels_ub_l, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1348 1); // per line 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1349 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1350 dml_print("DML_DLG: %s: full_recout_width = %d\n", __func__, full_recout_width); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1351 dml_print("DML_DLG: %s: hscale_pixel_rate_l = %3.2f\n", __func__, hscale_pixel_rate_l); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1352 dml_print("DML_DLG: %s: refcyc_per_line_delivery_pre_l = %3.2f\n", __func__, refcyc_per_line_delivery_pre_l); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1353 dml_print("DML_DLG: %s: refcyc_per_line_delivery_l = %3.2f\n", __func__, refcyc_per_line_delivery_l); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1354 dml_print("DML_DLG: %s: vba__refcyc_per_line_delivery_pre_l = %3.2f\n", __func__, vba__refcyc_per_line_delivery_pre_l); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1355 dml_print("DML_DLG: %s: vba__refcyc_per_line_delivery_l = %3.2f\n", __func__, vba__refcyc_per_line_delivery_l); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1356 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1357 //old_impl_vs_vba_impl("refcyc_per_line_delivery_pre_l", refcyc_per_line_delivery_pre_l, vba__refcyc_per_line_delivery_pre_l); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1358 //old_impl_vs_vba_impl("refcyc_per_line_delivery_l", refcyc_per_line_delivery_l, vba__refcyc_per_line_delivery_l); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1359 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1360 if (dual_plane) { 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1361 float vba__refcyc_per_line_delivery_pre_c = get_refcyc_per_line_delivery_pre_c_in_us(mode_lib, e2e_pipe_param, num_pipes, pipe_idx) * refclk_freq_in_mhz; // From VBA 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1362 float vba__refcyc_per_line_delivery_c = get_refcyc_per_line_delivery_c_in_us(mode_lib, e2e_pipe_param, num_pipes, pipe_idx) * refclk_freq_in_mhz; // From VBA 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1363 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1364 refcyc_per_line_delivery_pre_c = get_refcyc_per_delivery( 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1365 mode_lib, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1366 refclk_freq_in_mhz, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1367 pclk_freq_in_mhz, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1368 dst->odm_combine, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1369 full_recout_width, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1370 dst->hactive, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1371 vratio_pre_c, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1372 hscale_pixel_rate_c, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1373 swath_width_pixels_ub_c, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1374 1); // per line 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1375 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1376 refcyc_per_line_delivery_c = get_refcyc_per_delivery( 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1377 mode_lib, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1378 refclk_freq_in_mhz, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1379 pclk_freq_in_mhz, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1380 dst->odm_combine, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1381 full_recout_width, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1382 dst->hactive, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1383 vratio_c, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1384 hscale_pixel_rate_c, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1385 swath_width_pixels_ub_c, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1386 1); // per line 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1387 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1388 dml_print("DML_DLG: %s: refcyc_per_line_delivery_pre_c = %3.2f\n", __func__, refcyc_per_line_delivery_pre_c); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1389 dml_print("DML_DLG: %s: refcyc_per_line_delivery_c = %3.2f\n", __func__, refcyc_per_line_delivery_c); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1390 dml_print("DML_DLG: %s: vba__refcyc_per_line_delivery_pre_c = %3.2f\n", __func__, vba__refcyc_per_line_delivery_pre_c); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1391 dml_print("DML_DLG: %s: vba__refcyc_per_line_delivery_c = %3.2f\n", __func__, vba__refcyc_per_line_delivery_c); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1392 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1393 //old_impl_vs_vba_impl("refcyc_per_line_delivery_pre_c", refcyc_per_line_delivery_pre_c, vba__refcyc_per_line_delivery_pre_c); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1394 //old_impl_vs_vba_impl("refcyc_per_line_delivery_c", refcyc_per_line_delivery_c, vba__refcyc_per_line_delivery_c); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1395 } 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1396 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1397 if (src->dynamic_metadata_enable && src->gpuvm) 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1398 disp_dlg_regs->refcyc_per_vm_dmdata = get_refcyc_per_vm_dmdata_in_us(mode_lib, e2e_pipe_param, num_pipes, pipe_idx) * refclk_freq_in_mhz; // From VBA 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1399 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1400 disp_dlg_regs->dmdata_dl_delta = get_dmdata_dl_delta_in_us(mode_lib, e2e_pipe_param, num_pipes, pipe_idx) * refclk_freq_in_mhz; // From VBA 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1401 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1402 // TTU - Luma / Chroma 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1403 if (access_dir) { // vertical access 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1404 scaler_rec_in_width_l = vp_height_l; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1405 scaler_rec_in_width_c = vp_height_c; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1406 } else { 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1407 scaler_rec_in_width_l = vp_width_l; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1408 scaler_rec_in_width_c = vp_width_c; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1409 } 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1410 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1411 refcyc_per_req_delivery_pre_l = get_refcyc_per_delivery( 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1412 mode_lib, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1413 refclk_freq_in_mhz, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1414 pclk_freq_in_mhz, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1415 dst->odm_combine, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1416 full_recout_width, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1417 dst->hactive, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1418 vratio_pre_l, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1419 hscale_pixel_rate_l, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1420 scaler_rec_in_width_l, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1421 req_per_swath_ub_l); // per req 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1422 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1423 refcyc_per_req_delivery_l = get_refcyc_per_delivery( 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1424 mode_lib, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1425 refclk_freq_in_mhz, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1426 pclk_freq_in_mhz, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1427 dst->odm_combine, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1428 full_recout_width, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1429 dst->hactive, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1430 vratio_l, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1431 hscale_pixel_rate_l, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1432 scaler_rec_in_width_l, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1433 req_per_swath_ub_l); // per req 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1434 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1435 dml_print("DML_DLG: %s: refcyc_per_req_delivery_pre_l = %3.2f\n", __func__, refcyc_per_req_delivery_pre_l); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1436 dml_print("DML_DLG: %s: refcyc_per_req_delivery_l = %3.2f\n", __func__, refcyc_per_req_delivery_l); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1437 dml_print("DML_DLG: %s: vba__refcyc_per_req_delivery_pre_l = %3.2f\n", __func__, vba__refcyc_per_req_delivery_pre_l); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1438 dml_print("DML_DLG: %s: vba__refcyc_per_req_delivery_l = %3.2f\n", __func__, vba__refcyc_per_req_delivery_l); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1439 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1440 //old_impl_vs_vba_impl("refcyc_per_req_delivery_pre_l", refcyc_per_req_delivery_pre_l, vba__refcyc_per_req_delivery_pre_l); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1441 //old_impl_vs_vba_impl("refcyc_per_req_delivery_l", refcyc_per_req_delivery_l, vba__refcyc_per_req_delivery_l); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1442 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1443 ASSERT(refcyc_per_req_delivery_pre_l < dml_pow(2, 13)); ASSERT(refcyc_per_req_delivery_l < dml_pow(2, 13)); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1444 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1445 if (dual_plane) { 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1446 float vba__refcyc_per_req_delivery_pre_c = get_refcyc_per_req_delivery_pre_c_in_us(mode_lib, e2e_pipe_param, num_pipes, pipe_idx) * refclk_freq_in_mhz; // From VBA 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1447 float vba__refcyc_per_req_delivery_c = get_refcyc_per_req_delivery_c_in_us(mode_lib, e2e_pipe_param, num_pipes, pipe_idx) * refclk_freq_in_mhz; // From VBA 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1448 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1449 refcyc_per_req_delivery_pre_c = get_refcyc_per_delivery( 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1450 mode_lib, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1451 refclk_freq_in_mhz, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1452 pclk_freq_in_mhz, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1453 dst->odm_combine, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1454 full_recout_width, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1455 dst->hactive, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1456 vratio_pre_c, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1457 hscale_pixel_rate_c, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1458 scaler_rec_in_width_c, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1459 req_per_swath_ub_c); // per req 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1460 refcyc_per_req_delivery_c = get_refcyc_per_delivery( 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1461 mode_lib, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1462 refclk_freq_in_mhz, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1463 pclk_freq_in_mhz, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1464 dst->odm_combine, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1465 full_recout_width, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1466 dst->hactive, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1467 vratio_c, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1468 hscale_pixel_rate_c, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1469 scaler_rec_in_width_c, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1470 req_per_swath_ub_c); // per req 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1471 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1472 dml_print("DML_DLG: %s: refcyc_per_req_delivery_pre_c = %3.2f\n", __func__, refcyc_per_req_delivery_pre_c); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1473 dml_print("DML_DLG: %s: refcyc_per_req_delivery_c = %3.2f\n", __func__, refcyc_per_req_delivery_c); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1474 dml_print("DML_DLG: %s: vba__refcyc_per_req_delivery_pre_c = %3.2f\n", __func__, vba__refcyc_per_req_delivery_pre_c); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1475 dml_print("DML_DLG: %s: vba__refcyc_per_req_delivery_c = %3.2f\n", __func__, vba__refcyc_per_req_delivery_c); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1476 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1477 //old_impl_vs_vba_impl("refcyc_per_req_delivery_pre_c", refcyc_per_req_delivery_pre_c, vba__refcyc_per_req_delivery_pre_c); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1478 //old_impl_vs_vba_impl("refcyc_per_req_delivery_c", refcyc_per_req_delivery_c, vba__refcyc_per_req_delivery_c); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1479 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1480 ASSERT(refcyc_per_req_delivery_pre_c < dml_pow(2, 13)); ASSERT(refcyc_per_req_delivery_c < dml_pow(2, 13)); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1481 } 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1482 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1483 // TTU - Cursor 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1484 refcyc_per_req_delivery_pre_cur0 = 0.0; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1485 refcyc_per_req_delivery_cur0 = 0.0; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1486 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1487 ASSERT(src->num_cursors <= 1); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1488 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1489 if (src->num_cursors > 0) { 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1490 float vba__refcyc_per_req_delivery_pre_cur0; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1491 float vba__refcyc_per_req_delivery_cur0; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1492 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1493 calculate_ttu_cursor( 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1494 mode_lib, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1495 &refcyc_per_req_delivery_pre_cur0, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1496 &refcyc_per_req_delivery_cur0, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1497 refclk_freq_in_mhz, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1498 ref_freq_to_pix_freq, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1499 hscale_pixel_rate_l, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1500 scl->hscl_ratio, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1501 vratio_pre_l, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1502 vratio_l, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1503 src->cur0_src_width, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1504 (enum cursor_bpp) (src->cur0_bpp)); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1505 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1506 vba__refcyc_per_req_delivery_pre_cur0 = get_refcyc_per_cursor_req_delivery_pre_in_us(mode_lib, e2e_pipe_param, num_pipes, pipe_idx) * refclk_freq_in_mhz; // From VBA 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1507 vba__refcyc_per_req_delivery_cur0 = get_refcyc_per_cursor_req_delivery_in_us(mode_lib, e2e_pipe_param, num_pipes, pipe_idx) * refclk_freq_in_mhz; // From VBA 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1508 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1509 dml_print("DML_DLG: %s: refcyc_per_req_delivery_pre_cur0 = %3.2f\n", __func__, refcyc_per_req_delivery_pre_cur0); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1510 dml_print("DML_DLG: %s: refcyc_per_req_delivery_cur0 = %3.2f\n", __func__, refcyc_per_req_delivery_cur0); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1511 dml_print("DML_DLG: %s: vba__refcyc_per_req_delivery_pre_cur0 = %3.2f\n", __func__, vba__refcyc_per_req_delivery_pre_cur0); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1512 dml_print("DML_DLG: %s: vba__refcyc_per_req_delivery_cur0 = %3.2f\n", __func__, vba__refcyc_per_req_delivery_cur0); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1513 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1514 //old_impl_vs_vba_impl("refcyc_per_req_delivery_pre_cur0", refcyc_per_req_delivery_pre_cur0, vba__refcyc_per_req_delivery_pre_cur0); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1515 //old_impl_vs_vba_impl("refcyc_per_req_delivery_cur0", refcyc_per_req_delivery_cur0, vba__refcyc_per_req_delivery_cur0); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1516 } 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1517 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1518 refcyc_per_req_delivery_pre_cur1 = 0.0; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1519 refcyc_per_req_delivery_cur1 = 0.0; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1520 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1521 // TTU - Misc 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1522 // all hard-coded 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1523 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1524 // Assignment to register structures 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1525 disp_dlg_regs->dst_y_after_scaler = dst_y_after_scaler; // in terms of line 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1526 ASSERT(disp_dlg_regs->dst_y_after_scaler < (unsigned int)8); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1527 disp_dlg_regs->refcyc_x_after_scaler = dst_x_after_scaler * ref_freq_to_pix_freq; // in terms of refclk 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1528 ASSERT(disp_dlg_regs->refcyc_x_after_scaler < (unsigned int)dml_pow(2, 13)); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1529 disp_dlg_regs->dst_y_prefetch = (unsigned int) (dst_y_prefetch * dml_pow(2, 2)); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1530 disp_dlg_regs->dst_y_per_vm_vblank = (unsigned int) (dst_y_per_vm_vblank * dml_pow(2, 2)); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1531 disp_dlg_regs->dst_y_per_row_vblank = (unsigned int) (dst_y_per_row_vblank * dml_pow(2, 2)); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1532 disp_dlg_regs->dst_y_per_vm_flip = (unsigned int) (dst_y_per_vm_flip * dml_pow(2, 2)); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1533 disp_dlg_regs->dst_y_per_row_flip = (unsigned int) (dst_y_per_row_flip * dml_pow(2, 2)); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1534 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1535 disp_dlg_regs->vratio_prefetch = (unsigned int) (vratio_pre_l * dml_pow(2, 19)); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1536 disp_dlg_regs->vratio_prefetch_c = (unsigned int) (vratio_pre_c * dml_pow(2, 19)); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1537 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1538 dml_print("DML_DLG: %s: disp_dlg_regs->dst_y_per_vm_vblank = 0x%x\n", __func__, disp_dlg_regs->dst_y_per_vm_vblank); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1539 dml_print("DML_DLG: %s: disp_dlg_regs->dst_y_per_row_vblank = 0x%x\n", __func__, disp_dlg_regs->dst_y_per_row_vblank); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1540 dml_print("DML_DLG: %s: disp_dlg_regs->dst_y_per_vm_flip = 0x%x\n", __func__, disp_dlg_regs->dst_y_per_vm_flip); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1541 dml_print("DML_DLG: %s: disp_dlg_regs->dst_y_per_row_flip = 0x%x\n", __func__, disp_dlg_regs->dst_y_per_row_flip); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1542 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1543 // hack for FPGA 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1544 if (mode_lib->project == DML_PROJECT_DCN31_FPGA) { 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1545 if (disp_dlg_regs->vratio_prefetch >= (unsigned int) dml_pow(2, 22)) { 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1546 disp_dlg_regs->vratio_prefetch = (unsigned int) dml_pow(2, 22) - 1; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1547 dml_print("vratio_prefetch exceed the max value, the register field is [21:0]\n"); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1548 } 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1549 } 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1550 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1551 disp_dlg_regs->refcyc_per_pte_group_vblank_l = (unsigned int) (dst_y_per_row_vblank * (double) htotal * ref_freq_to_pix_freq / (double) dpte_groups_per_row_ub_l); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1552 ASSERT(disp_dlg_regs->refcyc_per_pte_group_vblank_l < (unsigned int)dml_pow(2, 13)); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1553 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1554 if (dual_plane) { 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1555 disp_dlg_regs->refcyc_per_pte_group_vblank_c = (unsigned int) (dst_y_per_row_vblank * (double) htotal * ref_freq_to_pix_freq / (double) dpte_groups_per_row_ub_c); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1556 ASSERT(disp_dlg_regs->refcyc_per_pte_group_vblank_c < (unsigned int)dml_pow(2, 13)); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1557 } 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1558 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1559 disp_dlg_regs->refcyc_per_meta_chunk_vblank_l = (unsigned int) (dst_y_per_row_vblank * (double) htotal * ref_freq_to_pix_freq / (double) meta_chunks_per_row_ub_l); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1560 ASSERT(disp_dlg_regs->refcyc_per_meta_chunk_vblank_l < (unsigned int)dml_pow(2, 13)); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1561 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1562 disp_dlg_regs->refcyc_per_meta_chunk_vblank_c = disp_dlg_regs->refcyc_per_meta_chunk_vblank_l; // dcc for 4:2:0 is not supported in dcn1.0. assigned to be the same as _l for now 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1563 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1564 disp_dlg_regs->refcyc_per_pte_group_flip_l = (unsigned int) (dst_y_per_row_flip * htotal * ref_freq_to_pix_freq) / dpte_groups_per_row_ub_l; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1565 disp_dlg_regs->refcyc_per_meta_chunk_flip_l = (unsigned int) (dst_y_per_row_flip * htotal * ref_freq_to_pix_freq) / meta_chunks_per_row_ub_l; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1566 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1567 if (dual_plane) { 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1568 disp_dlg_regs->refcyc_per_pte_group_flip_c = (unsigned int) (dst_y_per_row_flip * htotal * ref_freq_to_pix_freq) / dpte_groups_per_row_ub_c; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1569 disp_dlg_regs->refcyc_per_meta_chunk_flip_c = (unsigned int) (dst_y_per_row_flip * htotal * ref_freq_to_pix_freq) / meta_chunks_per_row_ub_c; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1570 } 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1571 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1572 disp_dlg_regs->refcyc_per_vm_group_vblank = get_refcyc_per_vm_group_vblank_in_us(mode_lib, e2e_pipe_param, num_pipes, pipe_idx) * refclk_freq_in_mhz; // From VBA 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1573 disp_dlg_regs->refcyc_per_vm_group_flip = get_refcyc_per_vm_group_flip_in_us(mode_lib, e2e_pipe_param, num_pipes, pipe_idx) * refclk_freq_in_mhz; // From VBA 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1574 disp_dlg_regs->refcyc_per_vm_req_vblank = get_refcyc_per_vm_req_vblank_in_us(mode_lib, e2e_pipe_param, num_pipes, pipe_idx) * refclk_freq_in_mhz * dml_pow(2, 10); // From VBA 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1575 disp_dlg_regs->refcyc_per_vm_req_flip = get_refcyc_per_vm_req_flip_in_us(mode_lib, e2e_pipe_param, num_pipes, pipe_idx) * refclk_freq_in_mhz * dml_pow(2, 10); // From VBA 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1576 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1577 // Clamp to max for now 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1578 if (disp_dlg_regs->refcyc_per_vm_group_vblank >= (unsigned int) dml_pow(2, 23)) 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1579 disp_dlg_regs->refcyc_per_vm_group_vblank = dml_pow(2, 23) - 1; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1580 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1581 if (disp_dlg_regs->refcyc_per_vm_group_flip >= (unsigned int) dml_pow(2, 23)) 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1582 disp_dlg_regs->refcyc_per_vm_group_flip = dml_pow(2, 23) - 1; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1583 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1584 if (disp_dlg_regs->refcyc_per_vm_req_vblank >= (unsigned int) dml_pow(2, 23)) 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1585 disp_dlg_regs->refcyc_per_vm_req_vblank = dml_pow(2, 23) - 1; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1586 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1587 if (disp_dlg_regs->refcyc_per_vm_req_flip >= (unsigned int) dml_pow(2, 23)) 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1588 disp_dlg_regs->refcyc_per_vm_req_flip = dml_pow(2, 23) - 1; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1589 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1590 disp_dlg_regs->dst_y_per_pte_row_nom_l = (unsigned int) ((double) dpte_row_height_l / (double) vratio_l * dml_pow(2, 2)); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1591 ASSERT(disp_dlg_regs->dst_y_per_pte_row_nom_l < (unsigned int)dml_pow(2, 17)); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1592 if (dual_plane) { 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1593 disp_dlg_regs->dst_y_per_pte_row_nom_c = (unsigned int) ((double) dpte_row_height_c / (double) vratio_c * dml_pow(2, 2)); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1594 if (disp_dlg_regs->dst_y_per_pte_row_nom_c >= (unsigned int) dml_pow(2, 17)) { 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1595 dml_print( 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1596 "DML_DLG: %s: Warning dst_y_per_pte_row_nom_c %u larger than supported by register format U15.2 %u\n", 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1597 __func__, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1598 disp_dlg_regs->dst_y_per_pte_row_nom_c, 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1599 (unsigned int) dml_pow(2, 17) - 1); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1600 } 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1601 } 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1602 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1603 disp_dlg_regs->dst_y_per_meta_row_nom_l = (unsigned int) ((double) meta_row_height_l / (double) vratio_l * dml_pow(2, 2)); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1604 ASSERT(disp_dlg_regs->dst_y_per_meta_row_nom_l < (unsigned int)dml_pow(2, 17)); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1605 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1606 disp_dlg_regs->dst_y_per_meta_row_nom_c = (unsigned int) ((double) meta_row_height_c / (double) vratio_c * dml_pow(2, 2)); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1607 ASSERT(disp_dlg_regs->dst_y_per_meta_row_nom_c < (unsigned int)dml_pow(2, 17)); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1608 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1609 disp_dlg_regs->refcyc_per_pte_group_nom_l = (unsigned int) ((double) dpte_row_height_l / (double) vratio_l * (double) htotal * ref_freq_to_pix_freq 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1610 / (double) dpte_groups_per_row_ub_l); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1611 if (disp_dlg_regs->refcyc_per_pte_group_nom_l >= (unsigned int) dml_pow(2, 23)) 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1612 disp_dlg_regs->refcyc_per_pte_group_nom_l = dml_pow(2, 23) - 1; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1613 disp_dlg_regs->refcyc_per_meta_chunk_nom_l = (unsigned int) ((double) meta_row_height_l / (double) vratio_l * (double) htotal * ref_freq_to_pix_freq 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1614 / (double) meta_chunks_per_row_ub_l); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1615 if (disp_dlg_regs->refcyc_per_meta_chunk_nom_l >= (unsigned int) dml_pow(2, 23)) 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1616 disp_dlg_regs->refcyc_per_meta_chunk_nom_l = dml_pow(2, 23) - 1; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1617 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1618 if (dual_plane) { 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1619 disp_dlg_regs->refcyc_per_pte_group_nom_c = (unsigned int) ((double) dpte_row_height_c / (double) vratio_c * (double) htotal * ref_freq_to_pix_freq 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1620 / (double) dpte_groups_per_row_ub_c); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1621 if (disp_dlg_regs->refcyc_per_pte_group_nom_c >= (unsigned int) dml_pow(2, 23)) 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1622 disp_dlg_regs->refcyc_per_pte_group_nom_c = dml_pow(2, 23) - 1; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1623 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1624 // TODO: Is this the right calculation? Does htotal need to be halved? 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1625 disp_dlg_regs->refcyc_per_meta_chunk_nom_c = (unsigned int) ((double) meta_row_height_c / (double) vratio_c * (double) htotal * ref_freq_to_pix_freq 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1626 / (double) meta_chunks_per_row_ub_c); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1627 if (disp_dlg_regs->refcyc_per_meta_chunk_nom_c >= (unsigned int) dml_pow(2, 23)) 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1628 disp_dlg_regs->refcyc_per_meta_chunk_nom_c = dml_pow(2, 23) - 1; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1629 } 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1630 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1631 disp_dlg_regs->refcyc_per_line_delivery_pre_l = (unsigned int) dml_floor(refcyc_per_line_delivery_pre_l, 1); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1632 disp_dlg_regs->refcyc_per_line_delivery_l = (unsigned int) dml_floor(refcyc_per_line_delivery_l, 1); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1633 ASSERT(disp_dlg_regs->refcyc_per_line_delivery_pre_l < (unsigned int)dml_pow(2, 13)); ASSERT(disp_dlg_regs->refcyc_per_line_delivery_l < (unsigned int)dml_pow(2, 13)); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1634 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1635 disp_dlg_regs->refcyc_per_line_delivery_pre_c = (unsigned int) dml_floor(refcyc_per_line_delivery_pre_c, 1); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1636 disp_dlg_regs->refcyc_per_line_delivery_c = (unsigned int) dml_floor(refcyc_per_line_delivery_c, 1); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1637 ASSERT(disp_dlg_regs->refcyc_per_line_delivery_pre_c < (unsigned int)dml_pow(2, 13)); ASSERT(disp_dlg_regs->refcyc_per_line_delivery_c < (unsigned int)dml_pow(2, 13)); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1638 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1639 disp_dlg_regs->chunk_hdl_adjust_cur0 = 3; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1640 disp_dlg_regs->dst_y_offset_cur0 = 0; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1641 disp_dlg_regs->chunk_hdl_adjust_cur1 = 3; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1642 disp_dlg_regs->dst_y_offset_cur1 = 0; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1643 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1644 disp_dlg_regs->dst_y_delta_drq_limit = 0x7fff; // off 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1645 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1646 disp_ttu_regs->refcyc_per_req_delivery_pre_l = (unsigned int) (refcyc_per_req_delivery_pre_l * dml_pow(2, 10)); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1647 disp_ttu_regs->refcyc_per_req_delivery_l = (unsigned int) (refcyc_per_req_delivery_l * dml_pow(2, 10)); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1648 disp_ttu_regs->refcyc_per_req_delivery_pre_c = (unsigned int) (refcyc_per_req_delivery_pre_c * dml_pow(2, 10)); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1649 disp_ttu_regs->refcyc_per_req_delivery_c = (unsigned int) (refcyc_per_req_delivery_c * dml_pow(2, 10)); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1650 disp_ttu_regs->refcyc_per_req_delivery_pre_cur0 = (unsigned int) (refcyc_per_req_delivery_pre_cur0 * dml_pow(2, 10)); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1651 disp_ttu_regs->refcyc_per_req_delivery_cur0 = (unsigned int) (refcyc_per_req_delivery_cur0 * dml_pow(2, 10)); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1652 disp_ttu_regs->refcyc_per_req_delivery_pre_cur1 = (unsigned int) (refcyc_per_req_delivery_pre_cur1 * dml_pow(2, 10)); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1653 disp_ttu_regs->refcyc_per_req_delivery_cur1 = (unsigned int) (refcyc_per_req_delivery_cur1 * dml_pow(2, 10)); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1654 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1655 disp_ttu_regs->qos_level_low_wm = 0; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1656 ASSERT(disp_ttu_regs->qos_level_low_wm < dml_pow(2, 14)); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1657 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1658 disp_ttu_regs->qos_level_high_wm = (unsigned int) (4.0 * (double) htotal * ref_freq_to_pix_freq); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1659 ASSERT(disp_ttu_regs->qos_level_high_wm < dml_pow(2, 14)); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1660 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1661 disp_ttu_regs->qos_level_flip = 14; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1662 disp_ttu_regs->qos_level_fixed_l = 8; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1663 disp_ttu_regs->qos_level_fixed_c = 8; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1664 disp_ttu_regs->qos_level_fixed_cur0 = 8; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1665 disp_ttu_regs->qos_ramp_disable_l = 0; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1666 disp_ttu_regs->qos_ramp_disable_c = 0; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1667 disp_ttu_regs->qos_ramp_disable_cur0 = 0; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1668 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1669 disp_ttu_regs->min_ttu_vblank = min_ttu_vblank * refclk_freq_in_mhz; 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1670 ASSERT(disp_ttu_regs->min_ttu_vblank < dml_pow(2, 24)); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1671 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1672 print__ttu_regs_st(mode_lib, *disp_ttu_regs); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1673 print__dlg_regs_st(mode_lib, *disp_dlg_regs); 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1674 } 74458c081fcfb0 Nicholas Kazlauskas 2021-05-19 1675 :::::: The code at line 939 was first introduced by commit :::::: 74458c081fcfb0423877e630de2746daefdb16e4 drm/amd/display: Add DCN3.1 DML calculation support :::::: TO: Nicholas Kazlauskas <nicholas.kazlauskas(a)amd.com> :::::: CC: Alex Deucher <alexander.deucher(a)amd.com> --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

1 year, 2 months

1
0
0 / 0

Re: [PATCH 3/6] v4l: async: Rename async nf functions, clean up long lines

by kernel test robot

Hi Sakari, I love your patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [cannot apply to rockchip/for-next tegra/for-next v5.13-rc7 next-20210622] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Sakari-Ailus/V4L2-driver-documen... base: git://linuxtv.org/media_tree.git master config: arm64-randconfig-r003-20210622 (attached as .config) compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project b3634d3e88b7f26534a5057bff182b7dced584fc) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install arm64 cross compiling tool for clang build # apt-get install binutils-aarch64-linux-gnu # https://github.com/0day-ci/linux/commit/922378435e59e00aef32ba7590991f0e9... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Sakari-Ailus/V4L2-driver-documentation-v4l2-async-improvements/20210622-192925 git checkout 922378435e59e00aef32ba7590991f0e9b24acac # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com> All errors (new ones prefixed by >>): >> drivers/media/platform/atmel/atmel-sama7g5-isc.c:511:9: error: implicit declaration of function 'v4l2_async_nf_add_fwnode_remote_subdev' [-Werror,-Wimplicit-function-declaration] asd = v4l2_async_nf_add_fwnode_remote_subdev( ^ drivers/media/platform/atmel/atmel-sama7g5-isc.c:511:9: note: did you mean '__v4l2_async_nf_add_fwnode_remote'? include/media/v4l2-async.h:182:1: note: '__v4l2_async_nf_add_fwnode_remote' declared here __v4l2_async_nf_add_fwnode_remote(struct v4l2_async_notifier *notif, ^ >> drivers/media/platform/atmel/atmel-sama7g5-isc.c:514:6: error: expected expression struct v4l2_async_subdev); ^ 2 errors generated. vim +/v4l2_async_nf_add_fwnode_remote_subdev +511 drivers/media/platform/atmel/atmel-sama7g5-isc.c 373 374 static int microchip_xisc_probe(struct platform_device *pdev) 375 { 376 struct device *dev = &pdev->dev; 377 struct isc_device *isc; 378 struct resource *res; 379 void __iomem *io_base; 380 struct isc_subdev_entity *subdev_entity; 381 int irq; 382 int ret; 383 u32 ver; 384 385 isc = devm_kzalloc(dev, sizeof(*isc), GFP_KERNEL); 386 if (!isc) 387 return -ENOMEM; 388 389 platform_set_drvdata(pdev, isc); 390 isc->dev = dev; 391 392 res = platform_get_resource(pdev, IORESOURCE_MEM, 0); 393 io_base = devm_ioremap_resource(dev, res); 394 if (IS_ERR(io_base)) 395 return PTR_ERR(io_base); 396 397 isc->regmap = devm_regmap_init_mmio(dev, io_base, &isc_regmap_config); 398 if (IS_ERR(isc->regmap)) { 399 ret = PTR_ERR(isc->regmap); 400 dev_err(dev, "failed to init register map: %d\n", ret); 401 return ret; 402 } 403 404 irq = platform_get_irq(pdev, 0); 405 if (irq < 0) 406 return irq; 407 408 ret = devm_request_irq(dev, irq, isc_interrupt, 0, 409 "microchip-sama7g5-xisc", isc); 410 if (ret < 0) { 411 dev_err(dev, "can't register ISR for IRQ %u (ret=%i)\n", 412 irq, ret); 413 return ret; 414 } 415 416 isc->gamma_table = isc_sama7g5_gamma_table; 417 isc->gamma_max = 0; 418 419 isc->max_width = ISC_SAMA7G5_MAX_SUPPORT_WIDTH; 420 isc->max_height = ISC_SAMA7G5_MAX_SUPPORT_HEIGHT; 421 422 isc->config_dpc = isc_sama7g5_config_dpc; 423 isc->config_csc = isc_sama7g5_config_csc; 424 isc->config_cbc = isc_sama7g5_config_cbc; 425 isc->config_cc = isc_sama7g5_config_cc; 426 isc->config_gam = isc_sama7g5_config_gam; 427 isc->config_rlp = isc_sama7g5_config_rlp; 428 isc->config_ctrls = isc_sama7g5_config_ctrls; 429 430 isc->adapt_pipeline = isc_sama7g5_adapt_pipeline; 431 432 isc->offsets.csc = ISC_SAMA7G5_CSC_OFFSET; 433 isc->offsets.cbc = ISC_SAMA7G5_CBC_OFFSET; 434 isc->offsets.sub422 = ISC_SAMA7G5_SUB422_OFFSET; 435 isc->offsets.sub420 = ISC_SAMA7G5_SUB420_OFFSET; 436 isc->offsets.rlp = ISC_SAMA7G5_RLP_OFFSET; 437 isc->offsets.his = ISC_SAMA7G5_HIS_OFFSET; 438 isc->offsets.dma = ISC_SAMA7G5_DMA_OFFSET; 439 isc->offsets.version = ISC_SAMA7G5_VERSION_OFFSET; 440 isc->offsets.his_entry = ISC_SAMA7G5_HIS_ENTRY_OFFSET; 441 442 isc->controller_formats = sama7g5_controller_formats; 443 isc->controller_formats_size = ARRAY_SIZE(sama7g5_controller_formats); 444 isc->formats_list = sama7g5_formats_list; 445 isc->formats_list_size = ARRAY_SIZE(sama7g5_formats_list); 446 447 /* sama7g5-isc RAM access port is full AXI4 - 32 bits per beat */ 448 isc->dcfg = ISC_DCFG_YMBSIZE_BEATS32 | ISC_DCFG_CMBSIZE_BEATS32; 449 450 ret = isc_pipeline_init(isc); 451 if (ret) 452 return ret; 453 454 isc->hclock = devm_clk_get(dev, "hclock"); 455 if (IS_ERR(isc->hclock)) { 456 ret = PTR_ERR(isc->hclock); 457 dev_err(dev, "failed to get hclock: %d\n", ret); 458 return ret; 459 } 460 461 ret = clk_prepare_enable(isc->hclock); 462 if (ret) { 463 dev_err(dev, "failed to enable hclock: %d\n", ret); 464 return ret; 465 } 466 467 ret = isc_clk_init(isc); 468 if (ret) { 469 dev_err(dev, "failed to init isc clock: %d\n", ret); 470 goto unprepare_hclk; 471 } 472 473 isc->ispck = isc->isc_clks[ISC_ISPCK].clk; 474 475 ret = clk_prepare_enable(isc->ispck); 476 if (ret) { 477 dev_err(dev, "failed to enable ispck: %d\n", ret); 478 goto unprepare_hclk; 479 } 480 481 /* ispck should be greater or equal to hclock */ 482 ret = clk_set_rate(isc->ispck, clk_get_rate(isc->hclock)); 483 if (ret) { 484 dev_err(dev, "failed to set ispck rate: %d\n", ret); 485 goto unprepare_clk; 486 } 487 488 ret = v4l2_device_register(dev, &isc->v4l2_dev); 489 if (ret) { 490 dev_err(dev, "unable to register v4l2 device.\n"); 491 goto unprepare_clk; 492 } 493 494 ret = xisc_parse_dt(dev, isc); 495 if (ret) { 496 dev_err(dev, "fail to parse device tree\n"); 497 goto unregister_v4l2_device; 498 } 499 500 if (list_empty(&isc->subdev_entities)) { 501 dev_err(dev, "no subdev found\n"); 502 ret = -ENODEV; 503 goto unregister_v4l2_device; 504 } 505 506 list_for_each_entry(subdev_entity, &isc->subdev_entities, list) { 507 struct v4l2_async_subdev *asd; 508 509 v4l2_async_nf_init(&subdev_entity->notifier); 510 > 511 asd = v4l2_async_nf_add_fwnode_remote_subdev( 512 &subdev_entity->notifier, 513 of_fwnode_handle(subdev_entity->epn), > 514 struct v4l2_async_subdev); 515 516 of_node_put(subdev_entity->epn); 517 subdev_entity->epn = NULL; 518 519 if (IS_ERR(asd)) { 520 ret = PTR_ERR(asd); 521 goto cleanup_subdev; 522 } 523 524 subdev_entity->notifier.ops = &isc_async_ops; 525 526 ret = v4l2_async_nf_register(&isc->v4l2_dev, 527 &subdev_entity->notifier); 528 if (ret) { 529 dev_err(dev, "fail to register async notifier\n"); 530 goto cleanup_subdev; 531 } 532 533 if (video_is_registered(&isc->video_dev)) 534 break; 535 } 536 537 pm_runtime_set_active(dev); 538 pm_runtime_enable(dev); 539 pm_request_idle(dev); 540 541 regmap_read(isc->regmap, ISC_VERSION + isc->offsets.version, &ver); 542 dev_info(dev, "Microchip XISC version %x\n", ver); 543 544 return 0; 545 546 cleanup_subdev: 547 isc_subdev_cleanup(isc); 548 549 unregister_v4l2_device: 550 v4l2_device_unregister(&isc->v4l2_dev); 551 552 unprepare_clk: 553 clk_disable_unprepare(isc->ispck); 554 unprepare_hclk: 555 clk_disable_unprepare(isc->hclock); 556 557 isc_clk_cleanup(isc); 558 559 return ret; 560 } 561 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

1 year, 2 months

1
0
0 / 0

Re: [PATCH 3/6] v4l: async: Rename async nf functions, clean up long lines

by kernel test robot

Hi Sakari, I love your patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [cannot apply to rockchip/for-next tegra/for-next v5.13-rc7 next-20210622] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Sakari-Ailus/V4L2-driver-documen... base: git://linuxtv.org/media_tree.git master config: sparc-allyesconfig (attached as .config) compiler: sparc64-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/922378435e59e00aef32ba7590991f0e9... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Sakari-Ailus/V4L2-driver-documentation-v4l2-async-improvements/20210622-192925 git checkout 922378435e59e00aef32ba7590991f0e9b24acac # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sparc If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com> All errors (new ones prefixed by >>): drivers/media/platform/atmel/atmel-sama7g5-isc.c: In function 'microchip_xisc_probe': >> drivers/media/platform/atmel/atmel-sama7g5-isc.c:511:9: error: implicit declaration of function 'v4l2_async_nf_add_fwnode_remote_subdev'; did you mean 'v4l2_async_nf_add_fwnode_remote'? [-Werror=implicit-function-declaration] 511 | asd = v4l2_async_nf_add_fwnode_remote_subdev( | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | v4l2_async_nf_add_fwnode_remote >> drivers/media/platform/atmel/atmel-sama7g5-isc.c:514:6: error: expected expression before 'struct' 514 | struct v4l2_async_subdev); | ^~~~~~ cc1: some warnings being treated as errors vim +511 drivers/media/platform/atmel/atmel-sama7g5-isc.c 373 374 static int microchip_xisc_probe(struct platform_device *pdev) 375 { 376 struct device *dev = &pdev->dev; 377 struct isc_device *isc; 378 struct resource *res; 379 void __iomem *io_base; 380 struct isc_subdev_entity *subdev_entity; 381 int irq; 382 int ret; 383 u32 ver; 384 385 isc = devm_kzalloc(dev, sizeof(*isc), GFP_KERNEL); 386 if (!isc) 387 return -ENOMEM; 388 389 platform_set_drvdata(pdev, isc); 390 isc->dev = dev; 391 392 res = platform_get_resource(pdev, IORESOURCE_MEM, 0); 393 io_base = devm_ioremap_resource(dev, res); 394 if (IS_ERR(io_base)) 395 return PTR_ERR(io_base); 396 397 isc->regmap = devm_regmap_init_mmio(dev, io_base, &isc_regmap_config); 398 if (IS_ERR(isc->regmap)) { 399 ret = PTR_ERR(isc->regmap); 400 dev_err(dev, "failed to init register map: %d\n", ret); 401 return ret; 402 } 403 404 irq = platform_get_irq(pdev, 0); 405 if (irq < 0) 406 return irq; 407 408 ret = devm_request_irq(dev, irq, isc_interrupt, 0, 409 "microchip-sama7g5-xisc", isc); 410 if (ret < 0) { 411 dev_err(dev, "can't register ISR for IRQ %u (ret=%i)\n", 412 irq, ret); 413 return ret; 414 } 415 416 isc->gamma_table = isc_sama7g5_gamma_table; 417 isc->gamma_max = 0; 418 419 isc->max_width = ISC_SAMA7G5_MAX_SUPPORT_WIDTH; 420 isc->max_height = ISC_SAMA7G5_MAX_SUPPORT_HEIGHT; 421 422 isc->config_dpc = isc_sama7g5_config_dpc; 423 isc->config_csc = isc_sama7g5_config_csc; 424 isc->config_cbc = isc_sama7g5_config_cbc; 425 isc->config_cc = isc_sama7g5_config_cc; 426 isc->config_gam = isc_sama7g5_config_gam; 427 isc->config_rlp = isc_sama7g5_config_rlp; 428 isc->config_ctrls = isc_sama7g5_config_ctrls; 429 430 isc->adapt_pipeline = isc_sama7g5_adapt_pipeline; 431 432 isc->offsets.csc = ISC_SAMA7G5_CSC_OFFSET; 433 isc->offsets.cbc = ISC_SAMA7G5_CBC_OFFSET; 434 isc->offsets.sub422 = ISC_SAMA7G5_SUB422_OFFSET; 435 isc->offsets.sub420 = ISC_SAMA7G5_SUB420_OFFSET; 436 isc->offsets.rlp = ISC_SAMA7G5_RLP_OFFSET; 437 isc->offsets.his = ISC_SAMA7G5_HIS_OFFSET; 438 isc->offsets.dma = ISC_SAMA7G5_DMA_OFFSET; 439 isc->offsets.version = ISC_SAMA7G5_VERSION_OFFSET; 440 isc->offsets.his_entry = ISC_SAMA7G5_HIS_ENTRY_OFFSET; 441 442 isc->controller_formats = sama7g5_controller_formats; 443 isc->controller_formats_size = ARRAY_SIZE(sama7g5_controller_formats); 444 isc->formats_list = sama7g5_formats_list; 445 isc->formats_list_size = ARRAY_SIZE(sama7g5_formats_list); 446 447 /* sama7g5-isc RAM access port is full AXI4 - 32 bits per beat */ 448 isc->dcfg = ISC_DCFG_YMBSIZE_BEATS32 | ISC_DCFG_CMBSIZE_BEATS32; 449 450 ret = isc_pipeline_init(isc); 451 if (ret) 452 return ret; 453 454 isc->hclock = devm_clk_get(dev, "hclock"); 455 if (IS_ERR(isc->hclock)) { 456 ret = PTR_ERR(isc->hclock); 457 dev_err(dev, "failed to get hclock: %d\n", ret); 458 return ret; 459 } 460 461 ret = clk_prepare_enable(isc->hclock); 462 if (ret) { 463 dev_err(dev, "failed to enable hclock: %d\n", ret); 464 return ret; 465 } 466 467 ret = isc_clk_init(isc); 468 if (ret) { 469 dev_err(dev, "failed to init isc clock: %d\n", ret); 470 goto unprepare_hclk; 471 } 472 473 isc->ispck = isc->isc_clks[ISC_ISPCK].clk; 474 475 ret = clk_prepare_enable(isc->ispck); 476 if (ret) { 477 dev_err(dev, "failed to enable ispck: %d\n", ret); 478 goto unprepare_hclk; 479 } 480 481 /* ispck should be greater or equal to hclock */ 482 ret = clk_set_rate(isc->ispck, clk_get_rate(isc->hclock)); 483 if (ret) { 484 dev_err(dev, "failed to set ispck rate: %d\n", ret); 485 goto unprepare_clk; 486 } 487 488 ret = v4l2_device_register(dev, &isc->v4l2_dev); 489 if (ret) { 490 dev_err(dev, "unable to register v4l2 device.\n"); 491 goto unprepare_clk; 492 } 493 494 ret = xisc_parse_dt(dev, isc); 495 if (ret) { 496 dev_err(dev, "fail to parse device tree\n"); 497 goto unregister_v4l2_device; 498 } 499 500 if (list_empty(&isc->subdev_entities)) { 501 dev_err(dev, "no subdev found\n"); 502 ret = -ENODEV; 503 goto unregister_v4l2_device; 504 } 505 506 list_for_each_entry(subdev_entity, &isc->subdev_entities, list) { 507 struct v4l2_async_subdev *asd; 508 509 v4l2_async_nf_init(&subdev_entity->notifier); 510 > 511 asd = v4l2_async_nf_add_fwnode_remote_subdev( 512 &subdev_entity->notifier, 513 of_fwnode_handle(subdev_entity->epn), > 514 struct v4l2_async_subdev); 515 516 of_node_put(subdev_entity->epn); 517 subdev_entity->epn = NULL; 518 519 if (IS_ERR(asd)) { 520 ret = PTR_ERR(asd); 521 goto cleanup_subdev; 522 } 523 524 subdev_entity->notifier.ops = &isc_async_ops; 525 526 ret = v4l2_async_nf_register(&isc->v4l2_dev, 527 &subdev_entity->notifier); 528 if (ret) { 529 dev_err(dev, "fail to register async notifier\n"); 530 goto cleanup_subdev; 531 } 532 533 if (video_is_registered(&isc->video_dev)) 534 break; 535 } 536 537 pm_runtime_set_active(dev); 538 pm_runtime_enable(dev); 539 pm_request_idle(dev); 540 541 regmap_read(isc->regmap, ISC_VERSION + isc->offsets.version, &ver); 542 dev_info(dev, "Microchip XISC version %x\n", ver); 543 544 return 0; 545 546 cleanup_subdev: 547 isc_subdev_cleanup(isc); 548 549 unregister_v4l2_device: 550 v4l2_device_unregister(&isc->v4l2_dev); 551 552 unprepare_clk: 553 clk_disable_unprepare(isc->ispck); 554 unprepare_hclk: 555 clk_disable_unprepare(isc->hclock); 556 557 isc_clk_cleanup(isc); 558 559 return ret; 560 } 561 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

1 year, 2 months

1
0
0 / 0

Re: [PATCH] This patch replaces all the instances of dev_info with drm_info

by kernel test robot

Hi Aman, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.13-rc7 next-20210622] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Aman-Jain/This-patch-replaces-al... base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git a96bfed64c8986d6404e553f18203cae1f5ac7e6 config: powerpc64-randconfig-r001-20210622 (attached as .config) compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project b3634d3e88b7f26534a5057bff182b7dced584fc) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install powerpc64 cross compiling tool for clang build # apt-get install binutils-powerpc64-linux-gnu # https://github.com/0day-ci/linux/commit/ca9c5b613cf15d038d10e80c402b78e59... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Aman-Jain/This-patch-replaces-all-the-instances-of-dev_info-with-drm_info/20210622-151557 git checkout ca9c5b613cf15d038d10e80c402b78e5925fc31e # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com> All errors (new ones prefixed by >>): In file included from drivers/gpu/drm/radeon/radeon_drv.c:33: In file included from include/linux/compat.h:14: In file included from include/linux/sem.h:5: In file included from include/uapi/linux/sem.h:5: In file included from include/linux/ipc.h:5: In file included from include/linux/spinlock.h:51: In file included from include/linux/preempt.h:11: In file included from include/linux/list.h:9: In file included from include/linux/kernel.h:12: In file included from include/linux/bitops.h:32: In file included from arch/powerpc/include/asm/bitops.h:62: arch/powerpc/include/asm/barrier.h:49:9: warning: '__lwsync' macro redefined [-Wmacro-redefined] #define __lwsync() __asm__ __volatile__ (stringify_in_c(LWSYNC) : : :"memory") ^ <built-in>:309:9: note: previous definition is here #define __lwsync __builtin_ppc_lwsync ^ >> drivers/gpu/drm/radeon/radeon_drv.c:312:4: error: no member named 'dev' in 'struct device' drm_info(&pdev->dev, ^~~~~~~~~~~~~~~~~~~~ include/drm/drm_print.h:416:2: note: expanded from macro 'drm_info' __drm_printk((drm), info,, fmt, ##__VA_ARGS__) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/drm/drm_print.h:412:27: note: expanded from macro '__drm_printk' dev_##level##type((drm)->dev, "[drm] " fmt, ##__VA_ARGS__) ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/dev_printk.h:118:12: note: expanded from macro 'dev_info' _dev_info(dev, dev_fmt(fmt), ##__VA_ARGS__) ^~~ drivers/gpu/drm/radeon/radeon_drv.c:324:4: error: no member named 'dev' in 'struct device' drm_info(&pdev->dev, ^~~~~~~~~~~~~~~~~~~~ include/drm/drm_print.h:416:2: note: expanded from macro 'drm_info' __drm_printk((drm), info,, fmt, ##__VA_ARGS__) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/drm/drm_print.h:412:27: note: expanded from macro '__drm_printk' dev_##level##type((drm)->dev, "[drm] " fmt, ##__VA_ARGS__) ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/dev_printk.h:118:12: note: expanded from macro 'dev_info' _dev_info(dev, dev_fmt(fmt), ##__VA_ARGS__) ^~~ 1 warning and 2 errors generated. vim +312 drivers/gpu/drm/radeon/radeon_drv.c 292 293 static int radeon_pci_probe(struct pci_dev *pdev, 294 const struct pci_device_id *ent) 295 { 296 unsigned long flags = 0; 297 struct drm_device *dev; 298 int ret; 299 300 if (!ent) 301 return -ENODEV; /* Avoid NULL-ptr deref in drm_get_pci_dev */ 302 303 flags = ent->driver_data; 304 305 if (!radeon_si_support) { 306 switch (flags & RADEON_FAMILY_MASK) { 307 case CHIP_TAHITI: 308 case CHIP_PITCAIRN: 309 case CHIP_VERDE: 310 case CHIP_OLAND: 311 case CHIP_HAINAN: > 312 drm_info(&pdev->dev, 313 "SI support disabled by module param\n"); 314 return -ENODEV; 315 } 316 } 317 if (!radeon_cik_support) { 318 switch (flags & RADEON_FAMILY_MASK) { 319 case CHIP_KAVERI: 320 case CHIP_BONAIRE: 321 case CHIP_HAWAII: 322 case CHIP_KABINI: 323 case CHIP_MULLINS: 324 drm_info(&pdev->dev, 325 "CIK support disabled by module param\n"); 326 return -ENODEV; 327 } 328 } 329 330 if (vga_switcheroo_client_probe_defer(pdev)) 331 return -EPROBE_DEFER; 332 333 /* Get rid of things like offb */ 334 ret = drm_fb_helper_remove_conflicting_pci_framebuffers(pdev, "radeondrmfb"); 335 if (ret) 336 return ret; 337 338 dev = drm_dev_alloc(&kms_driver, &pdev->dev); 339 if (IS_ERR(dev)) 340 return PTR_ERR(dev); 341 342 ret = pci_enable_device(pdev); 343 if (ret) 344 goto err_free; 345 346 pci_set_drvdata(pdev, dev); 347 348 if (pci_find_capability(pdev, PCI_CAP_ID_AGP)) 349 dev->agp = drm_agp_init(dev); 350 if (dev->agp) { 351 dev->agp->agp_mtrr = arch_phys_wc_add( 352 dev->agp->agp_info.aper_base, 353 dev->agp->agp_info.aper_size * 354 1024 * 1024); 355 } 356 357 ret = drm_dev_register(dev, ent->driver_data); 358 if (ret) 359 goto err_agp; 360 361 return 0; 362 363 err_agp: 364 if (dev->agp) 365 arch_phys_wc_del(dev->agp->agp_mtrr); 366 kfree(dev->agp); 367 pci_disable_device(pdev); 368 err_free: 369 drm_dev_put(dev); 370 return ret; 371 } 372 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

1 year, 2 months

1
0
0 / 0

2022

2021

2020

2019

kbuild-all June 2021