[linux-next:master 4484/11714] drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:1700 dp_perform_8b_10b_link_training() warn: inconsistent indenting
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 889bab4c367a0ef58208fd80fafa74bb6e2dca26
commit: cd6a9a1c15c2942c6a3b19a33a2523a18229ec4a [4484/11714] drm/amd/display: isolate 8b 10b link training sequence into its own function
config: i386-randconfig-m021-20210622 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
New smatch warnings:
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:1700 dp_perform_8b_10b_link_training() warn: inconsistent indenting
Old smatch warnings:
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:1857 perform_link_training_with_retries() warn: inconsistent indenting
vim +1700 drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c
3df212576e8b6f Wenjing Liu 2021-05-03 1657
cd6a9a1c15c294 Wenjing Liu 2021-05-04 1658 static enum link_training_result dp_perform_8b_10b_link_training(
e0a6440a2961b1 David Galiffi 2019-05-30 1659 struct dc_link *link,
cd6a9a1c15c294 Wenjing Liu 2021-05-04 1660 struct link_training_settings *lt_settings)
e0a6440a2961b1 David Galiffi 2019-05-30 1661 {
e0a6440a2961b1 David Galiffi 2019-05-30 1662 enum link_training_result status = LINK_TRAINING_SUCCESS;
64c12b733fe7ea abdoulaye berthe 2019-07-24 1663
cd6a9a1c15c294 Wenjing Liu 2021-05-04 1664 uint8_t repeater_cnt;
cd6a9a1c15c294 Wenjing Liu 2021-05-04 1665 uint8_t repeater_id;
bcc5042a220903 abdoulaye berthe 2020-02-18 1666
82054678aeb669 Martin Leung 2020-02-12 1667 if (link->ctx->dc->work_arounds.lt_early_cr_pattern)
cd6a9a1c15c294 Wenjing Liu 2021-05-04 1668 start_clock_recovery_pattern_early(link, lt_settings, DPRX);
834a9a9f04c708 Martin Leung 2020-02-13 1669
834a9a9f04c708 Martin Leung 2020-02-13 1670 /* 1. set link rate, lane count and spread. */
cd6a9a1c15c294 Wenjing Liu 2021-05-04 1671 dpcd_set_link_settings(link, lt_settings);
e0a6440a2961b1 David Galiffi 2019-05-30 1672
3128b285021ec0 Wesley Chalmers 2021-03-15 1673 if (link->lttpr_mode == LTTPR_MODE_NON_TRANSPARENT) {
008a4016c5cf92 Nikola Cornij 2019-06-24 1674
e0a6440a2961b1 David Galiffi 2019-05-30 1675 /* 2. perform link training (set link training done
e0a6440a2961b1 David Galiffi 2019-05-30 1676 * to false is done as well)
e0a6440a2961b1 David Galiffi 2019-05-30 1677 */
573a0a03af0253 Jimmy Kizito 2021-04-09 1678 repeater_cnt = dp_convert_to_count(link->dpcd_caps.lttpr_caps.phy_repeater_cnt);
64c12b733fe7ea abdoulaye berthe 2019-07-24 1679
64c12b733fe7ea abdoulaye berthe 2019-07-24 1680 for (repeater_id = repeater_cnt; (repeater_id > 0 && status == LINK_TRAINING_SUCCESS);
64c12b733fe7ea abdoulaye berthe 2019-07-24 1681 repeater_id--) {
cd6a9a1c15c294 Wenjing Liu 2021-05-04 1682 status = perform_clock_recovery_sequence(link, lt_settings, repeater_id);
64c12b733fe7ea abdoulaye berthe 2019-07-24 1683
64c12b733fe7ea abdoulaye berthe 2019-07-24 1684 if (status != LINK_TRAINING_SUCCESS)
64c12b733fe7ea abdoulaye berthe 2019-07-24 1685 break;
64c12b733fe7ea abdoulaye berthe 2019-07-24 1686
64c12b733fe7ea abdoulaye berthe 2019-07-24 1687 status = perform_channel_equalization_sequence(link,
cd6a9a1c15c294 Wenjing Liu 2021-05-04 1688 lt_settings,
64c12b733fe7ea abdoulaye berthe 2019-07-24 1689 repeater_id);
64c12b733fe7ea abdoulaye berthe 2019-07-24 1690
64c12b733fe7ea abdoulaye berthe 2019-07-24 1691 if (status != LINK_TRAINING_SUCCESS)
64c12b733fe7ea abdoulaye berthe 2019-07-24 1692 break;
64c12b733fe7ea abdoulaye berthe 2019-07-24 1693
64c12b733fe7ea abdoulaye berthe 2019-07-24 1694 repeater_training_done(link, repeater_id);
64c12b733fe7ea abdoulaye berthe 2019-07-24 1695 }
64c12b733fe7ea abdoulaye berthe 2019-07-24 1696 }
64c12b733fe7ea abdoulaye berthe 2019-07-24 1697
64c12b733fe7ea abdoulaye berthe 2019-07-24 1698 if (status == LINK_TRAINING_SUCCESS) {
cd6a9a1c15c294 Wenjing Liu 2021-05-04 1699 status = perform_clock_recovery_sequence(link, lt_settings, DPRX);
e0a6440a2961b1 David Galiffi 2019-05-30 @1700 if (status == LINK_TRAINING_SUCCESS) {
e0a6440a2961b1 David Galiffi 2019-05-30 1701 status = perform_channel_equalization_sequence(link,
cd6a9a1c15c294 Wenjing Liu 2021-05-04 1702 lt_settings,
64c12b733fe7ea abdoulaye berthe 2019-07-24 1703 DPRX);
64c12b733fe7ea abdoulaye berthe 2019-07-24 1704 }
e0a6440a2961b1 David Galiffi 2019-05-30 1705 }
e0a6440a2961b1 David Galiffi 2019-05-30 1706
cd6a9a1c15c294 Wenjing Liu 2021-05-04 1707 return status;
e0a6440a2961b1 David Galiffi 2019-05-30 1708 }
e0a6440a2961b1 David Galiffi 2019-05-30 1709
:::::: The code at line 1700 was first introduced by commit
:::::: e0a6440a2961b1da3ea895b0bef082fc1a78e190 drm/amd/display: Add ability to set preferred link training parameters.
:::::: TO: David Galiffi <David.Galiffi(a)amd.com>
:::::: CC: Alex Deucher <alexander.deucher(a)amd.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 3 months
[chrome-os:chromeos-5.10 13810/14339] drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c:94 vcn_v3_0_early_init() warn: inconsistent indenting
by kernel test robot
tree: https://chromium.googlesource.com/chromiumos/third_party/kernel chromeos-5.10
head: 0849b9f7453e685727c7dc47bb4f6fb76a7fb94d
commit: 46ca45044aa5891ff3c7cdfbdd2f034c05f00060 [13810/14339] UPSTREAM: drm/amdgpu: Enable VCN for Beige Goby
config: x86_64-randconfig-m001-20210622 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
smatch warnings:
drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c:94 vcn_v3_0_early_init() warn: inconsistent indenting
vim +94 drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c
77
78 /**
79 * vcn_v3_0_early_init - set function pointers
80 *
81 * @handle: amdgpu_device pointer
82 *
83 * Set ring and irq function pointers
84 */
85 static int vcn_v3_0_early_init(void *handle)
86 {
87 struct amdgpu_device *adev = (struct amdgpu_device *)handle;
88
89 if (amdgpu_sriov_vf(adev)) {
90 adev->vcn.num_vcn_inst = VCN_INSTANCES_SIENNA_CICHLID;
91 adev->vcn.harvest_config = 0;
92 adev->vcn.num_enc_rings = 1;
93
> 94 if (adev->asic_type == CHIP_BEIGE_GOBY) {
95 adev->vcn.num_vcn_inst = 1;
96 adev->vcn.num_enc_rings = 0;
97 }
98
99 } else {
100 if (adev->asic_type == CHIP_SIENNA_CICHLID) {
101 u32 harvest;
102 int i;
103
104 adev->vcn.num_vcn_inst = VCN_INSTANCES_SIENNA_CICHLID;
105 for (i = 0; i < adev->vcn.num_vcn_inst; i++) {
106 harvest = RREG32_SOC15(VCN, i, mmCC_UVD_HARVESTING);
107 if (harvest & CC_UVD_HARVESTING__UVD_DISABLE_MASK)
108 adev->vcn.harvest_config |= 1 << i;
109 }
110
111 if (adev->vcn.harvest_config == (AMDGPU_VCN_HARVEST_VCN0 |
112 AMDGPU_VCN_HARVEST_VCN1))
113 /* both instances are harvested, disable the block */
114 return -ENOENT;
115 } else
116 adev->vcn.num_vcn_inst = 1;
117
118 if (adev->asic_type == CHIP_BEIGE_GOBY)
119 adev->vcn.num_enc_rings = 0;
120 else
121 adev->vcn.num_enc_rings = 2;
122 }
123
124 vcn_v3_0_set_dec_ring_funcs(adev);
125 vcn_v3_0_set_enc_ring_funcs(adev);
126 vcn_v3_0_set_irq_funcs(adev);
127
128 return 0;
129 }
130
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 3 months
drivers/phy/amlogic/phy-meson-axg-mipi-dphy.c:393 phy_meson_axg_mipi_dphy_probe() warn: 'priv->clk' not released on lines: 386,393.
by Dan Carpenter
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: a96bfed64c8986d6404e553f18203cae1f5ac7e6
commit: 76aefb221146dbe0de124f566329c76d5dcf118a phy: amlogic: Add AXG MIPI D-PHY driver
config: powerpc64-randconfig-m031-20210622 (attached as .config)
compiler: powerpc64le-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
smatch warnings:
drivers/phy/amlogic/phy-meson-axg-mipi-dphy.c:393 phy_meson_axg_mipi_dphy_probe() warn: 'priv->clk' not released on lines: 386,393.
vim +393 drivers/phy/amlogic/phy-meson-axg-mipi-dphy.c
76aefb221146db Neil Armstrong 2020-11-16 333 static int phy_meson_axg_mipi_dphy_probe(struct platform_device *pdev)
76aefb221146db Neil Armstrong 2020-11-16 334 {
76aefb221146db Neil Armstrong 2020-11-16 335 struct device *dev = &pdev->dev;
76aefb221146db Neil Armstrong 2020-11-16 336 struct phy_provider *phy_provider;
76aefb221146db Neil Armstrong 2020-11-16 337 struct resource *res;
76aefb221146db Neil Armstrong 2020-11-16 338 struct phy_meson_axg_mipi_dphy_priv *priv;
76aefb221146db Neil Armstrong 2020-11-16 339 struct phy *phy;
76aefb221146db Neil Armstrong 2020-11-16 340 void __iomem *base;
76aefb221146db Neil Armstrong 2020-11-16 341 int ret;
76aefb221146db Neil Armstrong 2020-11-16 342
76aefb221146db Neil Armstrong 2020-11-16 343 priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
76aefb221146db Neil Armstrong 2020-11-16 344 if (!priv)
76aefb221146db Neil Armstrong 2020-11-16 345 return -ENOMEM;
76aefb221146db Neil Armstrong 2020-11-16 346
76aefb221146db Neil Armstrong 2020-11-16 347 priv->dev = dev;
76aefb221146db Neil Armstrong 2020-11-16 348 platform_set_drvdata(pdev, priv);
76aefb221146db Neil Armstrong 2020-11-16 349
76aefb221146db Neil Armstrong 2020-11-16 350 res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
76aefb221146db Neil Armstrong 2020-11-16 351 base = devm_ioremap_resource(dev, res);
76aefb221146db Neil Armstrong 2020-11-16 352 if (IS_ERR(base))
76aefb221146db Neil Armstrong 2020-11-16 353 return PTR_ERR(base);
76aefb221146db Neil Armstrong 2020-11-16 354
76aefb221146db Neil Armstrong 2020-11-16 355 priv->regmap = devm_regmap_init_mmio(dev, base,
76aefb221146db Neil Armstrong 2020-11-16 356 &phy_meson_axg_mipi_dphy_regmap_conf);
76aefb221146db Neil Armstrong 2020-11-16 357 if (IS_ERR(priv->regmap))
76aefb221146db Neil Armstrong 2020-11-16 358 return PTR_ERR(priv->regmap);
76aefb221146db Neil Armstrong 2020-11-16 359
76aefb221146db Neil Armstrong 2020-11-16 360 priv->clk = devm_clk_get(dev, "pclk");
76aefb221146db Neil Armstrong 2020-11-16 361 if (IS_ERR(priv->clk))
76aefb221146db Neil Armstrong 2020-11-16 362 return PTR_ERR(priv->clk);
76aefb221146db Neil Armstrong 2020-11-16 363
76aefb221146db Neil Armstrong 2020-11-16 364 priv->reset = devm_reset_control_get(dev, "phy");
76aefb221146db Neil Armstrong 2020-11-16 365 if (IS_ERR(priv->reset))
76aefb221146db Neil Armstrong 2020-11-16 366 return PTR_ERR(priv->reset);
76aefb221146db Neil Armstrong 2020-11-16 367
76aefb221146db Neil Armstrong 2020-11-16 368 priv->analog = devm_phy_get(dev, "analog");
76aefb221146db Neil Armstrong 2020-11-16 369 if (IS_ERR(priv->analog))
76aefb221146db Neil Armstrong 2020-11-16 370 return PTR_ERR(priv->analog);
76aefb221146db Neil Armstrong 2020-11-16 371
76aefb221146db Neil Armstrong 2020-11-16 372 ret = clk_prepare_enable(priv->clk);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Is this worth unwinding if we hit an error later on? I doubt it really
matters. #StaticCheckerProblems
76aefb221146db Neil Armstrong 2020-11-16 373 if (ret)
76aefb221146db Neil Armstrong 2020-11-16 374 return ret;
76aefb221146db Neil Armstrong 2020-11-16 375
76aefb221146db Neil Armstrong 2020-11-16 376 ret = reset_control_deassert(priv->reset);
76aefb221146db Neil Armstrong 2020-11-16 377 if (ret)
76aefb221146db Neil Armstrong 2020-11-16 378 return ret;
^^^^^^^^^^
76aefb221146db Neil Armstrong 2020-11-16 379
76aefb221146db Neil Armstrong 2020-11-16 380 phy = devm_phy_create(dev, NULL, &phy_meson_axg_mipi_dphy_ops);
76aefb221146db Neil Armstrong 2020-11-16 381 if (IS_ERR(phy)) {
76aefb221146db Neil Armstrong 2020-11-16 382 ret = PTR_ERR(phy);
76aefb221146db Neil Armstrong 2020-11-16 383 if (ret != -EPROBE_DEFER)
76aefb221146db Neil Armstrong 2020-11-16 384 dev_err(dev, "failed to create PHY\n");
76aefb221146db Neil Armstrong 2020-11-16 385
76aefb221146db Neil Armstrong 2020-11-16 386 return ret;
76aefb221146db Neil Armstrong 2020-11-16 387 }
76aefb221146db Neil Armstrong 2020-11-16 388
76aefb221146db Neil Armstrong 2020-11-16 389 phy_set_drvdata(phy, priv);
76aefb221146db Neil Armstrong 2020-11-16 390
76aefb221146db Neil Armstrong 2020-11-16 391 phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
76aefb221146db Neil Armstrong 2020-11-16 392
76aefb221146db Neil Armstrong 2020-11-16 @393 return PTR_ERR_OR_ZERO(phy_provider);
76aefb221146db Neil Armstrong 2020-11-16 394 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 3 months
Re: [RFC PATCH 4/4] thermal: cpufreq_cooling: Improve power estimation based on Active Stats framework
by kernel test robot
Hi Lukasz,
[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on pm/linux-next]
[also build test ERROR on linux/master linus/master v5.13-rc7 next-20210621]
[cannot apply to daniel.lezcano/clockevents/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Lukasz-Luba/Introduce-Active-Sta...
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/0df5dd13ee23cf287d3045ee078cb727c...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Lukasz-Luba/Introduce-Active-Stats-framework-with-CPU-performance-statistics/20210622-160145
git checkout 0df5dd13ee23cf287d3045ee078cb727c184fece
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
drivers/thermal/cpufreq_cooling.c: In function '__cpufreq_cooling_register':
>> drivers/thermal/cpufreq_cooling.c:720:2: error: implicit declaration of function 'clean_cpu_monitoring' [-Werror=implicit-function-declaration]
720 | clean_cpu_monitoring(cpufreq_cdev);
| ^~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_PDC
Depends on SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && HAS_DMA
Selected by
- SND_ATMEL_SOC_SSC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC
- SND_ATMEL_SOC_SSC_PDC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && ATMEL_SSC
vim +/clean_cpu_monitoring +720 drivers/thermal/cpufreq_cooling.c
607
608 /**
609 * __cpufreq_cooling_register - helper function to create cpufreq cooling device
610 * @np: a valid struct device_node to the cooling device device tree node
611 * @policy: cpufreq policy
612 * Normally this should be same as cpufreq policy->related_cpus.
613 * @em: Energy Model of the cpufreq policy
614 *
615 * This interface function registers the cpufreq cooling device with the name
616 * "thermal-cpufreq-%x". This api can support multiple instances of cpufreq
617 * cooling devices. It also gives the opportunity to link the cooling device
618 * with a device tree node, in order to bind it via the thermal DT code.
619 *
620 * Return: a valid struct thermal_cooling_device pointer on success,
621 * on failure, it returns a corresponding ERR_PTR().
622 */
623 static struct thermal_cooling_device *
624 __cpufreq_cooling_register(struct device_node *np,
625 struct cpufreq_policy *policy,
626 struct em_perf_domain *em)
627 {
628 struct thermal_cooling_device *cdev;
629 struct cpufreq_cooling_device *cpufreq_cdev;
630 unsigned int i;
631 struct device *dev;
632 int ret;
633 struct thermal_cooling_device_ops *cooling_ops;
634 char *name;
635
636 dev = get_cpu_device(policy->cpu);
637 if (unlikely(!dev)) {
638 pr_warn("No cpu device for cpu %d\n", policy->cpu);
639 return ERR_PTR(-ENODEV);
640 }
641
642 if (IS_ERR_OR_NULL(policy)) {
643 pr_err("%s: cpufreq policy isn't valid: %p\n", __func__, policy);
644 return ERR_PTR(-EINVAL);
645 }
646
647 i = cpufreq_table_count_valid_entries(policy);
648 if (!i) {
649 pr_debug("%s: CPUFreq table not found or has no valid entries\n",
650 __func__);
651 return ERR_PTR(-ENODEV);
652 }
653
654 cpufreq_cdev = kzalloc(sizeof(*cpufreq_cdev), GFP_KERNEL);
655 if (!cpufreq_cdev)
656 return ERR_PTR(-ENOMEM);
657
658 cpufreq_cdev->policy = policy;
659
660 ret = allocate_idle_time(cpufreq_cdev);
661 if (ret) {
662 cdev = ERR_PTR(ret);
663 goto free_cdev;
664 }
665
666 /* max_level is an index, not a counter */
667 cpufreq_cdev->max_level = i - 1;
668
669 cooling_ops = &cpufreq_cooling_ops;
670
671 #ifdef CONFIG_THERMAL_GOV_POWER_ALLOCATOR
672 if (em_is_sane(cpufreq_cdev, em)) {
673 cpufreq_cdev->em = em;
674 cooling_ops->get_requested_power = cpufreq_get_requested_power;
675 cooling_ops->state2power = cpufreq_state2power;
676 cooling_ops->power2state = cpufreq_power2state;
677
678 ret = setup_cpu_monitoring(cpufreq_cdev);
679 if (ret) {
680 pr_err("%s: failed to alloc active_stats\n", __func__);
681 cdev = ERR_PTR(-EINVAL);
682 goto free_cdev;
683 }
684 } else
685 #endif
686 if (policy->freq_table_sorted == CPUFREQ_TABLE_UNSORTED) {
687 pr_err("%s: unsorted frequency tables are not supported\n",
688 __func__);
689 cdev = ERR_PTR(-EINVAL);
690 goto free_idle_time;
691 }
692
693 ret = freq_qos_add_request(&policy->constraints,
694 &cpufreq_cdev->qos_req, FREQ_QOS_MAX,
695 get_state_freq(cpufreq_cdev, 0));
696 if (ret < 0) {
697 pr_err("%s: Failed to add freq constraint (%d)\n", __func__,
698 ret);
699 cdev = ERR_PTR(ret);
700 goto remove_active_stats;
701 }
702
703 cdev = ERR_PTR(-ENOMEM);
704 name = kasprintf(GFP_KERNEL, "cpufreq-%s", dev_name(dev));
705 if (!name)
706 goto remove_qos_req;
707
708 cdev = thermal_of_cooling_device_register(np, name, cpufreq_cdev,
709 cooling_ops);
710 kfree(name);
711
712 if (IS_ERR(cdev))
713 goto remove_qos_req;
714
715 return cdev;
716
717 remove_qos_req:
718 freq_qos_remove_request(&cpufreq_cdev->qos_req);
719 remove_active_stats:
> 720 clean_cpu_monitoring(cpufreq_cdev);
721 free_idle_time:
722 free_idle_time(cpufreq_cdev);
723 free_cdev:
724 kfree(cpufreq_cdev);
725 return cdev;
726 }
727
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 3 months
[linux-next:master 8371/11714] drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c:438:10: error: implicit declaration of function 'rmnet_map_ipv6_dl_csum_trailer'; did you mean 'rmnet_map_ipv4_dl_csum_trailer'?
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 889bab4c367a0ef58208fd80fafa74bb6e2dca26
commit: 75db5b07f8c393c216fd20f7adc9a167fc684c23 [8371/11714] net: qualcomm: rmnet: eliminate some ifdefs
config: nds32-randconfig-s031-20210621 (attached as .config)
compiler: nds32le-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.3-341-g8af24329-dirty
# https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commi...
git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git fetch --no-tags linux-next master
git checkout 75db5b07f8c393c216fd20f7adc9a167fc684c23
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=nds32
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Note: the linux-next/master HEAD 889bab4c367a0ef58208fd80fafa74bb6e2dca26 builds fine.
It may have been fixed somewhere.
All errors (new ones prefixed by >>):
drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c: In function 'rmnet_map_checksum_downlink_packet':
>> drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c:438:10: error: implicit declaration of function 'rmnet_map_ipv6_dl_csum_trailer'; did you mean 'rmnet_map_ipv4_dl_csum_trailer'? [-Werror=implicit-function-declaration]
438 | return rmnet_map_ipv6_dl_csum_trailer(skb, csum_trailer, priv);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| rmnet_map_ipv4_dl_csum_trailer
drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c: In function 'rmnet_map_v4_checksum_uplink_packet':
>> drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c:472:3: error: implicit declaration of function 'rmnet_map_ipv6_ul_csum_header'; did you mean 'rmnet_map_ipv4_ul_csum_header'? [-Werror=implicit-function-declaration]
472 | rmnet_map_ipv6_ul_csum_header(iphdr, ul_header, skb);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| rmnet_map_ipv4_ul_csum_header
cc1: some warnings being treated as errors
vim +438 drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c
bbd21b247cb596 Subash Abhinov Kasiviswanathan 2018-01-07 410
bbd21b247cb596 Subash Abhinov Kasiviswanathan 2018-01-07 411 /* Validates packet checksums. Function takes a pointer to
bbd21b247cb596 Subash Abhinov Kasiviswanathan 2018-01-07 412 * the beginning of a buffer which contains the IP payload +
bbd21b247cb596 Subash Abhinov Kasiviswanathan 2018-01-07 413 * padding + checksum trailer.
bbd21b247cb596 Subash Abhinov Kasiviswanathan 2018-01-07 414 * Only IPv4 and IPv6 are supported along with TCP & UDP.
bbd21b247cb596 Subash Abhinov Kasiviswanathan 2018-01-07 415 * Fragmented or tunneled packets are not supported.
bbd21b247cb596 Subash Abhinov Kasiviswanathan 2018-01-07 416 */
bbd21b247cb596 Subash Abhinov Kasiviswanathan 2018-01-07 417 int rmnet_map_checksum_downlink_packet(struct sk_buff *skb, u16 len)
bbd21b247cb596 Subash Abhinov Kasiviswanathan 2018-01-07 418 {
bbde32d38bfbbc Subash Abhinov Kasiviswanathan 2018-05-15 419 struct rmnet_priv *priv = netdev_priv(skb->dev);
bbd21b247cb596 Subash Abhinov Kasiviswanathan 2018-01-07 420 struct rmnet_map_dl_csum_trailer *csum_trailer;
bbd21b247cb596 Subash Abhinov Kasiviswanathan 2018-01-07 421
bbde32d38bfbbc Subash Abhinov Kasiviswanathan 2018-05-15 422 if (unlikely(!(skb->dev->features & NETIF_F_RXCSUM))) {
bbde32d38bfbbc Subash Abhinov Kasiviswanathan 2018-05-15 423 priv->stats.csum_sw++;
bbd21b247cb596 Subash Abhinov Kasiviswanathan 2018-01-07 424 return -EOPNOTSUPP;
bbde32d38bfbbc Subash Abhinov Kasiviswanathan 2018-05-15 425 }
bbd21b247cb596 Subash Abhinov Kasiviswanathan 2018-01-07 426
bbd21b247cb596 Subash Abhinov Kasiviswanathan 2018-01-07 427 csum_trailer = (struct rmnet_map_dl_csum_trailer *)(skb->data + len);
bbd21b247cb596 Subash Abhinov Kasiviswanathan 2018-01-07 428
cc1b21ba6251c8 Alex Elder 2021-03-15 429 if (!(csum_trailer->flags & MAP_CSUM_DL_VALID_FLAG)) {
bbde32d38bfbbc Subash Abhinov Kasiviswanathan 2018-05-15 430 priv->stats.csum_valid_unset++;
bbd21b247cb596 Subash Abhinov Kasiviswanathan 2018-01-07 431 return -EINVAL;
bbde32d38bfbbc Subash Abhinov Kasiviswanathan 2018-05-15 432 }
bbd21b247cb596 Subash Abhinov Kasiviswanathan 2018-01-07 433
75db5b07f8c393 Alex Elder 2021-06-11 434 if (skb->protocol == htons(ETH_P_IP))
bbde32d38bfbbc Subash Abhinov Kasiviswanathan 2018-05-15 435 return rmnet_map_ipv4_dl_csum_trailer(skb, csum_trailer, priv);
75db5b07f8c393 Alex Elder 2021-06-11 436
75db5b07f8c393 Alex Elder 2021-06-11 437 if (IS_ENABLED(CONFIG_IPV6) && skb->protocol == htons(ETH_P_IPV6))
bbde32d38bfbbc Subash Abhinov Kasiviswanathan 2018-05-15 @438 return rmnet_map_ipv6_dl_csum_trailer(skb, csum_trailer, priv);
75db5b07f8c393 Alex Elder 2021-06-11 439
bbde32d38bfbbc Subash Abhinov Kasiviswanathan 2018-05-15 440 priv->stats.csum_err_invalid_ip_version++;
bbd21b247cb596 Subash Abhinov Kasiviswanathan 2018-01-07 441
75db5b07f8c393 Alex Elder 2021-06-11 442 return -EPROTONOSUPPORT;
bbd21b247cb596 Subash Abhinov Kasiviswanathan 2018-01-07 443 }
5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 444
b6e5d27e32ef60 Sharath Chandra Vurukala 2021-06-02 445 static void rmnet_map_v4_checksum_uplink_packet(struct sk_buff *skb,
5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 446 struct net_device *orig_dev)
5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 447 {
bbde32d38bfbbc Subash Abhinov Kasiviswanathan 2018-05-15 448 struct rmnet_priv *priv = netdev_priv(orig_dev);
5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 449 struct rmnet_map_ul_csum_header *ul_header;
5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 450 void *iphdr;
5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 451
5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 452 ul_header = (struct rmnet_map_ul_csum_header *)
5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 453 skb_push(skb, sizeof(struct rmnet_map_ul_csum_header));
5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 454
5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 455 if (unlikely(!(orig_dev->features &
5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 456 (NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM))))
5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 457 goto sw_csum;
5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 458
75db5b07f8c393 Alex Elder 2021-06-11 459 if (skb->ip_summed != CHECKSUM_PARTIAL)
75db5b07f8c393 Alex Elder 2021-06-11 460 goto sw_csum;
75db5b07f8c393 Alex Elder 2021-06-11 461
5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 462 iphdr = (char *)ul_header +
5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 463 sizeof(struct rmnet_map_ul_csum_header);
5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 464
5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 465 if (skb->protocol == htons(ETH_P_IP)) {
5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 466 rmnet_map_ipv4_ul_csum_header(iphdr, ul_header, skb);
b6e5d27e32ef60 Sharath Chandra Vurukala 2021-06-02 467 priv->stats.csum_hw++;
5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 468 return;
75db5b07f8c393 Alex Elder 2021-06-11 469 }
75db5b07f8c393 Alex Elder 2021-06-11 470
75db5b07f8c393 Alex Elder 2021-06-11 471 if (IS_ENABLED(CONFIG_IPV6) && skb->protocol == htons(ETH_P_IPV6)) {
5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 @472 rmnet_map_ipv6_ul_csum_header(iphdr, ul_header, skb);
b6e5d27e32ef60 Sharath Chandra Vurukala 2021-06-02 473 priv->stats.csum_hw++;
5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 474 return;
5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 475 }
5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 476
75db5b07f8c393 Alex Elder 2021-06-11 477 priv->stats.csum_err_invalid_ip_version++;
75db5b07f8c393 Alex Elder 2021-06-11 478
5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 479 sw_csum:
86ca860e12ec0f Alex Elder 2021-03-15 480 memset(ul_header, 0, sizeof(*ul_header));
bbde32d38bfbbc Subash Abhinov Kasiviswanathan 2018-05-15 481
bbde32d38bfbbc Subash Abhinov Kasiviswanathan 2018-05-15 482 priv->stats.csum_sw++;
5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 483 }
e1d9a90a9bfdb0 Sharath Chandra Vurukala 2021-06-02 484
:::::: The code at line 438 was first introduced by commit
:::::: bbde32d38bfbbc4a6970498c7470a8a817122735 net: qualcomm: rmnet: Add support for ethtool private stats
:::::: TO: Subash Abhinov Kasiviswanathan <subashab(a)codeaurora.org>
:::::: CC: David S. Miller <davem(a)davemloft.net>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 3 months
Re: [PATCH v8 2/2] leds: Add driver for Qualcomm LPG
by kernel test robot
Hi Bjorn,
I love your patch! Yet something to improve:
[auto build test ERROR on pavel-linux-leds/for-next]
[also build test ERROR on robh/for-next v5.13-rc7 next-20210621]
[cannot apply to j.anaszewski-leds/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Bjorn-Andersson/dt-bindings-leds...
base: git://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds.git for-next
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/eb89f3ce4c58b347137bbc2944d46b60d...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Bjorn-Andersson/dt-bindings-leds-Add-Qualcomm-Light-Pulse-Generator-binding/20210622-130332
git checkout eb89f3ce4c58b347137bbc2944d46b60d5c363c2
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All error/warnings (new ones prefixed by >>, old ones prefixed by <<):
>> ERROR: modpost: "__udivdi3" [drivers/leds/rgb/leds-qcom-lpg.ko] undefined!
ERROR: modpost: "__delay" [drivers/net/mdio/mdio-cavium.ko] undefined!
ERROR: modpost: "__udivdi3" [fs/btrfs/btrfs.ko] undefined!
ERROR: modpost: "__umoddi3" [fs/btrfs/btrfs.ko] undefined!
--
drivers/leds/rgb/leds-qcom-lpg.c: In function 'lpg_calc_freq':
>> drivers/leds/rgb/leds-qcom-lpg.c:276:29: warning: integer overflow in expression of type 'long int' results in '898891776' [-Woverflow]
276 | if (period <= NSEC_PER_SEC * LPG_RESOLUTION / 19200000)
| ^
drivers/leds/rgb/leds-qcom-lpg.c: In function 'lpg_apply_lut_control':
>> drivers/leds/rgb/leds-qcom-lpg.c:395:6: warning: variable 'pattern_len' set but not used [-Wunused-but-set-variable]
395 | int pattern_len;
| ^~~~~~~~~~~
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_PDC
Depends on SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && HAS_DMA
Selected by
- SND_ATMEL_SOC_SSC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC
- SND_ATMEL_SOC_SSC_PDC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && ATMEL_SSC
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 3 months
Re: [PATCH] This patch replaces all the instances of dev_info with drm_info macro
by kernel test robot
Hi Aman,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.13-rc7 next-20210621]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Aman-Jain/This-patch-replaces-al...
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git a96bfed64c8986d6404e553f18203cae1f5ac7e6
config: x86_64-randconfig-a002-20210622 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project b3634d3e88b7f26534a5057bff182b7dced584fc)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://github.com/0day-ci/linux/commit/aa0d692308d703f641f19def814f7c8d5...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Aman-Jain/This-patch-replaces-all-the-instances-of-dev_info-with-drm_info-macro/20210622-140850
git checkout aa0d692308d703f641f19def814f7c8d59468671
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> drivers/gpu/drm/radeon/radeon_drv.c:311:4: error: no member named 'dev' in 'struct device'
drm_info(&pdev->dev,
^~~~~~~~~~~~~~~~~~~~
include/drm/drm_print.h:416:2: note: expanded from macro 'drm_info'
__drm_printk((drm), info,, fmt, ##__VA_ARGS__)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/drm/drm_print.h:412:27: note: expanded from macro '__drm_printk'
dev_##level##type((drm)->dev, "[drm] " fmt, ##__VA_ARGS__)
~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:118:12: note: expanded from macro 'dev_info'
_dev_info(dev, dev_fmt(fmt), ##__VA_ARGS__)
^~~
drivers/gpu/drm/radeon/radeon_drv.c:323:4: error: no member named 'dev' in 'struct device'
drm_info(&pdev->dev,
^~~~~~~~~~~~~~~~~~~~
include/drm/drm_print.h:416:2: note: expanded from macro 'drm_info'
__drm_printk((drm), info,, fmt, ##__VA_ARGS__)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/drm/drm_print.h:412:27: note: expanded from macro '__drm_printk'
dev_##level##type((drm)->dev, "[drm] " fmt, ##__VA_ARGS__)
~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:118:12: note: expanded from macro 'dev_info'
_dev_info(dev, dev_fmt(fmt), ##__VA_ARGS__)
^~~
2 errors generated.
vim +311 drivers/gpu/drm/radeon/radeon_drv.c
291
292 static int radeon_pci_probe(struct pci_dev *pdev,
293 const struct pci_device_id *ent)
294 {
295 unsigned long flags = 0;
296 struct drm_device *dev;
297 int ret;
298
299 if (!ent)
300 return -ENODEV; /* Avoid NULL-ptr deref in drm_get_pci_dev */
301
302 flags = ent->driver_data;
303
304 if (!radeon_si_support) {
305 switch (flags & RADEON_FAMILY_MASK) {
306 case CHIP_TAHITI:
307 case CHIP_PITCAIRN:
308 case CHIP_VERDE:
309 case CHIP_OLAND:
310 case CHIP_HAINAN:
> 311 drm_info(&pdev->dev,
312 "SI support disabled by module param\n");
313 return -ENODEV;
314 }
315 }
316 if (!radeon_cik_support) {
317 switch (flags & RADEON_FAMILY_MASK) {
318 case CHIP_KAVERI:
319 case CHIP_BONAIRE:
320 case CHIP_HAWAII:
321 case CHIP_KABINI:
322 case CHIP_MULLINS:
323 drm_info(&pdev->dev,
324 "CIK support disabled by module param\n");
325 return -ENODEV;
326 }
327 }
328
329 if (vga_switcheroo_client_probe_defer(pdev))
330 return -EPROBE_DEFER;
331
332 /* Get rid of things like offb */
333 ret = drm_fb_helper_remove_conflicting_pci_framebuffers(pdev, "radeondrmfb");
334 if (ret)
335 return ret;
336
337 dev = drm_dev_alloc(&kms_driver, &pdev->dev);
338 if (IS_ERR(dev))
339 return PTR_ERR(dev);
340
341 ret = pci_enable_device(pdev);
342 if (ret)
343 goto err_free;
344
345 pci_set_drvdata(pdev, dev);
346
347 if (pci_find_capability(pdev, PCI_CAP_ID_AGP))
348 dev->agp = drm_agp_init(dev);
349 if (dev->agp) {
350 dev->agp->agp_mtrr = arch_phys_wc_add(
351 dev->agp->agp_info.aper_base,
352 dev->agp->agp_info.aper_size *
353 1024 * 1024);
354 }
355
356 ret = drm_dev_register(dev, ent->driver_data);
357 if (ret)
358 goto err_agp;
359
360 return 0;
361
362 err_agp:
363 if (dev->agp)
364 arch_phys_wc_del(dev->agp->agp_mtrr);
365 kfree(dev->agp);
366 pci_disable_device(pdev);
367 err_free:
368 drm_dev_put(dev);
369 return ret;
370 }
371
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 3 months
[intel-linux-intel-lts:4.19/android_r 19121/23451] socket.c:undefined reference to `wext_handle_ioctl'
by kernel test robot
Hi Randy,
FYI, the error/warning still remains.
tree: https://github.com/intel/linux-intel-lts.git 4.19/android_r
head: 71dbe8b787e34f3ce300217fc6ca5a2ec4aef447
commit: d50a6d412d61dbbde36becaf093d1b8ae3868b8a [19121/23451] binder.c modify secids for struct and param by refs
config: s390-allyesconfig (attached as .config)
compiler: s390-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel/linux-intel-lts/commit/d50a6d412d61dbbde36becaf0...
git remote add intel-linux-intel-lts https://github.com/intel/linux-intel-lts.git
git fetch --no-tags intel-linux-intel-lts 4.19/android_r
git checkout d50a6d412d61dbbde36becaf093d1b8ae3868b8a
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=s390
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
s390-linux-ld: net/socket.o: in function `sock_ioctl':
>> socket.c:(.text+0xe64): undefined reference to `wext_handle_ioctl'
s390-linux-ld: net/socket.o: in function `compat_sock_ioctl':
socket.c:(.text+0x292e): undefined reference to `compat_wext_handle_ioctl'
s390-linux-ld: net/core/net-procfs.o: in function `dev_proc_net_exit':
net-procfs.c:(.text+0xbf4): undefined reference to `wext_proc_exit'
s390-linux-ld: net/core/net-procfs.o: in function `dev_proc_net_init':
net-procfs.c:(.text+0xd08): undefined reference to `wext_proc_init'
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for WIRELESS_EXT
Depends on NET && WIRELESS
Selected by
- GKI_LEGACY_WEXT_ALLCONFIG
WARNING: unmet direct dependencies detected for WEXT_CORE
Depends on NET && WIRELESS && (CFG80211_WEXT || WIRELESS_EXT
Selected by
- GKI_LEGACY_WEXT_ALLCONFIG
WARNING: unmet direct dependencies detected for WEXT_PROC
Depends on NET && WIRELESS && PROC_FS && WEXT_CORE
Selected by
- GKI_LEGACY_WEXT_ALLCONFIG
WARNING: unmet direct dependencies detected for WEXT_PRIV
Depends on NET && WIRELESS
Selected by
- GKI_LEGACY_WEXT_ALLCONFIG
WARNING: unmet direct dependencies detected for WEXT_SPY
Depends on NET && WIRELESS
Selected by
- GKI_LEGACY_WEXT_ALLCONFIG
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 3 months
arch/mips/boot/compressed/../../../../lib/zstd/decompress.c:126:12: warning: no previous prototype for 'ZSTD_createDCtx_advanced'
by kernel test robot
Hi Paul,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: a96bfed64c8986d6404e553f18203cae1f5ac7e6
commit: a510b616131f85215ba156ed67e5ed1c0701f80f MIPS: Add support for ZSTD-compressed kernels
date: 10 months ago
config: mips-randconfig-r036-20210622 (attached as .config)
compiler: mips-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit...
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout a510b616131f85215ba156ed67e5ed1c0701f80f
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
arch/mips/boot/compressed/decompress.c:38:6: warning: no previous prototype for 'error' [-Wmissing-prototypes]
38 | void error(char *x)
| ^~~~~
In file included from arch/mips/boot/compressed/../../../../lib/decompress_unzstd.c:75,
from arch/mips/boot/compressed/decompress.c:76:
>> arch/mips/boot/compressed/../../../../lib/zstd/decompress.c:126:12: warning: no previous prototype for 'ZSTD_createDCtx_advanced' [-Wmissing-prototypes]
126 | ZSTD_DCtx *ZSTD_createDCtx_advanced(ZSTD_customMem customMem)
| ^~~~~~~~~~~~~~~~~~~~~~~~
>> arch/mips/boot/compressed/../../../../lib/zstd/decompress.c:394:8: warning: no previous prototype for 'ZSTD_getcBlockSize' [-Wmissing-prototypes]
394 | size_t ZSTD_getcBlockSize(const void *src, size_t srcSize, blockProperties_t *bpPtr)
| ^~~~~~~~~~~~~~~~~~
>> arch/mips/boot/compressed/../../../../lib/zstd/decompress.c:432:8: warning: no previous prototype for 'ZSTD_decodeLiteralsBlock' [-Wmissing-prototypes]
432 | size_t ZSTD_decodeLiteralsBlock(ZSTD_DCtx *dctx, const void *src, size_t srcSize) /* note : srcSize < BLOCKSIZE */
| ^~~~~~~~~~~~~~~~~~~~~~~~
>> arch/mips/boot/compressed/../../../../lib/zstd/decompress.c:794:8: warning: no previous prototype for 'ZSTD_decodeSeqHeaders' [-Wmissing-prototypes]
794 | size_t ZSTD_decodeSeqHeaders(ZSTD_DCtx *dctx, int *nbSeqPtr, const void *src, size_t srcSize)
| ^~~~~~~~~~~~~~~~~~~~~
>> arch/mips/boot/compressed/../../../../lib/zstd/decompress.c:1497:8: warning: no previous prototype for 'ZSTD_generateNxBytes' [-Wmissing-prototypes]
1497 | size_t ZSTD_generateNxBytes(void *dst, size_t dstCapacity, BYTE byte, size_t length)
| ^~~~~~~~~~~~~~~~~~~~
arch/mips/boot/compressed/decompress.c:81:6: warning: no previous prototype for '__stack_chk_fail' [-Wmissing-prototypes]
81 | void __stack_chk_fail(void)
| ^~~~~~~~~~~~~~~~
arch/mips/boot/compressed/decompress.c:86:6: warning: no previous prototype for 'decompress_kernel' [-Wmissing-prototypes]
86 | void decompress_kernel(unsigned long boot_heap_start)
| ^~~~~~~~~~~~~~~~~
In file included from arch/mips/boot/compressed/../../../../lib/zstd/fse_decompress.c:50,
from arch/mips/boot/compressed/../../../../lib/decompress_unzstd.c:72,
from arch/mips/boot/compressed/decompress.c:76:
arch/mips/boot/compressed/../../../../lib/zstd/zstd_internal.h:124:18: warning: 'OF_defaultNormLog' defined but not used [-Wunused-const-variable=]
124 | static const U32 OF_defaultNormLog = OF_DEFAULTNORMLOG;
| ^~~~~~~~~~~~~~~~~
arch/mips/boot/compressed/../../../../lib/zstd/zstd_internal.h:122:18: warning: 'OF_defaultNorm' defined but not used [-Wunused-const-variable=]
122 | static const S16 OF_defaultNorm[MaxOff + 1] = {1, 1, 1, 1, 1, 1, 2, 2, 2, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, -1, -1, -1, -1, -1};
| ^~~~~~~~~~~~~~
arch/mips/boot/compressed/../../../../lib/zstd/zstd_internal.h:120:18: warning: 'ML_defaultNormLog' defined but not used [-Wunused-const-variable=]
120 | static const U32 ML_defaultNormLog = ML_DEFAULTNORMLOG;
| ^~~~~~~~~~~~~~~~~
arch/mips/boot/compressed/../../../../lib/zstd/zstd_internal.h:117:18: warning: 'ML_defaultNorm' defined but not used [-Wunused-const-variable=]
117 | static const S16 ML_defaultNorm[MaxML + 1] = {1, 4, 3, 2, 2, 2, 2, 2, 2, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,
| ^~~~~~~~~~~~~~
arch/mips/boot/compressed/../../../../lib/zstd/zstd_internal.h:113:18: warning: 'LL_defaultNormLog' defined but not used [-Wunused-const-variable=]
113 | static const U32 LL_defaultNormLog = LL_DEFAULTNORMLOG;
| ^~~~~~~~~~~~~~~~~
arch/mips/boot/compressed/../../../../lib/zstd/zstd_internal.h:111:18: warning: 'LL_defaultNorm' defined but not used [-Wunused-const-variable=]
111 | static const S16 LL_defaultNorm[MaxLL + 1] = {4, 3, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 1, 1, 1, 2, 2, 2, 2, 2, 2, 2, 2, 2, 3, 2, 1, 1, 1, 1, 1, -1, -1, -1, -1};
| ^~~~~~~~~~~~~~
vim +/ZSTD_createDCtx_advanced +126 arch/mips/boot/compressed/../../../../lib/zstd/decompress.c
73f3d1b48f5069 Nick Terrell 2017-08-09 125
73f3d1b48f5069 Nick Terrell 2017-08-09 @126 ZSTD_DCtx *ZSTD_createDCtx_advanced(ZSTD_customMem customMem)
73f3d1b48f5069 Nick Terrell 2017-08-09 127 {
73f3d1b48f5069 Nick Terrell 2017-08-09 128 ZSTD_DCtx *dctx;
73f3d1b48f5069 Nick Terrell 2017-08-09 129
73f3d1b48f5069 Nick Terrell 2017-08-09 130 if (!customMem.customAlloc || !customMem.customFree)
73f3d1b48f5069 Nick Terrell 2017-08-09 131 return NULL;
73f3d1b48f5069 Nick Terrell 2017-08-09 132
73f3d1b48f5069 Nick Terrell 2017-08-09 133 dctx = (ZSTD_DCtx *)ZSTD_malloc(sizeof(ZSTD_DCtx), customMem);
73f3d1b48f5069 Nick Terrell 2017-08-09 134 if (!dctx)
73f3d1b48f5069 Nick Terrell 2017-08-09 135 return NULL;
73f3d1b48f5069 Nick Terrell 2017-08-09 136 memcpy(&dctx->customMem, &customMem, sizeof(customMem));
73f3d1b48f5069 Nick Terrell 2017-08-09 137 ZSTD_decompressBegin(dctx);
73f3d1b48f5069 Nick Terrell 2017-08-09 138 return dctx;
73f3d1b48f5069 Nick Terrell 2017-08-09 139 }
73f3d1b48f5069 Nick Terrell 2017-08-09 140
:::::: The code at line 126 was first introduced by commit
:::::: 73f3d1b48f5069d46ba48aa28c2898dc93185560 lib: Add zstd modules
:::::: TO: Nick Terrell <terrelln(a)fb.com>
:::::: CC: Chris Mason <clm(a)fb.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 3 months