[sashal-linux-stable:pending-4.19 42/61] drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c:277:22: error: 'extack' undeclared
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git pending-4.19
head: da0ab6f9b4814a4a16e1999273d7dbd1a348314b
commit: 8d8bd352b9fe3f9dc4e67930a5b26074f06a4d67 [42/61] net: qualcomm: rmnet: Update rmnet device MTU based on real device
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git/c...
git remote add sashal-linux-stable https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git
git fetch --no-tags sashal-linux-stable pending-4.19
git checkout 8d8bd352b9fe3f9dc4e67930a5b26074f06a4d67
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from include/uapi/linux/neighbour.h:6,
from include/linux/netdevice.h:50,
from include/linux/etherdevice.h:26,
from drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c:17:
drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c: In function 'rmnet_vnd_newlink':
>> drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c:277:22: error: 'extack' undeclared (first use in this function)
277 | NL_SET_ERR_MSG_MOD(extack, "Invalid MTU on real dev");
| ^~~~~~
include/linux/netlink.h:89:38: note: in definition of macro 'NL_SET_ERR_MSG'
89 | struct netlink_ext_ack *__extack = (extack); \
| ^~~~~~
drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c:277:3: note: in expansion of macro 'NL_SET_ERR_MSG_MOD'
277 | NL_SET_ERR_MSG_MOD(extack, "Invalid MTU on real dev");
| ^~~~~~~~~~~~~~~~~~
drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c:277:22: note: each undeclared identifier is reported only once for each function it appears in
277 | NL_SET_ERR_MSG_MOD(extack, "Invalid MTU on real dev");
| ^~~~~~
include/linux/netlink.h:89:38: note: in definition of macro 'NL_SET_ERR_MSG'
89 | struct netlink_ext_ack *__extack = (extack); \
| ^~~~~~
drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c:277:3: note: in expansion of macro 'NL_SET_ERR_MSG_MOD'
277 | NL_SET_ERR_MSG_MOD(extack, "Invalid MTU on real dev");
| ^~~~~~~~~~~~~~~~~~
vim +/extack +277 drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c
252
253 int rmnet_vnd_newlink(u8 id, struct net_device *rmnet_dev,
254 struct rmnet_port *port,
255 struct net_device *real_dev,
256 struct rmnet_endpoint *ep)
257 {
258 struct rmnet_priv *priv = netdev_priv(rmnet_dev);
259 u32 headroom;
260 int rc;
261
262 if (ep->egress_dev)
263 return -EINVAL;
264
265 if (rmnet_get_endpoint(port, id))
266 return -EBUSY;
267
268 rmnet_dev->hw_features = NETIF_F_RXCSUM;
269 rmnet_dev->hw_features |= NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM;
270 rmnet_dev->hw_features |= NETIF_F_SG;
271
272 priv->real_dev = real_dev;
273
274 headroom = rmnet_vnd_headroom(port);
275
276 if (rmnet_vnd_change_mtu(rmnet_dev, real_dev->mtu - headroom)) {
> 277 NL_SET_ERR_MSG_MOD(extack, "Invalid MTU on real dev");
278 return -EINVAL;
279 }
280
281 rc = register_netdevice(rmnet_dev);
282 if (!rc) {
283 ep->egress_dev = rmnet_dev;
284 ep->mux_id = id;
285 port->nr_rmnet_devs++;
286
287 rmnet_dev->rtnl_link_ops = &rmnet_link_ops;
288
289 priv->mux_id = id;
290
291 netdev_dbg(rmnet_dev, "rmnet dev created\n");
292 }
293
294 return rc;
295 }
296
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 3 months
[sashal-linux-stable:pending-4.19 31/61] net/ipv6/netfilter/nft_fib_ipv6.c:187:23: error: 'NF_INET_INGRESS' undeclared; did you mean 'NF_NETDEV_INGRESS'?
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git pending-4.19
head: da0ab6f9b4814a4a16e1999273d7dbd1a348314b
commit: ee315934ec9b10a653ca97ca4669ef2ed5a15006 [31/61] netfilter: nft_fib_ipv6: skip ipv6 packets from any to link-local
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git/c...
git remote add sashal-linux-stable https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git
git fetch --no-tags sashal-linux-stable pending-4.19
git checkout ee315934ec9b10a653ca97ca4669ef2ed5a15006
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
net/ipv6/netfilter/nft_fib_ipv6.c: In function 'nft_fib6_eval':
>> net/ipv6/netfilter/nft_fib_ipv6.c:187:23: error: 'NF_INET_INGRESS' undeclared (first use in this function); did you mean 'NF_NETDEV_INGRESS'?
187 | nft_hook(pkt) == NF_INET_INGRESS) {
| ^~~~~~~~~~~~~~~
| NF_NETDEV_INGRESS
net/ipv6/netfilter/nft_fib_ipv6.c:187:23: note: each undeclared identifier is reported only once for each function it appears in
vim +187 net/ipv6/netfilter/nft_fib_ipv6.c
157
158 void nft_fib6_eval(const struct nft_expr *expr, struct nft_regs *regs,
159 const struct nft_pktinfo *pkt)
160 {
161 const struct nft_fib *priv = nft_expr_priv(expr);
162 int noff = skb_network_offset(pkt->skb);
163 const struct net_device *oif = NULL;
164 u32 *dest = ®s->data[priv->dreg];
165 struct ipv6hdr *iph, _iph;
166 struct flowi6 fl6 = {
167 .flowi6_iif = LOOPBACK_IFINDEX,
168 .flowi6_proto = pkt->tprot,
169 };
170 struct rt6_info *rt;
171 int lookup_flags;
172
173 if (priv->flags & NFTA_FIB_F_IIF)
174 oif = nft_in(pkt);
175 else if (priv->flags & NFTA_FIB_F_OIF)
176 oif = nft_out(pkt);
177
178 iph = skb_header_pointer(pkt->skb, noff, sizeof(_iph), &_iph);
179 if (!iph) {
180 regs->verdict.code = NFT_BREAK;
181 return;
182 }
183
184 lookup_flags = nft_fib6_flowi_init(&fl6, priv, pkt, oif, iph);
185
186 if (nft_hook(pkt) == NF_INET_PRE_ROUTING ||
> 187 nft_hook(pkt) == NF_INET_INGRESS) {
188 if (nft_fib_is_loopback(pkt->skb, nft_in(pkt)) ||
189 nft_fib_v6_skip_icmpv6(pkt->skb, pkt->tprot, iph)) {
190 nft_fib_store_result(dest, priv, nft_in(pkt));
191 return;
192 }
193 }
194
195 *dest = 0;
196 rt = (void *)ip6_route_lookup(nft_net(pkt), &fl6, pkt->skb,
197 lookup_flags);
198 if (rt->dst.error)
199 goto put_rt_err;
200
201 /* Should not see RTF_LOCAL here */
202 if (rt->rt6i_flags & (RTF_REJECT | RTF_ANYCAST | RTF_LOCAL))
203 goto put_rt_err;
204
205 if (oif && oif != rt->rt6i_idev->dev)
206 goto put_rt_err;
207
208 nft_fib_store_result(dest, priv, rt->rt6i_idev->dev);
209 put_rt_err:
210 ip6_rt_put(rt);
211 }
212 EXPORT_SYMBOL_GPL(nft_fib6_eval);
213
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 3 months
[sashal-linux-stable:pending-4.19 29/61] net/ipv4/netfilter/nft_fib_ipv4.c:147:8: error: implicit declaration of function 'fib_info_nh_uses_dev'
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git pending-4.19
head: da0ab6f9b4814a4a16e1999273d7dbd1a348314b
commit: 0d2758421c8819aae1c231d905be29419b0da83c [29/61] netfilter: nft_fib: Convert nft_fib4_eval to new dev helper
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git/c...
git remote add sashal-linux-stable https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git
git fetch --no-tags sashal-linux-stable pending-4.19
git checkout 0d2758421c8819aae1c231d905be29419b0da83c
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
net/ipv4/netfilter/nft_fib_ipv4.c: In function 'nft_fib4_eval':
>> net/ipv4/netfilter/nft_fib_ipv4.c:147:8: error: implicit declaration of function 'fib_info_nh_uses_dev' [-Werror=implicit-function-declaration]
147 | if (!fib_info_nh_uses_dev(res.fi, oif))
| ^~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/fib_info_nh_uses_dev +147 net/ipv4/netfilter/nft_fib_ipv4.c
65
66 void nft_fib4_eval(const struct nft_expr *expr, struct nft_regs *regs,
67 const struct nft_pktinfo *pkt)
68 {
69 const struct nft_fib *priv = nft_expr_priv(expr);
70 int noff = skb_network_offset(pkt->skb);
71 u32 *dest = ®s->data[priv->dreg];
72 struct iphdr *iph, _iph;
73 struct fib_result res;
74 struct flowi4 fl4 = {
75 .flowi4_scope = RT_SCOPE_UNIVERSE,
76 .flowi4_iif = LOOPBACK_IFINDEX,
77 };
78 const struct net_device *oif;
79 const struct net_device *found;
80
81 /*
82 * Do not set flowi4_oif, it restricts results (for example, asking
83 * for oif 3 will get RTN_UNICAST result even if the daddr exits
84 * on another interface.
85 *
86 * Search results for the desired outinterface instead.
87 */
88 if (priv->flags & NFTA_FIB_F_OIF)
89 oif = nft_out(pkt);
90 else if (priv->flags & NFTA_FIB_F_IIF)
91 oif = nft_in(pkt);
92 else
93 oif = NULL;
94
95 if (nft_hook(pkt) == NF_INET_PRE_ROUTING &&
96 nft_fib_is_loopback(pkt->skb, nft_in(pkt))) {
97 nft_fib_store_result(dest, priv, pkt,
98 nft_in(pkt)->ifindex);
99 return;
100 }
101
102 iph = skb_header_pointer(pkt->skb, noff, sizeof(_iph), &_iph);
103 if (!iph) {
104 regs->verdict.code = NFT_BREAK;
105 return;
106 }
107
108 if (ipv4_is_zeronet(iph->saddr)) {
109 if (ipv4_is_lbcast(iph->daddr) ||
110 ipv4_is_local_multicast(iph->daddr)) {
111 nft_fib_store_result(dest, priv, pkt,
112 get_ifindex(pkt->skb->dev));
113 return;
114 }
115 }
116
117 if (priv->flags & NFTA_FIB_F_MARK)
118 fl4.flowi4_mark = pkt->skb->mark;
119
120 fl4.flowi4_tos = iph->tos & DSCP_BITS;
121
122 if (priv->flags & NFTA_FIB_F_DADDR) {
123 fl4.daddr = iph->daddr;
124 fl4.saddr = get_saddr(iph->saddr);
125 } else {
126 fl4.daddr = iph->saddr;
127 fl4.saddr = get_saddr(iph->daddr);
128 }
129
130 *dest = 0;
131
132 if (fib_lookup(nft_net(pkt), &fl4, &res, FIB_LOOKUP_IGNORE_LINKSTATE))
133 return;
134
135 switch (res.type) {
136 case RTN_UNICAST:
137 break;
138 case RTN_LOCAL: /* Should not see RTN_LOCAL here */
139 return;
140 default:
141 break;
142 }
143
144 if (!oif) {
145 found = FIB_RES_DEV(res);
146 } else {
> 147 if (!fib_info_nh_uses_dev(res.fi, oif))
148 return;
149
150 found = oif;
151 }
152
153 switch (priv->result) {
154 case NFT_FIB_RESULT_OIF:
155 *dest = found->ifindex;
156 break;
157 case NFT_FIB_RESULT_OIFNAME:
158 strncpy((char *)dest, found->name, IFNAMSIZ);
159 break;
160 default:
161 WARN_ON_ONCE(1);
162 break;
163 }
164 }
165 EXPORT_SYMBOL_GPL(nft_fib4_eval);
166
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 3 months
[sashal-linux-stable:pending-4.19 47/61] net/ipv4/ip_input.c:564:6: error: implicit declaration of function 'fib4_has_custom_rules'
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git pending-4.19
head: da0ab6f9b4814a4a16e1999273d7dbd1a348314b
commit: 145556839e5b22a724a2c7118e03a0531d844332 [47/61] ipv4: use dst hint for ipv4 list receive
config: x86_64-randconfig-a002-20210620 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project d1baf2895467735ab14f4b3415fce204c0cc8e7f)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git/c...
git remote add sashal-linux-stable https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git
git fetch --no-tags sashal-linux-stable pending-4.19
git checkout 145556839e5b22a724a2c7118e03a0531d844332
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
net/ipv4/ip_input.c:316:1: warning: declaration specifier missing, defaulting to 'int'
INDIRECT_CALLABLE_DECLARE(int udp_v4_early_demux(struct sk_buff *));
^
int
net/ipv4/ip_input.c:317:1: warning: declaration specifier missing, defaulting to 'int'
INDIRECT_CALLABLE_DECLARE(int tcp_v4_early_demux(struct sk_buff *));
^
int
net/ipv4/ip_input.c:343:10: error: implicit declaration of function 'INDIRECT_CALL_2' [-Werror,-Wimplicit-function-declaration]
err = INDIRECT_CALL_2(edemux, tcp_v4_early_demux,
^
net/ipv4/ip_input.c:343:34: error: use of undeclared identifier 'tcp_v4_early_demux'
err = INDIRECT_CALL_2(edemux, tcp_v4_early_demux,
^
net/ipv4/ip_input.c:344:12: error: use of undeclared identifier 'udp_v4_early_demux'
udp_v4_early_demux, skb);
^
>> net/ipv4/ip_input.c:564:6: error: implicit declaration of function 'fib4_has_custom_rules' [-Werror,-Wimplicit-function-declaration]
if (fib4_has_custom_rules(net) || rt_type == RTN_BROADCAST)
^
2 warnings and 4 errors generated.
vim +/fib4_has_custom_rules +564 net/ipv4/ip_input.c
560
561 static struct sk_buff *ip_extract_route_hint(const struct net *net,
562 struct sk_buff *skb, int rt_type)
563 {
> 564 if (fib4_has_custom_rules(net) || rt_type == RTN_BROADCAST)
565 return NULL;
566
567 return skb;
568 }
569
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 3 months