Re: [PATCH v10 3/6] usb: dwc3: Resize TX FIFOs to meet EP bursting requirements
by kernel test robot
Hi Wesley,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on usb/usb-testing]
[also build test WARNING on robh/for-next v5.13-rc6 next-20210617]
[cannot apply to balbi-usb/testing/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Wesley-Cheng/Re-introduce-TX-FIF...
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/94892083cf17e46a29d4ef33a044af048...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Wesley-Cheng/Re-introduce-TX-FIFO-resize-for-larger-EP-bursting/20210617-180037
git checkout 94892083cf17e46a29d4ef33a044af04854162e6
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
drivers/usb/dwc3/gadget.c: In function 'dwc3_gadget_clear_tx_fifos':
>> drivers/usb/dwc3/gadget.c:671:18: warning: variable 'dep' set but not used [-Wunused-but-set-variable]
671 | struct dwc3_ep *dep;
| ^~~
--
drivers/usb/dwc3/gadget.c:648: warning: Function parameter or member 'mult' not described in 'dwc3_gadget_calc_tx_fifo_size'
drivers/usb/dwc3/gadget.c:648: warning: Excess function parameter 'nfifos' description in 'dwc3_gadget_calc_tx_fifo_size'
>> drivers/usb/dwc3/gadget.c:670: warning: expecting prototype for dwc3_gadget_clear_tx_fifo_size(). Prototype was for dwc3_gadget_clear_tx_fifos() instead
vim +/dep +671 drivers/usb/dwc3/gadget.c
661
662 /**
663 * dwc3_gadget_clear_tx_fifo_size - Clears txfifo allocation
664 * @dwc: pointer to the DWC3 context
665 *
666 * Iterates through all the endpoint registers and clears the previous txfifo
667 * allocations.
668 */
669 void dwc3_gadget_clear_tx_fifos(struct dwc3 *dwc)
> 670 {
> 671 struct dwc3_ep *dep;
672 int fifo_depth;
673 int size;
674 int num;
675
676 if (!dwc->do_fifo_resize)
677 return;
678
679 /* Read ep0IN related TXFIFO size */
680 dep = dwc->eps[1];
681 size = dwc3_readl(dwc->regs, DWC3_GTXFIFOSIZ(0));
682 if (DWC3_IP_IS(DWC3))
683 fifo_depth = DWC3_GTXFIFOSIZ_TXFDEP(size);
684 else
685 fifo_depth = DWC31_GTXFIFOSIZ_TXFDEP(size);
686
687 dwc->last_fifo_depth = fifo_depth;
688 /* Clear existing TXFIFO for all IN eps except ep0 */
689 for (num = 3; num < min_t(int, dwc->num_eps, DWC3_ENDPOINTS_NUM);
690 num += 2) {
691 dep = dwc->eps[num];
692 /* Don't change TXFRAMNUM on usb31 version */
693 size = DWC3_IP_IS(DWC3) ? 0 :
694 dwc3_readl(dwc->regs, DWC3_GTXFIFOSIZ(num >> 1)) &
695 DWC31_GTXFIFOSIZ_TXFRAMNUM;
696
697 dwc3_writel(dwc->regs, DWC3_GTXFIFOSIZ(num >> 1), size);
698 }
699 dwc->num_ep_resized = 0;
700 }
701
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 3 months
Re: [PATCH 1/1] sched: Add tunable capacity margin for fis_capacity
by kernel test robot
Hi YT,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on pm/linux-next]
[also build test ERROR on tip/sched/core kees/for-next/pstore linus/master v5.13-rc6 next-20210617]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/YT-Chang/sched-Add-tunable-capac...
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
config: x86_64-randconfig-b001-20210617 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 64720f57bea6a6bf033feef4a5751ab9c0c3b401)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://github.com/0day-ci/linux/commit/5f9a234696d4aef51f1f2b506e7724760...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review YT-Chang/sched-Add-tunable-capacity-margin-for-fis_capacity/20210617-101010
git checkout 5f9a234696d4aef51f1f2b506e7724760bb0f907
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> kernel/sysctl.c:1747:13: error: use of undeclared identifier 'sysctl_sched_capacity_margin'; did you mean 'min_sched_capacity_margin'?
.data = &sysctl_sched_capacity_margin,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
min_sched_capacity_margin
kernel/sysctl.c:132:12: note: 'min_sched_capacity_margin' declared here
static int min_sched_capacity_margin = 1024;
^
1 error generated.
vim +1747 kernel/sysctl.c
1735
1736 static struct ctl_table kern_table[] = {
1737 {
1738 .procname = "sched_child_runs_first",
1739 .data = &sysctl_sched_child_runs_first,
1740 .maxlen = sizeof(unsigned int),
1741 .mode = 0644,
1742 .proc_handler = proc_dointvec,
1743 },
1744 #ifdef CONFIG_SMP
1745 {
1746 .procname = "sched_capcity_margin",
> 1747 .data = &sysctl_sched_capacity_margin,
1748 .maxlen = sizeof(unsigned int),
1749 .mode = 0644,
1750 .proc_handler = proc_dointvec_minmax,
1751 .extra1 = &min_sched_capacity_margin,
1752 },
1753 #endif
1754 #ifdef CONFIG_SCHEDSTATS
1755 {
1756 .procname = "sched_schedstats",
1757 .data = NULL,
1758 .maxlen = sizeof(unsigned int),
1759 .mode = 0644,
1760 .proc_handler = sysctl_schedstats,
1761 .extra1 = SYSCTL_ZERO,
1762 .extra2 = SYSCTL_ONE,
1763 },
1764 #endif /* CONFIG_SCHEDSTATS */
1765 #ifdef CONFIG_NUMA_BALANCING
1766 {
1767 .procname = "numa_balancing",
1768 .data = NULL, /* filled in by handler */
1769 .maxlen = sizeof(unsigned int),
1770 .mode = 0644,
1771 .proc_handler = sysctl_numa_balancing,
1772 .extra1 = SYSCTL_ZERO,
1773 .extra2 = SYSCTL_ONE,
1774 },
1775 #endif /* CONFIG_NUMA_BALANCING */
1776 {
1777 .procname = "sched_rt_period_us",
1778 .data = &sysctl_sched_rt_period,
1779 .maxlen = sizeof(unsigned int),
1780 .mode = 0644,
1781 .proc_handler = sched_rt_handler,
1782 },
1783 {
1784 .procname = "sched_rt_runtime_us",
1785 .data = &sysctl_sched_rt_runtime,
1786 .maxlen = sizeof(int),
1787 .mode = 0644,
1788 .proc_handler = sched_rt_handler,
1789 },
1790 {
1791 .procname = "sched_deadline_period_max_us",
1792 .data = &sysctl_sched_dl_period_max,
1793 .maxlen = sizeof(unsigned int),
1794 .mode = 0644,
1795 .proc_handler = proc_dointvec,
1796 },
1797 {
1798 .procname = "sched_deadline_period_min_us",
1799 .data = &sysctl_sched_dl_period_min,
1800 .maxlen = sizeof(unsigned int),
1801 .mode = 0644,
1802 .proc_handler = proc_dointvec,
1803 },
1804 {
1805 .procname = "sched_rr_timeslice_ms",
1806 .data = &sysctl_sched_rr_timeslice,
1807 .maxlen = sizeof(int),
1808 .mode = 0644,
1809 .proc_handler = sched_rr_handler,
1810 },
1811 #ifdef CONFIG_UCLAMP_TASK
1812 {
1813 .procname = "sched_util_clamp_min",
1814 .data = &sysctl_sched_uclamp_util_min,
1815 .maxlen = sizeof(unsigned int),
1816 .mode = 0644,
1817 .proc_handler = sysctl_sched_uclamp_handler,
1818 },
1819 {
1820 .procname = "sched_util_clamp_max",
1821 .data = &sysctl_sched_uclamp_util_max,
1822 .maxlen = sizeof(unsigned int),
1823 .mode = 0644,
1824 .proc_handler = sysctl_sched_uclamp_handler,
1825 },
1826 {
1827 .procname = "sched_util_clamp_min_rt_default",
1828 .data = &sysctl_sched_uclamp_util_min_rt_default,
1829 .maxlen = sizeof(unsigned int),
1830 .mode = 0644,
1831 .proc_handler = sysctl_sched_uclamp_handler,
1832 },
1833 #endif
1834 #ifdef CONFIG_SCHED_AUTOGROUP
1835 {
1836 .procname = "sched_autogroup_enabled",
1837 .data = &sysctl_sched_autogroup_enabled,
1838 .maxlen = sizeof(unsigned int),
1839 .mode = 0644,
1840 .proc_handler = proc_dointvec_minmax,
1841 .extra1 = SYSCTL_ZERO,
1842 .extra2 = SYSCTL_ONE,
1843 },
1844 #endif
1845 #ifdef CONFIG_CFS_BANDWIDTH
1846 {
1847 .procname = "sched_cfs_bandwidth_slice_us",
1848 .data = &sysctl_sched_cfs_bandwidth_slice,
1849 .maxlen = sizeof(unsigned int),
1850 .mode = 0644,
1851 .proc_handler = proc_dointvec_minmax,
1852 .extra1 = SYSCTL_ONE,
1853 },
1854 #endif
1855 #if defined(CONFIG_ENERGY_MODEL) && defined(CONFIG_CPU_FREQ_GOV_SCHEDUTIL)
1856 {
1857 .procname = "sched_energy_aware",
1858 .data = &sysctl_sched_energy_aware,
1859 .maxlen = sizeof(unsigned int),
1860 .mode = 0644,
1861 .proc_handler = sched_energy_aware_handler,
1862 .extra1 = SYSCTL_ZERO,
1863 .extra2 = SYSCTL_ONE,
1864 },
1865 #endif
1866 #ifdef CONFIG_PROVE_LOCKING
1867 {
1868 .procname = "prove_locking",
1869 .data = &prove_locking,
1870 .maxlen = sizeof(int),
1871 .mode = 0644,
1872 .proc_handler = proc_dointvec,
1873 },
1874 #endif
1875 #ifdef CONFIG_LOCK_STAT
1876 {
1877 .procname = "lock_stat",
1878 .data = &lock_stat,
1879 .maxlen = sizeof(int),
1880 .mode = 0644,
1881 .proc_handler = proc_dointvec,
1882 },
1883 #endif
1884 {
1885 .procname = "panic",
1886 .data = &panic_timeout,
1887 .maxlen = sizeof(int),
1888 .mode = 0644,
1889 .proc_handler = proc_dointvec,
1890 },
1891 #ifdef CONFIG_COREDUMP
1892 {
1893 .procname = "core_uses_pid",
1894 .data = &core_uses_pid,
1895 .maxlen = sizeof(int),
1896 .mode = 0644,
1897 .proc_handler = proc_dointvec,
1898 },
1899 {
1900 .procname = "core_pattern",
1901 .data = core_pattern,
1902 .maxlen = CORENAME_MAX_SIZE,
1903 .mode = 0644,
1904 .proc_handler = proc_dostring_coredump,
1905 },
1906 {
1907 .procname = "core_pipe_limit",
1908 .data = &core_pipe_limit,
1909 .maxlen = sizeof(unsigned int),
1910 .mode = 0644,
1911 .proc_handler = proc_dointvec,
1912 },
1913 #endif
1914 #ifdef CONFIG_PROC_SYSCTL
1915 {
1916 .procname = "tainted",
1917 .maxlen = sizeof(long),
1918 .mode = 0644,
1919 .proc_handler = proc_taint,
1920 },
1921 {
1922 .procname = "sysctl_writes_strict",
1923 .data = &sysctl_writes_strict,
1924 .maxlen = sizeof(int),
1925 .mode = 0644,
1926 .proc_handler = proc_dointvec_minmax,
1927 .extra1 = &neg_one,
1928 .extra2 = SYSCTL_ONE,
1929 },
1930 #endif
1931 #ifdef CONFIG_LATENCYTOP
1932 {
1933 .procname = "latencytop",
1934 .data = &latencytop_enabled,
1935 .maxlen = sizeof(int),
1936 .mode = 0644,
1937 .proc_handler = sysctl_latencytop,
1938 },
1939 #endif
1940 #ifdef CONFIG_BLK_DEV_INITRD
1941 {
1942 .procname = "real-root-dev",
1943 .data = &real_root_dev,
1944 .maxlen = sizeof(int),
1945 .mode = 0644,
1946 .proc_handler = proc_dointvec,
1947 },
1948 #endif
1949 {
1950 .procname = "print-fatal-signals",
1951 .data = &print_fatal_signals,
1952 .maxlen = sizeof(int),
1953 .mode = 0644,
1954 .proc_handler = proc_dointvec,
1955 },
1956 #ifdef CONFIG_SPARC
1957 {
1958 .procname = "reboot-cmd",
1959 .data = reboot_command,
1960 .maxlen = 256,
1961 .mode = 0644,
1962 .proc_handler = proc_dostring,
1963 },
1964 {
1965 .procname = "stop-a",
1966 .data = &stop_a_enabled,
1967 .maxlen = sizeof (int),
1968 .mode = 0644,
1969 .proc_handler = proc_dointvec,
1970 },
1971 {
1972 .procname = "scons-poweroff",
1973 .data = &scons_pwroff,
1974 .maxlen = sizeof (int),
1975 .mode = 0644,
1976 .proc_handler = proc_dointvec,
1977 },
1978 #endif
1979 #ifdef CONFIG_SPARC64
1980 {
1981 .procname = "tsb-ratio",
1982 .data = &sysctl_tsb_ratio,
1983 .maxlen = sizeof (int),
1984 .mode = 0644,
1985 .proc_handler = proc_dointvec,
1986 },
1987 #endif
1988 #ifdef CONFIG_PARISC
1989 {
1990 .procname = "soft-power",
1991 .data = &pwrsw_enabled,
1992 .maxlen = sizeof (int),
1993 .mode = 0644,
1994 .proc_handler = proc_dointvec,
1995 },
1996 #endif
1997 #ifdef CONFIG_SYSCTL_ARCH_UNALIGN_ALLOW
1998 {
1999 .procname = "unaligned-trap",
2000 .data = &unaligned_enabled,
2001 .maxlen = sizeof (int),
2002 .mode = 0644,
2003 .proc_handler = proc_dointvec,
2004 },
2005 #endif
2006 {
2007 .procname = "ctrl-alt-del",
2008 .data = &C_A_D,
2009 .maxlen = sizeof(int),
2010 .mode = 0644,
2011 .proc_handler = proc_dointvec,
2012 },
2013 #ifdef CONFIG_FUNCTION_TRACER
2014 {
2015 .procname = "ftrace_enabled",
2016 .data = &ftrace_enabled,
2017 .maxlen = sizeof(int),
2018 .mode = 0644,
2019 .proc_handler = ftrace_enable_sysctl,
2020 },
2021 #endif
2022 #ifdef CONFIG_STACK_TRACER
2023 {
2024 .procname = "stack_tracer_enabled",
2025 .data = &stack_tracer_enabled,
2026 .maxlen = sizeof(int),
2027 .mode = 0644,
2028 .proc_handler = stack_trace_sysctl,
2029 },
2030 #endif
2031 #ifdef CONFIG_TRACING
2032 {
2033 .procname = "ftrace_dump_on_oops",
2034 .data = &ftrace_dump_on_oops,
2035 .maxlen = sizeof(int),
2036 .mode = 0644,
2037 .proc_handler = proc_dointvec,
2038 },
2039 {
2040 .procname = "traceoff_on_warning",
2041 .data = &__disable_trace_on_warning,
2042 .maxlen = sizeof(__disable_trace_on_warning),
2043 .mode = 0644,
2044 .proc_handler = proc_dointvec,
2045 },
2046 {
2047 .procname = "tracepoint_printk",
2048 .data = &tracepoint_printk,
2049 .maxlen = sizeof(tracepoint_printk),
2050 .mode = 0644,
2051 .proc_handler = tracepoint_printk_sysctl,
2052 },
2053 #endif
2054 #ifdef CONFIG_KEXEC_CORE
2055 {
2056 .procname = "kexec_load_disabled",
2057 .data = &kexec_load_disabled,
2058 .maxlen = sizeof(int),
2059 .mode = 0644,
2060 /* only handle a transition from default "0" to "1" */
2061 .proc_handler = proc_dointvec_minmax,
2062 .extra1 = SYSCTL_ONE,
2063 .extra2 = SYSCTL_ONE,
2064 },
2065 #endif
2066 #ifdef CONFIG_MODULES
2067 {
2068 .procname = "modprobe",
2069 .data = &modprobe_path,
2070 .maxlen = KMOD_PATH_LEN,
2071 .mode = 0644,
2072 .proc_handler = proc_dostring,
2073 },
2074 {
2075 .procname = "modules_disabled",
2076 .data = &modules_disabled,
2077 .maxlen = sizeof(int),
2078 .mode = 0644,
2079 /* only handle a transition from default "0" to "1" */
2080 .proc_handler = proc_dointvec_minmax,
2081 .extra1 = SYSCTL_ONE,
2082 .extra2 = SYSCTL_ONE,
2083 },
2084 #endif
2085 #ifdef CONFIG_UEVENT_HELPER
2086 {
2087 .procname = "hotplug",
2088 .data = &uevent_helper,
2089 .maxlen = UEVENT_HELPER_PATH_LEN,
2090 .mode = 0644,
2091 .proc_handler = proc_dostring,
2092 },
2093 #endif
2094 #ifdef CONFIG_CHR_DEV_SG
2095 {
2096 .procname = "sg-big-buff",
2097 .data = &sg_big_buff,
2098 .maxlen = sizeof (int),
2099 .mode = 0444,
2100 .proc_handler = proc_dointvec,
2101 },
2102 #endif
2103 #ifdef CONFIG_BSD_PROCESS_ACCT
2104 {
2105 .procname = "acct",
2106 .data = &acct_parm,
2107 .maxlen = 3*sizeof(int),
2108 .mode = 0644,
2109 .proc_handler = proc_dointvec,
2110 },
2111 #endif
2112 #ifdef CONFIG_MAGIC_SYSRQ
2113 {
2114 .procname = "sysrq",
2115 .data = NULL,
2116 .maxlen = sizeof (int),
2117 .mode = 0644,
2118 .proc_handler = sysrq_sysctl_handler,
2119 },
2120 #endif
2121 #ifdef CONFIG_PROC_SYSCTL
2122 {
2123 .procname = "cad_pid",
2124 .data = NULL,
2125 .maxlen = sizeof (int),
2126 .mode = 0600,
2127 .proc_handler = proc_do_cad_pid,
2128 },
2129 #endif
2130 {
2131 .procname = "threads-max",
2132 .data = NULL,
2133 .maxlen = sizeof(int),
2134 .mode = 0644,
2135 .proc_handler = sysctl_max_threads,
2136 },
2137 {
2138 .procname = "random",
2139 .mode = 0555,
2140 .child = random_table,
2141 },
2142 {
2143 .procname = "usermodehelper",
2144 .mode = 0555,
2145 .child = usermodehelper_table,
2146 },
2147 #ifdef CONFIG_FW_LOADER_USER_HELPER
2148 {
2149 .procname = "firmware_config",
2150 .mode = 0555,
2151 .child = firmware_config_table,
2152 },
2153 #endif
2154 {
2155 .procname = "overflowuid",
2156 .data = &overflowuid,
2157 .maxlen = sizeof(int),
2158 .mode = 0644,
2159 .proc_handler = proc_dointvec_minmax,
2160 .extra1 = &minolduid,
2161 .extra2 = &maxolduid,
2162 },
2163 {
2164 .procname = "overflowgid",
2165 .data = &overflowgid,
2166 .maxlen = sizeof(int),
2167 .mode = 0644,
2168 .proc_handler = proc_dointvec_minmax,
2169 .extra1 = &minolduid,
2170 .extra2 = &maxolduid,
2171 },
2172 #ifdef CONFIG_S390
2173 {
2174 .procname = "userprocess_debug",
2175 .data = &show_unhandled_signals,
2176 .maxlen = sizeof(int),
2177 .mode = 0644,
2178 .proc_handler = proc_dointvec,
2179 },
2180 #endif
2181 #ifdef CONFIG_SMP
2182 {
2183 .procname = "oops_all_cpu_backtrace",
2184 .data = &sysctl_oops_all_cpu_backtrace,
2185 .maxlen = sizeof(int),
2186 .mode = 0644,
2187 .proc_handler = proc_dointvec_minmax,
2188 .extra1 = SYSCTL_ZERO,
2189 .extra2 = SYSCTL_ONE,
2190 },
2191 #endif /* CONFIG_SMP */
2192 {
2193 .procname = "pid_max",
2194 .data = &pid_max,
2195 .maxlen = sizeof (int),
2196 .mode = 0644,
2197 .proc_handler = proc_dointvec_minmax,
2198 .extra1 = &pid_max_min,
2199 .extra2 = &pid_max_max,
2200 },
2201 {
2202 .procname = "panic_on_oops",
2203 .data = &panic_on_oops,
2204 .maxlen = sizeof(int),
2205 .mode = 0644,
2206 .proc_handler = proc_dointvec,
2207 },
2208 {
2209 .procname = "panic_print",
2210 .data = &panic_print,
2211 .maxlen = sizeof(unsigned long),
2212 .mode = 0644,
2213 .proc_handler = proc_doulongvec_minmax,
2214 },
2215 #if defined CONFIG_PRINTK
2216 {
2217 .procname = "printk",
2218 .data = &console_loglevel,
2219 .maxlen = 4*sizeof(int),
2220 .mode = 0644,
2221 .proc_handler = proc_dointvec,
2222 },
2223 {
2224 .procname = "printk_ratelimit",
2225 .data = &printk_ratelimit_state.interval,
2226 .maxlen = sizeof(int),
2227 .mode = 0644,
2228 .proc_handler = proc_dointvec_jiffies,
2229 },
2230 {
2231 .procname = "printk_ratelimit_burst",
2232 .data = &printk_ratelimit_state.burst,
2233 .maxlen = sizeof(int),
2234 .mode = 0644,
2235 .proc_handler = proc_dointvec,
2236 },
2237 {
2238 .procname = "printk_delay",
2239 .data = &printk_delay_msec,
2240 .maxlen = sizeof(int),
2241 .mode = 0644,
2242 .proc_handler = proc_dointvec_minmax,
2243 .extra1 = SYSCTL_ZERO,
2244 .extra2 = &ten_thousand,
2245 },
2246 {
2247 .procname = "printk_devkmsg",
2248 .data = devkmsg_log_str,
2249 .maxlen = DEVKMSG_STR_MAX_SIZE,
2250 .mode = 0644,
2251 .proc_handler = devkmsg_sysctl_set_loglvl,
2252 },
2253 {
2254 .procname = "dmesg_restrict",
2255 .data = &dmesg_restrict,
2256 .maxlen = sizeof(int),
2257 .mode = 0644,
2258 .proc_handler = proc_dointvec_minmax_sysadmin,
2259 .extra1 = SYSCTL_ZERO,
2260 .extra2 = SYSCTL_ONE,
2261 },
2262 {
2263 .procname = "kptr_restrict",
2264 .data = &kptr_restrict,
2265 .maxlen = sizeof(int),
2266 .mode = 0644,
2267 .proc_handler = proc_dointvec_minmax_sysadmin,
2268 .extra1 = SYSCTL_ZERO,
2269 .extra2 = &two,
2270 },
2271 #endif
2272 {
2273 .procname = "ngroups_max",
2274 .data = &ngroups_max,
2275 .maxlen = sizeof (int),
2276 .mode = 0444,
2277 .proc_handler = proc_dointvec,
2278 },
2279 {
2280 .procname = "cap_last_cap",
2281 .data = (void *)&cap_last_cap,
2282 .maxlen = sizeof(int),
2283 .mode = 0444,
2284 .proc_handler = proc_dointvec,
2285 },
2286 #if defined(CONFIG_LOCKUP_DETECTOR)
2287 {
2288 .procname = "watchdog",
2289 .data = &watchdog_user_enabled,
2290 .maxlen = sizeof(int),
2291 .mode = 0644,
2292 .proc_handler = proc_watchdog,
2293 .extra1 = SYSCTL_ZERO,
2294 .extra2 = SYSCTL_ONE,
2295 },
2296 {
2297 .procname = "watchdog_thresh",
2298 .data = &watchdog_thresh,
2299 .maxlen = sizeof(int),
2300 .mode = 0644,
2301 .proc_handler = proc_watchdog_thresh,
2302 .extra1 = SYSCTL_ZERO,
2303 .extra2 = &sixty,
2304 },
2305 {
2306 .procname = "nmi_watchdog",
2307 .data = &nmi_watchdog_user_enabled,
2308 .maxlen = sizeof(int),
2309 .mode = NMI_WATCHDOG_SYSCTL_PERM,
2310 .proc_handler = proc_nmi_watchdog,
2311 .extra1 = SYSCTL_ZERO,
2312 .extra2 = SYSCTL_ONE,
2313 },
2314 {
2315 .procname = "watchdog_cpumask",
2316 .data = &watchdog_cpumask_bits,
2317 .maxlen = NR_CPUS,
2318 .mode = 0644,
2319 .proc_handler = proc_watchdog_cpumask,
2320 },
2321 #ifdef CONFIG_SOFTLOCKUP_DETECTOR
2322 {
2323 .procname = "soft_watchdog",
2324 .data = &soft_watchdog_user_enabled,
2325 .maxlen = sizeof(int),
2326 .mode = 0644,
2327 .proc_handler = proc_soft_watchdog,
2328 .extra1 = SYSCTL_ZERO,
2329 .extra2 = SYSCTL_ONE,
2330 },
2331 {
2332 .procname = "softlockup_panic",
2333 .data = &softlockup_panic,
2334 .maxlen = sizeof(int),
2335 .mode = 0644,
2336 .proc_handler = proc_dointvec_minmax,
2337 .extra1 = SYSCTL_ZERO,
2338 .extra2 = SYSCTL_ONE,
2339 },
2340 #ifdef CONFIG_SMP
2341 {
2342 .procname = "softlockup_all_cpu_backtrace",
2343 .data = &sysctl_softlockup_all_cpu_backtrace,
2344 .maxlen = sizeof(int),
2345 .mode = 0644,
2346 .proc_handler = proc_dointvec_minmax,
2347 .extra1 = SYSCTL_ZERO,
2348 .extra2 = SYSCTL_ONE,
2349 },
2350 #endif /* CONFIG_SMP */
2351 #endif
2352 #ifdef CONFIG_HARDLOCKUP_DETECTOR
2353 {
2354 .procname = "hardlockup_panic",
2355 .data = &hardlockup_panic,
2356 .maxlen = sizeof(int),
2357 .mode = 0644,
2358 .proc_handler = proc_dointvec_minmax,
2359 .extra1 = SYSCTL_ZERO,
2360 .extra2 = SYSCTL_ONE,
2361 },
2362 #ifdef CONFIG_SMP
2363 {
2364 .procname = "hardlockup_all_cpu_backtrace",
2365 .data = &sysctl_hardlockup_all_cpu_backtrace,
2366 .maxlen = sizeof(int),
2367 .mode = 0644,
2368 .proc_handler = proc_dointvec_minmax,
2369 .extra1 = SYSCTL_ZERO,
2370 .extra2 = SYSCTL_ONE,
2371 },
2372 #endif /* CONFIG_SMP */
2373 #endif
2374 #endif
2375
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 3 months
Re: [PATCH v10 3/6] usb: dwc3: Resize TX FIFOs to meet EP bursting requirements
by kernel test robot
Hi Wesley,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on usb/usb-testing]
[also build test WARNING on robh/for-next v5.13-rc6 next-20210617]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Wesley-Cheng/Re-introduce-TX-FIF...
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: x86_64-randconfig-a011-20210617 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 64720f57bea6a6bf033feef4a5751ab9c0c3b401)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://github.com/0day-ci/linux/commit/94892083cf17e46a29d4ef33a044af048...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Wesley-Cheng/Re-introduce-TX-FIFO-resize-for-larger-EP-bursting/20210617-180037
git checkout 94892083cf17e46a29d4ef33a044af04854162e6
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/usb/dwc3/gadget.c:671:18: warning: variable 'dep' set but not used [-Wunused-but-set-variable]
struct dwc3_ep *dep;
^
1 warning generated.
--
drivers/usb/dwc3/gadget.c:648: warning: Function parameter or member 'mult' not described in 'dwc3_gadget_calc_tx_fifo_size'
drivers/usb/dwc3/gadget.c:648: warning: Excess function parameter 'nfifos' description in 'dwc3_gadget_calc_tx_fifo_size'
>> drivers/usb/dwc3/gadget.c:670: warning: expecting prototype for dwc3_gadget_clear_tx_fifo_size(). Prototype was for dwc3_gadget_clear_tx_fifos() instead
vim +/dep +671 drivers/usb/dwc3/gadget.c
661
662 /**
663 * dwc3_gadget_clear_tx_fifo_size - Clears txfifo allocation
664 * @dwc: pointer to the DWC3 context
665 *
666 * Iterates through all the endpoint registers and clears the previous txfifo
667 * allocations.
668 */
669 void dwc3_gadget_clear_tx_fifos(struct dwc3 *dwc)
> 670 {
> 671 struct dwc3_ep *dep;
672 int fifo_depth;
673 int size;
674 int num;
675
676 if (!dwc->do_fifo_resize)
677 return;
678
679 /* Read ep0IN related TXFIFO size */
680 dep = dwc->eps[1];
681 size = dwc3_readl(dwc->regs, DWC3_GTXFIFOSIZ(0));
682 if (DWC3_IP_IS(DWC3))
683 fifo_depth = DWC3_GTXFIFOSIZ_TXFDEP(size);
684 else
685 fifo_depth = DWC31_GTXFIFOSIZ_TXFDEP(size);
686
687 dwc->last_fifo_depth = fifo_depth;
688 /* Clear existing TXFIFO for all IN eps except ep0 */
689 for (num = 3; num < min_t(int, dwc->num_eps, DWC3_ENDPOINTS_NUM);
690 num += 2) {
691 dep = dwc->eps[num];
692 /* Don't change TXFRAMNUM on usb31 version */
693 size = DWC3_IP_IS(DWC3) ? 0 :
694 dwc3_readl(dwc->regs, DWC3_GTXFIFOSIZ(num >> 1)) &
695 DWC31_GTXFIFOSIZ_TXFRAMNUM;
696
697 dwc3_writel(dwc->regs, DWC3_GTXFIFOSIZ(num >> 1), size);
698 }
699 dwc->num_ep_resized = 0;
700 }
701
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 3 months
[linux-next:master 8337/10875] ice_main.c:(.text.ice_do_ioctl+0x60): undefined reference to `ice_ptp_get_ts_config'
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 7d9c6b8147bdd76d7eb2cf6f74f84c6918ae0939
commit: 77a781155a659053f3b7e81a0ab115d27ff151cd [8337/10875] ice: enable receive hardware timestamping
config: powerpc64-randconfig-c004-20210617 (attached as .config)
compiler: powerpc-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commi...
git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git fetch --no-tags linux-next master
git checkout 77a781155a659053f3b7e81a0ab115d27ff151cd
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
powerpc-linux-ld: drivers/net/ethernet/intel/ice/ice_main.o: in function `ice_do_ioctl':
>> ice_main.c:(.text.ice_do_ioctl+0x60): undefined reference to `ice_ptp_get_ts_config'
>> powerpc-linux-ld: ice_main.c:(.text.ice_do_ioctl+0x9c): undefined reference to `ice_ptp_set_ts_config'
powerpc-linux-ld: drivers/net/ethernet/intel/ice/ice_main.o: in function `ice_rebuild':
ice_main.c:(.text.ice_rebuild+0x424): undefined reference to `ice_ptp_init'
powerpc-linux-ld: drivers/net/ethernet/intel/ice/ice_main.o: in function `ice_prepare_for_reset':
ice_main.c:(.text.ice_prepare_for_reset+0x1e8): undefined reference to `ice_ptp_release'
powerpc-linux-ld: drivers/net/ethernet/intel/ice/ice_main.o: in function `ice_remove':
ice_main.c:(.text.ice_remove+0x338): undefined reference to `ice_ptp_release'
powerpc-linux-ld: drivers/net/ethernet/intel/ice/ice_main.o: in function `ice_probe':
ice_main.c:(.text.ice_probe+0x13b8): undefined reference to `ice_ptp_init'
powerpc-linux-ld: drivers/net/ethernet/intel/ice/ice_txrx_lib.o: in function `ice_process_skb_fields':
>> ice_txrx_lib.c:(.text.ice_process_skb_fields+0x210): undefined reference to `ice_ptp_rx_hwtstamp'
powerpc-linux-ld: drivers/net/ethernet/intel/ice/ice_ethtool.o: in function `ice_get_ts_info':
ice_ethtool.c:(.text.ice_get_ts_info+0x4c): undefined reference to `ice_get_ptp_clock_index'
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 3 months
Re: [PATCH net-next v7 1/3] net: flow_dissector: extend bpf flow dissector support with vnet hdr
by kernel test robot
Hi Tanner,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url: https://github.com/0day-ci/linux/commits/Tanner-Love/virtio_net-add-optio...
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 0c33795231bff5df410bd405b569c66851e92d4b
config: s390-randconfig-s031-20210617 (attached as .config)
compiler: s390-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.3-341-g8af24329-dirty
# https://github.com/0day-ci/linux/commit/b03a1eb684b925a09ae011d0e620d98eb...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Tanner-Love/virtio_net-add-optional-flow-dissection-in-virtio_net_hdr_to_skb/20210617-082208
git checkout b03a1eb684b925a09ae011d0e620d98ebf3b0abd
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=s390
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
>> net/core/flow_dissector.c:882:40: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __virtio16 [assigned] [usertype] hdr_len @@ got unsigned short @@
net/core/flow_dissector.c:882:40: sparse: expected restricted __virtio16 [assigned] [usertype] hdr_len
net/core/flow_dissector.c:882:40: sparse: got unsigned short
>> net/core/flow_dissector.c:884:41: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __virtio16 [assigned] [usertype] gso_size @@ got unsigned short @@
net/core/flow_dissector.c:884:41: sparse: expected restricted __virtio16 [assigned] [usertype] gso_size
net/core/flow_dissector.c:884:41: sparse: got unsigned short
>> net/core/flow_dissector.c:886:43: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __virtio16 [assigned] [usertype] csum_start @@ got unsigned short @@
net/core/flow_dissector.c:886:43: sparse: expected restricted __virtio16 [assigned] [usertype] csum_start
net/core/flow_dissector.c:886:43: sparse: got unsigned short
>> net/core/flow_dissector.c:888:44: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __virtio16 [assigned] [usertype] csum_offset @@ got unsigned short @@
net/core/flow_dissector.c:888:44: sparse: expected restricted __virtio16 [assigned] [usertype] csum_offset
net/core/flow_dissector.c:888:44: sparse: got unsigned short
vim +882 net/core/flow_dissector.c
866
867 bool bpf_flow_dissect(struct bpf_prog *prog, struct bpf_flow_dissector *ctx,
868 __be16 proto, int nhoff, int hlen, unsigned int flags,
869 const struct virtio_net_hdr *vhdr,
870 bool vhdr_is_little_endian)
871 {
872 struct bpf_flow_keys *flow_keys = ctx->flow_keys;
873 u32 result;
874
875 /* vnet hdr is either machine endian (virtio spec < v1) or le (>= v1) */
876 #if defined(__BIG_ENDIAN_BITFIELD)
877 struct virtio_net_hdr vnet_hdr_local;
878
879 if (vhdr && vhdr_is_little_endian) {
880 vnet_hdr_local.flags = vhdr->flags;
881 vnet_hdr_local.gso_type = vhdr->gso_type;
> 882 vnet_hdr_local.hdr_len = __virtio16_to_cpu(false,
883 vhdr->hdr_len);
> 884 vnet_hdr_local.gso_size = __virtio16_to_cpu(false,
885 vhdr->gso_size);
> 886 vnet_hdr_local.csum_start = __virtio16_to_cpu(false,
887 vhdr->csum_start);
> 888 vnet_hdr_local.csum_offset = __virtio16_to_cpu(false,
889 vhdr->csum_offset);
890 vhdr = &vnet_hdr_local;
891 }
892 #endif
893
894 /* Pass parameters to the BPF program */
895 memset(flow_keys, 0, sizeof(*flow_keys));
896 flow_keys->n_proto = proto;
897 flow_keys->nhoff = nhoff;
898 flow_keys->thoff = flow_keys->nhoff;
899 flow_keys->vhdr = vhdr;
900
901 BUILD_BUG_ON((int)BPF_FLOW_DISSECTOR_F_PARSE_1ST_FRAG !=
902 (int)FLOW_DISSECTOR_F_PARSE_1ST_FRAG);
903 BUILD_BUG_ON((int)BPF_FLOW_DISSECTOR_F_STOP_AT_FLOW_LABEL !=
904 (int)FLOW_DISSECTOR_F_STOP_AT_FLOW_LABEL);
905 BUILD_BUG_ON((int)BPF_FLOW_DISSECTOR_F_STOP_AT_ENCAP !=
906 (int)FLOW_DISSECTOR_F_STOP_AT_ENCAP);
907 flow_keys->flags = flags;
908
909 result = bpf_prog_run_pin_on_cpu(prog, ctx);
910
911 flow_keys->nhoff = clamp_t(u16, flow_keys->nhoff, nhoff, hlen);
912 flow_keys->thoff = clamp_t(u16, flow_keys->thoff,
913 flow_keys->nhoff, hlen);
914
915 return result == BPF_OK;
916 }
917
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 3 months
[pm:bleeding-edge 125/147] arch/x86/power/cpu.c:77: warning: expecting prototype for __save_processor_statei(). Prototype was for __save_processor_state() instead
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git bleeding-edge
head: 55375ed5b1263df5a5fb64262ac50040ad097d92
commit: 6e777a2c216c7148be128e24b4def6dee1734dbd [125/147] x86/power: fix doc warnings in cpu.c
config: i386-randconfig-a004-20210617 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commi...
git remote add pm https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git
git fetch --no-tags pm bleeding-edge
git checkout 6e777a2c216c7148be128e24b4def6dee1734dbd
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> arch/x86/power/cpu.c:77: warning: expecting prototype for __save_processor_statei(). Prototype was for __save_processor_state() instead
vim +77 arch/x86/power/cpu.c
7a9c2dd08eadd5 arch/x86/power/cpu.c Chen Yu 2015-11-25 59
5c9c9bec0589be arch/x86/kernel/suspend_64.c Rafael J. Wysocki 2008-01-30 60 /**
6e777a2c216c71 arch/x86/power/cpu.c Baokun Li 2021-06-15 61 * __save_processor_statei() - Save CPU registers before creating a
6e777a2c216c71 arch/x86/power/cpu.c Baokun Li 2021-06-15 62 * hibernation image and before restoring
6e777a2c216c71 arch/x86/power/cpu.c Baokun Li 2021-06-15 63 * the memory state from it
6e777a2c216c71 arch/x86/power/cpu.c Baokun Li 2021-06-15 64 * @ctxt: Structure to store the registers contents in.
5c9c9bec0589be arch/x86/kernel/suspend_64.c Rafael J. Wysocki 2008-01-30 65 *
5c9c9bec0589be arch/x86/kernel/suspend_64.c Rafael J. Wysocki 2008-01-30 66 * NOTE: If there is a CPU register the modification of which by the
5c9c9bec0589be arch/x86/kernel/suspend_64.c Rafael J. Wysocki 2008-01-30 67 * boot kernel (ie. the kernel used for loading the hibernation image)
5c9c9bec0589be arch/x86/kernel/suspend_64.c Rafael J. Wysocki 2008-01-30 68 * might affect the operations of the restored target kernel (ie. the one
5c9c9bec0589be arch/x86/kernel/suspend_64.c Rafael J. Wysocki 2008-01-30 69 * saved in the hibernation image), then its contents must be saved by this
5c9c9bec0589be arch/x86/kernel/suspend_64.c Rafael J. Wysocki 2008-01-30 70 * function. In other words, if kernel A is hibernated and different
5c9c9bec0589be arch/x86/kernel/suspend_64.c Rafael J. Wysocki 2008-01-30 71 * kernel B is used for loading the hibernation image into memory, the
5c9c9bec0589be arch/x86/kernel/suspend_64.c Rafael J. Wysocki 2008-01-30 72 * kernel A's __save_processor_state() function must save all registers
5c9c9bec0589be arch/x86/kernel/suspend_64.c Rafael J. Wysocki 2008-01-30 73 * needed by kernel A, so that it can operate correctly after the resume
5c9c9bec0589be arch/x86/kernel/suspend_64.c Rafael J. Wysocki 2008-01-30 74 * regardless of what kernel B does in the meantime.
5c9c9bec0589be arch/x86/kernel/suspend_64.c Rafael J. Wysocki 2008-01-30 75 */
cae4595764cb3b arch/x86/kernel/suspend_64.c Jan Beulich 2008-01-30 76 static void __save_processor_state(struct saved_context *ctxt)
^1da177e4c3f41 arch/x86_64/kernel/suspend.c Linus Torvalds 2005-04-16 @77 {
f9ebbe53e79c59 arch/x86/power/cpu_64.c Sergio Luis 2009-04-28 78 #ifdef CONFIG_X86_32
f9ebbe53e79c59 arch/x86/power/cpu_64.c Sergio Luis 2009-04-28 79 mtrr_save_fixed_ranges(NULL);
f9ebbe53e79c59 arch/x86/power/cpu_64.c Sergio Luis 2009-04-28 80 #endif
^1da177e4c3f41 arch/x86_64/kernel/suspend.c Linus Torvalds 2005-04-16 81 kernel_fpu_begin();
^1da177e4c3f41 arch/x86_64/kernel/suspend.c Linus Torvalds 2005-04-16 82
^1da177e4c3f41 arch/x86_64/kernel/suspend.c Linus Torvalds 2005-04-16 83 /*
^1da177e4c3f41 arch/x86_64/kernel/suspend.c Linus Torvalds 2005-04-16 84 * descriptor tables
^1da177e4c3f41 arch/x86_64/kernel/suspend.c Linus Torvalds 2005-04-16 85 */
f9ebbe53e79c59 arch/x86/power/cpu_64.c Sergio Luis 2009-04-28 86 store_idt(&ctxt->idt);
090edbe23ff579 arch/x86/power/cpu.c Andy Lutomirski 2017-12-14 87
cc456c4e7cac38 arch/x86/power/cpu.c Konrad Rzeszutek Wilk 2013-05-01 88 /*
cc456c4e7cac38 arch/x86/power/cpu.c Konrad Rzeszutek Wilk 2013-05-01 89 * We save it here, but restore it only in the hibernate case.
cc456c4e7cac38 arch/x86/power/cpu.c Konrad Rzeszutek Wilk 2013-05-01 90 * For ACPI S3 resume, this is loaded via 'early_gdt_desc' in 64-bit
cc456c4e7cac38 arch/x86/power/cpu.c Konrad Rzeszutek Wilk 2013-05-01 91 * mode in "secondary_startup_64". In 32-bit mode it is done via
cc456c4e7cac38 arch/x86/power/cpu.c Konrad Rzeszutek Wilk 2013-05-01 92 * 'pmode_gdt' in wakeup_start.
cc456c4e7cac38 arch/x86/power/cpu.c Konrad Rzeszutek Wilk 2013-05-01 93 */
cc456c4e7cac38 arch/x86/power/cpu.c Konrad Rzeszutek Wilk 2013-05-01 94 ctxt->gdt_desc.size = GDT_SIZE - 1;
69218e47994da6 arch/x86/power/cpu.c Thomas Garnier 2017-03-14 95 ctxt->gdt_desc.address = (unsigned long)get_cpu_gdt_rw(smp_processor_id());
cc456c4e7cac38 arch/x86/power/cpu.c Konrad Rzeszutek Wilk 2013-05-01 96
9d1c6e7c86ddc3 arch/x86/kernel/suspend_64.c Glauber de Oliveira Costa 2007-10-19 97 store_tr(ctxt->tr);
^1da177e4c3f41 arch/x86_64/kernel/suspend.c Linus Torvalds 2005-04-16 98
^1da177e4c3f41 arch/x86_64/kernel/suspend.c Linus Torvalds 2005-04-16 99 /* XMM0..XMM15 should be handled by kernel_fpu_begin(). */
^1da177e4c3f41 arch/x86_64/kernel/suspend.c Linus Torvalds 2005-04-16 100 /*
^1da177e4c3f41 arch/x86_64/kernel/suspend.c Linus Torvalds 2005-04-16 101 * segment registers
^1da177e4c3f41 arch/x86_64/kernel/suspend.c Linus Torvalds 2005-04-16 102 */
f9ebbe53e79c59 arch/x86/power/cpu_64.c Sergio Luis 2009-04-28 103 savesegment(gs, ctxt->gs);
7ee18d677989e9 arch/x86/power/cpu.c Andy Lutomirski 2017-12-14 104 #ifdef CONFIG_X86_64
7ee18d677989e9 arch/x86/power/cpu.c Andy Lutomirski 2017-12-14 105 savesegment(fs, ctxt->fs);
7ee18d677989e9 arch/x86/power/cpu.c Andy Lutomirski 2017-12-14 106 savesegment(ds, ctxt->ds);
7ee18d677989e9 arch/x86/power/cpu.c Andy Lutomirski 2017-12-14 107 savesegment(es, ctxt->es);
^1da177e4c3f41 arch/x86_64/kernel/suspend.c Linus Torvalds 2005-04-16 108
^1da177e4c3f41 arch/x86_64/kernel/suspend.c Linus Torvalds 2005-04-16 109 rdmsrl(MSR_FS_BASE, ctxt->fs_base);
7ee18d677989e9 arch/x86/power/cpu.c Andy Lutomirski 2017-12-14 110 rdmsrl(MSR_GS_BASE, ctxt->kernelmode_gs_base);
7ee18d677989e9 arch/x86/power/cpu.c Andy Lutomirski 2017-12-14 111 rdmsrl(MSR_KERNEL_GS_BASE, ctxt->usermode_gs_base);
3ebad590560947 arch/x86_64/kernel/suspend.c Bernhard Kaindl 2007-05-02 112 mtrr_save_fixed_ranges(NULL);
^1da177e4c3f41 arch/x86_64/kernel/suspend.c Linus Torvalds 2005-04-16 113
f9ebbe53e79c59 arch/x86/power/cpu_64.c Sergio Luis 2009-04-28 114 rdmsrl(MSR_EFER, ctxt->efer);
f9ebbe53e79c59 arch/x86/power/cpu_64.c Sergio Luis 2009-04-28 115 #endif
f9ebbe53e79c59 arch/x86/power/cpu_64.c Sergio Luis 2009-04-28 116
^1da177e4c3f41 arch/x86_64/kernel/suspend.c Linus Torvalds 2005-04-16 117 /*
^1da177e4c3f41 arch/x86_64/kernel/suspend.c Linus Torvalds 2005-04-16 118 * control registers
^1da177e4c3f41 arch/x86_64/kernel/suspend.c Linus Torvalds 2005-04-16 119 */
f51c94528a9bc7 arch/x86_64/kernel/suspend.c Glauber de Oliveira Costa 2007-07-22 120 ctxt->cr0 = read_cr0();
f51c94528a9bc7 arch/x86_64/kernel/suspend.c Glauber de Oliveira Costa 2007-07-22 121 ctxt->cr2 = read_cr2();
6c690ee1039b25 arch/x86/power/cpu.c Andy Lutomirski 2017-06-12 122 ctxt->cr3 = __read_cr3();
1ef55be16ed695 arch/x86/power/cpu.c Andy Lutomirski 2016-09-29 123 ctxt->cr4 = __read_cr4();
85a0e7539781da arch/x86/power/cpu.c Ondrej Zary 2010-06-08 124 ctxt->misc_enable_saved = !rdmsrl_safe(MSR_IA32_MISC_ENABLE,
85a0e7539781da arch/x86/power/cpu.c Ondrej Zary 2010-06-08 125 &ctxt->misc_enable);
7a9c2dd08eadd5 arch/x86/power/cpu.c Chen Yu 2015-11-25 126 msr_save_context(ctxt);
^1da177e4c3f41 arch/x86_64/kernel/suspend.c Linus Torvalds 2005-04-16 127 }
^1da177e4c3f41 arch/x86_64/kernel/suspend.c Linus Torvalds 2005-04-16 128
:::::: The code at line 77 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2
:::::: TO: Linus Torvalds <torvalds(a)ppc970.osdl.org>
:::::: CC: Linus Torvalds <torvalds(a)ppc970.osdl.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 3 months
[freescale-fslc:pr/373 15241/19429] arch/powerpc/platforms/85xx/qoriq_pm.c:102:6: error: no previous prototype for function 'qoriq_set_wakeup_source'
by kernel test robot
Hi Jason,
First bad commit (maybe != root cause):
tree: https://github.com/Freescale/linux-fslc pr/373
head: 5134d8a627a2d5df24640674e500a725652bcd0d
commit: 5bb09de3044acf91e6f8c712c026d5a4bc53b563 [15241/19429] MLK-24874-1: include: uapi: fmd: fix the UAPI_HEADER_TEST/install failure
config: powerpc64-randconfig-r013-20210617 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 64720f57bea6a6bf033feef4a5751ab9c0c3b401)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install powerpc64 cross compiling tool for clang build
# apt-get install binutils-powerpc64-linux-gnu
# https://github.com/Freescale/linux-fslc/commit/5bb09de3044acf91e6f8c712c0...
git remote add freescale-fslc https://github.com/Freescale/linux-fslc
git fetch --no-tags freescale-fslc pr/373
git checkout 5bb09de3044acf91e6f8c712c026d5a4bc53b563
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
^
arch/powerpc/include/asm/io.h:543:56: note: expanded from macro '__do_insw'
#define __do_insw(p, b, n) readsw((PCI_IO_ADDR)_IO_BASE+(p), (b), (n))
~~~~~~~~~~~~~~~~~~~~~^
In file included from arch/powerpc/platforms/85xx/qoriq_pm.c:37:
In file included from include/linux/suspend.h:5:
In file included from include/linux/swap.h:9:
In file included from include/linux/memcontrol.h:13:
In file included from include/linux/cgroup.h:26:
In file included from include/linux/kernel_stat.h:9:
In file included from include/linux/interrupt.h:11:
In file included from include/linux/hardirq.h:9:
In file included from arch/powerpc/include/asm/hardirq.h:6:
In file included from include/linux/irq.h:20:
In file included from include/linux/io.h:13:
In file included from arch/powerpc/include/asm/io.h:605:
arch/powerpc/include/asm/io-defs.h:47:1: error: performing pointer arithmetic on a null pointer has undefined behavior [-Werror,-Wnull-pointer-arithmetic]
DEF_PCI_AC_NORET(insl, (unsigned long p, void *b, unsigned long c),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/io.h:602:3: note: expanded from macro 'DEF_PCI_AC_NORET'
__do_##name al; \
^~~~~~~~~~~~~~
<scratch space>:66:1: note: expanded from here
__do_insl
^
arch/powerpc/include/asm/io.h:544:56: note: expanded from macro '__do_insl'
#define __do_insl(p, b, n) readsl((PCI_IO_ADDR)_IO_BASE+(p), (b), (n))
~~~~~~~~~~~~~~~~~~~~~^
In file included from arch/powerpc/platforms/85xx/qoriq_pm.c:37:
In file included from include/linux/suspend.h:5:
In file included from include/linux/swap.h:9:
In file included from include/linux/memcontrol.h:13:
In file included from include/linux/cgroup.h:26:
In file included from include/linux/kernel_stat.h:9:
In file included from include/linux/interrupt.h:11:
In file included from include/linux/hardirq.h:9:
In file included from arch/powerpc/include/asm/hardirq.h:6:
In file included from include/linux/irq.h:20:
In file included from include/linux/io.h:13:
In file included from arch/powerpc/include/asm/io.h:605:
arch/powerpc/include/asm/io-defs.h:49:1: error: performing pointer arithmetic on a null pointer has undefined behavior [-Werror,-Wnull-pointer-arithmetic]
DEF_PCI_AC_NORET(outsb, (unsigned long p, const void *b, unsigned long c),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/io.h:602:3: note: expanded from macro 'DEF_PCI_AC_NORET'
__do_##name al; \
^~~~~~~~~~~~~~
<scratch space>:68:1: note: expanded from here
__do_outsb
^
arch/powerpc/include/asm/io.h:545:58: note: expanded from macro '__do_outsb'
#define __do_outsb(p, b, n) writesb((PCI_IO_ADDR)_IO_BASE+(p),(b),(n))
~~~~~~~~~~~~~~~~~~~~~^
In file included from arch/powerpc/platforms/85xx/qoriq_pm.c:37:
In file included from include/linux/suspend.h:5:
In file included from include/linux/swap.h:9:
In file included from include/linux/memcontrol.h:13:
In file included from include/linux/cgroup.h:26:
In file included from include/linux/kernel_stat.h:9:
In file included from include/linux/interrupt.h:11:
In file included from include/linux/hardirq.h:9:
In file included from arch/powerpc/include/asm/hardirq.h:6:
In file included from include/linux/irq.h:20:
In file included from include/linux/io.h:13:
In file included from arch/powerpc/include/asm/io.h:605:
arch/powerpc/include/asm/io-defs.h:51:1: error: performing pointer arithmetic on a null pointer has undefined behavior [-Werror,-Wnull-pointer-arithmetic]
DEF_PCI_AC_NORET(outsw, (unsigned long p, const void *b, unsigned long c),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/io.h:602:3: note: expanded from macro 'DEF_PCI_AC_NORET'
__do_##name al; \
^~~~~~~~~~~~~~
<scratch space>:70:1: note: expanded from here
__do_outsw
^
arch/powerpc/include/asm/io.h:546:58: note: expanded from macro '__do_outsw'
#define __do_outsw(p, b, n) writesw((PCI_IO_ADDR)_IO_BASE+(p),(b),(n))
~~~~~~~~~~~~~~~~~~~~~^
In file included from arch/powerpc/platforms/85xx/qoriq_pm.c:37:
In file included from include/linux/suspend.h:5:
In file included from include/linux/swap.h:9:
In file included from include/linux/memcontrol.h:13:
In file included from include/linux/cgroup.h:26:
In file included from include/linux/kernel_stat.h:9:
In file included from include/linux/interrupt.h:11:
In file included from include/linux/hardirq.h:9:
In file included from arch/powerpc/include/asm/hardirq.h:6:
In file included from include/linux/irq.h:20:
In file included from include/linux/io.h:13:
In file included from arch/powerpc/include/asm/io.h:605:
arch/powerpc/include/asm/io-defs.h:53:1: error: performing pointer arithmetic on a null pointer has undefined behavior [-Werror,-Wnull-pointer-arithmetic]
DEF_PCI_AC_NORET(outsl, (unsigned long p, const void *b, unsigned long c),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/io.h:602:3: note: expanded from macro 'DEF_PCI_AC_NORET'
__do_##name al; \
^~~~~~~~~~~~~~
<scratch space>:72:1: note: expanded from here
__do_outsl
^
arch/powerpc/include/asm/io.h:547:58: note: expanded from macro '__do_outsl'
#define __do_outsl(p, b, n) writesl((PCI_IO_ADDR)_IO_BASE+(p),(b),(n))
~~~~~~~~~~~~~~~~~~~~~^
>> arch/powerpc/platforms/85xx/qoriq_pm.c:102:6: error: no previous prototype for function 'qoriq_set_wakeup_source' [-Werror,-Wmissing-prototypes]
void qoriq_set_wakeup_source(struct device *dev, void *enable)
^
arch/powerpc/platforms/85xx/qoriq_pm.c:102:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void qoriq_set_wakeup_source(struct device *dev, void *enable)
^
static
8 errors generated.
vim +/qoriq_set_wakeup_source +102 arch/powerpc/platforms/85xx/qoriq_pm.c
dc640f653a5d46 Ran Wang 2018-03-28 101
dc640f653a5d46 Ran Wang 2018-03-28 @102 void qoriq_set_wakeup_source(struct device *dev, void *enable)
dc640f653a5d46 Ran Wang 2018-03-28 103 {
dc640f653a5d46 Ran Wang 2018-03-28 104 if (!device_may_wakeup(dev))
dc640f653a5d46 Ran Wang 2018-03-28 105 return;
dc640f653a5d46 Ran Wang 2018-03-28 106
dc640f653a5d46 Ran Wang 2018-03-28 107 fsl_set_power_except(dev, *((int *)enable));
dc640f653a5d46 Ran Wang 2018-03-28 108 }
dc640f653a5d46 Ran Wang 2018-03-28 109
:::::: The code at line 102 was first introduced by commit
:::::: dc640f653a5d465ab03598388a1931894fa07ff7 powerpc/pm: add sleep and deep sleep on QorIQ SoCs
:::::: TO: Ran Wang <ran.wang_1(a)nxp.com>
:::::: CC: Dong Aisheng <aisheng.dong(a)nxp.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 3 months
[luto:sched/lazymm 9/10] arch/x86/lib/insn-eval.c:616:8: error: implicit declaration of function 'nmi_uaccess_ok'; did you mean 'nmi_uaccess_okay'?
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/luto/linux.git sched/lazymm
head: ecc3992c36cb88087df9c537e2326efb51c95e31
commit: 1211e1eda2ec9d4ed78a480d8a795dce3312f80c [9/10] x86/events, x86/insn-eval: Remove incorrect active_mm references
config: i386-randconfig-r016-20210617 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://git.kernel.org/pub/scm/linux/kernel/git/luto/linux.git/commit/?id...
git remote add luto https://git.kernel.org/pub/scm/linux/kernel/git/luto/linux.git
git fetch --no-tags luto sched/lazymm
git checkout 1211e1eda2ec9d4ed78a480d8a795dce3312f80c
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
arch/x86/lib/insn-eval.c: In function 'get_desc':
>> arch/x86/lib/insn-eval.c:616:8: error: implicit declaration of function 'nmi_uaccess_ok'; did you mean 'nmi_uaccess_okay'? [-Werror=implicit-function-declaration]
616 | if (!nmi_uaccess_ok())
| ^~~~~~~~~~~~~~
| nmi_uaccess_okay
cc1: some warnings being treated as errors
--
arch/x86/events/core.c: In function 'get_segment_base':
>> arch/x86/events/core.c:2780:8: error: implicit declaration of function 'nmi_uaccess_ok'; did you mean 'nmi_uaccess_okay'? [-Werror=implicit-function-declaration]
2780 | if (!nmi_uaccess_ok())
| ^~~~~~~~~~~~~~
| nmi_uaccess_okay
cc1: some warnings being treated as errors
vim +616 arch/x86/lib/insn-eval.c
584
585 /**
586 * get_desc() - Obtain contents of a segment descriptor
587 * @out: Segment descriptor contents on success
588 * @sel: Segment selector
589 *
590 * Given a segment selector, obtain a pointer to the segment descriptor.
591 * Both global and local descriptor tables are supported.
592 *
593 * Returns:
594 *
595 * True on success, false on failure.
596 *
597 * NULL on error.
598 */
599 static bool get_desc(struct desc_struct *out, unsigned short sel)
600 {
601 struct desc_ptr gdt_desc = {0, 0};
602 unsigned long desc_base;
603
604 #ifdef CONFIG_MODIFY_LDT_SYSCALL
605 if ((sel & SEGMENT_TI_MASK) == SEGMENT_LDT) {
606 bool success = false;
607 struct ldt_struct *ldt;
608
609 /* Bits [15:3] contain the index of the desired entry. */
610 sel >>= 3;
611
612 /*
613 * If we're not in a valid context with a real (not just lazy)
614 * user mm, then don't even try.
615 */
> 616 if (!nmi_uaccess_ok())
617 return false;
618
619 mutex_lock(¤t->mm->context.lock);
620 ldt = current->mm->context.ldt;
621 if (ldt && sel < ldt->nr_entries) {
622 *out = ldt->entries[sel];
623 success = true;
624 }
625
626 mutex_unlock(¤t->mm->context.lock);
627
628 return success;
629 }
630 #endif
631 native_store_gdt(&gdt_desc);
632
633 /*
634 * Segment descriptors have a size of 8 bytes. Thus, the index is
635 * multiplied by 8 to obtain the memory offset of the desired descriptor
636 * from the base of the GDT. As bits [15:3] of the segment selector
637 * contain the index, it can be regarded as multiplied by 8 already.
638 * All that remains is to clear bits [2:0].
639 */
640 desc_base = sel & ~(SEGMENT_RPL_MASK | SEGMENT_TI_MASK);
641
642 if (desc_base > gdt_desc.size)
643 return false;
644
645 *out = *(struct desc_struct *)(gdt_desc.address + desc_base);
646 return true;
647 }
648
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 3 months
[luto:sched/lazymm 2/10] arch/x86/mm/tlb.c:425:34: error: no member named 'membarrier_state' in 'struct mm_struct'
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/luto/linux.git sched/lazymm
head: ecc3992c36cb88087df9c537e2326efb51c95e31
commit: 9f81d011fbe6ff333c5a68e317d7ed7835db699d [2/10] x86/mm: Handle unlazying membarrier core sync in the arch code
config: x86_64-randconfig-r023-20210617 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 64720f57bea6a6bf033feef4a5751ab9c0c3b401)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/luto/linux.git/commit/?id...
git remote add luto https://git.kernel.org/pub/scm/linux/kernel/git/luto/linux.git
git fetch --no-tags luto sched/lazymm
git checkout 9f81d011fbe6ff333c5a68e317d7ed7835db699d
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> arch/x86/mm/tlb.c:425:34: error: no member named 'membarrier_state' in 'struct mm_struct'
if (unlikely(atomic_read(&next->membarrier_state) &
~~~~ ^
include/linux/compiler.h:48:41: note: expanded from macro 'unlikely'
# define unlikely(x) (__branch_check__(x, 0, __builtin_constant_p(x)))
^
include/linux/compiler.h:33:34: note: expanded from macro '__branch_check__'
______r = __builtin_expect(!!(x), expect); \
^
>> arch/x86/mm/tlb.c:426:8: error: use of undeclared identifier 'MEMBARRIER_STATE_PRIVATE_EXPEDITED_SYNC_CORE'
MEMBARRIER_STATE_PRIVATE_EXPEDITED_SYNC_CORE))
^
>> arch/x86/mm/tlb.c:425:34: error: no member named 'membarrier_state' in 'struct mm_struct'
if (unlikely(atomic_read(&next->membarrier_state) &
~~~~ ^
include/linux/compiler.h:48:68: note: expanded from macro 'unlikely'
# define unlikely(x) (__branch_check__(x, 0, __builtin_constant_p(x)))
^
include/linux/compiler.h:35:19: note: expanded from macro '__branch_check__'
expect, is_constant); \
^~~~~~~~~~~
>> arch/x86/mm/tlb.c:426:8: error: use of undeclared identifier 'MEMBARRIER_STATE_PRIVATE_EXPEDITED_SYNC_CORE'
MEMBARRIER_STATE_PRIVATE_EXPEDITED_SYNC_CORE))
^
4 errors generated.
vim +425 arch/x86/mm/tlb.c
422
423 static void sync_core_if_membarrier_enabled(struct mm_struct *next)
424 {
> 425 if (unlikely(atomic_read(&next->membarrier_state) &
> 426 MEMBARRIER_STATE_PRIVATE_EXPEDITED_SYNC_CORE))
427 sync_core_before_usermode();
428 }
429
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 3 months