Re: [PATCH bpf-next 1/3] net: bonding: Add XDP support to the bonding driver
by kernel test robot
Hi Jussi,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on bpf-next/master]
url: https://github.com/0day-ci/linux/commits/Jussi-Maki/XDP-bonding-support/2...
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: alpha-randconfig-r014-20210617 (attached as .config)
compiler: alpha-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/61fabab38aec5b8e0cdc33867e35ea974...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Jussi-Maki/XDP-bonding-support/20210617-053146
git checkout 61fabab38aec5b8e0cdc33867e35ea9740da84c8
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=alpha
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/net/bonding/bond_main.c:4926:1: warning: no previous prototype for 'bond_xdp_get_xmit_slave' [-Wmissing-prototypes]
4926 | bond_xdp_get_xmit_slave(struct net_device *bond_dev, struct xdp_buff *xdp)
| ^~~~~~~~~~~~~~~~~~~~~~~
vim +/bond_xdp_get_xmit_slave +4926 drivers/net/bonding/bond_main.c
4924
4925 struct net_device *
> 4926 bond_xdp_get_xmit_slave(struct net_device *bond_dev, struct xdp_buff *xdp)
4927 {
4928 struct bonding *bond = netdev_priv(bond_dev);
4929 struct slave *slave;
4930
4931 /* Caller needs to hold rcu_read_lock() */
4932
4933 switch (BOND_MODE(bond)) {
4934 case BOND_MODE_ROUNDROBIN:
4935 slave = bond_xdp_xmit_roundrobin_slave_get(bond, xdp);
4936 break;
4937
4938 case BOND_MODE_ACTIVEBACKUP:
4939 slave = bond_xmit_activebackup_slave_get(bond);
4940 break;
4941
4942 case BOND_MODE_8023AD:
4943 case BOND_MODE_XOR:
4944 slave = bond_xdp_xmit_3ad_xor_slave_get(bond, xdp);
4945 break;
4946
4947 default:
4948 /* Should never happen. Mode guarded by bond_xdp_check() */
4949 netdev_err(bond_dev, "Unknown bonding mode %d for xdp xmit\n", BOND_MODE(bond));
4950 WARN_ON_ONCE(1);
4951 return NULL;
4952 }
4953
4954 if (slave)
4955 return slave->dev;
4956
4957 return NULL;
4958 }
4959
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 3 months
Re: [PATCH v2] mt76: fix iv and CCMP header insertion
by kernel test robot
Hi Ryder,
I love your patch! Perhaps something to improve:
[auto build test WARNING on wireless-drivers-next/master]
[also build test WARNING on wireless-drivers/master v5.13-rc6 next-20210616]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Ryder-Lee/mt76-fix-iv-and-CCMP-h...
base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-ne... master
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/efe80b96022a46a670de9c1a21138f6ea...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Ryder-Lee/mt76-fix-iv-and-CCMP-header-insertion/20210617-103402
git checkout efe80b96022a46a670de9c1a21138f6ea7871b0a
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
drivers/net/wireless/mediatek/mt76/mt76x02_mac.c: In function 'mt76x02_mac_shared_key_setup':
>> drivers/net/wireless/mediatek/mt76/mt76x02_mac.c:66:13: warning: comparison between 'enum mt76x02_cipher_type' and 'enum mt76_cipher_type' [-Wenum-compare]
66 | if (cipher == MT_CIPHER_NONE && key)
| ^~
drivers/net/wireless/mediatek/mt76/mt76x02_mac.c: In function 'mt76x02_mac_wcid_set_key':
drivers/net/wireless/mediatek/mt76/mt76x02_mac.c:115:13: warning: comparison between 'enum mt76x02_cipher_type' and 'enum mt76_cipher_type' [-Wenum-compare]
115 | if (cipher == MT_CIPHER_NONE && key)
| ^~
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_PDC
Depends on SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && HAS_DMA
Selected by
- SND_ATMEL_SOC_SSC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC
- SND_ATMEL_SOC_SSC_PDC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && ATMEL_SSC
vim +66 drivers/net/wireless/mediatek/mt76/mt76x02_mac.c
047aed1c38cf4b Stanislaw Gruszka 2018-08-29 57
8d66af49a3db9a Lorenzo Bianconi 2018-10-07 58 int mt76x02_mac_shared_key_setup(struct mt76x02_dev *dev, u8 vif_idx,
8d66af49a3db9a Lorenzo Bianconi 2018-10-07 59 u8 key_idx, struct ieee80211_key_conf *key)
047aed1c38cf4b Stanislaw Gruszka 2018-08-29 60 {
047aed1c38cf4b Stanislaw Gruszka 2018-08-29 61 enum mt76x02_cipher_type cipher;
047aed1c38cf4b Stanislaw Gruszka 2018-08-29 62 u8 key_data[32];
047aed1c38cf4b Stanislaw Gruszka 2018-08-29 63 u32 val;
047aed1c38cf4b Stanislaw Gruszka 2018-08-29 64
047aed1c38cf4b Stanislaw Gruszka 2018-08-29 65 cipher = mt76x02_mac_get_key_info(key, key_data);
047aed1c38cf4b Stanislaw Gruszka 2018-08-29 @66 if (cipher == MT_CIPHER_NONE && key)
047aed1c38cf4b Stanislaw Gruszka 2018-08-29 67 return -EOPNOTSUPP;
047aed1c38cf4b Stanislaw Gruszka 2018-08-29 68
8d66af49a3db9a Lorenzo Bianconi 2018-10-07 69 val = mt76_rr(dev, MT_SKEY_MODE(vif_idx));
047aed1c38cf4b Stanislaw Gruszka 2018-08-29 70 val &= ~(MT_SKEY_MODE_MASK << MT_SKEY_MODE_SHIFT(vif_idx, key_idx));
047aed1c38cf4b Stanislaw Gruszka 2018-08-29 71 val |= cipher << MT_SKEY_MODE_SHIFT(vif_idx, key_idx);
8d66af49a3db9a Lorenzo Bianconi 2018-10-07 72 mt76_wr(dev, MT_SKEY_MODE(vif_idx), val);
047aed1c38cf4b Stanislaw Gruszka 2018-08-29 73
8d66af49a3db9a Lorenzo Bianconi 2018-10-07 74 mt76_wr_copy(dev, MT_SKEY(vif_idx, key_idx), key_data,
047aed1c38cf4b Stanislaw Gruszka 2018-08-29 75 sizeof(key_data));
047aed1c38cf4b Stanislaw Gruszka 2018-08-29 76
047aed1c38cf4b Stanislaw Gruszka 2018-08-29 77 return 0;
047aed1c38cf4b Stanislaw Gruszka 2018-08-29 78 }
047aed1c38cf4b Stanislaw Gruszka 2018-08-29 79 EXPORT_SYMBOL_GPL(mt76x02_mac_shared_key_setup);
46436b5ef9dd2b Stanislaw Gruszka 2018-08-29 80
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 3 months
Re: [PATCH 08/11] media: adv7842: better document EDID block size
by kernel test robot
Hi Mauro,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on next-20210616]
[cannot apply to v5.13-rc6]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Mauro-Carvalho-Chehab/Address-so...
base: git://linuxtv.org/media_tree.git master
config: arc-allyesconfig (attached as .config)
compiler: arceb-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/3bdf84a7467fed26b64ffe547f5989d73...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Mauro-Carvalho-Chehab/Address-some-smatch-warnings/20210617-091510
git checkout 3bdf84a7467fed26b64ffe547f5989d73060a30e
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
drivers/media/i2c/adv7842.c: In function 'edid_write_vga_segment':
>> drivers/media/i2c/adv7842.c:739:19: warning: comparison between pointer and integer
739 | for (i = 0; && i < blocks * EDID_BLOCK_SIZE; i += I2C_SMBUS_BLOCK_MAX) {
| ^
drivers/media/i2c/adv7842.c:739:2: error: label 'i' used but not defined
739 | for (i = 0; && i < blocks * EDID_BLOCK_SIZE; i += I2C_SMBUS_BLOCK_MAX) {
| ^~~
vim +739 drivers/media/i2c/adv7842.c
715
716 static int edid_write_vga_segment(struct v4l2_subdev *sd)
717 {
718 struct i2c_client *client = v4l2_get_subdevdata(sd);
719 struct adv7842_state *state = to_state(sd);
720 const u8 *edid = state->vga_edid.edid;
721 u32 blocks = state->vga_edid.blocks;
722 int err = 0;
723 int i;
724
725 v4l2_dbg(2, debug, sd, "%s: write EDID on VGA port\n", __func__);
726
727 if (!state->vga_edid.present)
728 return 0;
729
730 /* HPA disable on port A and B */
731 io_write_and_or(sd, 0x20, 0xcf, 0x00);
732
733 /* Disable I2C access to internal EDID ram from VGA DDC port */
734 rep_write_and_or(sd, 0x7f, 0x7f, 0x00);
735
736 /* edid segment pointer '1' for VGA port */
737 rep_write_and_or(sd, 0x77, 0xef, 0x10);
738
> 739 for (i = 0; && i < blocks * EDID_BLOCK_SIZE; i += I2C_SMBUS_BLOCK_MAX) {
740 err = i2c_smbus_write_i2c_block_data(state->i2c_edid, i,
741 I2C_SMBUS_BLOCK_MAX,
742 edid + i);
743 if (err)
744 return err;
745 }
746
747 /* Calculates the checksums and enables I2C access
748 * to internal EDID ram from VGA DDC port.
749 */
750 rep_write_and_or(sd, 0x7f, 0x7f, 0x80);
751
752 for (i = 0; i < 1000; i++) {
753 if (rep_read(sd, 0x79) & 0x20)
754 break;
755 mdelay(1);
756 }
757 if (i == 1000) {
758 v4l_err(client, "error enabling edid on VGA port\n");
759 return -EIO;
760 }
761
762 /* enable hotplug after 200 ms */
763 schedule_delayed_work(&state->delayed_work_enable_hotplug, HZ / 5);
764
765 return 0;
766 }
767
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 3 months
Re: [PATCH v2 2/2] drm/dp_mst: Avoid to mess up payload table by ports in stale topology
by kernel test robot
Hi Wayne,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on drm-exynos/exynos-drm-next next-20210616]
[cannot apply to drm-tip/drm-tip tegra-drm/drm/tegra/for-next linus/master drm/drm-next v5.13-rc6]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Wayne-Lin/Fix-observed-mst-probl...
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: nios2-randconfig-r026-20210617 (attached as .config)
compiler: nios2-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/a904fdf8679b7eb026e3919cd14678ba9...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Wayne-Lin/Fix-observed-mst-problems-with-StarTech-hub/20210617-053552
git checkout a904fdf8679b7eb026e3919cd14678ba9a06c8bc
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nios2
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
In file included from drivers/gpu/drm/drm_dp_mst_topology.c:45:
drivers/gpu/drm/drm_dp_mst_topology.c: In function 'drm_dp_update_payload_part1':
include/drm/drm_print.h:450:27: error: request for member 'dev' in something not a structure or union
450 | drm_dev_dbg((drm) ? (drm)->dev : NULL, DRM_UT_KMS, fmt, ##__VA_ARGS__)
| ^~
drivers/gpu/drm/drm_dp_mst_topology.c:3392:5: note: in expansion of macro 'drm_dbg_kms'
3392 | drm_dbg_kms("Virtual channel %d is not in current topology\n", i);
| ^~~~~~~~~~~
>> drivers/gpu/drm/drm_dp_mst_topology.c:3392:68: warning: passing argument 3 of 'drm_dev_dbg' makes pointer from integer without a cast [-Wint-conversion]
3392 | drm_dbg_kms("Virtual channel %d is not in current topology\n", i);
| ^
| |
| int
include/drm/drm_print.h:450:53: note: in definition of macro 'drm_dbg_kms'
450 | drm_dev_dbg((drm) ? (drm)->dev : NULL, DRM_UT_KMS, fmt, ##__VA_ARGS__)
| ^~~
include/drm/drm_print.h:338:16: note: expected 'const char *' but argument is of type 'int'
338 | const char *format, ...);
| ~~~~~~~~~~~~^~~~~~
drivers/gpu/drm/drm_dp_mst_topology.c:3407:53: error: macro "drm_dbg_kms" requires 3 arguments, but only 1 given
3407 | drm_dbg_kms("Fail:set payload to invalid sink");
| ^
In file included from drivers/gpu/drm/drm_dp_mst_topology.c:45:
include/drm/drm_print.h:449: note: macro "drm_dbg_kms" defined here
449 | #define drm_dbg_kms(drm, fmt, ...) \
|
drivers/gpu/drm/drm_dp_mst_topology.c:3407:7: error: 'drm_dbg_kms' undeclared (first use in this function)
3407 | drm_dbg_kms("Fail:set payload to invalid sink");
| ^~~~~~~~~~~
drivers/gpu/drm/drm_dp_mst_topology.c:3407:7: note: each undeclared identifier is reported only once for each function it appears in
vim +/drm_dev_dbg +3392 drivers/gpu/drm/drm_dp_mst_topology.c
3352
3353 /**
3354 * drm_dp_update_payload_part1() - Execute payload update part 1
3355 * @mgr: manager to use.
3356 *
3357 * This iterates over all proposed virtual channels, and tries to
3358 * allocate space in the link for them. For 0->slots transitions,
3359 * this step just writes the VCPI to the MST device. For slots->0
3360 * transitions, this writes the updated VCPIs and removes the
3361 * remote VC payloads.
3362 *
3363 * after calling this the driver should generate ACT and payload
3364 * packets.
3365 */
3366 int drm_dp_update_payload_part1(struct drm_dp_mst_topology_mgr *mgr)
3367 {
3368 struct drm_dp_payload req_payload;
3369 struct drm_dp_mst_port *port;
3370 int i, j;
3371 int cur_slots = 1;
3372 bool skip;
3373
3374 mutex_lock(&mgr->payload_lock);
3375 for (i = 0; i < mgr->max_payloads; i++) {
3376 struct drm_dp_vcpi *vcpi = mgr->proposed_vcpis[i];
3377 struct drm_dp_payload *payload = &mgr->payloads[i];
3378 bool put_port = false;
3379
3380 /* solve the current payloads - compare to the hw ones
3381 - update the hw view */
3382 req_payload.start_slot = cur_slots;
3383 if (vcpi) {
3384 port = container_of(vcpi, struct drm_dp_mst_port,
3385 vcpi);
3386
3387 mutex_lock(&mgr->lock);
3388 skip = !drm_dp_mst_port_downstream_of_branch(port, mgr->mst_primary);
3389 mutex_unlock(&mgr->lock);
3390
3391 if (skip) {
> 3392 drm_dbg_kms("Virtual channel %d is not in current topology\n", i);
3393 continue;
3394 }
3395 /* Validated ports don't matter if we're releasing
3396 * VCPI
3397 */
3398 if (vcpi->num_slots) {
3399 port = drm_dp_mst_topology_get_port_validated(
3400 mgr, port);
3401 if (!port) {
3402 if (vcpi->num_slots == payload->num_slots) {
3403 cur_slots += vcpi->num_slots;
3404 payload->start_slot = req_payload.start_slot;
3405 continue;
3406 } else {
3407 drm_dbg_kms("Fail:set payload to invalid sink");
3408 mutex_unlock(&mgr->payload_lock);
3409 return -EINVAL;
3410 }
3411 }
3412 put_port = true;
3413 }
3414
3415 req_payload.num_slots = vcpi->num_slots;
3416 req_payload.vcpi = vcpi->vcpi;
3417 } else {
3418 port = NULL;
3419 req_payload.num_slots = 0;
3420 }
3421
3422 payload->start_slot = req_payload.start_slot;
3423 /* work out what is required to happen with this payload */
3424 if (payload->num_slots != req_payload.num_slots) {
3425
3426 /* need to push an update for this payload */
3427 if (req_payload.num_slots) {
3428 drm_dp_create_payload_step1(mgr, vcpi->vcpi,
3429 &req_payload);
3430 payload->num_slots = req_payload.num_slots;
3431 payload->vcpi = req_payload.vcpi;
3432
3433 } else if (payload->num_slots) {
3434 payload->num_slots = 0;
3435 drm_dp_destroy_payload_step1(mgr, port,
3436 payload->vcpi,
3437 payload);
3438 req_payload.payload_state =
3439 payload->payload_state;
3440 payload->start_slot = 0;
3441 }
3442 payload->payload_state = req_payload.payload_state;
3443 }
3444 cur_slots += req_payload.num_slots;
3445
3446 if (put_port)
3447 drm_dp_mst_topology_put_port(port);
3448 }
3449
3450 for (i = 0; i < mgr->max_payloads; /* do nothing */) {
3451 if (mgr->payloads[i].payload_state != DP_PAYLOAD_DELETE_LOCAL) {
3452 i++;
3453 continue;
3454 }
3455
3456 drm_dbg_kms(mgr->dev, "removing payload %d\n", i);
3457 for (j = i; j < mgr->max_payloads - 1; j++) {
3458 mgr->payloads[j] = mgr->payloads[j + 1];
3459 mgr->proposed_vcpis[j] = mgr->proposed_vcpis[j + 1];
3460
3461 if (mgr->proposed_vcpis[j] &&
3462 mgr->proposed_vcpis[j]->num_slots) {
3463 set_bit(j + 1, &mgr->payload_mask);
3464 } else {
3465 clear_bit(j + 1, &mgr->payload_mask);
3466 }
3467 }
3468
3469 memset(&mgr->payloads[mgr->max_payloads - 1], 0,
3470 sizeof(struct drm_dp_payload));
3471 mgr->proposed_vcpis[mgr->max_payloads - 1] = NULL;
3472 clear_bit(mgr->max_payloads, &mgr->payload_mask);
3473 }
3474 mutex_unlock(&mgr->payload_lock);
3475
3476 return 0;
3477 }
3478 EXPORT_SYMBOL(drm_dp_update_payload_part1);
3479
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 3 months
[luto:x86/membarrier 4/8] kernel/sched/core.c:4226:51: error: macro "switch_mm" requires 3 arguments, but only 1 given
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/luto/linux.git x86/membarrier
head: df3b012fb56f54e581492d7ec053e36d4eacfabc
commit: 77bac12bb7899853f4a19463b7e7ab1a7652666e [4/8] membarrier: Make the post-switch-mm barrier explicit
config: alpha-randconfig-s031-20210617 (attached as .config)
compiler: alpha-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.3-341-g8af24329-dirty
# https://git.kernel.org/pub/scm/linux/kernel/git/luto/linux.git/commit/?id...
git remote add luto https://git.kernel.org/pub/scm/linux/kernel/git/luto/linux.git
git fetch --no-tags luto x86/membarrier
git checkout 77bac12bb7899853f4a19463b7e7ab1a7652666e
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=alpha
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
kernel/sched/core.c: In function 'ttwu_stat':
kernel/sched/core.c:2916:13: warning: variable 'rq' set but not used [-Wunused-but-set-variable]
2916 | struct rq *rq;
| ^~
kernel/sched/core.c: In function 'finish_task_switch':
kernel/sched/core.c:4225:5: error: 'If' undeclared (first use in this function)
4225 | * If an architecture needs to take a specific action for
| ^~
kernel/sched/core.c:4225:5: note: each undeclared identifier is reported only once for each function it appears in
kernel/sched/core.c:4225:7: error: expected ';' before 'an'
4225 | * If an architecture needs to take a specific action for
| ^~~
| ;
>> kernel/sched/core.c:4226:51: error: macro "switch_mm" requires 3 arguments, but only 1 given
4226 | * SYNC_CORE, it can do so in switch_mm_irqs_off().
| ^
In file included from include/linux/mmu_context.h:5,
from kernel/sched/sched.h:55,
from kernel/sched/core.c:13:
arch/alpha/include/asm/mmu_context.h:225: note: macro "switch_mm" defined here
225 | # define switch_mm(a,b,c) ev5_switch_mm((a),(b),(c))
|
kernel/sched/core.c:4174:20: warning: unused variable 'mm' [-Wunused-variable]
4174 | struct mm_struct *mm = rq->prev_mm;
| ^~
vim +/switch_mm +4226 kernel/sched/core.c
4866cde064afbb kernel/sched.c Nicholas Piggin 2005-06-25 4150
^1da177e4c3f41 kernel/sched.c Linus Torvalds 2005-04-16 4151 /**
^1da177e4c3f41 kernel/sched.c Linus Torvalds 2005-04-16 4152 * finish_task_switch - clean up after a task-switch
^1da177e4c3f41 kernel/sched.c Linus Torvalds 2005-04-16 4153 * @prev: the thread we just switched away from.
^1da177e4c3f41 kernel/sched.c Linus Torvalds 2005-04-16 4154 *
4866cde064afbb kernel/sched.c Nicholas Piggin 2005-06-25 4155 * finish_task_switch must be called after the context switch, paired
4866cde064afbb kernel/sched.c Nicholas Piggin 2005-06-25 4156 * with a prepare_task_switch call before the context switch.
4866cde064afbb kernel/sched.c Nicholas Piggin 2005-06-25 4157 * finish_task_switch will reconcile locking set up by prepare_task_switch,
4866cde064afbb kernel/sched.c Nicholas Piggin 2005-06-25 4158 * and do any other architecture-specific cleanup actions.
^1da177e4c3f41 kernel/sched.c Linus Torvalds 2005-04-16 4159 *
^1da177e4c3f41 kernel/sched.c Linus Torvalds 2005-04-16 4160 * Note that we may have delayed dropping an mm in context_switch(). If
^1da177e4c3f41 kernel/sched.c Linus Torvalds 2005-04-16 4161 * so, we finish that here outside of the runqueue lock. (Doing it
^1da177e4c3f41 kernel/sched.c Linus Torvalds 2005-04-16 4162 * with the lock held can cause deadlocks; see schedule() for
^1da177e4c3f41 kernel/sched.c Linus Torvalds 2005-04-16 4163 * details.)
dfa50b605c2a93 kernel/sched/core.c Oleg Nesterov 2014-10-09 4164 *
dfa50b605c2a93 kernel/sched/core.c Oleg Nesterov 2014-10-09 4165 * The context switch have flipped the stack from under us and restored the
dfa50b605c2a93 kernel/sched/core.c Oleg Nesterov 2014-10-09 4166 * local variables which were saved when this task called schedule() in the
dfa50b605c2a93 kernel/sched/core.c Oleg Nesterov 2014-10-09 4167 * past. prev == current is still correct but we need to recalculate this_rq
dfa50b605c2a93 kernel/sched/core.c Oleg Nesterov 2014-10-09 4168 * because prev may have moved to another CPU.
^1da177e4c3f41 kernel/sched.c Linus Torvalds 2005-04-16 4169 */
dfa50b605c2a93 kernel/sched/core.c Oleg Nesterov 2014-10-09 4170 static struct rq *finish_task_switch(struct task_struct *prev)
^1da177e4c3f41 kernel/sched.c Linus Torvalds 2005-04-16 4171 __releases(rq->lock)
^1da177e4c3f41 kernel/sched.c Linus Torvalds 2005-04-16 4172 {
dfa50b605c2a93 kernel/sched/core.c Oleg Nesterov 2014-10-09 4173 struct rq *rq = this_rq();
^1da177e4c3f41 kernel/sched.c Linus Torvalds 2005-04-16 4174 struct mm_struct *mm = rq->prev_mm;
55a101f8f71a3d kernel/sched.c Oleg Nesterov 2006-09-29 4175 long prev_state;
^1da177e4c3f41 kernel/sched.c Linus Torvalds 2005-04-16 4176
609ca066386b2e kernel/sched/core.c Peter Zijlstra 2015-09-28 4177 /*
609ca066386b2e kernel/sched/core.c Peter Zijlstra 2015-09-28 4178 * The previous task will have left us with a preempt_count of 2
609ca066386b2e kernel/sched/core.c Peter Zijlstra 2015-09-28 4179 * because it left us after:
609ca066386b2e kernel/sched/core.c Peter Zijlstra 2015-09-28 4180 *
609ca066386b2e kernel/sched/core.c Peter Zijlstra 2015-09-28 4181 * schedule()
609ca066386b2e kernel/sched/core.c Peter Zijlstra 2015-09-28 4182 * preempt_disable(); // 1
609ca066386b2e kernel/sched/core.c Peter Zijlstra 2015-09-28 4183 * __schedule()
609ca066386b2e kernel/sched/core.c Peter Zijlstra 2015-09-28 4184 * raw_spin_lock_irq(&rq->lock) // 2
609ca066386b2e kernel/sched/core.c Peter Zijlstra 2015-09-28 4185 *
609ca066386b2e kernel/sched/core.c Peter Zijlstra 2015-09-28 4186 * Also, see FORK_PREEMPT_COUNT.
609ca066386b2e kernel/sched/core.c Peter Zijlstra 2015-09-28 4187 */
e2bf1c4b17aff2 kernel/sched/core.c Peter Zijlstra 2015-09-29 4188 if (WARN_ONCE(preempt_count() != 2*PREEMPT_DISABLE_OFFSET,
e2bf1c4b17aff2 kernel/sched/core.c Peter Zijlstra 2015-09-29 4189 "corrupted preempt_count: %s/%d/0x%x\n",
e2bf1c4b17aff2 kernel/sched/core.c Peter Zijlstra 2015-09-29 4190 current->comm, current->pid, preempt_count()))
e2bf1c4b17aff2 kernel/sched/core.c Peter Zijlstra 2015-09-29 4191 preempt_count_set(FORK_PREEMPT_COUNT);
609ca066386b2e kernel/sched/core.c Peter Zijlstra 2015-09-28 4192
^1da177e4c3f41 kernel/sched.c Linus Torvalds 2005-04-16 4193 rq->prev_mm = NULL;
^1da177e4c3f41 kernel/sched.c Linus Torvalds 2005-04-16 4194
^1da177e4c3f41 kernel/sched.c Linus Torvalds 2005-04-16 4195 /*
^1da177e4c3f41 kernel/sched.c Linus Torvalds 2005-04-16 4196 * A task struct has one reference for the use as "current".
c394cc9fbb367f kernel/sched.c Oleg Nesterov 2006-09-29 4197 * If a task dies, then it sets TASK_DEAD in tsk->state and calls
55a101f8f71a3d kernel/sched.c Oleg Nesterov 2006-09-29 4198 * schedule one last time. The schedule call will never return, and
55a101f8f71a3d kernel/sched.c Oleg Nesterov 2006-09-29 4199 * the scheduled task must drop that reference.
95913d97914f44 kernel/sched/core.c Peter Zijlstra 2015-09-29 4200 *
95913d97914f44 kernel/sched/core.c Peter Zijlstra 2015-09-29 4201 * We must observe prev->state before clearing prev->on_cpu (in
31cb1bc0dc9488 kernel/sched/core.c rodrigosiqueira 2017-12-15 4202 * finish_task), otherwise a concurrent wakeup can get prev
95913d97914f44 kernel/sched/core.c Peter Zijlstra 2015-09-29 4203 * running on another CPU and we could rave with its RUNNING -> DEAD
95913d97914f44 kernel/sched/core.c Peter Zijlstra 2015-09-29 4204 * transition, resulting in a double drop.
^1da177e4c3f41 kernel/sched.c Linus Torvalds 2005-04-16 4205 */
55a101f8f71a3d kernel/sched.c Oleg Nesterov 2006-09-29 4206 prev_state = prev->state;
bf9fae9f5e4ca8 kernel/sched/core.c Frederic Weisbecker 2012-09-08 4207 vtime_task_switch(prev);
a8d757ef076f0f kernel/sched.c Stephane Eranian 2011-08-25 4208 perf_event_task_sched_in(prev, current);
31cb1bc0dc9488 kernel/sched/core.c rodrigosiqueira 2017-12-15 4209 finish_task(prev);
31cb1bc0dc9488 kernel/sched/core.c rodrigosiqueira 2017-12-15 4210 finish_lock_switch(rq);
01f23e1630d944 kernel/sched/core.c Catalin Marinas 2011-11-27 4211 finish_arch_post_lock_switch();
0ed557aa813922 kernel/sched/core.c Mark Rutland 2018-06-14 4212 kcov_finish_switch(current);
5fbda3ecd14a53 kernel/sched/core.c Thomas Gleixner 2020-11-18 4213 /*
5fbda3ecd14a53 kernel/sched/core.c Thomas Gleixner 2020-11-18 4214 * kmap_local_sched_out() is invoked with rq::lock held and
5fbda3ecd14a53 kernel/sched/core.c Thomas Gleixner 2020-11-18 4215 * interrupts disabled. There is no requirement for that, but the
5fbda3ecd14a53 kernel/sched/core.c Thomas Gleixner 2020-11-18 4216 * sched out code does not have an interrupt enabled section.
5fbda3ecd14a53 kernel/sched/core.c Thomas Gleixner 2020-11-18 4217 * Restoring the maps on sched in does not require interrupts being
5fbda3ecd14a53 kernel/sched/core.c Thomas Gleixner 2020-11-18 4218 * disabled either.
5fbda3ecd14a53 kernel/sched/core.c Thomas Gleixner 2020-11-18 4219 */
5fbda3ecd14a53 kernel/sched/core.c Thomas Gleixner 2020-11-18 4220 kmap_local_sched_in();
e8fa136262e112 kernel/sched.c Steven Rostedt 2008-01-25 4221
e107be36efb2a2 kernel/sched.c Avi Kivity 2007-07-26 4222 fire_sched_in_preempt_notifiers(current);
9f81d011fbe6ff kernel/sched/core.c Andy Lutomirski 2020-12-02 4223
70216e18e519a5 kernel/sched/core.c Mathieu Desnoyers 2018-01-29 4224 *
9f81d011fbe6ff kernel/sched/core.c Andy Lutomirski 2020-12-02 @4225 * If an architecture needs to take a specific action for
9f81d011fbe6ff kernel/sched/core.c Andy Lutomirski 2020-12-02 @4226 * SYNC_CORE, it can do so in switch_mm_irqs_off().
9f81d011fbe6ff kernel/sched/core.c Andy Lutomirski 2020-12-02 4227 if (mm)
^1da177e4c3f41 kernel/sched.c Linus Torvalds 2005-04-16 4228 mmdrop(mm);
9f81d011fbe6ff kernel/sched/core.c Andy Lutomirski 2020-12-02 4229
1cef1150ef40ec kernel/sched/core.c Peter Zijlstra 2018-06-07 4230 if (unlikely(prev_state == TASK_DEAD)) {
e6c390f2dfd04c kernel/sched/core.c Dario Faggioli 2013-11-07 4231 if (prev->sched_class->task_dead)
e6c390f2dfd04c kernel/sched/core.c Dario Faggioli 2013-11-07 4232 prev->sched_class->task_dead(prev);
e6c390f2dfd04c kernel/sched/core.c Dario Faggioli 2013-11-07 4233
c6fd91f0bdcd29 kernel/sched.c bibo mao 2006-03-26 4234 /*
c6fd91f0bdcd29 kernel/sched.c bibo mao 2006-03-26 4235 * Remove function-return probe instances associated with this
c6fd91f0bdcd29 kernel/sched.c bibo mao 2006-03-26 4236 * task and put them back on the free list.
c6fd91f0bdcd29 kernel/sched.c bibo mao 2006-03-26 4237 */
c6fd91f0bdcd29 kernel/sched.c bibo mao 2006-03-26 4238 kprobe_flush_task(prev);
68f24b08ee892d kernel/sched/core.c Andy Lutomirski 2016-09-15 4239
68f24b08ee892d kernel/sched/core.c Andy Lutomirski 2016-09-15 4240 /* Task is done with its stack. */
68f24b08ee892d kernel/sched/core.c Andy Lutomirski 2016-09-15 4241 put_task_stack(prev);
68f24b08ee892d kernel/sched/core.c Andy Lutomirski 2016-09-15 4242
0ff7b2cfbae36e kernel/sched/core.c Eric W. Biederman 2019-09-14 4243 put_task_struct_rcu_user(prev);
^1da177e4c3f41 kernel/sched.c Linus Torvalds 2005-04-16 4244 }
99e5ada9407cc1 kernel/sched/core.c Frederic Weisbecker 2013-04-20 4245
de734f89b67c2d kernel/sched/core.c Frederic Weisbecker 2015-06-11 4246 tick_nohz_task_switch();
dfa50b605c2a93 kernel/sched/core.c Oleg Nesterov 2014-10-09 4247 return rq;
c6fd91f0bdcd29 kernel/sched.c bibo mao 2006-03-26 4248 }
^1da177e4c3f41 kernel/sched.c Linus Torvalds 2005-04-16 4249
:::::: The code at line 4226 was first introduced by commit
:::::: 9f81d011fbe6ff333c5a68e317d7ed7835db699d x86/mm: Handle unlazying membarrier core sync in the arch code
:::::: TO: Andy Lutomirski <luto(a)kernel.org>
:::::: CC: Andy Lutomirski <luto(a)kernel.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 3 months
Re: [PATCH bpf-next 1/3] net: bonding: Add XDP support to the bonding driver
by kernel test robot
Hi Jussi,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on bpf-next/master]
url: https://github.com/0day-ci/linux/commits/Jussi-Maki/XDP-bonding-support/2...
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: x86_64-randconfig-a011-20210617 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 64720f57bea6a6bf033feef4a5751ab9c0c3b401)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://github.com/0day-ci/linux/commit/61fabab38aec5b8e0cdc33867e35ea974...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Jussi-Maki/XDP-bonding-support/20210617-053146
git checkout 61fabab38aec5b8e0cdc33867e35ea9740da84c8
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/net/bonding/bond_main.c:4926:1: warning: no previous prototype for function 'bond_xdp_get_xmit_slave' [-Wmissing-prototypes]
bond_xdp_get_xmit_slave(struct net_device *bond_dev, struct xdp_buff *xdp)
^
drivers/net/bonding/bond_main.c:4925:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
struct net_device *
^
static
1 warning generated.
--
>> drivers/net/bonding/bond_main.c:3720: warning: expecting prototype for bond_xmit_hash_skb(). Prototype was for bond_xmit_hash() instead
vim +/bond_xdp_get_xmit_slave +4926 drivers/net/bonding/bond_main.c
4924
4925 struct net_device *
> 4926 bond_xdp_get_xmit_slave(struct net_device *bond_dev, struct xdp_buff *xdp)
4927 {
4928 struct bonding *bond = netdev_priv(bond_dev);
4929 struct slave *slave;
4930
4931 /* Caller needs to hold rcu_read_lock() */
4932
4933 switch (BOND_MODE(bond)) {
4934 case BOND_MODE_ROUNDROBIN:
4935 slave = bond_xdp_xmit_roundrobin_slave_get(bond, xdp);
4936 break;
4937
4938 case BOND_MODE_ACTIVEBACKUP:
4939 slave = bond_xmit_activebackup_slave_get(bond);
4940 break;
4941
4942 case BOND_MODE_8023AD:
4943 case BOND_MODE_XOR:
4944 slave = bond_xdp_xmit_3ad_xor_slave_get(bond, xdp);
4945 break;
4946
4947 default:
4948 /* Should never happen. Mode guarded by bond_xdp_check() */
4949 netdev_err(bond_dev, "Unknown bonding mode %d for xdp xmit\n", BOND_MODE(bond));
4950 WARN_ON_ONCE(1);
4951 return NULL;
4952 }
4953
4954 if (slave)
4955 return slave->dev;
4956
4957 return NULL;
4958 }
4959
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 3 months
[linux-next:master 8714/10489] arch/riscv/kernel/traps.c:210:26: warning: no previous prototype for function 'get_overflow_stack'
by kernel test robot
Hi Tong,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: c7d4c1fd91ab4a6d2620497921a9c6bf54650ab8
commit: 7b9dbbb41e1e6579d21fbec1d85ed04a392f73e9 [8714/10489] riscv: add VMAP_STACK overflow detection
config: riscv-randconfig-r021-20210617 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 64720f57bea6a6bf033feef4a5751ab9c0c3b401)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install riscv cross compiling tool for clang build
# apt-get install binutils-riscv64-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commi...
git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git fetch --no-tags linux-next master
git checkout 7b9dbbb41e1e6579d21fbec1d85ed04a392f73e9
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=riscv
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> arch/riscv/kernel/traps.c:210:26: warning: no previous prototype for function 'get_overflow_stack' [-Wmissing-prototypes]
asmlinkage unsigned long get_overflow_stack(void)
^
arch/riscv/kernel/traps.c:210:12: note: declare 'static' if the function is not intended to be used outside of this translation unit
asmlinkage unsigned long get_overflow_stack(void)
^
static
>> arch/riscv/kernel/traps.c:216:17: warning: no previous prototype for function 'handle_bad_stack' [-Wmissing-prototypes]
asmlinkage void handle_bad_stack(struct pt_regs *regs)
^
arch/riscv/kernel/traps.c:216:12: note: declare 'static' if the function is not intended to be used outside of this translation unit
asmlinkage void handle_bad_stack(struct pt_regs *regs)
^
static
2 warnings generated.
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for LOCKDEP
Depends on DEBUG_KERNEL && LOCK_DEBUGGING_SUPPORT && (FRAME_POINTER || MIPS || PPC || S390 || MICROBLAZE || ARM || ARC || X86)
Selected by
- DEBUG_LOCK_ALLOC && DEBUG_KERNEL && LOCK_DEBUGGING_SUPPORT
vim +/get_overflow_stack +210 arch/riscv/kernel/traps.c
201
202 #ifdef CONFIG_VMAP_STACK
203 DEFINE_PER_CPU(unsigned long [OVERFLOW_STACK_SIZE/sizeof(long)], overflow_stack)
204 __aligned(16);
205 /*
206 * shadow stack, handled_ kernel_ stack_ overflow(in kernel/entry.S) is used
207 * to get per-cpu overflow stack(get_overflow_stack).
208 */
209 long shadow_stack[SHADOW_OVERFLOW_STACK_SIZE/sizeof(long)];
> 210 asmlinkage unsigned long get_overflow_stack(void)
211 {
212 return (unsigned long)this_cpu_ptr(overflow_stack) +
213 OVERFLOW_STACK_SIZE;
214 }
215
> 216 asmlinkage void handle_bad_stack(struct pt_regs *regs)
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 3 months
[linux-next:master 4273/10489] drivers/firmware/arm_ffa/driver.c:123: warning: expecting prototype for FF(). Prototype was for FFA_PAGE_SIZE() instead
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: c7d4c1fd91ab4a6d2620497921a9c6bf54650ab8
commit: 3bbfe9871005f38df2955b2e125933edf1d2feef [4273/10489] firmware: arm_ffa: Add initial Arm FFA driver support
config: arm64-randconfig-r024-20210617 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 64720f57bea6a6bf033feef4a5751ab9c0c3b401)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commi...
git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git fetch --no-tags linux-next master
git checkout 3bbfe9871005f38df2955b2e125933edf1d2feef
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/firmware/arm_ffa/driver.c:123: warning: expecting prototype for FF(). Prototype was for FFA_PAGE_SIZE() instead
vim +123 drivers/firmware/arm_ffa/driver.c
110
111 #define SENDER_ID_MASK GENMASK(31, 16)
112 #define RECEIVER_ID_MASK GENMASK(15, 0)
113 #define SENDER_ID(x) ((u16)(FIELD_GET(SENDER_ID_MASK, (x))))
114 #define RECEIVER_ID(x) ((u16)(FIELD_GET(RECEIVER_ID_MASK, (x))))
115 #define PACK_TARGET_INFO(s, r) \
116 (FIELD_PREP(SENDER_ID_MASK, (s)) | FIELD_PREP(RECEIVER_ID_MASK, (r)))
117
118 /**
119 * FF-A specification mentions explicitly about '4K pages'. This should
120 * not be confused with the kernel PAGE_SIZE, which is the translation
121 * granule kernel is configured and may be one among 4K, 16K and 64K.
122 */
> 123 #define FFA_PAGE_SIZE SZ_4K
124 /*
125 * Keeping RX TX buffer size as 4K for now
126 * 64K may be preferred to keep it min a page in 64K PAGE_SIZE config
127 */
128 #define RXTX_BUFFER_SIZE SZ_4K
129
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 3 months
Re: [PATCH 3/3] pinctrl: renesas: Add pins/groups/functions for I2C, SCIF and USB supported by RZ/G2L SoC
by kernel test robot
Hi Lad,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on renesas-drivers/renesas-pinctrl]
[also build test WARNING on robh/for-next pinctrl/devel v5.13-rc6 next-20210616]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Lad-Prabhakar/pinctrl-Add-RZ-G2L...
base: https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git renesas-pinctrl
config: parisc-randconfig-s031-20210617 (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.3-341-g8af24329-dirty
# https://github.com/0day-ci/linux/commit/0cc4856c569c78a2855607272bccac66f...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Lad-Prabhakar/pinctrl-Add-RZ-G2L-pin-and-gpio-driver/20210616-225928
git checkout 0cc4856c569c78a2855607272bccac66fd3d8e9e
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=parisc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
drivers/pinctrl/renesas/pinctrl-rzg2l.c: In function 'rzg2l_pinctrl_set_mux':
drivers/pinctrl/renesas/pinctrl-rzg2l.c:115:9: error: implicit declaration of function 'pinmux_generic_get_function'; did you mean 'pinmux_generic_free_functions'? [-Werror=implicit-function-declaration]
115 | func = pinmux_generic_get_function(pctldev, func_selector);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
| pinmux_generic_free_functions
>> drivers/pinctrl/renesas/pinctrl-rzg2l.c:115:7: warning: assignment to 'struct function_desc *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
115 | func = pinmux_generic_get_function(pctldev, func_selector);
| ^
drivers/pinctrl/renesas/pinctrl-rzg2l.c:118:10: error: implicit declaration of function 'pinctrl_generic_get_group' [-Werror=implicit-function-declaration]
118 | group = pinctrl_generic_get_group(pctldev, group_selector);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/pinctrl/renesas/pinctrl-rzg2l.c:118:8: warning: assignment to 'struct group_desc *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
118 | group = pinctrl_generic_get_group(pctldev, group_selector);
| ^
drivers/pinctrl/renesas/pinctrl-rzg2l.c:122:14: error: dereferencing pointer to incomplete type 'struct group_desc'
122 | pins = group->pins;
| ^~
In file included from include/linux/printk.h:409,
from include/linux/kernel.h:17,
from include/linux/list.h:9,
from include/linux/kobject.h:19,
from include/linux/of.h:17,
from drivers/pinctrl/renesas/pinctrl-rzg2l.c:8:
drivers/pinctrl/renesas/pinctrl-rzg2l.c:126:7: error: dereferencing pointer to incomplete type 'struct function_desc'
126 | func->name, group->name);
| ^~
include/linux/dynamic_debug.h:129:15: note: in definition of macro '__dynamic_func_call'
129 | func(&id, ##__VA_ARGS__); \
| ^~~~~~~~~~~
include/linux/dynamic_debug.h:161:2: note: in expansion of macro '_dynamic_func_call'
161 | _dynamic_func_call(fmt,__dynamic_dev_dbg, \
| ^~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:123:2: note: in expansion of macro 'dynamic_dev_dbg'
123 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
drivers/pinctrl/renesas/pinctrl-rzg2l.c:125:2: note: in expansion of macro 'dev_dbg'
125 | dev_dbg(pctldev->dev, "enable function %s group %s\n",
| ^~~~~~~
drivers/pinctrl/renesas/pinctrl-rzg2l.c: At top level:
drivers/pinctrl/renesas/pinctrl-rzg2l.c:135:22: error: 'pinctrl_generic_get_group_count' undeclared here (not in a function)
135 | .get_groups_count = pinctrl_generic_get_group_count,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/pinctrl/renesas/pinctrl-rzg2l.c:136:20: error: 'pinctrl_generic_get_group_name' undeclared here (not in a function)
136 | .get_group_name = pinctrl_generic_get_group_name,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/pinctrl/renesas/pinctrl-rzg2l.c:137:20: error: 'pinctrl_generic_get_group_pins' undeclared here (not in a function); did you mean 'pinctrl_get_group_pins'?
137 | .get_group_pins = pinctrl_generic_get_group_pins,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| pinctrl_get_group_pins
drivers/pinctrl/renesas/pinctrl-rzg2l.c:143:25: error: 'pinmux_generic_get_function_count' undeclared here (not in a function); did you mean 'pinmux_generic_free_functions'?
143 | .get_functions_count = pinmux_generic_get_function_count,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| pinmux_generic_free_functions
drivers/pinctrl/renesas/pinctrl-rzg2l.c:144:23: error: 'pinmux_generic_get_function_name' undeclared here (not in a function); did you mean 'pinmux_generic_free_functions'?
144 | .get_function_name = pinmux_generic_get_function_name,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| pinmux_generic_free_functions
drivers/pinctrl/renesas/pinctrl-rzg2l.c:145:25: error: 'pinmux_generic_get_function_groups' undeclared here (not in a function); did you mean 'pinmux_generic_free_functions'?
145 | .get_function_groups = pinmux_generic_get_function_groups,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| pinmux_generic_free_functions
drivers/pinctrl/renesas/pinctrl-rzg2l.c: In function 'rzg2l_pinctrl_add_groups':
drivers/pinctrl/renesas/pinctrl-rzg2l.c:155:56: error: invalid use of undefined type 'struct group_desc'
155 | const struct group_desc *group = pctrl->psoc->groups + i;
| ^
drivers/pinctrl/renesas/pinctrl-rzg2l.c:157:9: error: implicit declaration of function 'pinctrl_generic_add_group' [-Werror=implicit-function-declaration]
157 | ret = pinctrl_generic_add_group(pctrl->pctrl_dev, group->name,
| ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/pinctrl/renesas/pinctrl-rzg2l.c:157:58: error: dereferencing pointer to incomplete type 'const struct group_desc'
157 | ret = pinctrl_generic_add_group(pctrl->pctrl_dev, group->name,
| ^~
drivers/pinctrl/renesas/pinctrl-rzg2l.c: In function 'rzg2l_pinctrl_add_functions':
drivers/pinctrl/renesas/pinctrl-rzg2l.c:175:57: error: invalid use of undefined type 'struct function_desc'
175 | const struct function_desc *func = pctrl->psoc->funcs + i;
| ^
drivers/pinctrl/renesas/pinctrl-rzg2l.c:177:9: error: implicit declaration of function 'pinmux_generic_add_function'; did you mean 'pinmux_generic_free_functions'? [-Werror=implicit-function-declaration]
177 | ret = pinmux_generic_add_function(pctrl->pctrl_dev, func->name,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
| pinmux_generic_free_functions
drivers/pinctrl/renesas/pinctrl-rzg2l.c:177:59: error: dereferencing pointer to incomplete type 'const struct function_desc'
177 | ret = pinmux_generic_add_function(pctrl->pctrl_dev, func->name,
| ^~
At top level:
drivers/pinctrl/renesas/pinctrl-rzg2l.c:514:34: warning: 'rzg2l_pinctrl_of_table' defined but not used [-Wunused-const-variable=]
514 | static const struct of_device_id rzg2l_pinctrl_of_table[] = {
| ^~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for PINCTRL_RZG2L
Depends on PINCTRL && OF && (ARCH_R9A07G044 || COMPILE_TEST
Selected by
- PINCTRL_PFC_R9A07G044 && PINCTRL
vim +115 drivers/pinctrl/renesas/pinctrl-rzg2l.c
64165286d371f1 Lad Prabhakar 2021-06-16 103
64165286d371f1 Lad Prabhakar 2021-06-16 104 static int rzg2l_pinctrl_set_mux(struct pinctrl_dev *pctldev,
64165286d371f1 Lad Prabhakar 2021-06-16 105 unsigned int func_selector,
64165286d371f1 Lad Prabhakar 2021-06-16 106 unsigned int group_selector)
64165286d371f1 Lad Prabhakar 2021-06-16 107 {
64165286d371f1 Lad Prabhakar 2021-06-16 108 struct rzg2l_pinctrl *pctrl = pinctrl_dev_get_drvdata(pctldev);
64165286d371f1 Lad Prabhakar 2021-06-16 109 struct function_desc *func;
64165286d371f1 Lad Prabhakar 2021-06-16 110 struct group_desc *group;
64165286d371f1 Lad Prabhakar 2021-06-16 111 unsigned long data;
64165286d371f1 Lad Prabhakar 2021-06-16 112 int *pins;
64165286d371f1 Lad Prabhakar 2021-06-16 113 int i;
64165286d371f1 Lad Prabhakar 2021-06-16 114
64165286d371f1 Lad Prabhakar 2021-06-16 @115 func = pinmux_generic_get_function(pctldev, func_selector);
64165286d371f1 Lad Prabhakar 2021-06-16 116 if (!func)
64165286d371f1 Lad Prabhakar 2021-06-16 117 return -EINVAL;
64165286d371f1 Lad Prabhakar 2021-06-16 @118 group = pinctrl_generic_get_group(pctldev, group_selector);
64165286d371f1 Lad Prabhakar 2021-06-16 119 if (!group)
64165286d371f1 Lad Prabhakar 2021-06-16 120 return -EINVAL;
64165286d371f1 Lad Prabhakar 2021-06-16 121
64165286d371f1 Lad Prabhakar 2021-06-16 122 pins = group->pins;
64165286d371f1 Lad Prabhakar 2021-06-16 123 data = (unsigned long)group->data;
64165286d371f1 Lad Prabhakar 2021-06-16 124
64165286d371f1 Lad Prabhakar 2021-06-16 125 dev_dbg(pctldev->dev, "enable function %s group %s\n",
64165286d371f1 Lad Prabhakar 2021-06-16 126 func->name, group->name);
64165286d371f1 Lad Prabhakar 2021-06-16 127
64165286d371f1 Lad Prabhakar 2021-06-16 128 for (i = 0; i < group->num_pins; i++)
64165286d371f1 Lad Prabhakar 2021-06-16 129 rzg2l_pinctrl_set_pfc_mode(pctrl, *(pins + i), data);
64165286d371f1 Lad Prabhakar 2021-06-16 130
64165286d371f1 Lad Prabhakar 2021-06-16 131 return 0;
64165286d371f1 Lad Prabhakar 2021-06-16 132 };
64165286d371f1 Lad Prabhakar 2021-06-16 133
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 3 months
Re: [PATCH net-next v5 05/15] virtio: support virtqueue_detach_unused_buf_ctx
by kernel test robot
Hi Xuan,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url: https://github.com/0day-ci/linux/commits/Xuan-Zhuo/virtio-net-support-xdp...
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git c7654495916e109f76a67fd3ae68f8fa70ab4faa
config: parisc-randconfig-r023-20210617 (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/6155fdb771fa9f6c96472440c6b846dbf...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Xuan-Zhuo/virtio-net-support-xdp-socket-zero-copy/20210617-033438
git checkout 6155fdb771fa9f6c96472440c6b846dbfc4aebde
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=parisc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
drivers/virtio/virtio_ring.c:1898: warning: expecting prototype for virtqueue_get_buf(). Prototype was for virtqueue_get_buf_ctx() instead
drivers/virtio/virtio_ring.c:2024: warning: Function parameter or member 'ctx' not described in 'virtqueue_detach_unused_buf_ctx'
>> drivers/virtio/virtio_ring.c:2024: warning: expecting prototype for virtqueue_detach_unused_buf(). Prototype was for virtqueue_detach_unused_buf_ctx() instead
vim +2024 drivers/virtio/virtio_ring.c
e6f633e5beab65 Tiwei Bie 2018-11-21 2014
138fd25148638a Tiwei Bie 2018-11-21 2015 /**
138fd25148638a Tiwei Bie 2018-11-21 2016 * virtqueue_detach_unused_buf - detach first unused buffer
a5581206c565a7 Jiang Biao 2019-04-23 2017 * @_vq: the struct virtqueue we're talking about.
138fd25148638a Tiwei Bie 2018-11-21 2018 *
138fd25148638a Tiwei Bie 2018-11-21 2019 * Returns NULL or the "data" token handed to virtqueue_add_*().
138fd25148638a Tiwei Bie 2018-11-21 2020 * This is not valid on an active queue; it is useful only for device
138fd25148638a Tiwei Bie 2018-11-21 2021 * shutdown.
138fd25148638a Tiwei Bie 2018-11-21 2022 */
6155fdb771fa9f Xuan Zhuo 2021-06-10 2023 void *virtqueue_detach_unused_buf_ctx(struct virtqueue *_vq, void **ctx)
138fd25148638a Tiwei Bie 2018-11-21 @2024 {
1ce9e6055fa0a9 Tiwei Bie 2018-11-21 2025 struct vring_virtqueue *vq = to_vvq(_vq);
1ce9e6055fa0a9 Tiwei Bie 2018-11-21 2026
6155fdb771fa9f Xuan Zhuo 2021-06-10 2027 return vq->packed_ring ?
6155fdb771fa9f Xuan Zhuo 2021-06-10 2028 virtqueue_detach_unused_buf_ctx_packed(_vq, ctx) :
6155fdb771fa9f Xuan Zhuo 2021-06-10 2029 virtqueue_detach_unused_buf_ctx_split(_vq, ctx);
6155fdb771fa9f Xuan Zhuo 2021-06-10 2030 }
6155fdb771fa9f Xuan Zhuo 2021-06-10 2031
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 3 months