Re: [PATCH v27 22/25] Audit: Add record for multiple process LSM attributes
by kernel test robot
Hi Casey,
I love your patch! Yet something to improve:
[auto build test ERROR on nf/master]
[also build test ERROR on linus/master v5.13-rc6]
[cannot apply to security/next-testing pcmoore-audit/next nf-next/master next-20210616]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Casey-Schaufler/LSM-Infrastructu...
base: https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git master
config: arc-allyesconfig (attached as .config)
compiler: arceb-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/d534cd725d8e262f150ea8c62bd452ae6...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Casey-Schaufler/LSM-Infrastructure-management-of-the-sock-security/20210616-133254
git checkout d534cd725d8e262f150ea8c62bd452ae6d42bb19
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from kernel/audit.c:51:
include/linux/audit.h:571:1: error: expected identifier or '(' before '+' token
571 | +static inline struct audit_context *audit_alloc_local(gfp_t gfpflags)
| ^
kernel/audit.c: In function 'audit_log_config_change':
>> kernel/audit.c:393:12: error: implicit declaration of function 'audit_alloc_for_lsm'; did you mean 'audit_alloc_mark'? [-Werror=implicit-function-declaration]
393 | context = audit_alloc_for_lsm(GFP_KERNEL);
| ^~~~~~~~~~~~~~~~~~~
| audit_alloc_mark
kernel/audit.c:393:10: warning: assignment to 'struct audit_context *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
393 | context = audit_alloc_for_lsm(GFP_KERNEL);
| ^
kernel/audit.c: In function 'audit_receive_msg':
kernel/audit.c:1358:13: warning: assignment to 'struct audit_context *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
1358 | lcontext = audit_alloc_for_lsm(GFP_KERNEL);
| ^
kernel/audit.c:1381:13: warning: assignment to 'struct audit_context *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
1381 | lcontext = audit_alloc_for_lsm(GFP_KERNEL);
| ^
kernel/audit.c:1399:12: warning: assignment to 'struct audit_context *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
1399 | lcontext = audit_alloc_for_lsm(GFP_KERNEL);
| ^
kernel/audit.c:1431:12: warning: assignment to 'struct audit_context *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
1431 | lcontext = audit_alloc_for_lsm(GFP_KERNEL);
| ^
kernel/audit.c:1505:12: warning: assignment to 'struct audit_context *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
1505 | lcontext = audit_alloc_for_lsm(GFP_KERNEL);
| ^
kernel/audit.c: In function 'audit_log_multicast':
kernel/audit.c:1567:10: warning: assignment to 'struct audit_context *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
1567 | context = audit_alloc_for_lsm(GFP_KERNEL);
| ^
kernel/audit.c: At top level:
kernel/audit.c:1789:14: warning: no previous prototype for 'audit_serial' [-Wmissing-prototypes]
1789 | unsigned int audit_serial(void)
| ^~~~~~~~~~~~
kernel/audit.c: In function 'audit_log_vformat':
kernel/audit.c:1937:2: warning: function 'audit_log_vformat' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
1937 | len = vsnprintf(skb_tail_pointer(skb), avail, fmt, args);
| ^~~
kernel/audit.c:1946:3: warning: function 'audit_log_vformat' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
1946 | len = vsnprintf(skb_tail_pointer(skb), avail, fmt, args2);
| ^~~
kernel/audit.c: In function 'audit_log_set_loginuid':
kernel/audit.c:2334:10: warning: assignment to 'struct audit_context *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
2334 | context = audit_alloc_for_lsm(GFP_KERNEL);
| ^
In file included from include/linux/perf_event.h:25,
from include/linux/trace_events.h:10,
from include/trace/syscall.h:7,
from include/linux/syscalls.h:87,
from kernel/audit.c:44:
At top level:
arch/arc/include/asm/perf_event.h:126:23: warning: 'arc_pmu_cache_map' defined but not used [-Wunused-const-variable=]
126 | static const unsigned arc_pmu_cache_map[C(MAX)][C(OP_MAX)][C(RESULT_MAX)] = {
| ^~~~~~~~~~~~~~~~~
arch/arc/include/asm/perf_event.h:91:27: warning: 'arc_pmu_ev_hw_map' defined but not used [-Wunused-const-variable=]
91 | static const char * const arc_pmu_ev_hw_map[] = {
| ^~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
--
In file included from kernel/auditfilter.c:12:
include/linux/audit.h:571:1: error: expected identifier or '(' before '+' token
571 | +static inline struct audit_context *audit_alloc_local(gfp_t gfpflags)
| ^
kernel/auditfilter.c: In function 'audit_log_rule_change':
>> kernel/auditfilter.c:1107:12: error: implicit declaration of function 'audit_alloc_for_lsm'; did you mean 'audit_alloc_mark'? [-Werror=implicit-function-declaration]
1107 | context = audit_alloc_for_lsm(GFP_KERNEL);
| ^~~~~~~~~~~~~~~~~~~
| audit_alloc_mark
kernel/auditfilter.c:1107:10: warning: assignment to 'struct audit_context *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
1107 | context = audit_alloc_for_lsm(GFP_KERNEL);
| ^
cc1: some warnings being treated as errors
--
In file included from security/integrity/integrity_audit.c:12:
include/linux/audit.h:571:1: error: expected identifier or '(' before '+' token
571 | +static inline struct audit_context *audit_alloc_local(gfp_t gfpflags)
| ^
security/integrity/integrity_audit.c: In function 'integrity_audit_message':
>> security/integrity/integrity_audit.c:48:12: error: implicit declaration of function 'audit_alloc_for_lsm'; did you mean 'audit_log_format'? [-Werror=implicit-function-declaration]
48 | context = audit_alloc_for_lsm(GFP_KERNEL);
| ^~~~~~~~~~~~~~~~~~~
| audit_log_format
security/integrity/integrity_audit.c:48:10: warning: assignment to 'struct audit_context *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
48 | context = audit_alloc_for_lsm(GFP_KERNEL);
| ^
cc1: some warnings being treated as errors
--
In file included from security/integrity/ima/ima.h:22,
from security/integrity/ima/ima_api.c:18:
include/linux/audit.h:571:1: error: expected identifier or '(' before '+' token
571 | +static inline struct audit_context *audit_alloc_local(gfp_t gfpflags)
| ^
security/integrity/ima/ima_api.c: In function 'ima_audit_measurement':
>> security/integrity/ima/ima_api.c:362:12: error: implicit declaration of function 'audit_alloc_for_lsm'; did you mean 'audit_log_format'? [-Werror=implicit-function-declaration]
362 | context = audit_alloc_for_lsm(GFP_KERNEL);
| ^~~~~~~~~~~~~~~~~~~
| audit_log_format
security/integrity/ima/ima_api.c:362:10: warning: assignment to 'struct audit_context *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
362 | context = audit_alloc_for_lsm(GFP_KERNEL);
| ^
cc1: some warnings being treated as errors
vim +393 kernel/audit.c
385
386 static int audit_log_config_change(char *function_name, u32 new, u32 old,
387 int allow_changes)
388 {
389 struct audit_context *context;
390 struct audit_buffer *ab;
391 int rc = 0;
392
> 393 context = audit_alloc_for_lsm(GFP_KERNEL);
394 ab = audit_log_start(context, GFP_KERNEL, AUDIT_CONFIG_CHANGE);
395 if (unlikely(!ab))
396 return rc;
397 audit_log_format(ab, "op=set %s=%u old=%u ", function_name, new, old);
398 audit_log_session_info(ab);
399 rc = audit_log_task_context(ab);
400 if (rc)
401 allow_changes = 0; /* Something weird, deny request */
402 audit_log_format(ab, " res=%d", allow_changes);
403 audit_log_end(ab);
404 audit_free_local(context);
405 return rc;
406 }
407
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 3 months
Re: [RFC v1 2/6] virtio/vsock: add support for virtio datagram
by kernel test robot
Hi Jiang,
[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on vhost/linux-next]
[also build test WARNING on tip/perf/core linus/master v5.13-rc6]
[cannot apply to next-20210616]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Jiang-Wang/virtio-vsock-introduc...
base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next
config: x86_64-randconfig-a002-20210616 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 64720f57bea6a6bf033feef4a5751ab9c0c3b401)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://github.com/0day-ci/linux/commit/b156a0ad587c43dbfc98397f01b34fad1...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Jiang-Wang/virtio-vsock-introduce-SOCK_DGRAM-support/20210616-120056
git checkout b156a0ad587c43dbfc98397f01b34fad15054bf0
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> net/vmw_vsock/virtio_transport.c:450:7: warning: variable 'added' set but not used [-Wunused-but-set-variable]
bool added = false;
^
1 warning generated.
vim +/added +450 net/vmw_vsock/virtio_transport.c
444
445 static void virtio_transport_dgram_tx_work(struct work_struct *work)
446 {
447 struct virtio_vsock *vsock =
448 container_of(work, struct virtio_vsock, dgram_tx_work);
449 struct virtqueue *vq;
> 450 bool added = false;
451
452 vq = vsock->vqs[VSOCK_VQ_DGRAM_TX];
453 mutex_lock(&vsock->dgram_tx_lock);
454
455 if (!vsock->dgram_tx_run)
456 goto out;
457
458 do {
459 struct virtio_vsock_pkt *pkt;
460 unsigned int len;
461
462 virtqueue_disable_cb(vq);
463 while ((pkt = virtqueue_get_buf(vq, &len)) != NULL) {
464 virtio_transport_free_pkt(pkt);
465 added = true;
466 }
467 } while (!virtqueue_enable_cb(vq));
468
469 out:
470 mutex_unlock(&vsock->dgram_tx_lock);
471 }
472
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 3 months
Re: [PATCH 4/7] dma-buf: add dma_fence_chain_garbage_collect
by kernel test robot
Hi "Christian,
I love your patch! Perhaps something to improve:
[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next linus/master v5.13-rc6 next-20210616]
[cannot apply to drm-tip/drm-tip drm/drm-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Christian-K-nig/dma-buf-some-dma...
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: alpha-randconfig-s031-20210615 (attached as .config)
compiler: alpha-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.3-341-g8af24329-dirty
# https://github.com/0day-ci/linux/commit/058b99a2929f84c7f2cb1516dcc8674bf...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Christian-K-nig/dma-buf-some-dma_fence_chain-improvements/20210616-182806
git checkout 058b99a2929f84c7f2cb1516dcc8674bf3f2a661
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=alpha
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
>> drivers/dma-buf/dma-fence-chain.c:28:15: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected struct dma_fence_chain **_x_ @@ got struct dma_fence_chain [noderef] __rcu ** @@
drivers/dma-buf/dma-fence-chain.c:28:15: sparse: expected struct dma_fence_chain **_x_
drivers/dma-buf/dma-fence-chain.c:28:15: sparse: got struct dma_fence_chain [noderef] __rcu **
>> drivers/dma-buf/dma-fence-chain.c:28:13: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct dma_fence_chain [noderef] __rcu **tmp @@ got struct dma_fence_chain **[assigned] __ret @@
drivers/dma-buf/dma-fence-chain.c:28:13: sparse: expected struct dma_fence_chain [noderef] __rcu **tmp
drivers/dma-buf/dma-fence-chain.c:28:13: sparse: got struct dma_fence_chain **[assigned] __ret
vim +28 drivers/dma-buf/dma-fence-chain.c
16
17 /**
18 * dma_fence_chain_enqueue - enqeue a chain node for garbage collection
19 * @chain: the chain node to enqueue
20 *
21 * Add the chain node to the end of the gc fifo.
22 */
23 static void dma_fence_chain_enqueue(struct dma_fence_chain *chain)
24 {
25 struct dma_fence_chain __rcu **tmp;
26
27 RCU_INIT_POINTER(chain->next, NULL);
> 28 tmp = xchg((struct dma_fence_chain __force ***)&fifo_back,
29 &chain->next);
30
31 /* This is intentionally unordered since we only need the fifo for gc */
32 rcu_assign_pointer(*tmp, chain);
33 }
34
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 3 months
Re: [PATCH net-next v6 1/3] net: flow_dissector: extend bpf flow dissector support with vnet hdr
by kernel test robot
Hi Tanner,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url: https://github.com/0day-ci/linux/commits/Tanner-Love/virtio_net-add-optio...
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git c7654495916e109f76a67fd3ae68f8fa70ab4faa
config: riscv-randconfig-r024-20210615 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 64720f57bea6a6bf033feef4a5751ab9c0c3b401)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install riscv cross compiling tool for clang build
# apt-get install binutils-riscv64-linux-gnu
# https://github.com/0day-ci/linux/commit/7d159f648961a7849f67e1c3d7ecb3d18...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Tanner-Love/virtio_net-add-optional-flow-dissection-in-virtio_net_hdr_to_skb/20210616-193224
git checkout 7d159f648961a7849f67e1c3d7ecb3d18bf5c7c2
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=riscv
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> net/core/filter.c:8334:5: warning: no previous prototype for function 'check_flow_keys_access' [-Wmissing-prototypes]
int check_flow_keys_access(int off, int size, enum bpf_access_type t,
^
net/core/filter.c:8334:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int check_flow_keys_access(int off, int size, enum bpf_access_type t,
^
static
1 warning generated.
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for LOCKDEP
Depends on DEBUG_KERNEL && LOCK_DEBUGGING_SUPPORT && (FRAME_POINTER || MIPS || PPC || S390 || MICROBLAZE || ARM || ARC || X86)
Selected by
- PROVE_LOCKING && DEBUG_KERNEL && LOCK_DEBUGGING_SUPPORT
- DEBUG_LOCK_ALLOC && DEBUG_KERNEL && LOCK_DEBUGGING_SUPPORT
vim +/check_flow_keys_access +8334 net/core/filter.c
8333
> 8334 int check_flow_keys_access(int off, int size, enum bpf_access_type t,
8335 struct bpf_insn_access_aux *info)
8336 {
8337 if (size < 0 || off < 0 ||
8338 (u64)off + size > sizeof(struct bpf_flow_keys))
8339 return -EACCES;
8340
8341 switch (off) {
8342 case bpf_ctx_range_ptr(struct bpf_flow_keys, vhdr):
8343 if (t == BPF_WRITE || off % size != 0 || size != sizeof(__u64))
8344 return -EACCES;
8345
8346 if (!bpf_flow_dissector_btf_ids[0])
8347 return -EINVAL;
8348
8349 info->btf_id = bpf_flow_dissector_btf_ids[0];
8350
8351 break;
8352 case offsetof(struct bpf_flow_keys, vhdr_is_little_endian):
8353 if (t == BPF_WRITE)
8354 return -EACCES;
8355
8356 break;
8357 }
8358
8359 return 0;
8360 }
8361
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 3 months
Re: [PATCH] cfg80211: expose the rfkill device to the low level driver
by kernel test robot
Hi Emmanuel,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on mac80211-next/master]
[also build test WARNING on mac80211/master v5.13-rc6 next-20210616]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Emmanuel-Grumbach/cfg80211-expos...
base: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master
config: arm-imx_v6_v7_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/8b25a459eed15aebc25c2ce0a5bf20fea...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Emmanuel-Grumbach/cfg80211-expose-the-rfkill-device-to-the-low-level-driver/20210616-211511
git checkout 8b25a459eed15aebc25c2ce0a5bf20fea8eab638
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
In file included from net/wireless/core.c:26:
include/net/cfg80211.h: In function 'wiphy_rfkill_stop_polling':
include/net/cfg80211.h:6669:2: error: implicit declaration of function 'rfkill_pause_polling' [-Werror=implicit-function-declaration]
6669 | rfkill_pause_polling(wiphy->rfkill);
| ^~~~~~~~~~~~~~~~~~~~
In file included from net/wireless/core.h:14,
from net/wireless/nl80211.h:9,
from net/wireless/core.c:27:
include/linux/rfkill.h: At top level:
>> include/linux/rfkill.h:110:6: warning: conflicting types for 'rfkill_pause_polling'
110 | void rfkill_pause_polling(struct rfkill *rfkill);
| ^~~~~~~~~~~~~~~~~~~~
In file included from net/wireless/core.c:26:
include/net/cfg80211.h:6669:2: note: previous implicit declaration of 'rfkill_pause_polling' was here
6669 | rfkill_pause_polling(wiphy->rfkill);
| ^~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/rfkill_pause_polling +110 include/linux/rfkill.h
135900c182c321 Michael Buesch 2007-09-27 101
19d337dff95cbf Johannes Berg 2009-06-02 102 /**
19d337dff95cbf Johannes Berg 2009-06-02 103 * rfkill_pause_polling(struct rfkill *rfkill)
19d337dff95cbf Johannes Berg 2009-06-02 104 *
19d337dff95cbf Johannes Berg 2009-06-02 105 * Pause polling -- say transmitter is off for other reasons.
19d337dff95cbf Johannes Berg 2009-06-02 106 * NOTE: not necessary for suspend/resume -- in that case the
dd21dfc645d5dc Johannes Berg 2016-01-20 107 * core stops polling anyway (but will also correctly handle
dd21dfc645d5dc Johannes Berg 2016-01-20 108 * the case of polling having been paused before suspend.)
19d337dff95cbf Johannes Berg 2009-06-02 109 */
19d337dff95cbf Johannes Berg 2009-06-02 @110 void rfkill_pause_polling(struct rfkill *rfkill);
cf4328cd949c20 Ivo van Doorn 2007-05-07 111
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 3 months
Re: [PATCH 3/4] serial: 8250: Add proper clock handling for OxSemi PCIe devices
by kernel test robot
Hi "Maciej,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v5.13-rc6 next-20210616]
[cannot apply to tty/tty-testing]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Maciej-W-Rozycki/serial-8250-Fix...
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 94f0b2d4a1d0c52035aef425da5e022bd2cb1c71
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/d3a55e8397b71f343ef931cd098d42a13...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Maciej-W-Rozycki/serial-8250-Fixes-for-Oxford-Semiconductor-950-UARTs/20210616-201047
git checkout d3a55e8397b71f343ef931cd098d42a13faf9047
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=xtensa
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
drivers/tty/serial/8250/8250_pci.c: In function 'pci_oxsemi_tornado_setup':
>> drivers/tty/serial/8250/8250_pci.c:1258:18: warning: unsigned conversion from 'int' to 'unsigned char' changes value from '-129' to '127' [-Woverflow]
1258 | up->mcr_mask = ~UART_MCR_CLKSEL;
| ^
vim +1258 drivers/tty/serial/8250/8250_pci.c
1241
1242 /*
1243 * For Tornado devices we force MCR[7] set for the Divide-by-M N/8 baud rate
1244 * generator prescaler (CPR and CPR2). Otherwise no prescaler would be used.
1245 */
1246 static int pci_oxsemi_tornado_setup(struct serial_private *priv,
1247 const struct pciserial_board *board,
1248 struct uart_8250_port *up, int idx)
1249 {
1250 struct pci_dev *dev = priv->dev;
1251
1252 /* OxSemi Tornado devices are all 0xCxxx */
1253 if (dev->vendor == PCI_VENDOR_ID_OXSEMI &&
1254 (dev->device & 0xF000) == 0xC000) {
1255 up->port.get_divisor = pci_oxsemi_tornado_get_divisor;
1256 up->port.set_divisor = pci_oxsemi_tornado_set_divisor;
1257
> 1258 up->mcr_mask = ~UART_MCR_CLKSEL;
1259 up->mcr_force = UART_MCR_CLKSEL;
1260 }
1261
1262 return pci_default_setup(priv, board, up, idx);
1263 }
1264
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 3 months
Re: [PATCH -next] scsi: ufs: fix build warning without CONFIG_PM
by kernel test robot
Hi YueHaibing,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on next-20210615]
url: https://github.com/0day-ci/linux/commits/YueHaibing/scsi-ufs-fix-build-wa...
base: 19ae1f2bd9c091059f80646604ccef8a1e614f57
config: arc-allyesconfig (attached as .config)
compiler: arceb-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/6874b79b80a6d8905fe434342e4233b23...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review YueHaibing/scsi-ufs-fix-build-warning-without-CONFIG_PM/20210616-183217
git checkout 6874b79b80a6d8905fe434342e4233b23c3b2104
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from include/linux/device.h:25,
from include/linux/async.h:14,
from drivers/scsi/ufs/ufshcd.c:12:
>> drivers/scsi/ufs/ufshcd.c:9728:21: error: 'ufshcd_wl_runtime_suspend' undeclared here (not in a function); did you mean 'ufshcd_runtime_suspend'?
9728 | SET_RUNTIME_PM_OPS(ufshcd_wl_runtime_suspend, ufshcd_wl_runtime_resume, NULL)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/pm.h:341:21: note: in definition of macro 'SET_RUNTIME_PM_OPS'
341 | .runtime_suspend = suspend_fn, \
| ^~~~~~~~~~
>> drivers/scsi/ufs/ufshcd.c:9728:48: error: 'ufshcd_wl_runtime_resume' undeclared here (not in a function); did you mean 'ufshcd_runtime_resume'?
9728 | SET_RUNTIME_PM_OPS(ufshcd_wl_runtime_suspend, ufshcd_wl_runtime_resume, NULL)
| ^~~~~~~~~~~~~~~~~~~~~~~~
include/linux/pm.h:342:20: note: in definition of macro 'SET_RUNTIME_PM_OPS'
342 | .runtime_resume = resume_fn, \
| ^~~~~~~~~
>> drivers/scsi/ufs/ufshcd.c:9781:27: error: 'ufshcd_rpmb_resume' undeclared here (not in a function); did you mean 'ufshcd_vops_resume'?
9781 | SET_RUNTIME_PM_OPS(NULL, ufshcd_rpmb_resume, NULL)
| ^~~~~~~~~~~~~~~~~~
include/linux/pm.h:342:20: note: in definition of macro 'SET_RUNTIME_PM_OPS'
342 | .runtime_resume = resume_fn, \
| ^~~~~~~~~
In file included from include/linux/perf_event.h:25,
from include/linux/trace_events.h:10,
from include/trace/trace_events.h:21,
from include/trace/define_trace.h:102,
from include/trace/events/ufs.h:396,
from drivers/scsi/ufs/ufshcd.c:31:
arch/arc/include/asm/perf_event.h:126:23: warning: 'arc_pmu_cache_map' defined but not used [-Wunused-const-variable=]
126 | static const unsigned arc_pmu_cache_map[C(MAX)][C(OP_MAX)][C(RESULT_MAX)] = {
| ^~~~~~~~~~~~~~~~~
arch/arc/include/asm/perf_event.h:91:27: warning: 'arc_pmu_ev_hw_map' defined but not used [-Wunused-const-variable=]
91 | static const char * const arc_pmu_ev_hw_map[] = {
| ^~~~~~~~~~~~~~~~~
vim +9728 drivers/scsi/ufs/ufshcd.c
b294ff3e34490f Asutosh Das 2021-04-23 9718
b294ff3e34490f Asutosh Das 2021-04-23 9719 static const struct dev_pm_ops ufshcd_wl_pm_ops = {
b294ff3e34490f Asutosh Das 2021-04-23 9720 #ifdef CONFIG_PM_SLEEP
b294ff3e34490f Asutosh Das 2021-04-23 9721 .suspend = ufshcd_wl_suspend,
b294ff3e34490f Asutosh Das 2021-04-23 9722 .resume = ufshcd_wl_resume,
b294ff3e34490f Asutosh Das 2021-04-23 9723 .freeze = ufshcd_wl_suspend,
b294ff3e34490f Asutosh Das 2021-04-23 9724 .thaw = ufshcd_wl_resume,
b294ff3e34490f Asutosh Das 2021-04-23 9725 .poweroff = ufshcd_wl_poweroff,
b294ff3e34490f Asutosh Das 2021-04-23 9726 .restore = ufshcd_wl_resume,
b294ff3e34490f Asutosh Das 2021-04-23 9727 #endif
b294ff3e34490f Asutosh Das 2021-04-23 @9728 SET_RUNTIME_PM_OPS(ufshcd_wl_runtime_suspend, ufshcd_wl_runtime_resume, NULL)
b294ff3e34490f Asutosh Das 2021-04-23 9729 };
b294ff3e34490f Asutosh Das 2021-04-23 9730
b294ff3e34490f Asutosh Das 2021-04-23 9731 /*
b294ff3e34490f Asutosh Das 2021-04-23 9732 * ufs_dev_wlun_template - describes ufs device wlun
b294ff3e34490f Asutosh Das 2021-04-23 9733 * ufs-device wlun - used to send pm commands
b294ff3e34490f Asutosh Das 2021-04-23 9734 * All luns are consumers of ufs-device wlun.
b294ff3e34490f Asutosh Das 2021-04-23 9735 *
b294ff3e34490f Asutosh Das 2021-04-23 9736 * Currently, no sd driver is present for wluns.
b294ff3e34490f Asutosh Das 2021-04-23 9737 * Hence the no specific pm operations are performed.
b294ff3e34490f Asutosh Das 2021-04-23 9738 * With ufs design, SSU should be sent to ufs-device wlun.
b294ff3e34490f Asutosh Das 2021-04-23 9739 * Hence register a scsi driver for ufs wluns only.
b294ff3e34490f Asutosh Das 2021-04-23 9740 */
b294ff3e34490f Asutosh Das 2021-04-23 9741 static struct scsi_driver ufs_dev_wlun_template = {
b294ff3e34490f Asutosh Das 2021-04-23 9742 .gendrv = {
b294ff3e34490f Asutosh Das 2021-04-23 9743 .name = "ufs_device_wlun",
b294ff3e34490f Asutosh Das 2021-04-23 9744 .owner = THIS_MODULE,
b294ff3e34490f Asutosh Das 2021-04-23 9745 .probe = ufshcd_wl_probe,
b294ff3e34490f Asutosh Das 2021-04-23 9746 .remove = ufshcd_wl_remove,
b294ff3e34490f Asutosh Das 2021-04-23 9747 .pm = &ufshcd_wl_pm_ops,
b294ff3e34490f Asutosh Das 2021-04-23 9748 .shutdown = ufshcd_wl_shutdown,
b294ff3e34490f Asutosh Das 2021-04-23 9749 },
b294ff3e34490f Asutosh Das 2021-04-23 9750 };
b294ff3e34490f Asutosh Das 2021-04-23 9751
b294ff3e34490f Asutosh Das 2021-04-23 9752 static int ufshcd_rpmb_probe(struct device *dev)
b294ff3e34490f Asutosh Das 2021-04-23 9753 {
b294ff3e34490f Asutosh Das 2021-04-23 9754 return is_rpmb_wlun(to_scsi_device(dev)) ? 0 : -ENODEV;
b294ff3e34490f Asutosh Das 2021-04-23 9755 }
b294ff3e34490f Asutosh Das 2021-04-23 9756
b294ff3e34490f Asutosh Das 2021-04-23 9757 static inline int ufshcd_clear_rpmb_uac(struct ufs_hba *hba)
b294ff3e34490f Asutosh Das 2021-04-23 9758 {
b294ff3e34490f Asutosh Das 2021-04-23 9759 int ret = 0;
b294ff3e34490f Asutosh Das 2021-04-23 9760
b294ff3e34490f Asutosh Das 2021-04-23 9761 if (!hba->wlun_rpmb_clr_ua)
b294ff3e34490f Asutosh Das 2021-04-23 9762 return 0;
b294ff3e34490f Asutosh Das 2021-04-23 9763 ret = ufshcd_clear_ua_wlun(hba, UFS_UPIU_RPMB_WLUN);
b294ff3e34490f Asutosh Das 2021-04-23 9764 if (!ret)
b294ff3e34490f Asutosh Das 2021-04-23 9765 hba->wlun_rpmb_clr_ua = 0;
b294ff3e34490f Asutosh Das 2021-04-23 9766 return ret;
b294ff3e34490f Asutosh Das 2021-04-23 9767 }
b294ff3e34490f Asutosh Das 2021-04-23 9768
6874b79b80a6d8 YueHaibing 2021-06-11 9769 #ifdef CONFIG_PM_SLEEP
b294ff3e34490f Asutosh Das 2021-04-23 9770 static int ufshcd_rpmb_resume(struct device *dev)
b294ff3e34490f Asutosh Das 2021-04-23 9771 {
b294ff3e34490f Asutosh Das 2021-04-23 9772 struct ufs_hba *hba = wlun_dev_to_hba(dev);
b294ff3e34490f Asutosh Das 2021-04-23 9773
b294ff3e34490f Asutosh Das 2021-04-23 9774 if (hba->sdev_rpmb)
b294ff3e34490f Asutosh Das 2021-04-23 9775 ufshcd_clear_rpmb_uac(hba);
b294ff3e34490f Asutosh Das 2021-04-23 9776 return 0;
b294ff3e34490f Asutosh Das 2021-04-23 9777 }
6874b79b80a6d8 YueHaibing 2021-06-11 9778 #endif
b294ff3e34490f Asutosh Das 2021-04-23 9779
b294ff3e34490f Asutosh Das 2021-04-23 9780 static const struct dev_pm_ops ufs_rpmb_pm_ops = {
b294ff3e34490f Asutosh Das 2021-04-23 @9781 SET_RUNTIME_PM_OPS(NULL, ufshcd_rpmb_resume, NULL)
b294ff3e34490f Asutosh Das 2021-04-23 9782 SET_SYSTEM_SLEEP_PM_OPS(NULL, ufshcd_rpmb_resume)
b294ff3e34490f Asutosh Das 2021-04-23 9783 };
b294ff3e34490f Asutosh Das 2021-04-23 9784
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 3 months
Re: [Intel-gfx] [PATCH 5/5] DONOTMERGE: dma-buf: Get rid of dma_fence_get_rcu_safe
by kernel test robot
Hi Jason,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on drm-tip/drm-tip drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next linus/master v5.13-rc6 next-20210616]
[cannot apply to drm/drm-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Jason-Ekstrand/dma-fence-i915-St...
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-randconfig-s001-20210615 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.3-341-g8af24329-dirty
# https://github.com/0day-ci/linux/commit/d718e3dba487fc068d793f6220ac2508c...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Jason-Ekstrand/dma-fence-i915-Stop-allowing-SLAB_TYPESAFE_BY_RCU-for-dma_fence/20210616-154432
git checkout d718e3dba487fc068d793f6220ac2508c98d0eef
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c: note: in included file:
>> include/drm/drm_syncobj.h:110:50: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct dma_fence *fence @@ got struct dma_fence [noderef] __rcu *fence @@
include/drm/drm_syncobj.h:110:50: sparse: expected struct dma_fence *fence
include/drm/drm_syncobj.h:110:50: sparse: got struct dma_fence [noderef] __rcu *fence
>> include/drm/drm_syncobj.h:110:50: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct dma_fence *fence @@ got struct dma_fence [noderef] __rcu *fence @@
include/drm/drm_syncobj.h:110:50: sparse: expected struct dma_fence *fence
include/drm/drm_syncobj.h:110:50: sparse: got struct dma_fence [noderef] __rcu *fence
vim +110 include/drm/drm_syncobj.h
90
91 /**
92 * drm_syncobj_fence_get - get a reference to a fence in a sync object
93 * @syncobj: sync object.
94 *
95 * This acquires additional reference to &drm_syncobj.fence contained in @obj,
96 * if not NULL. It is illegal to call this without already holding a reference.
97 * No locks required.
98 *
99 * Returns:
100 * Either the fence of @obj or NULL if there's none.
101 */
102 static inline struct dma_fence *
103 drm_syncobj_fence_get(struct drm_syncobj *syncobj)
104 {
105 struct dma_fence *fence;
106
107 rcu_read_lock();
108 fence = rcu_dereference(syncobj->fence);
109 if (fence)
> 110 fence = dma_fence_get_rcu(syncobj->fence);
111 rcu_read_unlock();
112
113 return fence;
114 }
115
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 3 months
Re: [PATCH v1] Bluetooth: btintel: Support Digital(N) + RF(N-1) combination
by kernel test robot
Hi Kiran,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on bluetooth-next/master]
[also build test WARNING on bluetooth/master v5.13-rc6 next-20210616]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Kiran-K/Bluetooth-btintel-Suppor...
base: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
config: x86_64-randconfig-a015-20210615 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 64720f57bea6a6bf033feef4a5751ab9c0c3b401)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://github.com/0day-ci/linux/commit/6e8c708932770f46284508ca6f027fa39...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Kiran-K/Bluetooth-btintel-Support-Digital-N-RF-N-1-combination/20210616-183512
git checkout 6e8c708932770f46284508ca6f027fa39393389e
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/bluetooth/btintel.c:486:6: warning: no previous prototype for function 'btintel_parse_version_tlv' [-Wmissing-prototypes]
void btintel_parse_version_tlv(struct hci_dev *hdev, struct sk_buff *skb,
^
drivers/bluetooth/btintel.c:486:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void btintel_parse_version_tlv(struct hci_dev *hdev, struct sk_buff *skb,
^
static
1 warning generated.
vim +/btintel_parse_version_tlv +486 drivers/bluetooth/btintel.c
485
> 486 void btintel_parse_version_tlv(struct hci_dev *hdev, struct sk_buff *skb,
487 struct intel_version_tlv *version)
488 {
489 /* Consume Command Complete Status field */
490 skb_pull(skb, sizeof(__u8));
491
492 /* Event parameters contatin multiple TLVs. Read each of them
493 * and only keep the required data. Also, it use existing legacy
494 * version field like hw_platform, hw_variant, and fw_variant
495 * to keep the existing setup flow
496 */
497 while (skb->len) {
498 struct intel_tlv *tlv;
499
500 tlv = (struct intel_tlv *)skb->data;
501 switch (tlv->type) {
502 case INTEL_TLV_CNVI_TOP:
503 version->cnvi_top = get_unaligned_le32(tlv->val);
504 break;
505 case INTEL_TLV_CNVR_TOP:
506 version->cnvr_top = get_unaligned_le32(tlv->val);
507 break;
508 case INTEL_TLV_CNVI_BT:
509 version->cnvi_bt = get_unaligned_le32(tlv->val);
510 break;
511 case INTEL_TLV_CNVR_BT:
512 version->cnvr_bt = get_unaligned_le32(tlv->val);
513 break;
514 case INTEL_TLV_DEV_REV_ID:
515 version->dev_rev_id = get_unaligned_le16(tlv->val);
516 break;
517 case INTEL_TLV_IMAGE_TYPE:
518 version->img_type = tlv->val[0];
519 break;
520 case INTEL_TLV_TIME_STAMP:
521 version->timestamp = get_unaligned_le16(tlv->val);
522 break;
523 case INTEL_TLV_BUILD_TYPE:
524 version->build_type = tlv->val[0];
525 break;
526 case INTEL_TLV_BUILD_NUM:
527 version->build_num = get_unaligned_le32(tlv->val);
528 break;
529 case INTEL_TLV_SECURE_BOOT:
530 version->secure_boot = tlv->val[0];
531 break;
532 case INTEL_TLV_OTP_LOCK:
533 version->otp_lock = tlv->val[0];
534 break;
535 case INTEL_TLV_API_LOCK:
536 version->api_lock = tlv->val[0];
537 break;
538 case INTEL_TLV_DEBUG_LOCK:
539 version->debug_lock = tlv->val[0];
540 break;
541 case INTEL_TLV_MIN_FW:
542 version->min_fw_build_nn = tlv->val[0];
543 version->min_fw_build_cw = tlv->val[1];
544 version->min_fw_build_yy = tlv->val[2];
545 break;
546 case INTEL_TLV_LIMITED_CCE:
547 version->limited_cce = tlv->val[0];
548 break;
549 case INTEL_TLV_SBE_TYPE:
550 version->sbe_type = tlv->val[0];
551 break;
552 case INTEL_TLV_OTP_BDADDR:
553 memcpy(&version->otp_bd_addr, tlv->val, tlv->len);
554 break;
555 default:
556 /* Ignore rest of information */
557 break;
558 }
559 /* consume the current tlv and move to next*/
560 skb_pull(skb, tlv->len + sizeof(*tlv));
561 }
562 }
563 EXPORT_SYMBOL_GPL(btintel_parse_version_tlv);
564
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 3 months