[linux-next:master 845/1131] net/core/dev.c:6015:33: error: implicit declaration of function 'skb_ext_find'
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: db503865b9ba6284edfee3825846a464cc4f4c61
commit: 8550ff8d8c75416e984d9c4b082845e57e560984 [845/1131] skbuff: Release nfct refcount on napi stolen or re-used skbs
config: x86_64-buildonly-randconfig-r002-20210711 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 8d69635ed9ecf36fd0ca85906bfde17949671cbe)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commi...
git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git fetch --no-tags linux-next master
git checkout 8550ff8d8c75416e984d9c4b082845e57e560984
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Note: the linux-next/master HEAD db503865b9ba6284edfee3825846a464cc4f4c61 builds fine.
It may have been fixed somewhere.
All errors (new ones prefixed by >>):
>> net/core/dev.c:6015:33: error: implicit declaration of function 'skb_ext_find' [-Werror,-Wimplicit-function-declaration]
struct tc_skb_ext *skb_ext = skb_ext_find(skb, TC_SKB_EXT);
^
>> net/core/dev.c:6015:51: error: use of undeclared identifier 'TC_SKB_EXT'
struct tc_skb_ext *skb_ext = skb_ext_find(skb, TC_SKB_EXT);
^
net/core/dev.c:6016:47: error: use of undeclared identifier 'TC_SKB_EXT'
struct tc_skb_ext *p_ext = skb_ext_find(p, TC_SKB_EXT);
^
>> net/core/dev.c:6020:19: error: incomplete definition of type 'struct tc_skb_ext'
diffs |= p_ext->chain ^ skb_ext->chain;
~~~~~^
net/core/dev.c:6015:11: note: forward declaration of 'struct tc_skb_ext'
struct tc_skb_ext *skb_ext = skb_ext_find(skb, TC_SKB_EXT);
^
net/core/dev.c:6020:36: error: incomplete definition of type 'struct tc_skb_ext'
diffs |= p_ext->chain ^ skb_ext->chain;
~~~~~~~^
net/core/dev.c:6015:11: note: forward declaration of 'struct tc_skb_ext'
struct tc_skb_ext *skb_ext = skb_ext_find(skb, TC_SKB_EXT);
^
5 errors generated.
vim +/skb_ext_find +6015 net/core/dev.c
5980
5981 static void gro_list_prepare(const struct list_head *head,
5982 const struct sk_buff *skb)
5983 {
5984 unsigned int maclen = skb->dev->hard_header_len;
5985 u32 hash = skb_get_hash_raw(skb);
5986 struct sk_buff *p;
5987
5988 list_for_each_entry(p, head, list) {
5989 unsigned long diffs;
5990
5991 NAPI_GRO_CB(p)->flush = 0;
5992
5993 if (hash != skb_get_hash_raw(p)) {
5994 NAPI_GRO_CB(p)->same_flow = 0;
5995 continue;
5996 }
5997
5998 diffs = (unsigned long)p->dev ^ (unsigned long)skb->dev;
5999 diffs |= skb_vlan_tag_present(p) ^ skb_vlan_tag_present(skb);
6000 if (skb_vlan_tag_present(p))
6001 diffs |= skb_vlan_tag_get(p) ^ skb_vlan_tag_get(skb);
6002 diffs |= skb_metadata_dst_cmp(p, skb);
6003 diffs |= skb_metadata_differs(p, skb);
6004 if (maclen == ETH_HLEN)
6005 diffs |= compare_ether_header(skb_mac_header(p),
6006 skb_mac_header(skb));
6007 else if (!diffs)
6008 diffs = memcmp(skb_mac_header(p),
6009 skb_mac_header(skb),
6010 maclen);
6011
6012 diffs |= skb_get_nfct(p) ^ skb_get_nfct(skb);
6013
6014 if (!diffs) {
> 6015 struct tc_skb_ext *skb_ext = skb_ext_find(skb, TC_SKB_EXT);
6016 struct tc_skb_ext *p_ext = skb_ext_find(p, TC_SKB_EXT);
6017
6018 diffs |= (!!p_ext) ^ (!!skb_ext);
6019 if (!diffs && unlikely(skb_ext))
> 6020 diffs |= p_ext->chain ^ skb_ext->chain;
6021 }
6022
6023 NAPI_GRO_CB(p)->same_flow = !diffs;
6024 }
6025 }
6026
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 2 months
[ti:ti-linux-5.10.y 6283/6309] net/socket.c:861:5: error: use of undeclared identifier 'SCM_RED_TIMESTAMPING'
by kernel test robot
tree: git://git.ti.com/ti-linux-kernel/ti-linux-kernel.git ti-linux-5.10.y
head: 31b50abb3ee1c8f78cb2d61c6fbbf074c7f5d99f
commit: b98f7ec080e0de442e0be84994ec8d26bdc39eeb [6283/6309] net: socket: Forward extra timestamp of received skb to user space
config: mips-randconfig-r016-20210711 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 8d69635ed9ecf36fd0ca85906bfde17949671cbe)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install mips cross compiling tool for clang build
# apt-get install binutils-mips-linux-gnu
git remote add ti git://git.ti.com/ti-linux-kernel/ti-linux-kernel.git
git fetch --no-tags ti ti-linux-5.10.y
git checkout b98f7ec080e0de442e0be84994ec8d26bdc39eeb
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross O=build_dir ARCH=mips SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from net/socket.c:95:
In file included from include/net/cls_cgroup.h:14:
include/net/sock.h:2525:29: error: use of undeclared identifier 'SCM_REDUNDANT'
put_cmsg(msg, SOL_SOCKET, SCM_REDUNDANT, sizeof(*sred), sred);
^
>> net/socket.c:861:5: error: use of undeclared identifier 'SCM_RED_TIMESTAMPING'
SCM_RED_TIMESTAMPING, sizeof(tss), &tss);
^
2 errors generated.
vim +/SCM_RED_TIMESTAMPING +861 net/socket.c
845
846 void __sock_recv_redinfo_timestamp(struct msghdr *msg, struct sock *sk,
847 struct sk_buff *skb)
848 {
849 struct scm_timestamping_internal tss;
850 int empty = 1;
851 struct skb_shared_hwtstamps *red_shhwtstamps =
852 skb_redinfo_hwtstamps(skb);
853
854 if (red_shhwtstamps &&
855 (sk->sk_tsflags & SOF_TIMESTAMPING_RAW_HARDWARE) &&
856 ktime_to_timespec64_cond(red_shhwtstamps->hwtstamp, tss.ts + 2))
857 empty = 0;
858
859 if (!empty)
860 put_cmsg(msg, SOL_SOCKET,
> 861 SCM_RED_TIMESTAMPING, sizeof(tss), &tss);
862 }
863 EXPORT_SYMBOL_GPL(__sock_recv_redinfo_timestamp);
864
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 2 months
[linux-next:master 845/1131] net/core/dev.c:6015:33: error: implicit declaration of function 'skb_ext_find'; did you mean 'skb_ext_copy'?
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: db503865b9ba6284edfee3825846a464cc4f4c61
commit: 8550ff8d8c75416e984d9c4b082845e57e560984 [845/1131] skbuff: Release nfct refcount on napi stolen or re-used skbs
config: um-x86_64_defconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commi...
git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git fetch --no-tags linux-next master
git checkout 8550ff8d8c75416e984d9c4b082845e57e560984
# save the attached .config to linux build tree
make W=1 ARCH=um SUBARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Note: the linux-next/master HEAD db503865b9ba6284edfee3825846a464cc4f4c61 builds fine.
It may have been fixed somewhere.
All errors (new ones prefixed by >>):
net/core/dev.c: In function 'gro_list_prepare':
>> net/core/dev.c:6015:33: error: implicit declaration of function 'skb_ext_find'; did you mean 'skb_ext_copy'? [-Werror=implicit-function-declaration]
6015 | struct tc_skb_ext *skb_ext = skb_ext_find(skb, TC_SKB_EXT);
| ^~~~~~~~~~~~
| skb_ext_copy
net/core/dev.c:6015:51: error: 'TC_SKB_EXT' undeclared (first use in this function)
6015 | struct tc_skb_ext *skb_ext = skb_ext_find(skb, TC_SKB_EXT);
| ^~~~~~~~~~
net/core/dev.c:6015:51: note: each undeclared identifier is reported only once for each function it appears in
net/core/dev.c:6020:19: error: dereferencing pointer to incomplete type 'struct tc_skb_ext'
6020 | diffs |= p_ext->chain ^ skb_ext->chain;
| ^~
cc1: some warnings being treated as errors
vim +6015 net/core/dev.c
5980
5981 static void gro_list_prepare(const struct list_head *head,
5982 const struct sk_buff *skb)
5983 {
5984 unsigned int maclen = skb->dev->hard_header_len;
5985 u32 hash = skb_get_hash_raw(skb);
5986 struct sk_buff *p;
5987
5988 list_for_each_entry(p, head, list) {
5989 unsigned long diffs;
5990
5991 NAPI_GRO_CB(p)->flush = 0;
5992
5993 if (hash != skb_get_hash_raw(p)) {
5994 NAPI_GRO_CB(p)->same_flow = 0;
5995 continue;
5996 }
5997
5998 diffs = (unsigned long)p->dev ^ (unsigned long)skb->dev;
5999 diffs |= skb_vlan_tag_present(p) ^ skb_vlan_tag_present(skb);
6000 if (skb_vlan_tag_present(p))
6001 diffs |= skb_vlan_tag_get(p) ^ skb_vlan_tag_get(skb);
6002 diffs |= skb_metadata_dst_cmp(p, skb);
6003 diffs |= skb_metadata_differs(p, skb);
6004 if (maclen == ETH_HLEN)
6005 diffs |= compare_ether_header(skb_mac_header(p),
6006 skb_mac_header(skb));
6007 else if (!diffs)
6008 diffs = memcmp(skb_mac_header(p),
6009 skb_mac_header(skb),
6010 maclen);
6011
6012 diffs |= skb_get_nfct(p) ^ skb_get_nfct(skb);
6013
6014 if (!diffs) {
> 6015 struct tc_skb_ext *skb_ext = skb_ext_find(skb, TC_SKB_EXT);
6016 struct tc_skb_ext *p_ext = skb_ext_find(p, TC_SKB_EXT);
6017
6018 diffs |= (!!p_ext) ^ (!!skb_ext);
6019 if (!diffs && unlikely(skb_ext))
6020 diffs |= p_ext->chain ^ skb_ext->chain;
6021 }
6022
6023 NAPI_GRO_CB(p)->same_flow = !diffs;
6024 }
6025 }
6026
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 2 months
[android-goldfish:android-3.18 675/676] WARNING: sound/built-in.o(.data+0x348): Section mismatch in reference from the variable .L494 to the function .init.text:snd_minor_info_init()
by kernel test robot
tree: https://android.googlesource.com/kernel/goldfish android-3.18
head: 82a903ec4402017bbc07408833afdb3640e53bf8
commit: 75deea30e27a629139577d9dda886634a4443bb3 [675/676] ALSA: info: Drop WARN_ON() from buffer NULL sanity check
config: parisc-randconfig-c004-20210706 (attached as .config)
compiler: hppa64-linux-gcc (GCC) 5.5.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git remote add android-goldfish https://android.googlesource.com/kernel/goldfish
git fetch --no-tags android-goldfish android-3.18
git checkout 75deea30e27a629139577d9dda886634a4443bb3
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-5.5.0 make.cross O=build_dir ARCH=parisc SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> WARNING: sound/built-in.o(.data+0x348): Section mismatch in reference from the variable .L494 to the function .init.text:snd_minor_info_init()
The variable .L494 references
the function __init snd_minor_info_init()
If the reference is valid then annotate the
variable with or __refdata (see linux/init.h) or name the variable:
--
>> WARNING: sound/built-in.o(.data+0x350): Section mismatch in reference from the variable .L496 to the function .init.text:snd_card_info_init()
The variable .L496 references
the function __init snd_card_info_init()
If the reference is valid then annotate the
variable with or __refdata (see linux/init.h) or name the variable:
--
>> WARNING: sound/built-in.o(.data+0x360): Section mismatch in reference from the variable .L514 to the function .exit.text:snd_card_info_done()
The variable .L514 references
the function __exit snd_card_info_done()
If the reference is valid then annotate the
variable with (see linux/init.h) or name the variable:
--
>> WARNING: sound/built-in.o(.data+0x368): Section mismatch in reference from the variable .L516 to the function .exit.text:snd_minor_info_done()
The variable .L516 references
the function __exit snd_minor_info_done()
If the reference is valid then annotate the
variable with (see linux/init.h) or name the variable:
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 2 months
[gustavoars-linux:for-next/kspp 5/5] kernel/debug/gdbstub.c:1049:4: warning: fallthrough annotation in unreachable code
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git for-next/kspp
head: cd013b8a781567829cbb0764958b640642edc6ff
commit: cd013b8a781567829cbb0764958b640642edc6ff [5/5] Makefile: Enable -Wimplicit-fallthrough for Clang
config: riscv-randconfig-r031-20210711 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 8d69635ed9ecf36fd0ca85906bfde17949671cbe)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install riscv cross compiling tool for clang build
# apt-get install binutils-riscv64-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git/comm...
git remote add gustavoars-linux https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git
git fetch --no-tags gustavoars-linux for-next/kspp
git checkout cd013b8a781567829cbb0764958b640642edc6ff
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=riscv
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> kernel/debug/gdbstub.c:1049:4: warning: fallthrough annotation in unreachable code [-Wimplicit-fallthrough]
fallthrough;
^
include/linux/compiler_attributes.h:210:41: note: expanded from macro 'fallthrough'
# define fallthrough __attribute__((__fallthrough__))
^
1 warning generated.
vim +1049 kernel/debug/gdbstub.c
53197fc4954924 Jason Wessel 2010-04-02 953
53197fc4954924 Jason Wessel 2010-04-02 954 /*
2bbd9b0f2b4ec0 Bhaskar Chowdhury 2021-03-17 955 * This function performs all gdbserial command processing
53197fc4954924 Jason Wessel 2010-04-02 956 */
53197fc4954924 Jason Wessel 2010-04-02 957 int gdb_serial_stub(struct kgdb_state *ks)
53197fc4954924 Jason Wessel 2010-04-02 958 {
53197fc4954924 Jason Wessel 2010-04-02 959 int error = 0;
53197fc4954924 Jason Wessel 2010-04-02 960 int tmp;
53197fc4954924 Jason Wessel 2010-04-02 961
55751145dc1e08 Jason Wessel 2010-08-05 962 /* Initialize comm buffer and globals. */
53197fc4954924 Jason Wessel 2010-04-02 963 memset(remcom_out_buffer, 0, sizeof(remcom_out_buffer));
55751145dc1e08 Jason Wessel 2010-08-05 964 kgdb_usethread = kgdb_info[ks->cpu].task;
55751145dc1e08 Jason Wessel 2010-08-05 965 ks->kgdb_usethreadid = shadow_pid(kgdb_info[ks->cpu].task->pid);
55751145dc1e08 Jason Wessel 2010-08-05 966 ks->pass_exception = 0;
53197fc4954924 Jason Wessel 2010-04-02 967
53197fc4954924 Jason Wessel 2010-04-02 968 if (kgdb_connected) {
84a0bd5b283072 Jason Wessel 2010-08-05 969 unsigned char thref[BUF_THREAD_ID_SIZE];
53197fc4954924 Jason Wessel 2010-04-02 970 char *ptr;
53197fc4954924 Jason Wessel 2010-04-02 971
53197fc4954924 Jason Wessel 2010-04-02 972 /* Reply to host that an exception has occurred */
53197fc4954924 Jason Wessel 2010-04-02 973 ptr = remcom_out_buffer;
53197fc4954924 Jason Wessel 2010-04-02 974 *ptr++ = 'T';
50e1499f468fd7 Andy Shevchenko 2011-10-31 975 ptr = hex_byte_pack(ptr, ks->signo);
53197fc4954924 Jason Wessel 2010-04-02 976 ptr += strlen(strcpy(ptr, "thread:"));
53197fc4954924 Jason Wessel 2010-04-02 977 int_to_threadref(thref, shadow_pid(current->pid));
53197fc4954924 Jason Wessel 2010-04-02 978 ptr = pack_threadid(ptr, thref);
53197fc4954924 Jason Wessel 2010-04-02 979 *ptr++ = ';';
53197fc4954924 Jason Wessel 2010-04-02 980 put_packet(remcom_out_buffer);
53197fc4954924 Jason Wessel 2010-04-02 981 }
53197fc4954924 Jason Wessel 2010-04-02 982
53197fc4954924 Jason Wessel 2010-04-02 983 while (1) {
53197fc4954924 Jason Wessel 2010-04-02 984 error = 0;
53197fc4954924 Jason Wessel 2010-04-02 985
53197fc4954924 Jason Wessel 2010-04-02 986 /* Clear the out buffer. */
53197fc4954924 Jason Wessel 2010-04-02 987 memset(remcom_out_buffer, 0, sizeof(remcom_out_buffer));
53197fc4954924 Jason Wessel 2010-04-02 988
53197fc4954924 Jason Wessel 2010-04-02 989 get_packet(remcom_in_buffer);
53197fc4954924 Jason Wessel 2010-04-02 990
53197fc4954924 Jason Wessel 2010-04-02 991 switch (remcom_in_buffer[0]) {
53197fc4954924 Jason Wessel 2010-04-02 992 case '?': /* gdbserial status */
53197fc4954924 Jason Wessel 2010-04-02 993 gdb_cmd_status(ks);
53197fc4954924 Jason Wessel 2010-04-02 994 break;
53197fc4954924 Jason Wessel 2010-04-02 995 case 'g': /* return the value of the CPU registers */
53197fc4954924 Jason Wessel 2010-04-02 996 gdb_cmd_getregs(ks);
53197fc4954924 Jason Wessel 2010-04-02 997 break;
53197fc4954924 Jason Wessel 2010-04-02 998 case 'G': /* set the value of the CPU registers - return OK */
53197fc4954924 Jason Wessel 2010-04-02 999 gdb_cmd_setregs(ks);
53197fc4954924 Jason Wessel 2010-04-02 1000 break;
53197fc4954924 Jason Wessel 2010-04-02 1001 case 'm': /* mAA..AA,LLLL Read LLLL bytes at address AA..AA */
53197fc4954924 Jason Wessel 2010-04-02 1002 gdb_cmd_memread(ks);
53197fc4954924 Jason Wessel 2010-04-02 1003 break;
53197fc4954924 Jason Wessel 2010-04-02 1004 case 'M': /* MAA..AA,LLLL: Write LLLL bytes at address AA..AA */
53197fc4954924 Jason Wessel 2010-04-02 1005 gdb_cmd_memwrite(ks);
53197fc4954924 Jason Wessel 2010-04-02 1006 break;
55751145dc1e08 Jason Wessel 2010-08-05 1007 #if DBG_MAX_REG_NUM > 0
55751145dc1e08 Jason Wessel 2010-08-05 1008 case 'p': /* pXX Return gdb register XX (in hex) */
55751145dc1e08 Jason Wessel 2010-08-05 1009 gdb_cmd_reg_get(ks);
55751145dc1e08 Jason Wessel 2010-08-05 1010 break;
55751145dc1e08 Jason Wessel 2010-08-05 1011 case 'P': /* PXX=aaaa Set gdb register XX to aaaa (in hex) */
55751145dc1e08 Jason Wessel 2010-08-05 1012 gdb_cmd_reg_set(ks);
55751145dc1e08 Jason Wessel 2010-08-05 1013 break;
55751145dc1e08 Jason Wessel 2010-08-05 1014 #endif /* DBG_MAX_REG_NUM > 0 */
53197fc4954924 Jason Wessel 2010-04-02 1015 case 'X': /* XAA..AA,LLLL: Write LLLL bytes at address AA..AA */
53197fc4954924 Jason Wessel 2010-04-02 1016 gdb_cmd_binwrite(ks);
53197fc4954924 Jason Wessel 2010-04-02 1017 break;
53197fc4954924 Jason Wessel 2010-04-02 1018 /* kill or detach. KGDB should treat this like a
53197fc4954924 Jason Wessel 2010-04-02 1019 * continue.
53197fc4954924 Jason Wessel 2010-04-02 1020 */
53197fc4954924 Jason Wessel 2010-04-02 1021 case 'D': /* Debugger detach */
53197fc4954924 Jason Wessel 2010-04-02 1022 case 'k': /* Debugger detach via kill */
53197fc4954924 Jason Wessel 2010-04-02 1023 gdb_cmd_detachkill(ks);
53197fc4954924 Jason Wessel 2010-04-02 1024 goto default_handle;
53197fc4954924 Jason Wessel 2010-04-02 1025 case 'R': /* Reboot */
53197fc4954924 Jason Wessel 2010-04-02 1026 if (gdb_cmd_reboot(ks))
53197fc4954924 Jason Wessel 2010-04-02 1027 goto default_handle;
53197fc4954924 Jason Wessel 2010-04-02 1028 break;
53197fc4954924 Jason Wessel 2010-04-02 1029 case 'q': /* query command */
53197fc4954924 Jason Wessel 2010-04-02 1030 gdb_cmd_query(ks);
53197fc4954924 Jason Wessel 2010-04-02 1031 break;
53197fc4954924 Jason Wessel 2010-04-02 1032 case 'H': /* task related */
53197fc4954924 Jason Wessel 2010-04-02 1033 gdb_cmd_task(ks);
53197fc4954924 Jason Wessel 2010-04-02 1034 break;
53197fc4954924 Jason Wessel 2010-04-02 1035 case 'T': /* Query thread status */
53197fc4954924 Jason Wessel 2010-04-02 1036 gdb_cmd_thread(ks);
53197fc4954924 Jason Wessel 2010-04-02 1037 break;
53197fc4954924 Jason Wessel 2010-04-02 1038 case 'z': /* Break point remove */
53197fc4954924 Jason Wessel 2010-04-02 1039 case 'Z': /* Break point set */
53197fc4954924 Jason Wessel 2010-04-02 1040 gdb_cmd_break(ks);
53197fc4954924 Jason Wessel 2010-04-02 1041 break;
dcc7871128e994 Jason Wessel 2010-05-20 1042 #ifdef CONFIG_KGDB_KDB
dcc7871128e994 Jason Wessel 2010-05-20 1043 case '3': /* Escape into back into kdb */
dcc7871128e994 Jason Wessel 2010-05-20 1044 if (remcom_in_buffer[1] == '\0') {
dcc7871128e994 Jason Wessel 2010-05-20 1045 gdb_cmd_detachkill(ks);
dcc7871128e994 Jason Wessel 2010-05-20 1046 return DBG_PASS_EVENT;
dcc7871128e994 Jason Wessel 2010-05-20 1047 }
dcc7871128e994 Jason Wessel 2010-05-20 1048 #endif
df561f6688fef7 Gustavo A. R. Silva 2020-08-23 @1049 fallthrough;
53197fc4954924 Jason Wessel 2010-04-02 1050 case 'C': /* Exception passing */
53197fc4954924 Jason Wessel 2010-04-02 1051 tmp = gdb_cmd_exception_pass(ks);
53197fc4954924 Jason Wessel 2010-04-02 1052 if (tmp > 0)
53197fc4954924 Jason Wessel 2010-04-02 1053 goto default_handle;
53197fc4954924 Jason Wessel 2010-04-02 1054 if (tmp == 0)
53197fc4954924 Jason Wessel 2010-04-02 1055 break;
df561f6688fef7 Gustavo A. R. Silva 2020-08-23 1056 fallthrough; /* on tmp < 0 */
53197fc4954924 Jason Wessel 2010-04-02 1057 case 'c': /* Continue packet */
53197fc4954924 Jason Wessel 2010-04-02 1058 case 's': /* Single step packet */
53197fc4954924 Jason Wessel 2010-04-02 1059 if (kgdb_contthread && kgdb_contthread != current) {
53197fc4954924 Jason Wessel 2010-04-02 1060 /* Can't switch threads in kgdb */
53197fc4954924 Jason Wessel 2010-04-02 1061 error_packet(remcom_out_buffer, -EINVAL);
53197fc4954924 Jason Wessel 2010-04-02 1062 break;
53197fc4954924 Jason Wessel 2010-04-02 1063 }
df561f6688fef7 Gustavo A. R. Silva 2020-08-23 1064 fallthrough; /* to default processing */
53197fc4954924 Jason Wessel 2010-04-02 1065 default:
53197fc4954924 Jason Wessel 2010-04-02 1066 default_handle:
53197fc4954924 Jason Wessel 2010-04-02 1067 error = kgdb_arch_handle_exception(ks->ex_vector,
53197fc4954924 Jason Wessel 2010-04-02 1068 ks->signo,
53197fc4954924 Jason Wessel 2010-04-02 1069 ks->err_code,
53197fc4954924 Jason Wessel 2010-04-02 1070 remcom_in_buffer,
53197fc4954924 Jason Wessel 2010-04-02 1071 remcom_out_buffer,
53197fc4954924 Jason Wessel 2010-04-02 1072 ks->linux_regs);
53197fc4954924 Jason Wessel 2010-04-02 1073 /*
53197fc4954924 Jason Wessel 2010-04-02 1074 * Leave cmd processing on error, detach,
53197fc4954924 Jason Wessel 2010-04-02 1075 * kill, continue, or single step.
53197fc4954924 Jason Wessel 2010-04-02 1076 */
53197fc4954924 Jason Wessel 2010-04-02 1077 if (error >= 0 || remcom_in_buffer[0] == 'D' ||
53197fc4954924 Jason Wessel 2010-04-02 1078 remcom_in_buffer[0] == 'k') {
53197fc4954924 Jason Wessel 2010-04-02 1079 error = 0;
53197fc4954924 Jason Wessel 2010-04-02 1080 goto kgdb_exit;
53197fc4954924 Jason Wessel 2010-04-02 1081 }
53197fc4954924 Jason Wessel 2010-04-02 1082
53197fc4954924 Jason Wessel 2010-04-02 1083 }
53197fc4954924 Jason Wessel 2010-04-02 1084
53197fc4954924 Jason Wessel 2010-04-02 1085 /* reply to the request */
53197fc4954924 Jason Wessel 2010-04-02 1086 put_packet(remcom_out_buffer);
53197fc4954924 Jason Wessel 2010-04-02 1087 }
53197fc4954924 Jason Wessel 2010-04-02 1088
53197fc4954924 Jason Wessel 2010-04-02 1089 kgdb_exit:
53197fc4954924 Jason Wessel 2010-04-02 1090 if (ks->pass_exception)
53197fc4954924 Jason Wessel 2010-04-02 1091 error = 1;
53197fc4954924 Jason Wessel 2010-04-02 1092 return error;
53197fc4954924 Jason Wessel 2010-04-02 1093 }
dcc7871128e994 Jason Wessel 2010-05-20 1094
:::::: The code at line 1049 was first introduced by commit
:::::: df561f6688fef775baa341a0f5d960becd248b11 treewide: Use fallthrough pseudo-keyword
:::::: TO: Gustavo A. R. Silva <gustavoars(a)kernel.org>
:::::: CC: Gustavo A. R. Silva <gustavoars(a)kernel.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 2 months
[gustavoars-linux:for-next/kspp 5/5] fs/fcntl.c:373:3: warning: fallthrough annotation in unreachable code
by kernel test robot
Hi Gustavo,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git for-next/kspp
head: cd013b8a781567829cbb0764958b640642edc6ff
commit: cd013b8a781567829cbb0764958b640642edc6ff [5/5] Makefile: Enable -Wimplicit-fallthrough for Clang
config: riscv-buildonly-randconfig-r003-20210712 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 8d69635ed9ecf36fd0ca85906bfde17949671cbe)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install riscv cross compiling tool for clang build
# apt-get install binutils-riscv64-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git/comm...
git remote add gustavoars-linux https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git
git fetch --no-tags gustavoars-linux for-next/kspp
git checkout cd013b8a781567829cbb0764958b640642edc6ff
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=riscv
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> fs/fcntl.c:373:3: warning: fallthrough annotation in unreachable code [-Wimplicit-fallthrough]
fallthrough;
^
include/linux/compiler_attributes.h:210:41: note: expanded from macro 'fallthrough'
# define fallthrough __attribute__((__fallthrough__))
^
1 warning generated.
--
>> kernel/sched/core.c:3141:4: warning: fallthrough annotation in unreachable code [-Wimplicit-fallthrough]
fallthrough;
^
include/linux/compiler_attributes.h:210:41: note: expanded from macro 'fallthrough'
# define fallthrough __attribute__((__fallthrough__))
^
kernel/sched/core.c:3204:6: warning: no previous prototype for function 'sched_set_stop_task' [-Wmissing-prototypes]
void sched_set_stop_task(int cpu, struct task_struct *stop)
^
kernel/sched/core.c:3204:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void sched_set_stop_task(int cpu, struct task_struct *stop)
^
static
2 warnings generated.
--
>> drivers/mtd/chips/cfi_util.c:112:3: warning: fallthrough annotation in unreachable code [-Wimplicit-fallthrough]
fallthrough;
^
include/linux/compiler_attributes.h:210:41: note: expanded from macro 'fallthrough'
# define fallthrough __attribute__((__fallthrough__))
^
drivers/mtd/chips/cfi_util.c:168:3: warning: fallthrough annotation in unreachable code [-Wimplicit-fallthrough]
fallthrough;
^
include/linux/compiler_attributes.h:210:41: note: expanded from macro 'fallthrough'
# define fallthrough __attribute__((__fallthrough__))
^
2 warnings generated.
--
>> sound/core/pcm_native.c:3799:3: warning: fallthrough annotation in unreachable code [-Wimplicit-fallthrough]
fallthrough;
^
include/linux/compiler_attributes.h:210:41: note: expanded from macro 'fallthrough'
# define fallthrough __attribute__((__fallthrough__))
^
sound/core/pcm_native.c:3807:3: warning: fallthrough annotation in unreachable code [-Wimplicit-fallthrough]
fallthrough;
^
include/linux/compiler_attributes.h:210:41: note: expanded from macro 'fallthrough'
# define fallthrough __attribute__((__fallthrough__))
^
2 warnings generated.
vim +373 fs/fcntl.c
c75b1d9421f80f Jens Axboe 2017-06-27 329
^1da177e4c3f41 Linus Torvalds 2005-04-16 330 static long do_fcntl(int fd, unsigned int cmd, unsigned long arg,
^1da177e4c3f41 Linus Torvalds 2005-04-16 331 struct file *filp)
^1da177e4c3f41 Linus Torvalds 2005-04-16 332 {
a75d30c7720785 Christoph Hellwig 2017-05-27 333 void __user *argp = (void __user *)arg;
a75d30c7720785 Christoph Hellwig 2017-05-27 334 struct flock flock;
^1da177e4c3f41 Linus Torvalds 2005-04-16 335 long err = -EINVAL;
^1da177e4c3f41 Linus Torvalds 2005-04-16 336
^1da177e4c3f41 Linus Torvalds 2005-04-16 337 switch (cmd) {
^1da177e4c3f41 Linus Torvalds 2005-04-16 338 case F_DUPFD:
fe17f22d7fd0e3 Al Viro 2012-08-21 339 err = f_dupfd(arg, filp, 0);
4e1e018ecc6f7b Al Viro 2008-07-26 340 break;
fe17f22d7fd0e3 Al Viro 2012-08-21 341 case F_DUPFD_CLOEXEC:
121977187ca0a7 Al Viro 2012-10-08 342 err = f_dupfd(arg, filp, O_CLOEXEC);
^1da177e4c3f41 Linus Torvalds 2005-04-16 343 break;
^1da177e4c3f41 Linus Torvalds 2005-04-16 344 case F_GETFD:
^1da177e4c3f41 Linus Torvalds 2005-04-16 345 err = get_close_on_exec(fd) ? FD_CLOEXEC : 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16 346 break;
^1da177e4c3f41 Linus Torvalds 2005-04-16 347 case F_SETFD:
^1da177e4c3f41 Linus Torvalds 2005-04-16 348 err = 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16 349 set_close_on_exec(fd, arg & FD_CLOEXEC);
^1da177e4c3f41 Linus Torvalds 2005-04-16 350 break;
^1da177e4c3f41 Linus Torvalds 2005-04-16 351 case F_GETFL:
^1da177e4c3f41 Linus Torvalds 2005-04-16 352 err = filp->f_flags;
^1da177e4c3f41 Linus Torvalds 2005-04-16 353 break;
^1da177e4c3f41 Linus Torvalds 2005-04-16 354 case F_SETFL:
^1da177e4c3f41 Linus Torvalds 2005-04-16 355 err = setfl(fd, filp, arg);
^1da177e4c3f41 Linus Torvalds 2005-04-16 356 break;
5d50ffd7c31dab Jeff Layton 2014-02-03 357 #if BITS_PER_LONG != 32
5d50ffd7c31dab Jeff Layton 2014-02-03 358 /* 32-bit arches must use fcntl64() */
0d3f7a2dd2f5cf Jeff Layton 2014-04-22 359 case F_OFD_GETLK:
5d50ffd7c31dab Jeff Layton 2014-02-03 360 #endif
^1da177e4c3f41 Linus Torvalds 2005-04-16 361 case F_GETLK:
a75d30c7720785 Christoph Hellwig 2017-05-27 362 if (copy_from_user(&flock, argp, sizeof(flock)))
a75d30c7720785 Christoph Hellwig 2017-05-27 363 return -EFAULT;
a75d30c7720785 Christoph Hellwig 2017-05-27 364 err = fcntl_getlk(filp, cmd, &flock);
a75d30c7720785 Christoph Hellwig 2017-05-27 365 if (!err && copy_to_user(argp, &flock, sizeof(flock)))
a75d30c7720785 Christoph Hellwig 2017-05-27 366 return -EFAULT;
^1da177e4c3f41 Linus Torvalds 2005-04-16 367 break;
5d50ffd7c31dab Jeff Layton 2014-02-03 368 #if BITS_PER_LONG != 32
5d50ffd7c31dab Jeff Layton 2014-02-03 369 /* 32-bit arches must use fcntl64() */
0d3f7a2dd2f5cf Jeff Layton 2014-04-22 370 case F_OFD_SETLK:
0d3f7a2dd2f5cf Jeff Layton 2014-04-22 371 case F_OFD_SETLKW:
5d50ffd7c31dab Jeff Layton 2014-02-03 372 #endif
df561f6688fef7 Gustavo A. R. Silva 2020-08-23 @373 fallthrough;
^1da177e4c3f41 Linus Torvalds 2005-04-16 374 case F_SETLK:
^1da177e4c3f41 Linus Torvalds 2005-04-16 375 case F_SETLKW:
a75d30c7720785 Christoph Hellwig 2017-05-27 376 if (copy_from_user(&flock, argp, sizeof(flock)))
a75d30c7720785 Christoph Hellwig 2017-05-27 377 return -EFAULT;
a75d30c7720785 Christoph Hellwig 2017-05-27 378 err = fcntl_setlk(fd, filp, cmd, &flock);
^1da177e4c3f41 Linus Torvalds 2005-04-16 379 break;
^1da177e4c3f41 Linus Torvalds 2005-04-16 380 case F_GETOWN:
^1da177e4c3f41 Linus Torvalds 2005-04-16 381 /*
^1da177e4c3f41 Linus Torvalds 2005-04-16 382 * XXX If f_owner is a process group, the
^1da177e4c3f41 Linus Torvalds 2005-04-16 383 * negative return value will get converted
^1da177e4c3f41 Linus Torvalds 2005-04-16 384 * into an error. Oops. If we keep the
^1da177e4c3f41 Linus Torvalds 2005-04-16 385 * current syscall conventions, the only way
^1da177e4c3f41 Linus Torvalds 2005-04-16 386 * to fix this will be in libc.
^1da177e4c3f41 Linus Torvalds 2005-04-16 387 */
609d7fa9565c75 Eric W. Biederman 2006-10-02 388 err = f_getown(filp);
^1da177e4c3f41 Linus Torvalds 2005-04-16 389 force_successful_syscall_return();
^1da177e4c3f41 Linus Torvalds 2005-04-16 390 break;
^1da177e4c3f41 Linus Torvalds 2005-04-16 391 case F_SETOWN:
393cc3f51135ea Jiri Slaby 2017-06-13 392 err = f_setown(filp, arg, 1);
^1da177e4c3f41 Linus Torvalds 2005-04-16 393 break;
ba0a6c9f6fceed Peter Zijlstra 2009-09-23 394 case F_GETOWN_EX:
ba0a6c9f6fceed Peter Zijlstra 2009-09-23 395 err = f_getown_ex(filp, arg);
ba0a6c9f6fceed Peter Zijlstra 2009-09-23 396 break;
ba0a6c9f6fceed Peter Zijlstra 2009-09-23 397 case F_SETOWN_EX:
ba0a6c9f6fceed Peter Zijlstra 2009-09-23 398 err = f_setown_ex(filp, arg);
ba0a6c9f6fceed Peter Zijlstra 2009-09-23 399 break;
1d151c337d79fa Cyrill Gorcunov 2012-07-30 400 case F_GETOWNER_UIDS:
1d151c337d79fa Cyrill Gorcunov 2012-07-30 401 err = f_getowner_uids(filp, arg);
1d151c337d79fa Cyrill Gorcunov 2012-07-30 402 break;
^1da177e4c3f41 Linus Torvalds 2005-04-16 403 case F_GETSIG:
^1da177e4c3f41 Linus Torvalds 2005-04-16 404 err = filp->f_owner.signum;
^1da177e4c3f41 Linus Torvalds 2005-04-16 405 break;
^1da177e4c3f41 Linus Torvalds 2005-04-16 406 case F_SETSIG:
^1da177e4c3f41 Linus Torvalds 2005-04-16 407 /* arg == 0 restores default behaviour. */
7ed20e1ad521b5 Jesper Juhl 2005-05-01 408 if (!valid_signal(arg)) {
^1da177e4c3f41 Linus Torvalds 2005-04-16 409 break;
^1da177e4c3f41 Linus Torvalds 2005-04-16 410 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 411 err = 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16 412 filp->f_owner.signum = arg;
^1da177e4c3f41 Linus Torvalds 2005-04-16 413 break;
^1da177e4c3f41 Linus Torvalds 2005-04-16 414 case F_GETLEASE:
^1da177e4c3f41 Linus Torvalds 2005-04-16 415 err = fcntl_getlease(filp);
^1da177e4c3f41 Linus Torvalds 2005-04-16 416 break;
^1da177e4c3f41 Linus Torvalds 2005-04-16 417 case F_SETLEASE:
^1da177e4c3f41 Linus Torvalds 2005-04-16 418 err = fcntl_setlease(fd, filp, arg);
^1da177e4c3f41 Linus Torvalds 2005-04-16 419 break;
^1da177e4c3f41 Linus Torvalds 2005-04-16 420 case F_NOTIFY:
^1da177e4c3f41 Linus Torvalds 2005-04-16 421 err = fcntl_dirnotify(fd, filp, arg);
^1da177e4c3f41 Linus Torvalds 2005-04-16 422 break;
35f3d14dbbc584 Jens Axboe 2010-05-20 423 case F_SETPIPE_SZ:
35f3d14dbbc584 Jens Axboe 2010-05-20 424 case F_GETPIPE_SZ:
35f3d14dbbc584 Jens Axboe 2010-05-20 425 err = pipe_fcntl(filp, cmd, arg);
35f3d14dbbc584 Jens Axboe 2010-05-20 426 break;
40e041a2c858b3 David Herrmann 2014-08-08 427 case F_ADD_SEALS:
40e041a2c858b3 David Herrmann 2014-08-08 428 case F_GET_SEALS:
5aadc431a593ac Marc-André Lureau 2018-01-31 429 err = memfd_fcntl(filp, cmd, arg);
40e041a2c858b3 David Herrmann 2014-08-08 430 break;
c75b1d9421f80f Jens Axboe 2017-06-27 431 case F_GET_RW_HINT:
c75b1d9421f80f Jens Axboe 2017-06-27 432 case F_SET_RW_HINT:
c75b1d9421f80f Jens Axboe 2017-06-27 433 case F_GET_FILE_RW_HINT:
c75b1d9421f80f Jens Axboe 2017-06-27 434 case F_SET_FILE_RW_HINT:
c75b1d9421f80f Jens Axboe 2017-06-27 435 err = fcntl_rw_hint(filp, cmd, arg);
c75b1d9421f80f Jens Axboe 2017-06-27 436 break;
^1da177e4c3f41 Linus Torvalds 2005-04-16 437 default:
^1da177e4c3f41 Linus Torvalds 2005-04-16 438 break;
^1da177e4c3f41 Linus Torvalds 2005-04-16 439 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 440 return err;
^1da177e4c3f41 Linus Torvalds 2005-04-16 441 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 442
:::::: The code at line 373 was first introduced by commit
:::::: df561f6688fef775baa341a0f5d960becd248b11 treewide: Use fallthrough pseudo-keyword
:::::: TO: Gustavo A. R. Silva <gustavoars(a)kernel.org>
:::::: CC: Gustavo A. R. Silva <gustavoars(a)kernel.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 2 months
