Re: [PATCH net] sctp: do not update transport pathmtu if SPP_PMTUD_ENABLE is not set
by kernel test robot
Hi Xin,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net/master]
url: https://github.com/0day-ci/linux/commits/Xin-Long/sctp-do-not-update-tran...
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git e9a72f874d5b95cef0765bafc56005a50f72c5fe
config: x86_64-randconfig-r012-20210720 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project c781eb153bfbd1b52b03efe34f56bbeccbb8aba6)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://github.com/0day-ci/linux/commit/e6927d4d69af5f40d7884a7ccc70737bf...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Xin-Long/sctp-do-not-update-transport-pathmtu-if-SPP_PMTUD_ENABLE-is-not-set/20210722-001121
git checkout e6927d4d69af5f40d7884a7ccc70737bf3da2771
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross O=build_dir ARCH=x86_64 SHELL=/bin/bash net/sctp/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
net/sctp/output.c:112:2: error: expected identifier or '('
if (asoc->pmtu_pending) {
^
net/sctp/output.c:121:2: error: expected identifier or '('
if (ecn_capable) {
^
net/sctp/output.c:128:2: error: expected identifier or '('
if (!tp->dst)
^
>> net/sctp/output.c:132:2: warning: declaration specifier missing, defaulting to 'int'
rcu_read_lock();
^
int
net/sctp/output.c:132:15: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes]
rcu_read_lock();
^
void
net/sctp/output.c:132:2: error: conflicting types for 'rcu_read_lock'
rcu_read_lock();
^
include/linux/rcupdate.h:683:29: note: previous definition is here
static __always_inline void rcu_read_lock(void)
^
net/sctp/output.c:133:2: error: expected identifier or '('
if (__sk_dst_get(sk) != tp->dst) {
^
net/sctp/output.c:137:2: error: unknown type name 'packet'
packet->max_size = sk_can_gso(sk) ? tp->dst->dev->gso_max_size
^
net/sctp/output.c:137:8: error: expected identifier or '('
packet->max_size = sk_can_gso(sk) ? tp->dst->dev->gso_max_size
^
net/sctp/output.c:139:2: warning: declaration specifier missing, defaulting to 'int'
rcu_read_unlock();
^
int
net/sctp/output.c:139:17: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes]
rcu_read_unlock();
^
void
net/sctp/output.c:139:2: error: conflicting types for 'rcu_read_unlock'
rcu_read_unlock();
^
include/linux/rcupdate.h:714:20: note: previous definition is here
static inline void rcu_read_unlock(void)
^
net/sctp/output.c:140:1: error: extraneous closing brace ('}')
}
^
2 warnings and 11 errors generated.
vim +/int +132 net/sctp/output.c
be2971438dec2e Wei Yongjun 2009-09-04 69
^1da177e4c3f41 Linus Torvalds 2005-04-16 70 /* Config a packet.
^1da177e4c3f41 Linus Torvalds 2005-04-16 71 * This appears to be a followup set of initializations.
^1da177e4c3f41 Linus Torvalds 2005-04-16 72 */
66b91d2cd0344c Marcelo Ricardo Leitner 2016-12-28 73 void sctp_packet_config(struct sctp_packet *packet, __u32 vtag,
66b91d2cd0344c Marcelo Ricardo Leitner 2016-12-28 74 int ecn_capable)
^1da177e4c3f41 Linus Torvalds 2005-04-16 75 {
90017accff61ae Marcelo Ricardo Leitner 2016-06-02 76 struct sctp_transport *tp = packet->transport;
90017accff61ae Marcelo Ricardo Leitner 2016-06-02 77 struct sctp_association *asoc = tp->asoc;
feddd6c1af30ab Marcelo Ricardo Leitner 2018-04-26 78 struct sctp_sock *sp = NULL;
df2729c3238ed8 Xin Long 2017-04-01 79 struct sock *sk;
^1da177e4c3f41 Linus Torvalds 2005-04-16 80
bb33381d0c97cd Daniel Borkmann 2013-06-28 81 pr_debug("%s: packet:%p vtag:0x%x\n", __func__, packet, vtag);
^1da177e4c3f41 Linus Torvalds 2005-04-16 82 packet->vtag = vtag;
^1da177e4c3f41 Linus Torvalds 2005-04-16 83
df2729c3238ed8 Xin Long 2017-04-01 84 /* do the following jobs only once for a flush schedule */
df2729c3238ed8 Xin Long 2017-04-01 85 if (!sctp_packet_empty(packet))
df2729c3238ed8 Xin Long 2017-04-01 86 return;
90017accff61ae Marcelo Ricardo Leitner 2016-06-02 87
b7e10c25b839c0 Richard Haines 2018-02-24 88 /* set packet max_size with pathmtu, then calculate overhead */
90017accff61ae Marcelo Ricardo Leitner 2016-06-02 89 packet->max_size = tp->pathmtu;
feddd6c1af30ab Marcelo Ricardo Leitner 2018-04-26 90
b7e10c25b839c0 Richard Haines 2018-02-24 91 if (asoc) {
feddd6c1af30ab Marcelo Ricardo Leitner 2018-04-26 92 sk = asoc->base.sk;
feddd6c1af30ab Marcelo Ricardo Leitner 2018-04-26 93 sp = sctp_sk(sk);
feddd6c1af30ab Marcelo Ricardo Leitner 2018-04-26 94 }
feddd6c1af30ab Marcelo Ricardo Leitner 2018-04-26 95 packet->overhead = sctp_mtu_payload(sp, 0, 0);
feddd6c1af30ab Marcelo Ricardo Leitner 2018-04-26 96 packet->size = packet->overhead;
b7e10c25b839c0 Richard Haines 2018-02-24 97
feddd6c1af30ab Marcelo Ricardo Leitner 2018-04-26 98 if (!asoc)
df2729c3238ed8 Xin Long 2017-04-01 99 return;
90017accff61ae Marcelo Ricardo Leitner 2016-06-02 100
df2729c3238ed8 Xin Long 2017-04-01 101 /* update dst or transport pathmtu if in need */
df2729c3238ed8 Xin Long 2017-04-01 102 if (!sctp_transport_dst_check(tp)) {
feddd6c1af30ab Marcelo Ricardo Leitner 2018-04-26 103 sctp_transport_route(tp, NULL, sp);
df2729c3238ed8 Xin Long 2017-04-01 104 if (asoc->param_flags & SPP_PMTUD_ENABLE)
3ebfdf082184d0 Xin Long 2017-04-04 105 sctp_assoc_sync_pmtu(asoc);
7307e4fa4d295f Xin Long 2021-06-22 106 } else if (!sctp_transport_pl_enabled(tp) &&
e6927d4d69af5f Xin Long 2021-07-21 107 asoc->param_flags & SPP_PMTUD_ENABLE)
e6927d4d69af5f Xin Long 2021-07-21 108 if (!sctp_transport_pmtu_check(tp))
69fec325a64383 Xin Long 2018-11-18 109 sctp_assoc_sync_pmtu(asoc);
df2729c3238ed8 Xin Long 2017-04-01 110 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 111
d805397c3822d5 Xin Long 2018-10-15 112 if (asoc->pmtu_pending) {
d805397c3822d5 Xin Long 2018-10-15 113 if (asoc->param_flags & SPP_PMTUD_ENABLE)
d805397c3822d5 Xin Long 2018-10-15 114 sctp_assoc_sync_pmtu(asoc);
d805397c3822d5 Xin Long 2018-10-15 115 asoc->pmtu_pending = 0;
d805397c3822d5 Xin Long 2018-10-15 116 }
d805397c3822d5 Xin Long 2018-10-15 117
^1da177e4c3f41 Linus Torvalds 2005-04-16 118 /* If there a is a prepend chunk stick it on the list before
^1da177e4c3f41 Linus Torvalds 2005-04-16 119 * any other chunks get appended.
^1da177e4c3f41 Linus Torvalds 2005-04-16 120 */
df2729c3238ed8 Xin Long 2017-04-01 121 if (ecn_capable) {
df2729c3238ed8 Xin Long 2017-04-01 122 struct sctp_chunk *chunk = sctp_get_ecne_prepend(asoc);
df2729c3238ed8 Xin Long 2017-04-01 123
^1da177e4c3f41 Linus Torvalds 2005-04-16 124 if (chunk)
^1da177e4c3f41 Linus Torvalds 2005-04-16 125 sctp_packet_append_chunk(packet, chunk);
^1da177e4c3f41 Linus Torvalds 2005-04-16 126 }
df2729c3238ed8 Xin Long 2017-04-01 127
df2729c3238ed8 Xin Long 2017-04-01 128 if (!tp->dst)
df2729c3238ed8 Xin Long 2017-04-01 129 return;
df2729c3238ed8 Xin Long 2017-04-01 130
df2729c3238ed8 Xin Long 2017-04-01 131 /* set packet max_size with gso_max_size if gso is enabled*/
df2729c3238ed8 Xin Long 2017-04-01 @132 rcu_read_lock();
df2729c3238ed8 Xin Long 2017-04-01 133 if (__sk_dst_get(sk) != tp->dst) {
df2729c3238ed8 Xin Long 2017-04-01 134 dst_hold(tp->dst);
df2729c3238ed8 Xin Long 2017-04-01 135 sk_setup_caps(sk, tp->dst);
df2729c3238ed8 Xin Long 2017-04-01 136 }
df2729c3238ed8 Xin Long 2017-04-01 137 packet->max_size = sk_can_gso(sk) ? tp->dst->dev->gso_max_size
df2729c3238ed8 Xin Long 2017-04-01 138 : asoc->pathmtu;
df2729c3238ed8 Xin Long 2017-04-01 139 rcu_read_unlock();
^1da177e4c3f41 Linus Torvalds 2005-04-16 140 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 141
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 2 months
[drm-drm-misc:drm-misc-next 2/2] riscv64-linux-ld: sysfb.c:undefined reference to `screen_info'
by kernel test robot
tree: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
head: 8633ef82f101c040427b57d4df7b706261420b94
commit: 8633ef82f101c040427b57d4df7b706261420b94 [2/2] drivers/firmware: consolidate EFI framebuffer setup for all arches
config: riscv-randconfig-r031-20210720 (attached as .config)
compiler: riscv64-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git remote add drm-drm-misc git://anongit.freedesktop.org/drm/drm-misc
git fetch --no-tags drm-drm-misc drm-misc-next
git checkout 8633ef82f101c040427b57d4df7b706261420b94
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross O=build_dir ARCH=riscv SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
riscv64-linux-ld: drivers/firmware/sysfb.o: in function `.L0 ':
sysfb.c:(.init.text+0x24): undefined reference to `screen_info'
>> riscv64-linux-ld: sysfb.c:(.init.text+0x70): undefined reference to `screen_info'
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for LOCKDEP
Depends on DEBUG_KERNEL && LOCK_DEBUGGING_SUPPORT && (FRAME_POINTER || MIPS || PPC || S390 || MICROBLAZE || ARM || ARC || X86)
Selected by
- LOCK_STAT && DEBUG_KERNEL && LOCK_DEBUGGING_SUPPORT
- DEBUG_LOCK_ALLOC && DEBUG_KERNEL && LOCK_DEBUGGING_SUPPORT
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 2 months
Re: [PATCH net] sctp: do not update transport pathmtu if SPP_PMTUD_ENABLE is not set
by kernel test robot
Hi Xin,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net/master]
url: https://github.com/0day-ci/linux/commits/Xin-Long/sctp-do-not-update-tran...
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git e9a72f874d5b95cef0765bafc56005a50f72c5fe
config: arc-allyesconfig (attached as .config)
compiler: arceb-elf-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/e6927d4d69af5f40d7884a7ccc70737bf...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Xin-Long/sctp-do-not-update-transport-pathmtu-if-SPP_PMTUD_ENABLE-is-not-set/20210722-001121
git checkout e6927d4d69af5f40d7884a7ccc70737bf3da2771
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross O=build_dir ARCH=arc SHELL=/bin/bash net/sctp/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
net/sctp/output.c:112:2: error: expected identifier or '(' before 'if'
112 | if (asoc->pmtu_pending) {
| ^~
net/sctp/output.c:121:2: error: expected identifier or '(' before 'if'
121 | if (ecn_capable) {
| ^~
net/sctp/output.c:128:2: error: expected identifier or '(' before 'if'
128 | if (!tp->dst)
| ^~
>> net/sctp/output.c:132:2: warning: data definition has no type or storage class
132 | rcu_read_lock();
| ^~~~~~~~~~~~~
net/sctp/output.c:132:2: error: type defaults to 'int' in declaration of 'rcu_read_lock' [-Werror=implicit-int]
net/sctp/output.c:132:2: error: function declaration isn't a prototype [-Werror=strict-prototypes]
net/sctp/output.c:132:2: error: conflicting types for 'rcu_read_lock'
In file included from include/linux/rbtree.h:22,
from include/linux/mm_types.h:10,
from include/linux/mmzone.h:21,
from include/linux/gfp.h:6,
from include/linux/mm.h:10,
from include/linux/bvec.h:14,
from include/linux/skbuff.h:17,
from include/linux/ip.h:16,
from net/sctp/output.c:28:
include/linux/rcupdate.h:683:29: note: previous definition of 'rcu_read_lock' was here
683 | static __always_inline void rcu_read_lock(void)
| ^~~~~~~~~~~~~
net/sctp/output.c:133:2: error: expected identifier or '(' before 'if'
133 | if (__sk_dst_get(sk) != tp->dst) {
| ^~
net/sctp/output.c:137:8: error: expected '=', ',', ';', 'asm' or '__attribute__' before '->' token
137 | packet->max_size = sk_can_gso(sk) ? tp->dst->dev->gso_max_size
| ^~
net/sctp/output.c:139:2: warning: data definition has no type or storage class
139 | rcu_read_unlock();
| ^~~~~~~~~~~~~~~
net/sctp/output.c:139:2: error: type defaults to 'int' in declaration of 'rcu_read_unlock' [-Werror=implicit-int]
net/sctp/output.c:139:2: error: function declaration isn't a prototype [-Werror=strict-prototypes]
net/sctp/output.c:139:2: error: conflicting types for 'rcu_read_unlock'
In file included from include/linux/rbtree.h:22,
from include/linux/mm_types.h:10,
from include/linux/mmzone.h:21,
from include/linux/gfp.h:6,
from include/linux/mm.h:10,
from include/linux/bvec.h:14,
from include/linux/skbuff.h:17,
from include/linux/ip.h:16,
from net/sctp/output.c:28:
include/linux/rcupdate.h:714:20: note: previous definition of 'rcu_read_unlock' was here
714 | static inline void rcu_read_unlock(void)
| ^~~~~~~~~~~~~~~
net/sctp/output.c:140:1: error: expected identifier or '(' before '}' token
140 | }
| ^
cc1: some warnings being treated as errors
vim +132 net/sctp/output.c
be2971438dec2e Wei Yongjun 2009-09-04 69
^1da177e4c3f41 Linus Torvalds 2005-04-16 70 /* Config a packet.
^1da177e4c3f41 Linus Torvalds 2005-04-16 71 * This appears to be a followup set of initializations.
^1da177e4c3f41 Linus Torvalds 2005-04-16 72 */
66b91d2cd0344c Marcelo Ricardo Leitner 2016-12-28 73 void sctp_packet_config(struct sctp_packet *packet, __u32 vtag,
66b91d2cd0344c Marcelo Ricardo Leitner 2016-12-28 74 int ecn_capable)
^1da177e4c3f41 Linus Torvalds 2005-04-16 75 {
90017accff61ae Marcelo Ricardo Leitner 2016-06-02 76 struct sctp_transport *tp = packet->transport;
90017accff61ae Marcelo Ricardo Leitner 2016-06-02 77 struct sctp_association *asoc = tp->asoc;
feddd6c1af30ab Marcelo Ricardo Leitner 2018-04-26 78 struct sctp_sock *sp = NULL;
df2729c3238ed8 Xin Long 2017-04-01 79 struct sock *sk;
^1da177e4c3f41 Linus Torvalds 2005-04-16 80
bb33381d0c97cd Daniel Borkmann 2013-06-28 81 pr_debug("%s: packet:%p vtag:0x%x\n", __func__, packet, vtag);
^1da177e4c3f41 Linus Torvalds 2005-04-16 82 packet->vtag = vtag;
^1da177e4c3f41 Linus Torvalds 2005-04-16 83
df2729c3238ed8 Xin Long 2017-04-01 84 /* do the following jobs only once for a flush schedule */
df2729c3238ed8 Xin Long 2017-04-01 85 if (!sctp_packet_empty(packet))
df2729c3238ed8 Xin Long 2017-04-01 86 return;
90017accff61ae Marcelo Ricardo Leitner 2016-06-02 87
b7e10c25b839c0 Richard Haines 2018-02-24 88 /* set packet max_size with pathmtu, then calculate overhead */
90017accff61ae Marcelo Ricardo Leitner 2016-06-02 89 packet->max_size = tp->pathmtu;
feddd6c1af30ab Marcelo Ricardo Leitner 2018-04-26 90
b7e10c25b839c0 Richard Haines 2018-02-24 91 if (asoc) {
feddd6c1af30ab Marcelo Ricardo Leitner 2018-04-26 92 sk = asoc->base.sk;
feddd6c1af30ab Marcelo Ricardo Leitner 2018-04-26 93 sp = sctp_sk(sk);
feddd6c1af30ab Marcelo Ricardo Leitner 2018-04-26 94 }
feddd6c1af30ab Marcelo Ricardo Leitner 2018-04-26 95 packet->overhead = sctp_mtu_payload(sp, 0, 0);
feddd6c1af30ab Marcelo Ricardo Leitner 2018-04-26 96 packet->size = packet->overhead;
b7e10c25b839c0 Richard Haines 2018-02-24 97
feddd6c1af30ab Marcelo Ricardo Leitner 2018-04-26 98 if (!asoc)
df2729c3238ed8 Xin Long 2017-04-01 99 return;
90017accff61ae Marcelo Ricardo Leitner 2016-06-02 100
df2729c3238ed8 Xin Long 2017-04-01 101 /* update dst or transport pathmtu if in need */
df2729c3238ed8 Xin Long 2017-04-01 102 if (!sctp_transport_dst_check(tp)) {
feddd6c1af30ab Marcelo Ricardo Leitner 2018-04-26 103 sctp_transport_route(tp, NULL, sp);
df2729c3238ed8 Xin Long 2017-04-01 104 if (asoc->param_flags & SPP_PMTUD_ENABLE)
3ebfdf082184d0 Xin Long 2017-04-04 105 sctp_assoc_sync_pmtu(asoc);
7307e4fa4d295f Xin Long 2021-06-22 106 } else if (!sctp_transport_pl_enabled(tp) &&
e6927d4d69af5f Xin Long 2021-07-21 107 asoc->param_flags & SPP_PMTUD_ENABLE)
e6927d4d69af5f Xin Long 2021-07-21 108 if (!sctp_transport_pmtu_check(tp))
69fec325a64383 Xin Long 2018-11-18 109 sctp_assoc_sync_pmtu(asoc);
df2729c3238ed8 Xin Long 2017-04-01 110 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 111
d805397c3822d5 Xin Long 2018-10-15 112 if (asoc->pmtu_pending) {
d805397c3822d5 Xin Long 2018-10-15 113 if (asoc->param_flags & SPP_PMTUD_ENABLE)
d805397c3822d5 Xin Long 2018-10-15 114 sctp_assoc_sync_pmtu(asoc);
d805397c3822d5 Xin Long 2018-10-15 115 asoc->pmtu_pending = 0;
d805397c3822d5 Xin Long 2018-10-15 116 }
d805397c3822d5 Xin Long 2018-10-15 117
^1da177e4c3f41 Linus Torvalds 2005-04-16 118 /* If there a is a prepend chunk stick it on the list before
^1da177e4c3f41 Linus Torvalds 2005-04-16 119 * any other chunks get appended.
^1da177e4c3f41 Linus Torvalds 2005-04-16 120 */
df2729c3238ed8 Xin Long 2017-04-01 121 if (ecn_capable) {
df2729c3238ed8 Xin Long 2017-04-01 122 struct sctp_chunk *chunk = sctp_get_ecne_prepend(asoc);
df2729c3238ed8 Xin Long 2017-04-01 123
^1da177e4c3f41 Linus Torvalds 2005-04-16 124 if (chunk)
^1da177e4c3f41 Linus Torvalds 2005-04-16 125 sctp_packet_append_chunk(packet, chunk);
^1da177e4c3f41 Linus Torvalds 2005-04-16 126 }
df2729c3238ed8 Xin Long 2017-04-01 127
df2729c3238ed8 Xin Long 2017-04-01 128 if (!tp->dst)
df2729c3238ed8 Xin Long 2017-04-01 129 return;
df2729c3238ed8 Xin Long 2017-04-01 130
df2729c3238ed8 Xin Long 2017-04-01 131 /* set packet max_size with gso_max_size if gso is enabled*/
df2729c3238ed8 Xin Long 2017-04-01 @132 rcu_read_lock();
df2729c3238ed8 Xin Long 2017-04-01 133 if (__sk_dst_get(sk) != tp->dst) {
df2729c3238ed8 Xin Long 2017-04-01 134 dst_hold(tp->dst);
df2729c3238ed8 Xin Long 2017-04-01 135 sk_setup_caps(sk, tp->dst);
df2729c3238ed8 Xin Long 2017-04-01 136 }
df2729c3238ed8 Xin Long 2017-04-01 137 packet->max_size = sk_can_gso(sk) ? tp->dst->dev->gso_max_size
df2729c3238ed8 Xin Long 2017-04-01 138 : asoc->pathmtu;
df2729c3238ed8 Xin Long 2017-04-01 139 rcu_read_unlock();
^1da177e4c3f41 Linus Torvalds 2005-04-16 140 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 141
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 2 months
Re: [PATCH 2/4] scsi: sd: add concurrent positioning ranges support
by Dan Carpenter
Hi Damien,
url: https://github.com/0day-ci/linux/commits/Damien-Le-Moal/Initial-support-f...
base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
config: x86_64-randconfig-m001-20210720 (attached as .config)
compiler: gcc-10 (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
smatch warnings:
drivers/scsi/sd.c:3204 sd_read_cpr() error: uninitialized symbol 'buffer'.
vim +/buffer +3204 drivers/scsi/sd.c
331fc9cf44c011 Damien Le Moal 2021-07-21 3137 static void sd_read_cpr(struct scsi_disk *sdkp)
331fc9cf44c011 Damien Le Moal 2021-07-21 3138 {
331fc9cf44c011 Damien Le Moal 2021-07-21 3139 unsigned char *buffer, *desc;
^^^^^^
331fc9cf44c011 Damien Le Moal 2021-07-21 3140 struct blk_cranges *cr = NULL;
331fc9cf44c011 Damien Le Moal 2021-07-21 3141 unsigned int nr_cpr = 0;
331fc9cf44c011 Damien Le Moal 2021-07-21 3142 int i, vpd_len, buf_len = SD_BUF_SIZE;
331fc9cf44c011 Damien Le Moal 2021-07-21 3143
331fc9cf44c011 Damien Le Moal 2021-07-21 3144 /*
331fc9cf44c011 Damien Le Moal 2021-07-21 3145 * We need to have the capacity set first for the block layer to be
331fc9cf44c011 Damien Le Moal 2021-07-21 3146 * able to check the ranges.
331fc9cf44c011 Damien Le Moal 2021-07-21 3147 */
331fc9cf44c011 Damien Le Moal 2021-07-21 3148 if (sdkp->first_scan)
331fc9cf44c011 Damien Le Moal 2021-07-21 3149 return;
331fc9cf44c011 Damien Le Moal 2021-07-21 3150
331fc9cf44c011 Damien Le Moal 2021-07-21 3151 if (!sdkp->capacity)
331fc9cf44c011 Damien Le Moal 2021-07-21 3152 goto out;
^^^^^^^^^
This should just return probably?
331fc9cf44c011 Damien Le Moal 2021-07-21 3153
331fc9cf44c011 Damien Le Moal 2021-07-21 3154 /*
331fc9cf44c011 Damien Le Moal 2021-07-21 3155 * Concurrent Positioning Ranges VPD: there can be at most 256 ranges,
331fc9cf44c011 Damien Le Moal 2021-07-21 3156 * leading to a maximum page size of 64 + 256*32 bytes.
331fc9cf44c011 Damien Le Moal 2021-07-21 3157 */
331fc9cf44c011 Damien Le Moal 2021-07-21 3158 buf_len = 64 + 256*32;
331fc9cf44c011 Damien Le Moal 2021-07-21 3159 buffer = kmalloc(buf_len, GFP_KERNEL);
331fc9cf44c011 Damien Le Moal 2021-07-21 3160 if (!buffer || scsi_get_vpd_page(sdkp->device, 0xb9, buffer, buf_len))
331fc9cf44c011 Damien Le Moal 2021-07-21 3161 goto out;
331fc9cf44c011 Damien Le Moal 2021-07-21 3162
331fc9cf44c011 Damien Le Moal 2021-07-21 3163 /* We must have at least a 64B header and one 32B range descriptor */
331fc9cf44c011 Damien Le Moal 2021-07-21 3164 vpd_len = get_unaligned_be16(&buffer[2]) + 3;
331fc9cf44c011 Damien Le Moal 2021-07-21 3165 if (vpd_len > buf_len || vpd_len < 64 + 32 || (vpd_len & 31)) {
331fc9cf44c011 Damien Le Moal 2021-07-21 3166 sd_printk(KERN_ERR, sdkp,
331fc9cf44c011 Damien Le Moal 2021-07-21 3167 "Invalid Concurrent Positioning Ranges VPD page\n");
331fc9cf44c011 Damien Le Moal 2021-07-21 3168 goto out;
331fc9cf44c011 Damien Le Moal 2021-07-21 3169 }
331fc9cf44c011 Damien Le Moal 2021-07-21 3170
331fc9cf44c011 Damien Le Moal 2021-07-21 3171 nr_cpr = (vpd_len - 64) / 32;
331fc9cf44c011 Damien Le Moal 2021-07-21 3172 if (nr_cpr == 1) {
331fc9cf44c011 Damien Le Moal 2021-07-21 3173 nr_cpr = 0;
331fc9cf44c011 Damien Le Moal 2021-07-21 3174 goto out;
331fc9cf44c011 Damien Le Moal 2021-07-21 3175 }
331fc9cf44c011 Damien Le Moal 2021-07-21 3176
331fc9cf44c011 Damien Le Moal 2021-07-21 3177 cr = blk_alloc_cranges(sdkp->disk, nr_cpr);
331fc9cf44c011 Damien Le Moal 2021-07-21 3178 if (!cr) {
331fc9cf44c011 Damien Le Moal 2021-07-21 3179 nr_cpr = 0;
331fc9cf44c011 Damien Le Moal 2021-07-21 3180 goto out;
331fc9cf44c011 Damien Le Moal 2021-07-21 3181 }
331fc9cf44c011 Damien Le Moal 2021-07-21 3182
331fc9cf44c011 Damien Le Moal 2021-07-21 3183 desc = &buffer[64];
331fc9cf44c011 Damien Le Moal 2021-07-21 3184 for (i = 0; i < nr_cpr; i++, desc += 32) {
331fc9cf44c011 Damien Le Moal 2021-07-21 3185 if (desc[0] != i) {
331fc9cf44c011 Damien Le Moal 2021-07-21 3186 sd_printk(KERN_ERR, sdkp,
331fc9cf44c011 Damien Le Moal 2021-07-21 3187 "Invalid Concurrent Positioning Range number\n");
331fc9cf44c011 Damien Le Moal 2021-07-21 3188 nr_cpr = 0;
331fc9cf44c011 Damien Le Moal 2021-07-21 3189 break;
331fc9cf44c011 Damien Le Moal 2021-07-21 3190 }
331fc9cf44c011 Damien Le Moal 2021-07-21 3191
331fc9cf44c011 Damien Le Moal 2021-07-21 3192 cr->ranges[i].sector = sd64_to_sectors(sdkp, desc + 8);
331fc9cf44c011 Damien Le Moal 2021-07-21 3193 cr->ranges[i].nr_sectors = sd64_to_sectors(sdkp, desc + 16);
331fc9cf44c011 Damien Le Moal 2021-07-21 3194 }
331fc9cf44c011 Damien Le Moal 2021-07-21 3195
331fc9cf44c011 Damien Le Moal 2021-07-21 3196 out:
331fc9cf44c011 Damien Le Moal 2021-07-21 3197 blk_queue_set_cranges(sdkp->disk, cr);
331fc9cf44c011 Damien Le Moal 2021-07-21 3198 if (nr_cpr && sdkp->nr_actuators != nr_cpr) {
331fc9cf44c011 Damien Le Moal 2021-07-21 3199 sd_printk(KERN_NOTICE, sdkp,
331fc9cf44c011 Damien Le Moal 2021-07-21 3200 "%u concurrent positioning ranges\n", nr_cpr);
331fc9cf44c011 Damien Le Moal 2021-07-21 3201 sdkp->nr_actuators = nr_cpr;
331fc9cf44c011 Damien Le Moal 2021-07-21 3202 }
331fc9cf44c011 Damien Le Moal 2021-07-21 3203
331fc9cf44c011 Damien Le Moal 2021-07-21 @3204 kfree(buffer);
^^^^^^^^^^^^^
331fc9cf44c011 Damien Le Moal 2021-07-21 3205 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 2 months
Audio Transcription Service Provider
by George Scott
Hello,
Do you need someone reliable to transcribe both your short term and
long term projects? Or do you need an accurate transcript for your
audio or video?
Allow us to transcribe your audio and provide you accurate transcripts
and let us help you reach your business/project goals through the help
of our transcription services.
What are our goals with each transcript?
Speed
Accuracy
Confidentiality
Each transcript is properly formatted. Strict grammar and punctuation
rules are adhered to and of course, file security is something we take
very seriously.
Have any transcription queries? Send me a message. Let's discuss what
you need to get done. We will address any concerns you have.
- Professional transcription
- Accurate and thorough
- Beautifully transcribed documents.
- Grammar, spelling and jargon thoroughly checked
We have transcribed within most industries:
Medical transcription
Technological
Academic
Lectures
Business
Groups
Legal
Research interviews
more...
Skilled with international accents and prompt response. Our pricing is
better or comparable to individual service provider. In addition we
also assist in APA Style formatting for research papers. Please note
we don’t conduct research but assist only in formatting of the papers.
You can contact us by replying to this email or directly writing back
to us on info(a)zukovi.info or through our website www.zukovi.info
contact us form as well.
Regards,
George Scott
www.zukovi.info
http://zukovi.info/mailsoft/unsubscribe.php?M=967416&C=748a027e93f2839ced...
1 year, 2 months
Re: [net,v6] net: stmmac: fix 'ethtool -P' return -EBUSY
by kernel test robot
Hi Hao,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.14-rc2 next-20210721]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Hao-Chen/net-stmmac-fix-ethtool-...
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 8cae8cd89f05f6de223d63e6d15e31c8ba9cf53b
config: nios2-allyesconfig (attached as .config)
compiler: nios2-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/c55b4adeb427ae7db9fb2942a7bc7958a...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Hao-Chen/net-stmmac-fix-ethtool-P-return-EBUSY/20210721-172413
git checkout c55b4adeb427ae7db9fb2942a7bc7958a8d667bd
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=nios2
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c: In function 'stmmac_ethtool_begin':
>> drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c:418:35: error: passing argument 1 of 'pm_runtime_resume_and_get' from incompatible pointer type [-Werror=incompatible-pointer-types]
418 | return pm_runtime_resume_and_get(dev);
| ^~~
| |
| struct net_device *
In file included from drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c:17:
include/linux/pm_runtime.h:400:60: note: expected 'struct device *' but argument is of type 'struct net_device *'
400 | static inline int pm_runtime_resume_and_get(struct device *dev)
| ~~~~~~~~~~~~~~~^~~
drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c:416:22: warning: unused variable 'priv' [-Wunused-variable]
416 | struct stmmac_priv *priv = netdev_priv(dev);
| ^~~~
cc1: some warnings being treated as errors
vim +/pm_runtime_resume_and_get +418 drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
413
414 static int stmmac_ethtool_begin(struct net_device *dev)
415 {
416 struct stmmac_priv *priv = netdev_priv(dev);
417
> 418 return pm_runtime_resume_and_get(dev);
419 }
420
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 2 months
Re: [net,v6] net: stmmac: fix 'ethtool -P' return -EBUSY
by kernel test robot
Hi Hao,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.14-rc2 next-20210721]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Hao-Chen/net-stmmac-fix-ethtool-...
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 8cae8cd89f05f6de223d63e6d15e31c8ba9cf53b
config: arm64-randconfig-r022-20210720 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project c781eb153bfbd1b52b03efe34f56bbeccbb8aba6)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/0day-ci/linux/commit/c55b4adeb427ae7db9fb2942a7bc7958a...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Hao-Chen/net-stmmac-fix-ethtool-P-return-EBUSY/20210721-172413
git checkout c55b4adeb427ae7db9fb2942a7bc7958a8d667bd
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c:378:7: warning: variable 'mask' set but not used [-Wunused-but-set-variable]
u32 mask = ADVERTISED_Autoneg | ADVERTISED_Pause;
^
>> drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c:418:35: error: incompatible pointer types passing 'struct net_device *' to parameter of type 'struct device *' [-Werror,-Wincompatible-pointer-types]
return pm_runtime_resume_and_get(dev);
^~~
include/linux/pm_runtime.h:400:60: note: passing argument to parameter 'dev' here
static inline int pm_runtime_resume_and_get(struct device *dev)
^
drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c:416:22: warning: unused variable 'priv' [-Wunused-variable]
struct stmmac_priv *priv = netdev_priv(dev);
^
2 warnings and 1 error generated.
vim +418 drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
413
414 static int stmmac_ethtool_begin(struct net_device *dev)
415 {
416 struct stmmac_priv *priv = netdev_priv(dev);
417
> 418 return pm_runtime_resume_and_get(dev);
419 }
420
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 2 months
[agd5f:drm-next 156/217] drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5749:52: warning: variable 'timing_diff' is uninitialized when used here
by kernel test robot
tree: https://gitlab.freedesktop.org/agd5f/linux.git drm-next
head: e37e31def0dab2c3a5a97044d484382671517cf4
commit: efeedd3b1a2b06077745fc0a287bc84784bd359a [156/217] drm/amd/display: Add common rates of vide mode matching for freesync_video_mode
config: powerpc-buildonly-randconfig-r003-20210720 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project c781eb153bfbd1b52b03efe34f56bbeccbb8aba6)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install powerpc cross compiling tool for clang build
# apt-get install binutils-powerpc-linux-gnu
git remote add agd5f https://gitlab.freedesktop.org/agd5f/linux.git
git fetch --no-tags agd5f drm-next
git checkout efeedd3b1a2b06077745fc0a287bc84784bd359a
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
In file included from drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:29:
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dm_services_types.h:29:
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/os_types.h:30:
In file included from include/linux/kgdb.h:18:
In file included from include/linux/atomic.h:7:
In file included from arch/powerpc/include/asm/atomic.h:11:
In file included from arch/powerpc/include/asm/cmpxchg.h:8:
In file included from include/linux/bug.h:5:
In file included from arch/powerpc/include/asm/bug.h:109:
In file included from include/asm-generic/bug.h:20:
In file included from include/linux/kernel.h:12:
In file included from include/linux/bitops.h:32:
In file included from arch/powerpc/include/asm/bitops.h:62:
arch/powerpc/include/asm/barrier.h:49:9: warning: '__lwsync' macro redefined [-Wmacro-redefined]
#define __lwsync() __asm__ __volatile__ (stringify_in_c(LWSYNC) : : :"memory")
^
<built-in>:310:9: note: previous definition is here
#define __lwsync __builtin_ppc_lwsync
^
>> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5749:52: warning: variable 'timing_diff' is uninitialized when used here [-Wuninitialized]
high_mode->vsync_start - mode->vsync_start != timing_diff ||
^~~~~~~~~~~
include/linux/compiler.h:56:47: note: expanded from macro 'if'
#define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
^~~~
include/linux/compiler.h:58:52: note: expanded from macro '__trace_if_var'
#define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
^~~~
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5734:17: note: initialize the variable 'timing_diff' to silence this warning
int timing_diff;
^
= 0
2 warnings generated.
vim +/timing_diff +5749 drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c
a85ba00538cd4bb Nikola Cornij 2021-03-15 5714
efeedd3b1a2b060 Solomon Chiu 2021-07-19 5715 /* Standard FPS values
efeedd3b1a2b060 Solomon Chiu 2021-07-19 5716 *
efeedd3b1a2b060 Solomon Chiu 2021-07-19 5717 * 23.976 - TV/NTSC
efeedd3b1a2b060 Solomon Chiu 2021-07-19 5718 * 24 - Cinema
efeedd3b1a2b060 Solomon Chiu 2021-07-19 5719 * 25 - TV/PAL
efeedd3b1a2b060 Solomon Chiu 2021-07-19 5720 * 29.97 - TV/NTSC
efeedd3b1a2b060 Solomon Chiu 2021-07-19 5721 * 30 - TV/NTSC
efeedd3b1a2b060 Solomon Chiu 2021-07-19 5722 * 48 - Cinema HFR
efeedd3b1a2b060 Solomon Chiu 2021-07-19 5723 * 50 - TV/PAL
efeedd3b1a2b060 Solomon Chiu 2021-07-19 5724 * 60 - Commonly used
efeedd3b1a2b060 Solomon Chiu 2021-07-19 5725 * 48,72,96 - Multiples of 24
efeedd3b1a2b060 Solomon Chiu 2021-07-19 5726 */
efeedd3b1a2b060 Solomon Chiu 2021-07-19 5727 const uint32_t common_rates[] = { 23976, 24000, 25000, 29970, 30000,
efeedd3b1a2b060 Solomon Chiu 2021-07-19 5728 48000, 50000, 60000, 72000, 96000 };
efeedd3b1a2b060 Solomon Chiu 2021-07-19 5729
fe8858bb097ba34 Nikola Cornij 2021-03-26 5730 static bool is_freesync_video_mode(const struct drm_display_mode *mode,
a85ba00538cd4bb Nikola Cornij 2021-03-15 5731 struct amdgpu_dm_connector *aconnector)
a85ba00538cd4bb Nikola Cornij 2021-03-15 5732 {
a85ba00538cd4bb Nikola Cornij 2021-03-15 5733 struct drm_display_mode *high_mode;
a85ba00538cd4bb Nikola Cornij 2021-03-15 5734 int timing_diff;
efeedd3b1a2b060 Solomon Chiu 2021-07-19 5735 int i;
a85ba00538cd4bb Nikola Cornij 2021-03-15 5736
a85ba00538cd4bb Nikola Cornij 2021-03-15 5737 high_mode = get_highest_refresh_rate_mode(aconnector, false);
a85ba00538cd4bb Nikola Cornij 2021-03-15 5738 if (!high_mode || !mode)
a85ba00538cd4bb Nikola Cornij 2021-03-15 5739 return false;
a85ba00538cd4bb Nikola Cornij 2021-03-15 5740
a85ba00538cd4bb Nikola Cornij 2021-03-15 5741 if (high_mode->clock == 0 || high_mode->clock != mode->clock ||
a85ba00538cd4bb Nikola Cornij 2021-03-15 5742 high_mode->hdisplay != mode->hdisplay ||
a85ba00538cd4bb Nikola Cornij 2021-03-15 5743 high_mode->vdisplay != mode->vdisplay ||
a85ba00538cd4bb Nikola Cornij 2021-03-15 5744 high_mode->hsync_start != mode->hsync_start ||
a85ba00538cd4bb Nikola Cornij 2021-03-15 5745 high_mode->hsync_end != mode->hsync_end ||
a85ba00538cd4bb Nikola Cornij 2021-03-15 5746 high_mode->htotal != mode->htotal ||
a85ba00538cd4bb Nikola Cornij 2021-03-15 5747 high_mode->hskew != mode->hskew ||
a85ba00538cd4bb Nikola Cornij 2021-03-15 5748 high_mode->vscan != mode->vscan ||
a85ba00538cd4bb Nikola Cornij 2021-03-15 @5749 high_mode->vsync_start - mode->vsync_start != timing_diff ||
a85ba00538cd4bb Nikola Cornij 2021-03-15 5750 high_mode->vsync_end - mode->vsync_end != timing_diff)
a85ba00538cd4bb Nikola Cornij 2021-03-15 5751 return false;
efeedd3b1a2b060 Solomon Chiu 2021-07-19 5752
efeedd3b1a2b060 Solomon Chiu 2021-07-19 5753 for (i = 0; i < ARRAY_SIZE(common_rates); i++) {
efeedd3b1a2b060 Solomon Chiu 2021-07-19 5754 uint64_t target_vtotal, target_vtotal_diff;
efeedd3b1a2b060 Solomon Chiu 2021-07-19 5755 uint64_t num, den;
efeedd3b1a2b060 Solomon Chiu 2021-07-19 5756
efeedd3b1a2b060 Solomon Chiu 2021-07-19 5757 if (drm_mode_vrefresh(high_mode) * 1000 < common_rates[i])
efeedd3b1a2b060 Solomon Chiu 2021-07-19 5758 continue;
efeedd3b1a2b060 Solomon Chiu 2021-07-19 5759 if (common_rates[i] < aconnector->min_vfreq * 1000 ||
efeedd3b1a2b060 Solomon Chiu 2021-07-19 5760 common_rates[i] > aconnector->max_vfreq * 1000)
efeedd3b1a2b060 Solomon Chiu 2021-07-19 5761 continue;
efeedd3b1a2b060 Solomon Chiu 2021-07-19 5762 num = (unsigned long long)high_mode->clock * 1000 * 1000;
efeedd3b1a2b060 Solomon Chiu 2021-07-19 5763 den = common_rates[i] * (unsigned long long)high_mode->htotal;
efeedd3b1a2b060 Solomon Chiu 2021-07-19 5764 target_vtotal = div_u64(num, den);
efeedd3b1a2b060 Solomon Chiu 2021-07-19 5765 target_vtotal_diff = target_vtotal - high_mode->vtotal;
efeedd3b1a2b060 Solomon Chiu 2021-07-19 5766
efeedd3b1a2b060 Solomon Chiu 2021-07-19 5767 if ((mode->vtotal - target_vtotal_diff) == high_mode->vtotal)
a85ba00538cd4bb Nikola Cornij 2021-03-15 5768 return true;
a85ba00538cd4bb Nikola Cornij 2021-03-15 5769 }
a85ba00538cd4bb Nikola Cornij 2021-03-15 5770
efeedd3b1a2b060 Solomon Chiu 2021-07-19 5771 return false;
efeedd3b1a2b060 Solomon Chiu 2021-07-19 5772 }
efeedd3b1a2b060 Solomon Chiu 2021-07-19 5773
:::::: The code at line 5749 was first introduced by commit
:::::: a85ba00538cd4bb0655aaf57fe3ebf8cc21f4fea drm/amdgpu/display: re-enable freesync video patches
:::::: TO: Nikola Cornij <nikola.cornij(a)amd.com>
:::::: CC: Alex Deucher <alexander.deucher(a)amd.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 2 months