Re: [PATCH 3/3] fsi: occ: Add dynamic debug to dump command and response
by kernel test robot
Hi Eddie,
I love your patch! Yet something to improve:
[auto build test ERROR on hwmon/hwmon-next]
[also build test ERROR on linus/master v5.14-rc2 next-20210716]
[cannot apply to linux/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Eddie-James/OCC-fsi-and-hwmon-Se...
base: https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
config: csky-randconfig-r014-20210718 (attached as .config)
compiler: csky-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/2501575bac95640481d86c6d27cd67505...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Eddie-James/OCC-fsi-and-hwmon-Set-sequence-number-in-submit-interface/20210718-103535
git checkout 2501575bac95640481d86c6d27cd675055987aa8
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=csky
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
drivers/fsi/fsi-occ.c: In function 'occ_putsram':
>> drivers/fsi/fsi-occ.c:372:3: error: implicit declaration of function 'DEFINE_DYNAMIC_DEBUG_METADATA' [-Werror=implicit-function-declaration]
372 | DEFINE_DYNAMIC_DEBUG_METADATA(ddm_occ_cmd, "OCC command");
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/fsi/fsi-occ.c:372:33: error: 'ddm_occ_cmd' undeclared (first use in this function)
372 | DEFINE_DYNAMIC_DEBUG_METADATA(ddm_occ_cmd, "OCC command");
| ^~~~~~~~~~~
drivers/fsi/fsi-occ.c:372:33: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/fsi/fsi-occ.c:374:7: error: implicit declaration of function 'DYNAMIC_DEBUG_BRANCH' [-Werror=implicit-function-declaration]
374 | if (DYNAMIC_DEBUG_BRANCH(ddm_occ_cmd)) {
| ^~~~~~~~~~~~~~~~~~~~
drivers/fsi/fsi-occ.c: In function 'fsi_occ_submit':
>> drivers/fsi/fsi-occ.c:584:33: error: 'ddm_occ_rsp' undeclared (first use in this function)
584 | DEFINE_DYNAMIC_DEBUG_METADATA(ddm_occ_rsp,
| ^~~~~~~~~~~
>> drivers/fsi/fsi-occ.c:586:33: error: 'ddm_occ_full_rsp' undeclared (first use in this function)
586 | DEFINE_DYNAMIC_DEBUG_METADATA(ddm_occ_full_rsp,
| ^~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/DEFINE_DYNAMIC_DEBUG_METADATA +372 drivers/fsi/fsi-occ.c
315
316 static int occ_putsram(struct occ *occ, const void *data, ssize_t len,
317 u8 seq_no, u16 checksum)
318 {
319 size_t cmd_len, buf_len, resp_len, resp_data_len;
320 u32 data_len = ((len + 7) / 8) * 8; /* must be multiples of 8 B */
321 __be32 *buf;
322 u8 *byte_buf;
323 int idx = 0, rc;
324
325 cmd_len = (occ->version == occ_p10) ? 6 : 5;
326
327 /*
328 * We use the same buffer for command and response, make
329 * sure it's big enough
330 */
331 resp_len = OCC_SBE_STATUS_WORDS;
332 cmd_len += data_len >> 2;
333 buf_len = max(cmd_len, resp_len);
334 buf = kzalloc(buf_len << 2, GFP_KERNEL);
335 if (!buf)
336 return -ENOMEM;
337
338 /*
339 * Magic sequence to do SBE putsram command. SBE will transfer
340 * data to specified SRAM address.
341 */
342 buf[0] = cpu_to_be32(cmd_len);
343 buf[1] = cpu_to_be32(SBEFIFO_CMD_PUT_OCC_SRAM);
344
345 switch (occ->version) {
346 default:
347 case occ_p9:
348 buf[2] = cpu_to_be32(1); /* Normal mode */
349 buf[3] = cpu_to_be32(OCC_P9_SRAM_CMD_ADDR);
350 break;
351 case occ_p10:
352 idx = 1;
353 buf[2] = cpu_to_be32(OCC_P10_SRAM_MODE);
354 buf[3] = 0;
355 buf[4] = cpu_to_be32(OCC_P10_SRAM_CMD_ADDR);
356 break;
357 }
358
359 buf[4 + idx] = cpu_to_be32(data_len);
360 memcpy(&buf[5 + idx], data, len);
361
362 byte_buf = (u8 *)&buf[5 + idx];
363 /*
364 * Overwrite the first byte with our sequence number and the last two
365 * bytes with the checksum.
366 */
367 byte_buf[0] = seq_no;
368 byte_buf[len - 2] = checksum >> 8;
369 byte_buf[len - 1] = checksum & 0xff;
370
371 {
> 372 DEFINE_DYNAMIC_DEBUG_METADATA(ddm_occ_cmd, "OCC command");
373
> 374 if (DYNAMIC_DEBUG_BRANCH(ddm_occ_cmd)) {
375 char prefix[64];
376
377 snprintf(prefix, sizeof(prefix), "%s %s: cmd ",
378 dev_driver_string(occ->dev),
379 dev_name(occ->dev));
380 print_hex_dump(KERN_DEBUG, prefix, DUMP_PREFIX_OFFSET,
381 16, 4, byte_buf, len, false);
382 }
383 }
384
385 rc = sbefifo_submit(occ->sbefifo, buf, cmd_len, buf, &resp_len);
386 if (rc)
387 goto free;
388
389 rc = sbefifo_parse_status(occ->sbefifo, SBEFIFO_CMD_PUT_OCC_SRAM,
390 buf, resp_len, &resp_len);
391 if (rc)
392 goto free;
393
394 if (resp_len != 1) {
395 dev_err(occ->dev, "SRAM write response length invalid: %zd\n",
396 resp_len);
397 rc = -EBADMSG;
398 } else {
399 resp_data_len = be32_to_cpu(buf[0]);
400 if (resp_data_len != data_len) {
401 dev_err(occ->dev,
402 "SRAM write expected %d bytes got %zd\n",
403 data_len, resp_data_len);
404 rc = -EBADMSG;
405 }
406 }
407
408 free:
409 /* Convert positive SBEI status */
410 if (rc > 0) {
411 dev_err(occ->dev, "SRAM write returned failure status: %08x\n",
412 rc);
413 rc = -EBADMSG;
414 }
415
416 kfree(buf);
417 return rc;
418 }
419
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 2 months
[frank-w-bpi-r2-4.14:5.14-hdmilarb2 42/48] drivers/iommu/of_iommu.c:30:53: warning: cast from pointer to integer of different size
by kernel test robot
tree: https://github.com/frank-w/BPI-R2-4.14 5.14-hdmilarb2
head: 77b4c96140f9bec5bb54fc804b401af1c9a6b4b5
commit: a03e47787fdf1b8cf17dff02113ca385b4aaa131 [42/48] iommu, more debug
config: alpha-randconfig-r022-20210718 (attached as .config)
compiler: alpha-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/frank-w/BPI-R2-4.14/commit/a03e47787fdf1b8cf17dff02113...
git remote add frank-w-bpi-r2-4.14 https://github.com/frank-w/BPI-R2-4.14
git fetch --no-tags frank-w-bpi-r2-4.14 5.14-hdmilarb2
git checkout a03e47787fdf1b8cf17dff02113ca385b4aaa131
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=alpha
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
In file included from include/linux/device.h:15,
from include/linux/iommu.h:11,
from drivers/iommu/of_iommu.c:9:
include/linux/iommu.h: In function 'dev_iommu_fwspec_set':
include/linux/iommu.h:576:51: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
576 | dev_err(dev,"%s:%d 0x%08x",__FUNCTION__,__LINE__,(unsigned int)fwspec);
| ^
include/linux/dev_printk.h:112:32: note: in definition of macro 'dev_err'
112 | _dev_err(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~
drivers/iommu/of_iommu.c: In function 'of_iommu_xlate':
>> drivers/iommu/of_iommu.c:30:53: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
30 | dev_err(dev,"%s:%d ops:%08x",__FUNCTION__,__LINE__,(unsigned int)ops);
| ^
include/linux/dev_printk.h:112:32: note: in definition of macro 'dev_err'
112 | _dev_err(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~
drivers/iommu/of_iommu.c:32:56: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
32 | dev_err(dev,"%s:%d xlate:%08x",__FUNCTION__,__LINE__,(unsigned int)ops->of_xlate);
| ^
include/linux/dev_printk.h:112:32: note: in definition of macro 'dev_err'
112 | _dev_err(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~
vim +30 drivers/iommu/of_iommu.c
21
22 static int of_iommu_xlate(struct device *dev,
23 struct of_phandle_args *iommu_spec)
24 {
25 const struct iommu_ops *ops;
26 struct fwnode_handle *fwnode = &iommu_spec->np->fwnode;
27 int ret;
28
29 ops = iommu_ops_from_fwnode(fwnode);
> 30 dev_err(dev,"%s:%d ops:%08x",__FUNCTION__,__LINE__,(unsigned int)ops);
31 if (ops)
32 dev_err(dev,"%s:%d xlate:%08x",__FUNCTION__,__LINE__,(unsigned int)ops->of_xlate);
33
34 if ((ops && !ops->of_xlate) ||
35 !of_device_is_available(iommu_spec->np))
36 {
37 dev_err(dev,"no iommu");
38 return NO_IOMMU;
39 }
40 ret = iommu_fwspec_init(dev, &iommu_spec->np->fwnode, ops);
41 if (ret)
42 return ret;
43 /*
44 * The otherwise-empty fwspec handily serves to indicate the specific
45 * IOMMU device we're waiting for, which will be useful if we ever get
46 * a proper probe-ordering dependency mechanism in future.
47 */
48 if (!ops)
49 return driver_deferred_probe_check_state(dev);
50
51 if (!try_module_get(ops->owner))
52 return -ENODEV;
53
54 ret = ops->of_xlate(dev, iommu_spec);
55 module_put(ops->owner);
56 return ret;
57 }
58
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 2 months
[linux-chenxing:mstar_v5_14_rebase_i2_drm 98/349] drivers/iio/adc/msc313e_sar.c:473:64: warning: passing argument 3 of 'pinctrl_generic_add_group' discards 'const' qualifier from pointer target type
by kernel test robot
tree: git://github.com/linux-chenxing/linux.git mstar_v5_14_rebase_i2_drm
head: 93dfb2364436067bf34c6d4ddcd282496182cc0f
commit: fb1c5e9b61a43058147812d252a62c2451709ffe [98/349] ARM:mstar: SAR adc driver
config: s390-allyesconfig (attached as .config)
compiler: s390-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/linux-chenxing/linux/commit/fb1c5e9b61a43058147812d252...
git remote add linux-chenxing git://github.com/linux-chenxing/linux.git
git fetch --no-tags linux-chenxing mstar_v5_14_rebase_i2_drm
git checkout fb1c5e9b61a43058147812d252a62c2451709ffe
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=s390
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
drivers/iio/adc/msc313e_sar.c: In function 'msc313e_sar_probe_pinctrl':
>> drivers/iio/adc/msc313e_sar.c:473:64: warning: passing argument 3 of 'pinctrl_generic_add_group' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
473 | ret = pinctrl_generic_add_group(sar->pinctrl_dev, grp->name, &grp->pin,
| ^~~~~~~~~
In file included from drivers/iio/adc/msc313e_sar.c:25:
drivers/iio/adc/../../pinctrl/core.h:215:15: note: expected 'int *' but argument is of type 'const int *'
215 | int *gpins, int ngpins, void *data);
| ~~~~~^~~~~
>> drivers/iio/adc/msc313e_sar.c:480:5: warning: passing argument 3 of 'pinmux_generic_add_function' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
480 | &func->group, 1, func);
| ^~~~~~~~~~~~
In file included from drivers/iio/adc/msc313e_sar.c:27:
drivers/iio/adc/../../pinctrl/pinmux.h:153:18: note: expected 'const char **' but argument is of type 'const char * const*'
153 | const char **groups,
| ~~~~~~~~~~~~~^~~~~~
drivers/iio/adc/msc313e_sar.c:480:22: warning: passing argument 5 of 'pinmux_generic_add_function' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
480 | &func->group, 1, func);
| ^~~~
In file included from drivers/iio/adc/msc313e_sar.c:27:
drivers/iio/adc/../../pinctrl/pinmux.h:155:11: note: expected 'void *' but argument is of type 'const struct sar_pinctrl_function *'
155 | void *data);
| ~~~~~~^~~~
drivers/iio/adc/msc313e_sar.c: In function 'msc313e_sar_probe':
>> drivers/iio/adc/msc313e_sar.c:502:13: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
502 | match_data = of_device_get_match_data(&pdev->dev);
| ^
drivers/iio/adc/msc313e_sar.c:615:1: warning: label 'out' defined but not used [-Wunused-label]
615 | out:
| ^~~
vim +473 drivers/iio/adc/msc313e_sar.c
444
445 static int msc313e_sar_probe_pinctrl(struct platform_device *pdev,
446 struct msc313e_sar *sar) {
447 int i, ret;
448
449 sar->gpio_range.name = "sar";
450 sar->gpio_range.id = 0;
451 sar->gpio_range.base = sar->gpiochip.base;
452 sar->gpio_range.pins = sar->info->rangepins;
453 sar->gpio_range.npins = sar->info->nrangepins;
454 sar->gpio_range.gc = &sar->gpiochip;
455
456 sar->pinctrl_desc.name = DRIVER_NAME;
457 sar->pinctrl_desc.pctlops = &sar_pinctrl_ops;
458 sar->pinctrl_desc.pmxops = &sar_pinmux_ops;
459 sar->pinctrl_desc.owner = THIS_MODULE;
460 sar->pinctrl_desc.pins = sar->info->pins;
461 sar->pinctrl_desc.npins = sar->info->npins;
462
463 ret = devm_pinctrl_register_and_init(&pdev->dev, &sar->pinctrl_desc, sar,
464 &sar->pinctrl_dev);
465
466 if (ret) {
467 dev_err(&pdev->dev, "failed to register pinctrl\n");
468 return ret;
469 }
470
471 for (i = 0; i < sar->info->ngroups; i++) {
472 const struct sar_pinctrl_group *grp = &sar->info->groups[i];
> 473 ret = pinctrl_generic_add_group(sar->pinctrl_dev, grp->name, &grp->pin,
474 1, NULL);
475 }
476
477 for (i = 0; i < ARRAY_SIZE(sar_pinctrl_functions); i++) {
478 const struct sar_pinctrl_function *func = &sar_pinctrl_functions[i];
479 ret = pinmux_generic_add_function(sar->pinctrl_dev, func->name,
> 480 &func->group, 1, func);
481
482 }
483
484 pinctrl_add_gpio_range(sar->pinctrl_dev, &sar->gpio_range);
485
486 ret = pinctrl_enable(sar->pinctrl_dev);
487 if (ret)
488 dev_err(&pdev->dev, "failed to enable pinctrl\n");
489
490 return ret;
491 }
492
493 static int msc313e_sar_probe(struct platform_device *pdev)
494 {
495 int ret = 0;
496 struct mstar_sar_info *match_data;
497 struct iio_dev *indio_dev;
498 struct msc313e_sar *sar;
499 __iomem void *base;
500 int irq;
501
> 502 match_data = of_device_get_match_data(&pdev->dev);
503 if (!match_data)
504 return -EINVAL;
505
506 indio_dev = devm_iio_device_alloc(&pdev->dev, sizeof(*sar));
507 if(!indio_dev)
508 return -ENOMEM;
509
510 sar = iio_priv(indio_dev);
511
512 sar->info = match_data;
513
514 base = devm_platform_ioremap_resource(pdev, 0);
515 if (IS_ERR(base))
516 return PTR_ERR(base);
517
518 sar->regmap = devm_regmap_init_mmio(&pdev->dev, base,
519 &msc313_sar_regmap_config);
520 if (IS_ERR(sar->regmap)) {
521 dev_err(&pdev->dev, "failed to register regmap");
522 return PTR_ERR(sar->regmap);
523 }
524
525 sar->pmsleep = syscon_regmap_lookup_by_phandle(pdev->dev.of_node, "mstar,pmsleep");
526 if (IS_ERR(sar->pmsleep))
527 return PTR_ERR(sar->pmsleep);
528
529 sar->field_load = devm_regmap_field_alloc(&pdev->dev, sar->regmap, ctrl_load_field);
530 sar->field_freerun = devm_regmap_field_alloc(&pdev->dev, sar->regmap, ctrl_freerun_field);
531 sar->field_analogpd = devm_regmap_field_alloc(&pdev->dev, sar->regmap, ctrl_analogpd_field);
532 sar->field_start = devm_regmap_field_alloc(&pdev->dev, sar->regmap, ctrl_start_field);
533 sar->field_digitalpd = devm_regmap_field_alloc(&pdev->dev, sar->regmap, ctrl_digitalpd_field);
534 sar->field_mode = devm_regmap_field_alloc(&pdev->dev, sar->regmap, ctrl_mode_field);
535 sar->field_singlech = devm_regmap_field_alloc(&pdev->dev, sar->regmap, ctrl_singlech_field);
536 sar->field_channel = devm_regmap_field_alloc(&pdev->dev, sar->regmap, ctrl_channel_field);
537
538 sar->field_gpio_en = devm_regmap_field_alloc(&pdev->dev, sar->regmap, gpio_ctrl_en_field);
539 sar->field_gpio_oen = devm_regmap_field_alloc(&pdev->dev, sar->regmap, gpio_ctrl_oen_field);
540 sar->field_gpio_value = devm_regmap_field_alloc(&pdev->dev, sar->regmap, gpio_data_value_field);
541 sar->field_gpio_in = devm_regmap_field_alloc(&pdev->dev, sar->regmap, gpio_data_in_field);
542 sar->field_vref_ts = devm_regmap_field_alloc(&pdev->dev, sar->regmap, vref_ts_field);
543
544 sar->clk = devm_clk_get(&pdev->dev, "sar_clk");
545 if (IS_ERR(sar->clk)) {
546 dev_err(&pdev->dev, "failed to get clk\n");
547 return PTR_ERR(sar->clk);
548 }
549
550 irq = of_irq_get_byname(pdev->dev.of_node, "sar");
551 if (!irq)
552 return -EINVAL;
553
554 ret = devm_request_irq(&pdev->dev, irq, msc313e_sar_irq, IRQF_SHARED,
555 dev_name(&pdev->dev), indio_dev);
556 if (ret)
557 return ret;
558
559 irq = of_irq_get_byname(pdev->dev.of_node, "wakeup");
560 if (!irq)
561 return -EINVAL;
562
563 ret = devm_request_irq(&pdev->dev, irq, msc313e_sar_irq, IRQF_SHARED,
564 dev_name(&pdev->dev), indio_dev);
565 if (ret)
566 return ret;
567
568 sar->wakeirq_gpio = of_irq_get_byname(pdev->dev.of_node, "wakeup_gpio");
569 if (!sar->wakeirq_gpio)
570 return -EINVAL;
571
572 ret = devm_request_irq(&pdev->dev, sar->wakeirq_gpio, msc313e_sar_irq, IRQF_SHARED,
573 dev_name(&pdev->dev), indio_dev);
574 if (ret)
575 return ret;
576
577 indio_dev->name = platform_get_device_id(pdev)->name;
578 indio_dev->dev.parent = &pdev->dev;
579 indio_dev->dev.of_node = pdev->dev.of_node;
580 indio_dev->modes = INDIO_DIRECT_MODE;
581 indio_dev->info = &msc313e_sar_iio_info;
582 indio_dev->num_channels = ARRAY_SIZE(msc313e_sar_channels);
583 indio_dev->channels = msc313e_sar_channels;
584
585 platform_set_drvdata(pdev, indio_dev);
586
587 ret = devm_iio_device_register(&pdev->dev, indio_dev);
588 if (ret)
589 return ret;
590
591 ret = msc313e_sar_probe_gpio(pdev, sar);
592 if (ret)
593 return ret;
594
595 ret = msc313e_sar_probe_pinctrl(pdev, sar);
596 if (ret)
597 return ret;
598
599 clk_prepare_enable(sar->clk);
600
601 regmap_write(sar->regmap, REG_SAMPLE_PERIOD, 0x0f);
602
603 regmap_write(sar->regmap, REG_INT_CLR, ~0);
604 regmap_write(sar->regmap, REG_INT_MASK, 0);
605
606 /* turn the adc on */
607 regmap_field_write(sar->field_analogpd, 0);
608 regmap_field_write(sar->field_digitalpd, 0);
609
610 /* set the temp sensor to 2.0v */
611 regmap_field_write(sar->field_vref_ts, 0);
612
613 device_init_wakeup(&pdev->dev, 1);
614
615 out:
616 return ret;
617 }
618
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 2 months
[hare-scsi-devel:auth.v4 9/11] configfs.c:undefined reference to `nvme_auth_hmac_id'
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git auth.v4
head: d22f44dbe36eb82041e9e28db6a767c55c8d790e
commit: e769c043ef13de88f29d8e2bb3ca0063b38e6883 [9/11] nvmet: Implement basic In-Band Authentication
config: riscv-randconfig-c004-20210718 (attached as .config)
compiler: riscv64-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git/commi...
git remote add hare-scsi-devel https://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git
git fetch --no-tags hare-scsi-devel auth.v4
git checkout e769c043ef13de88f29d8e2bb3ca0063b38e6883
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross O=build_dir ARCH=riscv SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
riscv64-linux-ld: drivers/nvme/target/configfs.o: in function `nvmet_host_dhchap_hash_store':
>> configfs.c:(.text+0x28): undefined reference to `nvme_auth_hmac_id'
>> riscv64-linux-ld: configfs.c:(.text+0x38): undefined reference to `nvme_auth_hmac_name'
riscv64-linux-ld: drivers/nvme/target/configfs.o: in function `nvmet_host_dhchap_hash_show':
>> configfs.c:(.text+0xa4): undefined reference to `nvme_auth_hmac_name'
riscv64-linux-ld: drivers/nvme/target/fabrics-cmd-auth.o: in function `.L36':
>> fabrics-cmd-auth.c:(.text+0xe0): undefined reference to `nvme_auth_hmac_id'
riscv64-linux-ld: drivers/nvme/target/auth.o: in function `.L0 ':
>> auth.c:(.text+0x54): undefined reference to `nvme_auth_hmac_name'
riscv64-linux-ld: drivers/nvme/target/auth.o: in function `.L23':
auth.c:(.text+0x1dc): undefined reference to `nvme_auth_hmac_name'
>> riscv64-linux-ld: auth.c:(.text+0x218): undefined reference to `nvme_auth_extract_secret'
>> riscv64-linux-ld: auth.c:(.text+0x234): undefined reference to `nvme_auth_hmac_name'
riscv64-linux-ld: drivers/nvme/target/auth.o: in function `nvmet_auth_ctrl_sesskey':
>> auth.c:(.text+0x9c4): undefined reference to `nvme_auth_dhgroup_privkey_size'
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 2 months
[linux-chenxing:mstar_v5_14_rebase_i2_drm 86/349] drivers/irqchip/irq-msc313-pm-intc.c:121:2: warning: ignoring return value of 'request_irq' declared with attribute 'warn_unused_result'
by kernel test robot
tree: git://github.com/linux-chenxing/linux.git mstar_v5_14_rebase_i2_drm
head: 93dfb2364436067bf34c6d4ddcd282496182cc0f
commit: 5ef6feadec2f32e387068db45021b52ef7154d4c [86/349] ARM: mstar: msc313 pm intc driver
config: s390-allyesconfig (attached as .config)
compiler: s390-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/linux-chenxing/linux/commit/5ef6feadec2f32e387068db450...
git remote add linux-chenxing git://github.com/linux-chenxing/linux.git
git fetch --no-tags linux-chenxing mstar_v5_14_rebase_i2_drm
git checkout 5ef6feadec2f32e387068db45021b52ef7154d4c
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=s390
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
drivers/irqchip/irq-msc313-pm-intc.c: In function 'msc313_sleep_intc_of_init':
>> drivers/irqchip/irq-msc313-pm-intc.c:121:2: warning: ignoring return value of 'request_irq' declared with attribute 'warn_unused_result' [-Wunused-result]
121 | request_irq(gicint, msc313_sleep_intc_chainedhandler, IRQF_SHARED,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
122 | "pmsleep", domain);
| ~~~~~~~~~~~~~~~~~~
vim +121 drivers/irqchip/irq-msc313-pm-intc.c
89
90 static int __init msc313_sleep_intc_of_init(struct device_node *node,
91 struct device_node *parent)
92 {
93 int gicint;
94 struct regmap *pmsleep;
95 struct msc313_sleep_intc *intc;
96 struct irq_domain *domain;
97 int ret;
98
99 gicint = of_irq_get(node, 0);
100 printk("gicint: %d\n", gicint);
101 if (gicint <= 0)
102 return gicint;
103
104 pmsleep = syscon_regmap_lookup_by_phandle(node, "mstar,pmsleep");
105 if(IS_ERR(pmsleep))
106 return PTR_ERR(pmsleep);
107
108 intc = kzalloc(sizeof(*intc), GFP_KERNEL);
109 if (!intc)
110 return -ENOMEM;
111
112 intc->pmsleep = pmsleep;
113
114 domain = irq_domain_add_linear(node, NUM_IRQ,
115 &msc313_pm_intc_domain_ops, intc);
116 if (!domain) {
117 ret = -ENOMEM;
118 goto out_free;
119 }
120
> 121 request_irq(gicint, msc313_sleep_intc_chainedhandler, IRQF_SHARED,
122 "pmsleep", domain);
123
124 return 0;
125
126 out_free:
127 kfree(intc);
128 return ret;
129 }
130
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 2 months
Re: [PATCH v2 01/12] KVM: x86: Report host tsc and realtime values in KVM_GET_CLOCK
by kernel test robot
Hi Oliver,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on kvm/queue]
[also build test WARNING on vhost/linux-next v5.14-rc1 next-20210716]
[cannot apply to kvmarm/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Oliver-Upton/KVM-Add-idempotent-...
base: https://git.kernel.org/pub/scm/virt/kvm/kvm.git queue
config: x86_64-rhel-8.3-kselftests (attached as .config)
compiler: gcc-10 (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.3-341-g8af24329-dirty
# https://github.com/0day-ci/linux/commit/72b6d584e6ac692038a7d70e8782f0dfa...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Oliver-Upton/KVM-Add-idempotent-controls-for-migrating-system-counter-state/20210718-103407
git checkout 72b6d584e6ac692038a7d70e8782f0dfa179e5fb
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> arch/x86/kvm/x86.c:2784: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* Returns true if realtime and TSC values were written back to the caller.
vim +2784 arch/x86/kvm/x86.c
2782
2783 /**
> 2784 * Returns true if realtime and TSC values were written back to the caller.
2785 * Returns false if a clock triplet cannot be obtained, such as if the host's
2786 * realtime clock is not based on the TSC.
2787 */
2788 static bool get_kvmclock_and_realtime(struct kvm *kvm, u64 *kvmclock_ns,
2789 u64 *realtime_ns, u64 *tsc)
2790 {
2791 struct kvm_arch *ka = &kvm->arch;
2792 struct pvclock_vcpu_time_info hv_clock;
2793 unsigned long flags;
2794 bool ret = false;
2795
2796 spin_lock_irqsave(&ka->pvclock_gtod_sync_lock, flags);
2797 if (!ka->use_master_clock) {
2798 spin_unlock_irqrestore(&ka->pvclock_gtod_sync_lock, flags);
2799 *kvmclock_ns = get_kvmclock_base_ns() + ka->kvmclock_offset;
2800 return false;
2801 }
2802
2803 hv_clock.tsc_timestamp = ka->master_cycle_now;
2804 hv_clock.system_time = ka->master_kernel_ns + ka->kvmclock_offset;
2805 spin_unlock_irqrestore(&ka->pvclock_gtod_sync_lock, flags);
2806
2807 /* both __this_cpu_read() and rdtsc() should be on the same cpu */
2808 get_cpu();
2809
2810 if (__this_cpu_read(cpu_tsc_khz)) {
2811 struct timespec64 ts;
2812 u64 tsc_val;
2813
2814 kvm_get_time_scale(NSEC_PER_SEC, __this_cpu_read(cpu_tsc_khz) * 1000LL,
2815 &hv_clock.tsc_shift,
2816 &hv_clock.tsc_to_system_mul);
2817
2818 if (kvm_get_walltime_and_clockread(&ts, &tsc_val)) {
2819 *realtime_ns = ts.tv_nsec + NSEC_PER_SEC * ts.tv_sec;
2820 *tsc = tsc_val;
2821 ret = true;
2822 }
2823
2824 *kvmclock_ns = __pvclock_read_cycles(&hv_clock, tsc_val);
2825 } else
2826 *kvmclock_ns = get_kvmclock_base_ns() + ka->kvmclock_offset;
2827
2828 put_cpu();
2829
2830 return ret;
2831 }
2832
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 2 months
[ti:ti-rt-linux-5.10.y 6721/6782] drivers/media/pci/intel/ipu3/ipu3-cio2.c:983:27: error: incompatible pointer types passing 'struct media_entity *' to parameter of type 'struct media_pad *'
by kernel test robot
tree: git://git.ti.com/ti-linux-kernel/ti-linux-kernel.git ti-rt-linux-5.10.y
head: bee192299392dc41c94f4603968b7a3c02f17a1d
commit: d42003cd0440e21c8940801e58ba2aabf3dc13b6 [6721/6782] media: entity: Use pad as the starting point for a pipeline
config: x86_64-randconfig-a013-20210718 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 5d5b08761f944d5b9822d582378333cc4b36a0a7)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
git remote add ti git://git.ti.com/ti-linux-kernel/ti-linux-kernel.git
git fetch --no-tags ti ti-rt-linux-5.10.y
git checkout d42003cd0440e21c8940801e58ba2aabf3dc13b6
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> drivers/media/pci/intel/ipu3/ipu3-cio2.c:983:27: error: incompatible pointer types passing 'struct media_entity *' to parameter of type 'struct media_pad *' [-Werror,-Wincompatible-pointer-types]
r = media_pipeline_start(&q->vdev.entity, &q->pipe);
^~~~~~~~~~~~~~~
include/media/media-entity.h:948:57: note: passing argument to parameter 'pad' here
__must_check int media_pipeline_start(struct media_pad *pad,
^
drivers/media/pci/intel/ipu3/ipu3-cio2.c:1003:22: error: incompatible pointer types passing 'struct media_entity *' to parameter of type 'struct media_pad *' [-Werror,-Wincompatible-pointer-types]
media_pipeline_stop(&q->vdev.entity);
^~~~~~~~~~~~~~~
include/media/media-entity.h:972:44: note: passing argument to parameter 'pad' here
void media_pipeline_stop(struct media_pad *pad);
^
drivers/media/pci/intel/ipu3/ipu3-cio2.c:1024:22: error: incompatible pointer types passing 'struct media_entity *' to parameter of type 'struct media_pad *' [-Werror,-Wincompatible-pointer-types]
media_pipeline_stop(&q->vdev.entity);
^~~~~~~~~~~~~~~
include/media/media-entity.h:972:44: note: passing argument to parameter 'pad' here
void media_pipeline_stop(struct media_pad *pad);
^
3 errors generated.
vim +983 drivers/media/pci/intel/ipu3/ipu3-cio2.c
c2a6a07afe4a46 Yong Zhi 2017-11-08 966
c2a6a07afe4a46 Yong Zhi 2017-11-08 967 static int cio2_vb2_start_streaming(struct vb2_queue *vq, unsigned int count)
c2a6a07afe4a46 Yong Zhi 2017-11-08 968 {
c2a6a07afe4a46 Yong Zhi 2017-11-08 969 struct cio2_queue *q = vb2q_to_cio2_queue(vq);
c2a6a07afe4a46 Yong Zhi 2017-11-08 970 struct cio2_device *cio2 = vb2_get_drv_priv(vq);
c2a6a07afe4a46 Yong Zhi 2017-11-08 971 int r;
c2a6a07afe4a46 Yong Zhi 2017-11-08 972
c2a6a07afe4a46 Yong Zhi 2017-11-08 973 cio2->cur_queue = q;
c2a6a07afe4a46 Yong Zhi 2017-11-08 974 atomic_set(&q->frame_sequence, 0);
c2a6a07afe4a46 Yong Zhi 2017-11-08 975
c2a6a07afe4a46 Yong Zhi 2017-11-08 976 r = pm_runtime_get_sync(&cio2->pci_dev->dev);
c2a6a07afe4a46 Yong Zhi 2017-11-08 977 if (r < 0) {
c2a6a07afe4a46 Yong Zhi 2017-11-08 978 dev_info(&cio2->pci_dev->dev, "failed to set power %d\n", r);
c2a6a07afe4a46 Yong Zhi 2017-11-08 979 pm_runtime_put_noidle(&cio2->pci_dev->dev);
c2a6a07afe4a46 Yong Zhi 2017-11-08 980 return r;
c2a6a07afe4a46 Yong Zhi 2017-11-08 981 }
c2a6a07afe4a46 Yong Zhi 2017-11-08 982
c2a6a07afe4a46 Yong Zhi 2017-11-08 @983 r = media_pipeline_start(&q->vdev.entity, &q->pipe);
c2a6a07afe4a46 Yong Zhi 2017-11-08 984 if (r)
c2a6a07afe4a46 Yong Zhi 2017-11-08 985 goto fail_pipeline;
c2a6a07afe4a46 Yong Zhi 2017-11-08 986
c2a6a07afe4a46 Yong Zhi 2017-11-08 987 r = cio2_hw_init(cio2, q);
c2a6a07afe4a46 Yong Zhi 2017-11-08 988 if (r)
c2a6a07afe4a46 Yong Zhi 2017-11-08 989 goto fail_hw;
c2a6a07afe4a46 Yong Zhi 2017-11-08 990
c2a6a07afe4a46 Yong Zhi 2017-11-08 991 /* Start streaming on sensor */
c2a6a07afe4a46 Yong Zhi 2017-11-08 992 r = v4l2_subdev_call(q->sensor, video, s_stream, 1);
c2a6a07afe4a46 Yong Zhi 2017-11-08 993 if (r)
c2a6a07afe4a46 Yong Zhi 2017-11-08 994 goto fail_csi2_subdev;
c2a6a07afe4a46 Yong Zhi 2017-11-08 995
c2a6a07afe4a46 Yong Zhi 2017-11-08 996 cio2->streaming = true;
c2a6a07afe4a46 Yong Zhi 2017-11-08 997
c2a6a07afe4a46 Yong Zhi 2017-11-08 998 return 0;
c2a6a07afe4a46 Yong Zhi 2017-11-08 999
c2a6a07afe4a46 Yong Zhi 2017-11-08 1000 fail_csi2_subdev:
c2a6a07afe4a46 Yong Zhi 2017-11-08 1001 cio2_hw_exit(cio2, q);
c2a6a07afe4a46 Yong Zhi 2017-11-08 1002 fail_hw:
c2a6a07afe4a46 Yong Zhi 2017-11-08 1003 media_pipeline_stop(&q->vdev.entity);
c2a6a07afe4a46 Yong Zhi 2017-11-08 1004 fail_pipeline:
c2a6a07afe4a46 Yong Zhi 2017-11-08 1005 dev_dbg(&cio2->pci_dev->dev, "failed to start streaming (%d)\n", r);
dcd80955a0a13d Yong Zhi 2018-01-03 1006 cio2_vb2_return_all_buffers(q, VB2_BUF_STATE_QUEUED);
c2a6a07afe4a46 Yong Zhi 2017-11-08 1007 pm_runtime_put(&cio2->pci_dev->dev);
c2a6a07afe4a46 Yong Zhi 2017-11-08 1008
c2a6a07afe4a46 Yong Zhi 2017-11-08 1009 return r;
c2a6a07afe4a46 Yong Zhi 2017-11-08 1010 }
c2a6a07afe4a46 Yong Zhi 2017-11-08 1011
:::::: The code at line 983 was first introduced by commit
:::::: c2a6a07afe4a466896c250cbb203657162b86f4b media: intel-ipu3: cio2: add new MIPI-CSI2 driver
:::::: TO: Yong Zhi <yong.zhi(a)intel.com>
:::::: CC: Mauro Carvalho Chehab <mchehab(a)s-opensource.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 2 months