[sashal-linux-stable:pending-4.19 387/414] drivers/remoteproc/qcom_q6v5.c:282:16: error: implicit declaration of function 'devm_qcom_smem_state_get'; did you mean 'qcom_smem_state_get'?
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git pending-4.19
head: 2589ac98034d2c19f1303535132ae543640b086c
commit: c515bc15971993cbe9c0824aa210504823966f3e [387/414] remoteproc: qcom_q6v5: Use devm_qcom_smem_state_get() to fix missing put()
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git/c...
git remote add sashal-linux-stable https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git
git fetch --no-tags sashal-linux-stable pending-4.19
git checkout c515bc15971993cbe9c0824aa210504823966f3e
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All error/warnings (new ones prefixed by >>):
drivers/remoteproc/qcom_q6v5.c: In function 'qcom_q6v5_init':
>> drivers/remoteproc/qcom_q6v5.c:282:16: error: implicit declaration of function 'devm_qcom_smem_state_get'; did you mean 'qcom_smem_state_get'? [-Werror=implicit-function-declaration]
282 | q6v5->state = devm_qcom_smem_state_get(&pdev->dev, "stop", &q6v5->stop_bit);
| ^~~~~~~~~~~~~~~~~~~~~~~~
| qcom_smem_state_get
>> drivers/remoteproc/qcom_q6v5.c:282:14: warning: assignment to 'struct qcom_smem_state *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
282 | q6v5->state = devm_qcom_smem_state_get(&pdev->dev, "stop", &q6v5->stop_bit);
| ^
cc1: some warnings being treated as errors
vim +282 drivers/remoteproc/qcom_q6v5.c
166
167 /**
168 * qcom_q6v5_init() - initializer of the q6v5 common struct
169 * @q6v5: handle to be initialized
170 * @pdev: platform_device reference for acquiring resources
171 * @rproc: associated remoteproc instance
172 * @crash_reason: SMEM id for crash reason string, or 0 if none
173 * @handover: function to be called when proxy resources should be released
174 *
175 * Return: 0 on success, negative errno on failure
176 */
177 int qcom_q6v5_init(struct qcom_q6v5 *q6v5, struct platform_device *pdev,
178 struct rproc *rproc, int crash_reason,
179 void (*handover)(struct qcom_q6v5 *q6v5))
180 {
181 int ret;
182
183 q6v5->rproc = rproc;
184 q6v5->dev = &pdev->dev;
185 q6v5->crash_reason = crash_reason;
186 q6v5->handover = handover;
187
188 init_completion(&q6v5->start_done);
189 init_completion(&q6v5->stop_done);
190
191 q6v5->wdog_irq = platform_get_irq_byname(pdev, "wdog");
192 if (q6v5->wdog_irq < 0) {
193 if (q6v5->wdog_irq != -EPROBE_DEFER)
194 dev_err(&pdev->dev,
195 "failed to retrieve wdog IRQ: %d\n",
196 q6v5->wdog_irq);
197 return q6v5->wdog_irq;
198 }
199
200 ret = devm_request_threaded_irq(&pdev->dev, q6v5->wdog_irq,
201 NULL, q6v5_wdog_interrupt,
202 IRQF_TRIGGER_RISING | IRQF_ONESHOT,
203 "q6v5 wdog", q6v5);
204 if (ret) {
205 dev_err(&pdev->dev, "failed to acquire wdog IRQ\n");
206 return ret;
207 }
208
209 q6v5->fatal_irq = platform_get_irq_byname(pdev, "fatal");
210 if (q6v5->fatal_irq < 0) {
211 if (q6v5->fatal_irq != -EPROBE_DEFER)
212 dev_err(&pdev->dev,
213 "failed to retrieve fatal IRQ: %d\n",
214 q6v5->fatal_irq);
215 return q6v5->fatal_irq;
216 }
217
218 ret = devm_request_threaded_irq(&pdev->dev, q6v5->fatal_irq,
219 NULL, q6v5_fatal_interrupt,
220 IRQF_TRIGGER_RISING | IRQF_ONESHOT,
221 "q6v5 fatal", q6v5);
222 if (ret) {
223 dev_err(&pdev->dev, "failed to acquire fatal IRQ\n");
224 return ret;
225 }
226
227 q6v5->ready_irq = platform_get_irq_byname(pdev, "ready");
228 if (q6v5->ready_irq < 0) {
229 if (q6v5->ready_irq != -EPROBE_DEFER)
230 dev_err(&pdev->dev,
231 "failed to retrieve ready IRQ: %d\n",
232 q6v5->ready_irq);
233 return q6v5->ready_irq;
234 }
235
236 ret = devm_request_threaded_irq(&pdev->dev, q6v5->ready_irq,
237 NULL, q6v5_ready_interrupt,
238 IRQF_TRIGGER_RISING | IRQF_ONESHOT,
239 "q6v5 ready", q6v5);
240 if (ret) {
241 dev_err(&pdev->dev, "failed to acquire ready IRQ\n");
242 return ret;
243 }
244
245 q6v5->handover_irq = platform_get_irq_byname(pdev, "handover");
246 if (q6v5->handover_irq < 0) {
247 if (q6v5->handover_irq != -EPROBE_DEFER)
248 dev_err(&pdev->dev,
249 "failed to retrieve handover IRQ: %d\n",
250 q6v5->handover_irq);
251 return q6v5->handover_irq;
252 }
253
254 ret = devm_request_threaded_irq(&pdev->dev, q6v5->handover_irq,
255 NULL, q6v5_handover_interrupt,
256 IRQF_TRIGGER_RISING | IRQF_ONESHOT,
257 "q6v5 handover", q6v5);
258 if (ret) {
259 dev_err(&pdev->dev, "failed to acquire handover IRQ\n");
260 return ret;
261 }
262 disable_irq(q6v5->handover_irq);
263
264 q6v5->stop_irq = platform_get_irq_byname(pdev, "stop-ack");
265 if (q6v5->stop_irq < 0) {
266 if (q6v5->stop_irq != -EPROBE_DEFER)
267 dev_err(&pdev->dev,
268 "failed to retrieve stop-ack IRQ: %d\n",
269 q6v5->stop_irq);
270 return q6v5->stop_irq;
271 }
272
273 ret = devm_request_threaded_irq(&pdev->dev, q6v5->stop_irq,
274 NULL, q6v5_stop_interrupt,
275 IRQF_TRIGGER_RISING | IRQF_ONESHOT,
276 "q6v5 stop", q6v5);
277 if (ret) {
278 dev_err(&pdev->dev, "failed to acquire stop-ack IRQ\n");
279 return ret;
280 }
281
> 282 q6v5->state = devm_qcom_smem_state_get(&pdev->dev, "stop", &q6v5->stop_bit);
283 if (IS_ERR(q6v5->state)) {
284 dev_err(&pdev->dev, "failed to acquire stop state\n");
285 return PTR_ERR(q6v5->state);
286 }
287
288 return 0;
289 }
290 EXPORT_SYMBOL_GPL(qcom_q6v5_init);
291
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 2 months
Re: [PATCH nf 2/2] netfilter: flowtable: remove nf_ct_l4proto_find() call
by kernel test robot
Hi Pablo,
I love your patch! Perhaps something to improve:
[auto build test WARNING on nf/master]
url: https://github.com/0day-ci/linux/commits/Pablo-Neira-Ayuso/netfilter-nft_...
base: https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git master
config: mips-randconfig-r032-20210718 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 5d5b08761f944d5b9822d582378333cc4b36a0a7)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install mips cross compiling tool for clang build
# apt-get install binutils-mips-linux-gnu
# https://github.com/0day-ci/linux/commit/5f2c0c949c4707c91d270de9993cf889e...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Pablo-Neira-Ayuso/netfilter-nft_last-avoid-possible-false-sharing/20210718-102117
git checkout 5f2c0c949c4707c91d270de9993cf889ece6261a
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=mips
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> net/netfilter/nf_flow_table_core.c:191:13: warning: variable 'timeout' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
} else if (l4num == IPPROTO_UDP) {
^~~~~~~~~~~~~~~~~~~~
net/netfilter/nf_flow_table_core.c:197:50: note: uninitialized use occurs here
if (nf_flow_timeout_delta(ct->timeout) > (__s32)timeout)
^~~~~~~
net/netfilter/nf_flow_table_core.c:191:9: note: remove the 'if' if its condition is always true
} else if (l4num == IPPROTO_UDP) {
^~~~~~~~~~~~~~~~~~~~~~~~~~
net/netfilter/nf_flow_table_core.c:185:22: note: initialize the variable 'timeout' to silence this warning
unsigned int timeout;
^
= 0
1 warning generated.
vim +191 net/netfilter/nf_flow_table_core.c
da5984e51063a2 Felix Fietkau 2018-02-26 180
1e5b2471bcc483 Pablo Neira Ayuso 2019-08-09 181 static void flow_offload_fixup_ct_timeout(struct nf_conn *ct)
da5984e51063a2 Felix Fietkau 2018-02-26 182 {
1d91d2e1a7f767 Oz Shlomo 2021-06-03 183 struct net *net = nf_ct_net(ct);
1e5b2471bcc483 Pablo Neira Ayuso 2019-08-09 184 int l4num = nf_ct_protonum(ct);
da5984e51063a2 Felix Fietkau 2018-02-26 185 unsigned int timeout;
da5984e51063a2 Felix Fietkau 2018-02-26 186
1d91d2e1a7f767 Oz Shlomo 2021-06-03 187 if (l4num == IPPROTO_TCP) {
1d91d2e1a7f767 Oz Shlomo 2021-06-03 188 struct nf_tcp_net *tn = nf_tcp_pernet(net);
1d91d2e1a7f767 Oz Shlomo 2021-06-03 189
1d91d2e1a7f767 Oz Shlomo 2021-06-03 190 timeout = tn->offload_pickup;
1d91d2e1a7f767 Oz Shlomo 2021-06-03 @191 } else if (l4num == IPPROTO_UDP) {
1d91d2e1a7f767 Oz Shlomo 2021-06-03 192 struct nf_udp_net *tn = nf_udp_pernet(net);
1d91d2e1a7f767 Oz Shlomo 2021-06-03 193
1d91d2e1a7f767 Oz Shlomo 2021-06-03 194 timeout = tn->offload_pickup;
1d91d2e1a7f767 Oz Shlomo 2021-06-03 195 }
da5984e51063a2 Felix Fietkau 2018-02-26 196
1e5b2471bcc483 Pablo Neira Ayuso 2019-08-09 197 if (nf_flow_timeout_delta(ct->timeout) > (__s32)timeout)
da5984e51063a2 Felix Fietkau 2018-02-26 198 ct->timeout = nfct_time_stamp + timeout;
da5984e51063a2 Felix Fietkau 2018-02-26 199 }
da5984e51063a2 Felix Fietkau 2018-02-26 200
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 2 months
[sashal-linux-stable:pending-5.13 462/570] drivers/cpufreq/cppc_cpufreq.c:276:13: warning: conflicting types for 'cppc_cpufreq_put_cpu_data'
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git pending-5.13
head: 0c91fa6be7e9e93e0ff59925e742ebb9d86fb057
commit: b8fe99c7a5fa0b89e7dba24344c839d2e5f938f4 [462/570] cpufreq: CPPC: Fix potential memleak in cppc_cpufreq_cpu_init
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git/c...
git remote add sashal-linux-stable https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git
git fetch --no-tags sashal-linux-stable pending-5.13
git checkout b8fe99c7a5fa0b89e7dba24344c839d2e5f938f4
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/cpufreq/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
drivers/cpufreq/cppc_cpufreq.c: In function 'cppc_cpufreq_stop_cpu':
drivers/cpufreq/cppc_cpufreq.c:199:2: error: implicit declaration of function 'cppc_cpufreq_put_cpu_data'; did you mean 'cppc_cpufreq_stop_cpu'? [-Werror=implicit-function-declaration]
199 | cppc_cpufreq_put_cpu_data(policy);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
| cppc_cpufreq_stop_cpu
drivers/cpufreq/cppc_cpufreq.c: At top level:
>> drivers/cpufreq/cppc_cpufreq.c:276:13: warning: conflicting types for 'cppc_cpufreq_put_cpu_data'
276 | static void cppc_cpufreq_put_cpu_data(struct cpufreq_policy *policy)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/cpufreq/cppc_cpufreq.c:276:13: error: static declaration of 'cppc_cpufreq_put_cpu_data' follows non-static declaration
drivers/cpufreq/cppc_cpufreq.c:199:2: note: previous implicit declaration of 'cppc_cpufreq_put_cpu_data' was here
199 | cppc_cpufreq_put_cpu_data(policy);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/cppc_cpufreq_put_cpu_data +276 drivers/cpufreq/cppc_cpufreq.c
275
> 276 static void cppc_cpufreq_put_cpu_data(struct cpufreq_policy *policy)
277 {
278 struct cppc_cpudata *cpu_data = policy->driver_data;
279
280 list_del(&cpu_data->node);
281 free_cpumask_var(cpu_data->shared_cpu_map);
282 kfree(cpu_data);
283 policy->driver_data = NULL;
284 }
285
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 2 months
Re: [RFC 07/12] scsi/sr: add error handling support for add_disk()
by kernel test robot
Hi Luis,
[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on block/for-next]
[also build test ERROR on mkp-scsi/for-next scsi/for-next v5.14-rc1 next-20210716]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Luis-Chamberlain/block-add_disk-...
base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
config: x86_64-randconfig-a001-20210715 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 0e49c54a8cbd3e779e5526a5888c683c01cc3c50)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://github.com/0day-ci/linux/commit/1b194339e9e7b904476b4fdfa4aa3cb80...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Luis-Chamberlain/block-add_disk-driver-conversions-__register_blkdev/20210716-050317
git checkout 1b194339e9e7b904476b4fdfa4aa3cb801915e6f
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/scsi/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> drivers/scsi/sr.c:780:8: error: assigning to 'int' from incompatible type 'void'
error = device_add_disk(&sdev->sdev_gendev, disk, NULL);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
vim +780 drivers/scsi/sr.c
695
696 static int sr_probe(struct device *dev)
697 {
698 struct scsi_device *sdev = to_scsi_device(dev);
699 struct gendisk *disk;
700 struct scsi_cd *cd;
701 int minor, error;
702
703 scsi_autopm_get_device(sdev);
704 error = -ENODEV;
705 if (sdev->type != TYPE_ROM && sdev->type != TYPE_WORM)
706 goto fail;
707
708 error = -ENOMEM;
709 cd = kzalloc(sizeof(*cd), GFP_KERNEL);
710 if (!cd)
711 goto fail;
712
713 kref_init(&cd->kref);
714
715 disk = alloc_disk(1);
716 if (!disk)
717 goto fail_free;
718 mutex_init(&cd->lock);
719
720 spin_lock(&sr_index_lock);
721 minor = find_first_zero_bit(sr_index_bits, SR_DISKS);
722 if (minor == SR_DISKS) {
723 spin_unlock(&sr_index_lock);
724 error = -EBUSY;
725 goto fail_put;
726 }
727 __set_bit(minor, sr_index_bits);
728 spin_unlock(&sr_index_lock);
729
730 disk->major = SCSI_CDROM_MAJOR;
731 disk->first_minor = minor;
732 sprintf(disk->disk_name, "sr%d", minor);
733 disk->fops = &sr_bdops;
734 disk->flags = GENHD_FL_CD | GENHD_FL_BLOCK_EVENTS_ON_EXCL_WRITE;
735 disk->events = DISK_EVENT_MEDIA_CHANGE | DISK_EVENT_EJECT_REQUEST;
736 disk->event_flags = DISK_EVENT_FLAG_POLL | DISK_EVENT_FLAG_UEVENT;
737
738 blk_queue_rq_timeout(sdev->request_queue, SR_TIMEOUT);
739
740 cd->device = sdev;
741 cd->disk = disk;
742 cd->driver = &sr_template;
743 cd->disk = disk;
744 cd->capacity = 0x1fffff;
745 cd->device->changed = 1; /* force recheck CD type */
746 cd->media_present = 1;
747 cd->use = 1;
748 cd->readcd_known = 0;
749 cd->readcd_cdda = 0;
750
751 cd->cdi.ops = &sr_dops;
752 cd->cdi.handle = cd;
753 cd->cdi.mask = 0;
754 cd->cdi.capacity = 1;
755 sprintf(cd->cdi.name, "sr%d", minor);
756
757 sdev->sector_size = 2048; /* A guess, just in case */
758
759 /* FIXME: need to handle a get_capabilities failure properly ?? */
760 get_capabilities(cd);
761 sr_vendor_init(cd);
762
763 set_capacity(disk, cd->capacity);
764 disk->private_data = &cd->driver;
765 disk->queue = sdev->request_queue;
766
767 if (register_cdrom(disk, &cd->cdi))
768 goto fail_minor;
769
770 /*
771 * Initialize block layer runtime PM stuffs before the
772 * periodic event checking request gets started in add_disk.
773 */
774 blk_pm_runtime_init(sdev->request_queue, dev);
775
776 dev_set_drvdata(dev, cd);
777 disk->flags |= GENHD_FL_REMOVABLE;
778 sr_revalidate_disk(cd);
779
> 780 error = device_add_disk(&sdev->sdev_gendev, disk, NULL);
781 if (error)
782 goto fail_minor;
783
784 sdev_printk(KERN_DEBUG, sdev,
785 "Attached scsi CD-ROM %s\n", cd->cdi.name);
786 scsi_autopm_put_device(cd->device);
787
788 return 0;
789
790 fail_minor:
791 spin_lock(&sr_index_lock);
792 clear_bit(minor, sr_index_bits);
793 spin_unlock(&sr_index_lock);
794 fail_put:
795 blk_cleanup_disk(disk);
796 mutex_destroy(&cd->lock);
797 fail_free:
798 kfree(cd);
799 fail:
800 scsi_autopm_put_device(sdev);
801 return error;
802 }
803
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 2 months
[frank-w-bpi-r2-4.14:5.14-hdmilarb2 37/48] include/linux/iommu.h:576:51: warning: cast from pointer to integer of different size
by kernel test robot
tree: https://github.com/frank-w/BPI-R2-4.14 5.14-hdmilarb2
head: 77b4c96140f9bec5bb54fc804b401af1c9a6b4b5
commit: f94886349fc7e9a28901486218351f8e31fe950f [37/48] add debug in fwspec_set
config: sparc-randconfig-p002-20210718 (attached as .config)
compiler: sparc64-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/frank-w/BPI-R2-4.14/commit/f94886349fc7e9a289014862183...
git remote add frank-w-bpi-r2-4.14 https://github.com/frank-w/BPI-R2-4.14
git fetch --no-tags frank-w-bpi-r2-4.14 5.14-hdmilarb2
git checkout f94886349fc7e9a28901486218351f8e31fe950f
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=sparc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
In file included from include/linux/device.h:15,
from drivers/iommu/iommu.c:9:
include/linux/iommu.h: In function 'dev_iommu_fwspec_set':
>> include/linux/iommu.h:576:51: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
576 | dev_err(dev,"%s:%d 0x%08x",__FUNCTION__,__LINE__,(unsigned int)fwspec);
| ^
include/linux/dev_printk.h:112:32: note: in definition of macro 'dev_err'
112 | _dev_err(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~
vim +576 include/linux/iommu.h
571
572 static inline void dev_iommu_fwspec_set(struct device *dev,
573 struct iommu_fwspec *fwspec)
574 {
575 dev->iommu->fwspec = fwspec;
> 576 dev_err(dev,"%s:%d 0x%08x",__FUNCTION__,__LINE__,(unsigned int)fwspec);
577 dump_stack();
578 }
579
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 2 months
[chrome-os:chromeos-4.14 9/12] drivers/usb/core/message.c:951:25: sparse: sparse: incorrect type in argument 5 (different base types)
by kernel test robot
tree: https://chromium.googlesource.com/chromiumos/third_party/kernel chromeos-4.14
head: 20c828b1505cdd2d518dbace69490b21342fdf8d
commit: 7b34fb233405ff37e4d69921764524baac34f382 [9/12] UPSTREAM: usb: core: add support for USB_REQ_SET_ISOCH_DELAY
config: microblaze-randconfig-s032-20210718 (attached as .config)
compiler: microblaze-linux-gcc (GCC) 10.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.3-341-g8af24329-dirty
git remote add chrome-os https://chromium.googlesource.com/chromiumos/third_party/kernel
git fetch --no-tags chrome-os chromeos-4.14
git checkout 7b34fb233405ff37e4d69921764524baac34f382
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=microblaze
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
drivers/usb/core/message.c: note: in included file (through arch/microblaze/include/uapi/asm/byteorder.h, include/asm-generic/bitops/le.h, include/asm-generic/bitops.h, ...):
include/linux/byteorder/big_endian.h:8:2: sparse: sparse: inconsistent configuration, needs CONFIG_CPU_BIG_ENDIAN
>> drivers/usb/core/message.c:951:25: sparse: sparse: incorrect type in argument 5 (different base types) @@ expected unsigned short [usertype] value @@ got restricted __le16 [usertype] @@
drivers/usb/core/message.c:951:25: sparse: expected unsigned short [usertype] value
drivers/usb/core/message.c:951:25: sparse: got restricted __le16 [usertype]
In file included from include/linux/workqueue.h:9,
from include/linux/srcu.h:34,
from include/linux/notifier.h:16,
from include/linux/memory_hotplug.h:7,
from include/linux/mmzone.h:913,
from include/linux/gfp.h:6,
from include/linux/idr.h:16,
from include/linux/kernfs.h:14,
from include/linux/sysfs.h:16,
from include/linux/kobject.h:21,
from include/linux/pci.h:29,
from drivers/usb/core/message.c:8:
include/linux/timer.h: In function 'timer_setup':
include/linux/timer.h:179:23: warning: cast between incompatible function types from 'void (*)(struct timer_list *)' to 'void (*)(long unsigned int)' [-Wcast-function-type]
179 | __setup_timer(timer, (TIMER_FUNC_TYPE)callback,
| ^
include/linux/timer.h:144:25: note: in definition of macro '__setup_timer'
144 | (_timer)->function = (_fn); 24- | ^~~
vim +951 drivers/usb/core/message.c
930
931 /*
932 * usb_set_isoch_delay - informs the device of the packet transmit delay
933 * @dev: the device whose delay is to be informed
934 * Context: !in_interrupt()
935 *
936 * Since this is an optional request, we don't bother if it fails.
937 */
938 int usb_set_isoch_delay(struct usb_device *dev)
939 {
940 /* skip hub devices */
941 if (dev->descriptor.bDeviceClass == USB_CLASS_HUB)
942 return 0;
943
944 /* skip non-SS/non-SSP devices */
945 if (dev->speed < USB_SPEED_SUPER)
946 return 0;
947
948 return usb_control_msg(dev, usb_sndctrlpipe(dev, 0),
949 USB_REQ_SET_ISOCH_DELAY,
950 USB_DIR_OUT | USB_TYPE_STANDARD | USB_RECIP_DEVICE,
> 951 cpu_to_le16(dev->hub_delay), 0, NULL, 0,
952 USB_CTRL_SET_TIMEOUT);
953 }
954
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 2 months
Re: [PATCH 2/2] erofs: convert all uncompressed cases to iomap
by kernel test robot
Hi Gao,
I love your patch! Perhaps something to improve:
[auto build test WARNING on xiang-erofs/dev-test]
[cannot apply to xfs-linux/for-next linux/master linus/master v5.14-rc1 next-20210716]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Gao-Xiang/erofs-iomap-support-fo...
base: https://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs.git dev-test
config: x86_64-randconfig-s032-20210716 (attached as .config)
compiler: gcc-10 (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.3-341-g8af24329-dirty
# https://github.com/0day-ci/linux/commit/9bd9c1ccdf3e99ffd9a76cfec92691e46...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Gao-Xiang/erofs-iomap-support-for-tailpacking-cases/20210716-130821
git checkout 9bd9c1ccdf3e99ffd9a76cfec92691e460abd74d
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> fs/erofs/data.c:133:5: warning: no previous prototype for 'erofs_iomap_end' [-Wmissing-prototypes]
133 | int erofs_iomap_end(struct inode *inode, loff_t pos, loff_t length,
| ^~~~~~~~~~~~~~~
sparse warnings: (new ones prefixed by >>)
>> fs/erofs/data.c:133:5: sparse: sparse: symbol 'erofs_iomap_end' was not declared. Should it be static?
fs/erofs/data.c:148:24: sparse: sparse: symbol 'erofs_iomap_ops' was not declared. Should it be static?
Please review and possibly fold the followup patch.
vim +/erofs_iomap_end +133 fs/erofs/data.c
132
> 133 int erofs_iomap_end(struct inode *inode, loff_t pos, loff_t length,
134 ssize_t written, unsigned flags, struct iomap *iomap)
135 {
136 struct page *ipage = iomap->private;
137
138 if (ipage) {
139 DBG_BUGON(iomap->type != IOMAP_INLINE);
140 unlock_page(ipage);
141 put_page(ipage);
142 } else {
143 DBG_BUGON(iomap->type == IOMAP_INLINE);
144 }
145 return written;
146 }
147
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 2 months