[android-common:android12-5.10 10/15] sound/soc/hisilicon/hi3660-i2s.c:377:15: error: implicit declaration of function 'devm_pinctrl_get'; did you mean 'of_pinctrl_get'?
by kernel test robot
tree: https://android.googlesource.com/kernel/common android12-5.10
head: 8adfa9950c6c13d32c5c167c1f0be1ad3849d89c
commit: b4b11198edb99eb17a4d032c3a80854d3a817b0d [10/15] ANDROID: sound: Add hikey960 i2s audio driver
config: arm-randconfig-r013-20210718 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git remote add android-common https://android.googlesource.com/kernel/common
git fetch --no-tags android-common android12-5.10
git checkout b4b11198edb99eb17a4d032c3a80854d3a817b0d
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All error/warnings (new ones prefixed by >>):
sound/soc/hisilicon/hi3660-i2s.c: In function 'hi3660_i2s_probe':
>> sound/soc/hisilicon/hi3660-i2s.c:377:15: error: implicit declaration of function 'devm_pinctrl_get'; did you mean 'of_pinctrl_get'? [-Werror=implicit-function-declaration]
377 | i2s->pctrl = devm_pinctrl_get(dev);
| ^~~~~~~~~~~~~~~~
| of_pinctrl_get
>> sound/soc/hisilicon/hi3660-i2s.c:377:13: warning: assignment to 'struct pinctrl *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
377 | i2s->pctrl = devm_pinctrl_get(dev);
| ^
>> sound/soc/hisilicon/hi3660-i2s.c:384:21: error: implicit declaration of function 'pinctrl_lookup_state' [-Werror=implicit-function-declaration]
384 | i2s->pin_default = pinctrl_lookup_state(i2s->pctrl,
| ^~~~~~~~~~~~~~~~~~~~
>> sound/soc/hisilicon/hi3660-i2s.c:384:19: warning: assignment to 'struct pinctrl_state *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
384 | i2s->pin_default = pinctrl_lookup_state(i2s->pctrl,
| ^
>> sound/soc/hisilicon/hi3660-i2s.c:394:6: error: implicit declaration of function 'pinctrl_select_state' [-Werror=implicit-function-declaration]
394 | if (pinctrl_select_state(i2s->pctrl, i2s->pin_default)) {
| ^~~~~~~~~~~~~~~~~~~~
sound/soc/hisilicon/hi3660-i2s.c: In function 'hi3660_i2s_remove':
>> sound/soc/hisilicon/hi3660-i2s.c:422:2: error: implicit declaration of function 'pinctrl_put'; did you mean 'of_pinctrl_get'? [-Werror=implicit-function-declaration]
422 | pinctrl_put(i2s->pctrl);
| ^~~~~~~~~~~
| of_pinctrl_get
cc1: some warnings being treated as errors
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for DRM_MIPI_DSI
Depends on HAS_IOMEM && DRM
Selected by
- GKI_HIDDEN_DRM_CONFIGS
WARNING: unmet direct dependencies detected for WEXT_SPY
Depends on NET && WIRELESS
Selected by
- GKI_LEGACY_WEXT_ALLCONFIG
WARNING: unmet direct dependencies detected for WIRELESS_EXT
Depends on NET && WIRELESS
Selected by
- GKI_LEGACY_WEXT_ALLCONFIG
WARNING: unmet direct dependencies detected for WEXT_CORE
Depends on NET && WIRELESS && (CFG80211_WEXT || WIRELESS_EXT
Selected by
- GKI_LEGACY_WEXT_ALLCONFIG
WARNING: unmet direct dependencies detected for NET_PTP_CLASSIFY
Depends on NET
Selected by
- GKI_HIDDEN_NET_CONFIGS
WARNING: unmet direct dependencies detected for DRM_KMS_CMA_HELPER
Depends on HAS_IOMEM && DRM
Selected by
- GKI_HIDDEN_DRM_CONFIGS
WARNING: unmet direct dependencies detected for DRM_GEM_CMA_HELPER
Depends on HAS_IOMEM && DRM
Selected by
- GKI_HIDDEN_DRM_CONFIGS
WARNING: unmet direct dependencies detected for WEXT_PROC
Depends on NET && WIRELESS && PROC_FS && WEXT_CORE
Selected by
- GKI_LEGACY_WEXT_ALLCONFIG
WARNING: unmet direct dependencies detected for WEXT_PRIV
Depends on NET && WIRELESS
Selected by
- GKI_LEGACY_WEXT_ALLCONFIG
WARNING: unmet direct dependencies detected for PAGE_POOL
Depends on NET
Selected by
- GKI_HIDDEN_NET_CONFIGS
vim +377 sound/soc/hisilicon/hi3660-i2s.c
332
333 static int hi3660_i2s_probe(struct platform_device *pdev)
334 {
335 struct device *dev = &pdev->dev;
336 struct hi3660_i2s *i2s;
337 struct resource *res;
338 int ret;
339
340 i2s = devm_kzalloc(dev, sizeof(*i2s), GFP_KERNEL);
341 if (!i2s)
342 return -ENOMEM;
343
344 i2s->dev = dev;
345 spin_lock_init(&i2s->lock);
346
347 res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
348 if (!res) {
349 ret = -ENODEV;
350 return ret;
351 }
352 i2s->base_phys = (phys_addr_t)res->start;
353
354 i2s->dai = dai_init;
355 dev_set_drvdata(&pdev->dev, i2s);
356
357 i2s->base = devm_ioremap_resource(dev, res);
358 if (IS_ERR(i2s->base)) {
359 dev_err(&pdev->dev, "ioremap failed\n");
360 ret = PTR_ERR(i2s->base);
361 return ret;
362 }
363
364 res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
365 if (!res) {
366 ret = -ENODEV;
367 return ret;
368 }
369 i2s->base_syscon = devm_ioremap(dev, res->start, resource_size(res));
370 if (IS_ERR(i2s->base_syscon)) {
371 dev_err(&pdev->dev, "ioremap failed\n");
372 ret = PTR_ERR(i2s->base_syscon);
373 return ret;
374 }
375
376 /* i2s iomux config */
> 377 i2s->pctrl = devm_pinctrl_get(dev);
378 if (IS_ERR(i2s->pctrl)) {
379 dev_err(dev, "could not get pinctrl\n");
380 ret = -EIO;
381 return ret;
382 }
383
> 384 i2s->pin_default = pinctrl_lookup_state(i2s->pctrl,
385 PINCTRL_STATE_DEFAULT);
386 if (IS_ERR(i2s->pin_default)) {
387 dev_err(dev,
388 "could not get default state (%li)\n",
389 PTR_ERR(i2s->pin_default));
390 ret = -EIO;
391 return ret;
392 }
393
> 394 if (pinctrl_select_state(i2s->pctrl, i2s->pin_default)) {
395 dev_err(dev, "could not set pins to default state\n");
396 ret = -EIO;
397 return ret;
398 }
399
400 ret = devm_snd_dmaengine_pcm_register(&pdev->dev,
401 &dmaengine_pcm_config, 0);
402 if (ret)
403 return ret;
404
405 ret = snd_soc_register_component(&pdev->dev, &component_driver,
406 &i2s->dai, 1);
407 if (ret) {
408 dev_err(&pdev->dev, "Failed to register dai\n");
409 return ret;
410 }
411
412 return 0;
413 }
414
415 static int hi3660_i2s_remove(struct platform_device *pdev)
416 {
417 struct hi3660_i2s *i2s = dev_get_drvdata(&pdev->dev);
418
419 snd_soc_unregister_component(&pdev->dev);
420 dev_set_drvdata(&pdev->dev, NULL);
421
> 422 pinctrl_put(i2s->pctrl);
423
424 return 0;
425 }
426
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 2 months
Re: [PATCH 08/15] iio: dac: ad5624r: Fix incorrect handling of an optional regulator.
by kernel test robot
Hi Jonathan,
I love your patch! Yet something to improve:
[auto build test ERROR on iio/togreg]
[also build test ERROR on robh/for-next v5.13-rc7 next-20210625]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Jonathan-Cameron/dt-bindings-iio...
base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
config: nios2-randconfig-r001-20210627 (attached as .config)
compiler: nios2-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/4f70da9b9819945461961ccdfbd87438a...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Jonathan-Cameron/dt-bindings-iio-dac-Add-most-missing-binding-documents/20210628-003216
git checkout 4f70da9b9819945461961ccdfbd87438ac8a9f89
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross O=build_dir ARCH=nios2 SHELL=/bin/bash drivers/iio/dac/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All error/warnings (new ones prefixed by >>):
drivers/iio/dac/ad5624r_spi.c: In function 'ad5624r_probe':
>> drivers/iio/dac/ad5624r_spi.c:296:12: error: invalid storage class for function 'ad5624r_remove'
296 | static int ad5624r_remove(struct spi_device *spi)
| ^~~~~~~~~~~~~~
>> drivers/iio/dac/ad5624r_spi.c:296:1: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
296 | static int ad5624r_remove(struct spi_device *spi)
| ^~~~~~
>> drivers/iio/dac/ad5624r_spi.c:324:12: error: initializer element is not constant
324 | .remove = ad5624r_remove,
| ^~~~~~~~~~~~~~
drivers/iio/dac/ad5624r_spi.c:324:12: note: (near initialization for 'ad5624r_driver.remove')
drivers/iio/dac/ad5624r_spi.c:319:1: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
319 | static struct spi_driver ad5624r_driver = {
| ^~~~~~
In file included from include/linux/device.h:32,
from drivers/iio/dac/ad5624r_spi.c:10:
>> drivers/iio/dac/ad5624r_spi.c:327:19: error: invalid storage class for function 'ad5624r_driver_init'
327 | module_spi_driver(ad5624r_driver);
| ^~~~~~~~~~~~~~
include/linux/device/driver.h:259:19: note: in definition of macro 'module_driver'
259 | static int __init __driver##_init(void) \
| ^~~~~~~~
drivers/iio/dac/ad5624r_spi.c:327:1: note: in expansion of macro 'module_spi_driver'
327 | module_spi_driver(ad5624r_driver);
| ^~~~~~~~~~~~~~~~~
In file included from include/linux/printk.h:6,
from include/linux/kernel.h:17,
from include/linux/interrupt.h:6,
from drivers/iio/dac/ad5624r_spi.c:8:
drivers/iio/dac/ad5624r_spi.c:327:19: error: initializer element is not constant
327 | module_spi_driver(ad5624r_driver);
| ^~~~~~~~~~~~~~
include/linux/init.h:250:41: note: in definition of macro '____define_initcall'
250 | __attribute__((__section__(__sec))) = fn;
| ^~
include/linux/init.h:260:2: note: in expansion of macro '__unique_initcall'
260 | __unique_initcall(fn, id, __sec, __initcall_id(fn))
| ^~~~~~~~~~~~~~~~~
include/linux/init.h:262:35: note: in expansion of macro '___define_initcall'
262 | #define __define_initcall(fn, id) ___define_initcall(fn, id, .initcall##id)
| ^~~~~~~~~~~~~~~~~~
include/linux/init.h:291:30: note: in expansion of macro '__define_initcall'
291 | #define device_initcall(fn) __define_initcall(fn, 6)
| ^~~~~~~~~~~~~~~~~
include/linux/init.h:296:24: note: in expansion of macro 'device_initcall'
296 | #define __initcall(fn) device_initcall(fn)
| ^~~~~~~~~~~~~~~
include/linux/module.h:87:24: note: in expansion of macro '__initcall'
87 | #define module_init(x) __initcall(x);
| ^~~~~~~~~~
include/linux/device/driver.h:263:1: note: in expansion of macro 'module_init'
263 | module_init(__driver##_init); \
| ^~~~~~~~~~~
include/linux/spi/spi.h:315:2: note: in expansion of macro 'module_driver'
315 | module_driver(__spi_driver, spi_register_driver, \
| ^~~~~~~~~~~~~
drivers/iio/dac/ad5624r_spi.c:327:1: note: in expansion of macro 'module_spi_driver'
327 | module_spi_driver(ad5624r_driver);
| ^~~~~~~~~~~~~~~~~
In file included from include/linux/device.h:32,
from drivers/iio/dac/ad5624r_spi.c:10:
>> drivers/iio/dac/ad5624r_spi.c:327:19: error: invalid storage class for function 'ad5624r_driver_exit'
327 | module_spi_driver(ad5624r_driver);
| ^~~~~~~~~~~~~~
include/linux/device/driver.h:264:20: note: in definition of macro 'module_driver'
264 | static void __exit __driver##_exit(void) \
| ^~~~~~~~
drivers/iio/dac/ad5624r_spi.c:327:1: note: in expansion of macro 'module_spi_driver'
327 | module_spi_driver(ad5624r_driver);
| ^~~~~~~~~~~~~~~~~
>> include/linux/device/driver.h:264:1: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
264 | static void __exit __driver##_exit(void) \
| ^~~~~~
include/linux/spi/spi.h:315:2: note: in expansion of macro 'module_driver'
315 | module_driver(__spi_driver, spi_register_driver, \
| ^~~~~~~~~~~~~
drivers/iio/dac/ad5624r_spi.c:327:1: note: in expansion of macro 'module_spi_driver'
327 | module_spi_driver(ad5624r_driver);
| ^~~~~~~~~~~~~~~~~
In file included from include/linux/printk.h:6,
from include/linux/kernel.h:17,
from include/linux/interrupt.h:6,
from drivers/iio/dac/ad5624r_spi.c:8:
drivers/iio/dac/ad5624r_spi.c:327:19: error: initializer element is not constant
327 | module_spi_driver(ad5624r_driver);
| ^~~~~~~~~~~~~~
include/linux/init.h:299:50: note: in definition of macro '__exitcall'
299 | static exitcall_t __exitcall_##fn __exit_call = fn
| ^~
include/linux/device/driver.h:268:1: note: in expansion of macro 'module_exit'
268 | module_exit(__driver##_exit);
| ^~~~~~~~~~~
include/linux/spi/spi.h:315:2: note: in expansion of macro 'module_driver'
315 | module_driver(__spi_driver, spi_register_driver, \
| ^~~~~~~~~~~~~
drivers/iio/dac/ad5624r_spi.c:327:1: note: in expansion of macro 'module_spi_driver'
327 | module_spi_driver(ad5624r_driver);
| ^~~~~~~~~~~~~~~~~
In file included from include/linux/module.h:21,
from include/linux/bpf.h:19,
from include/linux/bpf-cgroup.h:5,
from include/linux/cgroup-defs.h:22,
from include/linux/cgroup.h:28,
from include/linux/memcontrol.h:13,
from include/linux/swap.h:9,
from include/linux/suspend.h:5,
from include/linux/regulator/consumer.h:35,
from drivers/iio/dac/ad5624r_spi.c:15:
include/linux/moduleparam.h:24:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
24 | static const char __UNIQUE_ID(name)[] \
| ^~~~~~
include/linux/module.h:165:32: note: in expansion of macro '__MODULE_INFO'
165 | #define MODULE_INFO(tag, info) __MODULE_INFO(tag, tag, info)
| ^~~~~~~~~~~~~
include/linux/module.h:235:32: note: in expansion of macro 'MODULE_INFO'
235 | #define MODULE_AUTHOR(_author) MODULE_INFO(author, _author)
| ^~~~~~~~~~~
drivers/iio/dac/ad5624r_spi.c:329:1: note: in expansion of macro 'MODULE_AUTHOR'
329 | MODULE_AUTHOR("Barry Song <21cnbao(a)gmail.com>");
| ^~~~~~~~~~~~~
>> drivers/iio/dac/ad5624r_spi.c:331:1: error: expected declaration or statement at end of input
331 | MODULE_LICENSE("GPL v2");
| ^~~~~~~~~~~~~~
At top level:
drivers/iio/dac/ad5624r_spi.c:222:12: warning: 'ad5624r_probe' defined but not used [-Wunused-function]
222 | static int ad5624r_probe(struct spi_device *spi)
| ^~~~~~~~~~~~~
vim +/ad5624r_remove +296 drivers/iio/dac/ad5624r_spi.c
6790e29fef61b2 drivers/staging/iio/dac/ad5624r_spi.c Barry Song 2010-10-27 295
fc52692c49969e drivers/iio/dac/ad5624r_spi.c Greg Kroah-Hartman 2012-12-21 @296 static int ad5624r_remove(struct spi_device *spi)
6790e29fef61b2 drivers/staging/iio/dac/ad5624r_spi.c Barry Song 2010-10-27 297 {
3ff242055b7b46 drivers/staging/iio/dac/ad5624r_spi.c Jonathan Cameron 2011-06-27 298 struct iio_dev *indio_dev = spi_get_drvdata(spi);
3ff242055b7b46 drivers/staging/iio/dac/ad5624r_spi.c Jonathan Cameron 2011-06-27 299 struct ad5624r_state *st = iio_priv(indio_dev);
3ff242055b7b46 drivers/staging/iio/dac/ad5624r_spi.c Jonathan Cameron 2011-06-27 300
d2fffd6c2fd60f drivers/staging/iio/dac/ad5624r_spi.c Jonathan Cameron 2011-10-14 301 iio_device_unregister(indio_dev);
75238230cce22b drivers/iio/dac/ad5624r_spi.c Sachin Kamat 2013-08-19 302 if (!IS_ERR(st->reg))
26a54797c1b094 drivers/staging/iio/dac/ad5624r_spi.c Jonathan Cameron 2011-08-30 303 regulator_disable(st->reg);
14f88f1b07e03b drivers/staging/iio/dac/ad5624r_spi.c Michael Hennerich 2011-03-09 304
6790e29fef61b2 drivers/staging/iio/dac/ad5624r_spi.c Barry Song 2010-10-27 305 return 0;
6790e29fef61b2 drivers/staging/iio/dac/ad5624r_spi.c Barry Song 2010-10-27 306 }
6790e29fef61b2 drivers/staging/iio/dac/ad5624r_spi.c Barry Song 2010-10-27 307
ece30c15921f94 drivers/staging/iio/dac/ad5624r_spi.c Michael Hennerich 2010-11-19 308 static const struct spi_device_id ad5624r_id[] = {
14f88f1b07e03b drivers/staging/iio/dac/ad5624r_spi.c Michael Hennerich 2011-03-09 309 {"ad5624r3", ID_AD5624R3},
14f88f1b07e03b drivers/staging/iio/dac/ad5624r_spi.c Michael Hennerich 2011-03-09 310 {"ad5644r3", ID_AD5644R3},
14f88f1b07e03b drivers/staging/iio/dac/ad5624r_spi.c Michael Hennerich 2011-03-09 311 {"ad5664r3", ID_AD5664R3},
14f88f1b07e03b drivers/staging/iio/dac/ad5624r_spi.c Michael Hennerich 2011-03-09 312 {"ad5624r5", ID_AD5624R5},
14f88f1b07e03b drivers/staging/iio/dac/ad5624r_spi.c Michael Hennerich 2011-03-09 313 {"ad5644r5", ID_AD5644R5},
14f88f1b07e03b drivers/staging/iio/dac/ad5624r_spi.c Michael Hennerich 2011-03-09 314 {"ad5664r5", ID_AD5664R5},
ece30c15921f94 drivers/staging/iio/dac/ad5624r_spi.c Michael Hennerich 2010-11-19 315 {}
ece30c15921f94 drivers/staging/iio/dac/ad5624r_spi.c Michael Hennerich 2010-11-19 316 };
55e4390cb04e8b drivers/staging/iio/dac/ad5624r_spi.c Lars-Peter Clausen 2011-11-16 317 MODULE_DEVICE_TABLE(spi, ad5624r_id);
ece30c15921f94 drivers/staging/iio/dac/ad5624r_spi.c Michael Hennerich 2010-11-19 318
6790e29fef61b2 drivers/staging/iio/dac/ad5624r_spi.c Barry Song 2010-10-27 319 static struct spi_driver ad5624r_driver = {
6790e29fef61b2 drivers/staging/iio/dac/ad5624r_spi.c Barry Song 2010-10-27 320 .driver = {
6790e29fef61b2 drivers/staging/iio/dac/ad5624r_spi.c Barry Song 2010-10-27 321 .name = "ad5624r",
6790e29fef61b2 drivers/staging/iio/dac/ad5624r_spi.c Barry Song 2010-10-27 322 },
6790e29fef61b2 drivers/staging/iio/dac/ad5624r_spi.c Barry Song 2010-10-27 323 .probe = ad5624r_probe,
fc52692c49969e drivers/iio/dac/ad5624r_spi.c Greg Kroah-Hartman 2012-12-21 @324 .remove = ad5624r_remove,
ece30c15921f94 drivers/staging/iio/dac/ad5624r_spi.c Michael Hennerich 2010-11-19 325 .id_table = ad5624r_id,
6790e29fef61b2 drivers/staging/iio/dac/ad5624r_spi.c Barry Song 2010-10-27 326 };
ae6ae6fec3f7d6 drivers/staging/iio/dac/ad5624r_spi.c Lars-Peter Clausen 2011-11-16 @327 module_spi_driver(ad5624r_driver);
6790e29fef61b2 drivers/staging/iio/dac/ad5624r_spi.c Barry Song 2010-10-27 328
6790e29fef61b2 drivers/staging/iio/dac/ad5624r_spi.c Barry Song 2010-10-27 329 MODULE_AUTHOR("Barry Song <21cnbao(a)gmail.com>");
6790e29fef61b2 drivers/staging/iio/dac/ad5624r_spi.c Barry Song 2010-10-27 330 MODULE_DESCRIPTION("Analog Devices AD5624/44/64R DAC spi driver");
6790e29fef61b2 drivers/staging/iio/dac/ad5624r_spi.c Barry Song 2010-10-27 @331 MODULE_LICENSE("GPL v2");
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 2 months
Re: [PATCH 1/5] drm: Define DRM_FORMAT_MAX_PLANES
by kernel test robot
Hi Thomas,
I love your patch! Perhaps something to improve:
[auto build test WARNING on 4d00e2309398147acdbfefbe1deb4b0e78868466]
url:
https://github.com/0day-ci/linux/commits/Thomas-Zimmermann/drm-Provide-fr...
base: 4d00e2309398147acdbfefbe1deb4b0e78868466
compiler: hppa-linux-gcc (GCC) 10.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
cppcheck possible warnings: (new ones prefixed by >>, may not real problems)
>> drivers/gpu/drm/drm_gem_framebuffer_helper.c:192:14: warning: Unsigned variable 'i' can't be negative so it is unnecessary to test it. [unsignedPositive]
for (i--; i >= 0; i--)
^
vim +192 drivers/gpu/drm/drm_gem_framebuffer_helper.c
4c3dbb2c312c9f Noralf Trønnes 2017-08-13 119 4c3dbb2c312c9f
Noralf Trønnes 2017-08-13 120 /**
f2b816d78a9431 Andrzej Pietrasiewicz 2020-03-11 121 *
drm_gem_fb_init_with_funcs() - Helper function for implementing
4c3dbb2c312c9f Noralf Trønnes 2017-08-13 122 *
&drm_mode_config_funcs.fb_create
f2b816d78a9431 Andrzej Pietrasiewicz 2020-03-11 123 * callback
in cases when the driver
f2b816d78a9431 Andrzej Pietrasiewicz 2020-03-11 124 * allocates
a subclass of
f2b816d78a9431 Andrzej Pietrasiewicz 2020-03-11 125 * struct
drm_framebuffer
4c3dbb2c312c9f Noralf Trønnes 2017-08-13 126 * @dev: DRM device
f2b816d78a9431 Andrzej Pietrasiewicz 2020-03-11 127 * @fb:
framebuffer object
2e187b2099034a Noralf Trønnes 2017-09-22 128 * @file: DRM file
that holds the GEM handle(s) backing the framebuffer
2e187b2099034a Noralf Trønnes 2017-09-22 129 * @mode_cmd:
Metadata from the userspace framebuffer creation request
4c3dbb2c312c9f Noralf Trønnes 2017-08-13 130 * @funcs: vtable
to be used for the new framebuffer object
4c3dbb2c312c9f Noralf Trønnes 2017-08-13 131 *
dbd62e16fd53d3 Noralf Trønnes 2019-01-15 132 * This function
can be used to set &drm_framebuffer_funcs for drivers that need
dbd62e16fd53d3 Noralf Trønnes 2019-01-15 133 * custom
framebuffer callbacks. Use drm_gem_fb_create() if you don't need to
dbd62e16fd53d3 Noralf Trønnes 2019-01-15 134 * change
&drm_framebuffer_funcs. The function does buffer size validation.
f2b816d78a9431 Andrzej Pietrasiewicz 2020-03-11 135 * The buffer size
validation is for a general case, though, so users should
f2b816d78a9431 Andrzej Pietrasiewicz 2020-03-11 136 * pay attention
to the checks being appropriate for them or, at least,
f2b816d78a9431 Andrzej Pietrasiewicz 2020-03-11 137 * non-conflicting.
2e187b2099034a Noralf Trønnes 2017-09-22 138 *
2e187b2099034a Noralf Trønnes 2017-09-22 139 * Returns:
f2b816d78a9431 Andrzej Pietrasiewicz 2020-03-11 140 * Zero or a
negative error code.
4c3dbb2c312c9f Noralf Trønnes 2017-08-13 141 */
f2b816d78a9431 Andrzej Pietrasiewicz 2020-03-11 142 int
drm_gem_fb_init_with_funcs(struct drm_device *dev,
f2b816d78a9431 Andrzej Pietrasiewicz 2020-03-11 143 struct
drm_framebuffer *fb,
f2b816d78a9431 Andrzej Pietrasiewicz 2020-03-11 144 struct
drm_file *file,
4c3dbb2c312c9f Noralf Trønnes 2017-08-13 145 const
struct drm_mode_fb_cmd2 *mode_cmd,
4c3dbb2c312c9f Noralf Trønnes 2017-08-13 146 const
struct drm_framebuffer_funcs *funcs)
4c3dbb2c312c9f Noralf Trønnes 2017-08-13 147 {
4c3dbb2c312c9f Noralf Trønnes 2017-08-13 148 const struct
drm_format_info *info;
6065e7036e073e Thomas Zimmermann 2021-07-15 149 struct
drm_gem_object *objs[DRM_FORMAT_MAX_PLANES];
6065e7036e073e Thomas Zimmermann 2021-07-15 150 unsigned int i;
6065e7036e073e Thomas Zimmermann 2021-07-15 151 int ret;
4c3dbb2c312c9f Noralf Trønnes 2017-08-13 152 4c3dbb2c312c9f
Noralf Trønnes 2017-08-13 153 info = drm_get_format_info(dev,
mode_cmd);
f7f525030854b1 Simon Ser 2021-05-03 154 if (!info) {
f7f525030854b1 Simon Ser 2021-05-03 155 drm_dbg_kms(dev,
"Failed to get FB format info\n");
f2b816d78a9431 Andrzej Pietrasiewicz 2020-03-11 156 return -EINVAL;
f7f525030854b1 Simon Ser 2021-05-03 157 }
4c3dbb2c312c9f Noralf Trønnes 2017-08-13 158 4c3dbb2c312c9f
Noralf Trønnes 2017-08-13 159 for (i = 0; i <
info->num_planes; i++) {
4c3dbb2c312c9f Noralf Trønnes 2017-08-13 160 unsigned int
width = mode_cmd->width / (i ? info->hsub : 1);
4c3dbb2c312c9f Noralf Trønnes 2017-08-13 161 unsigned int
height = mode_cmd->height / (i ? info->vsub : 1);
4c3dbb2c312c9f Noralf Trønnes 2017-08-13 162 unsigned int
min_size;
4c3dbb2c312c9f Noralf Trønnes 2017-08-13 163 4c3dbb2c312c9f
Noralf Trønnes 2017-08-13 164 objs[i] =
drm_gem_object_lookup(file, mode_cmd->handles[i]);
4c3dbb2c312c9f Noralf Trønnes 2017-08-13 165 if (!objs[i]) {
24f03be4aa7922 Jani Nikula 2019-12-10 166
drm_dbg_kms(dev, "Failed to lookup GEM object\n");
4c3dbb2c312c9f Noralf Trønnes 2017-08-13 167 ret = -ENOENT;
4c3dbb2c312c9f Noralf Trønnes 2017-08-13 168 goto
err_gem_object_put;
4c3dbb2c312c9f Noralf Trønnes 2017-08-13 169 }
4c3dbb2c312c9f Noralf Trønnes 2017-08-13 170 4c3dbb2c312c9f
Noralf Trønnes 2017-08-13 171 min_size = (height - 1) *
mode_cmd->pitches[i]
042bf753842ddb Alexandru Gheorghe 2018-11-01 172 +
drm_format_info_min_pitch(info, i, width)
4c3dbb2c312c9f Noralf Trønnes 2017-08-13 173 +
mode_cmd->offsets[i];
4c3dbb2c312c9f Noralf Trønnes 2017-08-13 174 4c3dbb2c312c9f
Noralf Trønnes 2017-08-13 175 if (objs[i]->size < min_size) {
f7f525030854b1 Simon Ser 2021-05-03 176 drm_dbg_kms(dev,
f7f525030854b1 Simon Ser 2021-05-03 177 "GEM
object size (%zu) smaller than minimum size (%u) for plane %d\n",
f7f525030854b1 Simon Ser 2021-05-03 178
objs[i]->size, min_size, i);
be6ee102341bc4 Emil Velikov 2020-05-15 179
drm_gem_object_put(objs[i]);
4c3dbb2c312c9f Noralf Trønnes 2017-08-13 180 ret = -EINVAL;
4c3dbb2c312c9f Noralf Trønnes 2017-08-13 181 goto
err_gem_object_put;
4c3dbb2c312c9f Noralf Trønnes 2017-08-13 182 }
4c3dbb2c312c9f Noralf Trønnes 2017-08-13 183 }
4c3dbb2c312c9f Noralf Trønnes 2017-08-13 184 f2b816d78a9431
Andrzej Pietrasiewicz 2020-03-11 185 ret = drm_gem_fb_init(dev, fb,
mode_cmd, objs, i, funcs);
f2b816d78a9431 Andrzej Pietrasiewicz 2020-03-11 186 if (ret)
4c3dbb2c312c9f Noralf Trønnes 2017-08-13 187 goto
err_gem_object_put;
4c3dbb2c312c9f Noralf Trønnes 2017-08-13 188 f2b816d78a9431
Andrzej Pietrasiewicz 2020-03-11 189 return 0;
4c3dbb2c312c9f Noralf Trønnes 2017-08-13 190 4c3dbb2c312c9f
Noralf Trønnes 2017-08-13 191 err_gem_object_put:
4c3dbb2c312c9f Noralf Trønnes 2017-08-13 @192 for (i--; i >= 0;
i--)
be6ee102341bc4 Emil Velikov 2020-05-15 193
drm_gem_object_put(objs[i]);
4c3dbb2c312c9f Noralf Trønnes 2017-08-13 194 f2b816d78a9431
Andrzej Pietrasiewicz 2020-03-11 195 return ret;
f2b816d78a9431 Andrzej Pietrasiewicz 2020-03-11 196 }
f2b816d78a9431 Andrzej Pietrasiewicz 2020-03-11 197
EXPORT_SYMBOL_GPL(drm_gem_fb_init_with_funcs);
f2b816d78a9431 Andrzej Pietrasiewicz 2020-03-11 198
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 2 months
Re: [PATCH v2 6/7] soc: mediatek: mmsys: Add reset controller support
by kernel test robot
Hi Enric,
I love your patch! Perhaps something to improve:
[auto build test WARNING on robh/for-next]
[also build test WARNING on pza/reset/next linux/master linus/master
v5.14-rc1 next-20210714]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Enric-Balletbo-i-Serra/Add-suppo...
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git
for-next
compiler: riscv64-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
cppcheck possible warnings: (new ones prefixed by >>, may not real problems)
>> drivers/soc/mediatek/mtk-mmsys.c:104:6: warning: Unused variable: i [unusedVariable]
int i;
^
vim +104 drivers/soc/mediatek/mtk-mmsys.c
2c758e301ed95a Enric Balletbo i Serra 2020-03-25 97 08a3068f9490f0
Enric Balletbo i Serra 2021-07-14 98 static int
mtk_mmsys_reset_update(struct reset_controller_dev *rcdev, unsigned long id,
08a3068f9490f0 Enric Balletbo i Serra 2021-07-14 99 bool assert)
08a3068f9490f0 Enric Balletbo i Serra 2021-07-14 100 {
08a3068f9490f0 Enric Balletbo i Serra 2021-07-14 101 struct mtk_mmsys
*mmsys = container_of(rcdev, struct mtk_mmsys, rcdev);
08a3068f9490f0 Enric Balletbo i Serra 2021-07-14 102 unsigned long flags;
08a3068f9490f0 Enric Balletbo i Serra 2021-07-14 103 u32 reg;
08a3068f9490f0 Enric Balletbo i Serra 2021-07-14 @104 int i;
08a3068f9490f0 Enric Balletbo i Serra 2021-07-14 105 08a3068f9490f0
Enric Balletbo i Serra 2021-07-14 106 spin_lock_irqsave(&mmsys->lock,
flags);
08a3068f9490f0 Enric Balletbo i Serra 2021-07-14 107 08a3068f9490f0
Enric Balletbo i Serra 2021-07-14 108 reg = readl_relaxed(mmsys->regs
+ MMSYS_SW0_RST_B);
08a3068f9490f0 Enric Balletbo i Serra 2021-07-14 109 08a3068f9490f0
Enric Balletbo i Serra 2021-07-14 110 if (assert)
08a3068f9490f0 Enric Balletbo i Serra 2021-07-14 111 reg &= ~BIT(id);
08a3068f9490f0 Enric Balletbo i Serra 2021-07-14 112 else
08a3068f9490f0 Enric Balletbo i Serra 2021-07-14 113 reg |= BIT(id);
08a3068f9490f0 Enric Balletbo i Serra 2021-07-14 114 08a3068f9490f0
Enric Balletbo i Serra 2021-07-14 115 writel_relaxed(reg, mmsys->regs
+ MMSYS_SW0_RST_B);
08a3068f9490f0 Enric Balletbo i Serra 2021-07-14 116 08a3068f9490f0
Enric Balletbo i Serra 2021-07-14 117
spin_unlock_irqrestore(&mmsys->lock, flags);
08a3068f9490f0 Enric Balletbo i Serra 2021-07-14 118 08a3068f9490f0
Enric Balletbo i Serra 2021-07-14 119 return 0;
08a3068f9490f0 Enric Balletbo i Serra 2021-07-14 120 }
08a3068f9490f0 Enric Balletbo i Serra 2021-07-14 121
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 2 months
Re: [PATCH v2 6/7] soc: mediatek: mmsys: Add reset controller support
by kernel test robot
Hi Enric,
I love your patch! Perhaps something to improve:
[auto build test WARNING on robh/for-next]
[also build test WARNING on pza/reset/next linux/master linus/master
v5.14-rc1 next-20210714]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Enric-Balletbo-i-Serra/Add-suppo...
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git
for-next
:::::: branch date: 14 hours ago
:::::: commit date: 14 hours ago
compiler: riscv64-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
cppcheck possible warnings: (new ones prefixed by >>, may not real problems)
>> drivers/soc/mediatek/mtk-mmsys.c:104:6: warning: Unused variable: i [unusedVariable]
int i;
^
vim +104 drivers/soc/mediatek/mtk-mmsys.c
2c758e301ed95a Enric Balletbo i Serra 2020-03-25 97 08a3068f9490f0
Enric Balletbo i Serra 2021-07-14 98 static int
mtk_mmsys_reset_update(struct reset_controller_dev *rcdev, unsigned long id,
08a3068f9490f0 Enric Balletbo i Serra 2021-07-14 99 bool assert)
08a3068f9490f0 Enric Balletbo i Serra 2021-07-14 100 {
08a3068f9490f0 Enric Balletbo i Serra 2021-07-14 101 struct mtk_mmsys
*mmsys = container_of(rcdev, struct mtk_mmsys, rcdev);
08a3068f9490f0 Enric Balletbo i Serra 2021-07-14 102 unsigned long flags;
08a3068f9490f0 Enric Balletbo i Serra 2021-07-14 103 u32 reg;
08a3068f9490f0 Enric Balletbo i Serra 2021-07-14 @104 int i;
08a3068f9490f0 Enric Balletbo i Serra 2021-07-14 105 08a3068f9490f0
Enric Balletbo i Serra 2021-07-14 106 spin_lock_irqsave(&mmsys->lock,
flags);
08a3068f9490f0 Enric Balletbo i Serra 2021-07-14 107 08a3068f9490f0
Enric Balletbo i Serra 2021-07-14 108 reg = readl_relaxed(mmsys->regs
+ MMSYS_SW0_RST_B);
08a3068f9490f0 Enric Balletbo i Serra 2021-07-14 109 08a3068f9490f0
Enric Balletbo i Serra 2021-07-14 110 if (assert)
08a3068f9490f0 Enric Balletbo i Serra 2021-07-14 111 reg &= ~BIT(id);
08a3068f9490f0 Enric Balletbo i Serra 2021-07-14 112 else
08a3068f9490f0 Enric Balletbo i Serra 2021-07-14 113 reg |= BIT(id);
08a3068f9490f0 Enric Balletbo i Serra 2021-07-14 114 08a3068f9490f0
Enric Balletbo i Serra 2021-07-14 115 writel_relaxed(reg, mmsys->regs
+ MMSYS_SW0_RST_B);
08a3068f9490f0 Enric Balletbo i Serra 2021-07-14 116 08a3068f9490f0
Enric Balletbo i Serra 2021-07-14 117
spin_unlock_irqrestore(&mmsys->lock, flags);
08a3068f9490f0 Enric Balletbo i Serra 2021-07-14 118 08a3068f9490f0
Enric Balletbo i Serra 2021-07-14 119 return 0;
08a3068f9490f0 Enric Balletbo i Serra 2021-07-14 120 }
08a3068f9490f0 Enric Balletbo i Serra 2021-07-14 121
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 2 months
[sashal-linux-stable:pending-5.13 51/176] drivers/infiniband/ulp/rtrs/rtrs-clt.c:1789:19: warning: result of comparison of constant 'MAX_SESS_QUEUE_DEPTH' (65536) with expression of type 'u16' (aka 'unsigned short') is always false
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git pending-5.13
head: 9e20d32ceee869b30775be931beb33f561a4f955
commit: 6d51e8a0a9e776dcd01f15fa0ea6d3ba0861e8b3 [51/176] RDMA/rtrs: Change MAX_SESS_QUEUE_DEPTH
config: x86_64-randconfig-a015-20210716 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 5d5b08761f944d5b9822d582378333cc4b36a0a7)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git/c...
git remote add sashal-linux-stable https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git
git fetch --no-tags sashal-linux-stable pending-5.13
git checkout 6d51e8a0a9e776dcd01f15fa0ea6d3ba0861e8b3
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/infiniband/ulp/rtrs/rtrs-clt.c:1789:19: warning: result of comparison of constant 'MAX_SESS_QUEUE_DEPTH' (65536) with expression of type 'u16' (aka 'unsigned short') is always false [-Wtautological-constant-out-of-range-compare]
if (queue_depth > MAX_SESS_QUEUE_DEPTH) {
~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~
1 warning generated.
vim +1789 drivers/infiniband/ulp/rtrs/rtrs-clt.c
6a98d71daea186 Jack Wang 2020-05-11 1753
6a98d71daea186 Jack Wang 2020-05-11 1754 static int rtrs_rdma_conn_established(struct rtrs_clt_con *con,
6a98d71daea186 Jack Wang 2020-05-11 1755 struct rdma_cm_event *ev)
6a98d71daea186 Jack Wang 2020-05-11 1756 {
6a98d71daea186 Jack Wang 2020-05-11 1757 struct rtrs_clt_sess *sess = to_clt_sess(con->c.sess);
6a98d71daea186 Jack Wang 2020-05-11 1758 struct rtrs_clt *clt = sess->clt;
6a98d71daea186 Jack Wang 2020-05-11 1759 const struct rtrs_msg_conn_rsp *msg;
6a98d71daea186 Jack Wang 2020-05-11 1760 u16 version, queue_depth;
6a98d71daea186 Jack Wang 2020-05-11 1761 int errno;
6a98d71daea186 Jack Wang 2020-05-11 1762 u8 len;
6a98d71daea186 Jack Wang 2020-05-11 1763
6a98d71daea186 Jack Wang 2020-05-11 1764 msg = ev->param.conn.private_data;
6a98d71daea186 Jack Wang 2020-05-11 1765 len = ev->param.conn.private_data_len;
6a98d71daea186 Jack Wang 2020-05-11 1766 if (len < sizeof(*msg)) {
6a98d71daea186 Jack Wang 2020-05-11 1767 rtrs_err(clt, "Invalid RTRS connection response\n");
6a98d71daea186 Jack Wang 2020-05-11 1768 return -ECONNRESET;
6a98d71daea186 Jack Wang 2020-05-11 1769 }
6a98d71daea186 Jack Wang 2020-05-11 1770 if (le16_to_cpu(msg->magic) != RTRS_MAGIC) {
6a98d71daea186 Jack Wang 2020-05-11 1771 rtrs_err(clt, "Invalid RTRS magic\n");
6a98d71daea186 Jack Wang 2020-05-11 1772 return -ECONNRESET;
6a98d71daea186 Jack Wang 2020-05-11 1773 }
6a98d71daea186 Jack Wang 2020-05-11 1774 version = le16_to_cpu(msg->version);
6a98d71daea186 Jack Wang 2020-05-11 1775 if (version >> 8 != RTRS_PROTO_VER_MAJOR) {
6a98d71daea186 Jack Wang 2020-05-11 1776 rtrs_err(clt, "Unsupported major RTRS version: %d, expected %d\n",
6a98d71daea186 Jack Wang 2020-05-11 1777 version >> 8, RTRS_PROTO_VER_MAJOR);
6a98d71daea186 Jack Wang 2020-05-11 1778 return -ECONNRESET;
6a98d71daea186 Jack Wang 2020-05-11 1779 }
6a98d71daea186 Jack Wang 2020-05-11 1780 errno = le16_to_cpu(msg->errno);
6a98d71daea186 Jack Wang 2020-05-11 1781 if (errno) {
6a98d71daea186 Jack Wang 2020-05-11 1782 rtrs_err(clt, "Invalid RTRS message: errno %d\n",
6a98d71daea186 Jack Wang 2020-05-11 1783 errno);
6a98d71daea186 Jack Wang 2020-05-11 1784 return -ECONNRESET;
6a98d71daea186 Jack Wang 2020-05-11 1785 }
6a98d71daea186 Jack Wang 2020-05-11 1786 if (con->c.cid == 0) {
6a98d71daea186 Jack Wang 2020-05-11 1787 queue_depth = le16_to_cpu(msg->queue_depth);
6a98d71daea186 Jack Wang 2020-05-11 1788
6a98d71daea186 Jack Wang 2020-05-11 @1789 if (queue_depth > MAX_SESS_QUEUE_DEPTH) {
6a98d71daea186 Jack Wang 2020-05-11 1790 rtrs_err(clt, "Invalid RTRS message: queue=%d\n",
6a98d71daea186 Jack Wang 2020-05-11 1791 queue_depth);
6a98d71daea186 Jack Wang 2020-05-11 1792 return -ECONNRESET;
6a98d71daea186 Jack Wang 2020-05-11 1793 }
84d3b0760dfc0d Md Haris Iqbal 2021-05-28 1794 if (sess->queue_depth > 0 && queue_depth != sess->queue_depth) {
84d3b0760dfc0d Md Haris Iqbal 2021-05-28 1795 rtrs_err(clt, "Error: queue depth changed\n");
84d3b0760dfc0d Md Haris Iqbal 2021-05-28 1796
84d3b0760dfc0d Md Haris Iqbal 2021-05-28 1797 /*
84d3b0760dfc0d Md Haris Iqbal 2021-05-28 1798 * Stop any more reconnection attempts
84d3b0760dfc0d Md Haris Iqbal 2021-05-28 1799 */
84d3b0760dfc0d Md Haris Iqbal 2021-05-28 1800 sess->reconnect_attempts = -1;
84d3b0760dfc0d Md Haris Iqbal 2021-05-28 1801 rtrs_err(clt,
84d3b0760dfc0d Md Haris Iqbal 2021-05-28 1802 "Disabling auto-reconnect. Trigger a manual reconnect after issue is resolved\n");
84d3b0760dfc0d Md Haris Iqbal 2021-05-28 1803 return -ECONNRESET;
84d3b0760dfc0d Md Haris Iqbal 2021-05-28 1804 }
84d3b0760dfc0d Md Haris Iqbal 2021-05-28 1805
84d3b0760dfc0d Md Haris Iqbal 2021-05-28 1806 if (!sess->rbufs) {
6a98d71daea186 Jack Wang 2020-05-11 1807 kfree(sess->rbufs);
6a98d71daea186 Jack Wang 2020-05-11 1808 sess->rbufs = kcalloc(queue_depth, sizeof(*sess->rbufs),
6a98d71daea186 Jack Wang 2020-05-11 1809 GFP_KERNEL);
6a98d71daea186 Jack Wang 2020-05-11 1810 if (!sess->rbufs)
6a98d71daea186 Jack Wang 2020-05-11 1811 return -ENOMEM;
6a98d71daea186 Jack Wang 2020-05-11 1812 }
6a98d71daea186 Jack Wang 2020-05-11 1813 sess->queue_depth = queue_depth;
6a98d71daea186 Jack Wang 2020-05-11 1814 sess->max_hdr_size = le32_to_cpu(msg->max_hdr_size);
6a98d71daea186 Jack Wang 2020-05-11 1815 sess->max_io_size = le32_to_cpu(msg->max_io_size);
6a98d71daea186 Jack Wang 2020-05-11 1816 sess->flags = le32_to_cpu(msg->flags);
6a98d71daea186 Jack Wang 2020-05-11 1817 sess->chunk_size = sess->max_io_size + sess->max_hdr_size;
6a98d71daea186 Jack Wang 2020-05-11 1818
6a98d71daea186 Jack Wang 2020-05-11 1819 /*
84d3b0760dfc0d Md Haris Iqbal 2021-05-28 1820 * Global IO size is always a minimum.
6a98d71daea186 Jack Wang 2020-05-11 1821 * If while a reconnection server sends us a value a bit
6a98d71daea186 Jack Wang 2020-05-11 1822 * higher - client does not care and uses cached minimum.
6a98d71daea186 Jack Wang 2020-05-11 1823 *
6a98d71daea186 Jack Wang 2020-05-11 1824 * Since we can have several sessions (paths) restablishing
6a98d71daea186 Jack Wang 2020-05-11 1825 * connections in parallel, use lock.
6a98d71daea186 Jack Wang 2020-05-11 1826 */
6a98d71daea186 Jack Wang 2020-05-11 1827 mutex_lock(&clt->paths_mutex);
84d3b0760dfc0d Md Haris Iqbal 2021-05-28 1828 clt->queue_depth = sess->queue_depth;
6a98d71daea186 Jack Wang 2020-05-11 1829 clt->max_io_size = min_not_zero(sess->max_io_size,
6a98d71daea186 Jack Wang 2020-05-11 1830 clt->max_io_size);
6a98d71daea186 Jack Wang 2020-05-11 1831 mutex_unlock(&clt->paths_mutex);
6a98d71daea186 Jack Wang 2020-05-11 1832
6a98d71daea186 Jack Wang 2020-05-11 1833 /*
6a98d71daea186 Jack Wang 2020-05-11 1834 * Cache the hca_port and hca_name for sysfs
6a98d71daea186 Jack Wang 2020-05-11 1835 */
6a98d71daea186 Jack Wang 2020-05-11 1836 sess->hca_port = con->c.cm_id->port_num;
6a98d71daea186 Jack Wang 2020-05-11 1837 scnprintf(sess->hca_name, sizeof(sess->hca_name),
6a98d71daea186 Jack Wang 2020-05-11 1838 sess->s.dev->ib_dev->name);
6a98d71daea186 Jack Wang 2020-05-11 1839 sess->s.src_addr = con->c.cm_id->route.addr.src_addr;
03e9b33a0fd677 Md Haris Iqbal 2021-02-12 1840 /* set for_new_clt, to allow future reconnect on any path */
03e9b33a0fd677 Md Haris Iqbal 2021-02-12 1841 sess->for_new_clt = 1;
6a98d71daea186 Jack Wang 2020-05-11 1842 }
6a98d71daea186 Jack Wang 2020-05-11 1843
6a98d71daea186 Jack Wang 2020-05-11 1844 return 0;
6a98d71daea186 Jack Wang 2020-05-11 1845 }
6a98d71daea186 Jack Wang 2020-05-11 1846
:::::: The code at line 1789 was first introduced by commit
:::::: 6a98d71daea186247005099758af549e6afdd244 RDMA/rtrs: client: main functionality
:::::: TO: Jack Wang <jinpu.wang(a)cloud.ionos.com>
:::::: CC: Jason Gunthorpe <jgg(a)mellanox.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 2 months
[PATCH] crypto: fix flexible_array.cocci warnings
by Julia Lawall
From: kernel test robot <lkp(a)intel.com>
Zero-length and one-element arrays are deprecated, see
Documentation/process/deprecated.rst
Flexible-array members should be used instead.
Generated by: scripts/coccinelle/misc/flexible_array.cocci
Fixes: 7540b2861e52 ("crypto: aesni - AVX512 version of AESNI-GCM using VPCLMULQDQ")
CC: Megha Dey <megha.dey(a)intel.com>
Reported-by: kernel test robot <lkp(a)intel.com>
Signed-off-by: kernel test robot <lkp(a)intel.com>
Signed-off-by: Julia Lawall <julia.lawall(a)inria.fr>
---
tree: https://github.com/meghadey/crypto for_crypto_avx512
head: a89c5880f0d6260dd593bf579df26f2a2d56ac32
commit: 7540b2861e5292b5993f8e693fc69510b2a7277a [5/6] crypto: aesni - AVX512 version of AESNI-GCM using VPCLMULQDQ
:::::: branch date: 7 hours ago
:::::: commit date: 7 hours ago
aesni-intel_glue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/arch/x86/crypto/aesni-intel_glue.c
+++ b/arch/x86/crypto/aesni-intel_glue.c
@@ -87,7 +87,7 @@ struct gcm_context_data {
u64 partial_block_len;
u64 unused;
/* Allocate space for hash_keys later */
- u8 hash_keys[0];
+ u8 hash_keys[];
};
asmlinkage int aesni_set_key(struct crypto_aes_ctx *ctx, const u8 *in_key,
1 year, 2 months
Re: [PATCH v5 1/2] iio: frequency: adrf6780: add support for ADRF6780
by kernel test robot
Hi Antoniu,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on iio/togreg]
[also build test WARNING on linux/master linus/master v5.14-rc1 next-20210715]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Antoniu-Miclaus/iio-frequency-ad...
base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
config: arm64-randconfig-r026-20210716 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 5d5b08761f944d5b9822d582378333cc4b36a0a7)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/0day-ci/linux/commit/50ec72e90468dea68ad72e14023fdf58d...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Antoniu-Miclaus/iio-frequency-adrf6780-add-support-for-ADRF6780/20210715-194501
git checkout 50ec72e90468dea68ad72e14023fdf58d5eb0885
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/iio/frequency/adrf6780.c:189:40: warning: variable 'data' is uninitialized when used here [-Wuninitialized]
ret = adrf6780_read_voltage_raw(dev, data);
^~~~
drivers/iio/frequency/adrf6780.c:184:19: note: initialize the variable 'data' to silence this warning
unsigned int data;
^
= 0
1 warning generated.
vim +/data +189 drivers/iio/frequency/adrf6780.c
178
179 static int adrf6780_read_raw(struct iio_dev *indio_dev,
180 struct iio_chan_spec const *chan,
181 int *val, int *val2, long info)
182 {
183 struct adrf6780_dev *dev = iio_priv(indio_dev);
184 unsigned int data;
185 int ret;
186
187 switch (info) {
188 case IIO_CHAN_INFO_RAW:
> 189 ret = adrf6780_read_voltage_raw(dev, data);
190 if (ret)
191 return ret;
192
193 *val = data & ADRF6780_ADC_VALUE_MSK;
194
195 return IIO_VAL_INT;
196
197 case IIO_CHAN_INFO_SCALE:
198 ret = adrf6780_spi_read(dev, ADRF6780_REG_LINEARIZE, &data);
199 if (ret)
200 return ret;
201
202 *val = data & ADRF6780_RDAC_LINEARIZE_MSK;
203
204 return IIO_VAL_INT;
205 case IIO_CHAN_INFO_PHASE:
206 ret = adrf6780_spi_read(dev, ADRF6780_REG_LO_PATH, &data);
207 if (ret)
208 return ret;
209
210 switch (chan->channel2) {
211 case IIO_MOD_I:
212 *val = data & ADRF6780_I_PATH_PHASE_ACCURACY_MSK;
213
214 return IIO_VAL_INT;
215 case IIO_MOD_Q:
216 *val = FIELD_GET(ADRF6780_Q_PATH_PHASE_ACCURACY_MSK, data);
217
218 return IIO_VAL_INT;
219 default:
220 return -EINVAL;
221 }
222 default:
223 return -EINVAL;
224 }
225 }
226
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 2 months
