Re: [Intel-gfx] [PATCH 5/5] drm/i915/debugfs: pass intel_connector to intel_connector_debugfs_add()
by kernel test robot
Hi Jani,
I love your patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on drm-tip/drm-tip next-20210831]
[cannot apply to v5.14]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Jani-Nikula/drm-i915-display-deb...
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-randconfig-a014-20210831 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 4b1fde8a2b681dad2ce0c082a5d6422caa06b0bc)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/3398bb6468f037af818548e7987e8fd06...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Jani-Nikula/drm-i915-display-debugfs-cleanups/20210830-205450
git checkout 3398bb6468f037af818548e7987e8fd062278824
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> drivers/gpu/drm/i915/display/intel_connector.c:127:30: error: incompatible pointer types passing 'struct intel_connector *' to parameter of type 'struct drm_connector *' [-Werror,-Wincompatible-pointer-types]
intel_connector_debugfs_add(intel_connector);
^~~~~~~~~~~~~~~
drivers/gpu/drm/i915/display/intel_display_debugfs.h:15:56: note: passing argument to parameter 'connector' here
void intel_connector_debugfs_add(struct drm_connector *connector);
^
1 error generated.
--
>> drivers/gpu/drm/i915/display/intel_display_debugfs.c:2447:6: error: conflicting types for 'intel_connector_debugfs_add'
void intel_connector_debugfs_add(struct intel_connector *intel_connector)
^
drivers/gpu/drm/i915/display/intel_display_debugfs.h:15:6: note: previous declaration is here
void intel_connector_debugfs_add(struct drm_connector *connector);
^
1 error generated.
vim +127 drivers/gpu/drm/i915/display/intel_connector.c
112
113 int intel_connector_register(struct drm_connector *connector)
114 {
115 struct intel_connector *intel_connector = to_intel_connector(connector);
116 int ret;
117
118 ret = intel_backlight_device_register(intel_connector);
119 if (ret)
120 goto err;
121
122 if (i915_inject_probe_failure(to_i915(connector->dev))) {
123 ret = -EFAULT;
124 goto err_backlight;
125 }
126
> 127 intel_connector_debugfs_add(intel_connector);
128
129 return 0;
130
131 err_backlight:
132 intel_backlight_device_unregister(intel_connector);
133 err:
134 return ret;
135 }
136
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
11 months, 2 weeks
Re: [PATCH 3/3] drivers: iio: chemical: Add support for Sensirion SCD4x CO2 sensor
by kernel test robot
Hi Roan,
I love your patch! Perhaps something to improve:
[auto build test WARNING on robh/for-next]
[also build test WARNING on linux/master linus/master v5.14]
[cannot apply to iio/togreg next-20210831]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Roan-van-Dijk/iio-chemical-Add-s...
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: mips-allyesconfig (attached as .config)
compiler: mips-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/605896bbee687d465d4ae58d910878e9b...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Roan-van-Dijk/iio-chemical-Add-support-for-Sensirion-SCD4x-CO2-sensor/20210831-202025
git checkout 605896bbee687d465d4ae58d910878e9b85f0035
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=mips
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/iio/chemical/scd4x.c:503:20: warning: no previous prototype for 'scd4x_suspend' [-Wmissing-prototypes]
503 | int __maybe_unused scd4x_suspend(struct device *dev)
| ^~~~~~~~~~~~~
>> drivers/iio/chemical/scd4x.c:517:20: warning: no previous prototype for 'scd4x_resume' [-Wmissing-prototypes]
517 | int __maybe_unused scd4x_resume(struct device *dev)
| ^~~~~~~~~~~~
>> drivers/iio/chemical/scd4x.c:613:5: warning: no previous prototype for 'scd4x_probe' [-Wmissing-prototypes]
613 | int scd4x_probe(struct i2c_client *client, const struct i2c_device_id *id)
| ^~~~~~~~~~~
vim +/scd4x_suspend +503 drivers/iio/chemical/scd4x.c
502
> 503 int __maybe_unused scd4x_suspend(struct device *dev)
504 {
505 struct iio_dev *indio_dev = dev_get_drvdata(dev);
506 struct scd4x_state *state = iio_priv(indio_dev);
507 int ret;
508
509 ret = scd4x_send_command(state, CMD_STOP_MEAS);
510 if (ret)
511 return ret;
512
513 return regulator_disable(state->vdd);
514 }
515 EXPORT_SYMBOL(scd4x_suspend);
516
> 517 int __maybe_unused scd4x_resume(struct device *dev)
518 {
519 struct iio_dev *indio_dev = dev_get_drvdata(dev);
520 struct scd4x_state *state = iio_priv(indio_dev);
521 int ret;
522
523 ret = regulator_enable(state->vdd);
524 if (ret)
525 return ret;
526
527 return scd4x_send_command(state, CMD_START_MEAS);
528 }
529 EXPORT_SYMBOL(scd4x_resume);
530
531 static void scd4x_stop_meas(void *data)
532 {
533 struct scd4x_state *state = data;
534
535 scd4x_send_command(state, CMD_STOP_MEAS);
536 }
537
538 static void scd4x_disable_regulator(void *data)
539 {
540 struct scd4x_state *state = data;
541
542 regulator_disable(state->vdd);
543 }
544
545 static irqreturn_t scd4x_trigger_handler(int irq, void *p)
546 {
547 struct iio_poll_func *pf = p;
548 struct iio_dev *indio_dev = pf->indio_dev;
549 struct scd4x_state *state = iio_priv(indio_dev);
550 struct {
551 int data[3];
552 int64_t ts __aligned(8);
553 } scan;
554 int ret;
555
556 mutex_lock(&state->lock);
557 ret = scd4x_read_poll(state);
558 memset(&scan, 0, sizeof(scan));
559 memcpy(scan.data, state->meas, sizeof(state->meas));
560 mutex_unlock(&state->lock);
561 if (ret)
562 goto out;
563
564 iio_push_to_buffers_with_timestamp(indio_dev, &scan, iio_get_time_ns(indio_dev));
565 out:
566 iio_trigger_notify_done(indio_dev->trig);
567 return IRQ_HANDLED;
568 }
569
570 static int scd4x_set_trigger_state(struct iio_trigger *trig, bool state)
571 {
572 struct iio_dev *indio_dev = iio_trigger_get_drvdata(trig);
573 struct scd4x_state *st = iio_priv(indio_dev);
574
575 if (state)
576 enable_irq(st->irq);
577 else
578 disable_irq(st->irq);
579
580 return 0;
581 }
582
583 static const struct iio_trigger_ops scd4x_trigger_ops = {
584 .set_trigger_state = scd4x_set_trigger_state,
585 .validate_device = iio_trigger_validate_own_device,
586 };
587
588 static int scd4x_setup_trigger(struct iio_dev *indio_dev)
589 {
590 struct device *dev = indio_dev->dev.parent;
591 struct iio_trigger *trig;
592 int ret;
593
594 trig = devm_iio_trigger_alloc(dev, "%s-dev%d", indio_dev->name,
595 iio_device_id(indio_dev));
596 if (!trig) {
597 dev_err(dev, "failed to allocate trigger\n");
598 return -ENOMEM;
599 }
600
601 trig->ops = &scd4x_trigger_ops;
602 iio_trigger_set_drvdata(trig, indio_dev);
603
604 ret = devm_iio_trigger_register(dev, trig);
605 if (ret)
606 return ret;
607
608 indio_dev->trig = iio_trigger_get(trig);
609
610 return ret;
611 }
612
> 613 int scd4x_probe(struct i2c_client *client, const struct i2c_device_id *id)
614 {
615 static const unsigned long scd4x_scan_masks[] = { 0x07, 0x00 };
616 struct device *dev = &client->dev;
617 struct iio_dev *indio_dev;
618 struct scd4x_state *state;
619 int ret;
620
621 indio_dev = devm_iio_device_alloc(dev, sizeof(*state));
622 if (!indio_dev)
623 return -ENOMEM;
624
625 state = iio_priv(indio_dev);
626 mutex_init(&state->lock);
627 state->dev = dev;
628 crc8_populate_msb(scd4x_crc8_table, SCD4X_CRC8_POLYNOMIAL);
629
630 indio_dev->info = &scd4x_info;
631 indio_dev->name = client->name;
632 indio_dev->channels = scd4x_channels;
633 indio_dev->num_channels = ARRAY_SIZE(scd4x_channels);
634 indio_dev->modes = INDIO_DIRECT_MODE | INDIO_BUFFER_TRIGGERED;
635 indio_dev->available_scan_masks = scd4x_scan_masks;
636
637 state->vdd = devm_regulator_get(dev, "vdd");
638 if (IS_ERR(state->vdd))
639 return dev_err_probe(dev, PTR_ERR(state->vdd), "failed to get regulator\n");
640
641 ret = regulator_enable(state->vdd);
642 if (ret)
643 return ret;
644
645 ret = devm_add_action_or_reset(dev, scd4x_disable_regulator, state);
646 if (ret)
647 return ret;
648
649 ret = scd4x_send_command(state, CMD_STOP_MEAS);
650 if (ret) {
651 dev_err(dev, "failed to stop measurement: %d\n", ret);
652 return ret;
653 }
654
655 /* execution time */
656 msleep_interruptible(500);
657
658 if (state->irq > 0) {
659 ret = scd4x_setup_trigger(indio_dev);
660 if (ret) {
661 dev_err(dev, "failed to setup trigger: %d\n", ret);
662 return ret;
663 }
664 }
665
666 ret = devm_iio_triggered_buffer_setup(dev, indio_dev, NULL, scd4x_trigger_handler, NULL);
667 if (ret)
668 return ret;
669
670 ret = devm_iio_device_register(dev, indio_dev);
671 if (ret) {
672 dev_err(dev, "failed to register iio device\n");
673 return ret;
674 }
675
676 ret = scd4x_send_command(state, CMD_START_MEAS);
677 if (ret) {
678 dev_err(dev, "failed to start measurement: %d\n", ret);
679 return ret;
680 }
681
682 ret = devm_add_action_or_reset(dev, scd4x_stop_meas, state);
683 if (ret)
684 return ret;
685
686 return 0;
687 }
688 EXPORT_SYMBOL(scd4x_probe);
689
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
11 months, 2 weeks
[jens.wiklander-linux-tee:optee_ffa_v5 4/5] drivers/tee/optee/smc_abi.c:323:6: warning: no previous prototype for function 'optee_disable_shm_cache'
by kernel test robot
tree: http://git.linaro.org/people/jens.wiklander/linux-tee optee_ffa_v5
head: 1556d10d3bf79a95ea971b845a22d93395b95083
commit: d3d8fea9b4b740e6168701116eaf90f4722c1eb7 [4/5] optee: isolate smc abi
config: arm64-randconfig-r023-20210831 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 4b1fde8a2b681dad2ce0c082a5d6422caa06b0bc)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
git remote add jens.wiklander-linux-tee http://git.linaro.org/people/jens.wiklander/linux-tee
git fetch --no-tags jens.wiklander-linux-tee optee_ffa_v5
git checkout d3d8fea9b4b740e6168701116eaf90f4722c1eb7
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/tee/optee/smc_abi.c:323:6: warning: no previous prototype for function 'optee_disable_shm_cache' [-Wmissing-prototypes]
void optee_disable_shm_cache(struct optee *optee)
^
drivers/tee/optee/smc_abi.c:323:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void optee_disable_shm_cache(struct optee *optee)
^
static
>> drivers/tee/optee/smc_abi.c:334:6: warning: no previous prototype for function 'optee_disable_unmapped_shm_cache' [-Wmissing-prototypes]
void optee_disable_unmapped_shm_cache(struct optee *optee)
^
drivers/tee/optee/smc_abi.c:334:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void optee_disable_unmapped_shm_cache(struct optee *optee)
^
static
2 warnings generated.
vim +/optee_disable_shm_cache +323 drivers/tee/optee/smc_abi.c
317
318 /**
319 * optee_disable_shm_cache() - Disables caching of mapped shared memory
320 * allocations in OP-TEE
321 * @optee: main service struct
322 */
> 323 void optee_disable_shm_cache(struct optee *optee)
324 {
325 return __optee_disable_shm_cache(optee, true);
326 }
327
328 /**
329 * optee_disable_unmapped_shm_cache() - Disables caching of shared memory
330 * allocations in OP-TEE which are not
331 * currently mapped
332 * @optee: main service struct
333 */
> 334 void optee_disable_unmapped_shm_cache(struct optee *optee)
335 {
336 return __optee_disable_shm_cache(optee, false);
337 }
338
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
11 months, 2 weeks
[trace:ftrace/core 35/39] kernel/trace/trace_boot.c:420:4: warning: misleading indentation; statement is not part of the previous 'if'
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git ftrace/core
head: 3dc65994e3c1c999be3d991cdc96705e167cb3b1
commit: 5d4648a0415efc239ffb377bce1d389723eda25d [35/39] tracing/boot: Show correct histogram error command
config: x86_64-randconfig-a015-20210831 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 4b1fde8a2b681dad2ce0c082a5d6422caa06b0bc)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git/c...
git remote add trace https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git
git fetch --no-tags trace ftrace/core
git checkout 5d4648a0415efc239ffb377bce1d389723eda25d
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> kernel/trace/trace_boot.c:420:4: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation]
if (trigger_process_regex(file, buf) < 0)
^
kernel/trace/trace_boot.c:418:3: note: previous statement is here
if (trace_boot_compose_hist_cmd(hnode, buf, size) == 0)
^
1 warning generated.
vim +/if +420 kernel/trace/trace_boot.c
30cb856e3067e5 Masami Hiramatsu 2021-08-06 395
30cb856e3067e5 Masami Hiramatsu 2021-08-06 396 static void __init
30cb856e3067e5 Masami Hiramatsu 2021-08-06 397 trace_boot_init_histograms(struct trace_event_file *file,
30cb856e3067e5 Masami Hiramatsu 2021-08-06 398 struct xbc_node *hnode, char *buf, size_t size)
30cb856e3067e5 Masami Hiramatsu 2021-08-06 399 {
30cb856e3067e5 Masami Hiramatsu 2021-08-06 400 struct xbc_node *node;
30cb856e3067e5 Masami Hiramatsu 2021-08-06 401 const char *p;
5d4648a0415efc Masami Hiramatsu 2021-08-06 402 char *tmp;
30cb856e3067e5 Masami Hiramatsu 2021-08-06 403
30cb856e3067e5 Masami Hiramatsu 2021-08-06 404 xbc_node_for_each_subkey(hnode, node) {
30cb856e3067e5 Masami Hiramatsu 2021-08-06 405 p = xbc_node_get_data(node);
30cb856e3067e5 Masami Hiramatsu 2021-08-06 406 if (!isdigit(p[0]))
30cb856e3067e5 Masami Hiramatsu 2021-08-06 407 continue;
30cb856e3067e5 Masami Hiramatsu 2021-08-06 408 /* All digit started node should be instances. */
30cb856e3067e5 Masami Hiramatsu 2021-08-06 409 if (trace_boot_compose_hist_cmd(node, buf, size) == 0) {
5d4648a0415efc Masami Hiramatsu 2021-08-06 410 tmp = kstrdup(buf, GFP_KERNEL);
30cb856e3067e5 Masami Hiramatsu 2021-08-06 411 if (trigger_process_regex(file, buf) < 0)
5d4648a0415efc Masami Hiramatsu 2021-08-06 412 pr_err("Failed to apply hist trigger: %s\n", tmp);
5d4648a0415efc Masami Hiramatsu 2021-08-06 413 kfree(tmp);
30cb856e3067e5 Masami Hiramatsu 2021-08-06 414 }
30cb856e3067e5 Masami Hiramatsu 2021-08-06 415 }
30cb856e3067e5 Masami Hiramatsu 2021-08-06 416
30cb856e3067e5 Masami Hiramatsu 2021-08-06 417 if (xbc_node_find_child(hnode, "keys")) {
30cb856e3067e5 Masami Hiramatsu 2021-08-06 418 if (trace_boot_compose_hist_cmd(hnode, buf, size) == 0)
5d4648a0415efc Masami Hiramatsu 2021-08-06 419 tmp = kstrdup(buf, GFP_KERNEL);
30cb856e3067e5 Masami Hiramatsu 2021-08-06 @420 if (trigger_process_regex(file, buf) < 0)
5d4648a0415efc Masami Hiramatsu 2021-08-06 421 pr_err("Failed to apply hist trigger: %s\n", tmp);
5d4648a0415efc Masami Hiramatsu 2021-08-06 422 kfree(tmp);
30cb856e3067e5 Masami Hiramatsu 2021-08-06 423 }
30cb856e3067e5 Masami Hiramatsu 2021-08-06 424
:::::: The code at line 420 was first introduced by commit
:::::: 30cb856e3067e5d6ae7b2144e1659145ab7686fd tracing/boot: Support multiple histograms for each event
:::::: TO: Masami Hiramatsu <mhiramat(a)kernel.org>
:::::: CC: Steven Rostedt (VMware) <rostedt(a)goodmis.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
11 months, 2 weeks
Re: [PATCH 1/2] pinctrl: pimux: Add support to save and restore HW register
by kernel test robot
Hi Prathamesh,
I love your patch! Perhaps something to improve:
[auto build test WARNING on pinctrl/devel]
[also build test WARNING on tegra/for-next v5.14 next-20210831]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Prathamesh-Shete/pinctrl-support...
base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
config: s390-allmodconfig (attached as .config)
compiler: s390-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/8c99cc4cd4b322e1a4dd6fb0e031a432a...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Prathamesh-Shete/pinctrl-support-to-save-and-restore-GPIO-conf/20210831-133414
git checkout 8c99cc4cd4b322e1a4dd6fb0e031a432ad768596
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=s390
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
In file included from drivers/pinctrl/core.c:36:
>> drivers/pinctrl/pinmux.h:98:5: warning: no previous prototype for 'pinmux_gpio_save_config' [-Wmissing-prototypes]
98 | int pinmux_gpio_save_config(struct pinctrl_dev *pctldev,
| ^~~~~~~~~~~~~~~~~~~~~~~
>> drivers/pinctrl/pinmux.h:104:5: warning: no previous prototype for 'pinmux_gpio_restore_config' [-Wmissing-prototypes]
104 | int pinmux_gpio_restore_config(struct pinctrl_dev *pctldev,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/pinmux_gpio_save_config +98 drivers/pinctrl/pinmux.h
97
> 98 int pinmux_gpio_save_config(struct pinctrl_dev *pctldev,
99 struct pinctrl_gpio_range *range,
100 unsigned pin)
101 {
102 return 0;
103 }
> 104 int pinmux_gpio_restore_config(struct pinctrl_dev *pctldev,
105 struct pinctrl_gpio_range *range,
106 unsigned pin)
107 {
108 return 0;
109 }
110 #endif
111
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
11 months, 2 weeks
[trace:ftrace/core 35/39] kernel/trace/trace_boot.c:418:17: warning: this 'if' clause does not guard...
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git ftrace/core
head: 3dc65994e3c1c999be3d991cdc96705e167cb3b1
commit: 5d4648a0415efc239ffb377bce1d389723eda25d [35/39] tracing/boot: Show correct histogram error command
config: s390-allyesconfig (attached as .config)
compiler: s390-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git/c...
git remote add trace https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git
git fetch --no-tags trace ftrace/core
git checkout 5d4648a0415efc239ffb377bce1d389723eda25d
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=s390
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
kernel/trace/trace_boot.c: In function 'trace_boot_init_histograms':
>> kernel/trace/trace_boot.c:418:17: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
418 | if (trace_boot_compose_hist_cmd(hnode, buf, size) == 0)
| ^~
kernel/trace/trace_boot.c:420:25: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
420 | if (trigger_process_regex(file, buf) < 0)
| ^~
vim +/if +418 kernel/trace/trace_boot.c
30cb856e3067e5 Masami Hiramatsu 2021-08-06 395
30cb856e3067e5 Masami Hiramatsu 2021-08-06 396 static void __init
30cb856e3067e5 Masami Hiramatsu 2021-08-06 397 trace_boot_init_histograms(struct trace_event_file *file,
30cb856e3067e5 Masami Hiramatsu 2021-08-06 398 struct xbc_node *hnode, char *buf, size_t size)
30cb856e3067e5 Masami Hiramatsu 2021-08-06 399 {
30cb856e3067e5 Masami Hiramatsu 2021-08-06 400 struct xbc_node *node;
30cb856e3067e5 Masami Hiramatsu 2021-08-06 401 const char *p;
5d4648a0415efc Masami Hiramatsu 2021-08-06 402 char *tmp;
30cb856e3067e5 Masami Hiramatsu 2021-08-06 403
30cb856e3067e5 Masami Hiramatsu 2021-08-06 404 xbc_node_for_each_subkey(hnode, node) {
30cb856e3067e5 Masami Hiramatsu 2021-08-06 405 p = xbc_node_get_data(node);
30cb856e3067e5 Masami Hiramatsu 2021-08-06 406 if (!isdigit(p[0]))
30cb856e3067e5 Masami Hiramatsu 2021-08-06 407 continue;
30cb856e3067e5 Masami Hiramatsu 2021-08-06 408 /* All digit started node should be instances. */
30cb856e3067e5 Masami Hiramatsu 2021-08-06 409 if (trace_boot_compose_hist_cmd(node, buf, size) == 0) {
5d4648a0415efc Masami Hiramatsu 2021-08-06 410 tmp = kstrdup(buf, GFP_KERNEL);
30cb856e3067e5 Masami Hiramatsu 2021-08-06 411 if (trigger_process_regex(file, buf) < 0)
5d4648a0415efc Masami Hiramatsu 2021-08-06 412 pr_err("Failed to apply hist trigger: %s\n", tmp);
5d4648a0415efc Masami Hiramatsu 2021-08-06 413 kfree(tmp);
30cb856e3067e5 Masami Hiramatsu 2021-08-06 414 }
30cb856e3067e5 Masami Hiramatsu 2021-08-06 415 }
30cb856e3067e5 Masami Hiramatsu 2021-08-06 416
30cb856e3067e5 Masami Hiramatsu 2021-08-06 417 if (xbc_node_find_child(hnode, "keys")) {
30cb856e3067e5 Masami Hiramatsu 2021-08-06 @418 if (trace_boot_compose_hist_cmd(hnode, buf, size) == 0)
5d4648a0415efc Masami Hiramatsu 2021-08-06 419 tmp = kstrdup(buf, GFP_KERNEL);
30cb856e3067e5 Masami Hiramatsu 2021-08-06 420 if (trigger_process_regex(file, buf) < 0)
5d4648a0415efc Masami Hiramatsu 2021-08-06 421 pr_err("Failed to apply hist trigger: %s\n", tmp);
5d4648a0415efc Masami Hiramatsu 2021-08-06 422 kfree(tmp);
30cb856e3067e5 Masami Hiramatsu 2021-08-06 423 }
30cb856e3067e5 Masami Hiramatsu 2021-08-06 424
:::::: The code at line 418 was first introduced by commit
:::::: 30cb856e3067e5d6ae7b2144e1659145ab7686fd tracing/boot: Support multiple histograms for each event
:::::: TO: Masami Hiramatsu <mhiramat(a)kernel.org>
:::::: CC: Steven Rostedt (VMware) <rostedt(a)goodmis.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
11 months, 2 weeks
[dhowells-fs:netfs-folio-regions 13/36] fs/ceph/addr.c:310:3: error: 'const struct netfs_request_ops' has no member named 'is_cache_enabled'
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git netfs-folio-regions
head: 2f3fe780e9a44691136170536363c701b527d0e8
commit: 7261c29990677f14498f0aa1749db277a581b9c3 [13/36] netfs: Add a netfs inode context
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/com...
git remote add dhowells-fs https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git
git fetch --no-tags dhowells-fs netfs-folio-regions
git checkout 7261c29990677f14498f0aa1749db277a581b9c3
# save the attached .config to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> fs/ceph/addr.c:310:3: error: 'const struct netfs_request_ops' has no member named 'is_cache_enabled'
310 | .is_cache_enabled = ceph_is_cache_enabled,
| ^~~~~~~~~~~~~~~~
>> fs/ceph/addr.c:310:22: error: initialization of 'int (*)(struct netfs_read_request *)' from incompatible pointer type 'bool (*)(struct inode *)' {aka '_Bool (*)(struct inode *)'} [-Werror=incompatible-pointer-types]
310 | .is_cache_enabled = ceph_is_cache_enabled,
| ^~~~~~~~~~~~~~~~~~~~~
fs/ceph/addr.c:310:22: note: (near initialization for 'ceph_netfs_read_ops.begin_cache_operation')
fs/ceph/addr.c:311:27: warning: initialized field overwritten [-Woverride-init]
311 | .begin_cache_operation = ceph_begin_cache_operation,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
fs/ceph/addr.c:311:27: note: (near initialization for 'ceph_netfs_read_ops.begin_cache_operation')
fs/ceph/addr.c: In function 'ceph_readpage':
>> fs/ceph/addr.c:347:30: error: passing argument 2 of 'netfs_readpage' from incompatible pointer type [-Werror=incompatible-pointer-types]
347 | return netfs_readpage(file, folio, &ceph_netfs_read_ops, NULL);
| ^~~~~
| |
| struct folio *
In file included from fs/ceph/addr.c:15:
include/linux/netfs.h:258:42: note: expected 'struct page *' but argument is of type 'struct folio *'
258 | extern int netfs_readpage(struct file *, struct page *);
| ^~~~~~~~~~~~~
>> fs/ceph/addr.c:347:9: error: too many arguments to function 'netfs_readpage'
347 | return netfs_readpage(file, folio, &ceph_netfs_read_ops, NULL);
| ^~~~~~~~~~~~~~
In file included from fs/ceph/addr.c:15:
include/linux/netfs.h:258:12: note: declared here
258 | extern int netfs_readpage(struct file *, struct page *);
| ^~~~~~~~~~~~~~
fs/ceph/addr.c: In function 'ceph_readahead':
>> fs/ceph/addr.c:378:2: error: too many arguments to function 'netfs_readahead'
378 | netfs_readahead(ractl, &ceph_netfs_read_ops, (void *)(uintptr_t)got);
| ^~~~~~~~~~~~~~~
In file included from fs/ceph/addr.c:15:
include/linux/netfs.h:257:13: note: declared here
257 | extern void netfs_readahead(struct readahead_control *);
| ^~~~~~~~~~~~~~~
fs/ceph/addr.c: In function 'ceph_write_begin':
>> fs/ceph/addr.c:1260:6: error: too many arguments to function 'netfs_write_begin'
1260 | r = netfs_write_begin(file, inode->i_mapping, pos, len, 0, &folio, NULL,
| ^~~~~~~~~~~~~~~~~
In file included from fs/ceph/addr.c:15:
include/linux/netfs.h:259:12: note: declared here
259 | extern int netfs_write_begin(struct file *, struct address_space *,
| ^~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for PHY_SPARX5_SERDES
Depends on (ARCH_SPARX5 || COMPILE_TEST && OF && HAS_IOMEM
Selected by
- SPARX5_SWITCH && NETDEVICES && ETHERNET && NET_VENDOR_MICROCHIP && NET_SWITCHDEV && HAS_IOMEM && OF
vim +310 fs/ceph/addr.c
49870056005ca938 Jeff Layton 2020-07-09 307
7261c29990677f14 David Howells 2021-06-29 308 static const struct netfs_request_ops ceph_netfs_read_ops = {
f0702876e152f044 Jeff Layton 2020-06-01 309 .init_rreq = ceph_init_rreq,
f0702876e152f044 Jeff Layton 2020-06-01 @310 .is_cache_enabled = ceph_is_cache_enabled,
f0702876e152f044 Jeff Layton 2020-06-01 311 .begin_cache_operation = ceph_begin_cache_operation,
f0702876e152f044 Jeff Layton 2020-06-01 312 .issue_op = ceph_netfs_issue_op,
f0702876e152f044 Jeff Layton 2020-06-01 313 .expand_readahead = ceph_netfs_expand_readahead,
f0702876e152f044 Jeff Layton 2020-06-01 314 .clamp_length = ceph_netfs_clamp_length,
d801327d9500c746 Jeff Layton 2020-06-05 315 .check_write_begin = ceph_netfs_check_write_begin,
49870056005ca938 Jeff Layton 2020-07-09 316 .cleanup = ceph_readahead_cleanup,
f0702876e152f044 Jeff Layton 2020-06-01 317 };
f0702876e152f044 Jeff Layton 2020-06-01 318
f0702876e152f044 Jeff Layton 2020-06-01 319 /* read a single page, without unlocking it. */
f8a58a6c5116593f David Howells 2021-08-11 320 static int ceph_readpage(struct file *file, struct page *subpage)
f0702876e152f044 Jeff Layton 2020-06-01 321 {
f8a58a6c5116593f David Howells 2021-08-11 322 struct folio *folio = page_folio(subpage);
f0702876e152f044 Jeff Layton 2020-06-01 323 struct inode *inode = file_inode(file);
f0702876e152f044 Jeff Layton 2020-06-01 324 struct ceph_inode_info *ci = ceph_inode(inode);
f0702876e152f044 Jeff Layton 2020-06-01 325 struct ceph_vino vino = ceph_vino(inode);
f8a58a6c5116593f David Howells 2021-08-11 326 size_t len = folio_size(folio);
f8a58a6c5116593f David Howells 2021-08-11 327 u64 off = folio_file_pos(folio);
f0702876e152f044 Jeff Layton 2020-06-01 328
f0702876e152f044 Jeff Layton 2020-06-01 329 if (ci->i_inline_version != CEPH_INLINE_NONE) {
f0702876e152f044 Jeff Layton 2020-06-01 330 /*
f0702876e152f044 Jeff Layton 2020-06-01 331 * Uptodate inline data should have been added
f0702876e152f044 Jeff Layton 2020-06-01 332 * into page cache while getting Fcr caps.
f0702876e152f044 Jeff Layton 2020-06-01 333 */
f0702876e152f044 Jeff Layton 2020-06-01 334 if (off == 0) {
f8a58a6c5116593f David Howells 2021-08-11 335 folio_unlock(folio);
f0702876e152f044 Jeff Layton 2020-06-01 336 return -EINVAL;
f0702876e152f044 Jeff Layton 2020-06-01 337 }
f8a58a6c5116593f David Howells 2021-08-11 338 zero_user_segment(&folio->page, 0, folio_size(folio));
f8a58a6c5116593f David Howells 2021-08-11 339 folio_mark_uptodate(folio);
f8a58a6c5116593f David Howells 2021-08-11 340 folio_unlock(folio);
f0702876e152f044 Jeff Layton 2020-06-01 341 return 0;
f0702876e152f044 Jeff Layton 2020-06-01 342 }
f0702876e152f044 Jeff Layton 2020-06-01 343
f8a58a6c5116593f David Howells 2021-08-11 344 dout("readpage ino %llx.%llx file %p off %llu len %zu folio %p index %lu\n",
f8a58a6c5116593f David Howells 2021-08-11 345 vino.ino, vino.snap, file, off, len, folio, folio_index(folio));
f0702876e152f044 Jeff Layton 2020-06-01 346
f8a58a6c5116593f David Howells 2021-08-11 @347 return netfs_readpage(file, folio, &ceph_netfs_read_ops, NULL);
f0702876e152f044 Jeff Layton 2020-06-01 348 }
f0702876e152f044 Jeff Layton 2020-06-01 349
49870056005ca938 Jeff Layton 2020-07-09 350 static void ceph_readahead(struct readahead_control *ractl)
1d3576fd10f0d7a1 Sage Weil 2009-10-06 351 {
49870056005ca938 Jeff Layton 2020-07-09 352 struct inode *inode = file_inode(ractl->file);
49870056005ca938 Jeff Layton 2020-07-09 353 struct ceph_file_info *fi = ractl->file->private_data;
49870056005ca938 Jeff Layton 2020-07-09 354 struct ceph_rw_context *rw_ctx;
2b1ac852eb67a6e9 Yan, Zheng 2016-10-25 355 int got = 0;
2b1ac852eb67a6e9 Yan, Zheng 2016-10-25 356 int ret = 0;
2b1ac852eb67a6e9 Yan, Zheng 2016-10-25 357
49870056005ca938 Jeff Layton 2020-07-09 358 if (ceph_inode(inode)->i_inline_version != CEPH_INLINE_NONE)
49870056005ca938 Jeff Layton 2020-07-09 359 return;
7c272194e66e9183 Sage Weil 2011-08-03 360
49870056005ca938 Jeff Layton 2020-07-09 361 rw_ctx = ceph_find_rw_context(fi);
49870056005ca938 Jeff Layton 2020-07-09 362 if (!rw_ctx) {
7c272194e66e9183 Sage Weil 2011-08-03 363 /*
49870056005ca938 Jeff Layton 2020-07-09 364 * readahead callers do not necessarily hold Fcb caps
49870056005ca938 Jeff Layton 2020-07-09 365 * (e.g. fadvise, madvise).
7c272194e66e9183 Sage Weil 2011-08-03 366 */
49870056005ca938 Jeff Layton 2020-07-09 367 int want = CEPH_CAP_FILE_CACHE;
0d66a487c120012f Sage Weil 2011-08-04 368
49870056005ca938 Jeff Layton 2020-07-09 369 ret = ceph_try_get_caps(inode, CEPH_CAP_FILE_RD, want, true, &got);
49870056005ca938 Jeff Layton 2020-07-09 370 if (ret < 0)
49870056005ca938 Jeff Layton 2020-07-09 371 dout("start_read %p, error getting cap\n", inode);
49870056005ca938 Jeff Layton 2020-07-09 372 else if (!(got & want))
49870056005ca938 Jeff Layton 2020-07-09 373 dout("start_read %p, no cache cap\n", inode);
83701246aee8f83b Yan, Zheng 2014-11-14 374
49870056005ca938 Jeff Layton 2020-07-09 375 if (ret <= 0)
49870056005ca938 Jeff Layton 2020-07-09 376 return;
7c272194e66e9183 Sage Weil 2011-08-03 377 }
49870056005ca938 Jeff Layton 2020-07-09 @378 netfs_readahead(ractl, &ceph_netfs_read_ops, (void *)(uintptr_t)got);
1d3576fd10f0d7a1 Sage Weil 2009-10-06 379 }
1d3576fd10f0d7a1 Sage Weil 2009-10-06 380
:::::: The code at line 310 was first introduced by commit
:::::: f0702876e152f0443911514aec8b2bf563a2432b ceph: convert ceph_readpage to netfs_readpage
:::::: TO: Jeff Layton <jlayton(a)kernel.org>
:::::: CC: Ilya Dryomov <idryomov(a)gmail.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
11 months, 2 weeks