[freescale-fslc:pr/416 12229/20667] drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_cfg80211.c:4244:6: warning: no previous prototype for 'woal_uap_update_11ax_ie'
by kernel test robot
tree: https://github.com/Freescale/linux-fslc pr/416
head: 915e71b823c877d351de1cbe650344ef6eace94b
commit: ec10135c193594eff7ee081099b4a409d2c89205 [12229/20667] MLK-24458 net: wireless: nxp: mxm_wifiex: upgrade to mxm4x17186 release
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/Freescale/linux-fslc/commit/ec10135c193594eff7ee081099...
git remote add freescale-fslc https://github.com/Freescale/linux-fslc
git fetch --no-tags freescale-fslc pr/416
git checkout ec10135c193594eff7ee081099b4a409d2c89205
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=sh
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
cc1: warning: /mlan: No such file or directory [-Wmissing-include-dirs]
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_cfg80211.c:336:13: warning: no previous prototype for 'woal_cfg80211_set_key' [-Wmissing-prototypes]
336 | mlan_status woal_cfg80211_set_key(moal_private *priv, t_u8 is_enable_wep,
| ^~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_cfg80211.c:515:13: warning: no previous prototype for 'woal_cfg80211_set_wep_keys' [-Wmissing-prototypes]
515 | mlan_status woal_cfg80211_set_wep_keys(moal_private *priv, const t_u8 *key,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_cfg80211.c:1972:13: warning: no previous prototype for 'woal_set_coalesce' [-Wmissing-prototypes]
1972 | mlan_status woal_set_coalesce(moal_private *priv, t_u16 action,
| ^~~~~~~~~~~~~~~~~
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_cfg80211.c: In function 'woal_mgmt_frame_register':
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_cfg80211.c:2293:21: warning: variable 'status' set but not used [-Wunused-but-set-variable]
2293 | mlan_status status = MLAN_STATUS_SUCCESS;
| ^~~~~~
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_cfg80211.c: In function 'woal_find_ie':
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_cfg80211.c:3217:14: warning: variable 'id' set but not used [-Wunused-but-set-variable]
3217 | t_u8 id = 0;
| ^~
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_cfg80211.c: At top level:
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_cfg80211.c:3422:6: warning: no previous prototype for 'is_selected_registrar_on' [-Wmissing-prototypes]
3422 | t_u8 is_selected_registrar_on(const t_u8 *ie, int len)
| ^~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_cfg80211.c:4244:6: warning: no previous prototype for 'woal_uap_update_11ax_ie' [-Wmissing-prototypes]
4244 | void woal_uap_update_11ax_ie(t_u8 band, mlan_ds_11ax_he_capa *hecap_ie)
| ^~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_main.h:130,
from drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_cfg80211.h:26,
from drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_cfg80211.c:23:
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_priv.h:282:34: warning: 'woal_private_args' defined but not used [-Wunused-const-variable=]
282 | static const struct iw_priv_args woal_private_args[] = {
| ^~~~~~~~~~~~~~~~~
--
cc1: warning: /mlan: No such file or directory [-Wmissing-include-dirs]
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:516:6: warning: no previous prototype for 'is_cfg80211_special_region_code' [-Wmissing-prototypes]
516 | t_u8 is_cfg80211_special_region_code(char *region_string)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:1205:13: warning: no previous prototype for 'woal_set_ewpa_mode' [-Wmissing-prototypes]
1205 | mlan_status woal_set_ewpa_mode(moal_private *priv, t_u8 wait_option,
| ^~~~~~~~~~~~~~~~~~
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c: In function 'woal_set_ewpa_mode':
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:1208:13: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
1208 | int ret = 0;
| ^~~
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c: At top level:
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:1616:5: warning: no previous prototype for 'woal_cfg80211_connect_scan' [-Wmissing-prototypes]
1616 | int woal_cfg80211_connect_scan(moal_private *priv,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:1702:6: warning: no previous prototype for 'woal_save_assoc_params' [-Wmissing-prototypes]
1702 | void woal_save_assoc_params(moal_private *priv,
| ^~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:1761:6: warning: no previous prototype for 'woal_save_auth_params' [-Wmissing-prototypes]
1761 | void woal_save_auth_params(moal_private *priv,
| ^~~~~~~~~~~~~~~~~~~~~
>> drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:2270:6: warning: no previous prototype for 'woal_assoc_resp_event' [-Wmissing-prototypes]
2270 | void woal_assoc_resp_event(moal_private *priv,
| ^~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c: In function 'woal_cfg80211_assoc':
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:2513:35: warning: variable 'chan_def' set but not used [-Wunused-but-set-variable]
2513 | struct cfg80211_chan_def *chan_def = NULL;
| ^~~~~~~~
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c: At top level:
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:3532:13: warning: no previous prototype for 'woal_role_switch' [-Wmissing-prototypes]
3532 | mlan_status woal_role_switch(moal_private *priv, t_u8 wait_option,
| ^~~~~~~~~~~~~~~~
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:3622:13: warning: no previous prototype for 'woal_uap_scan' [-Wmissing-prototypes]
3622 | mlan_status woal_uap_scan(moal_private *priv, wlan_user_scan_cfg *scan_cfg)
| ^~~~~~~~~~~~~
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:3709:6: warning: no previous prototype for 'woal_is_scan_result_expired' [-Wmissing-prototypes]
3709 | t_u8 woal_is_scan_result_expired(moal_private *priv)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:4933:6: warning: no previous prototype for 'woal_bandcfg_to_ieee_band' [-Wmissing-prototypes]
4933 | t_u8 woal_bandcfg_to_ieee_band(Band_Config_t bandcfg)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:6537:5: warning: no previous prototype for 'woal_update_okc_roaming_ie' [-Wmissing-prototypes]
6537 | int woal_update_okc_roaming_ie(moal_private *priv, struct pmksa_entry *entry)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:7197:13: warning: no previous prototype for 'woal_cfg80211_init_wiphy' [-Wmissing-prototypes]
7197 | mlan_status woal_cfg80211_init_wiphy(moal_private *priv, t_u8 wait_option)
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:7378:6: warning: no previous prototype for 'woal_update_channel_flag' [-Wmissing-prototypes]
7378 | void woal_update_channel_flag(struct wiphy *wiphy, mlan_fw_info *fw_info)
| ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_main.h:130,
from drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_cfg80211.h:26,
from drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:23:
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_priv.h:282:34: warning: 'woal_private_args' defined but not used [-Wunused-const-variable=]
282 | static const struct iw_priv_args woal_private_args[] = {
| ^~~~~~~~~~~~~~~~~
--
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_cfg80211.c:336:13: warning: no previous prototype for 'woal_cfg80211_set_key' [-Wmissing-prototypes]
336 | mlan_status woal_cfg80211_set_key(moal_private *priv, t_u8 is_enable_wep,
| ^~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_cfg80211.c:515:13: warning: no previous prototype for 'woal_cfg80211_set_wep_keys' [-Wmissing-prototypes]
515 | mlan_status woal_cfg80211_set_wep_keys(moal_private *priv, const t_u8 *key,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_cfg80211.c:1972:13: warning: no previous prototype for 'woal_set_coalesce' [-Wmissing-prototypes]
1972 | mlan_status woal_set_coalesce(moal_private *priv, t_u16 action,
| ^~~~~~~~~~~~~~~~~
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_cfg80211.c: In function 'woal_mgmt_frame_register':
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_cfg80211.c:2293:21: warning: variable 'status' set but not used [-Wunused-but-set-variable]
2293 | mlan_status status = MLAN_STATUS_SUCCESS;
| ^~~~~~
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_cfg80211.c: In function 'woal_find_ie':
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_cfg80211.c:3217:14: warning: variable 'id' set but not used [-Wunused-but-set-variable]
3217 | t_u8 id = 0;
| ^~
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_cfg80211.c: At top level:
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_cfg80211.c:3422:6: warning: no previous prototype for 'is_selected_registrar_on' [-Wmissing-prototypes]
3422 | t_u8 is_selected_registrar_on(const t_u8 *ie, int len)
| ^~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_cfg80211.c:4244:6: warning: no previous prototype for 'woal_uap_update_11ax_ie' [-Wmissing-prototypes]
4244 | void woal_uap_update_11ax_ie(t_u8 band, mlan_ds_11ax_he_capa *hecap_ie)
| ^~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_main.h:130,
from drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_cfg80211.h:26,
from drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_cfg80211.c:23:
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_priv.h:282:34: warning: 'woal_private_args' defined but not used [-Wunused-const-variable=]
282 | static const struct iw_priv_args woal_private_args[] = {
| ^~~~~~~~~~~~~~~~~
--
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:516:6: warning: no previous prototype for 'is_cfg80211_special_region_code' [-Wmissing-prototypes]
516 | t_u8 is_cfg80211_special_region_code(char *region_string)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:1205:13: warning: no previous prototype for 'woal_set_ewpa_mode' [-Wmissing-prototypes]
1205 | mlan_status woal_set_ewpa_mode(moal_private *priv, t_u8 wait_option,
| ^~~~~~~~~~~~~~~~~~
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c: In function 'woal_set_ewpa_mode':
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:1208:13: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
1208 | int ret = 0;
| ^~~
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c: At top level:
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:1616:5: warning: no previous prototype for 'woal_cfg80211_connect_scan' [-Wmissing-prototypes]
1616 | int woal_cfg80211_connect_scan(moal_private *priv,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:1702:6: warning: no previous prototype for 'woal_save_assoc_params' [-Wmissing-prototypes]
1702 | void woal_save_assoc_params(moal_private *priv,
| ^~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:1761:6: warning: no previous prototype for 'woal_save_auth_params' [-Wmissing-prototypes]
1761 | void woal_save_auth_params(moal_private *priv,
| ^~~~~~~~~~~~~~~~~~~~~
>> drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:2270:6: warning: no previous prototype for 'woal_assoc_resp_event' [-Wmissing-prototypes]
2270 | void woal_assoc_resp_event(moal_private *priv,
| ^~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c: In function 'woal_cfg80211_assoc':
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:2513:35: warning: variable 'chan_def' set but not used [-Wunused-but-set-variable]
2513 | struct cfg80211_chan_def *chan_def = NULL;
| ^~~~~~~~
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c: At top level:
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:3532:13: warning: no previous prototype for 'woal_role_switch' [-Wmissing-prototypes]
3532 | mlan_status woal_role_switch(moal_private *priv, t_u8 wait_option,
| ^~~~~~~~~~~~~~~~
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:3622:13: warning: no previous prototype for 'woal_uap_scan' [-Wmissing-prototypes]
3622 | mlan_status woal_uap_scan(moal_private *priv, wlan_user_scan_cfg *scan_cfg)
| ^~~~~~~~~~~~~
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:3709:6: warning: no previous prototype for 'woal_is_scan_result_expired' [-Wmissing-prototypes]
3709 | t_u8 woal_is_scan_result_expired(moal_private *priv)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:4933:6: warning: no previous prototype for 'woal_bandcfg_to_ieee_band' [-Wmissing-prototypes]
4933 | t_u8 woal_bandcfg_to_ieee_band(Band_Config_t bandcfg)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:6537:5: warning: no previous prototype for 'woal_update_okc_roaming_ie' [-Wmissing-prototypes]
6537 | int woal_update_okc_roaming_ie(moal_private *priv, struct pmksa_entry *entry)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:7197:13: warning: no previous prototype for 'woal_cfg80211_init_wiphy' [-Wmissing-prototypes]
7197 | mlan_status woal_cfg80211_init_wiphy(moal_private *priv, t_u8 wait_option)
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:7378:6: warning: no previous prototype for 'woal_update_channel_flag' [-Wmissing-prototypes]
7378 | void woal_update_channel_flag(struct wiphy *wiphy, mlan_fw_info *fw_info)
| ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_main.h:130,
from drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_cfg80211.h:26,
from drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:23:
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_priv.h:282:34: warning: 'woal_private_args' defined but not used [-Wunused-const-variable=]
282 | static const struct iw_priv_args woal_private_args[] = {
| ^~~~~~~~~~~~~~~~~
vim +/woal_uap_update_11ax_ie +4244 drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_cfg80211.c
4236
4237 /**
4238 * @brief update 11ax ie for AP mode *
4239 * @param band band config
4240 * @hecap_ie a pointer to mlan_ds_11ax_he_capa
4241 *
4242 * @return 0--success, otherwise failure
4243 */
> 4244 void woal_uap_update_11ax_ie(t_u8 band, mlan_ds_11ax_he_capa *hecap_ie)
4245 {
4246 if (band == BAND_5GHZ) {
4247 hecap_ie->he_mac_cap[0] &= UAP_HE_MAC_CAP0_MASK;
4248 hecap_ie->he_mac_cap[1] &= UAP_HE_MAC_CAP1_MASK;
4249 hecap_ie->he_mac_cap[2] &= UAP_HE_MAC_CAP2_MASK;
4250 hecap_ie->he_mac_cap[3] &= UAP_HE_MAC_CAP3_MASK;
4251 hecap_ie->he_mac_cap[4] &= UAP_HE_MAC_CAP4_MASK;
4252 hecap_ie->he_mac_cap[5] &= UAP_HE_MAC_CAP5_MASK;
4253 hecap_ie->he_phy_cap[0] &= UAP_HE_PHY_CAP0_MASK;
4254 hecap_ie->he_phy_cap[1] &= UAP_HE_PHY_CAP1_MASK;
4255 hecap_ie->he_phy_cap[2] &= UAP_HE_PHY_CAP2_MASK;
4256 hecap_ie->he_phy_cap[3] &= UAP_HE_PHY_CAP3_MASK;
4257 hecap_ie->he_phy_cap[4] &= UAP_HE_PHY_CAP4_MASK;
4258 hecap_ie->he_phy_cap[5] &= UAP_HE_PHY_CAP5_MASK;
4259 hecap_ie->he_phy_cap[6] &= UAP_HE_PHY_CAP6_MASK;
4260 hecap_ie->he_phy_cap[7] &= UAP_HE_PHY_CAP7_MASK;
4261 hecap_ie->he_phy_cap[8] &= UAP_HE_PHY_CAP8_MASK;
4262 hecap_ie->he_phy_cap[9] &= UAP_HE_PHY_CAP9_MASK;
4263 hecap_ie->he_phy_cap[10] &= UAP_HE_PHY_CAP10_MASK;
4264 } else {
4265 hecap_ie->he_mac_cap[0] &= UAP_HE_2G_MAC_CAP0_MASK;
4266 hecap_ie->he_mac_cap[1] &= UAP_HE_2G_MAC_CAP1_MASK;
4267 hecap_ie->he_mac_cap[2] &= UAP_HE_2G_MAC_CAP2_MASK;
4268 hecap_ie->he_mac_cap[3] &= UAP_HE_2G_MAC_CAP3_MASK;
4269 hecap_ie->he_mac_cap[4] &= UAP_HE_2G_MAC_CAP4_MASK;
4270 hecap_ie->he_mac_cap[5] &= UAP_HE_2G_MAC_CAP5_MASK;
4271 hecap_ie->he_phy_cap[0] &= UAP_HE_2G_PHY_CAP0_MASK;
4272 hecap_ie->he_phy_cap[1] &= UAP_HE_2G_PHY_CAP1_MASK;
4273 hecap_ie->he_phy_cap[2] &= UAP_HE_2G_PHY_CAP2_MASK;
4274 hecap_ie->he_phy_cap[3] &= UAP_HE_2G_PHY_CAP3_MASK;
4275 hecap_ie->he_phy_cap[4] &= UAP_HE_2G_PHY_CAP4_MASK;
4276 hecap_ie->he_phy_cap[5] &= UAP_HE_2G_PHY_CAP5_MASK;
4277 hecap_ie->he_phy_cap[6] &= UAP_HE_2G_PHY_CAP6_MASK;
4278 hecap_ie->he_phy_cap[7] &= UAP_HE_2G_PHY_CAP7_MASK;
4279 hecap_ie->he_phy_cap[8] &= UAP_HE_2G_PHY_CAP8_MASK;
4280 hecap_ie->he_phy_cap[9] &= UAP_HE_2G_PHY_CAP9_MASK;
4281 hecap_ie->he_phy_cap[10] &= UAP_HE_2G_PHY_CAP10_MASK;
4282 }
4283 return;
4284 }
4285
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 1 month
Re: [PATCH v8 09/14] iio: afe: rescale: fix accuracy for small fractional scales
by kernel test robot
Hi Liam,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on 6cbb3aa0f9d5d23221df787cf36f74d3866fdb78]
url: https://github.com/0day-ci/linux/commits/Liam-Beguin/iio-afe-add-temperat...
base: 6cbb3aa0f9d5d23221df787cf36f74d3866fdb78
config: openrisc-randconfig-m031-20210821 (attached as .config)
compiler: or1k-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
smatch warnings:
drivers/iio/afe/iio-rescale.c:56 rescale_process_scale() warn: inconsistent indenting
vim +56 drivers/iio/afe/iio-rescale.c
20
21 int rescale_process_scale(struct rescale *rescale, int scale_type,
22 int *val, int *val2)
23 {
24 s64 tmp;
25 s32 rem, rem2;
26 u32 mult;
27 u32 neg;
28
29 switch (scale_type) {
30 case IIO_VAL_INT:
31 *val *= rescale->numerator;
32 if (rescale->denominator == 1)
33 return scale_type;
34 *val2 = rescale->denominator;
35 return IIO_VAL_FRACTIONAL;
36 case IIO_VAL_FRACTIONAL:
37 case IIO_VAL_FRACTIONAL_LOG2:
38 tmp = (s64)*val * 1000000000LL;
39 tmp = div_s64(tmp, rescale->denominator);
40 tmp *= rescale->numerator;
41
42 tmp = div_s64_rem(tmp, 1000000000LL, &rem);
43 *val = tmp;
44
45 /*
46 * For small values, the approximation can be costly,
47 * change scale type to maintain accuracy.
48 *
49 * 100 vs. 10000000 NANO caps the error to about 100 ppm.
50 */
51 if (scale_type == IIO_VAL_FRACTIONAL)
52 tmp = *val2;
53 else
54 tmp = 1 << *val2;
55
> 56 if (abs(rem) > 10000000 && abs(*val / tmp) < 100) {
57 *val = div_s64_rem(*val, tmp, &rem2);
58
59 *val2 = div_s64(rem, tmp);
60 if (rem2)
61 *val2 += div_s64(rem2 * 1000000000LL, tmp);
62
63 return IIO_VAL_INT_PLUS_NANO;
64 }
65
66 return scale_type;
67 case IIO_VAL_INT_PLUS_NANO:
68 case IIO_VAL_INT_PLUS_MICRO:
69 if (scale_type == IIO_VAL_INT_PLUS_NANO)
70 mult = 1000000000LL;
71 else
72 mult = 1000000LL;
73 /*
74 * For IIO_VAL_INT_PLUS_{MICRO,NANO} scale types if *val OR
75 * *val2 is negative the schan scale is negative
76 */
77 neg = *val < 0 || *val2 < 0;
78
79 tmp = (s64)abs(*val) * abs(rescale->numerator);
80 *val = div_s64_rem(tmp, abs(rescale->denominator), &rem);
81
82 tmp = (s64)rem * mult + (s64)abs(*val2) * abs(rescale->numerator);
83 tmp = div_s64(tmp, abs(rescale->denominator));
84
85 *val += div_s64_rem(tmp, mult, val2);
86
87 /*
88 * If only one of the rescaler elements or the schan scale is
89 * negative, the combined scale is negative.
90 */
91 if (neg ^ ((rescale->numerator < 0) ^ (rescale->denominator < 0))) {
92 if (*val)
93 *val = -*val;
94 else
95 *val2 = -*val2;
96 }
97
98 return scale_type;
99 default:
100 return -EOPNOTSUPP;
101 }
102 }
103
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 1 month
arch/powerpc/platforms/52xx/lite5200_pm.c:215:9: error: implicit declaration of function 'enable_kernel_fp'
by kernel test robot
Hi Christophe,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: fa54d366a6e4fe3e16322abdb8b5115f8be0da8b
commit: 7d68c89169508064c460a1208f38ed0589d226fa powerpc/32s: Allow deselecting CONFIG_PPC_FPU on mpc832x
date: 9 months ago
config: powerpc64-buildonly-randconfig-r004-20210820 (attached as .config)
compiler: powerpc-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit...
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 7d68c89169508064c460a1208f38ed0589d226fa
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=powerpc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
arch/powerpc/platforms/52xx/lite5200_pm.c: In function 'lite5200_pm_enter':
>> arch/powerpc/platforms/52xx/lite5200_pm.c:215:9: error: implicit declaration of function 'enable_kernel_fp' [-Werror=implicit-function-declaration]
215 | enable_kernel_fp();
| ^~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
--
arch/powerpc/platforms/83xx/suspend.c: In function 'mpc83xx_suspend_enter':
>> arch/powerpc/platforms/83xx/suspend.c:210:17: error: implicit declaration of function 'enable_kernel_fp' [-Werror=implicit-function-declaration]
210 | enable_kernel_fp();
| ^~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
vim +/enable_kernel_fp +215 arch/powerpc/platforms/52xx/lite5200_pm.c
ee983079ce0464 Domen Puncer 2007-07-18 204
ee983079ce0464 Domen Puncer 2007-07-18 205 static int lite5200_pm_enter(suspend_state_t state)
ee983079ce0464 Domen Puncer 2007-07-18 206 {
ee983079ce0464 Domen Puncer 2007-07-18 207 /* deep sleep? let mpc52xx code handle that */
ee983079ce0464 Domen Puncer 2007-07-18 208 if (state == PM_SUSPEND_STANDBY) {
ee983079ce0464 Domen Puncer 2007-07-18 209 return mpc52xx_pm_enter(state);
ee983079ce0464 Domen Puncer 2007-07-18 210 }
ee983079ce0464 Domen Puncer 2007-07-18 211
ee983079ce0464 Domen Puncer 2007-07-18 212 lite5200_save_regs();
ee983079ce0464 Domen Puncer 2007-07-18 213
ee983079ce0464 Domen Puncer 2007-07-18 214 /* effectively save FP regs */
ee983079ce0464 Domen Puncer 2007-07-18 @215 enable_kernel_fp();
ee983079ce0464 Domen Puncer 2007-07-18 216
ee983079ce0464 Domen Puncer 2007-07-18 217 lite5200_low_power(sram, mbar);
ee983079ce0464 Domen Puncer 2007-07-18 218
ee983079ce0464 Domen Puncer 2007-07-18 219 lite5200_restore_regs();
ee983079ce0464 Domen Puncer 2007-07-18 220
ee983079ce0464 Domen Puncer 2007-07-18 221 iounmap(mbar);
ee983079ce0464 Domen Puncer 2007-07-18 222 return 0;
ee983079ce0464 Domen Puncer 2007-07-18 223 }
ee983079ce0464 Domen Puncer 2007-07-18 224
:::::: The code at line 215 was first introduced by commit
:::::: ee983079ce04641523b23b8ed02cc3503632351e [POWERPC] MPC5200 low power mode
:::::: TO: Domen Puncer <domen.puncer(a)telargo.com>
:::::: CC: Paul Mackerras <paulus(a)samba.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 1 month
[jimc:dd-drm-next 2/12] include/linux/dynamic_debug.h:232:68: warning: 'struct kernel_param' declared inside parameter list will not be visible outside of this definition or declaration
by kernel test robot
tree: https://github.com/jimc/linux.git dd-drm-next
head: 531b8210367c9d9d3430d37a12c01dced8e4354f
commit: 36e19f73c31f9c5b9db4b2b4661c065a36ffc174 [2/12] dyndbg: add DEFINE_DYNAMIC_DEBUG_CATEGORIES and callbacks
config: x86_64-randconfig-s032-20210821 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.3-348-gf0e6938b-dirty
# https://github.com/jimc/linux/commit/36e19f73c31f9c5b9db4b2b4661c065a36ff...
git remote add jimc https://github.com/jimc/linux.git
git fetch --no-tags jimc dd-drm-next
git checkout 36e19f73c31f9c5b9db4b2b4661c065a36ffc174
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=x86_64 SHELL=/bin/bash arch/x86/platform/pvh/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
In file included from include/linux/acpi.h:28,
from arch/x86/platform/pvh/enlighten.c:2:
>> include/linux/dynamic_debug.h:232:68: warning: 'struct kernel_param' declared inside parameter list will not be visible outside of this definition or declaration
232 | static inline int param_set_dyndbg(const char *instr, const struct kernel_param *kp)
| ^~~~~~~~~~~~
include/linux/dynamic_debug.h:234:63: warning: 'struct kernel_param' declared inside parameter list will not be visible outside of this definition or declaration
234 | static inline int param_get_dyndbg(char *buffer, const struct kernel_param *kp)
| ^~~~~~~~~~~~
arch/x86/platform/pvh/enlighten.c:39:20: warning: no previous prototype for 'mem_map_via_hcall' [-Wmissing-prototypes]
39 | void __init __weak mem_map_via_hcall(struct boot_params *ptr __maybe_unused)
| ^~~~~~~~~~~~~~~~~
arch/x86/platform/pvh/enlighten.c:104:20: warning: no previous prototype for 'xen_pvh_init' [-Wmissing-prototypes]
104 | void __init __weak xen_pvh_init(struct boot_params *boot_params)
| ^~~~~~~~~~~~
arch/x86/platform/pvh/enlighten.c:120:13: warning: no previous prototype for 'xen_prepare_pvh' [-Wmissing-prototypes]
120 | void __init xen_prepare_pvh(void)
| ^~~~~~~~~~~~~~~
vim +232 include/linux/dynamic_debug.h
231
> 232 static inline int param_set_dyndbg(const char *instr, const struct kernel_param *kp)
233 { return 0; }
234 static inline int param_get_dyndbg(char *buffer, const struct kernel_param *kp)
235 { return 0; }
236
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 1 month
[dhowells-fs:netfs-folio-regions 5/28] fs/netfs/read_helper.c:435:25: error: implicit declaration of function 'flush_dcache_folio'; did you mean 'flush_dcache_range'?
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git netfs-folio-regions
head: 215a4ee495a95cc73256ed76f91cb78bcabd6b8e
commit: e303f96b1836000d261e811df743b4eb499efa6e [5/28] netfs, afs, ceph: Use folios
config: nios2-allyesconfig (attached as .config)
compiler: nios2-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/com...
git remote add dhowells-fs https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git
git fetch --no-tags dhowells-fs netfs-folio-regions
git checkout e303f96b1836000d261e811df743b4eb499efa6e
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=nios2
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
fs/netfs/read_helper.c: In function 'netfs_rreq_unlock':
>> fs/netfs/read_helper.c:435:25: error: implicit declaration of function 'flush_dcache_folio'; did you mean 'flush_dcache_range'? [-Werror=implicit-function-declaration]
435 | flush_dcache_folio(folio);
| ^~~~~~~~~~~~~~~~~~
| flush_dcache_range
cc1: some warnings being treated as errors
vim +435 fs/netfs/read_helper.c
368
369 /*
370 * Unlock the folios in a read operation. We need to set PG_fscache on any
371 * folios we're going to write back before we unlock them.
372 */
373 static void netfs_rreq_unlock(struct netfs_read_request *rreq)
374 {
375 struct netfs_read_subrequest *subreq;
376 struct folio *folio;
377 unsigned int iopos, account = 0;
378 pgoff_t start_page = rreq->start / PAGE_SIZE;
379 pgoff_t last_page = ((rreq->start + rreq->len) / PAGE_SIZE) - 1;
380 bool subreq_failed = false;
381
382 XA_STATE(xas, &rreq->mapping->i_pages, start_page);
383
384 if (test_bit(NETFS_RREQ_FAILED, &rreq->flags)) {
385 __clear_bit(NETFS_RREQ_WRITE_TO_CACHE, &rreq->flags);
386 list_for_each_entry(subreq, &rreq->subrequests, rreq_link) {
387 __clear_bit(NETFS_SREQ_WRITE_TO_CACHE, &subreq->flags);
388 }
389 }
390
391 /* Walk through the pagecache and the I/O request lists simultaneously.
392 * We may have a mixture of cached and uncached sections and we only
393 * really want to write out the uncached sections. This is slightly
394 * complicated by the possibility that we might have huge pages with a
395 * mixture inside.
396 */
397 subreq = list_first_entry(&rreq->subrequests,
398 struct netfs_read_subrequest, rreq_link);
399 iopos = 0;
400 subreq_failed = (subreq->error < 0);
401
402 trace_netfs_rreq(rreq, netfs_rreq_trace_unlock);
403
404 rcu_read_lock();
405 xas_for_each(&xas, folio, last_page) {
406 unsigned int pgpos = (folio_index(folio) - start_page) * PAGE_SIZE;
407 unsigned int pgend = pgpos + folio_size(folio);
408 bool pg_failed = false;
409
410 for (;;) {
411 if (!subreq) {
412 pg_failed = true;
413 break;
414 }
415 if (test_bit(NETFS_SREQ_WRITE_TO_CACHE, &subreq->flags))
416 folio_start_fscache(folio);
417 pg_failed |= subreq_failed;
418 if (pgend < iopos + subreq->len)
419 break;
420
421 account += subreq->transferred;
422 iopos += subreq->len;
423 if (!list_is_last(&subreq->rreq_link, &rreq->subrequests)) {
424 subreq = list_next_entry(subreq, rreq_link);
425 subreq_failed = (subreq->error < 0);
426 } else {
427 subreq = NULL;
428 subreq_failed = false;
429 }
430 if (pgend == iopos)
431 break;
432 }
433
434 if (!pg_failed) {
> 435 flush_dcache_folio(folio);
436 folio_mark_uptodate(folio);
437 }
438
439 if (!test_bit(NETFS_RREQ_DONT_UNLOCK_FOLIOS, &rreq->flags)) {
440 if (folio_index(folio) == rreq->no_unlock_folio &&
441 test_bit(NETFS_RREQ_NO_UNLOCK_FOLIO, &rreq->flags))
442 _debug("no unlock");
443 else
444 folio_unlock(folio);
445 }
446 }
447 rcu_read_unlock();
448
449 task_io_account_read(account);
450 if (rreq->netfs_ops->done)
451 rreq->netfs_ops->done(rreq);
452 }
453
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 1 month
[jimc:dd-drm-next 2/12] include/linux/dynamic_debug.h:232:68: warning: declaration of 'struct kernel_param' will not be visible outside of this function
by kernel test robot
tree: https://github.com/jimc/linux.git dd-drm-next
head: 531b8210367c9d9d3430d37a12c01dced8e4354f
commit: 36e19f73c31f9c5b9db4b2b4661c065a36ffc174 [2/12] dyndbg: add DEFINE_DYNAMIC_DEBUG_CATEGORIES and callbacks
config: i386-randconfig-r033-20210821 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project d9c5613e856cf2addfbf892fc4c1ce9ef9feceaa)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/jimc/linux/commit/36e19f73c31f9c5b9db4b2b4661c065a36ff...
git remote add jimc https://github.com/jimc/linux.git
git fetch --no-tags jimc dd-drm-next
git checkout 36e19f73c31f9c5b9db4b2b4661c065a36ffc174
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
In file included from drivers/usb/typec/tipd/core.c:9:
In file included from include/linux/i2c.h:13:
In file included from include/linux/acpi.h:28:
>> include/linux/dynamic_debug.h:232:68: warning: declaration of 'struct kernel_param' will not be visible outside of this function [-Wvisibility]
static inline int param_set_dyndbg(const char *instr, const struct kernel_param *kp)
^
include/linux/dynamic_debug.h:234:63: warning: declaration of 'struct kernel_param' will not be visible outside of this function [-Wvisibility]
static inline int param_get_dyndbg(char *buffer, const struct kernel_param *kp)
^
drivers/usb/typec/tipd/core.c:166:19: warning: unused function 'tps6598x_write16' [-Wunused-function]
static inline int tps6598x_write16(struct tps6598x *tps, u8 reg, u16 val)
^
drivers/usb/typec/tipd/core.c:171:19: warning: unused function 'tps6598x_write32' [-Wunused-function]
static inline int tps6598x_write32(struct tps6598x *tps, u8 reg, u32 val)
^
4 warnings generated.
vim +232 include/linux/dynamic_debug.h
231
> 232 static inline int param_set_dyndbg(const char *instr, const struct kernel_param *kp)
233 { return 0; }
234 static inline int param_get_dyndbg(char *buffer, const struct kernel_param *kp)
235 { return 0; }
236
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 1 month
[jlayton:locks-next 4/4] fs/9p/vfs_file.c:322:1: warning: unused label 'out_err'
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jlayton/linux.git locks-next
head: d252e76f8180b23e595949307ce3af3fe84a6150
commit: d252e76f8180b23e595949307ce3af3fe84a6150 [4/4] fs: remove mandatory file locking support
config: x86_64-randconfig-a012-20210820 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project d9c5613e856cf2addfbf892fc4c1ce9ef9feceaa)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/jlayton/linux.git/commit/...
git remote add jlayton https://git.kernel.org/pub/scm/linux/kernel/git/jlayton/linux.git
git fetch --no-tags jlayton locks-next
git checkout d252e76f8180b23e595949307ce3af3fe84a6150
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> fs/9p/vfs_file.c:322:1: warning: unused label 'out_err' [-Wunused-label]
out_err:
^~~~~~~~
1 warning generated.
vim +/out_err +322 fs/9p/vfs_file.c
1d769cd192fc8c M. Mohan Kumar 2010-09-27 294
a099027c779068 M. Mohan Kumar 2010-09-27 295 /**
a099027c779068 M. Mohan Kumar 2010-09-27 296 * v9fs_file_lock_dotl - lock a file (or directory)
a099027c779068 M. Mohan Kumar 2010-09-27 297 * @filp: file to be locked
a099027c779068 M. Mohan Kumar 2010-09-27 298 * @cmd: lock command
a099027c779068 M. Mohan Kumar 2010-09-27 299 * @fl: file lock structure
a099027c779068 M. Mohan Kumar 2010-09-27 300 *
a099027c779068 M. Mohan Kumar 2010-09-27 301 */
a099027c779068 M. Mohan Kumar 2010-09-27 302
a099027c779068 M. Mohan Kumar 2010-09-27 303 static int v9fs_file_lock_dotl(struct file *filp, int cmd, struct file_lock *fl)
a099027c779068 M. Mohan Kumar 2010-09-27 304 {
496ad9aa8ef448 Al Viro 2013-01-23 305 struct inode *inode = file_inode(filp);
a099027c779068 M. Mohan Kumar 2010-09-27 306 int ret = -ENOLCK;
a099027c779068 M. Mohan Kumar 2010-09-27 307
4b8e992392a246 Al Viro 2014-08-19 308 p9_debug(P9_DEBUG_VFS, "filp: %p cmd:%d lock: %p name: %pD\n",
4b8e992392a246 Al Viro 2014-08-19 309 filp, cmd, fl, filp);
a099027c779068 M. Mohan Kumar 2010-09-27 310
a099027c779068 M. Mohan Kumar 2010-09-27 311 if ((IS_SETLK(cmd) || IS_SETLKW(cmd)) && fl->fl_type != F_UNLCK) {
a099027c779068 M. Mohan Kumar 2010-09-27 312 filemap_write_and_wait(inode->i_mapping);
a099027c779068 M. Mohan Kumar 2010-09-27 313 invalidate_mapping_pages(&inode->i_data, 0, -1);
a099027c779068 M. Mohan Kumar 2010-09-27 314 }
a099027c779068 M. Mohan Kumar 2010-09-27 315
a099027c779068 M. Mohan Kumar 2010-09-27 316 if (IS_SETLK(cmd) || IS_SETLKW(cmd))
a099027c779068 M. Mohan Kumar 2010-09-27 317 ret = v9fs_file_do_lock(filp, cmd, fl);
1d769cd192fc8c M. Mohan Kumar 2010-09-27 318 else if (IS_GETLK(cmd))
1d769cd192fc8c M. Mohan Kumar 2010-09-27 319 ret = v9fs_file_getlock(filp, fl);
a099027c779068 M. Mohan Kumar 2010-09-27 320 else
a099027c779068 M. Mohan Kumar 2010-09-27 321 ret = -EINVAL;
a099027c779068 M. Mohan Kumar 2010-09-27 @322 out_err:
a099027c779068 M. Mohan Kumar 2010-09-27 323 return ret;
a099027c779068 M. Mohan Kumar 2010-09-27 324 }
a099027c779068 M. Mohan Kumar 2010-09-27 325
:::::: The code at line 322 was first introduced by commit
:::::: a099027c779068b834f335cfdc3f2bf10f531dd9 9p: Implement TLOCK
:::::: TO: M. Mohan Kumar <mohan(a)in.ibm.com>
:::::: CC: Eric Van Hensbergen <ericvh(a)gmail.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 1 month
[mcgrof-next:20210819-add-disk-error-handling-next 67/90] drivers/memstick/core/ms_block.c:2166:29: error: passing argument 1 of 'blk_cleanup_disk' from incompatible pointer type
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git 20210819-add-disk-error-handling-next
head: 4a644c3aee4465306a79d393956c84ce8925fa6b
commit: 11db06272f02ef4208857a2825c3799afa048f13 [67/90] ms_block: add error handling support for add_disk()
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git/com...
git remote add mcgrof-next https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git
git fetch --no-tags mcgrof-next 20210819-add-disk-error-handling-next
git checkout 11db06272f02ef4208857a2825c3799afa048f13
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=xtensa
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
drivers/memstick/core/ms_block.c: In function 'msb_init_disk':
>> drivers/memstick/core/ms_block.c:2166:29: error: passing argument 1 of 'blk_cleanup_disk' from incompatible pointer type [-Werror=incompatible-pointer-types]
2166 | blk_cleanup_disk(msb->queue);
| ~~~^~~~~~~
| |
| struct request_queue *
In file included from include/linux/blkdev.h:8,
from include/linux/blk-mq.h:5,
from drivers/memstick/core/ms_block.c:14:
include/linux/genhd.h:281:39: note: expected 'struct gendisk *' but argument is of type 'struct request_queue *'
281 | void blk_cleanup_disk(struct gendisk *disk);
| ~~~~~~~~~~~~~~~~^~~~
cc1: some warnings being treated as errors
vim +/blk_cleanup_disk +2166 drivers/memstick/core/ms_block.c
2108
2109 /* Registers the block device */
2110 static int msb_init_disk(struct memstick_dev *card)
2111 {
2112 struct msb_data *msb = memstick_get_drvdata(card);
2113 int rc;
2114 unsigned long capacity;
2115
2116 mutex_lock(&msb_disk_lock);
2117 msb->disk_id = idr_alloc(&msb_disk_idr, card, 0, 256, GFP_KERNEL);
2118 mutex_unlock(&msb_disk_lock);
2119
2120 if (msb->disk_id < 0)
2121 return msb->disk_id;
2122
2123 rc = blk_mq_alloc_sq_tag_set(&msb->tag_set, &msb_mq_ops, 2,
2124 BLK_MQ_F_SHOULD_MERGE);
2125 if (rc)
2126 goto out_release_id;
2127
2128 msb->disk = blk_mq_alloc_disk(&msb->tag_set, card);
2129 if (IS_ERR(msb->disk)) {
2130 rc = PTR_ERR(msb->disk);
2131 goto out_free_tag_set;
2132 }
2133 msb->queue = msb->disk->queue;
2134
2135 blk_queue_max_hw_sectors(msb->queue, MS_BLOCK_MAX_PAGES);
2136 blk_queue_max_segments(msb->queue, MS_BLOCK_MAX_SEGS);
2137 blk_queue_max_segment_size(msb->queue,
2138 MS_BLOCK_MAX_PAGES * msb->page_size);
2139 blk_queue_logical_block_size(msb->queue, msb->page_size);
2140
2141 sprintf(msb->disk->disk_name, "msblk%d", msb->disk_id);
2142 msb->disk->fops = &msb_bdops;
2143 msb->disk->private_data = msb;
2144
2145 capacity = msb->pages_in_block * msb->logical_block_count;
2146 capacity *= (msb->page_size / 512);
2147 set_capacity(msb->disk, capacity);
2148 dbg("Set total disk size to %lu sectors", capacity);
2149
2150 msb->usage_count = 1;
2151 msb->io_queue = alloc_ordered_workqueue("ms_block", WQ_MEM_RECLAIM);
2152 INIT_WORK(&msb->io_work, msb_io_work);
2153 sg_init_table(msb->prealloc_sg, MS_BLOCK_MAX_SEGS+1);
2154
2155 if (msb->read_only)
2156 set_disk_ro(msb->disk, 1);
2157
2158 msb_start(card);
2159 rc = device_add_disk(&card->dev, msb->disk, NULL);
2160 if (rc)
2161 goto out_cleanup_disk;
2162 dbg("Disk added");
2163 return 0;
2164
2165 out_cleanup_disk:
> 2166 blk_cleanup_disk(msb->queue);
2167 out_free_tag_set:
2168 blk_mq_free_tag_set(&msb->tag_set);
2169 out_release_id:
2170 mutex_lock(&msb_disk_lock);
2171 idr_remove(&msb_disk_idr, msb->disk_id);
2172 mutex_unlock(&msb_disk_lock);
2173 return rc;
2174 }
2175
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 1 month
Re: [PATCH v4 1/6] iio: Add output buffer support
by kernel test robot
Hi Mihail,
I love your patch! Perhaps something to improve:
[auto build test WARNING on 94a853eca720ac9e385e59f27e859b4a01123f58]
url: https://github.com/0day-ci/linux/commits/Mihail-Chindris/iio-Add-output-b...
base: 94a853eca720ac9e385e59f27e859b4a01123f58
config: x86_64-randconfig-a005-20210821 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project d9c5613e856cf2addfbf892fc4c1ce9ef9feceaa)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/b4f124803ed8bfe5936c756ed4c7aa912...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Mihail-Chindris/iio-Add-output-buffer-support-and-DAC-example/20210821-010349
git checkout b4f124803ed8bfe5936c756ed4c7aa9124a1468a
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/iio/industrialio-buffer.c:1415: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* When adding new attributes here, put the at the end, at least until
vim +1415 drivers/iio/industrialio-buffer.c
1413
1414 /**
> 1415 * When adding new attributes here, put the at the end, at least until
1416 * the code that handles the lengh/length_ro & watermark/watermark_ro
1417 * assignments gets cleaned up. Otherwise these can create some weird
1418 * duplicate attributes errors under some setups.
1419 */
1420 static struct attribute *iio_buffer_attrs[] = {
1421 &dev_attr_length.attr,
1422 &dev_attr_enable.attr,
1423 &dev_attr_watermark.attr,
1424 &dev_attr_data_available.attr,
1425 &dev_attr_direction.attr,
1426 };
1427
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 1 month