[PATCH] gpio: fix noderef.cocci warnings
by kernel test robot
From: kernel test robot <lkp(a)intel.com>
drivers/gpio/gpio-virtio.c:261:42-48: ERROR: application of sizeof to pointer
sizeof when applied to a pointer typed expression gives the size of
the pointer
Generated by: scripts/coccinelle/misc/noderef.cocci
CC: Viresh Kumar <viresh.kumar(a)linaro.org>
Reported-by: kernel test robot <lkp(a)intel.com>
Signed-off-by: kernel test robot <lkp(a)intel.com>
---
url: https://github.com/0day-ci/linux/commits/Viresh-Kumar/gpio-Add-virtio-gpi...
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 614cb2751d3150850d459bee596c397f344a7936
:::::: branch date: 7 hours ago
:::::: commit date: 7 hours ago
gpio-virtio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/gpio/gpio-virtio.c
+++ b/drivers/gpio/gpio-virtio.c
@@ -258,7 +258,7 @@ static const char **virtio_gpio_get_name
return NULL;
}
- names = devm_kcalloc(dev, config->ngpio, sizeof(names), GFP_KERNEL);
+ names = devm_kcalloc(dev, config->ngpio, sizeof(*names), GFP_KERNEL);
if (!names)
return NULL;
1 year, 1 month
Re: [PATCH v8 2/3] tty: hvc: pass DMA capable memory to put_chars()
by kernel test robot
Hi Xianting,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on tty/tty-testing]
[also build test WARNING on char-misc/char-misc-testing soc/for-next v5.14-rc6 next-20210818]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Xianting-Tian/make-hvc-pass-dma-...
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
config: arm64-randconfig-r025-20210818 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project d2b574a4dea5b718e4386bf2e26af0126e5978ce)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/0day-ci/linux/commit/e1b7662dafceb07a6905b64da2f1be274...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Xianting-Tian/make-hvc-pass-dma-capable-memory-to-its-backend/20210818-162408
git checkout e1b7662dafceb07a6905b64da2f1be27498c4a46
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/tty/hvc/hvc_console.c:880:39: warning: incompatible integer to pointer conversion passing 'char' to parameter of type 'const char *'; take the address with & [-Wint-conversion]
n = hp->ops->put_chars(hp->vtermno, hp->out_ch, 1);
^~~~~~~~~~
&
1 warning generated.
vim +880 drivers/tty/hvc/hvc_console.c
870
871 static void hvc_poll_put_char(struct tty_driver *driver, int line, char ch)
872 {
873 struct tty_struct *tty = driver->ttys[0];
874 struct hvc_struct *hp = tty->driver_data;
875 int n;
876
877 hp->out_ch = ch;
878
879 do {
> 880 n = hp->ops->put_chars(hp->vtermno, hp->out_ch, 1);
881 } while (n <= 0);
882 }
883 #endif
884
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 1 month
[peterz-queue:perf/core 7/8] arch/x86/events/amd/ibs.c:829:5: error: redefinition of 'get_ibs_caps'
by kernel test robot
Hi Kim,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git perf/core
head: 0b8f94ea282357a79781d10024708c2cf0ff5305
commit: 10684f2b277c733c018c5d07ddb4aa980ba4fcc5 [7/8] perf/amd/uncore: Allow the driver to be built as a module
config: i386-tinyconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git/commit/?...
git remote add peterz-queue https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git
git fetch --no-tags peterz-queue perf/core
git checkout 10684f2b277c733c018c5d07ddb4aa980ba4fcc5
# save the attached .config to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash arch/x86/events/amd/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> arch/x86/events/amd/ibs.c:829:5: error: redefinition of 'get_ibs_caps'
829 | u32 get_ibs_caps(void)
| ^~~~~~~~~~~~
In file included from include/linux/perf_event.h:25,
from arch/x86/events/amd/ibs.c:9:
arch/x86/include/asm/perf_event.h:426:19: note: previous definition of 'get_ibs_caps' was here
426 | static inline u32 get_ibs_caps(void) { return 0; }
| ^~~~~~~~~~~~
arch/x86/events/amd/ibs.c: In function 'get_eilvt':
>> arch/x86/events/amd/ibs.c:838:10: error: implicit declaration of function 'setup_APIC_eilvt' [-Werror=implicit-function-declaration]
838 | return !setup_APIC_eilvt(offset, 0, APIC_EILVT_MSG_NMI, 1);
| ^~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/get_ibs_caps +829 arch/x86/events/amd/ibs.c
b716916679e720 arch/x86/kernel/cpu/perf_event_amd_ibs.c Robert Richter 2011-09-21 828
b716916679e720 arch/x86/kernel/cpu/perf_event_amd_ibs.c Robert Richter 2011-09-21 @829 u32 get_ibs_caps(void)
b716916679e720 arch/x86/kernel/cpu/perf_event_amd_ibs.c Robert Richter 2011-09-21 830 {
b716916679e720 arch/x86/kernel/cpu/perf_event_amd_ibs.c Robert Richter 2011-09-21 831 return ibs_caps;
b716916679e720 arch/x86/kernel/cpu/perf_event_amd_ibs.c Robert Richter 2011-09-21 832 }
b716916679e720 arch/x86/kernel/cpu/perf_event_amd_ibs.c Robert Richter 2011-09-21 833
b716916679e720 arch/x86/kernel/cpu/perf_event_amd_ibs.c Robert Richter 2011-09-21 834 EXPORT_SYMBOL(get_ibs_caps);
b716916679e720 arch/x86/kernel/cpu/perf_event_amd_ibs.c Robert Richter 2011-09-21 835
b716916679e720 arch/x86/kernel/cpu/perf_event_amd_ibs.c Robert Richter 2011-09-21 836 static inline int get_eilvt(int offset)
b716916679e720 arch/x86/kernel/cpu/perf_event_amd_ibs.c Robert Richter 2011-09-21 837 {
b716916679e720 arch/x86/kernel/cpu/perf_event_amd_ibs.c Robert Richter 2011-09-21 @838 return !setup_APIC_eilvt(offset, 0, APIC_EILVT_MSG_NMI, 1);
b716916679e720 arch/x86/kernel/cpu/perf_event_amd_ibs.c Robert Richter 2011-09-21 839 }
b716916679e720 arch/x86/kernel/cpu/perf_event_amd_ibs.c Robert Richter 2011-09-21 840
:::::: The code at line 829 was first introduced by commit
:::::: b716916679e72054d436afadce2f94dcad71cfad perf, x86: Implement IBS initialization
:::::: TO: Robert Richter <robert.richter(a)amd.com>
:::::: CC: Ingo Molnar <mingo(a)elte.hu>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 1 month
[linux-next:master 8730/8804] drivers/scsi/arm/fas216.c:993:20: error: no member named 'tag' in 'struct scsi_cmnd'
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: f26c3abc432a2026ba9ee7767061a1f88aead6ec
commit: 4c7b6ea336c1e415fc002c756449835de768914c [8730/8804] scsi: core: Remove scsi_cmnd.tag
config: arm-randconfig-r035-20210818 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project d2b574a4dea5b718e4386bf2e26af0126e5978ce)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
# https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commi...
git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git fetch --no-tags linux-next master
git checkout 4c7b6ea336c1e415fc002c756449835de768914c
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross O=build_dir ARCH=arm SHELL=/bin/bash drivers/scsi/arm/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> drivers/scsi/arm/fas216.c:993:20: error: no member named 'tag' in 'struct scsi_cmnd'
info->SCpnt->tag == tag) {
~~~~~~~~~~~ ^
drivers/scsi/arm/fas216.c:1793:13: error: no member named 'tag' in 'struct scsi_cmnd'
if (SCpnt->tag)
~~~~~ ^
drivers/scsi/arm/fas216.c:1794:65: error: no member named 'tag' in 'struct scsi_cmnd'
msgqueue_addmsg(&info->scsi.msgs, 2, SIMPLE_QUEUE_TAG, SCpnt->tag);
~~~~~ ^
drivers/scsi/arm/fas216.c:2119:9: error: no member named 'tag' in 'struct scsi_cmnd'
SCpnt->tag = 0;
~~~~~ ^
drivers/scsi/arm/fas216.c:2225:9: error: no member named 'tag' in 'struct scsi_cmnd'
SCpnt->tag = 0;
~~~~~ ^
5 errors generated.
--
>> drivers/scsi/arm/queue.c:217:17: error: no member named 'tag' in 'struct scsi_cmnd'
q->SCpnt->tag == tag) {
~~~~~~~~ ^
1 error generated.
vim +993 drivers/scsi/arm/fas216.c
^1da177e4c3f415 Linus Torvalds 2005-04-16 930
^1da177e4c3f415 Linus Torvalds 2005-04-16 931 /**
^1da177e4c3f415 Linus Torvalds 2005-04-16 932 * fas216_reselected_intr - start reconnection of a device
^1da177e4c3f415 Linus Torvalds 2005-04-16 933 * @info: interface which was reselected
^1da177e4c3f415 Linus Torvalds 2005-04-16 934 *
^1da177e4c3f415 Linus Torvalds 2005-04-16 935 * Start reconnection of a device
^1da177e4c3f415 Linus Torvalds 2005-04-16 936 */
^1da177e4c3f415 Linus Torvalds 2005-04-16 937 static void
^1da177e4c3f415 Linus Torvalds 2005-04-16 938 fas216_reselected_intr(FAS216_Info *info)
^1da177e4c3f415 Linus Torvalds 2005-04-16 939 {
^1da177e4c3f415 Linus Torvalds 2005-04-16 940 unsigned int cfis, i;
^1da177e4c3f415 Linus Torvalds 2005-04-16 941 unsigned char msg[4];
^1da177e4c3f415 Linus Torvalds 2005-04-16 942 unsigned char target, lun, tag;
^1da177e4c3f415 Linus Torvalds 2005-04-16 943
^1da177e4c3f415 Linus Torvalds 2005-04-16 944 fas216_checkmagic(info);
^1da177e4c3f415 Linus Torvalds 2005-04-16 945
^1da177e4c3f415 Linus Torvalds 2005-04-16 946 WARN_ON(info->scsi.phase == PHASE_SELECTION ||
^1da177e4c3f415 Linus Torvalds 2005-04-16 947 info->scsi.phase == PHASE_SELSTEPS);
^1da177e4c3f415 Linus Torvalds 2005-04-16 948
^1da177e4c3f415 Linus Torvalds 2005-04-16 949 cfis = fas216_readb(info, REG_CFIS);
^1da177e4c3f415 Linus Torvalds 2005-04-16 950
^1da177e4c3f415 Linus Torvalds 2005-04-16 951 fas216_log(info, LOG_CONNECT, "reconnect phase=%02x cfis=%02x",
^1da177e4c3f415 Linus Torvalds 2005-04-16 952 info->scsi.phase, cfis);
^1da177e4c3f415 Linus Torvalds 2005-04-16 953
^1da177e4c3f415 Linus Torvalds 2005-04-16 954 cfis &= CFIS_CF;
^1da177e4c3f415 Linus Torvalds 2005-04-16 955
^1da177e4c3f415 Linus Torvalds 2005-04-16 956 if (cfis < 2 || cfis > 4) {
^1da177e4c3f415 Linus Torvalds 2005-04-16 957 printk(KERN_ERR "scsi%d.H: incorrect number of bytes after reselect\n",
^1da177e4c3f415 Linus Torvalds 2005-04-16 958 info->host->host_no);
^1da177e4c3f415 Linus Torvalds 2005-04-16 959 goto bad_message;
^1da177e4c3f415 Linus Torvalds 2005-04-16 960 }
^1da177e4c3f415 Linus Torvalds 2005-04-16 961
^1da177e4c3f415 Linus Torvalds 2005-04-16 962 for (i = 0; i < cfis; i++)
^1da177e4c3f415 Linus Torvalds 2005-04-16 963 msg[i] = fas216_readb(info, REG_FF);
^1da177e4c3f415 Linus Torvalds 2005-04-16 964
^1da177e4c3f415 Linus Torvalds 2005-04-16 965 if (!(msg[0] & (1 << info->host->this_id)) ||
^1da177e4c3f415 Linus Torvalds 2005-04-16 966 !(msg[1] & 0x80))
^1da177e4c3f415 Linus Torvalds 2005-04-16 967 goto initiator_error;
^1da177e4c3f415 Linus Torvalds 2005-04-16 968
^1da177e4c3f415 Linus Torvalds 2005-04-16 969 target = msg[0] & ~(1 << info->host->this_id);
^1da177e4c3f415 Linus Torvalds 2005-04-16 970 target = ffs(target) - 1;
^1da177e4c3f415 Linus Torvalds 2005-04-16 971 lun = msg[1] & 7;
^1da177e4c3f415 Linus Torvalds 2005-04-16 972 tag = 0;
^1da177e4c3f415 Linus Torvalds 2005-04-16 973
^1da177e4c3f415 Linus Torvalds 2005-04-16 974 if (cfis >= 3) {
^1da177e4c3f415 Linus Torvalds 2005-04-16 975 if (msg[2] != SIMPLE_QUEUE_TAG)
^1da177e4c3f415 Linus Torvalds 2005-04-16 976 goto initiator_error;
^1da177e4c3f415 Linus Torvalds 2005-04-16 977
^1da177e4c3f415 Linus Torvalds 2005-04-16 978 tag = msg[3];
^1da177e4c3f415 Linus Torvalds 2005-04-16 979 }
^1da177e4c3f415 Linus Torvalds 2005-04-16 980
^1da177e4c3f415 Linus Torvalds 2005-04-16 981 /* set up for synchronous transfers */
^1da177e4c3f415 Linus Torvalds 2005-04-16 982 fas216_writeb(info, REG_SDID, target);
^1da177e4c3f415 Linus Torvalds 2005-04-16 983 fas216_set_sync(info, target);
^1da177e4c3f415 Linus Torvalds 2005-04-16 984 msgqueue_flush(&info->scsi.msgs);
^1da177e4c3f415 Linus Torvalds 2005-04-16 985
^1da177e4c3f415 Linus Torvalds 2005-04-16 986 fas216_log(info, LOG_CONNECT, "Reconnected: target %1x lun %1x tag %02x",
^1da177e4c3f415 Linus Torvalds 2005-04-16 987 target, lun, tag);
^1da177e4c3f415 Linus Torvalds 2005-04-16 988
^1da177e4c3f415 Linus Torvalds 2005-04-16 989 if (info->scsi.disconnectable && info->SCpnt) {
^1da177e4c3f415 Linus Torvalds 2005-04-16 990 info->scsi.disconnectable = 0;
^1da177e4c3f415 Linus Torvalds 2005-04-16 991 if (info->SCpnt->device->id == target &&
^1da177e4c3f415 Linus Torvalds 2005-04-16 992 info->SCpnt->device->lun == lun &&
^1da177e4c3f415 Linus Torvalds 2005-04-16 @993 info->SCpnt->tag == tag) {
^1da177e4c3f415 Linus Torvalds 2005-04-16 994 fas216_log(info, LOG_CONNECT, "reconnected previously executing command");
^1da177e4c3f415 Linus Torvalds 2005-04-16 995 } else {
^1da177e4c3f415 Linus Torvalds 2005-04-16 996 queue_add_cmd_tail(&info->queues.disconnected, info->SCpnt);
^1da177e4c3f415 Linus Torvalds 2005-04-16 997 fas216_log(info, LOG_CONNECT, "had to move command to disconnected queue");
^1da177e4c3f415 Linus Torvalds 2005-04-16 998 info->SCpnt = NULL;
^1da177e4c3f415 Linus Torvalds 2005-04-16 999 }
^1da177e4c3f415 Linus Torvalds 2005-04-16 1000 }
^1da177e4c3f415 Linus Torvalds 2005-04-16 1001 if (!info->SCpnt) {
^1da177e4c3f415 Linus Torvalds 2005-04-16 1002 info->SCpnt = queue_remove_tgtluntag(&info->queues.disconnected,
^1da177e4c3f415 Linus Torvalds 2005-04-16 1003 target, lun, tag);
^1da177e4c3f415 Linus Torvalds 2005-04-16 1004 fas216_log(info, LOG_CONNECT, "had to get command");
^1da177e4c3f415 Linus Torvalds 2005-04-16 1005 }
^1da177e4c3f415 Linus Torvalds 2005-04-16 1006
^1da177e4c3f415 Linus Torvalds 2005-04-16 1007 if (info->SCpnt) {
^1da177e4c3f415 Linus Torvalds 2005-04-16 1008 /*
^1da177e4c3f415 Linus Torvalds 2005-04-16 1009 * Restore data pointer from SAVED data pointer
^1da177e4c3f415 Linus Torvalds 2005-04-16 1010 */
^1da177e4c3f415 Linus Torvalds 2005-04-16 1011 info->scsi.SCp = info->SCpnt->SCp;
^1da177e4c3f415 Linus Torvalds 2005-04-16 1012
^1da177e4c3f415 Linus Torvalds 2005-04-16 1013 fas216_log(info, LOG_CONNECT, "data pointers: [%p, %X]",
^1da177e4c3f415 Linus Torvalds 2005-04-16 1014 info->scsi.SCp.ptr, info->scsi.SCp.this_residual);
^1da177e4c3f415 Linus Torvalds 2005-04-16 1015 info->scsi.phase = PHASE_MSGIN;
^1da177e4c3f415 Linus Torvalds 2005-04-16 1016 } else {
^1da177e4c3f415 Linus Torvalds 2005-04-16 1017 /*
^1da177e4c3f415 Linus Torvalds 2005-04-16 1018 * Our command structure not found - abort the
^1da177e4c3f415 Linus Torvalds 2005-04-16 1019 * command on the target. Since we have no
^1da177e4c3f415 Linus Torvalds 2005-04-16 1020 * record of this command, we can't send
^1da177e4c3f415 Linus Torvalds 2005-04-16 1021 * an INITIATOR DETECTED ERROR message.
^1da177e4c3f415 Linus Torvalds 2005-04-16 1022 */
^1da177e4c3f415 Linus Torvalds 2005-04-16 1023 fas216_cmd(info, CMD_SETATN);
^1da177e4c3f415 Linus Torvalds 2005-04-16 1024
:::::: The code at line 993 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2
:::::: TO: Linus Torvalds <torvalds(a)ppc970.osdl.org>
:::::: CC: Linus Torvalds <torvalds(a)ppc970.osdl.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 1 month
[mcgrof-next:20210817-add-disk-error-handling-next 1/89] drivers/nvme/host/core.c:3760:22: error: use of undeclared identifier 'NVME_QUIRK_LIGHTNVM'; did you mean 'NVME_NS_LIGHTNVM'?
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git 20210817-add-disk-error-handling-next
head: 3d00c210d7fd616243af9cf41829f4a56f116ba8
commit: 6e8cedeeaa2d0b259010b0d956020ba8284196ce [1/89] nvme: use blk_mq_alloc_disk
config: hexagon-randconfig-r045-20210816 (attached as .config)
compiler: clang version 12.0.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git/com...
git remote add mcgrof-next https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git
git fetch --no-tags mcgrof-next 20210817-add-disk-error-handling-next
git checkout 6e8cedeeaa2d0b259010b0d956020ba8284196ce
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross O=build_dir ARCH=hexagon SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> drivers/nvme/host/core.c:3760:22: error: use of undeclared identifier 'NVME_QUIRK_LIGHTNVM'; did you mean 'NVME_NS_LIGHTNVM'?
if ((ctrl->quirks & NVME_QUIRK_LIGHTNVM) && id->vs[0] == 0x1) {
^~~~~~~~~~~~~~~~~~~
NVME_NS_LIGHTNVM
drivers/nvme/host/nvme.h:52:2: note: 'NVME_NS_LIGHTNVM' declared here
NVME_NS_LIGHTNVM = 1,
^
>> drivers/nvme/host/core.c:3761:7: error: implicit declaration of function 'nvme_nvm_register' [-Werror,-Wimplicit-function-declaration]
if (nvme_nvm_register(ns, disk->disk_name, node)) {
^
drivers/nvme/host/core.c:3761:7: note: did you mean 'nvme_pr_register'?
drivers/nvme/host/core.c:1970:12: note: 'nvme_pr_register' declared here
static int nvme_pr_register(struct block_device *bdev, u64 old,
^
2 errors generated.
vim +3760 drivers/nvme/host/core.c
3710
3711 static void nvme_alloc_ns(struct nvme_ctrl *ctrl, unsigned nsid,
3712 struct nvme_ns_ids *ids)
3713 {
3714 struct nvme_ns *ns;
3715 struct gendisk *disk;
3716 struct nvme_id_ns *id;
3717 int node = ctrl->numa_node;
3718
3719 if (nvme_identify_ns(ctrl, nsid, ids, &id))
3720 return;
3721
3722 ns = kzalloc_node(sizeof(*ns), GFP_KERNEL, node);
3723 if (!ns)
3724 goto out_free_id;
3725
3726 disk = blk_mq_alloc_disk(ctrl->tagset, ns);
3727 if (IS_ERR(disk))
3728 goto out_free_ns;
3729 disk->fops = &nvme_bdev_ops;
3730 disk->private_data = ns;
3731
3732 ns->disk = disk;
3733 ns->queue = disk->queue;
3734
3735 if (ctrl->opts && ctrl->opts->data_digest)
3736 blk_queue_flag_set(QUEUE_FLAG_STABLE_WRITES, ns->queue);
3737
3738 blk_queue_flag_set(QUEUE_FLAG_NONROT, ns->queue);
3739 if (ctrl->ops->flags & NVME_F_PCI_P2PDMA)
3740 blk_queue_flag_set(QUEUE_FLAG_PCI_P2PDMA, ns->queue);
3741
3742 ns->ctrl = ctrl;
3743 kref_init(&ns->kref);
3744
3745 if (nvme_init_ns_head(ns, nsid, ids, id->nmic & NVME_NS_NMIC_SHARED))
3746 goto out_cleanup_disk;
3747
3748 /*
3749 * Without the multipath code enabled, multiple controller per
3750 * subsystems are visible as devices and thus we cannot use the
3751 * subsystem instance.
3752 */
3753 if (!nvme_mpath_set_disk_name(ns, disk->disk_name, &disk->flags))
3754 sprintf(disk->disk_name, "nvme%dn%d", ctrl->instance,
3755 ns->head->instance);
3756
3757 if (nvme_update_ns_info(ns, id))
3758 goto out_unlink_ns;
3759
> 3760 if ((ctrl->quirks & NVME_QUIRK_LIGHTNVM) && id->vs[0] == 0x1) {
> 3761 if (nvme_nvm_register(ns, disk->disk_name, node)) {
3762 dev_warn(ctrl->device, "LightNVM init failure\n");
3763 goto out_unlink_ns;
3764 }
3765 }
3766
3767 down_write(&ctrl->namespaces_rwsem);
3768 list_add_tail(&ns->list, &ctrl->namespaces);
3769 up_write(&ctrl->namespaces_rwsem);
3770
3771 nvme_get_ctrl(ctrl);
3772
3773 device_add_disk(ctrl->device, ns->disk, nvme_ns_id_attr_groups);
3774 if (!nvme_ns_head_multipath(ns->head))
3775 nvme_add_ns_cdev(ns);
3776
3777 nvme_mpath_add_disk(ns, id);
3778 nvme_fault_inject_init(&ns->fault_inject, ns->disk->disk_name);
3779 kfree(id);
3780
3781 return;
3782
3783 out_unlink_ns:
3784 mutex_lock(&ctrl->subsys->lock);
3785 list_del_rcu(&ns->siblings);
3786 if (list_empty(&ns->head->list))
3787 list_del_init(&ns->head->entry);
3788 mutex_unlock(&ctrl->subsys->lock);
3789 nvme_put_ns_head(ns->head);
3790 out_cleanup_disk:
3791 blk_cleanup_disk(disk);
3792 out_free_ns:
3793 kfree(ns);
3794 out_free_id:
3795 kfree(id);
3796 }
3797
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 1 month
[mcgrof:20210818-add-disk-error-handling-v2 160/160] drivers/lightnvm/core.c:400:9: warning: ignoring return value of 'add_disk' declared with attribute 'warn_unused_result'
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git 20210818-add-disk-error-handling-v2
head: 0517c8bf82eb7da58caada94869afb0957f57c81
commit: 0517c8bf82eb7da58caada94869afb0957f57c81 [160/160] block: add __must_check for *add_disk*() callers
config: arc-randconfig-r043-20210818 (attached as .config)
compiler: arceb-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/commit/?...
git remote add mcgrof https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git
git fetch --no-tags mcgrof 20210818-add-disk-error-handling-v2
git checkout 0517c8bf82eb7da58caada94869afb0957f57c81
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=arc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
drivers/lightnvm/core.c: In function 'nvm_create_tgt':
>> drivers/lightnvm/core.c:400:9: warning: ignoring return value of 'add_disk' declared with attribute 'warn_unused_result' [-Wunused-result]
400 | add_disk(tdisk);
| ^~~~~~~~~~~~~~~
vim +400 drivers/lightnvm/core.c
e53927393b9987 Javier González 2018-01-05 304
ade69e2432b795 Matias Bjørling 2017-01-31 305 static int nvm_create_tgt(struct nvm_dev *dev, struct nvm_ioctl_create *create)
ade69e2432b795 Matias Bjørling 2017-01-31 306 {
e53927393b9987 Javier González 2018-01-05 307 struct nvm_ioctl_create_extended e;
ade69e2432b795 Matias Bjørling 2017-01-31 308 struct gendisk *tdisk;
ade69e2432b795 Matias Bjørling 2017-01-31 309 struct nvm_tgt_type *tt;
ade69e2432b795 Matias Bjørling 2017-01-31 310 struct nvm_target *t;
ade69e2432b795 Matias Bjørling 2017-01-31 311 struct nvm_tgt_dev *tgt_dev;
ade69e2432b795 Matias Bjørling 2017-01-31 312 void *targetdata;
a14669ebc0e294 Igor Konopko 2019-05-04 313 unsigned int mdts;
8d77bb8276062f Rakesh Pandit 2017-04-20 314 int ret;
ade69e2432b795 Matias Bjørling 2017-01-31 315
e53927393b9987 Javier González 2018-01-05 316 switch (create->conf.type) {
e53927393b9987 Javier González 2018-01-05 317 case NVM_CONFIG_TYPE_SIMPLE:
e53927393b9987 Javier González 2018-01-05 318 ret = __nvm_config_simple(dev, &create->conf.s);
e53927393b9987 Javier González 2018-01-05 319 if (ret)
e53927393b9987 Javier González 2018-01-05 320 return ret;
e53927393b9987 Javier González 2018-01-05 321
e53927393b9987 Javier González 2018-01-05 322 e.lun_begin = create->conf.s.lun_begin;
e53927393b9987 Javier González 2018-01-05 323 e.lun_end = create->conf.s.lun_end;
e53927393b9987 Javier González 2018-01-05 324 e.op = NVM_TARGET_DEFAULT_OP;
e53927393b9987 Javier González 2018-01-05 325 break;
e53927393b9987 Javier González 2018-01-05 326 case NVM_CONFIG_TYPE_EXTENDED:
e53927393b9987 Javier González 2018-01-05 327 ret = __nvm_config_extended(dev, &create->conf.e);
e53927393b9987 Javier González 2018-01-05 328 if (ret)
e53927393b9987 Javier González 2018-01-05 329 return ret;
e53927393b9987 Javier González 2018-01-05 330
e53927393b9987 Javier González 2018-01-05 331 e = create->conf.e;
e53927393b9987 Javier González 2018-01-05 332 break;
e53927393b9987 Javier González 2018-01-05 333 default:
43db059ea4b7e9 Minwoo Im 2019-09-05 334 pr_err("config type not valid\n");
e53927393b9987 Javier González 2018-01-05 335 return -EINVAL;
e53927393b9987 Javier González 2018-01-05 336 }
e53927393b9987 Javier González 2018-01-05 337
e29c80e6dd70d6 Javier González 2018-01-05 338 tt = nvm_find_target_type(create->tgttype);
ade69e2432b795 Matias Bjørling 2017-01-31 339 if (!tt) {
43db059ea4b7e9 Minwoo Im 2019-09-05 340 pr_err("target type %s not found\n", create->tgttype);
ade69e2432b795 Matias Bjørling 2017-01-31 341 return -EINVAL;
ade69e2432b795 Matias Bjørling 2017-01-31 342 }
ade69e2432b795 Matias Bjørling 2017-01-31 343
656e33ca3d4051 Matias Bjørling 2018-10-09 344 if ((tt->flags & NVM_TGT_F_HOST_L2P) != (dev->geo.dom & NVM_RSP_L2P)) {
43db059ea4b7e9 Minwoo Im 2019-09-05 345 pr_err("device is incompatible with target L2P type.\n");
656e33ca3d4051 Matias Bjørling 2018-10-09 346 return -EINVAL;
656e33ca3d4051 Matias Bjørling 2018-10-09 347 }
656e33ca3d4051 Matias Bjørling 2018-10-09 348
bd77b23b40370f Javier González 2018-01-05 349 if (nvm_target_exists(create->tgtname)) {
43db059ea4b7e9 Minwoo Im 2019-09-05 350 pr_err("target name already exists (%s)\n",
bd77b23b40370f Javier González 2018-01-05 351 create->tgtname);
ade69e2432b795 Matias Bjørling 2017-01-31 352 return -EINVAL;
ade69e2432b795 Matias Bjørling 2017-01-31 353 }
ade69e2432b795 Matias Bjørling 2017-01-31 354
e53927393b9987 Javier González 2018-01-05 355 ret = nvm_reserve_luns(dev, e.lun_begin, e.lun_end);
12e9a6d62236da Rakesh Pandit 2017-06-27 356 if (ret)
12e9a6d62236da Rakesh Pandit 2017-06-27 357 return ret;
ade69e2432b795 Matias Bjørling 2017-01-31 358
ade69e2432b795 Matias Bjørling 2017-01-31 359 t = kmalloc(sizeof(struct nvm_target), GFP_KERNEL);
8d77bb8276062f Rakesh Pandit 2017-04-20 360 if (!t) {
8d77bb8276062f Rakesh Pandit 2017-04-20 361 ret = -ENOMEM;
ade69e2432b795 Matias Bjørling 2017-01-31 362 goto err_reserve;
8d77bb8276062f Rakesh Pandit 2017-04-20 363 }
ade69e2432b795 Matias Bjørling 2017-01-31 364
e53927393b9987 Javier González 2018-01-05 365 tgt_dev = nvm_create_tgt_dev(dev, e.lun_begin, e.lun_end, e.op);
ade69e2432b795 Matias Bjørling 2017-01-31 366 if (!tgt_dev) {
43db059ea4b7e9 Minwoo Im 2019-09-05 367 pr_err("could not create target device\n");
8d77bb8276062f Rakesh Pandit 2017-04-20 368 ret = -ENOMEM;
ade69e2432b795 Matias Bjørling 2017-01-31 369 goto err_t;
ade69e2432b795 Matias Bjørling 2017-01-31 370 }
ade69e2432b795 Matias Bjørling 2017-01-31 371
1aabd53a4b49ad Christoph Hellwig 2021-05-21 372 tdisk = blk_alloc_disk(dev->q->node);
8d77bb8276062f Rakesh Pandit 2017-04-20 373 if (!tdisk) {
8d77bb8276062f Rakesh Pandit 2017-04-20 374 ret = -ENOMEM;
7d1ef2f408abec Javier González 2017-04-15 375 goto err_dev;
8d77bb8276062f Rakesh Pandit 2017-04-20 376 }
7d1ef2f408abec Javier González 2017-04-15 377
6eb082452df121 Javier González 2017-04-15 378 strlcpy(tdisk->disk_name, create->tgtname, sizeof(tdisk->disk_name));
ade69e2432b795 Matias Bjørling 2017-01-31 379 tdisk->major = 0;
ade69e2432b795 Matias Bjørling 2017-01-31 380 tdisk->first_minor = 0;
c62b37d96b6eb3 Christoph Hellwig 2020-07-01 381 tdisk->fops = tt->bops;
ade69e2432b795 Matias Bjørling 2017-01-31 382
4af3f75d7992dd Javier González 2017-04-15 383 targetdata = tt->init(tgt_dev, tdisk, create->flags);
8d77bb8276062f Rakesh Pandit 2017-04-20 384 if (IS_ERR(targetdata)) {
8d77bb8276062f Rakesh Pandit 2017-04-20 385 ret = PTR_ERR(targetdata);
ade69e2432b795 Matias Bjørling 2017-01-31 386 goto err_init;
8d77bb8276062f Rakesh Pandit 2017-04-20 387 }
ade69e2432b795 Matias Bjørling 2017-01-31 388
ade69e2432b795 Matias Bjørling 2017-01-31 389 tdisk->private_data = targetdata;
1aabd53a4b49ad Christoph Hellwig 2021-05-21 390 tdisk->queue->queuedata = targetdata;
ade69e2432b795 Matias Bjørling 2017-01-31 391
a14669ebc0e294 Igor Konopko 2019-05-04 392 mdts = (dev->geo.csecs >> 9) * NVM_MAX_VLBA;
a14669ebc0e294 Igor Konopko 2019-05-04 393 if (dev->geo.mdts) {
a14669ebc0e294 Igor Konopko 2019-05-04 394 mdts = min_t(u32, dev->geo.mdts,
e46f4e4822bdec Javier González 2018-03-30 395 (dev->geo.csecs >> 9) * NVM_MAX_VLBA);
a14669ebc0e294 Igor Konopko 2019-05-04 396 }
1aabd53a4b49ad Christoph Hellwig 2021-05-21 397 blk_queue_max_hw_sectors(tdisk->queue, mdts);
ade69e2432b795 Matias Bjørling 2017-01-31 398
ade69e2432b795 Matias Bjørling 2017-01-31 399 set_capacity(tdisk, tt->capacity(targetdata));
ade69e2432b795 Matias Bjørling 2017-01-31 @400 add_disk(tdisk);
ade69e2432b795 Matias Bjørling 2017-01-31 401
8d77bb8276062f Rakesh Pandit 2017-04-20 402 if (tt->sysfs_init && tt->sysfs_init(tdisk)) {
8d77bb8276062f Rakesh Pandit 2017-04-20 403 ret = -ENOMEM;
9a69b0ed6257ae Javier González 2017-01-31 404 goto err_sysfs;
8d77bb8276062f Rakesh Pandit 2017-04-20 405 }
9a69b0ed6257ae Javier González 2017-01-31 406
ade69e2432b795 Matias Bjørling 2017-01-31 407 t->type = tt;
ade69e2432b795 Matias Bjørling 2017-01-31 408 t->disk = tdisk;
ade69e2432b795 Matias Bjørling 2017-01-31 409 t->dev = tgt_dev;
ade69e2432b795 Matias Bjørling 2017-01-31 410
ade69e2432b795 Matias Bjørling 2017-01-31 411 mutex_lock(&dev->mlock);
ade69e2432b795 Matias Bjørling 2017-01-31 412 list_add_tail(&t->list, &dev->targets);
ade69e2432b795 Matias Bjørling 2017-01-31 413 mutex_unlock(&dev->mlock);
ade69e2432b795 Matias Bjørling 2017-01-31 414
900148296b78c6 Rakesh Pandit 2017-10-13 415 __module_get(tt->owner);
900148296b78c6 Rakesh Pandit 2017-10-13 416
ade69e2432b795 Matias Bjørling 2017-01-31 417 return 0;
9a69b0ed6257ae Javier González 2017-01-31 418 err_sysfs:
9a69b0ed6257ae Javier González 2017-01-31 419 if (tt->exit)
a7c9e9109ca114 Javier González 2018-06-01 420 tt->exit(targetdata, true);
ade69e2432b795 Matias Bjørling 2017-01-31 421 err_init:
1aabd53a4b49ad Christoph Hellwig 2021-05-21 422 blk_cleanup_disk(tdisk);
ade69e2432b795 Matias Bjørling 2017-01-31 423 err_dev:
edee1bdd66bf0f Javier González 2017-04-15 424 nvm_remove_tgt_dev(tgt_dev, 0);
ade69e2432b795 Matias Bjørling 2017-01-31 425 err_t:
ade69e2432b795 Matias Bjørling 2017-01-31 426 kfree(t);
ade69e2432b795 Matias Bjørling 2017-01-31 427 err_reserve:
e53927393b9987 Javier González 2018-01-05 428 nvm_release_luns_err(dev, e.lun_begin, e.lun_end);
8d77bb8276062f Rakesh Pandit 2017-04-20 429 return ret;
ade69e2432b795 Matias Bjørling 2017-01-31 430 }
ade69e2432b795 Matias Bjørling 2017-01-31 431
:::::: The code at line 400 was first introduced by commit
:::::: ade69e2432b795c76653e1dfa09c684549826a50 lightnvm: merge gennvm with core
:::::: TO: Matias Bjørling <matias(a)cnexlabs.com>
:::::: CC: Jens Axboe <axboe(a)fb.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 1 month
[ti:ti-rt-linux-5.10.y 6649/6833] include/net/sock.h:2523:43: error: 'SCM_REDUNDANT' undeclared
by kernel test robot
Hi WingMan,
FYI, the error/warning still remains.
tree: git://git.ti.com/ti-linux-kernel/ti-linux-kernel.git ti-rt-linux-5.10.y
head: ac3657d2050406e974383b1490184f42a06b73cc
commit: e355bf097bb11257afeadf6665e51f224eeb93a7 [6649/6833] net: packet: Pass on redundant net info in packet_recvmsg
config: parisc-randconfig-r022-20210817 (attached as .config)
compiler: hppa-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git remote add ti git://git.ti.com/ti-linux-kernel/ti-linux-kernel.git
git fetch --no-tags ti ti-rt-linux-5.10.y
git checkout e355bf097bb11257afeadf6665e51f224eeb93a7
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=parisc SHELL=/bin/bash kernel/cgroup/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from kernel/cgroup/cgroup.c:60:
include/net/sock.h: In function 'sock_recv_redundant_info':
>> include/net/sock.h:2523:43: error: 'SCM_REDUNDANT' undeclared (first use in this function)
2523 | put_cmsg(msg, SOL_SOCKET, SCM_REDUNDANT, sizeof(*sred), sred);
| ^~~~~~~~~~~~~
include/net/sock.h:2523:43: note: each undeclared identifier is reported only once for each function it appears in
vim +/SCM_REDUNDANT +2523 include/net/sock.h
2514
2515 DECLARE_STATIC_KEY_FALSE(tcp_rx_skb_cache_key);
2516 static inline void sock_recv_redundant_info(struct msghdr *msg, struct sock *sk,
2517 struct sk_buff *skb)
2518 {
2519 struct skb_redundant_info *sred;
2520
2521 sred = skb_redinfo(skb);
2522 if (sred->lsdu_size)
> 2523 put_cmsg(msg, SOL_SOCKET, SCM_REDUNDANT, sizeof(*sred), sred);
2524 }
2525
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 1 month
Re: [PATCH 4/5] drm: zte: remove obsolete DRM Support for ZTE SoCs
by kernel test robot
Hi Lukas,
I love your patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on drm-tip/drm-tip next-20210818]
[cannot apply to rockchip/for-next linus/master v5.14-rc6]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Lukas-Bulwahn/Kconfig-symbol-cle...
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-tinyconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/432489a34862a1874790d81866c3a30bc...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Lukas-Bulwahn/Kconfig-symbol-clean-up-on-gpu/20210818-204414
git checkout 432489a34862a1874790d81866c3a30bca355979
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> drivers/gpu/drm/Kconfig:354: can't open file "drivers/gpu/drm/zte/Kconfig"
--
>> drivers/gpu/drm/Kconfig:354: can't open file "drivers/gpu/drm/zte/Kconfig"
make[2]: *** [scripts/kconfig/Makefile:77: olddefconfig] Error 1
make[1]: *** [Makefile:626: olddefconfig] Error 2
make: *** [Makefile:220: __sub-make] Error 2
make: Target 'olddefconfig' not remade because of errors.
--
>> drivers/gpu/drm/Kconfig:354: can't open file "drivers/gpu/drm/zte/Kconfig"
make[3]: *** [scripts/kconfig/Makefile:77: syncconfig] Error 1
make[2]: *** [Makefile:626: syncconfig] Error 2
make[1]: *** [Makefile:736: include/config/auto.conf.cmd] Error 2
make[1]: Failed to remake makefile 'include/config/auto.conf.cmd'.
make[1]: Failed to remake makefile 'include/config/auto.conf'.
make[1]: Target 'prepare' not remade because of errors.
make: *** [Makefile:220: __sub-make] Error 2
make: Target 'prepare' not remade because of errors.
vim +354 drivers/gpu/drm/Kconfig
d92d9c3a14488e David Herrmann 2016-08-04 353
0a886f59528aac Shawn Guo 2016-09-22 @354 source "drivers/gpu/drm/zte/Kconfig"
0a886f59528aac Shawn Guo 2016-09-22 355
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 1 month
Re: [PATCH v12] phy: HiSilicon: Add driver for Kirin 970 PCIe PHY
by kernel test robot
Hi Mauro,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.14-rc6 next-20210818]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Mauro-Carvalho-Chehab/phy-HiSili...
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 614cb2751d3150850d459bee596c397f344a7936
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/90e806228f10f8375d808f4813c6ea64a...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Mauro-Carvalho-Chehab/phy-HiSilicon-Add-driver-for-Kirin-970-PCIe-PHY/20210818-190539
git checkout 90e806228f10f8375d808f4813c6ea64aaa91a2a
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=ia64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
drivers/phy/hisilicon/phy-hi3670-pcie.c: In function 'hi3670_pcie_set_eyeparam':
>> drivers/phy/hisilicon/phy-hi3670-pcie.c:257:24: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration]
257 | val |= FIELD_PREP(EYE_PARM1_MASK, phy->eye_param[1]);
| ^~~~~~~~~~
cc1: some warnings being treated as errors
vim +/FIELD_PREP +257 drivers/phy/hisilicon/phy-hi3670-pcie.c
248
249 static void hi3670_pcie_set_eyeparam(struct hi3670_pcie_phy *phy)
250 {
251 u32 val;
252
253 val = kirin_apb_natural_phy_readl(phy, RAWLANEN_DIG_PCS_XF_TX_OVRD_IN_1);
254
255 if (phy->eye_param[1] != EYEPARAM_NOCFG) {
256 val &= ~EYE_PARM1_MASK;
> 257 val |= FIELD_PREP(EYE_PARM1_MASK, phy->eye_param[1]);
258 val |= EYE_PARM1_EN;
259 }
260 kirin_apb_natural_phy_writel(phy, val,
261 RAWLANEN_DIG_PCS_XF_TX_OVRD_IN_1);
262
263 val = kirin_apb_natural_phy_readl(phy, LANEN_DIG_ASIC_TX_OVRD_IN_2);
264 val &= ~(EYE_PARM2_MASK | EYE_PARM3_MASK);
265 if (phy->eye_param[2] != EYEPARAM_NOCFG) {
266 val |= FIELD_PREP(EYE_PARM2_MASK, phy->eye_param[2]);
267 val |= EYE_PARM2_EN;
268 }
269
270 if (phy->eye_param[3] != EYEPARAM_NOCFG) {
271 val |= FIELD_PREP(EYE_PARM3_MASK, phy->eye_param[3]);
272 val |= EYE_PARM3_EN;
273 }
274
275 kirin_apb_natural_phy_writel(phy, val, LANEN_DIG_ASIC_TX_OVRD_IN_2);
276
277 val = kirin_apb_natural_phy_readl(phy, SUP_DIG_LVL_OVRD_IN);
278 if (phy->eye_param[0] != EYEPARAM_NOCFG) {
279 val &= ~EYE_PARM0_MASK;
280 val |= FIELD_PREP(EYE_PARM0_MASK, phy->eye_param[0]);
281 val |= EYE_PARM0_EN;
282 }
283 kirin_apb_natural_phy_writel(phy, val, SUP_DIG_LVL_OVRD_IN);
284
285 val = kirin_apb_natural_phy_readl(phy, LANEN_DIG_ASIC_TX_OVRD_IN_1);
286 if (phy->eye_param[4] != EYEPARAM_NOCFG) {
287 val &= ~EYE_PARM4_MASK;
288 val |= FIELD_PREP(EYE_PARM4_MASK, phy->eye_param[4]);
289 val |= EYE_PARM4_EN;
290 }
291 kirin_apb_natural_phy_writel(phy, val, LANEN_DIG_ASIC_TX_OVRD_IN_1);
292 }
293
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 1 month