Re: [PATCH v2 18/20] platform/x86: intel-vbtn: Move to intel sub-directory
by kernel test robot
Hi Kate,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on next-20210816]
[cannot apply to linus/master v5.14-rc6 v5.14-rc5 v5.14-rc4 v5.14-rc6]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Kate-Hsuan/Intel-platform-driver...
base: b9011c7e671dbbf59bb753283ddfd03f0c9eb865
config: x86_64-randconfig-a003-20210816 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/e1413deafe75ca70b59d29f73b389fdc0...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Kate-Hsuan/Intel-platform-driver-code-movement/20210816-185713
git checkout e1413deafe75ca70b59d29f73b389fdc0249ce7b
# save the attached .config to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> drivers/platform/x86/intel/vbtn.c:17:10: fatal error: dual_accel_detect.h: No such file or directory
17 | #include "dual_accel_detect.h"
| ^~~~~~~~~~~~~~~~~~~~~
compilation terminated.
vim +17 drivers/platform/x86/intel/vbtn.c
153cca9caa81ca drivers/platform/x86/intel-vbtn.c Hans de Goede 2021-07-29 @17 #include "dual_accel_detect.h"
332e081225fc2a drivers/platform/x86/intel-vbtn.c AceLan Kao 2016-07-01 18
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 1 month
drivers/gpu/drm/i915/gt/selftest_execlists.c:167:4: error: format string is not a string literal (potentially insecure)
by kernel test robot
Hi Chris,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 7c60610d476766e128cc4284bb6349732cbd6606
commit: 70a2b431c36483c0c06e589e11c59e438cd0ac06 drm/i915/gt: Rename lrc.c to execlists_submission.c
date: 8 months ago
config: i386-randconfig-r024-20210816 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 44d0a99a12ec7ead4d2f5ef649ba05b40f6d463d)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit...
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 70a2b431c36483c0c06e589e11c59e438cd0ac06
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from drivers/gpu/drm/i915/gt/intel_execlists_submission.c:6116:
>> drivers/gpu/drm/i915/gt/selftest_execlists.c:167:4: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
GEM_TRACE("spinner failed to start\n");
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/i915_gem.h:69:24: note: expanded from macro 'GEM_TRACE'
#define GEM_TRACE(...) trace_printk(__VA_ARGS__)
^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/kernel.h:724:3: note: expanded from macro 'trace_printk'
do_trace_printk(fmt, ##__VA_ARGS__); \
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/kernel.h:738:30: note: expanded from macro 'do_trace_printk'
__trace_bprintk(_THIS_IP_, trace_printk_fmt, ##args); \
^~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/selftest_execlists.c:167:4: note: treat the string as an argument to avoid this
drivers/gpu/drm/i915/i915_gem.h:69:24: note: expanded from macro 'GEM_TRACE'
#define GEM_TRACE(...) trace_printk(__VA_ARGS__)
^
include/linux/kernel.h:724:3: note: expanded from macro 'trace_printk'
do_trace_printk(fmt, ##__VA_ARGS__); \
^
include/linux/kernel.h:738:30: note: expanded from macro 'do_trace_printk'
__trace_bprintk(_THIS_IP_, trace_printk_fmt, ##args); \
^
In file included from drivers/gpu/drm/i915/gt/intel_execlists_submission.c:6116:
drivers/gpu/drm/i915/gt/selftest_execlists.c:1790:4: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
GEM_TRACE("lo spinner failed to start\n");
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/i915_gem.h:69:24: note: expanded from macro 'GEM_TRACE'
#define GEM_TRACE(...) trace_printk(__VA_ARGS__)
^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/kernel.h:724:3: note: expanded from macro 'trace_printk'
do_trace_printk(fmt, ##__VA_ARGS__); \
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/kernel.h:738:30: note: expanded from macro 'do_trace_printk'
__trace_bprintk(_THIS_IP_, trace_printk_fmt, ##args); \
^~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/selftest_execlists.c:1790:4: note: treat the string as an argument to avoid this
drivers/gpu/drm/i915/i915_gem.h:69:24: note: expanded from macro 'GEM_TRACE'
#define GEM_TRACE(...) trace_printk(__VA_ARGS__)
^
include/linux/kernel.h:724:3: note: expanded from macro 'trace_printk'
do_trace_printk(fmt, ##__VA_ARGS__); \
^
include/linux/kernel.h:738:30: note: expanded from macro 'do_trace_printk'
__trace_bprintk(_THIS_IP_, trace_printk_fmt, ##args); \
^
In file included from drivers/gpu/drm/i915/gt/intel_execlists_submission.c:6116:
drivers/gpu/drm/i915/gt/selftest_execlists.c:1807:4: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
GEM_TRACE("hi spinner failed to start\n");
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/i915_gem.h:69:24: note: expanded from macro 'GEM_TRACE'
#define GEM_TRACE(...) trace_printk(__VA_ARGS__)
^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/kernel.h:724:3: note: expanded from macro 'trace_printk'
do_trace_printk(fmt, ##__VA_ARGS__); \
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/kernel.h:738:30: note: expanded from macro 'do_trace_printk'
__trace_bprintk(_THIS_IP_, trace_printk_fmt, ##args); \
^~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/selftest_execlists.c:1807:4: note: treat the string as an argument to avoid this
drivers/gpu/drm/i915/i915_gem.h:69:24: note: expanded from macro 'GEM_TRACE'
#define GEM_TRACE(...) trace_printk(__VA_ARGS__)
^
include/linux/kernel.h:724:3: note: expanded from macro 'trace_printk'
do_trace_printk(fmt, ##__VA_ARGS__); \
^
include/linux/kernel.h:738:30: note: expanded from macro 'do_trace_printk'
__trace_bprintk(_THIS_IP_, trace_printk_fmt, ##args); \
^
3 errors generated.
vim +167 drivers/gpu/drm/i915/gt/selftest_execlists.c
280e285dc78f73 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2020-02-27 134
2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 135 static int live_sanitycheck(void *arg)
2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 136 {
1357fa8136ea03 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-10-16 137 struct intel_gt *gt = arg;
e6ba76480299a0 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 138 struct intel_engine_cs *engine;
e6ba76480299a0 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 139 enum intel_engine_id id;
8d2f6e2f272109 drivers/gpu/drm/i915/selftests/intel_lrc.c Tvrtko Ursulin 2018-11-30 140 struct igt_spinner spin;
e6ba76480299a0 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 141 int err = 0;
2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 142
1357fa8136ea03 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-10-16 143 if (!HAS_LOGICAL_RING_CONTEXTS(gt->i915))
2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 144 return 0;
2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 145
1357fa8136ea03 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-10-16 146 if (igt_spinner_init(&spin, gt))
2af402982ab382 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-10-04 147 return -ENOMEM;
2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 148
e6ba76480299a0 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 149 for_each_engine(engine, gt, id) {
e6ba76480299a0 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 150 struct intel_context *ce;
2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 151 struct i915_request *rq;
2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 152
e6ba76480299a0 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 153 ce = intel_context_create(engine);
e6ba76480299a0 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 154 if (IS_ERR(ce)) {
e6ba76480299a0 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 155 err = PTR_ERR(ce);
e6ba76480299a0 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 156 break;
e6ba76480299a0 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 157 }
e6ba76480299a0 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 158
f277bc0c98a407 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-07-31 159 rq = igt_spinner_create_request(&spin, ce, MI_NOOP);
2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 160 if (IS_ERR(rq)) {
2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 161 err = PTR_ERR(rq);
e6ba76480299a0 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 162 goto out_ctx;
2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 163 }
2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 164
2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 165 i915_request_add(rq);
8d2f6e2f272109 drivers/gpu/drm/i915/selftests/intel_lrc.c Tvrtko Ursulin 2018-11-30 166 if (!igt_wait_for_spinner(&spin, rq)) {
2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 @167 GEM_TRACE("spinner failed to start\n");
2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 168 GEM_TRACE_DUMP();
1357fa8136ea03 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-10-16 169 intel_gt_set_wedged(gt);
2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 170 err = -EIO;
e6ba76480299a0 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 171 goto out_ctx;
2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 172 }
2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 173
8d2f6e2f272109 drivers/gpu/drm/i915/selftests/intel_lrc.c Tvrtko Ursulin 2018-11-30 174 igt_spinner_end(&spin);
1357fa8136ea03 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-10-16 175 if (igt_flush_test(gt->i915)) {
2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 176 err = -EIO;
e6ba76480299a0 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 177 goto out_ctx;
2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 178 }
e6ba76480299a0 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 179
e6ba76480299a0 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 180 out_ctx:
e6ba76480299a0 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 181 intel_context_put(ce);
e6ba76480299a0 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 182 if (err)
e6ba76480299a0 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 183 break;
2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 184 }
2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 185
8d2f6e2f272109 drivers/gpu/drm/i915/selftests/intel_lrc.c Tvrtko Ursulin 2018-11-30 186 igt_spinner_fini(&spin);
2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 187 return err;
2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 188 }
2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 189
:::::: The code at line 167 was first introduced by commit
:::::: 2c66555ec19235efd689741c44bbeb893aa8e7de drm/i915/selftests: Add basic sanitychecks for execlists
:::::: TO: Chris Wilson <chris(a)chris-wilson.co.uk>
:::::: CC: Chris Wilson <chris(a)chris-wilson.co.uk>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 1 month
[block:io_uring-fops.v6 58/64] io_uring.c:undefined reference to `__compiletime_assert_833'
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git io_uring-fops.v6
head: 4e0c34c9b129fe84c63d3f76053d2e55d944e8a9
commit: 834d3e42c71acf4653f840ac3998f8601f37021c [58/64] io_uring: add infrastructure around io_uring_cmd_sqe issue type
config: s390-randconfig-r033-20210813 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 62df4df41c939205b2dc0a2a3bfb75b8c1ed74fa)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install s390 cross compiling tool for clang build
# apt-get install binutils-s390x-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/com...
git remote add block https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git
git fetch --no-tags block io_uring-fops.v6
git checkout 834d3e42c71acf4653f840ac3998f8601f37021c
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross O=build_dir ARCH=s390 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
s390x-linux-gnu-ld: kernel/dma/coherent.o: in function `dma_declare_coherent_memory':
coherent.c:(.text+0xc4): undefined reference to `memunmap'
s390x-linux-gnu-ld: coherent.c:(.text+0x1c4): undefined reference to `memunmap'
s390x-linux-gnu-ld: kernel/dma/coherent.o: in function `dma_init_coherent_memory':
coherent.c:(.text+0x2b4): undefined reference to `memremap'
s390x-linux-gnu-ld: coherent.c:(.text+0x564): undefined reference to `memunmap'
s390x-linux-gnu-ld: fs/io_uring.o: in function `io_uring_init':
>> io_uring.c:(.init.text+0x30): undefined reference to `__compiletime_assert_833'
>> s390x-linux-gnu-ld: io_uring.c:(.init.text+0x4a): undefined reference to `__compiletime_assert_835'
s390x-linux-gnu-ld: drivers/dma/fsl-edma.o: in function `fsl_edma_probe':
fsl-edma.c:(.text+0x1bc): undefined reference to `devm_ioremap_resource'
s390x-linux-gnu-ld: fsl-edma.c:(.text+0x40a): undefined reference to `devm_ioremap_resource'
s390x-linux-gnu-ld: drivers/dma/idma64.o: in function `idma64_platform_probe':
idma64.c:(.text+0xc6): undefined reference to `devm_ioremap_resource'
s390x-linux-gnu-ld: drivers/char/xillybus/xillybus_of.o: in function `xilly_drv_probe':
xillybus_of.c:(.text+0xc4): undefined reference to `devm_platform_ioremap_resource'
s390x-linux-gnu-ld: drivers/pcmcia/cistpl.o: in function `release_cis_mem':
cistpl.c:(.text+0x1d6): undefined reference to `iounmap'
s390x-linux-gnu-ld: drivers/pcmcia/cistpl.o: in function `set_cis_map':
cistpl.c:(.text+0xb10): undefined reference to `ioremap'
s390x-linux-gnu-ld: cistpl.c:(.text+0xbbe): undefined reference to `iounmap'
s390x-linux-gnu-ld: cistpl.c:(.text+0xf4e): undefined reference to `iounmap'
s390x-linux-gnu-ld: cistpl.c:(.text+0xf8c): undefined reference to `ioremap'
s390x-linux-gnu-ld: drivers/clocksource/timer-of.o: in function `timer_of_base_init':
timer-of.c:(.init.text+0x576): undefined reference to `of_iomap'
s390x-linux-gnu-ld: drivers/clocksource/timer-of.o: in function `timer_of_base_exit':
timer-of.c:(.init.text+0x17ba): undefined reference to `iounmap'
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 1 month
[iommu:apple/dart 3/3] drivers/iommu/apple-dart.c:730:17: error: initialization of 'size_t (*)(struct iommu_domain *, long unsigned int, size_t, struct iommu_iotlb_gather *)' {aka 'long unsigned int (*)(struct iommu_domain *, long unsigned int, long unsigned int, struct iom...
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git apple/dart
head: 05ce9d20d699b093dec985192a7db63b48f26ca2
commit: 05ce9d20d699b093dec985192a7db63b48f26ca2 [3/3] iommu/dart: Add DART iommu driver
config: sparc-allyesconfig (attached as .config)
compiler: sparc64-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git/commit/?id...
git remote add iommu https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git
git fetch --no-tags iommu apple/dart
git checkout 05ce9d20d699b093dec985192a7db63b48f26ca2
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=sparc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
drivers/iommu/apple-dart.c: In function 'apple_dart_map_pages':
drivers/iommu/apple-dart.c:380:12: error: 'struct io_pgtable_ops' has no member named 'map_pages'
380 | return ops->map_pages(ops, iova, paddr, pgsize, pgcount, prot, gfp,
| ^~
drivers/iommu/apple-dart.c: In function 'apple_dart_unmap_pages':
drivers/iommu/apple-dart.c:392:12: error: 'struct io_pgtable_ops' has no member named 'unmap_pages'
392 | return ops->unmap_pages(ops, iova, pgsize, pgcount, gather);
| ^~
drivers/iommu/apple-dart.c: At top level:
drivers/iommu/apple-dart.c:729:3: error: 'const struct iommu_ops' has no member named 'map_pages'
729 | .map_pages = apple_dart_map_pages,
| ^~~~~~~~~
drivers/iommu/apple-dart.c:729:15: error: initialization of 'int (*)(struct iommu_domain *, long unsigned int, phys_addr_t, size_t, int, gfp_t)' {aka 'int (*)(struct iommu_domain *, long unsigned int, long long unsigned int, long unsigned int, int, unsigned int)'} from incompatible pointer type 'int (*)(struct iommu_domain *, long unsigned int, phys_addr_t, size_t, size_t, int, gfp_t, size_t *)' {aka 'int (*)(struct iommu_domain *, long unsigned int, long long unsigned int, long unsigned int, long unsigned int, int, unsigned int, long unsigned int *)'} [-Werror=incompatible-pointer-types]
729 | .map_pages = apple_dart_map_pages,
| ^~~~~~~~~~~~~~~~~~~~
drivers/iommu/apple-dart.c:729:15: note: (near initialization for 'apple_dart_iommu_ops.map')
drivers/iommu/apple-dart.c:730:3: error: 'const struct iommu_ops' has no member named 'unmap_pages'
730 | .unmap_pages = apple_dart_unmap_pages,
| ^~~~~~~~~~~
>> drivers/iommu/apple-dart.c:730:17: error: initialization of 'size_t (*)(struct iommu_domain *, long unsigned int, size_t, struct iommu_iotlb_gather *)' {aka 'long unsigned int (*)(struct iommu_domain *, long unsigned int, long unsigned int, struct iommu_iotlb_gather *)'} from incompatible pointer type 'size_t (*)(struct iommu_domain *, long unsigned int, size_t, size_t, struct iommu_iotlb_gather *)' {aka 'long unsigned int (*)(struct iommu_domain *, long unsigned int, long unsigned int, long unsigned int, struct iommu_iotlb_gather *)'} [-Werror=incompatible-pointer-types]
730 | .unmap_pages = apple_dart_unmap_pages,
| ^~~~~~~~~~~~~~~~~~~~~~
drivers/iommu/apple-dart.c:730:17: note: (near initialization for 'apple_dart_iommu_ops.unmap')
drivers/iommu/apple-dart.c: In function 'apple_dart_unmap_pages':
drivers/iommu/apple-dart.c:393:1: error: control reaches end of non-void function [-Werror=return-type]
393 | }
| ^
drivers/iommu/apple-dart.c: In function 'apple_dart_map_pages':
drivers/iommu/apple-dart.c:382:1: error: control reaches end of non-void function [-Werror=return-type]
382 | }
| ^
cc1: some warnings being treated as errors
vim +730 drivers/iommu/apple-dart.c
723
724 static const struct iommu_ops apple_dart_iommu_ops = {
725 .domain_alloc = apple_dart_domain_alloc,
726 .domain_free = apple_dart_domain_free,
727 .attach_dev = apple_dart_attach_dev,
728 .detach_dev = apple_dart_detach_dev,
> 729 .map_pages = apple_dart_map_pages,
> 730 .unmap_pages = apple_dart_unmap_pages,
731 .flush_iotlb_all = apple_dart_flush_iotlb_all,
732 .iotlb_sync = apple_dart_iotlb_sync,
733 .iotlb_sync_map = apple_dart_iotlb_sync_map,
734 .iova_to_phys = apple_dart_iova_to_phys,
735 .probe_device = apple_dart_probe_device,
736 .release_device = apple_dart_release_device,
737 .device_group = apple_dart_device_group,
738 .of_xlate = apple_dart_of_xlate,
739 .def_domain_type = apple_dart_def_domain_type,
740 .pgsize_bitmap = -1UL, /* Restricted during dart probe */
741 };
742
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 1 month
Re: [PATCH] ksmbd: fix lookup on idmapped mounts
by kernel test robot
Hi Christian,
I love your patch! Perhaps something to improve:
[auto build test WARNING on 456af438ad490bac7ed954cb929bcec1df7f0c82]
url: https://github.com/0day-ci/linux/commits/Christian-Brauner/ksmbd-fix-look...
base: 456af438ad490bac7ed954cb929bcec1df7f0c82
config: s390-allyesconfig (attached as .config)
compiler: s390-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/ebbc41b9d3f7b7f6c558cb5d5f12ecb81...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Christian-Brauner/ksmbd-fix-lookup-on-idmapped-mounts/20210816-200054
git checkout ebbc41b9d3f7b7f6c558cb5d5f12ecb8134c9c2e
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=s390
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
fs/ksmbd/vfs.c: In function 'ksmbd_vfs_lock_parent':
fs/ksmbd/vfs.c:79:18: error: implicit declaration of function 'lookup_one'; did you mean 'lookup_bdev'? [-Werror=implicit-function-declaration]
79 | dentry = lookup_one(user_ns, child->d_name.name, parent,
| ^~~~~~~~~~
| lookup_bdev
>> fs/ksmbd/vfs.c:79:16: warning: assignment to 'struct dentry *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
79 | dentry = lookup_one(user_ns, child->d_name.name, parent,
| ^
fs/ksmbd/vfs.c: In function 'ksmbd_vfs_mkdir':
fs/ksmbd/vfs.c:223:19: warning: assignment to 'struct dentry *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
223 | d = lookup_one(user_ns, dentry->d_name.name, dentry->d_parent,
| ^
fs/ksmbd/vfs.c: In function '__ksmbd_vfs_rename':
fs/ksmbd/vfs.c:753:18: warning: assignment to 'struct dentry *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
753 | dst_dent = lookup_one(dst_user_ns, dst_name, dst_dent_parent,
| ^
fs/ksmbd/vfs.c: In function 'ksmbd_vfs_fp_rename':
fs/ksmbd/vfs.c:816:19: warning: assignment to 'struct dentry *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
816 | src_child = lookup_one(user_ns, src_dent->d_name.name, src_dent_parent,
| ^
cc1: some warnings being treated as errors
--
fs/ksmbd/smb2pdu.c: In function 'process_query_dir_entries':
fs/ksmbd/smb2pdu.c:3542:24: error: implicit declaration of function 'lookup_one'; did you mean 'lookup_bdev'? [-Werror=implicit-function-declaration]
3542 | dent = lookup_one(user_ns, priv->d_info->name,
| ^~~~~~~~~~
| lookup_bdev
>> fs/ksmbd/smb2pdu.c:3542:22: warning: assignment to 'struct dentry *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
3542 | dent = lookup_one(user_ns, priv->d_info->name,
| ^
cc1: some warnings being treated as errors
vim +79 fs/ksmbd/vfs.c
62
63 /**
64 * ksmbd_vfs_lock_parent() - lock parent dentry if it is stable
65 *
66 * the parent dentry got by dget_parent or @parent could be
67 * unstable, we try to lock a parent inode and lookup the
68 * child dentry again.
69 *
70 * the reference count of @parent isn't incremented.
71 */
72 int ksmbd_vfs_lock_parent(struct user_namespace *user_ns, struct dentry *parent,
73 struct dentry *child)
74 {
75 struct dentry *dentry;
76 int ret = 0;
77
78 inode_lock_nested(d_inode(parent), I_MUTEX_PARENT);
> 79 dentry = lookup_one(user_ns, child->d_name.name, parent,
80 child->d_name.len);
81 if (IS_ERR(dentry)) {
82 ret = PTR_ERR(dentry);
83 goto out_err;
84 }
85
86 if (dentry != child) {
87 ret = -ESTALE;
88 dput(dentry);
89 goto out_err;
90 }
91
92 dput(dentry);
93 return 0;
94 out_err:
95 inode_unlock(d_inode(parent));
96 return ret;
97 }
98
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 1 month
[linux-next:master 7766/8423] clang-14: error: unsupported option '-mfentry' for target 's390-unknown-linux'
by kernel test robot
CC: Linux Memory Management List <linux-mm(a)kvack.org>
TO: Nick Desaulniers <ndesaulniers(a)google.com>
CC: Nathan Chancellor <nathan(a)kernel.org>
CC: Andrew Morton <akpm(a)linux-foundation.org>
CC: Linux Memory Management List <linux-mm(a)kvack.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: b9011c7e671dbbf59bb753283ddfd03f0c9eb865
commit: 9b9a2f6284409ce3171fd72c288cc0e82bb34c6f [7766/8423] Makefile: remove stale cc-option checks
config: s390-randconfig-r011-20210816 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 44d0a99a12ec7ead4d2f5ef649ba05b40f6d463d)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install s390 cross compiling tool for clang build
# apt-get install binutils-s390x-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commi...
git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git fetch --no-tags linux-next master
git checkout 9b9a2f6284409ce3171fd72c288cc0e82bb34c6f
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross O=build_dir ARCH=s390 prepare
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> clang-14: error: unsupported option '-mfentry' for target 's390-unknown-linux'
--
>> clang-14: error: unsupported option '-mfentry' for target 's390-unknown-linux'
>> clang-14: error: unsupported option '-mfentry' for target 's390-unknown-linux'
make[2]: *** [scripts/Makefile.build:271: scripts/mod/empty.o] Error 1
make[2]: *** [scripts/Makefile.build:117: scripts/mod/devicetable-offsets.s] Error 1
make[2]: Target '__build' not remade because of errors.
make[1]: *** [Makefile:1218: prepare0] Error 2
make[1]: Target 'modules_prepare' not remade because of errors.
make: *** [Makefile:220: __sub-make] Error 2
make: Target 'modules_prepare' not remade because of errors.
--
>> clang-14: error: unsupported option '-mfentry' for target 's390-unknown-linux'
make[2]: *** [scripts/Makefile.build:271: scripts/mod/empty.o] Error 1
>> clang-14: error: unsupported option '-mfentry' for target 's390-unknown-linux'
make[2]: *** [scripts/Makefile.build:117: scripts/mod/devicetable-offsets.s] Error 1
make[2]: Target '__build' not remade because of errors.
make[1]: *** [Makefile:1218: prepare0] Error 2
make[1]: Target 'prepare' not remade because of errors.
make: *** [Makefile:220: __sub-make] Error 2
make: Target 'prepare' not remade because of errors.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 1 month
drivers/net/dsa/ocelot/felix.c:1329 felix_check_xtr_pkt() error: uninitialized symbol 'err'.
by Dan Carpenter
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 7c60610d476766e128cc4284bb6349732cbd6606
commit: 0a6f17c6ae2116809a7b7eb6dd3eab59ef5460ef net: dsa: tag_ocelot_8021q: add support for PTP timestamping
config: ia64-randconfig-m031-20210816 (attached as .config)
compiler: ia64-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
smatch warnings:
drivers/net/dsa/ocelot/felix.c:1329 felix_check_xtr_pkt() error: uninitialized symbol 'err'.
vim +/err +1329 drivers/net/dsa/ocelot/felix.c
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1286 static bool felix_check_xtr_pkt(struct ocelot *ocelot, unsigned int ptp_type)
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1287 {
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1288 struct felix *felix = ocelot_to_felix(ocelot);
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1289 int err, grp = 0;
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1290
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1291 if (felix->tag_proto != DSA_TAG_PROTO_OCELOT_8021Q)
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1292 return false;
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1293
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1294 if (!felix->info->quirk_no_xtr_irq)
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1295 return false;
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1296
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1297 if (ptp_type == PTP_CLASS_NONE)
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1298 return false;
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1299
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1300 while (ocelot_read(ocelot, QS_XTR_DATA_PRESENT) & BIT(grp)) {
Smatch is complaining that this condition could be false on the first
iteration through the loop.
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1301 struct sk_buff *skb;
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1302 unsigned int type;
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1303
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1304 err = ocelot_xtr_poll_frame(ocelot, grp, &skb);
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1305 if (err)
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1306 goto out;
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1307
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1308 /* We trap to the CPU port module all PTP frames, but
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1309 * felix_rxtstamp() only gets called for event frames.
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1310 * So we need to avoid sending duplicate general
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1311 * message frames by running a second BPF classifier
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1312 * here and dropping those.
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1313 */
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1314 __skb_push(skb, ETH_HLEN);
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1315
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1316 type = ptp_classify_raw(skb);
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1317
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1318 __skb_pull(skb, ETH_HLEN);
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1319
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1320 if (type == PTP_CLASS_NONE) {
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1321 kfree_skb(skb);
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1322 continue;
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1323 }
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1324
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1325 netif_rx(skb);
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1326 }
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1327
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1328 out:
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 @1329 if (err < 0)
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1330 ocelot_drain_cpu_queue(ocelot, 0);
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1331
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1332 return true;
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1333 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 1 month
[sashal-linux-stable:linux-4.19.y 89/127] lib/rhashtable.c:302:13: sparse: sparse: cast removes address space '<asn:4>' of expression
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git linux-4.19.y
head: 399849e4654ea496a6217ba4e5ee3d304c995ab4
commit: a24f9d6cf9bd65c1305344134e0182ed7bef76c8 [89/127] riscv/atomic: Fix sign extension for RV64I
config: riscv-randconfig-s031-20210816 (attached as .config)
compiler: riscv32-linux-gcc (GCC) 11.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.3-348-gf0e6938b-dirty
# https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git/c...
git remote add sashal-linux-stable https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git
git fetch --no-tags sashal-linux-stable linux-4.19.y
git checkout a24f9d6cf9bd65c1305344134e0182ed7bef76c8
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=riscv SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
lib/rhashtable.c:302:13: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected struct bucket_table [noderef] <asn:4> *_n_ @@ got struct bucket_table *new_tbl @@
lib/rhashtable.c:302:13: sparse: expected struct bucket_table [noderef] <asn:4> *_n_
lib/rhashtable.c:302:13: sparse: got struct bucket_table *new_tbl
>> lib/rhashtable.c:302:13: sparse: sparse: cast removes address space '<asn:4>' of expression
vim +302 lib/rhashtable.c
97defe1ecf868b Thomas Graf 2015-01-02 291
b824478b2145be Herbert Xu 2015-03-24 292 static int rhashtable_rehash_attach(struct rhashtable *ht,
b824478b2145be Herbert Xu 2015-03-24 293 struct bucket_table *old_tbl,
aa34a6cb047884 Herbert Xu 2015-03-11 294 struct bucket_table *new_tbl)
97defe1ecf868b Thomas Graf 2015-01-02 295 {
aa34a6cb047884 Herbert Xu 2015-03-11 296 /* Make insertions go into the new, empty table right away. Deletions
aa34a6cb047884 Herbert Xu 2015-03-11 297 * and lookups will be attempted in both tables until we synchronize.
0ad66449aa3cba NeilBrown 2018-06-18 298 * As cmpxchg() provides strong barriers, we do not need
0ad66449aa3cba NeilBrown 2018-06-18 299 * rcu_assign_pointer().
aa34a6cb047884 Herbert Xu 2015-03-11 300 */
aa34a6cb047884 Herbert Xu 2015-03-11 301
0ad66449aa3cba NeilBrown 2018-06-18 @302 if (cmpxchg(&old_tbl->future_tbl, NULL, new_tbl) != NULL)
0ad66449aa3cba NeilBrown 2018-06-18 303 return -EEXIST;
b824478b2145be Herbert Xu 2015-03-24 304
b824478b2145be Herbert Xu 2015-03-24 305 return 0;
b824478b2145be Herbert Xu 2015-03-24 306 }
b824478b2145be Herbert Xu 2015-03-24 307
:::::: The code at line 302 was first introduced by commit
:::::: 0ad66449aa3cbaedbdeaf55bffce74084bb7e9f9 rhashtable: use cmpxchg() to protect ->future_tbl.
:::::: TO: NeilBrown <neilb(a)suse.com>
:::::: CC: David S. Miller <davem(a)davemloft.net>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 1 month