[xilinx-xlnx:xlnx_rebase_v5.10 223/1964] drivers/media/i2c/adv7511-v4l2.c:2251:21: warning: no previous prototype for 'adv7511_subdev'
by kernel test robot
tree: https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.10
head: 0a6e9d56f285540e5ca6c69c7fad2c3520b79c50
commit: c879ca1c486ba6c809ca48c82c0c8a289d97ce15 [223/1964] drivers: media: Customized adv7511 for Xylon LogiCVC (deprecated)
config: openrisc-randconfig-r023-20210930 (attached as .config)
compiler: or1k-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/Xilinx/linux-xlnx/commit/c879ca1c486ba6c809ca48c82c0c8...
git remote add xilinx-xlnx https://github.com/Xilinx/linux-xlnx
git fetch --no-tags xilinx-xlnx xlnx_rebase_v5.10
git checkout c879ca1c486ba6c809ca48c82c0c8a289d97ce15
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=openrisc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
drivers/media/i2c/adv7511-v4l2.c: In function 'adv7511_set_rgb_quantization_mode':
drivers/media/i2c/adv7511-v4l2.c:427:16: error: 'return' with a value, in function returning void [-Werror=return-type]
427 | return 0;
| ^
drivers/media/i2c/adv7511-v4l2.c:422:13: note: declared here
422 | static void adv7511_set_rgb_quantization_mode(struct v4l2_subdev *sd, struct v4l2_ctrl *ctrl)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/media/i2c/adv7511-v4l2.c: At top level:
>> drivers/media/i2c/adv7511-v4l2.c:2251:21: warning: no previous prototype for 'adv7511_subdev' [-Wmissing-prototypes]
2251 | struct v4l2_subdev *adv7511_subdev(struct v4l2_subdev *sd)
| ^~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/adv7511_subdev +2251 drivers/media/i2c/adv7511-v4l2.c
2250
> 2251 struct v4l2_subdev *adv7511_subdev(struct v4l2_subdev *sd)
2252 {
2253 static struct v4l2_subdev *subdev;
2254
2255 if (sd)
2256 subdev = sd;
2257
2258 return subdev;
2259 }
2260 EXPORT_SYMBOL(adv7511_subdev);
2261
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 months
[gustavoars:for-next/cast-function 1/1] kernel/bpf/verifier.c:12470:16: warning: cast from 'unsigned int (*)(const void *, const struct bpf_insn *)' to 'u64 (*)(u64, u64, u64, u64, u64)' (aka 'unsigned long long (*)(unsigned long long, unsigned long long, unsigned long long, unsigned long long,...
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git for-next/cast-function
head: ffea83dd8823401f3922276d36aca35c3e99d7f3
commit: ffea83dd8823401f3922276d36aca35c3e99d7f3 [1/1] Makefile: Enable -Wcast-function-type
config: i386-randconfig-r016-20210930 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 28981015526f2192440c18f18e8a20cd11b0779c)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git/comm...
git remote add gustavoars https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git
git fetch --no-tags gustavoars for-next/cast-function
git checkout ffea83dd8823401f3922276d36aca35c3e99d7f3
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> kernel/bpf/verifier.c:12470:16: warning: cast from 'unsigned int (*)(const void *, const struct bpf_insn *)' to 'u64 (*)(u64, u64, u64, u64, u64)' (aka 'unsigned long long (*)(unsigned long long, unsigned long long, unsigned long long, unsigned long long, unsigned long long)') converts to incompatible function type [-Wcast-function-type]
insn->imm = BPF_CAST_CALL(func[subprog]->bpf_func) -
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/filter.h:366:4: note: expanded from macro 'BPF_CAST_CALL'
((u64 (*)(u64, u64, u64, u64, u64))(x))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> kernel/bpf/verifier.c:12951:17: warning: cast from 'void *(*)(struct bpf_map *, void *)' to 'u64 (*)(u64, u64, u64, u64, u64)' (aka 'unsigned long long (*)(unsigned long long, unsigned long long, unsigned long long, unsigned long long, unsigned long long)') converts to incompatible function type [-Wcast-function-type]
insn->imm = BPF_CAST_CALL(ops->map_lookup_elem) -
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/filter.h:366:4: note: expanded from macro 'BPF_CAST_CALL'
((u64 (*)(u64, u64, u64, u64, u64))(x))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> kernel/bpf/verifier.c:12955:17: warning: cast from 'int (*)(struct bpf_map *, void *, void *, u64)' (aka 'int (*)(struct bpf_map *, void *, void *, unsigned long long)') to 'u64 (*)(u64, u64, u64, u64, u64)' (aka 'unsigned long long (*)(unsigned long long, unsigned long long, unsigned long long, unsigned long long, unsigned long long)') converts to incompatible function type [-Wcast-function-type]
insn->imm = BPF_CAST_CALL(ops->map_update_elem) -
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/filter.h:366:4: note: expanded from macro 'BPF_CAST_CALL'
((u64 (*)(u64, u64, u64, u64, u64))(x))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> kernel/bpf/verifier.c:12959:17: warning: cast from 'int (*)(struct bpf_map *, void *)' to 'u64 (*)(u64, u64, u64, u64, u64)' (aka 'unsigned long long (*)(unsigned long long, unsigned long long, unsigned long long, unsigned long long, unsigned long long)') converts to incompatible function type [-Wcast-function-type]
insn->imm = BPF_CAST_CALL(ops->map_delete_elem) -
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/filter.h:366:4: note: expanded from macro 'BPF_CAST_CALL'
((u64 (*)(u64, u64, u64, u64, u64))(x))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> kernel/bpf/verifier.c:12963:17: warning: cast from 'int (*)(struct bpf_map *, void *, u64)' (aka 'int (*)(struct bpf_map *, void *, unsigned long long)') to 'u64 (*)(u64, u64, u64, u64, u64)' (aka 'unsigned long long (*)(unsigned long long, unsigned long long, unsigned long long, unsigned long long, unsigned long long)') converts to incompatible function type [-Wcast-function-type]
insn->imm = BPF_CAST_CALL(ops->map_push_elem) -
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/filter.h:366:4: note: expanded from macro 'BPF_CAST_CALL'
((u64 (*)(u64, u64, u64, u64, u64))(x))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/bpf/verifier.c:12967:17: warning: cast from 'int (*)(struct bpf_map *, void *)' to 'u64 (*)(u64, u64, u64, u64, u64)' (aka 'unsigned long long (*)(unsigned long long, unsigned long long, unsigned long long, unsigned long long, unsigned long long)') converts to incompatible function type [-Wcast-function-type]
insn->imm = BPF_CAST_CALL(ops->map_pop_elem) -
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/filter.h:366:4: note: expanded from macro 'BPF_CAST_CALL'
((u64 (*)(u64, u64, u64, u64, u64))(x))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/bpf/verifier.c:12971:17: warning: cast from 'int (*)(struct bpf_map *, void *)' to 'u64 (*)(u64, u64, u64, u64, u64)' (aka 'unsigned long long (*)(unsigned long long, unsigned long long, unsigned long long, unsigned long long, unsigned long long)') converts to incompatible function type [-Wcast-function-type]
insn->imm = BPF_CAST_CALL(ops->map_peek_elem) -
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/filter.h:366:4: note: expanded from macro 'BPF_CAST_CALL'
((u64 (*)(u64, u64, u64, u64, u64))(x))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> kernel/bpf/verifier.c:12975:17: warning: cast from 'int (*)(struct bpf_map *, u32, u64)' (aka 'int (*)(struct bpf_map *, unsigned int, unsigned long long)') to 'u64 (*)(u64, u64, u64, u64, u64)' (aka 'unsigned long long (*)(unsigned long long, unsigned long long, unsigned long long, unsigned long long, unsigned long long)') converts to incompatible function type [-Wcast-function-type]
insn->imm = BPF_CAST_CALL(ops->map_redirect) -
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/filter.h:366:4: note: expanded from macro 'BPF_CAST_CALL'
((u64 (*)(u64, u64, u64, u64, u64))(x))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
8 warnings generated.
--
>> kernel/bpf/hashtab.c:671:26: warning: cast from 'void *(*)(struct bpf_map *, void *)' to 'u64 (*)(u64, u64, u64, u64, u64)' (aka 'unsigned long long (*)(unsigned long long, unsigned long long, unsigned long long, unsigned long long, unsigned long long)') converts to incompatible function type [-Wcast-function-type]
*insn++ = BPF_EMIT_CALL(BPF_CAST_CALL(__htab_map_lookup_elem));
~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/filter.h:366:4: note: expanded from macro 'BPF_CAST_CALL'
((u64 (*)(u64, u64, u64, u64, u64))(x))
^
include/linux/filter.h:374:14: note: expanded from macro 'BPF_EMIT_CALL'
.imm = ((FUNC) - __bpf_call_base) })
^~~~
kernel/bpf/hashtab.c:712:26: warning: cast from 'void *(*)(struct bpf_map *, void *)' to 'u64 (*)(u64, u64, u64, u64, u64)' (aka 'unsigned long long (*)(unsigned long long, unsigned long long, unsigned long long, unsigned long long, unsigned long long)') converts to incompatible function type [-Wcast-function-type]
*insn++ = BPF_EMIT_CALL(BPF_CAST_CALL(__htab_map_lookup_elem));
~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/filter.h:366:4: note: expanded from macro 'BPF_CAST_CALL'
((u64 (*)(u64, u64, u64, u64, u64))(x))
^
include/linux/filter.h:374:14: note: expanded from macro 'BPF_EMIT_CALL'
.imm = ((FUNC) - __bpf_call_base) })
^~~~
kernel/bpf/hashtab.c:2400:26: warning: cast from 'void *(*)(struct bpf_map *, void *)' to 'u64 (*)(u64, u64, u64, u64, u64)' (aka 'unsigned long long (*)(unsigned long long, unsigned long long, unsigned long long, unsigned long long, unsigned long long)') converts to incompatible function type [-Wcast-function-type]
*insn++ = BPF_EMIT_CALL(BPF_CAST_CALL(__htab_map_lookup_elem));
~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/filter.h:366:4: note: expanded from macro 'BPF_CAST_CALL'
((u64 (*)(u64, u64, u64, u64, u64))(x))
^
include/linux/filter.h:374:14: note: expanded from macro 'BPF_EMIT_CALL'
.imm = ((FUNC) - __bpf_call_base) })
^~~~
3 warnings generated.
--
>> drivers/firewire/core-cdev.c:985:8: warning: cast from 'void (*)(struct fw_iso_context *, dma_addr_t, void *)' (aka 'void (*)(struct fw_iso_context *, unsigned int, void *)') to 'fw_iso_callback_t' (aka 'void (*)(struct fw_iso_context *, unsigned int, unsigned int, void *, void *)') converts to incompatible function type [-Wcast-function-type]
cb = (fw_iso_callback_t)iso_mc_callback;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
vim +12470 kernel/bpf/verifier.c
9bac3d6d548e5c Alexei Starovoitov 2015-03-13 12337
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12338 static int jit_subprogs(struct bpf_verifier_env *env)
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12339 {
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12340 struct bpf_prog *prog = env->prog, **func, *tmp;
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12341 int i, j, subprog_start, subprog_end = 0, len, subprog;
a748c6975dea32 Maciej Fijalkowski 2020-09-16 12342 struct bpf_map *map_ptr;
7105e828c087de Daniel Borkmann 2017-12-20 12343 struct bpf_insn *insn;
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12344 void *old_bpf_func;
c4c0bdc0d2d084 Yonghong Song 2020-06-23 12345 int err, num_exentries;
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12346
f910cefa32b6cd Jiong Wang 2018-05-02 12347 if (env->subprog_cnt <= 1)
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12348 return 0;
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12349
7105e828c087de Daniel Borkmann 2017-12-20 12350 for (i = 0, insn = prog->insnsi; i < prog->len; i++, insn++) {
69c087ba6225b5 Yonghong Song 2021-02-26 12351 if (bpf_pseudo_func(insn)) {
69c087ba6225b5 Yonghong Song 2021-02-26 12352 env->insn_aux_data[i].call_imm = insn->imm;
69c087ba6225b5 Yonghong Song 2021-02-26 12353 /* subprog is encoded in insn[1].imm */
69c087ba6225b5 Yonghong Song 2021-02-26 12354 continue;
69c087ba6225b5 Yonghong Song 2021-02-26 12355 }
69c087ba6225b5 Yonghong Song 2021-02-26 12356
23a2d70c7a2f28 Yonghong Song 2021-02-04 12357 if (!bpf_pseudo_call(insn))
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12358 continue;
c7a897843224a9 Daniel Borkmann 2018-07-12 12359 /* Upon error here we cannot fall back to interpreter but
c7a897843224a9 Daniel Borkmann 2018-07-12 12360 * need a hard reject of the program. Thus -EFAULT is
c7a897843224a9 Daniel Borkmann 2018-07-12 12361 * propagated in any case.
c7a897843224a9 Daniel Borkmann 2018-07-12 12362 */
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12363 subprog = find_subprog(env, i + insn->imm + 1);
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12364 if (subprog < 0) {
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12365 WARN_ONCE(1, "verifier bug. No program starts at insn %d\n",
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12366 i + insn->imm + 1);
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12367 return -EFAULT;
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12368 }
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12369 /* temporarily remember subprog id inside insn instead of
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12370 * aux_data, since next loop will split up all insns into funcs
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12371 */
f910cefa32b6cd Jiong Wang 2018-05-02 12372 insn->off = subprog;
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12373 /* remember original imm in case JIT fails and fallback
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12374 * to interpreter will be needed
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12375 */
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12376 env->insn_aux_data[i].call_imm = insn->imm;
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12377 /* point imm to __bpf_call_base+1 from JITs point of view */
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12378 insn->imm = 1;
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12379 }
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12380
c454a46b5efd8e Martin KaFai Lau 2018-12-07 12381 err = bpf_prog_alloc_jited_linfo(prog);
c454a46b5efd8e Martin KaFai Lau 2018-12-07 12382 if (err)
c454a46b5efd8e Martin KaFai Lau 2018-12-07 12383 goto out_undo_insn;
c454a46b5efd8e Martin KaFai Lau 2018-12-07 12384
c454a46b5efd8e Martin KaFai Lau 2018-12-07 12385 err = -ENOMEM;
6396bb221514d2 Kees Cook 2018-06-12 12386 func = kcalloc(env->subprog_cnt, sizeof(prog), GFP_KERNEL);
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12387 if (!func)
c7a897843224a9 Daniel Borkmann 2018-07-12 12388 goto out_undo_insn;
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12389
f910cefa32b6cd Jiong Wang 2018-05-02 12390 for (i = 0; i < env->subprog_cnt; i++) {
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12391 subprog_start = subprog_end;
9c8105bd440223 Jiong Wang 2018-05-02 12392 subprog_end = env->subprog_info[i + 1].start;
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12393
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12394 len = subprog_end - subprog_start;
fb7dd8bca0139f Andrii Nakryiko 2021-08-15 12395 /* bpf_prog_run() doesn't call subprogs directly,
492ecee892c2a4 Alexei Starovoitov 2019-02-25 12396 * hence main prog stats include the runtime of subprogs.
492ecee892c2a4 Alexei Starovoitov 2019-02-25 12397 * subprogs don't have IDs and not reachable via prog_get_next_id
700d4796ef59f5 Alexei Starovoitov 2021-02-09 12398 * func[i]->stats will never be accessed and stays NULL
492ecee892c2a4 Alexei Starovoitov 2019-02-25 12399 */
492ecee892c2a4 Alexei Starovoitov 2019-02-25 12400 func[i] = bpf_prog_alloc_no_stats(bpf_prog_size(len), GFP_USER);
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12401 if (!func[i])
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12402 goto out_free;
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12403 memcpy(func[i]->insnsi, &prog->insnsi[subprog_start],
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12404 len * sizeof(struct bpf_insn));
4f74d80971bce9 Daniel Borkmann 2017-12-20 12405 func[i]->type = prog->type;
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12406 func[i]->len = len;
4f74d80971bce9 Daniel Borkmann 2017-12-20 12407 if (bpf_prog_calc_tag(func[i]))
4f74d80971bce9 Daniel Borkmann 2017-12-20 12408 goto out_free;
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12409 func[i]->is_func = 1;
ba64e7d8525236 Yonghong Song 2018-11-24 12410 func[i]->aux->func_idx = i;
f263a81451c12d John Fastabend 2021-07-07 12411 /* Below members will be freed only at prog->aux */
ba64e7d8525236 Yonghong Song 2018-11-24 12412 func[i]->aux->btf = prog->aux->btf;
ba64e7d8525236 Yonghong Song 2018-11-24 12413 func[i]->aux->func_info = prog->aux->func_info;
f263a81451c12d John Fastabend 2021-07-07 12414 func[i]->aux->poke_tab = prog->aux->poke_tab;
f263a81451c12d John Fastabend 2021-07-07 12415 func[i]->aux->size_poke_tab = prog->aux->size_poke_tab;
ba64e7d8525236 Yonghong Song 2018-11-24 12416
a748c6975dea32 Maciej Fijalkowski 2020-09-16 12417 for (j = 0; j < prog->aux->size_poke_tab; j++) {
f263a81451c12d John Fastabend 2021-07-07 12418 struct bpf_jit_poke_descriptor *poke;
a748c6975dea32 Maciej Fijalkowski 2020-09-16 12419
f263a81451c12d John Fastabend 2021-07-07 12420 poke = &prog->aux->poke_tab[j];
f263a81451c12d John Fastabend 2021-07-07 12421 if (poke->insn_idx < subprog_end &&
f263a81451c12d John Fastabend 2021-07-07 12422 poke->insn_idx >= subprog_start)
f263a81451c12d John Fastabend 2021-07-07 12423 poke->aux = func[i]->aux;
a748c6975dea32 Maciej Fijalkowski 2020-09-16 12424 }
a748c6975dea32 Maciej Fijalkowski 2020-09-16 12425
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12426 /* Use bpf_prog_F_tag to indicate functions in stack traces.
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12427 * Long term would need debug info to populate names
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12428 */
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12429 func[i]->aux->name[0] = 'F';
9c8105bd440223 Jiong Wang 2018-05-02 12430 func[i]->aux->stack_depth = env->subprog_info[i].stack_depth;
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12431 func[i]->jit_requested = 1;
e6ac2450d6dee3 Martin KaFai Lau 2021-03-24 12432 func[i]->aux->kfunc_tab = prog->aux->kfunc_tab;
c454a46b5efd8e Martin KaFai Lau 2018-12-07 12433 func[i]->aux->linfo = prog->aux->linfo;
c454a46b5efd8e Martin KaFai Lau 2018-12-07 12434 func[i]->aux->nr_linfo = prog->aux->nr_linfo;
c454a46b5efd8e Martin KaFai Lau 2018-12-07 12435 func[i]->aux->jited_linfo = prog->aux->jited_linfo;
c454a46b5efd8e Martin KaFai Lau 2018-12-07 12436 func[i]->aux->linfo_idx = env->subprog_info[i].linfo_idx;
c4c0bdc0d2d084 Yonghong Song 2020-06-23 12437 num_exentries = 0;
c4c0bdc0d2d084 Yonghong Song 2020-06-23 12438 insn = func[i]->insnsi;
c4c0bdc0d2d084 Yonghong Song 2020-06-23 12439 for (j = 0; j < func[i]->len; j++, insn++) {
c4c0bdc0d2d084 Yonghong Song 2020-06-23 12440 if (BPF_CLASS(insn->code) == BPF_LDX &&
c4c0bdc0d2d084 Yonghong Song 2020-06-23 12441 BPF_MODE(insn->code) == BPF_PROBE_MEM)
c4c0bdc0d2d084 Yonghong Song 2020-06-23 12442 num_exentries++;
c4c0bdc0d2d084 Yonghong Song 2020-06-23 12443 }
c4c0bdc0d2d084 Yonghong Song 2020-06-23 12444 func[i]->aux->num_exentries = num_exentries;
ebf7d1f508a738 Maciej Fijalkowski 2020-09-16 12445 func[i]->aux->tail_call_reachable = env->subprog_info[i].tail_call_reachable;
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12446 func[i] = bpf_int_jit_compile(func[i]);
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12447 if (!func[i]->jited) {
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12448 err = -ENOTSUPP;
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12449 goto out_free;
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12450 }
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12451 cond_resched();
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12452 }
a748c6975dea32 Maciej Fijalkowski 2020-09-16 12453
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12454 /* at this point all bpf functions were successfully JITed
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12455 * now populate all bpf_calls with correct addresses and
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12456 * run last pass of JIT
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12457 */
f910cefa32b6cd Jiong Wang 2018-05-02 12458 for (i = 0; i < env->subprog_cnt; i++) {
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12459 insn = func[i]->insnsi;
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12460 for (j = 0; j < func[i]->len; j++, insn++) {
69c087ba6225b5 Yonghong Song 2021-02-26 12461 if (bpf_pseudo_func(insn)) {
69c087ba6225b5 Yonghong Song 2021-02-26 12462 subprog = insn[1].imm;
69c087ba6225b5 Yonghong Song 2021-02-26 12463 insn[0].imm = (u32)(long)func[subprog]->bpf_func;
69c087ba6225b5 Yonghong Song 2021-02-26 12464 insn[1].imm = ((u64)(long)func[subprog]->bpf_func) >> 32;
69c087ba6225b5 Yonghong Song 2021-02-26 12465 continue;
69c087ba6225b5 Yonghong Song 2021-02-26 12466 }
23a2d70c7a2f28 Yonghong Song 2021-02-04 12467 if (!bpf_pseudo_call(insn))
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12468 continue;
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12469 subprog = insn->off;
0d306c31b2f773 Prashant Bhole 2019-04-16 @12470 insn->imm = BPF_CAST_CALL(func[subprog]->bpf_func) -
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12471 __bpf_call_base;
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12472 }
2162fed49fa86c Sandipan Das 2018-05-24 12473
2162fed49fa86c Sandipan Das 2018-05-24 12474 /* we use the aux data to keep a list of the start addresses
2162fed49fa86c Sandipan Das 2018-05-24 12475 * of the JITed images for each function in the program
2162fed49fa86c Sandipan Das 2018-05-24 12476 *
2162fed49fa86c Sandipan Das 2018-05-24 12477 * for some architectures, such as powerpc64, the imm field
2162fed49fa86c Sandipan Das 2018-05-24 12478 * might not be large enough to hold the offset of the start
2162fed49fa86c Sandipan Das 2018-05-24 12479 * address of the callee's JITed image from __bpf_call_base
2162fed49fa86c Sandipan Das 2018-05-24 12480 *
2162fed49fa86c Sandipan Das 2018-05-24 12481 * in such cases, we can lookup the start address of a callee
2162fed49fa86c Sandipan Das 2018-05-24 12482 * by using its subprog id, available from the off field of
2162fed49fa86c Sandipan Das 2018-05-24 12483 * the call instruction, as an index for this list
2162fed49fa86c Sandipan Das 2018-05-24 12484 */
2162fed49fa86c Sandipan Das 2018-05-24 12485 func[i]->aux->func = func;
2162fed49fa86c Sandipan Das 2018-05-24 12486 func[i]->aux->func_cnt = env->subprog_cnt;
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12487 }
f910cefa32b6cd Jiong Wang 2018-05-02 12488 for (i = 0; i < env->subprog_cnt; i++) {
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12489 old_bpf_func = func[i]->bpf_func;
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12490 tmp = bpf_int_jit_compile(func[i]);
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12491 if (tmp != func[i] || func[i]->bpf_func != old_bpf_func) {
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12492 verbose(env, "JIT doesn't support bpf-to-bpf calls\n");
c7a897843224a9 Daniel Borkmann 2018-07-12 12493 err = -ENOTSUPP;
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12494 goto out_free;
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12495 }
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12496 cond_resched();
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12497 }
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12498
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12499 /* finally lock prog and jit images for all functions and
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12500 * populate kallsysm
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12501 */
f910cefa32b6cd Jiong Wang 2018-05-02 12502 for (i = 0; i < env->subprog_cnt; i++) {
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12503 bpf_prog_lock_ro(func[i]);
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12504 bpf_prog_kallsyms_add(func[i]);
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12505 }
7105e828c087de Daniel Borkmann 2017-12-20 12506
7105e828c087de Daniel Borkmann 2017-12-20 12507 /* Last step: make now unused interpreter insns from main
7105e828c087de Daniel Borkmann 2017-12-20 12508 * prog consistent for later dump requests, so they can
7105e828c087de Daniel Borkmann 2017-12-20 12509 * later look the same as if they were interpreted only.
7105e828c087de Daniel Borkmann 2017-12-20 12510 */
7105e828c087de Daniel Borkmann 2017-12-20 12511 for (i = 0, insn = prog->insnsi; i < prog->len; i++, insn++) {
69c087ba6225b5 Yonghong Song 2021-02-26 12512 if (bpf_pseudo_func(insn)) {
69c087ba6225b5 Yonghong Song 2021-02-26 12513 insn[0].imm = env->insn_aux_data[i].call_imm;
69c087ba6225b5 Yonghong Song 2021-02-26 12514 insn[1].imm = find_subprog(env, i + insn[0].imm + 1);
69c087ba6225b5 Yonghong Song 2021-02-26 12515 continue;
69c087ba6225b5 Yonghong Song 2021-02-26 12516 }
23a2d70c7a2f28 Yonghong Song 2021-02-04 12517 if (!bpf_pseudo_call(insn))
7105e828c087de Daniel Borkmann 2017-12-20 12518 continue;
7105e828c087de Daniel Borkmann 2017-12-20 12519 insn->off = env->insn_aux_data[i].call_imm;
7105e828c087de Daniel Borkmann 2017-12-20 12520 subprog = find_subprog(env, i + insn->off + 1);
dbecd7388476ae Sandipan Das 2018-05-24 12521 insn->imm = subprog;
7105e828c087de Daniel Borkmann 2017-12-20 12522 }
7105e828c087de Daniel Borkmann 2017-12-20 12523
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12524 prog->jited = 1;
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12525 prog->bpf_func = func[0]->bpf_func;
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12526 prog->aux->func = func;
f910cefa32b6cd Jiong Wang 2018-05-02 12527 prog->aux->func_cnt = env->subprog_cnt;
e16301fbe1837c Martin KaFai Lau 2021-03-24 12528 bpf_prog_jit_attempt_done(prog);
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12529 return 0;
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12530 out_free:
f263a81451c12d John Fastabend 2021-07-07 12531 /* We failed JIT'ing, so at this point we need to unregister poke
f263a81451c12d John Fastabend 2021-07-07 12532 * descriptors from subprogs, so that kernel is not attempting to
f263a81451c12d John Fastabend 2021-07-07 12533 * patch it anymore as we're freeing the subprog JIT memory.
f263a81451c12d John Fastabend 2021-07-07 12534 */
f263a81451c12d John Fastabend 2021-07-07 12535 for (i = 0; i < prog->aux->size_poke_tab; i++) {
f263a81451c12d John Fastabend 2021-07-07 12536 map_ptr = prog->aux->poke_tab[i].tail_call.map;
f263a81451c12d John Fastabend 2021-07-07 12537 map_ptr->ops->map_poke_untrack(map_ptr, prog->aux);
f263a81451c12d John Fastabend 2021-07-07 12538 }
f263a81451c12d John Fastabend 2021-07-07 12539 /* At this point we're guaranteed that poke descriptors are not
f263a81451c12d John Fastabend 2021-07-07 12540 * live anymore. We can just unlink its descriptor table as it's
f263a81451c12d John Fastabend 2021-07-07 12541 * released with the main prog.
f263a81451c12d John Fastabend 2021-07-07 12542 */
a748c6975dea32 Maciej Fijalkowski 2020-09-16 12543 for (i = 0; i < env->subprog_cnt; i++) {
a748c6975dea32 Maciej Fijalkowski 2020-09-16 12544 if (!func[i])
a748c6975dea32 Maciej Fijalkowski 2020-09-16 12545 continue;
f263a81451c12d John Fastabend 2021-07-07 12546 func[i]->aux->poke_tab = NULL;
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12547 bpf_jit_free(func[i]);
a748c6975dea32 Maciej Fijalkowski 2020-09-16 12548 }
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12549 kfree(func);
c7a897843224a9 Daniel Borkmann 2018-07-12 12550 out_undo_insn:
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12551 /* cleanup main prog to be interpreted */
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12552 prog->jit_requested = 0;
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12553 for (i = 0, insn = prog->insnsi; i < prog->len; i++, insn++) {
23a2d70c7a2f28 Yonghong Song 2021-02-04 12554 if (!bpf_pseudo_call(insn))
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12555 continue;
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12556 insn->off = 0;
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12557 insn->imm = env->insn_aux_data[i].call_imm;
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12558 }
e16301fbe1837c Martin KaFai Lau 2021-03-24 12559 bpf_prog_jit_attempt_done(prog);
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12560 return err;
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12561 }
1c2a088a6626d4 Alexei Starovoitov 2017-12-14 12562
:::::: The code at line 12470 was first introduced by commit
:::::: 0d306c31b2f77391dacdeaad4470c577f2aecc4f bpf: use BPF_CAST_CALL for casting bpf call
:::::: TO: Prashant Bhole <bhole_prashant_q7(a)lab.ntt.co.jp>
:::::: CC: Alexei Starovoitov <ast(a)kernel.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 months
[intel-lts:5.10/preempt-rt 16141/17188] drivers/gpu/drm/nouveau/dispnv50/disp.c:1665:54: error: no member named 'backlight' in 'struct nouveau_connector'
by kernel test robot
tree: https://github.com/intel/linux-intel-lts.git 5.10/preempt-rt
head: 3ab3139402e6adc34f10481f1c1c60459bcd0a7e
commit: ce5ae1651b65e1a62c2fd1c347a4a2473341bec7 [16141/17188] drm/nouveau/kms/nv50-: Add basic DPCD backlight support for nouveau
config: riscv-randconfig-r042-20210929 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 28981015526f2192440c18f18e8a20cd11b0779c)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install riscv cross compiling tool for clang build
# apt-get install binutils-riscv64-linux-gnu
# https://github.com/intel/linux-intel-lts/commit/ce5ae1651b65e1a62c2fd1c34...
git remote add intel-lts https://github.com/intel/linux-intel-lts.git
git fetch --no-tags intel-lts 5.10/preempt-rt
git checkout ce5ae1651b65e1a62c2fd1c347a4a2473341bec7
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash drivers/gpu/drm/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
drivers/gpu/drm/nouveau/dispnv50/disp.c:1390:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
int ret;
^
drivers/gpu/drm/nouveau/dispnv50/disp.c:1414:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
int ret;
^
>> drivers/gpu/drm/nouveau/dispnv50/disp.c:1665:54: error: no member named 'backlight' in 'struct nouveau_connector'
struct nouveau_backlight *backlight = nv_connector->backlight;
~~~~~~~~~~~~ ^
>> drivers/gpu/drm/nouveau/dispnv50/disp.c:1670:28: error: incomplete definition of type 'struct nouveau_backlight'
if (backlight && backlight->uses_dpcd) {
~~~~~~~~~^
drivers/gpu/drm/nouveau/dispnv50/disp.c:1665:9: note: forward declaration of 'struct nouveau_backlight'
struct nouveau_backlight *backlight = nv_connector->backlight;
^
drivers/gpu/drm/nouveau/dispnv50/disp.c:1671:50: error: incomplete definition of type 'struct nouveau_backlight'
ret = drm_edp_backlight_disable(aux, &backlight->edp_info);
~~~~~~~~~^
drivers/gpu/drm/nouveau/dispnv50/disp.c:1665:9: note: forward declaration of 'struct nouveau_backlight'
struct nouveau_backlight *backlight = nv_connector->backlight;
^
drivers/gpu/drm/nouveau/dispnv50/disp.c:2661:1: warning: no previous prototype for function 'nv50_display_create' [-Wmissing-prototypes]
nv50_display_create(struct drm_device *dev)
^
drivers/gpu/drm/nouveau/dispnv50/disp.c:2660:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int
^
static
3 warnings and 3 errors generated.
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for SKB_EXTENSIONS
Depends on NET
Selected by
- KCOV && ARCH_HAS_KCOV && (CC_HAS_SANCOV_TRACE_PC || GCC_PLUGINS
vim +1665 drivers/gpu/drm/nouveau/dispnv50/disp.c
1652
1653 /* TODO: Should we extend this to PWM-only backlights?
1654 * As well, should we add a DRM helper for waiting for the backlight to acknowledge
1655 * the panel backlight has been shut off? Intel doesn't seem to do this, and uses a
1656 * fixed time delay from the vbios…
1657 */
1658 static void
1659 nv50_sor_atomic_disable(struct drm_encoder *encoder, struct drm_atomic_state *state)
1660 {
1661 struct nouveau_encoder *nv_encoder = nouveau_encoder(encoder);
1662 struct nouveau_drm *drm = nouveau_drm(nv_encoder->base.base.dev);
1663 struct nouveau_crtc *nv_crtc = nouveau_crtc(nv_encoder->crtc);
1664 struct nouveau_connector *nv_connector = nv50_outp_get_old_connector(state, nv_encoder);
> 1665 struct nouveau_backlight *backlight = nv_connector->backlight;
1666 struct drm_dp_aux *aux = &nv_connector->aux;
1667 int ret;
1668 u8 pwr;
1669
> 1670 if (backlight && backlight->uses_dpcd) {
1671 ret = drm_edp_backlight_disable(aux, &backlight->edp_info);
1672 if (ret < 0)
1673 NV_ERROR(drm, "Failed to disable backlight on [CONNECTOR:%d:%s]: %d\n",
1674 nv_connector->base.base.id, nv_connector->base.name, ret);
1675 }
1676
1677 if (nv_encoder->dcb->type == DCB_OUTPUT_DP) {
1678 int ret = drm_dp_dpcd_readb(aux, DP_SET_POWER, &pwr);
1679
1680 if (ret == 0) {
1681 pwr &= ~DP_SET_POWER_MASK;
1682 pwr |= DP_SET_POWER_D3;
1683 drm_dp_dpcd_writeb(aux, DP_SET_POWER, pwr);
1684 }
1685 }
1686
1687 nv_encoder->update(nv_encoder, nv_crtc->index, NULL, 0, 0);
1688 nv50_audio_disable(encoder, nv_crtc);
1689 nv50_hdmi_disable(&nv_encoder->base.base, nv_crtc);
1690 nv50_outp_release(nv_encoder);
1691 nv_encoder->crtc = NULL;
1692 }
1693
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 months
[kbingham-rcar:kbingham/vsp/v3u-rd-5.15 25/26] drivers/soc/renesas/rcar-irqc.c:46:6: warning: no previous prototype for function 'r8a7791_irqc_show'
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/kbingham/rcar.git kbingham/vsp/v3u-rd-5.15
head: 61b5560118d70887c4acc6687912e78eb279bfde
commit: a9d6287bf4fbc6eff6f93606086c74a35d8ce5f0 [25/26] soc: renesas: rcar: IRQC debug handling
config: arm64-randconfig-r021-20210930 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 28981015526f2192440c18f18e8a20cd11b0779c)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/kbingham/rcar.git/commit/...
git remote add kbingham-rcar https://git.kernel.org/pub/scm/linux/kernel/git/kbingham/rcar.git
git fetch --no-tags kbingham-rcar kbingham/vsp/v3u-rd-5.15
git checkout a9d6287bf4fbc6eff6f93606086c74a35d8ce5f0
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/soc/renesas/rcar-irqc.c:46:6: warning: no previous prototype for function 'r8a7791_irqc_show' [-Wmissing-prototypes]
void r8a7791_irqc_show(const char *msg, unsigned int n)
^
drivers/soc/renesas/rcar-irqc.c:46:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void r8a7791_irqc_show(const char *msg, unsigned int n)
^
static
1 warning generated.
vim +/r8a7791_irqc_show +46 drivers/soc/renesas/rcar-irqc.c
45
> 46 void r8a7791_irqc_show(const char *msg, unsigned int n)
47 {
48 printk("%s:%u\n", msg, n);
49 printk("-LEVEL-- --HIGH-- --LOW--- -S-RISE- -S-FALL- -A-RISE- -A-FALL-\n");
50 printk("%08x %08x %08x %08x %08x %08x %08x\n",
51 ioread32(irqc + MONITOR), ioread32(irqc + HLVL_STS),
52 ioread32(irqc + LLVL_STS), ioread32(irqc + S_R_EDGE_STS),
53 ioread32(irqc + S_F_EDGE_STS), ioread32(irqc + A_R_EDGE_STS),
54 ioread32(irqc + A_F_EDGE_STS));
55 }
56
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 months
[intel-lts:5.4/preempt-rt 9824/19034] drivers/misc/vpusmm/vpusmm_driver.c:406:6: warning: no previous prototype for function 'vpusmm_dmabuf_release'
by kernel test robot
tree: https://github.com/intel/linux-intel-lts.git 5.4/preempt-rt
head: 2dc0f2c1ee89b9ce92944e397f2619062ebb77f8
commit: 2c4a98833ded50c324a6c5e7c949f93cca137acf [9824/19034] misc: vpusmm: add alloc/import DMABuf for VPU
config: arm-randconfig-r035-20210930 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 28981015526f2192440c18f18e8a20cd11b0779c)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
# https://github.com/intel/linux-intel-lts/commit/2c4a98833ded50c324a6c5e7c...
git remote add intel-lts https://github.com/intel/linux-intel-lts.git
git fetch --no-tags intel-lts 5.4/preempt-rt
git checkout 2c4a98833ded50c324a6c5e7c949f93cca137acf
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/misc/vpusmm/vpusmm_driver.c:406:6: warning: no previous prototype for function 'vpusmm_dmabuf_release' [-Wmissing-prototypes]
void vpusmm_dmabuf_release(struct dma_buf *dmabuf)
^
drivers/misc/vpusmm/vpusmm_driver.c:406:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void vpusmm_dmabuf_release(struct dma_buf *dmabuf)
^
static
>> drivers/misc/vpusmm/vpusmm_driver.c:617:14: warning: format specifies type 'unsigned long long' but the argument has type 'dma_addr_t' (aka 'unsigned int') [-Wformat]
__func__, buff->dma_addr, phys_addr, dev_name(dev->dev));
^~~~~~~~~~~~~~
include/linux/printk.h:337:38: note: expanded from macro 'pr_debug'
no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__)
~~~ ^~~~~~~~~~~
include/linux/printk.h:137:17: note: expanded from macro 'no_printk'
printk(fmt, ##__VA_ARGS__); \
~~~ ^~~~~~~~~~~
>> drivers/misc/vpusmm/vpusmm_driver.c:617:30: warning: format specifies type 'unsigned long long' but the argument has type 'phys_addr_t' (aka 'unsigned int') [-Wformat]
__func__, buff->dma_addr, phys_addr, dev_name(dev->dev));
^~~~~~~~~
include/linux/printk.h:337:38: note: expanded from macro 'pr_debug'
no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__)
~~~ ^~~~~~~~~~~
include/linux/printk.h:137:17: note: expanded from macro 'no_printk'
printk(fmt, ##__VA_ARGS__); \
~~~ ^~~~~~~~~~~
>> drivers/misc/vpusmm/vpusmm_driver.c:936:9: warning: format specifies type 'unsigned long long' but the argument has type 'resource_size_t' (aka 'unsigned int') [-Wformat]
vpusmm_dev->mem_res[i].start, vpusmm_dev->mem_res[i].end);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/device.h:1747:33: note: expanded from macro 'dev_info'
_dev_info(dev, dev_fmt(fmt), ##__VA_ARGS__)
~~~ ^~~~~~~~~~~
drivers/misc/vpusmm/vpusmm_driver.c:936:39: warning: format specifies type 'unsigned long long' but the argument has type 'resource_size_t' (aka 'unsigned int') [-Wformat]
vpusmm_dev->mem_res[i].start, vpusmm_dev->mem_res[i].end);
^~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/device.h:1747:33: note: expanded from macro 'dev_info'
_dev_info(dev, dev_fmt(fmt), ##__VA_ARGS__)
~~~ ^~~~~~~~~~~
5 warnings generated.
vim +/vpusmm_dmabuf_release +406 drivers/misc/vpusmm/vpusmm_driver.c
405
> 406 void vpusmm_dmabuf_release(struct dma_buf *dmabuf)
407 {
408 // this buffer is only referencec by dmabuf
409 struct vpusmm_buffer *buff = dmabuf->priv;
410
411 if (buff) {
412 if (buff->cookie) {
413 dma_free_attrs(buff->dev, buff->size, buff->cookie, buff->dma_addr, buff->dma_attrs);
414 buff->cookie = NULL;
415 }
416 kfree(buff);
417 }
418 }
419
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 months
[kbuild] drivers/soc/sifive/sifive_l2_cache.c:235 sifive_l2_init() warn: 'l2_base' not released on lines: 215.
by Dan Carpenter
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 02d5e016800d082058b3d3b7c3ede136cdc6ddcb
commit: 507308b8ccc90d37b07bfca8ffe130435d6b354f RISC-V: sifive_l2_cache: Update L2 cache driver to support SiFive FU740
config: riscv-randconfig-m031-20210930 (attached as .config)
compiler: riscv64-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
smatch warnings:
drivers/soc/sifive/sifive_l2_cache.c:235 sifive_l2_init() warn: 'l2_base' not released on lines: 215.
vim +/l2_base +235 drivers/soc/sifive/sifive_l2_cache.c
bf6df5dd25b7440 arch/riscv/mm/sifive_l2_cache.c Paul Walmsley 2019-10-17 195 static int __init sifive_l2_init(void)
a967a289f169695 arch/riscv/mm/sifive_l2_cache.c Yash Shah 2019-05-06 196 {
a967a289f169695 arch/riscv/mm/sifive_l2_cache.c Yash Shah 2019-05-06 197 struct device_node *np;
a967a289f169695 arch/riscv/mm/sifive_l2_cache.c Yash Shah 2019-05-06 198 struct resource res;
507308b8ccc90d3 drivers/soc/sifive/sifive_l2_cache.c Yash Shah 2020-12-10 199 int i, rc, intr_num;
a967a289f169695 arch/riscv/mm/sifive_l2_cache.c Yash Shah 2019-05-06 200
a967a289f169695 arch/riscv/mm/sifive_l2_cache.c Yash Shah 2019-05-06 201 np = of_find_matching_node(NULL, sifive_l2_ids);
a967a289f169695 arch/riscv/mm/sifive_l2_cache.c Yash Shah 2019-05-06 202 if (!np)
a967a289f169695 arch/riscv/mm/sifive_l2_cache.c Yash Shah 2019-05-06 203 return -ENODEV;
a967a289f169695 arch/riscv/mm/sifive_l2_cache.c Yash Shah 2019-05-06 204
a967a289f169695 arch/riscv/mm/sifive_l2_cache.c Yash Shah 2019-05-06 205 if (of_address_to_resource(np, 0, &res))
a967a289f169695 arch/riscv/mm/sifive_l2_cache.c Yash Shah 2019-05-06 206 return -ENODEV;
a967a289f169695 arch/riscv/mm/sifive_l2_cache.c Yash Shah 2019-05-06 207
a967a289f169695 arch/riscv/mm/sifive_l2_cache.c Yash Shah 2019-05-06 208 l2_base = ioremap(res.start, resource_size(&res));
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
a967a289f169695 arch/riscv/mm/sifive_l2_cache.c Yash Shah 2019-05-06 209 if (!l2_base)
a967a289f169695 arch/riscv/mm/sifive_l2_cache.c Yash Shah 2019-05-06 210 return -ENOMEM;
a967a289f169695 arch/riscv/mm/sifive_l2_cache.c Yash Shah 2019-05-06 211
507308b8ccc90d3 drivers/soc/sifive/sifive_l2_cache.c Yash Shah 2020-12-10 212 intr_num = of_property_count_u32_elems(np, "interrupts");
507308b8ccc90d3 drivers/soc/sifive/sifive_l2_cache.c Yash Shah 2020-12-10 213 if (!intr_num) {
507308b8ccc90d3 drivers/soc/sifive/sifive_l2_cache.c Yash Shah 2020-12-10 214 pr_err("L2CACHE: no interrupts property\n");
507308b8ccc90d3 drivers/soc/sifive/sifive_l2_cache.c Yash Shah 2020-12-10 215 return -ENODEV;
No clean up here. iounmap().
rc = -ENODEV;
goto unmap;
507308b8ccc90d3 drivers/soc/sifive/sifive_l2_cache.c Yash Shah 2020-12-10 216 }
507308b8ccc90d3 drivers/soc/sifive/sifive_l2_cache.c Yash Shah 2020-12-10 217
507308b8ccc90d3 drivers/soc/sifive/sifive_l2_cache.c Yash Shah 2020-12-10 218 for (i = 0; i < intr_num; i++) {
a967a289f169695 arch/riscv/mm/sifive_l2_cache.c Yash Shah 2019-05-06 219 g_irq[i] = irq_of_parse_and_map(np, i);
a967a289f169695 arch/riscv/mm/sifive_l2_cache.c Yash Shah 2019-05-06 220 rc = request_irq(g_irq[i], l2_int_handler, 0, "l2_ecc", NULL);
a967a289f169695 arch/riscv/mm/sifive_l2_cache.c Yash Shah 2019-05-06 221 if (rc) {
a967a289f169695 arch/riscv/mm/sifive_l2_cache.c Yash Shah 2019-05-06 222 pr_err("L2CACHE: Could not request IRQ %d\n", g_irq[i]);
a967a289f169695 arch/riscv/mm/sifive_l2_cache.c Yash Shah 2019-05-06 223 return rc;
Or here. Release the previous IRQs and iounmap(). Yes, this probably
won't boot but we may as well do it correctly because it's less hassle
than debating endlessly whenever someone runs a static checker on the
code.
goto release_irqs;
...
return 0;
release_irqs:
while (--i >= 0)
release_irq();
unmap:
iounmap();
return rc;
a967a289f169695 arch/riscv/mm/sifive_l2_cache.c Yash Shah 2019-05-06 224 }
a967a289f169695 arch/riscv/mm/sifive_l2_cache.c Yash Shah 2019-05-06 225 }
a967a289f169695 arch/riscv/mm/sifive_l2_cache.c Yash Shah 2019-05-06 226
a967a289f169695 arch/riscv/mm/sifive_l2_cache.c Yash Shah 2019-05-06 227 l2_config_read();
a967a289f169695 arch/riscv/mm/sifive_l2_cache.c Yash Shah 2019-05-06 228
4a3a37331248d85 drivers/soc/sifive/sifive_l2_cache.c Yash Shah 2020-02-20 229 l2_cache_ops.get_priv_group = l2_get_priv_group;
4a3a37331248d85 drivers/soc/sifive/sifive_l2_cache.c Yash Shah 2020-02-20 230 riscv_set_cacheinfo_ops(&l2_cache_ops);
4a3a37331248d85 drivers/soc/sifive/sifive_l2_cache.c Yash Shah 2020-02-20 231
a967a289f169695 arch/riscv/mm/sifive_l2_cache.c Yash Shah 2019-05-06 232 #ifdef CONFIG_DEBUG_FS
a967a289f169695 arch/riscv/mm/sifive_l2_cache.c Yash Shah 2019-05-06 233 setup_sifive_debug();
a967a289f169695 arch/riscv/mm/sifive_l2_cache.c Yash Shah 2019-05-06 234 #endif
a967a289f169695 arch/riscv/mm/sifive_l2_cache.c Yash Shah 2019-05-06 @235 return 0;
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
_______________________________________________
kbuild mailing list -- kbuild(a)lists.01.org
To unsubscribe send an email to kbuild-leave(a)lists.01.org
2 months
[arm-platforms:irq/gpio-handler-data 25/37] drivers/iommu/apple-dart.c:186:37: error: 'apple_dart_tlb_ops' defined but not used
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git irq/gpio-handler-data
head: abe5890b12c34b929be59373a9b78d937b9bf290
commit: 91ce249c740186beca41a68c55c3d637e7b0dad7 [25/37] iommu/dart: Remove iommu_flush_ops
config: arc-allyesconfig (attached as .config)
compiler: arceb-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/com...
git remote add arm-platforms https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git
git fetch --no-tags arm-platforms irq/gpio-handler-data
git checkout 91ce249c740186beca41a68c55c3d637e7b0dad7
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=arc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> drivers/iommu/apple-dart.c:186:37: error: 'apple_dart_tlb_ops' defined but not used [-Werror=unused-const-variable=]
186 | static const struct iommu_flush_ops apple_dart_tlb_ops;
| ^~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
vim +/apple_dart_tlb_ops +186 drivers/iommu/apple-dart.c
46d1fb072e76b1 Sven Peter 2021-08-03 170
46d1fb072e76b1 Sven Peter 2021-08-03 171 /*
46d1fb072e76b1 Sven Peter 2021-08-03 172 * Helper macro to iterate over apple_dart_master_cfg.stream_maps and
46d1fb072e76b1 Sven Peter 2021-08-03 173 * apple_dart_domain.stream_maps
46d1fb072e76b1 Sven Peter 2021-08-03 174 *
46d1fb072e76b1 Sven Peter 2021-08-03 175 * @i int used as loop variable
46d1fb072e76b1 Sven Peter 2021-08-03 176 * @base pointer to base struct (apple_dart_master_cfg or apple_dart_domain)
46d1fb072e76b1 Sven Peter 2021-08-03 177 * @stream pointer to the apple_dart_streams struct for each loop iteration
46d1fb072e76b1 Sven Peter 2021-08-03 178 */
46d1fb072e76b1 Sven Peter 2021-08-03 179 #define for_each_stream_map(i, base, stream_map) \
46d1fb072e76b1 Sven Peter 2021-08-03 180 for (i = 0, stream_map = &(base)->stream_maps[0]; \
46d1fb072e76b1 Sven Peter 2021-08-03 181 i < MAX_DARTS_PER_DEVICE && stream_map->dart; \
46d1fb072e76b1 Sven Peter 2021-08-03 182 stream_map = &(base)->stream_maps[++i])
46d1fb072e76b1 Sven Peter 2021-08-03 183
46d1fb072e76b1 Sven Peter 2021-08-03 184 static struct platform_driver apple_dart_driver;
46d1fb072e76b1 Sven Peter 2021-08-03 185 static const struct iommu_ops apple_dart_iommu_ops;
46d1fb072e76b1 Sven Peter 2021-08-03 @186 static const struct iommu_flush_ops apple_dart_tlb_ops;
46d1fb072e76b1 Sven Peter 2021-08-03 187
:::::: The code at line 186 was first introduced by commit
:::::: 46d1fb072e76b161b0fb1ada9e37bf7e4d1f123f iommu/dart: Add DART iommu driver
:::::: TO: Sven Peter <sven(a)svenpeter.dev>
:::::: CC: Joerg Roedel <jroedel(a)suse.de>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 months
[l1k:nft_egress_v5 4/5] net/netfilter/nfnetlink_hook.c:242:56: error: 'struct net_device' has no member named 'nf_hooks_ingress'; did you mean 'nf_hooks_egress'?
by kernel test robot
tree: https://github.com/l1k/linux nft_egress_v5
head: aa103bda2811c502faeacc31ee47d807be2b9d91
commit: 6e373c45e90e9502ca92df0b9c42fe592b80e649 [4/5] netfilter: Introduce egress hook
config: h8300-randconfig-r016-20210930 (attached as .config)
compiler: h8300-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/l1k/linux/commit/6e373c45e90e9502ca92df0b9c42fe592b80e649
git remote add l1k https://github.com/l1k/linux
git fetch --no-tags l1k nft_egress_v5
git checkout 6e373c45e90e9502ca92df0b9c42fe592b80e649
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=h8300 SHELL=/bin/bash net/netfilter/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from include/linux/kernel.h:11,
from include/linux/list.h:9,
from include/linux/module.h:12,
from net/netfilter/nfnetlink_hook.c:8:
include/linux/scatterlist.h: In function 'sg_set_buf':
include/asm-generic/page.h:89:51: warning: ordered comparison of pointer with null pointer [-Wextra]
89 | #define virt_addr_valid(kaddr) (((void *)(kaddr) >= (void *)PAGE_OFFSET) && \
| ^~
include/linux/compiler.h:78:45: note: in definition of macro 'unlikely'
78 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
include/linux/scatterlist.h:143:9: note: in expansion of macro 'BUG_ON'
143 | BUG_ON(!virt_addr_valid(buf));
| ^~~~~~
include/linux/scatterlist.h:143:17: note: in expansion of macro 'virt_addr_valid'
143 | BUG_ON(!virt_addr_valid(buf));
| ^~~~~~~~~~~~~~~
In file included from include/linux/rbtree.h:24,
from include/linux/mm_types.h:10,
from include/linux/buildid.h:5,
from include/linux/module.h:14,
from net/netfilter/nfnetlink_hook.c:8:
net/netfilter/nfnetlink_hook.c: In function 'nfnl_hook_entries_head':
>> net/netfilter/nfnetlink_hook.c:242:56: error: 'struct net_device' has no member named 'nf_hooks_ingress'; did you mean 'nf_hooks_egress'?
242 | return rcu_dereference(netdev->nf_hooks_ingress);
| ^~~~~~~~~~~~~~~~
include/linux/rcupdate.h:389:17: note: in definition of macro '__rcu_dereference_check'
389 | typeof(*p) *________p1 = (typeof(*p) *__force)READ_ONCE(p); \
| ^
include/linux/rcupdate.h:596:28: note: in expansion of macro 'rcu_dereference_check'
596 | #define rcu_dereference(p) rcu_dereference_check(p, 0)
| ^~~~~~~~~~~~~~~~~~~~~
net/netfilter/nfnetlink_hook.c:242:32: note: in expansion of macro 'rcu_dereference'
242 | return rcu_dereference(netdev->nf_hooks_ingress);
| ^~~~~~~~~~~~~~~
>> net/netfilter/nfnetlink_hook.c:242:56: error: 'struct net_device' has no member named 'nf_hooks_ingress'; did you mean 'nf_hooks_egress'?
242 | return rcu_dereference(netdev->nf_hooks_ingress);
| ^~~~~~~~~~~~~~~~
include/linux/rcupdate.h:389:43: note: in definition of macro '__rcu_dereference_check'
389 | typeof(*p) *________p1 = (typeof(*p) *__force)READ_ONCE(p); \
| ^
include/linux/rcupdate.h:596:28: note: in expansion of macro 'rcu_dereference_check'
596 | #define rcu_dereference(p) rcu_dereference_check(p, 0)
| ^~~~~~~~~~~~~~~~~~~~~
net/netfilter/nfnetlink_hook.c:242:32: note: in expansion of macro 'rcu_dereference'
242 | return rcu_dereference(netdev->nf_hooks_ingress);
| ^~~~~~~~~~~~~~~
In file included from <command-line>:
>> net/netfilter/nfnetlink_hook.c:242:56: error: 'struct net_device' has no member named 'nf_hooks_ingress'; did you mean 'nf_hooks_egress'?
242 | return rcu_dereference(netdev->nf_hooks_ingress);
| ^~~~~~~~~~~~~~~~
include/linux/compiler_types.h:302:23: note: in definition of macro '__compiletime_assert'
302 | if (!(condition)) \
| ^~~~~~~~~
include/linux/compiler_types.h:322:9: note: in expansion of macro '_compiletime_assert'
322 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:28: note: in expansion of macro '__native_word'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~
include/asm-generic/rwonce.h:49:9: note: in expansion of macro 'compiletime_assert_rwonce_type'
49 | compiletime_assert_rwonce_type(x); \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/rcupdate.h:389:55: note: in expansion of macro 'READ_ONCE'
389 | typeof(*p) *________p1 = (typeof(*p) *__force)READ_ONCE(p); \
| ^~~~~~~~~
include/linux/rcupdate.h:528:9: note: in expansion of macro '__rcu_dereference_check'
528 | __rcu_dereference_check((p), (c) || rcu_read_lock_held(), __rcu)
| ^~~~~~~~~~~~~~~~~~~~~~~
include/linux/rcupdate.h:596:28: note: in expansion of macro 'rcu_dereference_check'
596 | #define rcu_dereference(p) rcu_dereference_check(p, 0)
| ^~~~~~~~~~~~~~~~~~~~~
net/netfilter/nfnetlink_hook.c:242:32: note: in expansion of macro 'rcu_dereference'
242 | return rcu_dereference(netdev->nf_hooks_ingress);
| ^~~~~~~~~~~~~~~
>> net/netfilter/nfnetlink_hook.c:242:56: error: 'struct net_device' has no member named 'nf_hooks_ingress'; did you mean 'nf_hooks_egress'?
242 | return rcu_dereference(netdev->nf_hooks_ingress);
| ^~~~~~~~~~~~~~~~
include/linux/compiler_types.h:302:23: note: in definition of macro '__compiletime_assert'
302 | if (!(condition)) \
| ^~~~~~~~~
include/linux/compiler_types.h:322:9: note: in expansion of macro '_compiletime_assert'
322 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:28: note: in expansion of macro '__native_word'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~
include/asm-generic/rwonce.h:49:9: note: in expansion of macro 'compiletime_assert_rwonce_type'
49 | compiletime_assert_rwonce_type(x); \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/rcupdate.h:389:55: note: in expansion of macro 'READ_ONCE'
389 | typeof(*p) *________p1 = (typeof(*p) *__force)READ_ONCE(p); \
| ^~~~~~~~~
include/linux/rcupdate.h:528:9: note: in expansion of macro '__rcu_dereference_check'
528 | __rcu_dereference_check((p), (c) || rcu_read_lock_held(), __rcu)
| ^~~~~~~~~~~~~~~~~~~~~~~
include/linux/rcupdate.h:596:28: note: in expansion of macro 'rcu_dereference_check'
596 | #define rcu_dereference(p) rcu_dereference_check(p, 0)
| ^~~~~~~~~~~~~~~~~~~~~
net/netfilter/nfnetlink_hook.c:242:32: note: in expansion of macro 'rcu_dereference'
242 | return rcu_dereference(netdev->nf_hooks_ingress);
| ^~~~~~~~~~~~~~~
>> net/netfilter/nfnetlink_hook.c:242:56: error: 'struct net_device' has no member named 'nf_hooks_ingress'; did you mean 'nf_hooks_egress'?
242 | return rcu_dereference(netdev->nf_hooks_ingress);
| ^~~~~~~~~~~~~~~~
include/linux/compiler_types.h:302:23: note: in definition of macro '__compiletime_assert'
302 | if (!(condition)) \
| ^~~~~~~~~
include/linux/compiler_types.h:322:9: note: in expansion of macro '_compiletime_assert'
322 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:28: note: in expansion of macro '__native_word'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~
include/asm-generic/rwonce.h:49:9: note: in expansion of macro 'compiletime_assert_rwonce_type'
49 | compiletime_assert_rwonce_type(x); \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/rcupdate.h:389:55: note: in expansion of macro 'READ_ONCE'
389 | typeof(*p) *________p1 = (typeof(*p) *__force)READ_ONCE(p); \
| ^~~~~~~~~
include/linux/rcupdate.h:528:9: note: in expansion of macro '__rcu_dereference_check'
528 | __rcu_dereference_check((p), (c) || rcu_read_lock_held(), __rcu)
| ^~~~~~~~~~~~~~~~~~~~~~~
include/linux/rcupdate.h:596:28: note: in expansion of macro 'rcu_dereference_check'
596 | #define rcu_dereference(p) rcu_dereference_check(p, 0)
| ^~~~~~~~~~~~~~~~~~~~~
net/netfilter/nfnetlink_hook.c:242:32: note: in expansion of macro 'rcu_dereference'
242 | return rcu_dereference(netdev->nf_hooks_ingress);
| ^~~~~~~~~~~~~~~
>> net/netfilter/nfnetlink_hook.c:242:56: error: 'struct net_device' has no member named 'nf_hooks_ingress'; did you mean 'nf_hooks_egress'?
242 | return rcu_dereference(netdev->nf_hooks_ingress);
| ^~~~~~~~~~~~~~~~
include/linux/compiler_types.h:302:23: note: in definition of macro '__compiletime_assert'
302 | if (!(condition)) \
| ^~~~~~~~~
include/linux/compiler_types.h:322:9: note: in expansion of macro '_compiletime_assert'
322 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:28: note: in expansion of macro '__native_word'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~
include/asm-generic/rwonce.h:49:9: note: in expansion of macro 'compiletime_assert_rwonce_type'
49 | compiletime_assert_rwonce_type(x); \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/rcupdate.h:389:55: note: in expansion of macro 'READ_ONCE'
389 | typeof(*p) *________p1 = (typeof(*p) *__force)READ_ONCE(p); \
| ^~~~~~~~~
include/linux/rcupdate.h:528:9: note: in expansion of macro '__rcu_dereference_check'
528 | __rcu_dereference_check((p), (c) || rcu_read_lock_held(), __rcu)
| ^~~~~~~~~~~~~~~~~~~~~~~
include/linux/rcupdate.h:596:28: note: in expansion of macro 'rcu_dereference_check'
596 | #define rcu_dereference(p) rcu_dereference_check(p, 0)
| ^~~~~~~~~~~~~~~~~~~~~
net/netfilter/nfnetlink_hook.c:242:32: note: in expansion of macro 'rcu_dereference'
242 | return rcu_dereference(netdev->nf_hooks_ingress);
| ^~~~~~~~~~~~~~~
>> net/netfilter/nfnetlink_hook.c:242:56: error: 'struct net_device' has no member named 'nf_hooks_ingress'; did you mean 'nf_hooks_egress'?
242 | return rcu_dereference(netdev->nf_hooks_ingress);
| ^~~~~~~~~~~~~~~~
include/linux/compiler_types.h:302:23: note: in definition of macro '__compiletime_assert'
302 | if (!(condition)) \
| ^~~~~~~~~
include/linux/compiler_types.h:322:9: note: in expansion of macro '_compiletime_assert'
322 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:49:9: note: in expansion of macro 'compiletime_assert_rwonce_type'
49 | compiletime_assert_rwonce_type(x); \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/rcupdate.h:389:55: note: in expansion of macro 'READ_ONCE'
389 | typeof(*p) *________p1 = (typeof(*p) *__force)READ_ONCE(p); \
| ^~~~~~~~~
include/linux/rcupdate.h:528:9: note: in expansion of macro '__rcu_dereference_check'
528 | __rcu_dereference_check((p), (c) || rcu_read_lock_held(), __rcu)
| ^~~~~~~~~~~~~~~~~~~~~~~
include/linux/rcupdate.h:596:28: note: in expansion of macro 'rcu_dereference_check'
596 | #define rcu_dereference(p) rcu_dereference_check(p, 0)
| ^~~~~~~~~~~~~~~~~~~~~
net/netfilter/nfnetlink_hook.c:242:32: note: in expansion of macro 'rcu_dereference'
242 | return rcu_dereference(netdev->nf_hooks_ingress);
| ^~~~~~~~~~~~~~~
>> net/netfilter/nfnetlink_hook.c:242:56: error: 'struct net_device' has no member named 'nf_hooks_ingress'; did you mean 'nf_hooks_egress'?
242 | return rcu_dereference(netdev->nf_hooks_ingress);
| ^~~~~~~~~~~~~~~~
include/linux/compiler_types.h:279:27: note: in definition of macro '__unqual_scalar_typeof'
279 | _Generic((x), \
| ^
include/asm-generic/rwonce.h:50:9: note: in expansion of macro '__READ_ONCE'
50 | __READ_ONCE(x); \
| ^~~~~~~~~~~
include/linux/rcupdate.h:389:55: note: in expansion of macro 'READ_ONCE'
389 | typeof(*p) *________p1 = (typeof(*p) *__force)READ_ONCE(p); \
| ^~~~~~~~~
include/linux/rcupdate.h:528:9: note: in expansion of macro '__rcu_dereference_check'
528 | __rcu_dereference_check((p), (c) || rcu_read_lock_held(), __rcu)
| ^~~~~~~~~~~~~~~~~~~~~~~
include/linux/rcupdate.h:596:28: note: in expansion of macro 'rcu_dereference_check'
596 | #define rcu_dereference(p) rcu_dereference_check(p, 0)
| ^~~~~~~~~~~~~~~~~~~~~
net/netfilter/nfnetlink_hook.c:242:32: note: in expansion of macro 'rcu_dereference'
242 | return rcu_dereference(netdev->nf_hooks_ingress);
| ^~~~~~~~~~~~~~~
In file included from ./arch/h8300/include/generated/asm/rwonce.h:1,
from include/linux/compiler.h:266,
from include/linux/kernel.h:11,
from include/linux/list.h:9,
from include/linux/module.h:12,
from net/netfilter/nfnetlink_hook.c:8:
>> net/netfilter/nfnetlink_hook.c:242:56: error: 'struct net_device' has no member named 'nf_hooks_ingress'; did you mean 'nf_hooks_egress'?
242 | return rcu_dereference(netdev->nf_hooks_ingress);
| ^~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:44:73: note: in definition of macro '__READ_ONCE'
44 | #define __READ_ONCE(x) (*(const volatile __unqual_scalar_typeof(x) *)&(x))
| ^
include/linux/rcupdate.h:389:55: note: in expansion of macro 'READ_ONCE'
389 | typeof(*p) *________p1 = (typeof(*p) *__force)READ_ONCE(p); \
| ^~~~~~~~~
include/linux/rcupdate.h:528:9: note: in expansion of macro '__rcu_dereference_check'
528 | __rcu_dereference_check((p), (c) || rcu_read_lock_held(), __rcu)
| ^~~~~~~~~~~~~~~~~~~~~~~
include/linux/rcupdate.h:596:28: note: in expansion of macro 'rcu_dereference_check'
596 | #define rcu_dereference(p) rcu_dereference_check(p, 0)
| ^~~~~~~~~~~~~~~~~~~~~
net/netfilter/nfnetlink_hook.c:242:32: note: in expansion of macro 'rcu_dereference'
242 | return rcu_dereference(netdev->nf_hooks_ingress);
| ^~~~~~~~~~~~~~~
In file included from include/linux/rbtree.h:24,
from include/linux/mm_types.h:10,
from include/linux/buildid.h:5,
from include/linux/module.h:14,
from net/netfilter/nfnetlink_hook.c:8:
>> net/netfilter/nfnetlink_hook.c:242:56: error: 'struct net_device' has no member named 'nf_hooks_ingress'; did you mean 'nf_hooks_egress'?
242 | return rcu_dereference(netdev->nf_hooks_ingress);
| ^~~~~~~~~~~~~~~~
include/linux/rcupdate.h:392:19: note: in definition of macro '__rcu_dereference_check'
392 | ((typeof(*p) __force __kernel *)(________p1)); \
| ^
include/linux/rcupdate.h:596:28: note: in expansion of macro 'rcu_dereference_check'
596 | #define rcu_dereference(p) rcu_dereference_check(p, 0)
| ^~~~~~~~~~~~~~~~~~~~~
net/netfilter/nfnetlink_hook.c:242:32: note: in expansion of macro 'rcu_dereference'
242 | return rcu_dereference(netdev->nf_hooks_ingress);
| ^~~~~~~~~~~~~~~
vim +242 net/netfilter/nfnetlink_hook.c
191
192 switch (pf) {
193 case NFPROTO_IPV4:
194 if (hook >= ARRAY_SIZE(net->nf.hooks_ipv4))
195 return ERR_PTR(-EINVAL);
196 hook_head = rcu_dereference(net->nf.hooks_ipv4[hook]);
197 break;
198 case NFPROTO_IPV6:
199 if (hook >= ARRAY_SIZE(net->nf.hooks_ipv6))
200 return ERR_PTR(-EINVAL);
201 hook_head = rcu_dereference(net->nf.hooks_ipv6[hook]);
202 break;
203 case NFPROTO_ARP:
204 #ifdef CONFIG_NETFILTER_FAMILY_ARP
205 if (hook >= ARRAY_SIZE(net->nf.hooks_arp))
206 return ERR_PTR(-EINVAL);
207 hook_head = rcu_dereference(net->nf.hooks_arp[hook]);
208 #endif
209 break;
210 case NFPROTO_BRIDGE:
211 #ifdef CONFIG_NETFILTER_FAMILY_BRIDGE
212 if (hook >= ARRAY_SIZE(net->nf.hooks_bridge))
213 return ERR_PTR(-EINVAL);
214 hook_head = rcu_dereference(net->nf.hooks_bridge[hook]);
215 #endif
216 break;
217 #if IS_ENABLED(CONFIG_DECNET)
218 case NFPROTO_DECNET:
219 if (hook >= ARRAY_SIZE(net->nf.hooks_decnet))
220 return ERR_PTR(-EINVAL);
221 hook_head = rcu_dereference(net->nf.hooks_decnet[hook]);
222 break;
223 #endif
224 #if defined(CONFIG_NETFILTER_INGRESS) || defined(CONFIG_NETFILTER_EGRESS)
225 case NFPROTO_NETDEV:
226 if (hook >= NF_NETDEV_NUMHOOKS)
227 return ERR_PTR(-EOPNOTSUPP);
228
229 if (!dev)
230 return ERR_PTR(-ENODEV);
231
232 netdev = dev_get_by_name_rcu(net, dev);
233 if (!netdev)
234 return ERR_PTR(-ENODEV);
235
236 #ifdef CONFIG_NETFILTER_INGRESS
237 if (hook == NF_NETDEV_INGRESS)
238 return rcu_dereference(netdev->nf_hooks_ingress);
239 #endif
240 #ifdef CONFIG_NETFILTER_EGRESS
241 if (hook == NF_NETDEV_EGRESS)
> 242 return rcu_dereference(netdev->nf_hooks_ingress);
243 #endif
244 fallthrough;
245 #endif
246 default:
247 return ERR_PTR(-EPROTONOSUPPORT);
248 }
249
250 return hook_head;
251 }
252
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 months
[hare-scsi-devel:scsi-result.v1 170/170] drivers/staging/unisys/visorhba/visorhba_main.c:383:10: error: 'struct scsi_cmnd' has no member named 'result'
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git scsi-result.v1
head: 8b1a0adf66803c2d24951496a97bfe401d17b777
commit: 8b1a0adf66803c2d24951496a97bfe401d17b777 [170/170] scsi: split 'result' value into host_byte and status_byte
config: x86_64-randconfig-a006-20210929 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git/commi...
git remote add hare-scsi-devel https://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git
git fetch --no-tags hare-scsi-devel scsi-result.v1
git checkout 8b1a0adf66803c2d24951496a97bfe401d17b777
# save the attached .config to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from include/scsi/scsi.h:12,
from drivers/staging/unisys/visorhba/visorhba_main.c:13:
include/scsi/scsi_common.h: In function 'scsi_sense_buffer_valid':
include/scsi/scsi_common.h:74:34: warning: bitwise comparison always evaluates to false [-Wtautological-compare]
74 | return (sense_buffer[0] & 0x70) == 70;
| ^~
drivers/staging/unisys/visorhba/visorhba_main.c: In function 'visorhba_abort_handler':
>> drivers/staging/unisys/visorhba/visorhba_main.c:383:10: error: 'struct scsi_cmnd' has no member named 'result'
383 | scsicmd->result = DID_ABORT << 16;
| ^~
drivers/staging/unisys/visorhba/visorhba_main.c: In function 'visorhba_device_reset_handler':
drivers/staging/unisys/visorhba/visorhba_main.c:410:10: error: 'struct scsi_cmnd' has no member named 'result'
410 | scsicmd->result = DID_RESET << 16;
| ^~
drivers/staging/unisys/visorhba/visorhba_main.c: In function 'visorhba_bus_reset_handler':
drivers/staging/unisys/visorhba/visorhba_main.c:439:10: error: 'struct scsi_cmnd' has no member named 'result'
439 | scsicmd->result = DID_RESET << 16;
| ^~
drivers/staging/unisys/visorhba/visorhba_main.c: In function 'visorhba_serverdown_complete':
drivers/staging/unisys/visorhba/visorhba_main.c:742:11: error: 'struct scsi_cmnd' has no member named 'result'
742 | scsicmd->result = DID_RESET << 16;
| ^~
drivers/staging/unisys/visorhba/visorhba_main.c: In function 'complete_scsi_command':
drivers/staging/unisys/visorhba/visorhba_main.c:904:9: error: 'struct scsi_cmnd' has no member named 'result'
904 | scsicmd->result = cmdrsp->scsi.linuxstat;
| ^~
vim +383 drivers/staging/unisys/visorhba/visorhba_main.c
d2c3506be646a4 David Kershner 2015-09-24 361
c0487e7e83f136 David Binder 2017-02-21 362 /*
d2c3506be646a4 David Kershner 2015-09-24 363 * visorhba_abort_handler - Send TASK_MGMT_ABORT_TASK
d2c3506be646a4 David Kershner 2015-09-24 364 * @scsicmd: The scsicmd that needs aborted
d2c3506be646a4 David Kershner 2015-09-24 365 *
75f92fcda2923c David Binder 2017-06-30 366 * Return: SUCCESS if inserted, FAILED otherwise
d2c3506be646a4 David Kershner 2015-09-24 367 */
d2c3506be646a4 David Kershner 2015-09-24 368 static int visorhba_abort_handler(struct scsi_cmnd *scsicmd)
d2c3506be646a4 David Kershner 2015-09-24 369 {
d2c3506be646a4 David Kershner 2015-09-24 370 /* issue TASK_MGMT_ABORT_TASK */
d2c3506be646a4 David Kershner 2015-09-24 371 struct scsi_device *scsidev;
d2c3506be646a4 David Kershner 2015-09-24 372 struct visordisk_info *vdisk;
7bc4e528d9f6fc Hannes Reinecke 2017-08-25 373 int rtn;
d2c3506be646a4 David Kershner 2015-09-24 374
d2c3506be646a4 David Kershner 2015-09-24 375 scsidev = scsicmd->device;
7bc4e528d9f6fc Hannes Reinecke 2017-08-25 376 vdisk = scsidev->hostdata;
d2c3506be646a4 David Kershner 2015-09-24 377 if (atomic_read(&vdisk->error_count) < VISORHBA_ERROR_COUNT)
d2c3506be646a4 David Kershner 2015-09-24 378 atomic_inc(&vdisk->error_count);
d2c3506be646a4 David Kershner 2015-09-24 379 else
d2c3506be646a4 David Kershner 2015-09-24 380 atomic_set(&vdisk->ios_threshold, IOS_ERROR_THRESHOLD);
7bc4e528d9f6fc Hannes Reinecke 2017-08-25 381 rtn = forward_taskmgmt_command(TASK_MGMT_ABORT_TASK, scsidev);
7bc4e528d9f6fc Hannes Reinecke 2017-08-25 382 if (rtn == SUCCESS) {
7bc4e528d9f6fc Hannes Reinecke 2017-08-25 @383 scsicmd->result = DID_ABORT << 16;
7bc4e528d9f6fc Hannes Reinecke 2017-08-25 384 scsicmd->scsi_done(scsicmd);
d2c3506be646a4 David Kershner 2015-09-24 385 }
7bc4e528d9f6fc Hannes Reinecke 2017-08-25 386 return rtn;
d2c3506be646a4 David Kershner 2015-09-24 387 }
d2c3506be646a4 David Kershner 2015-09-24 388
:::::: The code at line 383 was first introduced by commit
:::::: 7bc4e528d9f6fc4677eb1a4b0ddeb989c50e051d scsi: visorhba: sanitze private device data allocation
:::::: TO: Hannes Reinecke <hare(a)suse.de>
:::::: CC: Martin K. Petersen <martin.petersen(a)oracle.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 months