[l1k:bcm2835_spi_clkcache 1/1] drivers/spi/spi-bcm2835.c:1048:1: warning: no previous prototype for 'bcm2835_spi_set_clk'
by kernel test robot
tree: https://github.com/l1k/linux bcm2835_spi_clkcache
head: c26ae7b1acc28bc6d97707230886c6fe9ece7d15
commit: c26ae7b1acc28bc6d97707230886c6fe9ece7d15 [1/1] spi: bcm2835: Avoid unnecessary recalculation of CLK register
config: arm64-randconfig-r022-20210912 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/l1k/linux/commit/c26ae7b1acc28bc6d97707230886c6fe9ece7d15
git remote add l1k https://github.com/l1k/linux
git fetch --no-tags l1k bcm2835_spi_clkcache
git checkout c26ae7b1acc28bc6d97707230886c6fe9ece7d15
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
drivers/spi/spi-bcm2835.c:1048:1: error: return type defaults to 'int' [-Werror=return-type]
1048 | bcm2835_spi_set_clk(struct bcm2835_spi *bs, struct spi_transfer *tfr)
| ^~~~~~~~~~~~~~~~~~~
>> drivers/spi/spi-bcm2835.c:1048:1: warning: no previous prototype for 'bcm2835_spi_set_clk' [-Wmissing-prototypes]
drivers/spi/spi-bcm2835.c: In function 'bcm2835_spi_set_clk':
drivers/spi/spi-bcm2835.c:1070:1: error: control reaches end of non-void function [-Werror=return-type]
1070 | }
| ^
cc1: some warnings being treated as errors
vim +/bcm2835_spi_set_clk +1048 drivers/spi/spi-bcm2835.c
1047
> 1048 bcm2835_spi_set_clk(struct bcm2835_spi *bs, struct spi_transfer *tfr)
1049 {
1050 unsigned long spi_hz = bs->speed_hz = tfr->speed_hz;
1051 unsigned long cdiv;
1052
1053 if (spi_hz >= bs->clk_hz / 2) {
1054 cdiv = 2; /* clk_hz/2 is the fastest we can go */
1055 } else if (spi_hz) {
1056 /* CDIV must be a multiple of two */
1057 cdiv = DIV_ROUND_UP(bs->clk_hz, spi_hz);
1058 cdiv += (cdiv % 2);
1059
1060 if (cdiv >= 65536)
1061 cdiv = 0; /* 0 is the slowest we can go */
1062 } else {
1063 cdiv = 0; /* 0 is the slowest we can go */
1064 }
1065
1066 tfr->effective_speed_hz = bs->effective_speed_hz =
1067 cdiv ? (bs->clk_hz / cdiv) : (bs->clk_hz / 65536);
1068
1069 bcm2835_wr(bs, BCM2835_SPI_CLK, cdiv);
1070 }
1071
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year
Re: [PATCH v2] mm/page_alloc: detect allocation forbidden by cpuset and bail out early
by kernel test robot
Hi Feng,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on hnaz-linux-mm/master]
url: https://github.com/0day-ci/linux/commits/Feng-Tang/mm-page_alloc-detect-a...
base: https://github.com/hnaz/linux-mm master
config: arc-randconfig-r043-20210913 (attached as .config)
compiler: arc-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/276fb2292fa199777b3e9a394c8737e4c...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Feng-Tang/mm-page_alloc-detect-allocation-forbidden-by-cpuset-and-bail-out-early/20210913-154016
git checkout 276fb2292fa199777b3e9a394c8737e4c618cd23
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=arc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
mm/page_alloc.c:3810:15: warning: no previous prototype for 'should_fail_alloc_page' [-Wmissing-prototypes]
3810 | noinline bool should_fail_alloc_page(gfp_t gfp_mask, unsigned int order)
| ^~~~~~~~~~~~~~~~~~~~~~
mm/page_alloc.c: In function '__alloc_pages_slowpath':
>> mm/page_alloc.c:4922:13: error: implicit declaration of function 'cpusets_insane_config' [-Werror=implicit-function-declaration]
4922 | if (cpusets_insane_config() && (gfp_mask & __GFP_HARDWALL)) {
| ^~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/cpusets_insane_config +4922 mm/page_alloc.c
4868
4869 static inline struct page *
4870 __alloc_pages_slowpath(gfp_t gfp_mask, unsigned int order,
4871 struct alloc_context *ac)
4872 {
4873 bool can_direct_reclaim = gfp_mask & __GFP_DIRECT_RECLAIM;
4874 const bool costly_order = order > PAGE_ALLOC_COSTLY_ORDER;
4875 struct page *page = NULL;
4876 unsigned int alloc_flags;
4877 unsigned long did_some_progress;
4878 enum compact_priority compact_priority;
4879 enum compact_result compact_result;
4880 int compaction_retries;
4881 int no_progress_loops;
4882 unsigned int cpuset_mems_cookie;
4883 int reserve_flags;
4884
4885 /*
4886 * We also sanity check to catch abuse of atomic reserves being used by
4887 * callers that are not in atomic context.
4888 */
4889 if (WARN_ON_ONCE((gfp_mask & (__GFP_ATOMIC|__GFP_DIRECT_RECLAIM)) ==
4890 (__GFP_ATOMIC|__GFP_DIRECT_RECLAIM)))
4891 gfp_mask &= ~__GFP_ATOMIC;
4892
4893 retry_cpuset:
4894 compaction_retries = 0;
4895 no_progress_loops = 0;
4896 compact_priority = DEF_COMPACT_PRIORITY;
4897 cpuset_mems_cookie = read_mems_allowed_begin();
4898
4899 /*
4900 * The fast path uses conservative alloc_flags to succeed only until
4901 * kswapd needs to be woken up, and to avoid the cost of setting up
4902 * alloc_flags precisely. So we do that now.
4903 */
4904 alloc_flags = gfp_to_alloc_flags(gfp_mask);
4905
4906 /*
4907 * We need to recalculate the starting point for the zonelist iterator
4908 * because we might have used different nodemask in the fast path, or
4909 * there was a cpuset modification and we are retrying - otherwise we
4910 * could end up iterating over non-eligible zones endlessly.
4911 */
4912 ac->preferred_zoneref = first_zones_zonelist(ac->zonelist,
4913 ac->highest_zoneidx, ac->nodemask);
4914 if (!ac->preferred_zoneref->zone)
4915 goto nopage;
4916
4917 /*
4918 * Check for insane configurations where the cpuset doesn't contain
4919 * any suitable zone to satisfy the request - e.g. non-movable
4920 * GFP_HIGHUSER allocations from MOVABLE nodes only.
4921 */
> 4922 if (cpusets_insane_config() && (gfp_mask & __GFP_HARDWALL)) {
4923 struct zoneref *z = first_zones_zonelist(ac->zonelist,
4924 ac->highest_zoneidx,
4925 &cpuset_current_mems_allowed);
4926 if (!z->zone)
4927 goto nopage;
4928 }
4929
4930 if (alloc_flags & ALLOC_KSWAPD)
4931 wake_all_kswapds(order, gfp_mask, ac);
4932
4933 /*
4934 * The adjusted alloc_flags might result in immediate success, so try
4935 * that first
4936 */
4937 page = get_page_from_freelist(gfp_mask, order, alloc_flags, ac);
4938 if (page)
4939 goto got_pg;
4940
4941 /*
4942 * For costly allocations, try direct compaction first, as it's likely
4943 * that we have enough base pages and don't need to reclaim. For non-
4944 * movable high-order allocations, do that as well, as compaction will
4945 * try prevent permanent fragmentation by migrating from blocks of the
4946 * same migratetype.
4947 * Don't try this for allocations that are allowed to ignore
4948 * watermarks, as the ALLOC_NO_WATERMARKS attempt didn't yet happen.
4949 */
4950 if (can_direct_reclaim &&
4951 (costly_order ||
4952 (order > 0 && ac->migratetype != MIGRATE_MOVABLE))
4953 && !gfp_pfmemalloc_allowed(gfp_mask)) {
4954 page = __alloc_pages_direct_compact(gfp_mask, order,
4955 alloc_flags, ac,
4956 INIT_COMPACT_PRIORITY,
4957 &compact_result);
4958 if (page)
4959 goto got_pg;
4960
4961 /*
4962 * Checks for costly allocations with __GFP_NORETRY, which
4963 * includes some THP page fault allocations
4964 */
4965 if (costly_order && (gfp_mask & __GFP_NORETRY)) {
4966 /*
4967 * If allocating entire pageblock(s) and compaction
4968 * failed because all zones are below low watermarks
4969 * or is prohibited because it recently failed at this
4970 * order, fail immediately unless the allocator has
4971 * requested compaction and reclaim retry.
4972 *
4973 * Reclaim is
4974 * - potentially very expensive because zones are far
4975 * below their low watermarks or this is part of very
4976 * bursty high order allocations,
4977 * - not guaranteed to help because isolate_freepages()
4978 * may not iterate over freed pages as part of its
4979 * linear scan, and
4980 * - unlikely to make entire pageblocks free on its
4981 * own.
4982 */
4983 if (compact_result == COMPACT_SKIPPED ||
4984 compact_result == COMPACT_DEFERRED)
4985 goto nopage;
4986
4987 /*
4988 * Looks like reclaim/compaction is worth trying, but
4989 * sync compaction could be very expensive, so keep
4990 * using async compaction.
4991 */
4992 compact_priority = INIT_COMPACT_PRIORITY;
4993 }
4994 }
4995
4996 retry:
4997 /* Ensure kswapd doesn't accidentally go to sleep as long as we loop */
4998 if (alloc_flags & ALLOC_KSWAPD)
4999 wake_all_kswapds(order, gfp_mask, ac);
5000
5001 reserve_flags = __gfp_pfmemalloc_flags(gfp_mask);
5002 if (reserve_flags)
5003 alloc_flags = gfp_to_alloc_flags_cma(gfp_mask, reserve_flags);
5004
5005 /*
5006 * Reset the nodemask and zonelist iterators if memory policies can be
5007 * ignored. These allocations are high priority and system rather than
5008 * user oriented.
5009 */
5010 if (!(alloc_flags & ALLOC_CPUSET) || reserve_flags) {
5011 ac->nodemask = NULL;
5012 ac->preferred_zoneref = first_zones_zonelist(ac->zonelist,
5013 ac->highest_zoneidx, ac->nodemask);
5014 }
5015
5016 /* Attempt with potentially adjusted zonelist and alloc_flags */
5017 page = get_page_from_freelist(gfp_mask, order, alloc_flags, ac);
5018 if (page)
5019 goto got_pg;
5020
5021 /* Caller is not willing to reclaim, we can't balance anything */
5022 if (!can_direct_reclaim)
5023 goto nopage;
5024
5025 /* Avoid recursion of direct reclaim */
5026 if (current->flags & PF_MEMALLOC)
5027 goto nopage;
5028
5029 /* Try direct reclaim and then allocating */
5030 page = __alloc_pages_direct_reclaim(gfp_mask, order, alloc_flags, ac,
5031 &did_some_progress);
5032 if (page)
5033 goto got_pg;
5034
5035 /* Try direct compaction and then allocating */
5036 page = __alloc_pages_direct_compact(gfp_mask, order, alloc_flags, ac,
5037 compact_priority, &compact_result);
5038 if (page)
5039 goto got_pg;
5040
5041 /* Do not loop if specifically requested */
5042 if (gfp_mask & __GFP_NORETRY)
5043 goto nopage;
5044
5045 /*
5046 * Do not retry costly high order allocations unless they are
5047 * __GFP_RETRY_MAYFAIL
5048 */
5049 if (costly_order && !(gfp_mask & __GFP_RETRY_MAYFAIL))
5050 goto nopage;
5051
5052 if (should_reclaim_retry(gfp_mask, order, ac, alloc_flags,
5053 did_some_progress > 0, &no_progress_loops))
5054 goto retry;
5055
5056 /*
5057 * It doesn't make any sense to retry for the compaction if the order-0
5058 * reclaim is not able to make any progress because the current
5059 * implementation of the compaction depends on the sufficient amount
5060 * of free memory (see __compaction_suitable)
5061 */
5062 if (did_some_progress > 0 &&
5063 should_compact_retry(ac, order, alloc_flags,
5064 compact_result, &compact_priority,
5065 &compaction_retries))
5066 goto retry;
5067
5068
5069 /* Deal with possible cpuset update races before we start OOM killing */
5070 if (check_retry_cpuset(cpuset_mems_cookie, ac))
5071 goto retry_cpuset;
5072
5073 /* Reclaim has failed us, start killing things */
5074 page = __alloc_pages_may_oom(gfp_mask, order, ac, &did_some_progress);
5075 if (page)
5076 goto got_pg;
5077
5078 /* Avoid allocations with no watermarks from looping endlessly */
5079 if (tsk_is_oom_victim(current) &&
5080 (alloc_flags & ALLOC_OOM ||
5081 (gfp_mask & __GFP_NOMEMALLOC)))
5082 goto nopage;
5083
5084 /* Retry as long as the OOM killer is making progress */
5085 if (did_some_progress) {
5086 no_progress_loops = 0;
5087 goto retry;
5088 }
5089
5090 nopage:
5091 /* Deal with possible cpuset update races before we fail */
5092 if (check_retry_cpuset(cpuset_mems_cookie, ac))
5093 goto retry_cpuset;
5094
5095 /*
5096 * Make sure that __GFP_NOFAIL request doesn't leak out and make sure
5097 * we always retry
5098 */
5099 if (gfp_mask & __GFP_NOFAIL) {
5100 /*
5101 * All existing users of the __GFP_NOFAIL are blockable, so warn
5102 * of any new users that actually require GFP_NOWAIT
5103 */
5104 if (WARN_ON_ONCE(!can_direct_reclaim))
5105 goto fail;
5106
5107 /*
5108 * PF_MEMALLOC request from this context is rather bizarre
5109 * because we cannot reclaim anything and only can loop waiting
5110 * for somebody to do a work for us
5111 */
5112 WARN_ON_ONCE(current->flags & PF_MEMALLOC);
5113
5114 /*
5115 * non failing costly orders are a hard requirement which we
5116 * are not prepared for much so let's warn about these users
5117 * so that we can identify them and convert them to something
5118 * else.
5119 */
5120 WARN_ON_ONCE(order > PAGE_ALLOC_COSTLY_ORDER);
5121
5122 /*
5123 * Help non-failing allocations by giving them access to memory
5124 * reserves but do not use ALLOC_NO_WATERMARKS because this
5125 * could deplete whole memory reserves which would just make
5126 * the situation worse
5127 */
5128 page = __alloc_pages_cpuset_fallback(gfp_mask, order, ALLOC_HARDER, ac);
5129 if (page)
5130 goto got_pg;
5131
5132 cond_resched();
5133 goto retry;
5134 }
5135 fail:
5136 warn_alloc(gfp_mask, ac->nodemask,
5137 "page allocation failure: order:%u", order);
5138 got_pg:
5139 return page;
5140 }
5141
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year
[hch-block:blkdev.h-includes 14/17] arch/um/drivers/ubd_kern.c:922:20: error: 'UBD_MAJOR' undeclared
by kernel test robot
tree: git://git.infradead.org/users/hch/block.git blkdev.h-includes
head: 0687088056048288700f442e86ea92af0fce9a12
commit: 6d47a4368a1c73179c8a73c2365d013341b8cb71 [14/17] block: drop unused includes in <linux/genhd.h>
config: um-x86_64_defconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
git remote add hch-block git://git.infradead.org/users/hch/block.git
git fetch --no-tags hch-block blkdev.h-includes
git checkout 6d47a4368a1c73179c8a73c2365d013341b8cb71
# save the attached .config to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=um SUBARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
arch/um/drivers/ubd_kern.c: In function 'ubd_add':
>> arch/um/drivers/ubd_kern.c:922:20: error: 'UBD_MAJOR' undeclared (first use in this function)
922 | ubd_disk_register(UBD_MAJOR, ubd_dev->size, n, disk);
| ^~~~~~~~~
arch/um/drivers/ubd_kern.c:922:20: note: each undeclared identifier is reported only once for each function it appears in
In file included from include/linux/blkdev.h:6,
from arch/um/drivers/ubd_kern.c:26:
arch/um/drivers/ubd_kern.c: In function 'ubd_init':
arch/um/drivers/ubd_kern.c:1088:22: error: 'UBD_MAJOR' undeclared (first use in this function)
1088 | if (register_blkdev(UBD_MAJOR, "ubd"))
| ^~~~~~~~~
include/linux/genhd.h:276:20: note: in definition of macro 'register_blkdev'
276 | __register_blkdev(major, name, NULL)
| ^~~~~
vim +/UBD_MAJOR +922 arch/um/drivers/ubd_kern.c
4e6da0fe8058df Richard Weinberger 2017-11-26 883
f28169d2000177 Jeff Dike 2007-02-10 884 static int ubd_add(int n, char **error_out)
^1da177e4c3f41 Linus Torvalds 2005-04-16 885 {
7d314e346d6081 Paolo 'Blaisorblade' Giarrusso 2006-10-30 886 struct ubd *ubd_dev = &ubd_devs[n];
35efb594c3a8bb Christoph Hellwig 2021-06-14 887 struct gendisk *disk;
f28169d2000177 Jeff Dike 2007-02-10 888 int err = 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16 889
7d314e346d6081 Paolo 'Blaisorblade' Giarrusso 2006-10-30 890 if(ubd_dev->file == NULL)
ec7cf783dd6cf5 Jeff Dike 2005-09-03 891 goto out;
^1da177e4c3f41 Linus Torvalds 2005-04-16 892
7d314e346d6081 Paolo 'Blaisorblade' Giarrusso 2006-10-30 893 err = ubd_file_size(ubd_dev, &ubd_dev->size);
f28169d2000177 Jeff Dike 2007-02-10 894 if(err < 0){
f28169d2000177 Jeff Dike 2007-02-10 895 *error_out = "Couldn't determine size of device's file";
80c13749140284 Jeff Dike 2006-09-29 896 goto out;
f28169d2000177 Jeff Dike 2007-02-10 897 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 898
7d314e346d6081 Paolo 'Blaisorblade' Giarrusso 2006-10-30 899 ubd_dev->size = ROUND_BLOCK(ubd_dev->size);
^1da177e4c3f41 Linus Torvalds 2005-04-16 900
4e6da0fe8058df Richard Weinberger 2017-11-26 901 ubd_dev->tag_set.ops = &ubd_mq_ops;
4e6da0fe8058df Richard Weinberger 2017-11-26 902 ubd_dev->tag_set.queue_depth = 64;
4e6da0fe8058df Richard Weinberger 2017-11-26 903 ubd_dev->tag_set.numa_node = NUMA_NO_NODE;
4e6da0fe8058df Richard Weinberger 2017-11-26 904 ubd_dev->tag_set.flags = BLK_MQ_F_SHOULD_MERGE;
4e6da0fe8058df Richard Weinberger 2017-11-26 905 ubd_dev->tag_set.driver_data = ubd_dev;
4e6da0fe8058df Richard Weinberger 2017-11-26 906 ubd_dev->tag_set.nr_hw_queues = 1;
a0044bdf60c212 Jeff Dike 2007-05-06 907
4e6da0fe8058df Richard Weinberger 2017-11-26 908 err = blk_mq_alloc_tag_set(&ubd_dev->tag_set);
4e6da0fe8058df Richard Weinberger 2017-11-26 909 if (err)
80c13749140284 Jeff Dike 2006-09-29 910 goto out;
4e6da0fe8058df Richard Weinberger 2017-11-26 911
35efb594c3a8bb Christoph Hellwig 2021-06-14 912 disk = blk_mq_alloc_disk(&ubd_dev->tag_set, ubd_dev);
35efb594c3a8bb Christoph Hellwig 2021-06-14 913 if (IS_ERR(disk)) {
35efb594c3a8bb Christoph Hellwig 2021-06-14 914 err = PTR_ERR(disk);
aea05eb56e4704 Anton Ivanov 2019-02-26 915 goto out_cleanup_tags;
62f96cb01e8de7 Jeff Dike 2007-02-10 916 }
35efb594c3a8bb Christoph Hellwig 2021-06-14 917 ubd_dev->queue = disk->queue;
4e6da0fe8058df Richard Weinberger 2017-11-26 918
f935a8ce0a60ac Jens Axboe 2016-03-30 919 blk_queue_write_cache(ubd_dev->queue, true, false);
8a78362c4eefc1 Martin K. Petersen 2010-02-26 920 blk_queue_max_segments(ubd_dev->queue, MAX_SG);
fc6b6a872dcd48 Gabriel Krisman Bertazi 2020-11-21 921 blk_queue_segment_boundary(ubd_dev->queue, PAGE_SIZE - 1);
35efb594c3a8bb Christoph Hellwig 2021-06-14 @922 ubd_disk_register(UBD_MAJOR, ubd_dev->size, n, disk);
35efb594c3a8bb Christoph Hellwig 2021-06-14 923 ubd_gendisk[n] = disk;
35efb594c3a8bb Christoph Hellwig 2021-06-14 924 return 0;
62f96cb01e8de7 Jeff Dike 2007-02-10 925
4e6da0fe8058df Richard Weinberger 2017-11-26 926 out_cleanup_tags:
4e6da0fe8058df Richard Weinberger 2017-11-26 927 blk_mq_free_tag_set(&ubd_dev->tag_set);
35efb594c3a8bb Christoph Hellwig 2021-06-14 928 out:
35efb594c3a8bb Christoph Hellwig 2021-06-14 929 return err;
^1da177e4c3f41 Linus Torvalds 2005-04-16 930 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 931
:::::: The code at line 922 was first introduced by commit
:::::: 35efb594c3a8bbd41fca67658b03bf99441d488b ubd: use blk_mq_alloc_disk and blk_cleanup_disk
:::::: TO: Christoph Hellwig <hch(a)lst.de>
:::::: CC: Jens Axboe <axboe(a)kernel.dk>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year
Re: [PATCH] trace: Do some cleanups for osnoise tracer
by kernel test robot
Hi Tang,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on tip/perf/core]
[also build test WARNING on v5.15-rc1 next-20210913]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Tang-Yizhou/trace-Do-some-cleanu...
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 4034fb207e302cc0b1f304084d379640c1fb1436
config: i386-randconfig-s001-20210912 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.4-dirty
# https://github.com/0day-ci/linux/commit/cecf38d3b5e23a411856f6c8f3e3be903...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Tang-Yizhou/trace-Do-some-cleanups-for-osnoise-tracer/20210913-111459
git checkout cecf38d3b5e23a411856f6c8f3e3be903e439876
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
>> kernel/trace/trace_osnoise.c:1826:20: sparse: sparse: incorrect type in initializer (different modifiers) @@ expected unsigned long long [usertype] *max @@ got unsigned long long const * @@
kernel/trace/trace_osnoise.c:1826:20: sparse: expected unsigned long long [usertype] *max
kernel/trace/trace_osnoise.c:1826:20: sparse: got unsigned long long const *
>> kernel/trace/trace_osnoise.c:1827:20: sparse: sparse: incorrect type in initializer (different modifiers) @@ expected unsigned long long [usertype] *min @@ got unsigned long long const * @@
kernel/trace/trace_osnoise.c:1827:20: sparse: expected unsigned long long [usertype] *min
kernel/trace/trace_osnoise.c:1827:20: sparse: got unsigned long long const *
vim +1826 kernel/trace/trace_osnoise.c
a955d7eac1779b43 Daniel Bristot de Oliveira 2021-06-22 1817
a955d7eac1779b43 Daniel Bristot de Oliveira 2021-06-22 1818 /*
a955d7eac1779b43 Daniel Bristot de Oliveira 2021-06-22 1819 * osnoise/timerlat_period: min 100 us, max 1 s
a955d7eac1779b43 Daniel Bristot de Oliveira 2021-06-22 1820 */
cecf38d3b5e23a41 Tang Yizhou 2021-09-13 1821 static const u64 timerlat_min_period = 100;
cecf38d3b5e23a41 Tang Yizhou 2021-09-13 1822 static const u64 timerlat_max_period = 1000000;
a955d7eac1779b43 Daniel Bristot de Oliveira 2021-06-22 1823 static struct trace_min_max_param timerlat_period = {
a955d7eac1779b43 Daniel Bristot de Oliveira 2021-06-22 1824 .lock = &interface_lock,
a955d7eac1779b43 Daniel Bristot de Oliveira 2021-06-22 1825 .val = &osnoise_data.timerlat_period,
a955d7eac1779b43 Daniel Bristot de Oliveira 2021-06-22 @1826 .max = &timerlat_max_period,
a955d7eac1779b43 Daniel Bristot de Oliveira 2021-06-22 @1827 .min = &timerlat_min_period,
a955d7eac1779b43 Daniel Bristot de Oliveira 2021-06-22 1828 };
a955d7eac1779b43 Daniel Bristot de Oliveira 2021-06-22 1829 #endif
a955d7eac1779b43 Daniel Bristot de Oliveira 2021-06-22 1830
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year
Re: [PATCH] trace: Do some cleanups for osnoise tracer
by kernel test robot
Hi Tang,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on tip/perf/core]
[also build test WARNING on v5.15-rc1 next-20210913]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Tang-Yizhou/trace-Do-some-cleanu...
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 4034fb207e302cc0b1f304084d379640c1fb1436
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/cecf38d3b5e23a411856f6c8f3e3be903...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Tang-Yizhou/trace-Do-some-cleanups-for-osnoise-tracer/20210913-111459
git checkout cecf38d3b5e23a411856f6c8f3e3be903e439876
# save the attached .config to linux build tree
make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> kernel/trace/trace_osnoise.c:1826:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
1826 | .max = &timerlat_max_period,
| ^
kernel/trace/trace_osnoise.c:1827:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
1827 | .min = &timerlat_min_period,
| ^
vim +/const +1826 kernel/trace/trace_osnoise.c
a955d7eac1779b Daniel Bristot de Oliveira 2021-06-22 1817
a955d7eac1779b Daniel Bristot de Oliveira 2021-06-22 1818 /*
a955d7eac1779b Daniel Bristot de Oliveira 2021-06-22 1819 * osnoise/timerlat_period: min 100 us, max 1 s
a955d7eac1779b Daniel Bristot de Oliveira 2021-06-22 1820 */
cecf38d3b5e23a Tang Yizhou 2021-09-13 1821 static const u64 timerlat_min_period = 100;
cecf38d3b5e23a Tang Yizhou 2021-09-13 1822 static const u64 timerlat_max_period = 1000000;
a955d7eac1779b Daniel Bristot de Oliveira 2021-06-22 1823 static struct trace_min_max_param timerlat_period = {
a955d7eac1779b Daniel Bristot de Oliveira 2021-06-22 1824 .lock = &interface_lock,
a955d7eac1779b Daniel Bristot de Oliveira 2021-06-22 1825 .val = &osnoise_data.timerlat_period,
a955d7eac1779b Daniel Bristot de Oliveira 2021-06-22 @1826 .max = &timerlat_max_period,
a955d7eac1779b Daniel Bristot de Oliveira 2021-06-22 1827 .min = &timerlat_min_period,
a955d7eac1779b Daniel Bristot de Oliveira 2021-06-22 1828 };
a955d7eac1779b Daniel Bristot de Oliveira 2021-06-22 1829 #endif
a955d7eac1779b Daniel Bristot de Oliveira 2021-06-22 1830
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year
Re: [PATCH v3 1/2] powerpc/64s: system call scv tabort fix for corrupt irq soft-mask state
by kernel test robot
Please kindly note that this is a powerpc32 build.
Hi Nicholas,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.14 next-20210903]
[cannot apply to powerpc/next scottwood/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Nicholas-Piggin/powerpc-64s-syst...
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git a9c9a6f741cdaa2fa9ba24a790db8d07295761e3
:::::: branch date: 5 hours ago
:::::: commit date: 5 hours ago
config: powerpc-randconfig-s032-20210903 (attached as .config)
compiler: powerpc-linux-gcc (GCC) 11.2.0
reproduce:
cd linux
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O make.cross
chmod +x make.cross
# https://github.com/0day-ci/linux/commit/3510c8c0951ec7ac98da8d6931df7499c...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Nicholas-Piggin/powerpc-64s-system-call-scv-tabort-fix-for-corrupt-irq-soft-mask-state/20210903-205907
git checkout 3510c8c0951ec7ac98da8d6931df7499ca6c881e
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 ./make.cross ARCH=powerpc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from arch/powerpc/include/asm/processor.h:11,
from arch/powerpc/include/asm/thread_info.h:40,
from include/linux/thread_info.h:60,
from arch/powerpc/include/asm/ptrace.h:298,
from arch/powerpc/include/asm/hw_irq.h:12,
from arch/powerpc/include/asm/irqflags.h:12,
from include/linux/irqflags.h:16,
from include/asm-generic/cmpxchg-local.h:6,
from arch/powerpc/include/asm/cmpxchg.h:526,
from arch/powerpc/include/asm/atomic.h:11,
from include/linux/atomic.h:7,
from include/linux/rcupdate.h:25,
from include/linux/rculist.h:11,
from include/linux/pid.h:5,
from include/linux/sched.h:14,
from include/linux/context_tracking.h:5,
from arch/powerpc/kernel/interrupt.c:3:
arch/powerpc/kernel/interrupt.c: In function 'system_call_exception':
>> arch/powerpc/include/asm/reg.h:66:29: error: left shift count >= width of type [-Werror=shift-count-overflow]
66 | #define __MASK(X) (1UL<<(X))
| ^~
arch/powerpc/include/asm/reg.h:1378:61: note: in definition of macro 'mtmsr'
1378 | : "r" ((unsigned long)(v)) \
| ^
arch/powerpc/include/asm/reg.h:115:25: note: in expansion of macro '__MASK'
115 | #define MSR_TM __MASK(MSR_TM_LG) /* Transactional Mem Available */
| ^~~~~~
arch/powerpc/kernel/interrupt.c:153:33: note: in expansion of macro 'MSR_TM'
153 | mtmsr(mfmsr() | MSR_TM);
| ^~~~~~
cc1: all warnings being treated as errors
vim +66 arch/powerpc/include/asm/reg.h
14cf11af6cf608 include/asm-powerpc/reg.h Paul Mackerras 2005-09-26 62
9f04b9e327c495 include/asm-powerpc/reg.h Paul Mackerras 2005-10-10 63 #ifdef __ASSEMBLY__
9f04b9e327c495 include/asm-powerpc/reg.h Paul Mackerras 2005-10-10 64 #define __MASK(X) (1<<(X))
9f04b9e327c495 include/asm-powerpc/reg.h Paul Mackerras 2005-10-10 65 #else
9f04b9e327c495 include/asm-powerpc/reg.h Paul Mackerras 2005-10-10 @66 #define __MASK(X) (1UL<<(X))
9f04b9e327c495 include/asm-powerpc/reg.h Paul Mackerras 2005-10-10 67 #endif
9f04b9e327c495 include/asm-powerpc/reg.h Paul Mackerras 2005-10-10 68
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year
[frank-w-bpi-r2-4.14:5.10-main 6/34] drivers/pci/probe.c:929:39: error: no member named 'msi_domain' in 'struct device'; did you mean 'pm_domain'?
by kernel test robot
tree: https://github.com/frank-w/BPI-R2-4.14 5.10-main
head: e2d611389c10351ed2caab346dca9f8f2cb9af60
commit: aae45a226341c84a12b431abb7904bb39cac53c2 [6/34] pci: fix MSI issue part 2
config: x86_64-randconfig-a002-20210912 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 261cbe98c38f8c1ee1a482fe76511110e790f58a)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/frank-w/BPI-R2-4.14/commit/aae45a226341c84a12b431abb79...
git remote add frank-w-bpi-r2-4.14 https://github.com/frank-w/BPI-R2-4.14
git fetch --no-tags frank-w-bpi-r2-4.14 5.10-main
git checkout aae45a226341c84a12b431abb7904bb39cac53c2
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> drivers/pci/probe.c:929:39: error: no member named 'msi_domain' in 'struct device'; did you mean 'pm_domain'?
(bridge->msi_domain && !bus->dev.msi_domain))
^~~~~~~~~~
pm_domain
include/linux/device.h:486:24: note: 'pm_domain' declared here
struct dev_pm_domain *pm_domain;
^
1 error generated.
vim +929 drivers/pci/probe.c
903
904 b = pci_find_bus(pci_domain_nr(bus), bridge->busnr);
905 if (b) {
906 /* Ignore it if we already got here via a different bridge */
907 dev_dbg(&b->dev, "bus already known\n");
908 err = -EEXIST;
909 goto free;
910 }
911
912 dev_set_name(&bridge->dev, "pci%04x:%02x", pci_domain_nr(bus),
913 bridge->busnr);
914
915 err = pcibios_root_bridge_prepare(bridge);
916 if (err)
917 goto free;
918
919 err = device_add(&bridge->dev);
920 if (err) {
921 put_device(&bridge->dev);
922 goto free;
923 }
924 bus->bridge = get_device(&bridge->dev);
925 device_enable_async_suspend(bus->bridge);
926 pci_set_bus_of_node(bus);
927 pci_set_bus_msi_domain(bus);
928 if (bridge->no_msi ||
> 929 (bridge->msi_domain && !bus->dev.msi_domain))
930 bus->bus_flags |= PCI_BUS_FLAGS_NO_MSI;
931
932 if (!parent)
933 set_dev_node(bus->bridge, pcibus_to_node(bus));
934
935 bus->dev.class = &pcibus_class;
936 bus->dev.parent = bus->bridge;
937
938 dev_set_name(&bus->dev, "%04x:%02x", pci_domain_nr(bus), bus->number);
939 name = dev_name(&bus->dev);
940
941 err = device_register(&bus->dev);
942 if (err)
943 goto unregister;
944
945 pcibios_add_bus(bus);
946
947 if (bus->ops->add_bus) {
948 err = bus->ops->add_bus(bus);
949 if (WARN_ON(err < 0))
950 dev_err(&bus->dev, "failed to add bus: %d\n", err);
951 }
952
953 /* Create legacy_io and legacy_mem files for this bus */
954 pci_create_legacy_files(bus);
955
956 if (parent)
957 dev_info(parent, "PCI host bridge to bus %s\n", name);
958 else
959 pr_info("PCI host bridge to bus %s\n", name);
960
961 if (nr_node_ids > 1 && pcibus_to_node(bus) == NUMA_NO_NODE)
962 dev_warn(&bus->dev, "Unknown NUMA node; performance will be reduced\n");
963
964 /* Add initial resources to the bus */
965 resource_list_for_each_entry_safe(window, n, &resources) {
966 list_move_tail(&window->node, &bridge->windows);
967 offset = window->offset;
968 res = window->res;
969
970 if (res->flags & IORESOURCE_BUS)
971 pci_bus_insert_busn_res(bus, bus->number, res->end);
972 else
973 pci_bus_add_resource(bus, res, 0);
974
975 if (offset) {
976 if (resource_type(res) == IORESOURCE_IO)
977 fmt = " (bus address [%#06llx-%#06llx])";
978 else
979 fmt = " (bus address [%#010llx-%#010llx])";
980
981 snprintf(addr, sizeof(addr), fmt,
982 (unsigned long long)(res->start - offset),
983 (unsigned long long)(res->end - offset));
984 } else
985 addr[0] = '\0';
986
987 dev_info(&bus->dev, "root bus resource %pR%s\n", res, addr);
988 }
989
990 down_write(&pci_bus_sem);
991 list_add_tail(&bus->node, &pci_root_buses);
992 up_write(&pci_bus_sem);
993
994 return 0;
995
996 unregister:
997 put_device(&bridge->dev);
998 device_del(&bridge->dev);
999
1000 free:
1001 kfree(bus);
1002 return err;
1003 }
1004
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year
