Re: [PATCH][next] ALSA: usb-audio: scarlett2: Use struct_size() helper in scarlett2_usb()
by kernel test robot
Hi "Gustavo,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on tiwai-sound/for-next]
[also build test WARNING on v5.16 next-20220118]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Gustavo-A-R-Silva/ALSA-usb-audio...
base: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next
config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20220120/202201201043.0reWtM98-lk...)
compiler: m68k-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/1696152f12c0a7d23ccd5e228f9d08f7b...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Gustavo-A-R-Silva/ALSA-usb-audio-scarlett2-Use-struct_size-helper-in-scarlett2_usb/20220120-080908
git checkout 1696152f12c0a7d23ccd5e228f9d08f7bd2da83a
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=m68k SHELL=/bin/bash sound/usb/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
In file included from include/linux/device.h:15,
from include/linux/usb/ch9.h:36,
from include/linux/usb.h:6,
from sound/usb/mixer_scarlett_gen2.c:126:
sound/usb/mixer_scarlett_gen2.c: In function 'scarlett2_usb':
>> sound/usb/mixer_scarlett_gen2.c:1113:25: warning: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'size_t' {aka 'unsigned int'} [-Wformat=]
1113 | "Scarlett Gen 2/3 USB response result cmd %x was %d "
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~
include/linux/dev_printk.h:144:56: note: in expansion of macro 'dev_fmt'
144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
sound/usb/usbaudio.h:67:9: note: in expansion of macro 'dev_err'
67 | dev_err(&(chip)->dev->dev, fmt, ##args)
| ^~~~~~~
sound/usb/mixer_scarlett_gen2.c:1111:17: note: in expansion of macro 'usb_audio_err'
1111 | usb_audio_err(
| ^~~~~~~~~~~~~
vim +1113 sound/usb/mixer_scarlett_gen2.c
1f7fa6e5afbf20 Geoffrey D. Bennett 2021-06-22 1056
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1057 /* Send a proprietary format request to the Scarlett interface */
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1058 static int scarlett2_usb(
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1059 struct usb_mixer_interface *mixer, u32 cmd,
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1060 void *req_data, u16 req_size, void *resp_data, u16 resp_size)
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1061 {
e46f2195c86b00 Geoffrey D. Bennett 2021-06-21 1062 struct scarlett2_data *private = mixer->private_data;
1f7fa6e5afbf20 Geoffrey D. Bennett 2021-06-22 1063 struct usb_device *dev = mixer->chip->dev;
b677b6c6d82248 Geoffrey D. Bennett 2021-06-21 1064 struct scarlett2_usb_packet *req, *resp = NULL;
1696152f12c0a7 Gustavo A. R. Silva 2022-01-19 1065 size_t req_buf_size = struct_size(req, data, req_size);
1696152f12c0a7 Gustavo A. R. Silva 2022-01-19 1066 size_t resp_buf_size = struct_size(resp, data, resp_size);
b677b6c6d82248 Geoffrey D. Bennett 2021-06-21 1067 int err;
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1068
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1069 req = kmalloc(req_buf_size, GFP_KERNEL);
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1070 if (!req) {
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1071 err = -ENOMEM;
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1072 goto error;
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1073 }
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1074
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1075 resp = kmalloc(resp_buf_size, GFP_KERNEL);
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1076 if (!resp) {
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1077 err = -ENOMEM;
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1078 goto error;
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1079 }
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1080
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1081 mutex_lock(&private->usb_mutex);
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1082
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1083 /* build request message and send it */
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1084
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1085 scarlett2_fill_request_header(private, req, cmd, req_size);
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1086
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1087 if (req_size)
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1088 memcpy(req->data, req_data, req_size);
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1089
1f7fa6e5afbf20 Geoffrey D. Bennett 2021-06-22 1090 err = scarlett2_usb_tx(dev, private->bInterfaceNumber,
1f7fa6e5afbf20 Geoffrey D. Bennett 2021-06-22 1091 req, req_buf_size);
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1092
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1093 if (err != req_buf_size) {
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1094 usb_audio_err(
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1095 mixer->chip,
4be47798d76e6e Geoffrey D. Bennett 2021-06-23 1096 "Scarlett Gen 2/3 USB request result cmd %x was %d\n",
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1097 cmd, err);
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1098 err = -EINVAL;
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1099 goto unlock;
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1100 }
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1101
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1102 /* send a second message to get the response */
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1103
1f7fa6e5afbf20 Geoffrey D. Bennett 2021-06-22 1104 err = scarlett2_usb_rx(dev, private->bInterfaceNumber,
1f7fa6e5afbf20 Geoffrey D. Bennett 2021-06-22 1105 SCARLETT2_USB_CMD_RESP,
1f7fa6e5afbf20 Geoffrey D. Bennett 2021-06-22 1106 resp, resp_buf_size);
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1107
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1108 /* validate the response */
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1109
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1110 if (err != resp_buf_size) {
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1111 usb_audio_err(
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1112 mixer->chip,
4be47798d76e6e Geoffrey D. Bennett 2021-06-23 @1113 "Scarlett Gen 2/3 USB response result cmd %x was %d "
1696152f12c0a7 Gustavo A. R. Silva 2022-01-19 1114 "expected %lu\n",
acf91b8122c7f6 Geoffrey D. Bennett 2021-06-22 1115 cmd, err, resp_buf_size);
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1116 err = -EINVAL;
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1117 goto unlock;
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1118 }
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1119
acf91b8122c7f6 Geoffrey D. Bennett 2021-06-22 1120 /* cmd/seq/size should match except when initialising
acf91b8122c7f6 Geoffrey D. Bennett 2021-06-22 1121 * seq sent = 1, response = 0
acf91b8122c7f6 Geoffrey D. Bennett 2021-06-22 1122 */
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1123 if (resp->cmd != req->cmd ||
acf91b8122c7f6 Geoffrey D. Bennett 2021-06-22 1124 (resp->seq != req->seq &&
acf91b8122c7f6 Geoffrey D. Bennett 2021-06-22 1125 (le16_to_cpu(req->seq) != 1 || resp->seq != 0)) ||
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1126 resp_size != le16_to_cpu(resp->size) ||
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1127 resp->error ||
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1128 resp->pad) {
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1129 usb_audio_err(
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1130 mixer->chip,
4be47798d76e6e Geoffrey D. Bennett 2021-06-23 1131 "Scarlett Gen 2/3 USB invalid response; "
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1132 "cmd tx/rx %d/%d seq %d/%d size %d/%d "
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1133 "error %d pad %d\n",
d8f489355cff55 Takashi Iwai 2020-02-01 1134 le32_to_cpu(req->cmd), le32_to_cpu(resp->cmd),
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1135 le16_to_cpu(req->seq), le16_to_cpu(resp->seq),
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1136 resp_size, le16_to_cpu(resp->size),
d8f489355cff55 Takashi Iwai 2020-02-01 1137 le32_to_cpu(resp->error),
d8f489355cff55 Takashi Iwai 2020-02-01 1138 le32_to_cpu(resp->pad));
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1139 err = -EINVAL;
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1140 goto unlock;
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1141 }
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1142
acf91b8122c7f6 Geoffrey D. Bennett 2021-06-22 1143 if (resp_data && resp_size > 0)
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1144 memcpy(resp_data, resp->data, resp_size);
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1145
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1146 unlock:
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1147 mutex_unlock(&private->usb_mutex);
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1148 error:
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1149 kfree(req);
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1150 kfree(resp);
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1151 return err;
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1152 }
9e4d5c1be21f0c Geoffrey D. Bennett 2019-07-29 1153
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
8 months
[jpirko-mlxsw:ubridge 73/78] drivers/net/ethernet/mellanox/mlxsw/spectrum_fid.c:461:12: warning: stack frame size (1092) exceeds limit (1024) in 'mlxsw_sp_fid_erif_eport_to_vid_map'
by kernel test robot
tree: https://github.com/jpirko/linux_mlxsw ubridge
head: 976afb368c2f7efc2dc2436013895cc96ab06774
commit: 6e0855a9b3824d98f266ac39a1a19c7bce925cd2 [73/78] mlxsw: spectrum_fid: Configure layer 3 egress VID classification
config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20220120/202201201030.HA2UgQTx-lk...)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project f7b7138a62648f4019c55e4671682af1f851f295)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/jpirko/linux_mlxsw/commit/6e0855a9b3824d98f266ac39a1a1...
git remote add jpirko-mlxsw https://github.com/jpirko/linux_mlxsw
git fetch --no-tags jpirko-mlxsw ubridge
git checkout 6e0855a9b3824d98f266ac39a1a19c7bce925cd2
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/net/ethernet/mellanox/mlxsw/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/net/ethernet/mellanox/mlxsw/spectrum_fid.c:461:12: warning: stack frame size (1092) exceeds limit (1024) in 'mlxsw_sp_fid_erif_eport_to_vid_map' [-Wframe-larger-than]
static int mlxsw_sp_fid_erif_eport_to_vid_map(struct mlxsw_sp_fid *fid,
^
>> drivers/net/ethernet/mellanox/mlxsw/spectrum_fid.c:689:12: warning: stack frame size (1116) exceeds limit (1024) in '__mlxsw_sp_fid_port_vid_map' [-Wframe-larger-than]
static int __mlxsw_sp_fid_port_vid_map(const struct mlxsw_sp_fid *fid,
^
2 warnings generated.
vim +/mlxsw_sp_fid_erif_eport_to_vid_map +461 drivers/net/ethernet/mellanox/mlxsw/spectrum_fid.c
460
> 461 static int mlxsw_sp_fid_erif_eport_to_vid_map(struct mlxsw_sp_fid *fid,
462 u16 rif_index, bool valid)
463 {
464 struct mlxsw_sp *mlxsw_sp = fid->fid_family->mlxsw_sp;
465 struct mlxsw_sp_fid_port_vid *port_vid, *tmp;
466 char reiv_pl[MLXSW_REG_REIV_LEN] = {};
467 bool records_to_write = false;
468 u8 rec_num, current_page = 0;
469 u16 last_local_port;
470 int err;
471
472 mlxsw_reg_reiv_pack(reiv_pl, current_page, rif_index);
473 last_local_port = current_page * MLXSW_REG_REIV_REC_MAX_COUNT +
474 MLXSW_REG_REIV_REC_MAX_COUNT - 1;
475
476 list_for_each_entry_safe(port_vid, tmp, &fid->port_vid_list, list) {
477 /* The list is sorted by local_port. */
478 if (port_vid->local_port > last_local_port)
479 goto reg_write;
480
481 new_record_fill:
482 rec_num = port_vid->local_port % MLXSW_REG_REIV_REC_MAX_COUNT;
483 mlxsw_reg_reiv_rec_update_set(reiv_pl, rec_num, true);
484 mlxsw_reg_reiv_rec_evid_set(reiv_pl, rec_num,
485 valid ? port_vid->vid : 0);
486 records_to_write = true;
487 goto next_list_node;
488
489 reg_write:
490 err = mlxsw_reg_write(mlxsw_sp->core, MLXSW_REG(reiv), reiv_pl);
491 if (err)
492 return err;
493
494 records_to_write = false;
495 current_page++;
496 memset(reiv_pl, 0, MLXSW_REG_REIV_LEN);
497 mlxsw_reg_reiv_pack(reiv_pl, current_page, rif_index);
498 last_local_port = current_page * MLXSW_REG_REIV_REC_MAX_COUNT +
499 MLXSW_REG_REIV_REC_MAX_COUNT - 1;
500 goto new_record_fill;
501
502 next_list_node:
503 continue;
504 }
505
506 if (records_to_write)
507 return mlxsw_reg_write(mlxsw_sp->core, MLXSW_REG(reiv),
508 reiv_pl);
509 return 0;
510 }
511
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
8 months
[android-common:upstream-f2fs-stable-linux-4.14.y 927/1431] include/linux/kern_levels.h:5:18: warning: format '%lu' expects argument of type 'long unsigned int', but argument 6 has type 'blkcnt_t {aka long long unsigned int}'
by kernel test robot
tree: https://android.googlesource.com/kernel/common upstream-f2fs-stable-linux-4.14.y
head: a1f8c5458f03b609b124191a55118e9c11109442
commit: 285ad248f6744133988a915887f1ec35f980ee74 [927/1431] f2fs: fix to check i_compr_blocks correctly
config: i386-randconfig-a001-20220117 (https://download.01.org/0day-ci/archive/20220120/202201200957.Gz4xTPFP-lk...)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build):
git remote add android-common https://android.googlesource.com/kernel/common
git fetch --no-tags android-common upstream-f2fs-stable-linux-4.14.y
git checkout 285ad248f6744133988a915887f1ec35f980ee74
# save the config file to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash fs/f2fs/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
In file included from include/linux/printk.h:7:0,
from include/linux/kernel.h:14,
from include/linux/list.h:9,
from include/linux/wait.h:7,
from include/linux/wait_bit.h:8,
from include/linux/fs.h:6,
from fs/f2fs/inode.c:8:
fs/f2fs/inode.c: In function 'sanity_check_inode':
>> include/linux/kern_levels.h:5:18: warning: format '%lu' expects argument of type 'long unsigned int', but argument 6 has type 'blkcnt_t {aka long long unsigned int}' [-Wformat=]
#define KERN_SOH "\001" /* ASCII Start Of Header */
^
include/linux/kern_levels.h:12:22: note: in expansion of macro 'KERN_SOH'
#define KERN_WARNING KERN_SOH "4" /* warning conditions */
^~~~~~~~
fs/f2fs/f2fs.h:1947:19: note: in expansion of macro 'KERN_WARNING'
f2fs_printk(sbi, KERN_WARNING fmt, ##__VA_ARGS__)
^~~~~~~~~~~~
fs/f2fs/inode.c:303:4: note: in expansion of macro 'f2fs_warn'
f2fs_warn(sbi, "%s: inode (ino=%lx) has inconsistent "
^~~~~~~~~
fs/f2fs/inode.c:304:38: note: format string is defined here
"i_compr_blocks:%llu, i_blocks:%lu, run fsck to fix",
~~^
%llu
vim +5 include/linux/kern_levels.h
314ba3520e513a7 Joe Perches 2012-07-30 4
04d2c8c83d0e3ac Joe Perches 2012-07-30 @5 #define KERN_SOH "\001" /* ASCII Start Of Header */
04d2c8c83d0e3ac Joe Perches 2012-07-30 6 #define KERN_SOH_ASCII '\001'
04d2c8c83d0e3ac Joe Perches 2012-07-30 7
:::::: The code at line 5 was first introduced by commit
:::::: 04d2c8c83d0e3ac5f78aeede51babb3236200112 printk: convert the format for KERN_<LEVEL> to a 2 byte pattern
:::::: TO: Joe Perches <joe(a)perches.com>
:::::: CC: Linus Torvalds <torvalds(a)linux-foundation.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
8 months
[mnyman-xhci:dbc 5/5] drivers/usb/host/xhci-dbgtty.c:423 xhci_dbc_tty_register_device() warn: unsigned 'port->minor' is never less than zero.
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mnyman/xhci.git dbc
head: 595547d1cfa3f6c591ea084cc1f77cd45bd81213
commit: 595547d1cfa3f6c591ea084cc1f77cd45bd81213 [5/5] xhci: dbgtty: use IDR to support several dbc instances.
config: riscv-randconfig-m031-20220118 (https://download.01.org/0day-ci/archive/20220120/202201200955.C9pzrtCw-lk...)
compiler: riscv32-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
smatch warnings:
drivers/usb/host/xhci-dbgtty.c:423 xhci_dbc_tty_register_device() warn: unsigned 'port->minor' is never less than zero.
vim +423 drivers/usb/host/xhci-dbgtty.c
407
408 static int xhci_dbc_tty_register_device(struct xhci_dbc *dbc)
409 {
410 int ret;
411 struct device *tty_dev;
412 struct dbc_port *port = dbc_to_port(dbc);
413
414 if (port->registered)
415 return -EBUSY;
416
417 xhci_dbc_tty_init_port(dbc, port);
418
419 mutex_lock(&dbc_tty_minors_lock);
420 port->minor = idr_alloc(&dbc_tty_minors, port, 0, 64, GFP_KERNEL);
421 mutex_unlock(&dbc_tty_minors_lock);
422
> 423 if (port->minor < 0) {
424 ret = port->minor;
425 goto err_idr;
426 }
427
428 ret = kfifo_alloc(&port->write_fifo, DBC_WRITE_BUF_SIZE, GFP_KERNEL);
429 if (ret)
430 goto err_exit_port;
431
432 ret = xhci_dbc_alloc_requests(dbc, BULK_IN, &port->read_pool,
433 dbc_read_complete);
434 if (ret)
435 goto err_free_fifo;
436
437 ret = xhci_dbc_alloc_requests(dbc, BULK_OUT, &port->write_pool,
438 dbc_write_complete);
439 if (ret)
440 goto err_free_requests;
441
442 tty_dev = tty_port_register_device(&port->port,
443 dbc_tty_driver, port->minor, NULL);
444 if (IS_ERR(tty_dev)) {
445 ret = PTR_ERR(tty_dev);
446 goto err_free_requests;
447 }
448
449 port->registered = true;
450
451 return 0;
452
453 err_free_requests:
454 xhci_dbc_free_requests(&port->read_pool);
455 xhci_dbc_free_requests(&port->write_pool);
456 err_free_fifo:
457 kfifo_free(&port->write_fifo);
458 err_exit_port:
459 idr_remove(&dbc_tty_minors, port->minor);
460 err_idr:
461 xhci_dbc_tty_exit_port(port);
462
463 dev_err(dbc->dev, "can't register tty port, err %d\n", ret);
464
465 return ret;
466 }
467
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
8 months
[jpirko-mlxsw:ubridge 63/78] drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c:2652:6: warning: variable 'vid' is used uninitialized whenever 'if' condition is true
by kernel test robot
tree: https://github.com/jpirko/linux_mlxsw ubridge
head: 976afb368c2f7efc2dc2436013895cc96ab06774
commit: 126a17e336358fd81470d0a19b64130234eca122 [63/78] mlxsw: Configure egress VID for unicast FDB entries
config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20220120/202201200839.oo2R9DV2-lk...)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project f7b7138a62648f4019c55e4671682af1f851f295)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/jpirko/linux_mlxsw/commit/126a17e336358fd81470d0a19b64...
git remote add jpirko-mlxsw https://github.com/jpirko/linux_mlxsw
git fetch --no-tags jpirko-mlxsw ubridge
git checkout 126a17e336358fd81470d0a19b64130234eca122
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/net/ethernet/mellanox/mlxsw/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c:2652:6: warning: variable 'vid' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
if (!bridge_port) {
^~~~~~~~~~~~
drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c:2661:64: note: uninitialized use occurs here
err = mlxsw_sp_port_fdb_uc_op(mlxsw_sp, local_port, mac, fid, vid,
^~~
drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c:2652:2: note: remove the 'if' if its condition is always false
if (!bridge_port) {
^~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c:2646:6: warning: variable 'vid' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
if (!mlxsw_sp_port_vlan) {
^~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c:2661:64: note: uninitialized use occurs here
err = mlxsw_sp_port_fdb_uc_op(mlxsw_sp, local_port, mac, fid, vid,
^~~
drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c:2646:2: note: remove the 'if' if its condition is always false
if (!mlxsw_sp_port_vlan) {
^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c:2642:6: warning: variable 'vid' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
if (mlxsw_sp_fid_is_dummy(mlxsw_sp, fid))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c:2661:64: note: uninitialized use occurs here
err = mlxsw_sp_port_fdb_uc_op(mlxsw_sp, local_port, mac, fid, vid,
^~~
drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c:2642:2: note: remove the 'if' if its condition is always false
if (mlxsw_sp_fid_is_dummy(mlxsw_sp, fid))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c:2637:6: warning: variable 'vid' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
if (!mlxsw_sp_port) {
^~~~~~~~~~~~~~
drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c:2661:64: note: uninitialized use occurs here
err = mlxsw_sp_port_fdb_uc_op(mlxsw_sp, local_port, mac, fid, vid,
^~~
drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c:2637:2: note: remove the 'if' if its condition is always false
if (!mlxsw_sp_port) {
^~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c:2628:9: note: initialize the variable 'vid' to silence this warning
u16 vid, fid;
^
= 0
4 warnings generated.
vim +2652 drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c
8a1ab5d766396aa Jiri Pirko 2015-12-03 2616
56ade8fe3fe1e13 Jiri Pirko 2015-10-16 2617 static void mlxsw_sp_fdb_notify_mac_process(struct mlxsw_sp *mlxsw_sp,
56ade8fe3fe1e13 Jiri Pirko 2015-10-16 2618 char *sfn_pl, int rec_index,
56ade8fe3fe1e13 Jiri Pirko 2015-10-16 2619 bool adding)
56ade8fe3fe1e13 Jiri Pirko 2015-10-16 2620 {
c57529e1d5d882f Ido Schimmel 2017-05-26 2621 struct mlxsw_sp_port_vlan *mlxsw_sp_port_vlan;
c57529e1d5d882f Ido Schimmel 2017-05-26 2622 struct mlxsw_sp_bridge_device *bridge_device;
c57529e1d5d882f Ido Schimmel 2017-05-26 2623 struct mlxsw_sp_bridge_port *bridge_port;
56ade8fe3fe1e13 Jiri Pirko 2015-10-16 2624 struct mlxsw_sp_port *mlxsw_sp_port;
1b40dc3d86724c7 Arkadi Sharshevsky 2017-06-08 2625 enum switchdev_notifier_type type;
56ade8fe3fe1e13 Jiri Pirko 2015-10-16 2626 char mac[ETH_ALEN];
c934757d90000a9 Amit Cohen 2021-12-01 2627 u16 local_port;
9de6a80e061238d Ido Schimmel 2015-12-15 2628 u16 vid, fid;
12f1501e7511958 Jiri Pirko 2016-01-07 2629 bool do_notification = true;
56ade8fe3fe1e13 Jiri Pirko 2015-10-16 2630 int err;
56ade8fe3fe1e13 Jiri Pirko 2015-10-16 2631
9de6a80e061238d Ido Schimmel 2015-12-15 2632 mlxsw_reg_sfn_mac_unpack(sfn_pl, rec_index, mac, &fid, &local_port);
837ec05cfea0828 Danielle Ratson 2021-05-17 2633
c49bf28ae363005 Amit Cohen 2022-01-17 2634 if (WARN_ON_ONCE(!mlxsw_sp_local_port_is_valid(mlxsw_sp, local_port)))
837ec05cfea0828 Danielle Ratson 2021-05-17 2635 return;
56ade8fe3fe1e13 Jiri Pirko 2015-10-16 2636 mlxsw_sp_port = mlxsw_sp->ports[local_port];
56ade8fe3fe1e13 Jiri Pirko 2015-10-16 2637 if (!mlxsw_sp_port) {
56ade8fe3fe1e13 Jiri Pirko 2015-10-16 2638 dev_err_ratelimited(mlxsw_sp->bus_info->dev, "Incorrect local port in FDB notification\n");
12f1501e7511958 Jiri Pirko 2016-01-07 2639 goto just_remove;
56ade8fe3fe1e13 Jiri Pirko 2015-10-16 2640 }
56ade8fe3fe1e13 Jiri Pirko 2015-10-16 2641
577fa14d210073b Ido Schimmel 2019-07-17 2642 if (mlxsw_sp_fid_is_dummy(mlxsw_sp, fid))
577fa14d210073b Ido Schimmel 2019-07-17 2643 goto just_remove;
577fa14d210073b Ido Schimmel 2019-07-17 2644
c57529e1d5d882f Ido Schimmel 2017-05-26 2645 mlxsw_sp_port_vlan = mlxsw_sp_port_vlan_find_by_fid(mlxsw_sp_port, fid);
c57529e1d5d882f Ido Schimmel 2017-05-26 2646 if (!mlxsw_sp_port_vlan) {
c57529e1d5d882f Ido Schimmel 2017-05-26 2647 netdev_err(mlxsw_sp_port->dev, "Failed to find a matching {Port, VID} following FDB notification\n");
12f1501e7511958 Jiri Pirko 2016-01-07 2648 goto just_remove;
aac78a44088728f Ido Schimmel 2015-12-15 2649 }
c57529e1d5d882f Ido Schimmel 2017-05-26 2650
c57529e1d5d882f Ido Schimmel 2017-05-26 2651 bridge_port = mlxsw_sp_port_vlan->bridge_port;
c57529e1d5d882f Ido Schimmel 2017-05-26 @2652 if (!bridge_port) {
c57529e1d5d882f Ido Schimmel 2017-05-26 2653 netdev_err(mlxsw_sp_port->dev, "{Port, VID} not associated with a bridge\n");
c57529e1d5d882f Ido Schimmel 2017-05-26 2654 goto just_remove;
aac78a44088728f Ido Schimmel 2015-12-15 2655 }
aac78a44088728f Ido Schimmel 2015-12-15 2656
c57529e1d5d882f Ido Schimmel 2017-05-26 2657 bridge_device = bridge_port->bridge_device;
c57529e1d5d882f Ido Schimmel 2017-05-26 2658 vid = bridge_device->vlan_enabled ? mlxsw_sp_port_vlan->vid : 0;
c57529e1d5d882f Ido Schimmel 2017-05-26 2659
12f1501e7511958 Jiri Pirko 2016-01-07 2660 do_fdb_op:
126a17e336358fd Amit Cohen 2022-01-04 2661 err = mlxsw_sp_port_fdb_uc_op(mlxsw_sp, local_port, mac, fid, vid,
12f1501e7511958 Jiri Pirko 2016-01-07 2662 adding, true);
56ade8fe3fe1e13 Jiri Pirko 2015-10-16 2663 if (err) {
c0e01eac7ada785 Ido Schimmel 2017-05-18 2664 dev_err_ratelimited(mlxsw_sp->bus_info->dev, "Failed to set FDB entry\n");
56ade8fe3fe1e13 Jiri Pirko 2015-10-16 2665 return;
56ade8fe3fe1e13 Jiri Pirko 2015-10-16 2666 }
56ade8fe3fe1e13 Jiri Pirko 2015-10-16 2667
12f1501e7511958 Jiri Pirko 2016-01-07 2668 if (!do_notification)
12f1501e7511958 Jiri Pirko 2016-01-07 2669 return;
1b40dc3d86724c7 Arkadi Sharshevsky 2017-06-08 2670 type = adding ? SWITCHDEV_FDB_ADD_TO_BRIDGE : SWITCHDEV_FDB_DEL_TO_BRIDGE;
e9ba0fbc7dd23a7 Ido Schimmel 2018-10-17 2671 mlxsw_sp_fdb_call_notifiers(type, mac, vid, bridge_port->dev, adding);
a989cdb473c2fd9 Arkadi Sharshevsky 2017-06-08 2672
12f1501e7511958 Jiri Pirko 2016-01-07 2673 return;
12f1501e7511958 Jiri Pirko 2016-01-07 2674
12f1501e7511958 Jiri Pirko 2016-01-07 2675 just_remove:
12f1501e7511958 Jiri Pirko 2016-01-07 2676 adding = false;
12f1501e7511958 Jiri Pirko 2016-01-07 2677 do_notification = false;
12f1501e7511958 Jiri Pirko 2016-01-07 2678 goto do_fdb_op;
8a1ab5d766396aa Jiri Pirko 2015-12-03 2679 }
56ade8fe3fe1e13 Jiri Pirko 2015-10-16 2680
:::::: The code at line 2652 was first introduced by commit
:::::: c57529e1d5d882fbd6383163e2cb2e4ba3118174 mlxsw: spectrum: Replace vPorts with Port-VLAN
:::::: TO: Ido Schimmel <idosch(a)mellanox.com>
:::::: CC: David S. Miller <davem(a)davemloft.net>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
8 months
drivers/cxl/core/mbox.c:330:6: error: unexpected token, expected comma
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 1d1df41c5a33359a00e919d54eaebfb789711fdc
commit: 4faf31b43468c58e2c8c91cc5fa26f08a6b733be cxl/mbox: Move mailbox and other non-PCI specific infrastructure to the core
date: 4 months ago
config: mips-randconfig-r003-20220118 (https://download.01.org/0day-ci/archive/20220120/202201200842.QCcshg1P-lk...)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 5f782d25a742302d25ef3c8b84b54f7483c2deb9)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install mips cross compiling tool for clang build
# apt-get install binutils-mips-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit...
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 4faf31b43468c58e2c8c91cc5fa26f08a6b733be
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash drivers/cxl/core/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> drivers/cxl/core/mbox.c:330:6: error: unexpected token, expected comma
if (get_user(n_commands, &q->n_commands))
^
arch/mips/include/asm/uaccess.h:138:33: note: expanded from macro 'get_user'
access_ok(__p, sizeof(*__p)) ? __get_user((x), __p) : \
^
arch/mips/include/asm/uaccess.h:224:23: note: expanded from macro '__get_user'
__get_data_asm((x), user_lw, __gu_ptr); \
^
<inline asm>:3:10: note: instantiated into assembly here
.set eva
^
>> drivers/cxl/core/mbox.c:330:6: error: invalid operand for instruction
if (get_user(n_commands, &q->n_commands))
^
arch/mips/include/asm/uaccess.h:138:33: note: expanded from macro 'get_user'
access_ok(__p, sizeof(*__p)) ? __get_user((x), __p) : \
^
arch/mips/include/asm/uaccess.h:224:23: note: expanded from macro '__get_user'
__get_data_asm((x), user_lw, __gu_ptr); \
^
<inline asm>:4:10: note: instantiated into assembly here
lwe $4, 0($16)
^
drivers/cxl/core/mbox.c:335:10: error: unexpected token, expected comma
return put_user(cxl_cmd_count, &q->n_commands);
^
arch/mips/include/asm/uaccess.h:112:33: note: expanded from macro 'put_user'
access_ok(__p, sizeof(*__p)) ? __put_user((x), __p) : -EFAULT; \
^
arch/mips/include/asm/uaccess.h:177:18: note: expanded from macro '__put_user'
__put_data_asm(user_sw, __pu_ptr); \
^
<inline asm>:3:10: note: instantiated into assembly here
.set eva
^
drivers/cxl/core/mbox.c:335:10: error: invalid operand for instruction
return put_user(cxl_cmd_count, &q->n_commands);
^
arch/mips/include/asm/uaccess.h:112:33: note: expanded from macro 'put_user'
access_ok(__p, sizeof(*__p)) ? __put_user((x), __p) : -EFAULT; \
^
arch/mips/include/asm/uaccess.h:177:18: note: expanded from macro '__put_user'
__put_data_asm(user_sw, __pu_ptr); \
^
<inline asm>:4:10: note: instantiated into assembly here
swe $3, 0($16)
^
4 errors generated.
vim +330 drivers/cxl/core/mbox.c
319
320 int cxl_query_cmd(struct cxl_memdev *cxlmd,
321 struct cxl_mem_query_commands __user *q)
322 {
323 struct device *dev = &cxlmd->dev;
324 struct cxl_mem_command *cmd;
325 u32 n_commands;
326 int j = 0;
327
328 dev_dbg(dev, "Query IOCTL\n");
329
> 330 if (get_user(n_commands, &q->n_commands))
331 return -EFAULT;
332
333 /* returns the total number if 0 elements are requested. */
334 if (n_commands == 0)
335 return put_user(cxl_cmd_count, &q->n_commands);
336
337 /*
338 * otherwise, return max(n_commands, total commands) cxl_command_info
339 * structures.
340 */
341 cxl_for_each_cmd(cmd) {
342 const struct cxl_command_info *info = &cmd->info;
343
344 if (copy_to_user(&q->commands[j++], info, sizeof(*info)))
345 return -EFAULT;
346
347 if (j == n_commands)
348 break;
349 }
350
351 return 0;
352 }
353
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
8 months
[android-common:upstream-f2fs-stable-linux-5.4.y 665/703] fs/ubifs/file.c:1644:16: error: passing argument 1 of 'ubifs_getattr' from incompatible pointer type
by kernel test robot
Hi Eric,
FYI, the error/warning still remains.
tree: https://android.googlesource.com/kernel/common upstream-f2fs-stable-linux-5.4.y
head: b85eb593dc0ffde2c8ae4e91485fc022841aa97f
commit: 0e764ea6471e002f101dd7726b6e97f0e55c2288 [665/703] ubifs: report correct st_size for encrypted symlinks
config: x86_64-allmodconfig (https://download.01.org/0day-ci/archive/20220120/202201200700.LUVQAZXU-lk...)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
git remote add android-common https://android.googlesource.com/kernel/common
git fetch --no-tags android-common upstream-f2fs-stable-linux-5.4.y
git checkout 0e764ea6471e002f101dd7726b6e97f0e55c2288
# save the config file to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash fs/ubifs/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All error/warnings (new ones prefixed by >>):
fs/ubifs/file.c: In function 'ubifs_symlink_getattr':
>> fs/ubifs/file.c:1644:16: error: passing argument 1 of 'ubifs_getattr' from incompatible pointer type [-Werror=incompatible-pointer-types]
1644 | ubifs_getattr(mnt_userns, path, stat, request_mask, query_flags);
| ^~~~~~~~~~
| |
| struct user_namespace *
In file included from fs/ubifs/file.c:40:
fs/ubifs/ubifs.h:1997:38: note: expected 'const struct path *' but argument is of type 'struct user_namespace *'
1997 | int ubifs_getattr(const struct path *path, struct kstat *stat,
| ~~~~~~~~~~~~~~~~~~~^~~~
fs/ubifs/file.c:1644:28: error: passing argument 2 of 'ubifs_getattr' from incompatible pointer type [-Werror=incompatible-pointer-types]
1644 | ubifs_getattr(mnt_userns, path, stat, request_mask, query_flags);
| ^~~~
| |
| const struct path *
In file included from fs/ubifs/file.c:40:
fs/ubifs/ubifs.h:1997:58: note: expected 'struct kstat *' but argument is of type 'const struct path *'
1997 | int ubifs_getattr(const struct path *path, struct kstat *stat,
| ~~~~~~~~~~~~~~^~~~
>> fs/ubifs/file.c:1644:34: warning: passing argument 3 of 'ubifs_getattr' makes integer from pointer without a cast [-Wint-conversion]
1644 | ubifs_getattr(mnt_userns, path, stat, request_mask, query_flags);
| ^~~~
| |
| struct kstat *
In file included from fs/ubifs/file.c:40:
fs/ubifs/ubifs.h:1998:9: note: expected 'u32' {aka 'unsigned int'} but argument is of type 'struct kstat *'
1998 | u32 request_mask, unsigned int flags);
| ~~~~^~~~~~~~~~~~
>> fs/ubifs/file.c:1644:2: error: too many arguments to function 'ubifs_getattr'
1644 | ubifs_getattr(mnt_userns, path, stat, request_mask, query_flags);
| ^~~~~~~~~~~~~
In file included from fs/ubifs/file.c:40:
fs/ubifs/ubifs.h:1997:5: note: declared here
1997 | int ubifs_getattr(const struct path *path, struct kstat *stat,
| ^~~~~~~~~~~~~
fs/ubifs/file.c: At top level:
>> fs/ubifs/file.c:1676:17: error: initialization of 'int (*)(const struct path *, struct kstat *, u32, unsigned int)' {aka 'int (*)(const struct path *, struct kstat *, unsigned int, unsigned int)'} from incompatible pointer type 'int (*)(struct user_namespace *, const struct path *, struct kstat *, u32, unsigned int)' {aka 'int (*)(struct user_namespace *, const struct path *, struct kstat *, unsigned int, unsigned int)'} [-Werror=incompatible-pointer-types]
1676 | .getattr = ubifs_symlink_getattr,
| ^~~~~~~~~~~~~~~~~~~~~
fs/ubifs/file.c:1676:17: note: (near initialization for 'ubifs_symlink_inode_operations.getattr')
cc1: some warnings being treated as errors
vim +/ubifs_getattr +1644 fs/ubifs/file.c
1639
1640 static int ubifs_symlink_getattr(struct user_namespace *mnt_userns,
1641 const struct path *path, struct kstat *stat,
1642 u32 request_mask, unsigned int query_flags)
1643 {
> 1644 ubifs_getattr(mnt_userns, path, stat, request_mask, query_flags);
1645
1646 if (IS_ENCRYPTED(d_inode(path->dentry)))
1647 return fscrypt_symlink_getattr(path, stat);
1648 return 0;
1649 }
1650
1651 const struct address_space_operations ubifs_file_address_operations = {
1652 .readpage = ubifs_readpage,
1653 .writepage = ubifs_writepage,
1654 .write_begin = ubifs_write_begin,
1655 .write_end = ubifs_write_end,
1656 .invalidatepage = ubifs_invalidatepage,
1657 .set_page_dirty = ubifs_set_page_dirty,
1658 #ifdef CONFIG_MIGRATION
1659 .migratepage = ubifs_migrate_page,
1660 #endif
1661 .releasepage = ubifs_releasepage,
1662 };
1663
1664 const struct inode_operations ubifs_file_inode_operations = {
1665 .setattr = ubifs_setattr,
1666 .getattr = ubifs_getattr,
1667 #ifdef CONFIG_UBIFS_FS_XATTR
1668 .listxattr = ubifs_listxattr,
1669 #endif
1670 .update_time = ubifs_update_time,
1671 };
1672
1673 const struct inode_operations ubifs_symlink_inode_operations = {
1674 .get_link = ubifs_get_link,
1675 .setattr = ubifs_setattr,
> 1676 .getattr = ubifs_symlink_getattr,
1677 #ifdef CONFIG_UBIFS_FS_XATTR
1678 .listxattr = ubifs_listxattr,
1679 #endif
1680 .update_time = ubifs_update_time,
1681 };
1682
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
8 months