drivers/gpu/drm/armada/armada_plane.c:124 armada_drm_plane_atomic_check() warn: variable dereferenced before check 'state' (see line 111)
by Dan Carpenter
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 79e06c4c4950be2abd8ca5d2428a8c915aa62c24
commit: dec92020671c48da231189eb06a5f755f492f87f drm: Use the state pointer directly in planes atomic_check
config: arm-randconfig-m031-20220116 (https://download.01.org/0day-ci/archive/20220117/202201170744.uress2oV-lk...)
compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
smatch warnings:
drivers/gpu/drm/armada/armada_plane.c:124 armada_drm_plane_atomic_check() warn: variable dereferenced before check 'state' (see line 111)
vim +/state +124 drivers/gpu/drm/armada/armada_plane.c
d40af7b1ae23da Russell King 2018-07-30 108 int armada_drm_plane_atomic_check(struct drm_plane *plane,
7c11b99a8e58c0 Maxime Ripard 2021-02-19 109 struct drm_atomic_state *state)
d40af7b1ae23da Russell King 2018-07-30 110 {
7c11b99a8e58c0 Maxime Ripard 2021-02-19 @111 struct drm_plane_state *new_plane_state = drm_atomic_get_new_plane_state(state,
^^^^^^
Dereference
7c11b99a8e58c0 Maxime Ripard 2021-02-19 112 plane);
ba5c1649465d40 Maxime Ripard 2021-02-19 113 struct armada_plane_state *st = to_armada_plane_state(new_plane_state);
ba5c1649465d40 Maxime Ripard 2021-02-19 114 struct drm_crtc *crtc = new_plane_state->crtc;
d40af7b1ae23da Russell King 2018-07-30 115 struct drm_crtc_state *crtc_state;
1d1547ec12bc7d Russell King 2019-01-25 116 bool interlace;
1d1547ec12bc7d Russell King 2019-01-25 117 int ret;
1d1547ec12bc7d Russell King 2019-01-25 118
ba5c1649465d40 Maxime Ripard 2021-02-19 119 if (!new_plane_state->fb || WARN_ON(!new_plane_state->crtc)) {
ba5c1649465d40 Maxime Ripard 2021-02-19 120 new_plane_state->visible = false;
1d1547ec12bc7d Russell King 2019-01-25 121 return 0;
1d1547ec12bc7d Russell King 2019-01-25 122 }
d40af7b1ae23da Russell King 2018-07-30 123
dec92020671c48 Maxime Ripard 2021-02-19 @124 if (state)
^^^^^
Checked too late
dec92020671c48 Maxime Ripard 2021-02-19 125 crtc_state = drm_atomic_get_existing_crtc_state(state,
ba5c1649465d40 Maxime Ripard 2021-02-19 126 crtc);
d40af7b1ae23da Russell King 2018-07-30 127 else
d40af7b1ae23da Russell King 2018-07-30 128 crtc_state = crtc->state;
1d1547ec12bc7d Russell King 2019-01-25 129
ba5c1649465d40 Maxime Ripard 2021-02-19 130 ret = drm_atomic_helper_check_plane_state(new_plane_state, crtc_state,
ba5c1649465d40 Maxime Ripard 2021-02-19 131 0,
1d1547ec12bc7d Russell King 2019-01-25 132 INT_MAX, true, false);
1d1547ec12bc7d Russell King 2019-01-25 133 if (ret)
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
8 months
drivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c:101 visconti_eth_fix_mac_speed() error: uninitialized symbol 'clk_sel_val'.
by Dan Carpenter
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 4d66020dcef83314092f2c8c89152a8d122627e2
commit: b38dd98ff8d0d951770bffdca49b387dc63ba92b net: stmmac: Add Toshiba Visconti SoCs glue driver
config: nios2-randconfig-m031-20220116 (https://download.01.org/0day-ci/archive/20220117/202201170216.Q8zMAmz9-lk...)
compiler: nios2-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
New smatch warnings:
drivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c:101 visconti_eth_fix_mac_speed() error: uninitialized symbol 'clk_sel_val'.
vim +/clk_sel_val +101 drivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 55 static void visconti_eth_fix_mac_speed(void *priv, unsigned int speed)
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 56 {
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 57 struct visconti_eth *dwmac = priv;
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 58 unsigned int val, clk_sel_val;
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 59 unsigned long flags;
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 60
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 61 spin_lock_irqsave(&dwmac->lock, flags);
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 62
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 63 /* adjust link */
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 64 val = readl(dwmac->reg + MAC_CTRL_REG);
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 65 val &= ~(GMAC_CONFIG_PS | GMAC_CONFIG_FES);
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 66
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 67 switch (speed) {
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 68 case SPEED_1000:
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 69 if (dwmac->phy_intf_sel == ETHER_CONFIG_INTF_RGMII)
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 70 clk_sel_val = ETHER_CLK_SEL_FREQ_SEL_125M;
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 71 break;
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 72 case SPEED_100:
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 73 if (dwmac->phy_intf_sel == ETHER_CONFIG_INTF_RGMII)
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 74 clk_sel_val = ETHER_CLK_SEL_FREQ_SEL_25M;
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 75 if (dwmac->phy_intf_sel == ETHER_CONFIG_INTF_RMII)
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 76 clk_sel_val = ETHER_CLK_SEL_DIV_SEL_2;
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 77 val |= GMAC_CONFIG_PS | GMAC_CONFIG_FES;
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 78 break;
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 79 case SPEED_10:
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 80 if (dwmac->phy_intf_sel == ETHER_CONFIG_INTF_RGMII)
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 81 clk_sel_val = ETHER_CLK_SEL_FREQ_SEL_2P5M;
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 82 if (dwmac->phy_intf_sel == ETHER_CONFIG_INTF_RMII)
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 83 clk_sel_val = ETHER_CLK_SEL_DIV_SEL_20;
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 84 val |= GMAC_CONFIG_PS;
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 85 break;
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 86 default:
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 87 /* No bit control */
clk_sel_val is not set on the default path
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 88 break;
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 89 }
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 90
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 91 writel(val, dwmac->reg + MAC_CTRL_REG);
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 92
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 93 /* Stop internal clock */
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 94 val = readl(dwmac->reg + REG_ETHER_CLOCK_SEL);
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 95 val &= ~(ETHER_CLK_SEL_RMII_CLK_EN | ETHER_CLK_SEL_RX_TX_CLK_EN);
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 96 val |= ETHER_CLK_SEL_TX_O_E_N_IN;
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 97 writel(val, dwmac->reg + REG_ETHER_CLOCK_SEL);
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 98
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 99 switch (dwmac->phy_intf_sel) {
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 100 case ETHER_CONFIG_INTF_RGMII:
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 @101 val = clk_sel_val | ETHER_CLK_SEL_RX_CLK_EXT_SEL_RXC;
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 102 break;
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 103 case ETHER_CONFIG_INTF_RMII:
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 104 val = clk_sel_val | ETHER_CLK_SEL_RX_CLK_EXT_SEL_DIV |
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 105 ETHER_CLK_SEL_TX_CLK_EXT_SEL_TXC | ETHER_CLK_SEL_TX_O_E_N_IN |
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 106 ETHER_CLK_SEL_RMII_CLK_SEL_RX_C;
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 107 break;
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 108 case ETHER_CONFIG_INTF_MII:
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 109 default:
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 110 val = clk_sel_val | ETHER_CLK_SEL_RX_CLK_EXT_SEL_RXC |
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 111 ETHER_CLK_SEL_TX_CLK_EXT_SEL_DIV | ETHER_CLK_SEL_TX_O_E_N_IN |
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 112 ETHER_CLK_SEL_RMII_CLK_EN;
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 113 break;
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 114 }
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 115
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 116 /* Start clock */
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 117 writel(val, dwmac->reg + REG_ETHER_CLOCK_SEL);
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 118 val |= ETHER_CLK_SEL_RX_TX_CLK_EN;
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 119 writel(val, dwmac->reg + REG_ETHER_CLOCK_SEL);
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 120
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 121 val &= ~ETHER_CLK_SEL_TX_O_E_N_IN;
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 122 writel(val, dwmac->reg + REG_ETHER_CLOCK_SEL);
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 123
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 124 spin_unlock_irqrestore(&dwmac->lock, flags);
b38dd98ff8d0d9 Nobuhiro Iwamatsu 2021-02-16 125 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
8 months
Re: [PATCH net-next v2] net: mptcp, Fast Open Mechanism
by Dan Carpenter
Hi Dmytro,
url: https://github.com/0day-ci/linux/commits/Dmytro-SHYTYI/net-mptcp-Fast-Ope...
base: df0cc57e057f18e44dac8e6c18aba47ab53202f9
config: x86_64-randconfig-m001 (https://download.01.org/0day-ci/archive/20220117/202201170247.BMTU5XYy-lk...)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
smatch warnings:
net/ipv4/tcp_input.c:6960 tcp_conn_request() warn: ignoring unreachable code.
vim +6960 net/ipv4/tcp_input.c
9caad864151e52 Eric Dumazet 2016-04-01 6951 if (want_cookie) {
9caad864151e52 Eric Dumazet 2016-04-01 6952 reqsk_free(req);
9caad864151e52 Eric Dumazet 2016-04-01 6953 return 0;
9caad864151e52 Eric Dumazet 2016-04-01 6954 }
1fb6f159fd21c6 Octavian Purdila 2014-06-25 6955 }
ca6fb06518836e Eric Dumazet 2015-10-02 6956 reqsk_put(req);
1fb6f159fd21c6 Octavian Purdila 2014-06-25 6957 return 0;
^^^^^^^^
1fb6f159fd21c6 Octavian Purdila 2014-06-25 6958
52c7bf82e2e91e Dmytro SHYTYI 2022-01-16 6959 //drop_and_release:
1fb6f159fd21c6 Octavian Purdila 2014-06-25 @6960 dst_release(dst);
^^^^^^^^^^^^^^^^
Unreachable code.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
8 months
Re: [PATCH] lkdtm/bugs: Check for the NULL pointer after calling kmalloc
by Dan Carpenter
Hi Jiasheng,
url: https://github.com/0day-ci/linux/commits/Jiasheng-Jiang/lkdtm-bugs-Check-...
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git d47c7407b4c88cf66098eba8893bc38279f301fc
config: arm-randconfig-m031-20220113 (https://download.01.org/0day-ci/archive/20220115/202201150641.NvpCoUdU-lk...)
compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
New smatch warnings:
drivers/misc/lkdtm/bugs.c:331 lkdtm_ARRAY_BOUNDS() warn: possible memory leak of 'checked'
drivers/misc/lkdtm/bugs.c:331 lkdtm_ARRAY_BOUNDS() warn: possible memory leak of 'not_checked'
Old smatch warnings:
drivers/misc/lkdtm/bugs.c:346 lkdtm_ARRAY_BOUNDS() error: buffer overflow 'checked->data' 8 <= 8
vim +/checked +331 drivers/misc/lkdtm/bugs.c
ae2e1aad3e48e4 Kees Cook 2020-04-06 322 void lkdtm_ARRAY_BOUNDS(void)
ae2e1aad3e48e4 Kees Cook 2020-04-06 323 {
ae2e1aad3e48e4 Kees Cook 2020-04-06 324 struct array_bounds_flex_array *not_checked;
ae2e1aad3e48e4 Kees Cook 2020-04-06 325 struct array_bounds *checked;
ae2e1aad3e48e4 Kees Cook 2020-04-06 326 volatile int i;
ae2e1aad3e48e4 Kees Cook 2020-04-06 327
ae2e1aad3e48e4 Kees Cook 2020-04-06 328 not_checked = kmalloc(sizeof(*not_checked) * 2, GFP_KERNEL);
ae2e1aad3e48e4 Kees Cook 2020-04-06 329 checked = kmalloc(sizeof(*checked) * 2, GFP_KERNEL);
6ac33daa73b3fe Jiasheng Jiang 2022-01-14 330 if (!not_checked || !checked)
6ac33daa73b3fe Jiasheng Jiang 2022-01-14 @331 return;
We've just changed one static checker warning for another. Plus these
functions are *supposed* to be buggy.
ae2e1aad3e48e4 Kees Cook 2020-04-06 332
ae2e1aad3e48e4 Kees Cook 2020-04-06 333 pr_info("Array access within bounds ...\n");
ae2e1aad3e48e4 Kees Cook 2020-04-06 334 /* For both, touch all bytes in the actual member size. */
ae2e1aad3e48e4 Kees Cook 2020-04-06 335 for (i = 0; i < sizeof(checked->data); i++)
ae2e1aad3e48e4 Kees Cook 2020-04-06 336 checked->data[i] = 'A';
ae2e1aad3e48e4 Kees Cook 2020-04-06 337 /*
ae2e1aad3e48e4 Kees Cook 2020-04-06 338 * For the uninstrumented flex array member, also touch 1 byte
ae2e1aad3e48e4 Kees Cook 2020-04-06 339 * beyond to verify it is correctly uninstrumented.
ae2e1aad3e48e4 Kees Cook 2020-04-06 340 */
ae2e1aad3e48e4 Kees Cook 2020-04-06 341 for (i = 0; i < sizeof(not_checked->data) + 1; i++)
ae2e1aad3e48e4 Kees Cook 2020-04-06 342 not_checked->data[i] = 'A';
ae2e1aad3e48e4 Kees Cook 2020-04-06 343
ae2e1aad3e48e4 Kees Cook 2020-04-06 344 pr_info("Array access beyond bounds ...\n");
ae2e1aad3e48e4 Kees Cook 2020-04-06 345 for (i = 0; i < sizeof(checked->data) + 1; i++)
ae2e1aad3e48e4 Kees Cook 2020-04-06 346 checked->data[i] = 'B';
ae2e1aad3e48e4 Kees Cook 2020-04-06 347
ae2e1aad3e48e4 Kees Cook 2020-04-06 348 kfree(not_checked);
ae2e1aad3e48e4 Kees Cook 2020-04-06 349 kfree(checked);
464e86b4abadfc Kees Cook 2020-06-25 350 pr_err("FAIL: survived array bounds overflow!\n");
c75be56e35b2ee Kees Cook 2021-08-18 351 pr_expected_config(CONFIG_UBSAN_BOUNDS);
ae2e1aad3e48e4 Kees Cook 2020-04-06 352 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
8 months
[chrome-os:chromeos-5.10 9993/9999] sound/soc/sof/topology.c:812:3: error: 'SOF_TKN_MEDIATEK_AFE_RATE' undeclared here (not in a function); did you mean 'SOF_TKN_INTEL_ALH_RATE'?
by kernel test robot
tree: https://chromium.googlesource.com/chromiumos/third_party/kernel chromeos-5.10
head: d2945e83762685e27b20286924d8e59daa10233f
commit: ee38f0f8d4d97952216e45924a874aee3b6f98c4 [9993/9999] UPSTREAM: ASoC: SOF: topology: Add support for Mediatek AFE DAI
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20220118/202201181911.S7jEymv9-lk...)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
git remote add chrome-os https://chromium.googlesource.com/chromiumos/third_party/kernel
git fetch --no-tags chrome-os chromeos-5.10
git checkout ee38f0f8d4d97952216e45924a874aee3b6f98c4
# save the config file to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Note: the chrome-os/chromeos-5.10 HEAD d2945e83762685e27b20286924d8e59daa10233f builds fine.
It only hurts bisectability.
All errors (new ones prefixed by >>):
>> sound/soc/sof/topology.c:812:3: error: 'SOF_TKN_MEDIATEK_AFE_RATE' undeclared here (not in a function); did you mean 'SOF_TKN_INTEL_ALH_RATE'?
812 | {SOF_TKN_MEDIATEK_AFE_RATE,
| ^~~~~~~~~~~~~~~~~~~~~~~~~
| SOF_TKN_INTEL_ALH_RATE
>> sound/soc/sof/topology.c:815:3: error: 'SOF_TKN_MEDIATEK_AFE_CH' undeclared here (not in a function); did you mean 'SOF_DAI_MEDIATEK_AFE'?
815 | {SOF_TKN_MEDIATEK_AFE_CH,
| ^~~~~~~~~~~~~~~~~~~~~~~
| SOF_DAI_MEDIATEK_AFE
>> sound/soc/sof/topology.c:818:3: error: 'SOF_TKN_MEDIATEK_AFE_FORMAT' undeclared here (not in a function)
818 | {SOF_TKN_MEDIATEK_AFE_FORMAT,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +812 sound/soc/sof/topology.c
809
810 /* AFE */
811 static const struct sof_topology_token afe_tokens[] = {
> 812 {SOF_TKN_MEDIATEK_AFE_RATE,
813 SND_SOC_TPLG_TUPLE_TYPE_WORD, get_token_u32,
814 offsetof(struct sof_ipc_dai_mtk_afe_params, rate), 0},
> 815 {SOF_TKN_MEDIATEK_AFE_CH,
816 SND_SOC_TPLG_TUPLE_TYPE_WORD, get_token_u32,
817 offsetof(struct sof_ipc_dai_mtk_afe_params, channels), 0},
> 818 {SOF_TKN_MEDIATEK_AFE_FORMAT,
819 SND_SOC_TPLG_TUPLE_TYPE_STRING, get_token_comp_format,
820 offsetof(struct sof_ipc_dai_mtk_afe_params, format), 0},
821 };
822
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
8 months
drivers/power/supply/ab8500_fg.c:2243:75: warning: variable 'b' set but not used
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: e3a8b6a1e70c37702054ae3c7c07ed828435d8ee
commit: 2a5f41830aadc2d7f4145eae49381133da5df2a3 power: supply: ab8500: Standardize voltages
date: 8 weeks ago
config: arm-allyesconfig (https://download.01.org/0day-ci/archive/20220118/202201181843.hXuoA1vS-lk...)
compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit...
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 2a5f41830aadc2d7f4145eae49381133da5df2a3
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arm SHELL=/bin/bash drivers/power/supply/ drivers/usb/gadget/udc/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
drivers/power/supply/ab8500_fg.c: In function 'ab8500_fg_get_ext_psy_data':
>> drivers/power/supply/ab8500_fg.c:2243:75: warning: variable 'b' set but not used [-Wunused-but-set-variable]
2243 | const struct ab8500_battery_type *b;
| ^
vim +/b +2243 drivers/power/supply/ab8500_fg.c
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2167
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2168 static int ab8500_fg_get_ext_psy_data(struct device *dev, void *data)
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2169 {
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2170 struct power_supply *psy;
ea32cea140f644 drivers/power/ab8500_fg.c Andy Shevchenko 2016-03-17 2171 struct power_supply *ext = dev_get_drvdata(dev);
ea32cea140f644 drivers/power/ab8500_fg.c Andy Shevchenko 2016-03-17 2172 const char **supplicants = (const char **)ext->supplied_to;
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2173 struct ab8500_fg *di;
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2174 union power_supply_propval ret;
ea32cea140f644 drivers/power/ab8500_fg.c Andy Shevchenko 2016-03-17 2175 int j;
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2176
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2177 psy = (struct power_supply *)data;
297d716f6260cc drivers/power/ab8500_fg.c Krzysztof Kozlowski 2015-03-12 2178 di = power_supply_get_drvdata(psy);
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2179
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2180 /*
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2181 * For all psy where the name of your driver
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2182 * appears in any supplied_to
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2183 */
ea32cea140f644 drivers/power/ab8500_fg.c Andy Shevchenko 2016-03-17 2184 j = match_string(supplicants, ext->num_supplicants, psy->desc->name);
ea32cea140f644 drivers/power/ab8500_fg.c Andy Shevchenko 2016-03-17 2185 if (j < 0)
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2186 return 0;
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2187
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2188 /* Go through all properties for the psy */
297d716f6260cc drivers/power/ab8500_fg.c Krzysztof Kozlowski 2015-03-12 2189 for (j = 0; j < ext->desc->num_properties; j++) {
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2190 enum power_supply_property prop;
297d716f6260cc drivers/power/ab8500_fg.c Krzysztof Kozlowski 2015-03-12 2191 prop = ext->desc->properties[j];
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2192
15077fc1f78488 drivers/power/ab8500_fg.c Krzysztof Kozlowski 2015-03-12 2193 if (power_supply_get_property(ext, prop, &ret))
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2194 continue;
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2195
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2196 switch (prop) {
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2197 case POWER_SUPPLY_PROP_STATUS:
297d716f6260cc drivers/power/ab8500_fg.c Krzysztof Kozlowski 2015-03-12 2198 switch (ext->desc->type) {
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2199 case POWER_SUPPLY_TYPE_BATTERY:
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2200 switch (ret.intval) {
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2201 case POWER_SUPPLY_STATUS_UNKNOWN:
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2202 case POWER_SUPPLY_STATUS_DISCHARGING:
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2203 case POWER_SUPPLY_STATUS_NOT_CHARGING:
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2204 if (!di->flags.charging)
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2205 break;
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2206 di->flags.charging = false;
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2207 di->flags.fully_charged = false;
ea4024017831d6 drivers/power/ab8500_fg.c Marcus Cooper 2013-01-11 2208 if (di->bm->capacity_scaling)
ea4024017831d6 drivers/power/ab8500_fg.c Marcus Cooper 2013-01-11 2209 ab8500_fg_update_cap_scalers(di);
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2210 queue_work(di->fg_wq, &di->fg_work);
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2211 break;
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2212 case POWER_SUPPLY_STATUS_FULL:
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2213 if (di->flags.fully_charged)
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2214 break;
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2215 di->flags.fully_charged = true;
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2216 di->flags.force_full = true;
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2217 /* Save current capacity as maximum */
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2218 di->bat_cap.max_mah = di->bat_cap.mah;
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2219 queue_work(di->fg_wq, &di->fg_work);
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2220 break;
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2221 case POWER_SUPPLY_STATUS_CHARGING:
ea4024017831d6 drivers/power/ab8500_fg.c Marcus Cooper 2013-01-11 2222 if (di->flags.charging &&
ea4024017831d6 drivers/power/ab8500_fg.c Marcus Cooper 2013-01-11 2223 !di->flags.fully_charged)
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2224 break;
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2225 di->flags.charging = true;
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2226 di->flags.fully_charged = false;
ea4024017831d6 drivers/power/ab8500_fg.c Marcus Cooper 2013-01-11 2227 if (di->bm->capacity_scaling)
ea4024017831d6 drivers/power/ab8500_fg.c Marcus Cooper 2013-01-11 2228 ab8500_fg_update_cap_scalers(di);
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2229 queue_work(di->fg_wq, &di->fg_work);
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2230 break;
c6ef5234efc076 drivers/power/supply/ab8500_fg.c Ma Feng 2019-12-19 2231 }
b51883d47d37c3 drivers/power/supply/ab8500_fg.c Gustavo A. R. Silva 2021-07-13 2232 break;
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2233 default:
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2234 break;
c6ef5234efc076 drivers/power/supply/ab8500_fg.c Ma Feng 2019-12-19 2235 }
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2236 break;
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2237 case POWER_SUPPLY_PROP_TECHNOLOGY:
297d716f6260cc drivers/power/ab8500_fg.c Krzysztof Kozlowski 2015-03-12 2238 switch (ext->desc->type) {
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2239 case POWER_SUPPLY_TYPE_BATTERY:
1a793a10899487 drivers/power/ab8500_fg.c Rajkumar Kasirajan 2012-05-30 2240 if (!di->flags.batt_id_received &&
2d3559a50ad6d2 drivers/power/supply/ab8500_fg.c Linus Walleij 2021-11-20 2241 (di->bm->bi.technology !=
e5dff305ab5c53 drivers/power/supply/ab8500_fg.c Linus Walleij 2021-11-20 2242 POWER_SUPPLY_TECHNOLOGY_UNKNOWN)) {
484a9cc3dcb867 drivers/power/supply/ab8500_fg.c Linus Walleij 2021-07-13 @2243 const struct ab8500_battery_type *b;
c34a61b4e7a996 drivers/power/ab8500_fg.c Anton Vorontsov 2012-03-14 2244
e5dff305ab5c53 drivers/power/supply/ab8500_fg.c Linus Walleij 2021-11-20 2245 b = di->bm->bat_type;
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2246
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2247 di->flags.batt_id_received = true;
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2248
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2249 di->bat_cap.max_mah_design =
22be8d77c80dca drivers/power/supply/ab8500_fg.c Linus Walleij 2021-11-20 2250 di->bm->bi.charge_full_design_uah;
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2251
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2252 di->bat_cap.max_mah =
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2253 di->bat_cap.max_mah_design;
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2254
2a5f41830aadc2 drivers/power/supply/ab8500_fg.c Linus Walleij 2021-11-20 2255 di->vbat_nom_uv =
2a5f41830aadc2 drivers/power/supply/ab8500_fg.c Linus Walleij 2021-11-20 2256 di->bm->bi.voltage_max_design_uv;
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2257 }
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2258
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2259 if (ret.intval)
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2260 di->flags.batt_unknown = false;
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2261 else
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2262 di->flags.batt_unknown = true;
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2263 break;
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2264 default:
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2265 break;
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2266 }
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2267 break;
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2268 case POWER_SUPPLY_PROP_TEMP:
297d716f6260cc drivers/power/ab8500_fg.c Krzysztof Kozlowski 2015-03-12 2269 switch (ext->desc->type) {
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2270 case POWER_SUPPLY_TYPE_BATTERY:
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2271 if (di->flags.batt_id_received)
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2272 di->bat_temp = ret.intval;
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2273 break;
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2274 default:
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2275 break;
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2276 }
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2277 break;
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2278 default:
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2279 break;
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2280 }
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2281 }
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2282 return 0;
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2283 }
13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 2284
:::::: The code at line 2243 was first introduced by commit
:::::: 484a9cc3dcb867813fca62f6443c1e77a1ae3c27 power: supply: ab8500: Drop abx500 concept
:::::: TO: Linus Walleij <linus.walleij(a)linaro.org>
:::::: CC: Sebastian Reichel <sebastian.reichel(a)collabora.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
8 months
[mkp:5.18/discovery 76/89] drivers/scsi/mpt3sas/mpt3sas_scsih.c:12594:16: error: 'SCSI_VPD_PG_LEN' undeclared
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/linux.git 5.18/discovery
head: e8d3e07074b4fc3d49dbfcc604d7d03de2b16f2a
commit: 1056b3b530cef4e0d723fd3af2072f65a136b872 [76/89] scsi: core: Query VPD size before getting full page
config: x86_64-rhel-8.3-func (https://download.01.org/0day-ci/archive/20220118/202201181804.pwMFkLNX-lk...)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://git.kernel.org/pub/scm/linux/kernel/git/mkp/linux.git/commit/?id=...
git remote add mkp https://git.kernel.org/pub/scm/linux/kernel/git/mkp/linux.git
git fetch --no-tags mkp 5.18/discovery
git checkout 1056b3b530cef4e0d723fd3af2072f65a136b872
# save the config file to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/scsi/mpt3sas/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Note: the mkp/5.18/discovery HEAD e8d3e07074b4fc3d49dbfcc604d7d03de2b16f2a builds fine.
It only hurts bisectability.
All errors (new ones prefixed by >>):
drivers/scsi/mpt3sas/mpt3sas_scsih.c: In function 'scsih_ncq_prio_supp':
>> drivers/scsi/mpt3sas/mpt3sas_scsih.c:12594:16: error: 'SCSI_VPD_PG_LEN' undeclared (first use in this function)
12594 | buf = kmalloc(SCSI_VPD_PG_LEN, GFP_KERNEL);
| ^~~~~~~~~~~~~~~
drivers/scsi/mpt3sas/mpt3sas_scsih.c:12594:16: note: each undeclared identifier is reported only once for each function it appears in
vim +/SCSI_VPD_PG_LEN +12594 drivers/scsi/mpt3sas/mpt3sas_scsih.c
f92363d1235949 Sreekanth Reddy 2012-11-30 12578
307d9075a02b69 Adam Manzanares 2016-12-12 12579 /**
a8d548b0b3eea1 Lee Jones 2021-03-17 12580 * scsih_ncq_prio_supp - Check for NCQ command priority support
307d9075a02b69 Adam Manzanares 2016-12-12 12581 * @sdev: scsi device struct
307d9075a02b69 Adam Manzanares 2016-12-12 12582 *
307d9075a02b69 Adam Manzanares 2016-12-12 12583 * This is called when a user indicates they would like to enable
307d9075a02b69 Adam Manzanares 2016-12-12 12584 * ncq command priorities. This works only on SATA devices.
307d9075a02b69 Adam Manzanares 2016-12-12 12585 */
307d9075a02b69 Adam Manzanares 2016-12-12 12586 bool scsih_ncq_prio_supp(struct scsi_device *sdev)
307d9075a02b69 Adam Manzanares 2016-12-12 12587 {
307d9075a02b69 Adam Manzanares 2016-12-12 12588 unsigned char *buf;
307d9075a02b69 Adam Manzanares 2016-12-12 12589 bool ncq_prio_supp = false;
307d9075a02b69 Adam Manzanares 2016-12-12 12590
307d9075a02b69 Adam Manzanares 2016-12-12 12591 if (!scsi_device_supports_vpd(sdev))
307d9075a02b69 Adam Manzanares 2016-12-12 12592 return ncq_prio_supp;
307d9075a02b69 Adam Manzanares 2016-12-12 12593
307d9075a02b69 Adam Manzanares 2016-12-12 @12594 buf = kmalloc(SCSI_VPD_PG_LEN, GFP_KERNEL);
307d9075a02b69 Adam Manzanares 2016-12-12 12595 if (!buf)
307d9075a02b69 Adam Manzanares 2016-12-12 12596 return ncq_prio_supp;
307d9075a02b69 Adam Manzanares 2016-12-12 12597
307d9075a02b69 Adam Manzanares 2016-12-12 12598 if (!scsi_get_vpd_page(sdev, 0x89, buf, SCSI_VPD_PG_LEN))
307d9075a02b69 Adam Manzanares 2016-12-12 12599 ncq_prio_supp = (buf[213] >> 4) & 1;
307d9075a02b69 Adam Manzanares 2016-12-12 12600
307d9075a02b69 Adam Manzanares 2016-12-12 12601 kfree(buf);
307d9075a02b69 Adam Manzanares 2016-12-12 12602 return ncq_prio_supp;
307d9075a02b69 Adam Manzanares 2016-12-12 12603 }
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12604 /*
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12605 * The pci device ids are defined in mpi/mpi2_cnfg.h.
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12606 */
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12607 static const struct pci_device_id mpt3sas_pci_table[] = {
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12608 /* Spitfire ~ 2004 */
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12609 { MPI2_MFGPAGE_VENDORID_LSI, MPI2_MFGPAGE_DEVID_SAS2004,
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12610 PCI_ANY_ID, PCI_ANY_ID },
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12611 /* Falcon ~ 2008 */
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12612 { MPI2_MFGPAGE_VENDORID_LSI, MPI2_MFGPAGE_DEVID_SAS2008,
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12613 PCI_ANY_ID, PCI_ANY_ID },
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12614 /* Liberator ~ 2108 */
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12615 { MPI2_MFGPAGE_VENDORID_LSI, MPI2_MFGPAGE_DEVID_SAS2108_1,
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12616 PCI_ANY_ID, PCI_ANY_ID },
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12617 { MPI2_MFGPAGE_VENDORID_LSI, MPI2_MFGPAGE_DEVID_SAS2108_2,
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12618 PCI_ANY_ID, PCI_ANY_ID },
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12619 { MPI2_MFGPAGE_VENDORID_LSI, MPI2_MFGPAGE_DEVID_SAS2108_3,
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12620 PCI_ANY_ID, PCI_ANY_ID },
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12621 /* Meteor ~ 2116 */
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12622 { MPI2_MFGPAGE_VENDORID_LSI, MPI2_MFGPAGE_DEVID_SAS2116_1,
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12623 PCI_ANY_ID, PCI_ANY_ID },
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12624 { MPI2_MFGPAGE_VENDORID_LSI, MPI2_MFGPAGE_DEVID_SAS2116_2,
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12625 PCI_ANY_ID, PCI_ANY_ID },
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12626 /* Thunderbolt ~ 2208 */
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12627 { MPI2_MFGPAGE_VENDORID_LSI, MPI2_MFGPAGE_DEVID_SAS2208_1,
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12628 PCI_ANY_ID, PCI_ANY_ID },
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12629 { MPI2_MFGPAGE_VENDORID_LSI, MPI2_MFGPAGE_DEVID_SAS2208_2,
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12630 PCI_ANY_ID, PCI_ANY_ID },
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12631 { MPI2_MFGPAGE_VENDORID_LSI, MPI2_MFGPAGE_DEVID_SAS2208_3,
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12632 PCI_ANY_ID, PCI_ANY_ID },
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12633 { MPI2_MFGPAGE_VENDORID_LSI, MPI2_MFGPAGE_DEVID_SAS2208_4,
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12634 PCI_ANY_ID, PCI_ANY_ID },
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12635 { MPI2_MFGPAGE_VENDORID_LSI, MPI2_MFGPAGE_DEVID_SAS2208_5,
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12636 PCI_ANY_ID, PCI_ANY_ID },
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12637 { MPI2_MFGPAGE_VENDORID_LSI, MPI2_MFGPAGE_DEVID_SAS2208_6,
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12638 PCI_ANY_ID, PCI_ANY_ID },
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12639 /* Mustang ~ 2308 */
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12640 { MPI2_MFGPAGE_VENDORID_LSI, MPI2_MFGPAGE_DEVID_SAS2308_1,
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12641 PCI_ANY_ID, PCI_ANY_ID },
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12642 { MPI2_MFGPAGE_VENDORID_LSI, MPI2_MFGPAGE_DEVID_SAS2308_2,
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12643 PCI_ANY_ID, PCI_ANY_ID },
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12644 { MPI2_MFGPAGE_VENDORID_LSI, MPI2_MFGPAGE_DEVID_SAS2308_3,
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12645 PCI_ANY_ID, PCI_ANY_ID },
1244790d178bb0 Suganath Prabu S 2019-01-29 12646 { MPI2_MFGPAGE_VENDORID_LSI, MPI2_MFGPAGE_DEVID_SWITCH_MPI_EP,
c520691b38cde1 Suganath Prabu Subramani 2018-02-07 12647 PCI_ANY_ID, PCI_ANY_ID },
8f8384503e40c6 Suganath Prabu S 2019-01-29 12648 { MPI2_MFGPAGE_VENDORID_LSI, MPI2_MFGPAGE_DEVID_SWITCH_MPI_EP_1,
8f8384503e40c6 Suganath Prabu S 2019-01-29 12649 PCI_ANY_ID, PCI_ANY_ID },
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12650 /* SSS6200 */
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12651 { MPI2_MFGPAGE_VENDORID_LSI, MPI2_MFGPAGE_DEVID_SSS6200,
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12652 PCI_ANY_ID, PCI_ANY_ID },
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12653 /* Fury ~ 3004 and 3008 */
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12654 { MPI2_MFGPAGE_VENDORID_LSI, MPI25_MFGPAGE_DEVID_SAS3004,
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12655 PCI_ANY_ID, PCI_ANY_ID },
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12656 { MPI2_MFGPAGE_VENDORID_LSI, MPI25_MFGPAGE_DEVID_SAS3008,
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12657 PCI_ANY_ID, PCI_ANY_ID },
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12658 /* Invader ~ 3108 */
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12659 { MPI2_MFGPAGE_VENDORID_LSI, MPI25_MFGPAGE_DEVID_SAS3108_1,
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12660 PCI_ANY_ID, PCI_ANY_ID },
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12661 { MPI2_MFGPAGE_VENDORID_LSI, MPI25_MFGPAGE_DEVID_SAS3108_2,
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12662 PCI_ANY_ID, PCI_ANY_ID },
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12663 { MPI2_MFGPAGE_VENDORID_LSI, MPI25_MFGPAGE_DEVID_SAS3108_5,
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12664 PCI_ANY_ID, PCI_ANY_ID },
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12665 { MPI2_MFGPAGE_VENDORID_LSI, MPI25_MFGPAGE_DEVID_SAS3108_6,
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12666 PCI_ANY_ID, PCI_ANY_ID },
b130b0d56fa97e Suganath prabu Subramani 2016-01-28 12667 /* Cutlass ~ 3216 and 3224 */
b130b0d56fa97e Suganath prabu Subramani 2016-01-28 12668 { MPI2_MFGPAGE_VENDORID_LSI, MPI26_MFGPAGE_DEVID_SAS3216,
b130b0d56fa97e Suganath prabu Subramani 2016-01-28 12669 PCI_ANY_ID, PCI_ANY_ID },
b130b0d56fa97e Suganath prabu Subramani 2016-01-28 12670 { MPI2_MFGPAGE_VENDORID_LSI, MPI26_MFGPAGE_DEVID_SAS3224,
b130b0d56fa97e Suganath prabu Subramani 2016-01-28 12671 PCI_ANY_ID, PCI_ANY_ID },
b130b0d56fa97e Suganath prabu Subramani 2016-01-28 12672 /* Intruder ~ 3316 and 3324 */
b130b0d56fa97e Suganath prabu Subramani 2016-01-28 12673 { MPI2_MFGPAGE_VENDORID_LSI, MPI26_MFGPAGE_DEVID_SAS3316_1,
b130b0d56fa97e Suganath prabu Subramani 2016-01-28 12674 PCI_ANY_ID, PCI_ANY_ID },
b130b0d56fa97e Suganath prabu Subramani 2016-01-28 12675 { MPI2_MFGPAGE_VENDORID_LSI, MPI26_MFGPAGE_DEVID_SAS3316_2,
b130b0d56fa97e Suganath prabu Subramani 2016-01-28 12676 PCI_ANY_ID, PCI_ANY_ID },
b130b0d56fa97e Suganath prabu Subramani 2016-01-28 12677 { MPI2_MFGPAGE_VENDORID_LSI, MPI26_MFGPAGE_DEVID_SAS3316_3,
b130b0d56fa97e Suganath prabu Subramani 2016-01-28 12678 PCI_ANY_ID, PCI_ANY_ID },
b130b0d56fa97e Suganath prabu Subramani 2016-01-28 12679 { MPI2_MFGPAGE_VENDORID_LSI, MPI26_MFGPAGE_DEVID_SAS3316_4,
b130b0d56fa97e Suganath prabu Subramani 2016-01-28 12680 PCI_ANY_ID, PCI_ANY_ID },
b130b0d56fa97e Suganath prabu Subramani 2016-01-28 12681 { MPI2_MFGPAGE_VENDORID_LSI, MPI26_MFGPAGE_DEVID_SAS3324_1,
b130b0d56fa97e Suganath prabu Subramani 2016-01-28 12682 PCI_ANY_ID, PCI_ANY_ID },
b130b0d56fa97e Suganath prabu Subramani 2016-01-28 12683 { MPI2_MFGPAGE_VENDORID_LSI, MPI26_MFGPAGE_DEVID_SAS3324_2,
b130b0d56fa97e Suganath prabu Subramani 2016-01-28 12684 PCI_ANY_ID, PCI_ANY_ID },
b130b0d56fa97e Suganath prabu Subramani 2016-01-28 12685 { MPI2_MFGPAGE_VENDORID_LSI, MPI26_MFGPAGE_DEVID_SAS3324_3,
b130b0d56fa97e Suganath prabu Subramani 2016-01-28 12686 PCI_ANY_ID, PCI_ANY_ID },
b130b0d56fa97e Suganath prabu Subramani 2016-01-28 12687 { MPI2_MFGPAGE_VENDORID_LSI, MPI26_MFGPAGE_DEVID_SAS3324_4,
b130b0d56fa97e Suganath prabu Subramani 2016-01-28 12688 PCI_ANY_ID, PCI_ANY_ID },
998f26aedf41bc Suganath Prabu Subramani 2016-10-26 12689 /* Ventura, Crusader, Harpoon & Tomcat ~ 3516, 3416, 3508 & 3408*/
998f26aedf41bc Suganath Prabu Subramani 2016-10-26 12690 { MPI2_MFGPAGE_VENDORID_LSI, MPI26_MFGPAGE_DEVID_SAS3508,
998f26aedf41bc Suganath Prabu Subramani 2016-10-26 12691 PCI_ANY_ID, PCI_ANY_ID },
998f26aedf41bc Suganath Prabu Subramani 2016-10-26 12692 { MPI2_MFGPAGE_VENDORID_LSI, MPI26_MFGPAGE_DEVID_SAS3508_1,
998f26aedf41bc Suganath Prabu Subramani 2016-10-26 12693 PCI_ANY_ID, PCI_ANY_ID },
998f26aedf41bc Suganath Prabu Subramani 2016-10-26 12694 { MPI2_MFGPAGE_VENDORID_LSI, MPI26_MFGPAGE_DEVID_SAS3408,
998f26aedf41bc Suganath Prabu Subramani 2016-10-26 12695 PCI_ANY_ID, PCI_ANY_ID },
998f26aedf41bc Suganath Prabu Subramani 2016-10-26 12696 { MPI2_MFGPAGE_VENDORID_LSI, MPI26_MFGPAGE_DEVID_SAS3516,
998f26aedf41bc Suganath Prabu Subramani 2016-10-26 12697 PCI_ANY_ID, PCI_ANY_ID },
998f26aedf41bc Suganath Prabu Subramani 2016-10-26 12698 { MPI2_MFGPAGE_VENDORID_LSI, MPI26_MFGPAGE_DEVID_SAS3516_1,
998f26aedf41bc Suganath Prabu Subramani 2016-10-26 12699 PCI_ANY_ID, PCI_ANY_ID },
998f26aedf41bc Suganath Prabu Subramani 2016-10-26 12700 { MPI2_MFGPAGE_VENDORID_LSI, MPI26_MFGPAGE_DEVID_SAS3416,
998f26aedf41bc Suganath Prabu Subramani 2016-10-26 12701 PCI_ANY_ID, PCI_ANY_ID },
15fd7c74dadc8d Sreekanth Reddy 2017-10-10 12702 /* Mercator ~ 3616*/
15fd7c74dadc8d Sreekanth Reddy 2017-10-10 12703 { MPI2_MFGPAGE_VENDORID_LSI, MPI26_MFGPAGE_DEVID_SAS3616,
15fd7c74dadc8d Sreekanth Reddy 2017-10-10 12704 PCI_ANY_ID, PCI_ANY_ID },
6c2938f7bfd937 Suganath Prabu 2018-10-25 12705
6c2938f7bfd937 Suganath Prabu 2018-10-25 12706 /* Aero SI 0x00E1 Configurable Secure
6c2938f7bfd937 Suganath Prabu 2018-10-25 12707 * 0x00E2 Hard Secure
6c2938f7bfd937 Suganath Prabu 2018-10-25 12708 */
6c2938f7bfd937 Suganath Prabu 2018-10-25 12709 { MPI2_MFGPAGE_VENDORID_LSI, MPI26_MFGPAGE_DEVID_CFG_SEC_3916,
6c2938f7bfd937 Suganath Prabu 2018-10-25 12710 PCI_ANY_ID, PCI_ANY_ID },
6c2938f7bfd937 Suganath Prabu 2018-10-25 12711 { MPI2_MFGPAGE_VENDORID_LSI, MPI26_MFGPAGE_DEVID_HARD_SEC_3916,
6c2938f7bfd937 Suganath Prabu 2018-10-25 12712 PCI_ANY_ID, PCI_ANY_ID },
6c2938f7bfd937 Suganath Prabu 2018-10-25 12713
f38c43a0e9007e Sreekanth Reddy 2020-08-14 12714 /*
f38c43a0e9007e Sreekanth Reddy 2020-08-14 12715 * Aero SI –> 0x00E0 Invalid, 0x00E3 Tampered
f38c43a0e9007e Sreekanth Reddy 2020-08-14 12716 */
f38c43a0e9007e Sreekanth Reddy 2020-08-14 12717 { MPI2_MFGPAGE_VENDORID_LSI, MPI26_MFGPAGE_DEVID_INVALID0_3916,
f38c43a0e9007e Sreekanth Reddy 2020-08-14 12718 PCI_ANY_ID, PCI_ANY_ID },
f38c43a0e9007e Sreekanth Reddy 2020-08-14 12719 { MPI2_MFGPAGE_VENDORID_LSI, MPI26_MFGPAGE_DEVID_INVALID1_3916,
f38c43a0e9007e Sreekanth Reddy 2020-08-14 12720 PCI_ANY_ID, PCI_ANY_ID },
f38c43a0e9007e Sreekanth Reddy 2020-08-14 12721
eb9c7ce5604533 Suganath Prabu S 2019-01-29 12722 /* Atlas PCIe Switch Management Port */
eb9c7ce5604533 Suganath Prabu S 2019-01-29 12723 { MPI2_MFGPAGE_VENDORID_LSI, MPI26_ATLAS_PCIe_SWITCH_DEVID,
eb9c7ce5604533 Suganath Prabu S 2019-01-29 12724 PCI_ANY_ID, PCI_ANY_ID },
eb9c7ce5604533 Suganath Prabu S 2019-01-29 12725
6c2938f7bfd937 Suganath Prabu 2018-10-25 12726 /* Sea SI 0x00E5 Configurable Secure
6c2938f7bfd937 Suganath Prabu 2018-10-25 12727 * 0x00E6 Hard Secure
6c2938f7bfd937 Suganath Prabu 2018-10-25 12728 */
6c2938f7bfd937 Suganath Prabu 2018-10-25 12729 { MPI2_MFGPAGE_VENDORID_LSI, MPI26_MFGPAGE_DEVID_CFG_SEC_3816,
6c2938f7bfd937 Suganath Prabu 2018-10-25 12730 PCI_ANY_ID, PCI_ANY_ID },
6c2938f7bfd937 Suganath Prabu 2018-10-25 12731 { MPI2_MFGPAGE_VENDORID_LSI, MPI26_MFGPAGE_DEVID_HARD_SEC_3816,
6c2938f7bfd937 Suganath Prabu 2018-10-25 12732 PCI_ANY_ID, PCI_ANY_ID },
6c2938f7bfd937 Suganath Prabu 2018-10-25 12733
f38c43a0e9007e Sreekanth Reddy 2020-08-14 12734 /*
f38c43a0e9007e Sreekanth Reddy 2020-08-14 12735 * Sea SI –> 0x00E4 Invalid, 0x00E7 Tampered
f38c43a0e9007e Sreekanth Reddy 2020-08-14 12736 */
f38c43a0e9007e Sreekanth Reddy 2020-08-14 12737 { MPI2_MFGPAGE_VENDORID_LSI, MPI26_MFGPAGE_DEVID_INVALID0_3816,
f38c43a0e9007e Sreekanth Reddy 2020-08-14 12738 PCI_ANY_ID, PCI_ANY_ID },
f38c43a0e9007e Sreekanth Reddy 2020-08-14 12739 { MPI2_MFGPAGE_VENDORID_LSI, MPI26_MFGPAGE_DEVID_INVALID1_3816,
f38c43a0e9007e Sreekanth Reddy 2020-08-14 12740 PCI_ANY_ID, PCI_ANY_ID },
f38c43a0e9007e Sreekanth Reddy 2020-08-14 12741
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12742 {0} /* Terminating entry */
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12743 };
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12744 MODULE_DEVICE_TABLE(pci, mpt3sas_pci_table);
c84b06a48c4d8a Sreekanth Reddy 2015-11-11 12745
:::::: The code at line 12594 was first introduced by commit
:::::: 307d9075a02b696e817b775c565e45c4fa3c32f2 scsi: mpt3sas: Recognize and act on iopriority info
:::::: TO: Adam Manzanares <adam.manzanares(a)wdc.com>
:::::: CC: Martin K. Petersen <martin.petersen(a)oracle.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
8 months
Re: [PATCH v4] powerpc/mce: Avoid using irq_work_queue() in realmode
by kernel test robot
Hi Ganesh,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on powerpc/next]
[also build test ERROR on v5.16 next-20220118]
[cannot apply to scottwood/next mpe/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Ganesh-Goudar/powerpc-mce-Avoid-...
base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc64-randconfig-c024-20220116 (https://download.01.org/0day-ci/archive/20220118/202201181831.VB3r6wzz-lk...)
compiler: powerpc64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/bb8f4e786eb9c838daad7a6187dcd5904...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Ganesh-Goudar/powerpc-mce-Avoid-using-irq_work_queue-in-realmode/20220117-163425
git checkout bb8f4e786eb9c838daad7a6187dcd59040ff2771
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=powerpc SHELL=/bin/bash arch/powerpc/platforms/pseries/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
arch/powerpc/platforms/pseries/ras.c: In function 'mce_handle_error':
>> arch/powerpc/platforms/pseries/ras.c:715:23: error: unused variable 'msr' [-Werror=unused-variable]
715 | unsigned long msr;
| ^~~
cc1: all warnings being treated as errors
vim +/msr +715 arch/powerpc/platforms/pseries/ras.c
a43c1590426c44 Mahesh Salgaonkar 2018-09-11 709
4ff753feab0212 Ganesh Goudar 2020-07-24 710 static int mce_handle_error(struct pt_regs *regs, struct rtas_error_log *errp)
4ff753feab0212 Ganesh Goudar 2020-07-24 711 {
4ff753feab0212 Ganesh Goudar 2020-07-24 712 struct pseries_errorlog *pseries_log;
4ff753feab0212 Ganesh Goudar 2020-07-24 713 struct pseries_mc_errorlog *mce_log = NULL;
4ff753feab0212 Ganesh Goudar 2020-07-24 714 int disposition = rtas_error_disposition(errp);
74c3354bc1d89d Nicholas Piggin 2021-02-07 @715 unsigned long msr;
4ff753feab0212 Ganesh Goudar 2020-07-24 716 u8 error_type;
4ff753feab0212 Ganesh Goudar 2020-07-24 717
4ff753feab0212 Ganesh Goudar 2020-07-24 718 if (!rtas_error_extended(errp))
4ff753feab0212 Ganesh Goudar 2020-07-24 719 goto out;
4ff753feab0212 Ganesh Goudar 2020-07-24 720
4ff753feab0212 Ganesh Goudar 2020-07-24 721 pseries_log = get_pseries_errorlog(errp, PSERIES_ELOG_SECT_ID_MCE);
4ff753feab0212 Ganesh Goudar 2020-07-24 722 if (!pseries_log)
4ff753feab0212 Ganesh Goudar 2020-07-24 723 goto out;
4ff753feab0212 Ganesh Goudar 2020-07-24 724
4ff753feab0212 Ganesh Goudar 2020-07-24 725 mce_log = (struct pseries_mc_errorlog *)pseries_log->data;
4ff753feab0212 Ganesh Goudar 2020-07-24 726 error_type = mce_log->error_type;
4ff753feab0212 Ganesh Goudar 2020-07-24 727
4ff753feab0212 Ganesh Goudar 2020-07-24 728 disposition = mce_handle_err_realmode(disposition, error_type);
4ff753feab0212 Ganesh Goudar 2020-07-24 729 out:
4ff753feab0212 Ganesh Goudar 2020-07-24 730 disposition = mce_handle_err_virtmode(regs, errp, mce_log,
4ff753feab0212 Ganesh Goudar 2020-07-24 731 disposition);
9ca766f9891d23 Nicholas Piggin 2019-08-02 732 return disposition;
7f177f9810ada8 Ganesh Goudar 2019-04-15 733 }
7f177f9810ada8 Ganesh Goudar 2019-04-15 734
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
8 months
fs/notify/fanotify/fanotify_user.c:154:24: warning: variable 'info' set but not used
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: e3a8b6a1e70c37702054ae3c7c07ed828435d8ee
commit: 7326e382c21e9c23c89c88369afdc90b82a14da8 fanotify: report old and/or new parent+name in FAN_RENAME event
date: 5 weeks ago
config: hexagon-randconfig-r045-20220117 (https://download.01.org/0day-ci/archive/20220118/202201181811.egJXbMCF-lk...)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project c10cbb243cafc0cf42c3e922cb29183279444432)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit...
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 7326e382c21e9c23c89c88369afdc90b82a14da8
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash fs/notify/fanotify/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> fs/notify/fanotify/fanotify_user.c:154:24: warning: variable 'info' set but not used [-Wunused-but-set-variable]
struct fanotify_info *info;
^
1 warning generated.
vim +/info +154 fs/notify/fanotify/fanotify_user.c
7326e382c21e9c Amir Goldstein 2021-11-29 149
b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 150 static size_t fanotify_event_len(unsigned int info_mode,
929943b38daf81 Amir Goldstein 2020-07-16 151 struct fanotify_event *event)
5e469c830fdb5a Amir Goldstein 2019-01-10 152 {
b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 153 size_t event_len = FAN_EVENT_METADATA_LEN;
b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 @154 struct fanotify_info *info;
b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 155 int fh_len;
929943b38daf81 Amir Goldstein 2020-07-16 156 int dot_len = 0;
f454fa610a69b9 Amir Goldstein 2020-07-16 157
b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 158 if (!info_mode)
b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 159 return event_len;
b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 160
130a3c742107ac Gabriel Krisman Bertazi 2021-10-25 161 if (fanotify_is_error_event(event->mask))
130a3c742107ac Gabriel Krisman Bertazi 2021-10-25 162 event_len += FANOTIFY_ERROR_INFO_LEN;
130a3c742107ac Gabriel Krisman Bertazi 2021-10-25 163
b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 164 info = fanotify_event_info(event);
b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 165
7326e382c21e9c Amir Goldstein 2021-11-29 166 if (fanotify_event_has_any_dir_fh(event)) {
7326e382c21e9c Amir Goldstein 2021-11-29 167 event_len += fanotify_dir_name_info_len(event);
d3424c9bac893b Matthew Bobrowski 2021-08-08 168 } else if ((info_mode & FAN_REPORT_NAME) &&
d3424c9bac893b Matthew Bobrowski 2021-08-08 169 (event->mask & FAN_ONDIR)) {
929943b38daf81 Amir Goldstein 2020-07-16 170 /*
929943b38daf81 Amir Goldstein 2020-07-16 171 * With group flag FAN_REPORT_NAME, if name was not recorded in
929943b38daf81 Amir Goldstein 2020-07-16 172 * event on a directory, we will report the name ".".
929943b38daf81 Amir Goldstein 2020-07-16 173 */
929943b38daf81 Amir Goldstein 2020-07-16 174 dot_len = 1;
929943b38daf81 Amir Goldstein 2020-07-16 175 }
afc894c784c84c Jan Kara 2020-03-24 176
af579beb666aef Matthew Bobrowski 2021-08-08 177 if (info_mode & FAN_REPORT_PIDFD)
b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 178 event_len += FANOTIFY_PIDFD_INFO_HDR_LEN;
af579beb666aef Matthew Bobrowski 2021-08-08 179
4bd5a5c8e6e5cd Gabriel Krisman Bertazi 2021-10-25 180 if (fanotify_event_has_object_fh(event)) {
4bd5a5c8e6e5cd Gabriel Krisman Bertazi 2021-10-25 181 fh_len = fanotify_event_object_fh_len(event);
b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 182 event_len += fanotify_fid_info_len(fh_len, dot_len);
4bd5a5c8e6e5cd Gabriel Krisman Bertazi 2021-10-25 183 }
5e469c830fdb5a Amir Goldstein 2019-01-10 184
b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 185 return event_len;
5e469c830fdb5a Amir Goldstein 2019-01-10 186 }
5e469c830fdb5a Amir Goldstein 2019-01-10 187
:::::: The code at line 154 was first introduced by commit
:::::: b9928e80dda84b349ba8de01780b9bef2fc36ffa fanotify: Fold event size calculation to its own function
:::::: TO: Gabriel Krisman Bertazi <krisman(a)collabora.com>
:::::: CC: Jan Kara <jack(a)suse.cz>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
8 months