Re: [PATCH v6 08/12] ACPI: add perf low power callback
by kernel test robot
Hi Stephane,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on tip/perf/core]
[also build test ERROR on rafael-pm/linux-next v5.17-rc3 next-20220209]
[cannot apply to tip/x86/core]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Stephane-Eranian/perf-x86-amd-Ad...
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git ee28855a54493ce83bc2a3fbe30210be61b57bc7
config: x86_64-randconfig-a015 (https://download.01.org/0day-ci/archive/20220209/202202092259.Zrszy4r3-lk...)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/90b2d6c8c171189602e01f8c00301f770...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Stephane-Eranian/perf-x86-amd-Add-AMD-Fam19h-Branch-Sampling-support/20220209-064255
git checkout 90b2d6c8c171189602e01f8c00301f7705e5d16a
# save the config file to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
drivers/acpi/acpi_pad.c: In function 'power_saving_thread':
>> drivers/acpi/acpi_pad.c:168:4: error: implicit declaration of function 'perf_lopwr_cb' [-Werror=implicit-function-declaration]
168 | perf_lopwr_cb(true);
| ^~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/perf_lopwr_cb +168 drivers/acpi/acpi_pad.c
135
136 static unsigned int idle_pct = 5; /* percentage */
137 static unsigned int round_robin_time = 1; /* second */
138 static int power_saving_thread(void *data)
139 {
140 int do_sleep;
141 unsigned int tsk_index = (unsigned long)data;
142 u64 last_jiffies = 0;
143
144 sched_set_fifo_low(current);
145
146 while (!kthread_should_stop()) {
147 unsigned long expire_time;
148
149 /* round robin to cpus */
150 expire_time = last_jiffies + round_robin_time * HZ;
151 if (time_before(expire_time, jiffies)) {
152 last_jiffies = jiffies;
153 round_robin_cpu(tsk_index);
154 }
155
156 do_sleep = 0;
157
158 expire_time = jiffies + HZ * (100 - idle_pct) / 100;
159
160 while (!need_resched()) {
161 if (tsc_detected_unstable && !tsc_marked_unstable) {
162 /* TSC could halt in idle, so notify users */
163 mark_tsc_unstable("TSC halts in idle");
164 tsc_marked_unstable = 1;
165 }
166 local_irq_disable();
167
> 168 perf_lopwr_cb(true);
169
170 tick_broadcast_enable();
171 tick_broadcast_enter();
172 stop_critical_timings();
173
174 mwait_idle_with_hints(power_saving_mwait_eax, 1);
175
176 start_critical_timings();
177 tick_broadcast_exit();
178
179 perf_lopwr_cb(false);
180
181 local_irq_enable();
182
183 if (time_before(expire_time, jiffies)) {
184 do_sleep = 1;
185 break;
186 }
187 }
188
189 /*
190 * current sched_rt has threshold for rt task running time.
191 * When a rt task uses 95% CPU time, the rt thread will be
192 * scheduled out for 5% CPU time to not starve other tasks. But
193 * the mechanism only works when all CPUs have RT task running,
194 * as if one CPU hasn't RT task, RT task from other CPUs will
195 * borrow CPU time from this CPU and cause RT task use > 95%
196 * CPU time. To make 'avoid starvation' work, takes a nap here.
197 */
198 if (unlikely(do_sleep))
199 schedule_timeout_killable(HZ * idle_pct / 100);
200
201 /* If an external event has set the need_resched flag, then
202 * we need to deal with it, or this loop will continue to
203 * spin without calling __mwait().
204 */
205 if (unlikely(need_resched()))
206 schedule();
207 }
208
209 exit_round_robin(tsk_index);
210 return 0;
211 }
212
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
7 months, 1 week
[xilinx-xlnx:xlnx_rebase_v5.15 797/907] zynqmp_dpsub.c:undefined reference to `xlnx_drm_pipeline_exit'
by kernel test robot
tree: https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.15
head: 423a108a01e05e84b59a4c4885c16bf3cd8c90c7
commit: 2d2fa5c476daa40a5aac243bd776cab2568c7111 [797/907] drm: xlnx: Update DP subsystem with downstream version
config: csky-randconfig-r022-20220209 (https://download.01.org/0day-ci/archive/20220209/202202092252.XjSgLJUN-lk...)
compiler: csky-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/Xilinx/linux-xlnx/commit/2d2fa5c476daa40a5aac243bd776c...
git remote add xilinx-xlnx https://github.com/Xilinx/linux-xlnx
git fetch --no-tags xilinx-xlnx xlnx_rebase_v5.15
git checkout 2d2fa5c476daa40a5aac243bd776cab2568c7111
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=csky SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
csky-linux-ld: drivers/gpu/drm/xlnx/zynqmp_dpsub.o: in function `zynqmp_dpsub_remove':
>> zynqmp_dpsub.c:(.text+0x1c): undefined reference to `xlnx_drm_pipeline_exit'
csky-linux-ld: drivers/gpu/drm/xlnx/zynqmp_dpsub.o: in function `zynqmp_dpsub_unbind':
zynqmp_dpsub.c:(.text+0xa0): undefined reference to `xlnx_drm_pipeline_exit'
csky-linux-ld: drivers/gpu/drm/xlnx/zynqmp_dpsub.o: in function `zynqmp_dpsub_probe':
>> zynqmp_dpsub.c:(.text+0x180): undefined reference to `xlnx_drm_pipeline_init'
>> csky-linux-ld: zynqmp_dpsub.c:(.text+0x214): undefined reference to `xlnx_drm_pipeline_init'
csky-linux-ld: drivers/gpu/drm/xlnx/zynqmp_disp.o: in function `zynqmp_disp_bind':
>> (.text+0x1a58): undefined reference to `xlnx_crtc_register'
>> csky-linux-ld: (.text+0x1ad8): undefined reference to `xlnx_crtc_register'
csky-linux-ld: drivers/gpu/drm/xlnx/zynqmp_disp.o: in function `zynqmp_disp_unbind':
>> (.text+0x1afc): undefined reference to `xlnx_crtc_unregister'
>> csky-linux-ld: (.text+0x1b8c): undefined reference to `xlnx_crtc_unregister'
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
7 months, 1 week
[jimc:dyn-drm-trc 17/21] lib/dynamic_debug.c:754:6: error: assignment to 'struct dynamic_trace_buf *' from incompatible pointer type 'struct ddebug_trace_buf *'
by kernel test robot
tree: https://github.com/jimc/linux.git dyn-drm-trc
head: a78f403dcd7765c2691998346cffdd311310e1d0
commit: dad7758807ceb3a05385b6f9d09b58cbab8ee9ab [17/21] dyndbg: add write-events-to-tracefs code
config: x86_64-rhel-8.3-func (https://download.01.org/0day-ci/archive/20220209/202202092218.3FyLGNfM-lk...)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/jimc/linux/commit/dad7758807ceb3a05385b6f9d09b58cbab8e...
git remote add jimc https://github.com/jimc/linux.git
git fetch --no-tags jimc dyn-drm-trc
git checkout dad7758807ceb3a05385b6f9d09b58cbab8ee9ab
# save the config file to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Note: the jimc/dyn-drm-trc HEAD a78f403dcd7765c2691998346cffdd311310e1d0 builds fine.
It only hurts bisectability.
All errors (new ones prefixed by >>):
lib/dynamic_debug.c: In function 'ddebug_trace':
>> lib/dynamic_debug.c:754:6: error: assignment to 'struct dynamic_trace_buf *' from incompatible pointer type 'struct ddebug_trace_buf *' [-Werror=incompatible-pointer-types]
754 | buf = this_cpu_ptr(ddebug_trace_bufs.bufs) + bufidx;
| ^
>> lib/dynamic_debug.c:756:22: error: dereferencing pointer to incomplete type 'struct dynamic_trace_buf'
756 | len = vscnprintf(buf->buf, sizeof(buf->buf), fmt, args);
| ^~
cc1: some warnings being treated as errors
vim +754 lib/dynamic_debug.c
737
738 static void ddebug_trace(const char *fmt, va_list args)
739 {
740 struct dynamic_trace_buf *buf;
741 int bufidx;
742 int len;
743
744 preempt_disable_notrace();
745
746 bufidx = __this_cpu_inc_return(ddebug_trace_reserve) - 1;
747
748 if (WARN_ON_ONCE(bufidx > DYNAMIC_TRACE_NESTING))
749 goto out;
750
751 /* For the same reasons as in __ftrace_trace_stack(). */
752 barrier();
753
> 754 buf = this_cpu_ptr(ddebug_trace_bufs.bufs) + bufidx;
755
> 756 len = vscnprintf(buf->buf, sizeof(buf->buf), fmt, args);
757 trace_console(buf->buf, len);
758
759 out:
760 /* As above. */
761 barrier();
762 __this_cpu_dec(ddebug_trace_reserve);
763 preempt_enable_notrace();
764 }
765
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
7 months, 1 week
[PATCH] spi: spi-xilinx: fix for_each_child.cocci warnings
by Julia Lawall
From: kernel test robot <lkp(a)intel.com>
After for_each_available_child_of_node, of_node_put is needed before break
and return.
Generated by: scripts/coccinelle/iterators/for_each_child.cocci
Fixes: 3973536c4560 ("spi: spi-xilinx: Updated axi-qspi controller driver")
CC: Amit Kumar Mahapatra <amit.kumar-mahapatra(a)xilinx.com>
Reported-by: kernel test robot <lkp(a)intel.com>
Signed-off-by: kernel test robot <lkp(a)intel.com>
Signed-off-by: Julia Lawall <julia.lawall(a)inria.fr>
---
tree: https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.15
head: 1183ce490adb103e5e569b8ebd74c50c885ddc05
commit: 3973536c456079bf3d09e9a97bf33d29422b183f [861/872] spi: spi-xilinx: Updated axi-qspi controller driver
:::::: branch date: 7 days ago
:::::: commit date: 7 days ago
spi-xilinx.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
--- a/drivers/spi/spi-xilinx.c
+++ b/drivers/spi/spi-xilinx.c
@@ -693,13 +693,16 @@ static int xilinx_spi_probe(struct platf
if (startup_block) {
ret = of_property_read_u32(nc, "reg",
&cs_num);
- if (ret < 0)
+ if (ret < 0) {
+ of_node_put(nc);
return -EINVAL;
+ }
}
ret = of_property_read_u32(nc, "spi-rx-bus-width",
&rx_bus_width);
if (!ret) {
xspi->rx_bus_width = rx_bus_width;
+ of_node_put(nc);
break;
}
}
7 months, 1 week
[linux-nvme:nvme-5.17 1/2] drivers/nvme/host/tcp.c:920:25: sparse: sparse: incorrect type in argument 2 (different base types)
by kernel test robot
tree: git://git.infradead.org/nvme.git nvme-5.17
head: 5c66f610f0be01358a3bb037fce6ae5744e225d2
commit: 52100021775a35eef08e493acabe3deb31847cb8 [1/2] nvme-tcp: fix bogus request completion when failing to send AER
config: x86_64-randconfig-s021 (https://download.01.org/0day-ci/archive/20220209/202202092122.25VLa0rQ-lk...)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.4-dirty
git remote add linux-nvme git://git.infradead.org/nvme.git
git fetch --no-tags linux-nvme nvme-5.17
git checkout 52100021775a35eef08e493acabe3deb31847cb8
# save the config file to linux build tree
mkdir build_dir
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/nvme/host/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
>> drivers/nvme/host/tcp.c:920:25: sparse: sparse: incorrect type in argument 2 (different base types) @@ expected restricted __le16 [usertype] status @@ got int @@
drivers/nvme/host/tcp.c:920:25: sparse: expected restricted __le16 [usertype] status
drivers/nvme/host/tcp.c:920:25: sparse: got int
vim +920 drivers/nvme/host/tcp.c
913
914 static void nvme_tcp_fail_request(struct nvme_tcp_request *req)
915 {
916 if (nvme_tcp_async_req(req)) {
917 union nvme_result res = {};
918
919 nvme_complete_async_event(&req->queue->ctrl->ctrl,
> 920 NVME_SC_HOST_PATH_ERROR, &res);
921 } else {
922 nvme_tcp_end_request(blk_mq_rq_from_pdu(req),
923 NVME_SC_HOST_PATH_ERROR);
924 }
925 }
926
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
7 months, 1 week
[peterz-queue:sched/core 29/29] kernel/sched/fair.c:230:9: error: implicit declaration of function 'sched_cfs_bandwidth_sysctl_init'
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git sched/core
head: bf8d9ef490e0600b3b30ac2244858ecd327123ab
commit: bf8d9ef490e0600b3b30ac2244858ecd327123ab [29/29] sched: Move cfs_bandwidth_slice sysctls to fair.c
config: powerpc-allnoconfig (https://download.01.org/0day-ci/archive/20220209/202202092104.f0q3gfHV-lk...)
compiler: powerpc-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git/commit/?...
git remote add peterz-queue https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git
git fetch --no-tags peterz-queue sched/core
git checkout bf8d9ef490e0600b3b30ac2244858ecd327123ab
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=powerpc SHELL=/bin/bash kernel/sched/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
kernel/sched/fair.c: In function 'sched_init_granularity':
>> kernel/sched/fair.c:230:9: error: implicit declaration of function 'sched_cfs_bandwidth_sysctl_init' [-Werror=implicit-function-declaration]
230 | sched_cfs_bandwidth_sysctl_init();
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/sched/fair.c: At top level:
kernel/sched/fair.c:652:5: warning: no previous prototype for 'sched_update_scaling' [-Wmissing-prototypes]
652 | int sched_update_scaling(void)
| ^~~~~~~~~~~~~~~~~~~~
kernel/sched/fair.c:5469:6: warning: no previous prototype for 'init_cfs_bandwidth' [-Wmissing-prototypes]
5469 | void init_cfs_bandwidth(struct cfs_bandwidth *cfs_b) {}
| ^~~~~~~~~~~~~~~~~~
kernel/sched/fair.c:11694:6: warning: no previous prototype for 'free_fair_sched_group' [-Wmissing-prototypes]
11694 | void free_fair_sched_group(struct task_group *tg) { }
| ^~~~~~~~~~~~~~~~~~~~~
kernel/sched/fair.c:11696:5: warning: no previous prototype for 'alloc_fair_sched_group' [-Wmissing-prototypes]
11696 | int alloc_fair_sched_group(struct task_group *tg, struct task_group *parent)
| ^~~~~~~~~~~~~~~~~~~~~~
kernel/sched/fair.c:11701:6: warning: no previous prototype for 'online_fair_sched_group' [-Wmissing-prototypes]
11701 | void online_fair_sched_group(struct task_group *tg) { }
| ^~~~~~~~~~~~~~~~~~~~~~~
kernel/sched/fair.c:11703:6: warning: no previous prototype for 'unregister_fair_sched_group' [-Wmissing-prototypes]
11703 | void unregister_fair_sched_group(struct task_group *tg) { }
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/sched_cfs_bandwidth_sysctl_init +230 kernel/sched/fair.c
226
227 void __init sched_init_granularity(void)
228 {
229 update_sysctl();
> 230 sched_cfs_bandwidth_sysctl_init();
231 }
232
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
7 months, 1 week
[peterz-queue:sched/core 29/29] kernel/sched/fair.c:230:2: error: implicit declaration of function 'sched_cfs_bandwidth_sysctl_init'
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git sched/core
head: bf8d9ef490e0600b3b30ac2244858ecd327123ab
commit: bf8d9ef490e0600b3b30ac2244858ecd327123ab [29/29] sched: Move cfs_bandwidth_slice sysctls to fair.c
config: hexagon-randconfig-r045-20220209 (https://download.01.org/0day-ci/archive/20220209/202202092107.WdTEsmSF-lk...)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project e8bff9ae54a55b4dbfeb6ba55f723abbd81bf494)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git/commit/?...
git remote add peterz-queue https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git
git fetch --no-tags peterz-queue sched/core
git checkout bf8d9ef490e0600b3b30ac2244858ecd327123ab
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash kernel/sched/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> kernel/sched/fair.c:230:2: error: implicit declaration of function 'sched_cfs_bandwidth_sysctl_init' [-Werror,-Wimplicit-function-declaration]
sched_cfs_bandwidth_sysctl_init();
^
kernel/sched/fair.c:652:5: warning: no previous prototype for function 'sched_update_scaling' [-Wmissing-prototypes]
int sched_update_scaling(void)
^
kernel/sched/fair.c:652:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int sched_update_scaling(void)
^
static
kernel/sched/fair.c:5469:6: warning: no previous prototype for function 'init_cfs_bandwidth' [-Wmissing-prototypes]
void init_cfs_bandwidth(struct cfs_bandwidth *cfs_b) {}
^
kernel/sched/fair.c:5469:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void init_cfs_bandwidth(struct cfs_bandwidth *cfs_b) {}
^
static
kernel/sched/fair.c:11694:6: warning: no previous prototype for function 'free_fair_sched_group' [-Wmissing-prototypes]
void free_fair_sched_group(struct task_group *tg) { }
^
kernel/sched/fair.c:11694:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void free_fair_sched_group(struct task_group *tg) { }
^
static
kernel/sched/fair.c:11696:5: warning: no previous prototype for function 'alloc_fair_sched_group' [-Wmissing-prototypes]
int alloc_fair_sched_group(struct task_group *tg, struct task_group *parent)
^
kernel/sched/fair.c:11696:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int alloc_fair_sched_group(struct task_group *tg, struct task_group *parent)
^
static
kernel/sched/fair.c:11701:6: warning: no previous prototype for function 'online_fair_sched_group' [-Wmissing-prototypes]
void online_fair_sched_group(struct task_group *tg) { }
^
kernel/sched/fair.c:11701:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void online_fair_sched_group(struct task_group *tg) { }
^
static
kernel/sched/fair.c:11703:6: warning: no previous prototype for function 'unregister_fair_sched_group' [-Wmissing-prototypes]
void unregister_fair_sched_group(struct task_group *tg) { }
^
kernel/sched/fair.c:11703:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void unregister_fair_sched_group(struct task_group *tg) { }
^
static
6 warnings and 1 error generated.
vim +/sched_cfs_bandwidth_sysctl_init +230 kernel/sched/fair.c
226
227 void __init sched_init_granularity(void)
228 {
229 update_sysctl();
> 230 sched_cfs_bandwidth_sysctl_init();
231 }
232
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
7 months, 1 week
