[xilinx-xlnx:xlnx_rebase_v5.15 132/872] drivers/clk/clk-xlnx-clock-wizard.c:309:8: error: implicit declaration of function 'FIELD_PREP'
by kernel test robot
tree: https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.15
head: 1183ce490adb103e5e569b8ebd74c50c885ddc05
commit: e7cc160039f02d71ef5a3b16038d325ad76ab59e [132/872] clocking-wizard: Support higher frequency accuracy
config: x86_64-randconfig-a002-20220207 (https://download.01.org/0day-ci/archive/20220208/202202081516.4zYCwhp4-lk...)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project e8bff9ae54a55b4dbfeb6ba55f723abbd81bf494)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/Xilinx/linux-xlnx/commit/e7cc160039f02d71ef5a3b16038d3...
git remote add xilinx-xlnx https://github.com/Xilinx/linux-xlnx
git fetch --no-tags xilinx-xlnx xlnx_rebase_v5.15
git checkout e7cc160039f02d71ef5a3b16038d325ad76ab59e
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> drivers/clk/clk-xlnx-clock-wizard.c:309:8: error: implicit declaration of function 'FIELD_PREP' [-Werror,-Wimplicit-function-declaration]
reg = FIELD_PREP(WZRD_CLKOUT_DIVIDE_MASK, clockout0_div) |
^
>> drivers/clk/clk-xlnx-clock-wizard.c:369:6: error: implicit declaration of function 'FIELD_GET' [-Werror,-Wimplicit-function-declaration]
d = FIELD_GET(WZRD_DIVCLK_DIVIDE_MASK, reg);
^
2 errors generated.
vim +/FIELD_PREP +309 drivers/clk/clk-xlnx-clock-wizard.c
286
287 static int clk_wzrd_dynamic_all_nolock(struct clk_hw *hw, unsigned long rate,
288 unsigned long parent_rate)
289 {
290 struct clk_wzrd_divider *divider = to_clk_wzrd_divider(hw);
291 u32 reg, pre;
292 u32 value;
293 int err;
294 u64 vco_freq, rate_div, f, clockout0_div;
295
296 err = clk_wzrd_get_divisors(hw, rate, parent_rate);
297 if (err)
298 pr_err("failed to get divisors\n");
299
300 vco_freq = DIV_ROUND_CLOSEST((parent_rate * divider->valuem), divider->valued);
301 rate_div = DIV_ROUND_CLOSEST((vco_freq * WZRD_FRAC_POINTS), rate);
302
303 clockout0_div = rate_div / WZRD_FRAC_POINTS;
304
305 pre = DIV_ROUND_CLOSEST((vco_freq * WZRD_FRAC_POINTS), rate);
306 f = (u32)(pre - (clockout0_div * WZRD_FRAC_POINTS));
307 f = f & WZRD_CLKOUT_FRAC_MASK;
308
> 309 reg = FIELD_PREP(WZRD_CLKOUT_DIVIDE_MASK, clockout0_div) |
310 FIELD_PREP(WZRD_CLKOUT0_FRAC_MASK, f);
311
312 writel(reg, divider->base + WZRD_CLK_CFG_REG(2));
313 /* Set divisor and clear phase offset */
314 reg = FIELD_PREP(WZRD_CLKFBOUT_MULT_MASK, divider->valuem) |
315 FIELD_PREP(WZRD_DIVCLK_DIVIDE_MASK, divider->valued);
316 writel(reg, divider->base + WZRD_CLK_CFG_REG(0));
317 writel(divider->valueo, divider->base + WZRD_CLK_CFG_REG(2));
318 writel(0, divider->base + WZRD_CLK_CFG_REG(3));
319 /* Check status register */
320 err = readl_poll_timeout(divider->base + WZRD_DR_STATUS_REG_OFFSET, value,
321 value & WZRD_DR_LOCK_BIT_MASK,
322 WZRD_USEC_POLL, WZRD_TIMEOUT_POLL);
323 if (err)
324 return -ETIMEDOUT;
325
326 /* Initiate reconfiguration */
327 writel(WZRD_DR_BEGIN_DYNA_RECONF,
328 divider->base + WZRD_DR_INIT_REG_OFFSET);
329
330 /* Check status register */
331 err = readl_poll_timeout(divider->base + WZRD_DR_STATUS_REG_OFFSET, value,
332 value & WZRD_DR_LOCK_BIT_MASK,
333 WZRD_USEC_POLL, WZRD_TIMEOUT_POLL);
334 if (err)
335 return -ETIMEDOUT;
336
337 return 0;
338 }
339
340 static int clk_wzrd_dynamic_all(struct clk_hw *hw, unsigned long rate,
341 unsigned long parent_rate)
342 {
343 struct clk_wzrd_divider *divider = to_clk_wzrd_divider(hw);
344 unsigned long flags = 0;
345 int ret;
346
347 if (divider->lock)
348 spin_lock_irqsave(divider->lock, flags);
349 else
350 __acquire(divider->lock);
351
352 ret = clk_wzrd_dynamic_all_nolock(hw, rate, parent_rate);
353
354 if (divider->lock)
355 spin_unlock_irqrestore(divider->lock, flags);
356 else
357 __release(divider->lock);
358
359 return ret;
360 }
361
362 static unsigned long clk_wzrd_recalc_rate_all(struct clk_hw *hw,
363 unsigned long parent_rate)
364 {
365 struct clk_wzrd_divider *divider = to_clk_wzrd_divider(hw);
366 u32 m, d, o, div, reg, f;
367
368 reg = readl(divider->base + WZRD_CLK_CFG_REG(0));
> 369 d = FIELD_GET(WZRD_DIVCLK_DIVIDE_MASK, reg);
370 m = FIELD_GET(WZRD_CLKFBOUT_MULT_MASK, reg);
371 reg = readl(divider->base + WZRD_CLK_CFG_REG(2));
372 o = FIELD_GET(WZRD_DIVCLK_DIVIDE_MASK, reg);
373 f = FIELD_GET(WZRD_CLKOUT0_FRAC_MASK, reg);
374
375 div = DIV_ROUND_CLOSEST(d * (WZRD_FRAC_POINTS * o + f), WZRD_FRAC_POINTS);
376 return divider_recalc_rate(hw, parent_rate * m, div, divider->table,
377 divider->flags, divider->width);
378 }
379
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
7 months, 2 weeks
[xilinx-xlnx:xlnx_rebase_v5.15 72/872] drivers/mtd/spi-nor/core.c:1891 spi_nor_read_id() error: we previously assumed 'nor->spimem' could be null (see line 1873)
by Dan Carpenter
tree: https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.15
head: 1183ce490adb103e5e569b8ebd74c50c885ddc05
commit: 87a0aa695a2dbabc2d1a24acbb421529ea53c59e [72/872] spi: spi-cadence-quadspi: Add support for DDR PHY mode
config: x86_64-randconfig-m001-20220207 (https://download.01.org/0day-ci/archive/20220208/202202081251.fIdJevWf-lk...)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
smatch warnings:
drivers/mtd/spi-nor/core.c:1891 spi_nor_read_id() error: we previously assumed 'nor->spimem' could be null (see line 1873)
vim +1891 drivers/mtd/spi-nor/core.c
06bb6f5a69dfc5 drivers/mtd/spi-nor/spi-nor.c Rafał Miłecki 2015-08-10 1866 static const struct flash_info *spi_nor_read_id(struct spi_nor *nor)
b199489d37b21c drivers/mtd/spi-nor/spi-nor.c Huang Shijie 2014-02-24 1867 {
9ec4bbcb2044ea drivers/mtd/spi-nor/core.c Boris Brezillon 2020-03-13 1868 const struct flash_info *info;
f173f26a4d543f drivers/mtd/spi-nor/spi-nor.c Vignesh Raghavendra 2019-08-06 1869 u8 *id = nor->bouncebuf;
2dcbfe365b1303 drivers/mtd/spi-nor/spi-nor.c Jonathan Neuschäfer 2020-02-23 1870 unsigned int i;
2dcbfe365b1303 drivers/mtd/spi-nor/spi-nor.c Jonathan Neuschäfer 2020-02-23 1871 int ret;
b199489d37b21c drivers/mtd/spi-nor/spi-nor.c Huang Shijie 2014-02-24 1872
b35b9a10362d20 drivers/mtd/spi-nor/spi-nor.c Boris Brezillon 2019-08-06 @1873 if (nor->spimem) {
^^^^^^^^^^^
Check for NULL
b35b9a10362d20 drivers/mtd/spi-nor/spi-nor.c Boris Brezillon 2019-08-06 1874 struct spi_mem_op op =
b35b9a10362d20 drivers/mtd/spi-nor/spi-nor.c Boris Brezillon 2019-08-06 1875 SPI_MEM_OP(SPI_MEM_OP_CMD(SPINOR_OP_RDID, 1),
b35b9a10362d20 drivers/mtd/spi-nor/spi-nor.c Boris Brezillon 2019-08-06 1876 SPI_MEM_OP_NO_ADDR,
b35b9a10362d20 drivers/mtd/spi-nor/spi-nor.c Boris Brezillon 2019-08-06 1877 SPI_MEM_OP_NO_DUMMY,
b35b9a10362d20 drivers/mtd/spi-nor/spi-nor.c Boris Brezillon 2019-08-06 1878 SPI_MEM_OP_DATA_IN(SPI_NOR_MAX_ID_LEN, id, 1));
b35b9a10362d20 drivers/mtd/spi-nor/spi-nor.c Boris Brezillon 2019-08-06 1879
2dcbfe365b1303 drivers/mtd/spi-nor/spi-nor.c Jonathan Neuschäfer 2020-02-23 1880 ret = spi_mem_exec_op(nor->spimem, &op);
b35b9a10362d20 drivers/mtd/spi-nor/spi-nor.c Boris Brezillon 2019-08-06 1881 } else {
2dcbfe365b1303 drivers/mtd/spi-nor/spi-nor.c Jonathan Neuschäfer 2020-02-23 1882 ret = nor->controller_ops->read_reg(nor, SPINOR_OP_RDID, id,
b35b9a10362d20 drivers/mtd/spi-nor/spi-nor.c Boris Brezillon 2019-08-06 1883 SPI_NOR_MAX_ID_LEN);
b35b9a10362d20 drivers/mtd/spi-nor/spi-nor.c Boris Brezillon 2019-08-06 1884 }
2dcbfe365b1303 drivers/mtd/spi-nor/spi-nor.c Jonathan Neuschäfer 2020-02-23 1885 if (ret) {
2dcbfe365b1303 drivers/mtd/spi-nor/spi-nor.c Jonathan Neuschäfer 2020-02-23 1886 dev_dbg(nor->dev, "error %d reading JEDEC ID\n", ret);
2dcbfe365b1303 drivers/mtd/spi-nor/spi-nor.c Jonathan Neuschäfer 2020-02-23 1887 return ERR_PTR(ret);
b199489d37b21c drivers/mtd/spi-nor/spi-nor.c Huang Shijie 2014-02-24 1888 }
b199489d37b21c drivers/mtd/spi-nor/spi-nor.c Huang Shijie 2014-02-24 1889
87a0aa695a2dba drivers/mtd/spi-nor/core.c Sai Krishna Potthuri 2021-12-09 1890 for (i = 0; i < SPI_NOR_MAX_ID_LEN; i++)
87a0aa695a2dba drivers/mtd/spi-nor/core.c Sai Krishna Potthuri 2021-12-09 @1891 nor->spimem->device_id[i] = id[i];
^^^^^^^^^^^^^
Unchecked dereference
87a0aa695a2dba drivers/mtd/spi-nor/core.c Sai Krishna Potthuri 2021-12-09 1892
9ec4bbcb2044ea drivers/mtd/spi-nor/core.c Boris Brezillon 2020-03-13 1893 for (i = 0; i < ARRAY_SIZE(manufacturers); i++) {
9ec4bbcb2044ea drivers/mtd/spi-nor/core.c Boris Brezillon 2020-03-13 1894 info = spi_nor_search_part_by_id(manufacturers[i]->parts,
9ec4bbcb2044ea drivers/mtd/spi-nor/core.c Boris Brezillon 2020-03-13 1895 manufacturers[i]->nparts,
9ec4bbcb2044ea drivers/mtd/spi-nor/core.c Boris Brezillon 2020-03-13 1896 id);
9ec4bbcb2044ea drivers/mtd/spi-nor/core.c Boris Brezillon 2020-03-13 1897 if (info) {
9ec4bbcb2044ea drivers/mtd/spi-nor/core.c Boris Brezillon 2020-03-13 1898 nor->manufacturer = manufacturers[i];
9ec4bbcb2044ea drivers/mtd/spi-nor/core.c Boris Brezillon 2020-03-13 1899 return info;
b199489d37b21c drivers/mtd/spi-nor/spi-nor.c Huang Shijie 2014-02-24 1900 }
9ec4bbcb2044ea drivers/mtd/spi-nor/core.c Boris Brezillon 2020-03-13 1901 }
9ec4bbcb2044ea drivers/mtd/spi-nor/core.c Boris Brezillon 2020-03-13 1902
3ddc8adbbc7683 drivers/mtd/spi-nor/spi-nor.c Geert Uytterhoeven 2019-03-12 1903 dev_err(nor->dev, "unrecognized JEDEC id bytes: %*ph\n",
3ddc8adbbc7683 drivers/mtd/spi-nor/spi-nor.c Geert Uytterhoeven 2019-03-12 1904 SPI_NOR_MAX_ID_LEN, id);
b199489d37b21c drivers/mtd/spi-nor/spi-nor.c Huang Shijie 2014-02-24 1905 return ERR_PTR(-ENODEV);
b199489d37b21c drivers/mtd/spi-nor/spi-nor.c Huang Shijie 2014-02-24 1906 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
7 months, 2 weeks
