Re: [PATCH v2 05/15] staging: r8188eu: remove DBG_88E calls from hal subdir
by kernel test robot
Hi Phillip,
I love your patch! Perhaps something to improve:
[auto build test WARNING on staging/staging-testing]
url: https://github.com/0day-ci/linux/commits/Phillip-Potter/staging-r8188eu-C...
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git e9685834b1db754cbd07e31ad1a091f5d366dacf
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20220217/202202170549.Ns7hoYfn-lk...)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 0e628a783b935c70c80815db6c061ec84f884af5)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/b481114992de793aca50ace1616b6b394...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Phillip-Potter/staging-r8188eu-Cleanup-and-removal-of-DBG_88E-macro/20220216-090900
git checkout b481114992de793aca50ace1616b6b3947fde0a0
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/leds/ drivers/net/ethernet/mellanox/mlxsw/ drivers/platform/chrome/ drivers/staging/r8188eu/ mm/damon/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/staging/r8188eu/hal/usb_halinit.c:1546:6: warning: variable 'arg' set but not used [-Wunused-but-set-variable]
u8 arg;
^
1 warning generated.
vim +/arg +1546 drivers/staging/r8188eu/hal/usb_halinit.c
8cd574e6af5463a Phillip Potter 2021-07-28 1490
b561d2f0dc01ab0 Michael Straube 2021-09-06 1491 void UpdateHalRAMask8188EUsb(struct adapter *adapt, u32 mac_id, u8 rssi_level)
8cd574e6af5463a Phillip Potter 2021-07-28 1492 {
8cd574e6af5463a Phillip Potter 2021-07-28 1493 u8 init_rate = 0;
8cd574e6af5463a Phillip Potter 2021-07-28 1494 u8 networkType, raid;
8cd574e6af5463a Phillip Potter 2021-07-28 1495 u32 mask, rate_bitmap;
8cd574e6af5463a Phillip Potter 2021-07-28 1496 u8 shortGIrate = false;
8cd574e6af5463a Phillip Potter 2021-07-28 1497 int supportRateNum = 0;
8cd574e6af5463a Phillip Potter 2021-07-28 1498 struct sta_info *psta;
d904512db6f3727 Michael Straube 2021-12-07 1499 struct hal_data_8188e *haldata = &adapt->haldata;
8cd574e6af5463a Phillip Potter 2021-07-28 1500 struct mlme_ext_priv *pmlmeext = &adapt->mlmeextpriv;
6839ff57baa4a60 Michael Straube 2021-08-09 1501 struct mlme_ext_info *pmlmeinfo = &pmlmeext->mlmext_info;
6839ff57baa4a60 Michael Straube 2021-08-09 1502 struct wlan_bssid_ex *cur_network = &pmlmeinfo->network;
8cd574e6af5463a Phillip Potter 2021-07-28 1503
8cd574e6af5463a Phillip Potter 2021-07-28 1504 if (mac_id >= NUM_STA) /* CAM_SIZE */
8cd574e6af5463a Phillip Potter 2021-07-28 1505 return;
8cd574e6af5463a Phillip Potter 2021-07-28 1506 psta = pmlmeinfo->FW_sta_info[mac_id].psta;
725a3f1c4d56b73 Michael Straube 2021-08-01 1507 if (!psta)
8cd574e6af5463a Phillip Potter 2021-07-28 1508 return;
8cd574e6af5463a Phillip Potter 2021-07-28 1509 switch (mac_id) {
8cd574e6af5463a Phillip Potter 2021-07-28 1510 case 0:/* for infra mode */
8cd574e6af5463a Phillip Potter 2021-07-28 1511 supportRateNum = rtw_get_rateset_len(cur_network->SupportedRates);
8cd574e6af5463a Phillip Potter 2021-07-28 1512 networkType = judge_network_type(adapt, cur_network->SupportedRates, supportRateNum) & 0xf;
8cd574e6af5463a Phillip Potter 2021-07-28 1513 raid = networktype_to_raid(networkType);
8cd574e6af5463a Phillip Potter 2021-07-28 1514 mask = update_supported_rate(cur_network->SupportedRates, supportRateNum);
6839ff57baa4a60 Michael Straube 2021-08-09 1515 mask |= (pmlmeinfo->HT_enable) ? update_MSC_rate(&pmlmeinfo->HT_caps) : 0;
6839ff57baa4a60 Michael Straube 2021-08-09 1516 if (support_short_GI(adapt, &pmlmeinfo->HT_caps))
8cd574e6af5463a Phillip Potter 2021-07-28 1517 shortGIrate = true;
8cd574e6af5463a Phillip Potter 2021-07-28 1518 break;
8cd574e6af5463a Phillip Potter 2021-07-28 1519 case 1:/* for broadcast/multicast */
8cd574e6af5463a Phillip Potter 2021-07-28 1520 supportRateNum = rtw_get_rateset_len(pmlmeinfo->FW_sta_info[mac_id].SupportedRates);
8cd574e6af5463a Phillip Potter 2021-07-28 1521 if (pmlmeext->cur_wireless_mode & WIRELESS_11B)
8cd574e6af5463a Phillip Potter 2021-07-28 1522 networkType = WIRELESS_11B;
8cd574e6af5463a Phillip Potter 2021-07-28 1523 else
8cd574e6af5463a Phillip Potter 2021-07-28 1524 networkType = WIRELESS_11G;
8cd574e6af5463a Phillip Potter 2021-07-28 1525 raid = networktype_to_raid(networkType);
8cd574e6af5463a Phillip Potter 2021-07-28 1526 mask = update_basic_rate(cur_network->SupportedRates, supportRateNum);
8cd574e6af5463a Phillip Potter 2021-07-28 1527 break;
8cd574e6af5463a Phillip Potter 2021-07-28 1528 default: /* for each sta in IBSS */
8cd574e6af5463a Phillip Potter 2021-07-28 1529 supportRateNum = rtw_get_rateset_len(pmlmeinfo->FW_sta_info[mac_id].SupportedRates);
8cd574e6af5463a Phillip Potter 2021-07-28 1530 networkType = judge_network_type(adapt, pmlmeinfo->FW_sta_info[mac_id].SupportedRates, supportRateNum) & 0xf;
8cd574e6af5463a Phillip Potter 2021-07-28 1531 raid = networktype_to_raid(networkType);
8cd574e6af5463a Phillip Potter 2021-07-28 1532 mask = update_supported_rate(cur_network->SupportedRates, supportRateNum);
8cd574e6af5463a Phillip Potter 2021-07-28 1533
8cd574e6af5463a Phillip Potter 2021-07-28 1534 /* todo: support HT in IBSS */
8cd574e6af5463a Phillip Potter 2021-07-28 1535 break;
8cd574e6af5463a Phillip Potter 2021-07-28 1536 }
8cd574e6af5463a Phillip Potter 2021-07-28 1537
8cd574e6af5463a Phillip Potter 2021-07-28 1538 rate_bitmap = 0x0fffffff;
8cd574e6af5463a Phillip Potter 2021-07-28 1539 rate_bitmap = ODM_Get_Rate_Bitmap(&haldata->odmpriv, mac_id, mask, rssi_level);
8cd574e6af5463a Phillip Potter 2021-07-28 1540
8cd574e6af5463a Phillip Potter 2021-07-28 1541 mask &= rate_bitmap;
8cd574e6af5463a Phillip Potter 2021-07-28 1542
8cd574e6af5463a Phillip Potter 2021-07-28 1543 init_rate = get_highest_rate_idx(mask) & 0x3f;
8cd574e6af5463a Phillip Potter 2021-07-28 1544
8cd574e6af5463a Phillip Potter 2021-07-28 1545 if (haldata->fw_ractrl) {
8cd574e6af5463a Phillip Potter 2021-07-28 @1546 u8 arg;
8cd574e6af5463a Phillip Potter 2021-07-28 1547
8cd574e6af5463a Phillip Potter 2021-07-28 1548 arg = mac_id & 0x1f;/* MACID */
8cd574e6af5463a Phillip Potter 2021-07-28 1549 arg |= BIT(7);
8cd574e6af5463a Phillip Potter 2021-07-28 1550 if (shortGIrate)
8cd574e6af5463a Phillip Potter 2021-07-28 1551 arg |= BIT(5);
8cd574e6af5463a Phillip Potter 2021-07-28 1552 mask |= ((raid << 28) & 0xf0000000);
8cd574e6af5463a Phillip Potter 2021-07-28 1553 psta->ra_mask = mask;
8cd574e6af5463a Phillip Potter 2021-07-28 1554 mask |= ((raid << 28) & 0xf0000000);
8cd574e6af5463a Phillip Potter 2021-07-28 1555
8cd574e6af5463a Phillip Potter 2021-07-28 1556 /* to do ,for 8188E-SMIC */
8cd574e6af5463a Phillip Potter 2021-07-28 1557 rtl8188e_set_raid_cmd(adapt, mask);
8cd574e6af5463a Phillip Potter 2021-07-28 1558 } else {
6839ff57baa4a60 Michael Straube 2021-08-09 1559 ODM_RA_UpdateRateInfo_8188E(&haldata->odmpriv,
8cd574e6af5463a Phillip Potter 2021-07-28 1560 mac_id,
8cd574e6af5463a Phillip Potter 2021-07-28 1561 raid,
8cd574e6af5463a Phillip Potter 2021-07-28 1562 mask,
8cd574e6af5463a Phillip Potter 2021-07-28 1563 shortGIrate
8cd574e6af5463a Phillip Potter 2021-07-28 1564 );
8cd574e6af5463a Phillip Potter 2021-07-28 1565 }
8cd574e6af5463a Phillip Potter 2021-07-28 1566 /* set ra_id */
8cd574e6af5463a Phillip Potter 2021-07-28 1567 psta->raid = raid;
8cd574e6af5463a Phillip Potter 2021-07-28 1568 psta->init_rate = init_rate;
8cd574e6af5463a Phillip Potter 2021-07-28 1569 }
8cd574e6af5463a Phillip Potter 2021-07-28 1570
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
7 months
[ammarfaizi2-block:dhowells/linux-fs/netfs-maple 29/42] fs/netfs/buffered_write.c:610:58: error: 'struct netfs_i_context' has no member named 'cache'
by kernel test robot
tree: https://github.com/ammarfaizi2/linux-block dhowells/linux-fs/netfs-maple
head: 5cb7f190822d09757b30cd9539e57eef72552d1f
commit: 261cd621bd0477d43de460dea6c7bf7fa81824be [29/42] netfs: Implement buffered writes through netfs_file_write_iter()
config: powerpc64-randconfig-m031-20220216 (https://download.01.org/0day-ci/archive/20220217/202202170410.fCsMg7GT-lk...)
compiler: powerpc64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/ammarfaizi2/linux-block/commit/261cd621bd0477d43de460d...
git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
git fetch --no-tags ammarfaizi2-block dhowells/linux-fs/netfs-maple
git checkout 261cd621bd0477d43de460dea6c7bf7fa81824be
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=powerpc SHELL=/bin/bash fs/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
fs/netfs/buffered_write.c: In function 'netfs_perform_write':
>> fs/netfs/buffered_write.c:610:58: error: 'struct netfs_i_context' has no member named 'cache'
610 | fscache_update_cookie(ctx->cache, NULL, &pos);
| ^~
vim +610 fs/netfs/buffered_write.c
453
454 /*
455 * Write data into a prereserved region of the pagecache attached to a netfs
456 * inode.
457 */
458 static ssize_t netfs_perform_write(struct kiocb *iocb, struct iov_iter *iter)
459 {
460 struct netfs_dirty_region *spare_region = NULL;
461 struct file *file = iocb->ki_filp;
462 struct netfs_i_context *ctx = netfs_i_context(file_inode(file));
463 struct folio *folio;
464 enum netfs_handle_nonuptodate nupt;
465 ssize_t written = 0, ret;
466 loff_t i_size, pos = iocb->ki_pos;
467 bool always_fill = false;
468 bool locked = false;
469
470 MA_STATE(mas, &ctx->dirty_regions, pos / PAGE_SIZE,
471 (pos + iov_iter_count(iter) - 1) / PAGE_SIZE);
472
473 ret = ctx->ops->validate_for_write(file_inode(file), file);
474 if (ret < 0)
475 return ret;
476
477 do {
478 size_t plen;
479 size_t offset; /* Offset into pagecache folio */
480 size_t bytes; /* Bytes to write to folio */
481 size_t copied; /* Bytes copied from user */
482
483 folio = netfs_grab_folio_for_write(file->f_mapping,
484 pos / PAGE_SIZE,
485 iov_iter_count(iter));
486 if (!folio) {
487 ret = -ENOMEM;
488 goto out;
489 }
490
491 plen = folio_size(folio);
492 offset = pos - folio_file_pos(folio);
493 bytes = min_t(size_t, plen - offset, iov_iter_count(iter));
494 locked = true;
495
496 if (!folio_test_uptodate(folio)) {
497 folio_unlock(folio); /* Avoid deadlocking fault-in */
498 locked = false;
499 }
500
501 /* Bring in the user page that we will copy from _first_.
502 * Otherwise there's a nasty deadlock on copying from the same
503 * page as we're writing to, without it being marked
504 * up-to-date.
505 *
506 * Not only is this an optimisation, but it is also required to
507 * check that the address is actually valid, when atomic
508 * usercopies are used, below.
509 */
510 if (unlikely(fault_in_iov_iter_readable(iter, bytes))) {
511 ret = -EFAULT;
512 goto error_folio;
513 }
514
515 if (fatal_signal_pending(current)) {
516 ret = -EINTR;
517 goto error_folio;
518 }
519
520 if (!locked) {
521 ret = folio_lock_killable(folio);
522 if (ret < 0)
523 goto error_folio;
524 }
525
526 redo_prefetch:
527 /* See if we need to prefetch the area we're going to modify.
528 * We need to do this before we get a lock on the folio in case
529 * there's more than one writer competing for the same cache
530 * block.
531 */
532 nupt = netfs_handle_nonuptodate_folio(ctx, file, folio,
533 offset, bytes, always_fill);
534 _debug("nupt %u", nupt);
535 switch (nupt) {
536 case NETFS_JUST_PREFETCH:
537 ret = netfs_prefetch_for_write(file, folio, bytes);
538 if (ret < 0) {
539 _debug("prefetch = %zd", ret);
540 goto error_folio;
541 }
542 nupt = NETFS_FOLIO_IS_UPTODATE;
543 fallthrough;
544 case NETFS_FOLIO_IS_UPTODATE:
545 break;
546 case NETFS_MODIFY_AND_CLEAR:
547 zero_user_segment(&folio->page, 0, offset);
548 break;
549 case NETFS_WHOLE_FOLIO_MODIFY:
550 break;
551 }
552
553 /* Preallocate the space we need in the dirty region list. */
554 ret = mas_expected_entries(&mas, 1);
555 if (ret < 0)
556 goto error_folio;
557
558 if (!spare_region) {
559 spare_region = netfs_alloc_dirty_region();
560 if (IS_ERR(spare_region)) {
561 ret = PTR_ERR(spare_region);
562 spare_region = NULL;
563 goto error_folio;
564 }
565 }
566
567 if (mapping_writably_mapped(folio_file_mapping(folio)))
568 flush_dcache_folio(folio);
569 copied = copy_folio_from_iter_atomic(folio, offset, bytes, iter);
570 flush_dcache_folio(folio);
571
572 /* Deal with a (partially) failed copy */
573 if (!folio_test_uptodate(folio)) {
574 if (copied == 0) {
575 ret = -EFAULT;
576 goto error_folio;
577 }
578 if (copied < bytes) {
579 iov_iter_revert(iter, copied);
580 always_fill = true;
581 goto redo_prefetch;
582 }
583 switch (nupt) {
584 case NETFS_JUST_PREFETCH:
585 case NETFS_FOLIO_IS_UPTODATE:
586 /* We have the folio locked, so it really ought
587 * to be uptodate.
588 */
589 WARN(true, "Locked folio %lx became non-uptodate\n",
590 folio_index(folio));
591 ret = -EIO;
592 goto error_folio;
593 case NETFS_MODIFY_AND_CLEAR:
594 zero_user_segment(&folio->page, offset + copied, plen);
595 fallthrough;
596 case NETFS_WHOLE_FOLIO_MODIFY:
597 folio_mark_uptodate(folio);
598 break;
599 }
600 }
601
602 /* Update the inode size if we moved the EOF marker */
603 pos += copied;
604 i_size = i_size_read(file_inode(file));
605 if (pos > i_size) {
606 if (ctx->ops->update_i_size) {
607 ctx->ops->update_i_size(file, pos);
608 } else {
609 i_size_write(file_inode(file), pos);
> 610 fscache_update_cookie(ctx->cache, NULL, &pos);
611 }
612 }
613
614 netfs_commit_folio(ctx, file, &spare_region, &mas,
615 folio, offset, copied);
616
617 folio_mark_dirty(folio);
618 folio_unlock(folio);
619 folio_put(folio);
620 folio = NULL;
621
622 cond_resched();
623
624 written += copied;
625
626 balance_dirty_pages_ratelimited(file->f_mapping);
627 } while (iov_iter_count(iter));
628
629 out:
630 if (likely(written)) {
631 netfs_commit_region(ctx, &mas, iocb->ki_pos, written);
632
633 iocb->ki_pos += written;
634
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
7 months
Re: [PATCH] net: dsa: lan9303: add VLAN IDs to master device
by kernel test robot
Hi Mans,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.17-rc4 next-20220216]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Mans-Rullgard/net-dsa-lan9303-ad...
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git c5d9ae265b105d9a67575fb67bd4650a6fc08e25
config: x86_64-randconfig-a005 (https://download.01.org/0day-ci/archive/20220217/202202170327.RiXqUeGc-lk...)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 0e628a783b935c70c80815db6c061ec84f884af5)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/960beb0e82f5d219a4f7e8bdcc49fb548...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Mans-Rullgard/net-dsa-lan9303-add-VLAN-IDs-to-master-device/20220216-231201
git checkout 960beb0e82f5d219a4f7e8bdcc49fb548a82a69d
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/net/dsa/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> drivers/net/dsa/lan9303-core.c:1095:2: error: implicit declaration of function 'vlan_vid_add' [-Werror,-Wimplicit-function-declaration]
vlan_vid_add(cpu_dp->master, htons(ETH_P_8021Q), port);
^
>> drivers/net/dsa/lan9303-core.c:1111:2: error: implicit declaration of function 'vlan_vid_del' [-Werror,-Wimplicit-function-declaration]
vlan_vid_del(cpu_dp->master, htons(ETH_P_8021Q), port);
^
2 errors generated.
vim +/vlan_vid_add +1095 drivers/net/dsa/lan9303-core.c
1082
1083 static int lan9303_port_enable(struct dsa_switch *ds, int port,
1084 struct phy_device *phy)
1085 {
1086 struct lan9303 *chip = ds->priv;
1087 struct dsa_port *cpu_dp;
1088
1089 if (!dsa_is_user_port(ds, port))
1090 return 0;
1091
1092 dsa_switch_for_each_cpu_port(cpu_dp, ds)
1093 break;
1094
> 1095 vlan_vid_add(cpu_dp->master, htons(ETH_P_8021Q), port);
1096
1097 return lan9303_enable_processing_port(chip, port);
1098 }
1099
1100 static void lan9303_port_disable(struct dsa_switch *ds, int port)
1101 {
1102 struct lan9303 *chip = ds->priv;
1103 struct dsa_port *cpu_dp;
1104
1105 if (!dsa_is_user_port(ds, port))
1106 return;
1107
1108 dsa_switch_for_each_cpu_port(cpu_dp, ds)
1109 break;
1110
> 1111 vlan_vid_del(cpu_dp->master, htons(ETH_P_8021Q), port);
1112
1113 lan9303_disable_processing_port(chip, port);
1114 lan9303_phy_write(ds, chip->phy_addr_base + port, MII_BMCR, BMCR_PDOWN);
1115 }
1116
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
7 months
Re: [PATCH] net: dsa: lan9303: add VLAN IDs to master device
by kernel test robot
Hi Mans,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.17-rc4 next-20220216]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Mans-Rullgard/net-dsa-lan9303-ad...
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git c5d9ae265b105d9a67575fb67bd4650a6fc08e25
config: openrisc-randconfig-r004-20220216 (https://download.01.org/0day-ci/archive/20220217/202202170354.djrMhJqt-lk...)
compiler: or1k-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/960beb0e82f5d219a4f7e8bdcc49fb548...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Mans-Rullgard/net-dsa-lan9303-add-VLAN-IDs-to-master-device/20220216-231201
git checkout 960beb0e82f5d219a4f7e8bdcc49fb548a82a69d
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=openrisc SHELL=/bin/bash drivers/net/dsa/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
drivers/net/dsa/lan9303-core.c: In function 'lan9303_port_enable':
>> drivers/net/dsa/lan9303-core.c:1095:9: error: implicit declaration of function 'vlan_vid_add' [-Werror=implicit-function-declaration]
1095 | vlan_vid_add(cpu_dp->master, htons(ETH_P_8021Q), port);
| ^~~~~~~~~~~~
drivers/net/dsa/lan9303-core.c: In function 'lan9303_port_disable':
>> drivers/net/dsa/lan9303-core.c:1111:9: error: implicit declaration of function 'vlan_vid_del' [-Werror=implicit-function-declaration]
1111 | vlan_vid_del(cpu_dp->master, htons(ETH_P_8021Q), port);
| ^~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/vlan_vid_add +1095 drivers/net/dsa/lan9303-core.c
1082
1083 static int lan9303_port_enable(struct dsa_switch *ds, int port,
1084 struct phy_device *phy)
1085 {
1086 struct lan9303 *chip = ds->priv;
1087 struct dsa_port *cpu_dp;
1088
1089 if (!dsa_is_user_port(ds, port))
1090 return 0;
1091
1092 dsa_switch_for_each_cpu_port(cpu_dp, ds)
1093 break;
1094
> 1095 vlan_vid_add(cpu_dp->master, htons(ETH_P_8021Q), port);
1096
1097 return lan9303_enable_processing_port(chip, port);
1098 }
1099
1100 static void lan9303_port_disable(struct dsa_switch *ds, int port)
1101 {
1102 struct lan9303 *chip = ds->priv;
1103 struct dsa_port *cpu_dp;
1104
1105 if (!dsa_is_user_port(ds, port))
1106 return;
1107
1108 dsa_switch_for_each_cpu_port(cpu_dp, ds)
1109 break;
1110
> 1111 vlan_vid_del(cpu_dp->master, htons(ETH_P_8021Q), port);
1112
1113 lan9303_disable_processing_port(chip, port);
1114 lan9303_phy_write(ds, chip->phy_addr_base + port, MII_BMCR, BMCR_PDOWN);
1115 }
1116
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
7 months
[jpirko-mlxsw:jiri_devel_linecards 27/43] drivers/net/ethernet/mellanox/mlxsw/core_env.c:1249:16: error: incompatible function pointer types initializing 'void (*)(struct mlxsw_core *, u8, void *, void *)' (aka 'void (*)(struct mlxsw_core *, unsigned char, void *, void *)') with an expression of ...
by kernel test robot
tree: https://github.com/jpirko/linux_mlxsw jiri_devel_linecards
head: 5cb021512c3be7e03591497caeab474ecccfcd21
commit: 08ac493598146680137ed7a81dc108b837018125 [27/43] mlxsw: core: Add interfaces for line card initialization and de-initialization
config: i386-randconfig-a015 (https://download.01.org/0day-ci/archive/20220217/202202170101.p6TIUxNw-lk...)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 0e628a783b935c70c80815db6c061ec84f884af5)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/jpirko/linux_mlxsw/commit/08ac493598146680137ed7a81dc1...
git remote add jpirko-mlxsw https://github.com/jpirko/linux_mlxsw
git fetch --no-tags jpirko-mlxsw jiri_devel_linecards
git checkout 08ac493598146680137ed7a81dc108b837018125
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/net/ethernet/mellanox/mlxsw/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> drivers/net/ethernet/mellanox/mlxsw/core_env.c:1249:16: error: incompatible function pointer types initializing 'void (*)(struct mlxsw_core *, u8, void *, void *)' (aka 'void (*)(struct mlxsw_core *, unsigned char, void *, void *)') with an expression of type 'void (struct mlxsw_core *, u8, const struct mlxsw_linecard *, void *)' (aka 'void (struct mlxsw_core *, unsigned char, const struct mlxsw_linecard *, void *)') [-Werror,-Wincompatible-function-pointer-types]
.got_active = mlxsw_env_got_active,
^~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/mellanox/mlxsw/core_env.c:1250:18: error: incompatible function pointer types initializing 'void (*)(struct mlxsw_core *, u8, void *, void *)' (aka 'void (*)(struct mlxsw_core *, unsigned char, void *, void *)') with an expression of type 'void (struct mlxsw_core *, u8, const struct mlxsw_linecard *, void *)' (aka 'void (struct mlxsw_core *, unsigned char, const struct mlxsw_linecard *, void *)') [-Werror,-Wincompatible-function-pointer-types]
.got_inactive = mlxsw_env_got_inactive,
^~~~~~~~~~~~~~~~~~~~~~
2 errors generated.
vim +1249 drivers/net/ethernet/mellanox/mlxsw/core_env.c
1247
1248 static struct mlxsw_linecards_event_ops mlxsw_env_event_ops = {
> 1249 .got_active = mlxsw_env_got_active,
1250 .got_inactive = mlxsw_env_got_inactive,
1251 };
1252
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
7 months
Re: [PATCH 1/2] block: fix surprise removal for drivers calling blk_set_queue_dying
by kernel test robot
Hi Christoph,
I love your patch! Perhaps something to improve:
[auto build test WARNING on axboe-block/for-next]
[also build test WARNING on ceph-client/for-linus xen-tip/linux-next device-mapper-dm/for-next linus/master v5.17-rc4 next-20220216]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Christoph-Hellwig/block-fix-surp...
base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
config: nds32-allnoconfig (https://download.01.org/0day-ci/archive/20220217/202202170106.0gjJs3bN-lk...)
compiler: nds32le-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/97d6b5e4c96fcbf1dc26120c918dd1bac...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Christoph-Hellwig/block-fix-surprise-removal-for-drivers-calling-blk_set_queue_dying/20220216-231057
git checkout 97d6b5e4c96fcbf1dc26120c918dd1baca987188
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=nds32 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> block/blk-core.c:296: warning: expecting prototype for blk_set_disk_dead(). Prototype was for blk_mark_disk_dead() instead
vim +296 block/blk-core.c
8e141f9eb803e20 Christoph Hellwig 2021-09-29 287
97d6b5e4c96fcbf Christoph Hellwig 2022-02-16 288 /**
97d6b5e4c96fcbf Christoph Hellwig 2022-02-16 289 * blk_set_disk_dead - mark a disk as dead
97d6b5e4c96fcbf Christoph Hellwig 2022-02-16 290 * @disk: disk to mark as dead
97d6b5e4c96fcbf Christoph Hellwig 2022-02-16 291 *
97d6b5e4c96fcbf Christoph Hellwig 2022-02-16 292 * Mark as disk as dead (e.g. surprise removed) and don't accept any new I/O
97d6b5e4c96fcbf Christoph Hellwig 2022-02-16 293 * to this disk.
97d6b5e4c96fcbf Christoph Hellwig 2022-02-16 294 */
97d6b5e4c96fcbf Christoph Hellwig 2022-02-16 295 void blk_mark_disk_dead(struct gendisk *disk)
8e141f9eb803e20 Christoph Hellwig 2021-09-29 @296 {
97d6b5e4c96fcbf Christoph Hellwig 2022-02-16 297 set_bit(GD_DEAD, &disk->state);
97d6b5e4c96fcbf Christoph Hellwig 2022-02-16 298 blk_queue_start_drain(disk->queue);
8e141f9eb803e20 Christoph Hellwig 2021-09-29 299 }
97d6b5e4c96fcbf Christoph Hellwig 2022-02-16 300 EXPORT_SYMBOL_GPL(blk_mark_disk_dead);
aed3ea94bdd2ac0 Jens Axboe 2014-12-22 301
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
7 months
Verified Contacts from Optical Fiber Communication - OFC
by maria＠eventsinamerica.tech
Hi,
Hope all is well.
Would you be interested in acquiring Attendees List of " Optical Fiber
Communication - OFC " - 2022?
Data fields Included: Company Name, Job Title, Contact Name, fax number,
physical address, Industry, Company size, Email, Tel Number, Website/URL
etc.
We have discounted pricing this month.
Please let me know your thoughts and I shall get back to you with the
pricing.
Best Regards,
Maria | Event Co-ordinator
If you do not wish to receive future emails from us, please reply as ' No
Requirements '
7 months
[jpirko-mlxsw:jiri_devel_linecards 29/43] drivers/net/ethernet/mellanox/mlxsw/core_hwmon.c:898:23: error: initialization of 'void (*)(struct mlxsw_core *, u8, void *, void *)' {aka 'void (*)(struct mlxsw_core *, unsigned char, void *, void *)'} from incompatible pointer type 'void (*)(struct ml...
by kernel test robot
tree: https://github.com/jpirko/linux_mlxsw jiri_devel_linecards
head: 5cb021512c3be7e03591497caeab474ecccfcd21
commit: 0733fff985b276239955edfc5a42e929eced7437 [29/43] mlxsw: core_hwmon: Add interfaces for line card initialization and de-initialization
config: powerpc-allmodconfig (https://download.01.org/0day-ci/archive/20220217/202202170026.mb9LyVVk-lk...)
compiler: powerpc-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/jpirko/linux_mlxsw/commit/0733fff985b276239955edfc5a42...
git remote add jpirko-mlxsw https://github.com/jpirko/linux_mlxsw
git fetch --no-tags jpirko-mlxsw jiri_devel_linecards
git checkout 0733fff985b276239955edfc5a42e929eced7437
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=powerpc SHELL=/bin/bash drivers/net/ethernet/mellanox/mlxsw/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> drivers/net/ethernet/mellanox/mlxsw/core_hwmon.c:898:23: error: initialization of 'void (*)(struct mlxsw_core *, u8, void *, void *)' {aka 'void (*)(struct mlxsw_core *, unsigned char, void *, void *)'} from incompatible pointer type 'void (*)(struct mlxsw_core *, u8, const struct mlxsw_linecard *, void *)' {aka 'void (*)(struct mlxsw_core *, unsigned char, const struct mlxsw_linecard *, void *)'} [-Werror=incompatible-pointer-types]
898 | .got_active = mlxsw_hwmon_got_active,
| ^~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/mellanox/mlxsw/core_hwmon.c:898:23: note: (near initialization for 'mlxsw_hwmon_event_ops.got_active')
drivers/net/ethernet/mellanox/mlxsw/core_hwmon.c:899:25: error: initialization of 'void (*)(struct mlxsw_core *, u8, void *, void *)' {aka 'void (*)(struct mlxsw_core *, unsigned char, void *, void *)'} from incompatible pointer type 'void (*)(struct mlxsw_core *, u8, const struct mlxsw_linecard *, void *)' {aka 'void (*)(struct mlxsw_core *, unsigned char, const struct mlxsw_linecard *, void *)'} [-Werror=incompatible-pointer-types]
899 | .got_inactive = mlxsw_hwmon_got_inactive,
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/mellanox/mlxsw/core_hwmon.c:899:25: note: (near initialization for 'mlxsw_hwmon_event_ops.got_inactive')
cc1: some warnings being treated as errors
vim +898 drivers/net/ethernet/mellanox/mlxsw/core_hwmon.c
896
897 static struct mlxsw_linecards_event_ops mlxsw_hwmon_event_ops = {
> 898 .got_active = mlxsw_hwmon_got_active,
899 .got_inactive = mlxsw_hwmon_got_inactive,
900 };
901
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
7 months
Re: [RFC V3 4/6] blk-iocost: make iocost pluggable
by kernel test robot
Hi "Wang,
[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on v5.17-rc4]
[cannot apply to axboe-block/for-next next-20220216]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Wang-Jianchao-Kuaishou/blk-make-...
base: 754e0b0e35608ed5206d6a67a791563c631cec07
config: riscv-buildonly-randconfig-r004-20220216 (https://download.01.org/0day-ci/archive/20220216/202202162343.zPf2UuRg-lk...)
compiler: riscv32-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/28800cf3765b9c31df59c666540b777f2...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Wang-Jianchao-Kuaishou/blk-make-blk-rq-qos-policies-pluggable-and-modular/20220216-195026
git checkout 28800cf3765b9c31df59c666540b777f278f03e5
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=riscv SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
block/blk-iocost.c: In function 'iocg_activate':
block/blk-iocost.c:1245:13: warning: variable 'last_period' set but not used [-Wunused-but-set-variable]
1245 | u64 last_period, cur_period;
| ^~~~~~~~~~~
block/blk-iocost.c: In function 'ioc_cost_model_write':
>> block/blk-iocost.c:3333:24: warning: variable 'rqos' set but not used [-Wunused-but-set-variable]
3333 | struct rq_qos *rqos;
| ^~~~
vim +/rqos +3333 block/blk-iocost.c
3328
3329 static ssize_t ioc_cost_model_write(struct kernfs_open_file *of, char *input,
3330 size_t nbytes, loff_t off)
3331 {
3332 struct block_device *bdev;
> 3333 struct rq_qos *rqos;
3334 struct ioc *ioc;
3335 u64 u[NR_I_LCOEFS];
3336 bool user;
3337 char *p;
3338 int ret;
3339
3340 bdev = blkcg_conf_open_bdev(&input);
3341 if (IS_ERR(bdev))
3342 return PTR_ERR(bdev);
3343
3344 rqos = rq_qos_get(bdev_get_queue(bdev), ioc_rqos_ops.id);
3345 if (!ioc) {
3346 ret = -EOPNOTSUPP;
3347 goto err;
3348 }
3349
3350 spin_lock_irq(&ioc->lock);
3351 memcpy(u, ioc->params.i_lcoefs, sizeof(u));
3352 user = ioc->user_cost_model;
3353 spin_unlock_irq(&ioc->lock);
3354
3355 while ((p = strsep(&input, " \t\n"))) {
3356 substring_t args[MAX_OPT_ARGS];
3357 char buf[32];
3358 int tok;
3359 u64 v;
3360
3361 if (!*p)
3362 continue;
3363
3364 switch (match_token(p, cost_ctrl_tokens, args)) {
3365 case COST_CTRL:
3366 match_strlcpy(buf, &args[0], sizeof(buf));
3367 if (!strcmp(buf, "auto"))
3368 user = false;
3369 else if (!strcmp(buf, "user"))
3370 user = true;
3371 else
3372 goto einval;
3373 continue;
3374 case COST_MODEL:
3375 match_strlcpy(buf, &args[0], sizeof(buf));
3376 if (strcmp(buf, "linear"))
3377 goto einval;
3378 continue;
3379 }
3380
3381 tok = match_token(p, i_lcoef_tokens, args);
3382 if (tok == NR_I_LCOEFS)
3383 goto einval;
3384 if (match_u64(&args[0], &v))
3385 goto einval;
3386 u[tok] = v;
3387 user = true;
3388 }
3389
3390 spin_lock_irq(&ioc->lock);
3391 if (user) {
3392 memcpy(ioc->params.i_lcoefs, u, sizeof(u));
3393 ioc->user_cost_model = true;
3394 } else {
3395 ioc->user_cost_model = false;
3396 }
3397 ioc_refresh_params(ioc, true);
3398 spin_unlock_irq(&ioc->lock);
3399
3400 blkdev_put_no_open(bdev);
3401 return nbytes;
3402
3403 einval:
3404 ret = -EINVAL;
3405 err:
3406 blkdev_put_no_open(bdev);
3407 return ret;
3408 }
3409
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
7 months
