Re: [PATCH] crypto: crypto_xor - use helpers for unaligned accesses
by kernel test robot
Hi Ard,
I love your patch! Perhaps something to improve:
[auto build test WARNING on herbert-cryptodev-2.6/master]
[also build test WARNING on herbert-crypto-2.6/master v5.17-rc4 next-20220215]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Ard-Biesheuvel/crypto-crypto_xor...
base: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
config: i386-randconfig-a003 (https://download.01.org/0day-ci/archive/20220216/202202160048.w2jucJCP-lk...)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/6ca2d09816a67230ab30f3c7e7d87815e...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Ard-Biesheuvel/crypto-crypto_xor-use-helpers-for-unaligned-accesses/20220215-185741
git checkout 6ca2d09816a67230ab30f3c7e7d87815e833d0af
# save the config file to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash arch/x86/kernel/ drivers/md/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
In file included from ./arch/x86/include/generated/asm/unaligned.h:1,
from drivers/md/dm-crypt.c:30:
drivers/md/dm-crypt.c: In function 'crypt_iv_tcw_whitening':
>> include/asm-generic/unaligned.h:14:8: warning: 'buf.x' is used uninitialized in this function [-Wuninitialized]
14 | __pptr->x; \
| ^~
>> include/asm-generic/unaligned.h:14:8: warning: '*((void *)&buf+4).x' is used uninitialized in this function [-Wuninitialized]
include/asm-generic/unaligned.h:14:8: warning: '*((void *)&buf+8).x' is used uninitialized in this function [-Wuninitialized]
include/asm-generic/unaligned.h:14:8: warning: '*((void *)&buf+12).x' is used uninitialized in this function [-Wuninitialized]
vim +14 include/asm-generic/unaligned.h
aafe4dbed0bf6c Arnd Bergmann 2009-05-13 11
803f4e1eab7a89 Arnd Bergmann 2021-05-08 12 #define __get_unaligned_t(type, ptr) ({ \
803f4e1eab7a89 Arnd Bergmann 2021-05-08 13 const struct { type x; } __packed *__pptr = (typeof(__pptr))(ptr); \
803f4e1eab7a89 Arnd Bergmann 2021-05-08 @14 __pptr->x; \
803f4e1eab7a89 Arnd Bergmann 2021-05-08 15 })
803f4e1eab7a89 Arnd Bergmann 2021-05-08 16
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
7 months, 1 week
[thesofproject:pr/3431 51/69] sound/soc/sof/ipc4-topology.c:114:6: warning: no previous prototype for 'sof_ipc4_dbg_audio_format'
by kernel test robot
tree: https://github.com/thesofproject/linux pr/3431
head: 8bede155af2999e234bccdd68821b5025e54d0b3
commit: cac35cbf20c6d9773f7b700bd38b33efeacd343d [51/69] ASoC: SOF: IPC4-topology: Add support for parsing AIF_IN/AIF_OUT widgets
config: x86_64-sof-customedconfig-sof-defconfig (https://download.01.org/0day-ci/archive/20220216/202202160047.TQrND8Bz-lk...)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/thesofproject/linux/commit/cac35cbf20c6d9773f7b700bd38...
git remote add thesofproject https://github.com/thesofproject/linux
git fetch --no-tags thesofproject pr/3431
git checkout cac35cbf20c6d9773f7b700bd38b33efeacd343d
# save the config file to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash sound/soc/sof/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> sound/soc/sof/ipc4-topology.c:114:6: warning: no previous prototype for 'sof_ipc4_dbg_audio_format' [-Wmissing-prototypes]
114 | void sof_ipc4_dbg_audio_format(struct device *dev, struct sof_ipc4_audio_format *format,
| ^~~~~~~~~~~~~~~~~~~~~~~~~
vim +/sof_ipc4_dbg_audio_format +114 sound/soc/sof/ipc4-topology.c
113
> 114 void sof_ipc4_dbg_audio_format(struct device *dev, struct sof_ipc4_audio_format *format,
115 size_t object_size, int num_format, const char *widget_name,
116 const char *function_name)
117 {
118 struct sof_ipc4_audio_format *fmt;
119 void *ptr = format;
120 int i;
121
122 for (i = 0; i < num_format; i++, ptr = (u8 *)ptr + object_size) {
123 fmt = ptr;
124 dev_dbg(dev, "%s i %d %s rate %u, bit_depth %u ch_map %u ch_cfg %u interleaving_style %u fmt_cfg %u\n",
125 function_name, i, widget_name,
126 fmt->sampling_frequency,
127 fmt->bit_depth,
128 fmt->ch_map,
129 fmt->ch_cfg,
130 fmt->interleaving_style,
131 fmt->fmt_cfg);
132 }
133 }
134
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
7 months, 1 week
[crng-random:master 17/42] include/trace/events/random.h:55:1: error: incompatible function pointer types passing 'void (void *, size_t, unsigned long)' (aka 'void (void *, unsigned int, unsigned long)') to parameter of type 'void (*)(void *, int, unsigned long)'
by kernel test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/crng/random.git master
head: e09db9454de88dca579c13562129bef2b0c7dd36
commit: 60681e3678705f119c0d32b5e0d56a21f90bb720 [17/42] random: make more consistent use of integer types
config: i386-randconfig-a001-20220214 (https://download.01.org/0day-ci/archive/20220216/202202160014.qVgMDFfX-lk...)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 37f422f4ac31c8b8041c6b62065263314282dab6)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/crng/random.git/commit/?i...
git remote add crng-random git://git.kernel.org/pub/scm/linux/kernel/git/crng/random.git
git fetch --no-tags crng-random master
git checkout 60681e3678705f119c0d32b5e0d56a21f90bb720
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Note: the crng-random/master HEAD e09db9454de88dca579c13562129bef2b0c7dd36 builds fine.
It only hurts bisectability.
All errors (new ones prefixed by >>):
In file included from drivers/char/random.c:241:
In file included from include/trace/events/random.h:212:
In file included from include/trace/define_trace.h:102:
In file included from include/trace/trace_events.h:873:
>> include/trace/events/random.h:55:1: error: incompatible function pointer types passing 'void (void *, size_t, unsigned long)' (aka 'void (void *, unsigned int, unsigned long)') to parameter of type 'void (*)(void *, int, unsigned long)' [-Werror,-Wincompatible-function-pointer-types]
DEFINE_EVENT(random__mix_pool_bytes, mix_pool_bytes_nolock,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/trace/trace_events.h:870:35: note: expanded from macro 'DEFINE_EVENT'
check_trace_callback_type_##call(trace_event_raw_event_##template); \
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
<scratch space>:39:1: note: expanded from here
trace_event_raw_event_random__mix_pool_bytes
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/trace/events/random.h:55:1: note: passing argument to parameter 'cb' here
DEFINE_EVENT(random__mix_pool_bytes, mix_pool_bytes_nolock,
^
include/linux/tracepoint.h:542:2: note: expanded from macro 'DEFINE_EVENT'
DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
^
include/linux/tracepoint.h:419:2: note: expanded from macro 'DECLARE_TRACE'
__DECLARE_TRACE(name, PARAMS(proto), PARAMS(args), \
^
include/linux/tracepoint.h:279:42: note: expanded from macro '__DECLARE_TRACE'
check_trace_callback_type_##name(void (*cb)(data_proto)) \
^
In file included from drivers/char/random.c:241:
In file included from include/trace/events/random.h:212:
In file included from include/trace/define_trace.h:103:
In file included from include/trace/perf.h:107:
>> include/trace/events/random.h:55:1: error: incompatible function pointer types passing 'void (void *, size_t, unsigned long)' (aka 'void (void *, unsigned int, unsigned long)') to parameter of type 'void (*)(void *, int, unsigned long)' [-Werror,-Wincompatible-function-pointer-types]
DEFINE_EVENT(random__mix_pool_bytes, mix_pool_bytes_nolock,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/trace/perf.h:99:35: note: expanded from macro 'DEFINE_EVENT'
check_trace_callback_type_##call(perf_trace_##template); \
^~~~~~~~~~~~~~~~~~~~~
<scratch space>:62:1: note: expanded from here
perf_trace_random__mix_pool_bytes
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/trace/events/random.h:55:1: note: passing argument to parameter 'cb' here
DEFINE_EVENT(random__mix_pool_bytes, mix_pool_bytes_nolock,
^
include/linux/tracepoint.h:542:2: note: expanded from macro 'DEFINE_EVENT'
DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
^
include/linux/tracepoint.h:419:2: note: expanded from macro 'DECLARE_TRACE'
__DECLARE_TRACE(name, PARAMS(proto), PARAMS(args), \
^
include/linux/tracepoint.h:279:42: note: expanded from macro '__DECLARE_TRACE'
check_trace_callback_type_##name(void (*cb)(data_proto)) \
^
drivers/char/random.c:1734:6: warning: no previous prototype for function 'add_hwgenerator_randomness' [-Wmissing-prototypes]
void add_hwgenerator_randomness(const void *buffer, size_t count,
^
drivers/char/random.c:1734:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void add_hwgenerator_randomness(const void *buffer, size_t count,
^
static
1 warning and 2 errors generated.
vim +55 include/trace/events/random.h
00ce1db1a634746 Theodore Ts'o 2012-07-04 54
00ce1db1a634746 Theodore Ts'o 2012-07-04 @55 DEFINE_EVENT(random__mix_pool_bytes, mix_pool_bytes_nolock,
90ed1e67e896cc8 Jason A. Donenfeld 2022-01-12 56 TP_PROTO(int bytes, unsigned long IP),
00ce1db1a634746 Theodore Ts'o 2012-07-04 57
90ed1e67e896cc8 Jason A. Donenfeld 2022-01-12 58 TP_ARGS(bytes, IP)
00ce1db1a634746 Theodore Ts'o 2012-07-04 59 );
00ce1db1a634746 Theodore Ts'o 2012-07-04 60
:::::: The code at line 55 was first introduced by commit
:::::: 00ce1db1a634746040ace24c09a4e3a7949a3145 random: add tracepoints for easier debugging and verification
:::::: TO: Theodore Ts'o <tytso(a)mit.edu>
:::::: CC: Theodore Ts'o <tytso(a)mit.edu>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
7 months, 1 week
