Re: [PATCH net-next 06/19] net: tcp: use kfree_skb_reason() for tcp_v{4,6}_do_rcv()
by kernel test robot
Hi,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on next-20220214]
[cannot apply to net-next/master rostedt-trace/for-next net/master linus/master v5.17-rc4 v5.17-rc3 v5.17-rc2 v5.17-rc4]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/menglong8-dong-gmail-com/net-add...
base: 259cbfc98c55ba3b6ef6e61fb7cfc3751dfded1e
config: i386-randconfig-a004-20220214 (https://download.01.org/0day-ci/archive/20220215/202202152352.9jAkQxUc-lk...)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 37f422f4ac31c8b8041c6b62065263314282dab6)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/8619663f7f150a5f5d782d8f6083988f5...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review menglong8-dong-gmail-com/net-add-skb-drop-reasons-for-TCP-IP-dev-and-neigh/20220215-193437
git checkout 8619663f7f150a5f5d782d8f6083988f56505777
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash net/ipv6/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> net/ipv6/tcp_ipv6.c:1556:6: warning: variable 'reason' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
if (tcp_rcv_state_process(sk, skb))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
net/ipv6/tcp_ipv6.c:1567:24: note: uninitialized use occurs here
kfree_skb_reason(skb, reason);
^~~~~~
net/ipv6/tcp_ipv6.c:1556:2: note: remove the 'if' if its condition is always false
if (tcp_rcv_state_process(sk, skb))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
net/ipv6/tcp_ipv6.c:1547:8: warning: variable 'reason' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
if (tcp_child_process(sk, nsk, skb))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
net/ipv6/tcp_ipv6.c:1567:24: note: uninitialized use occurs here
kfree_skb_reason(skb, reason);
^~~~~~
net/ipv6/tcp_ipv6.c:1547:4: note: remove the 'if' if its condition is always false
if (tcp_child_process(sk, nsk, skb))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
net/ipv6/tcp_ipv6.c:1543:7: warning: variable 'reason' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
if (!nsk)
^~~~
net/ipv6/tcp_ipv6.c:1567:24: note: uninitialized use occurs here
kfree_skb_reason(skb, reason);
^~~~~~
net/ipv6/tcp_ipv6.c:1543:3: note: remove the 'if' if its condition is always false
if (!nsk)
^~~~~~~~~
net/ipv6/tcp_ipv6.c:1479:2: note: variable 'reason' is declared here
enum skb_drop_reason reason;
^
3 warnings generated.
vim +1556 net/ipv6/tcp_ipv6.c
^1da177e4c3f41 Linus Torvalds 2005-04-16 1463
bbd807dfbf2050 Brian Vazquez 2021-02-01 1464 INDIRECT_CALLABLE_DECLARE(struct dst_entry *ipv4_dst_check(struct dst_entry *,
bbd807dfbf2050 Brian Vazquez 2021-02-01 1465 u32));
^1da177e4c3f41 Linus Torvalds 2005-04-16 1466 /* The socket must have it's spinlock held when we get
e994b2f0fb9229 Eric Dumazet 2015-10-02 1467 * here, unless it is a TCP_LISTEN socket.
^1da177e4c3f41 Linus Torvalds 2005-04-16 1468 *
^1da177e4c3f41 Linus Torvalds 2005-04-16 1469 * We have a potential double-lock case here, so even when
^1da177e4c3f41 Linus Torvalds 2005-04-16 1470 * doing backlog processing we use the BH locking scheme.
^1da177e4c3f41 Linus Torvalds 2005-04-16 1471 * This is because we cannot sleep with the original spinlock
^1da177e4c3f41 Linus Torvalds 2005-04-16 1472 * held.
^1da177e4c3f41 Linus Torvalds 2005-04-16 1473 */
d2489c7b6d7d5e Eric Dumazet 2021-11-15 1474 INDIRECT_CALLABLE_SCOPE
d2489c7b6d7d5e Eric Dumazet 2021-11-15 1475 int tcp_v6_do_rcv(struct sock *sk, struct sk_buff *skb)
^1da177e4c3f41 Linus Torvalds 2005-04-16 1476 {
93a77c11ae79e8 Eric Dumazet 2019-03-19 1477 struct ipv6_pinfo *np = tcp_inet6_sk(sk);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1478 struct sk_buff *opt_skb = NULL;
8619663f7f150a Menglong Dong 2022-02-15 1479 enum skb_drop_reason reason;
93a77c11ae79e8 Eric Dumazet 2019-03-19 1480 struct tcp_sock *tp;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1481
^1da177e4c3f41 Linus Torvalds 2005-04-16 1482 /* Imagine: socket is IPv6. IPv4 packet arrives,
^1da177e4c3f41 Linus Torvalds 2005-04-16 1483 goes to IPv4 receive handler and backlogged.
^1da177e4c3f41 Linus Torvalds 2005-04-16 1484 From backlog it always goes here. Kerboom...
^1da177e4c3f41 Linus Torvalds 2005-04-16 1485 Fortunately, tcp_rcv_established and rcv_established
^1da177e4c3f41 Linus Torvalds 2005-04-16 1486 handle them correctly, but it is not case with
^1da177e4c3f41 Linus Torvalds 2005-04-16 1487 tcp_v6_hnd_req and tcp_v6_send_reset(). --ANK
^1da177e4c3f41 Linus Torvalds 2005-04-16 1488 */
^1da177e4c3f41 Linus Torvalds 2005-04-16 1489
^1da177e4c3f41 Linus Torvalds 2005-04-16 1490 if (skb->protocol == htons(ETH_P_IP))
^1da177e4c3f41 Linus Torvalds 2005-04-16 1491 return tcp_v4_do_rcv(sk, skb);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1492
^1da177e4c3f41 Linus Torvalds 2005-04-16 1493 /*
^1da177e4c3f41 Linus Torvalds 2005-04-16 1494 * socket locking is here for SMP purposes as backlog rcv
^1da177e4c3f41 Linus Torvalds 2005-04-16 1495 * is currently called with bh processing disabled.
^1da177e4c3f41 Linus Torvalds 2005-04-16 1496 */
^1da177e4c3f41 Linus Torvalds 2005-04-16 1497
^1da177e4c3f41 Linus Torvalds 2005-04-16 1498 /* Do Stevens' IPV6_PKTOPTIONS.
^1da177e4c3f41 Linus Torvalds 2005-04-16 1499
^1da177e4c3f41 Linus Torvalds 2005-04-16 1500 Yes, guys, it is the only place in our code, where we
^1da177e4c3f41 Linus Torvalds 2005-04-16 1501 may make it not affecting IPv4.
^1da177e4c3f41 Linus Torvalds 2005-04-16 1502 The rest of code is protocol independent,
^1da177e4c3f41 Linus Torvalds 2005-04-16 1503 and I do not like idea to uglify IPv4.
^1da177e4c3f41 Linus Torvalds 2005-04-16 1504
^1da177e4c3f41 Linus Torvalds 2005-04-16 1505 Actually, all the idea behind IPV6_PKTOPTIONS
^1da177e4c3f41 Linus Torvalds 2005-04-16 1506 looks not very well thought. For now we latch
^1da177e4c3f41 Linus Torvalds 2005-04-16 1507 options, received in the last packet, enqueued
^1da177e4c3f41 Linus Torvalds 2005-04-16 1508 by tcp. Feel free to propose better solution.
^1da177e4c3f41 Linus Torvalds 2005-04-16 1509 --ANK (980728)
^1da177e4c3f41 Linus Torvalds 2005-04-16 1510 */
^1da177e4c3f41 Linus Torvalds 2005-04-16 1511 if (np->rxopt.all)
7450aaf61f0ae2 Eric Dumazet 2015-11-30 1512 opt_skb = skb_clone(skb, sk_gfp_mask(sk, GFP_ATOMIC));
^1da177e4c3f41 Linus Torvalds 2005-04-16 1513
^1da177e4c3f41 Linus Torvalds 2005-04-16 1514 if (sk->sk_state == TCP_ESTABLISHED) { /* Fast path */
8f905c0e7354ef Eric Dumazet 2021-12-20 1515 struct dst_entry *dst;
8f905c0e7354ef Eric Dumazet 2021-12-20 1516
8f905c0e7354ef Eric Dumazet 2021-12-20 1517 dst = rcu_dereference_protected(sk->sk_rx_dst,
8f905c0e7354ef Eric Dumazet 2021-12-20 1518 lockdep_sock_is_held(sk));
5d299f3d3c8a2f Eric Dumazet 2012-08-06 1519
bdeab991918663 Tom Herbert 2011-08-14 1520 sock_rps_save_rxhash(sk, skb);
3d97379a67486b Eric Dumazet 2014-11-11 1521 sk_mark_napi_id(sk, skb);
5d299f3d3c8a2f Eric Dumazet 2012-08-06 1522 if (dst) {
0c0a5ef809f915 Eric Dumazet 2021-10-25 1523 if (sk->sk_rx_dst_ifindex != skb->skb_iif ||
bbd807dfbf2050 Brian Vazquez 2021-02-01 1524 INDIRECT_CALL_1(dst->ops->check, ip6_dst_check,
ef57c1610dd8fb Eric Dumazet 2021-10-25 1525 dst, sk->sk_rx_dst_cookie) == NULL) {
8f905c0e7354ef Eric Dumazet 2021-12-20 1526 RCU_INIT_POINTER(sk->sk_rx_dst, NULL);
5d299f3d3c8a2f Eric Dumazet 2012-08-06 1527 dst_release(dst);
5d299f3d3c8a2f Eric Dumazet 2012-08-06 1528 }
5d299f3d3c8a2f Eric Dumazet 2012-08-06 1529 }
5d299f3d3c8a2f Eric Dumazet 2012-08-06 1530
3d97d88e8091f3 Yafang Shao 2018-05-29 1531 tcp_rcv_established(sk, skb);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1532 if (opt_skb)
^1da177e4c3f41 Linus Torvalds 2005-04-16 1533 goto ipv6_pktoptions;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1534 return 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1535 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 1536
12e25e1041d044 Eric Dumazet 2015-06-03 1537 if (tcp_checksum_complete(skb))
^1da177e4c3f41 Linus Torvalds 2005-04-16 1538 goto csum_err;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1539
^1da177e4c3f41 Linus Torvalds 2005-04-16 1540 if (sk->sk_state == TCP_LISTEN) {
079096f103faca Eric Dumazet 2015-10-02 1541 struct sock *nsk = tcp_v6_cookie_check(sk, skb);
079096f103faca Eric Dumazet 2015-10-02 1542
^1da177e4c3f41 Linus Torvalds 2005-04-16 1543 if (!nsk)
^1da177e4c3f41 Linus Torvalds 2005-04-16 1544 goto discard;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1545
^1da177e4c3f41 Linus Torvalds 2005-04-16 1546 if (nsk != sk) {
^1da177e4c3f41 Linus Torvalds 2005-04-16 1547 if (tcp_child_process(sk, nsk, skb))
^1da177e4c3f41 Linus Torvalds 2005-04-16 1548 goto reset;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1549 if (opt_skb)
^1da177e4c3f41 Linus Torvalds 2005-04-16 1550 __kfree_skb(opt_skb);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1551 return 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1552 }
47482f132a689a Neil Horman 2011-04-06 1553 } else
bdeab991918663 Tom Herbert 2011-08-14 1554 sock_rps_save_rxhash(sk, skb);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1555
72ab4a86f7a260 Eric Dumazet 2015-09-29 @1556 if (tcp_rcv_state_process(sk, skb))
^1da177e4c3f41 Linus Torvalds 2005-04-16 1557 goto reset;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1558 if (opt_skb)
^1da177e4c3f41 Linus Torvalds 2005-04-16 1559 goto ipv6_pktoptions;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1560 return 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1561
^1da177e4c3f41 Linus Torvalds 2005-04-16 1562 reset:
cfb6eeb4c86059 YOSHIFUJI Hideaki 2006-11-14 1563 tcp_v6_send_reset(sk, skb);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1564 discard:
^1da177e4c3f41 Linus Torvalds 2005-04-16 1565 if (opt_skb)
^1da177e4c3f41 Linus Torvalds 2005-04-16 1566 __kfree_skb(opt_skb);
8619663f7f150a Menglong Dong 2022-02-15 1567 kfree_skb_reason(skb, reason);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1568 return 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1569 csum_err:
8619663f7f150a Menglong Dong 2022-02-15 1570 reason = SKB_DROP_REASON_TCP_CSUM;
709c0314239992 Jakub Kicinski 2021-05-14 1571 trace_tcp_bad_csum(skb);
c10d9310edf5aa Eric Dumazet 2016-04-29 1572 TCP_INC_STATS(sock_net(sk), TCP_MIB_CSUMERRORS);
c10d9310edf5aa Eric Dumazet 2016-04-29 1573 TCP_INC_STATS(sock_net(sk), TCP_MIB_INERRS);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1574 goto discard;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1575
^1da177e4c3f41 Linus Torvalds 2005-04-16 1576
^1da177e4c3f41 Linus Torvalds 2005-04-16 1577 ipv6_pktoptions:
^1da177e4c3f41 Linus Torvalds 2005-04-16 1578 /* Do you ask, what is it?
^1da177e4c3f41 Linus Torvalds 2005-04-16 1579
^1da177e4c3f41 Linus Torvalds 2005-04-16 1580 1. skb was enqueued by tcp.
^1da177e4c3f41 Linus Torvalds 2005-04-16 1581 2. skb is added to tail of read queue, rather than out of order.
^1da177e4c3f41 Linus Torvalds 2005-04-16 1582 3. socket is not in passive state.
^1da177e4c3f41 Linus Torvalds 2005-04-16 1583 4. Finally, it really contains options, which user wants to receive.
^1da177e4c3f41 Linus Torvalds 2005-04-16 1584 */
^1da177e4c3f41 Linus Torvalds 2005-04-16 1585 tp = tcp_sk(sk);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1586 if (TCP_SKB_CB(opt_skb)->end_seq == tp->rcv_nxt &&
^1da177e4c3f41 Linus Torvalds 2005-04-16 1587 !((1 << sk->sk_state) & (TCPF_CLOSE | TCPF_LISTEN))) {
333fad5364d6b4 YOSHIFUJI Hideaki 2005-09-08 1588 if (np->rxopt.bits.rxinfo || np->rxopt.bits.rxoinfo)
870c3151382c98 Eric Dumazet 2014-10-17 1589 np->mcast_oif = tcp_v6_iif(opt_skb);
333fad5364d6b4 YOSHIFUJI Hideaki 2005-09-08 1590 if (np->rxopt.bits.rxhlim || np->rxopt.bits.rxohlim)
0660e03f6b18f1 Arnaldo Carvalho de Melo 2007-04-25 1591 np->mcast_hops = ipv6_hdr(opt_skb)->hop_limit;
82e9f105a28006 Florent Fourcot 2013-12-08 1592 if (np->rxopt.bits.rxflow || np->rxopt.bits.rxtclass)
1397ed35f22d7c Florent Fourcot 2013-12-08 1593 np->rcv_flowinfo = ip6_flowinfo(ipv6_hdr(opt_skb));
df3687ffc6653e Florent Fourcot 2014-01-17 1594 if (np->repflow)
df3687ffc6653e Florent Fourcot 2014-01-17 1595 np->flow_label = ip6_flowlabel(ipv6_hdr(opt_skb));
a224772db8420e Eric Dumazet 2014-09-27 1596 if (ipv6_opt_accepted(sk, opt_skb, &TCP_SKB_CB(opt_skb)->header.h6)) {
^1da177e4c3f41 Linus Torvalds 2005-04-16 1597 skb_set_owner_r(opt_skb, sk);
8ce48623f0cf3d Eric Dumazet 2016-10-12 1598 tcp_v6_restore_cb(opt_skb);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1599 opt_skb = xchg(&np->pktoptions, opt_skb);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1600 } else {
^1da177e4c3f41 Linus Torvalds 2005-04-16 1601 __kfree_skb(opt_skb);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1602 opt_skb = xchg(&np->pktoptions, NULL);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1603 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 1604 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 1605
12c8691de30734 Eric Dumazet 2021-10-25 1606 consume_skb(opt_skb);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1607 return 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1608 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 1609
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
7 months, 1 week
arch/mips/sibyte/common/sb_tbprof.c:515:23: sparse: sparse: incorrect type in initializer (different address spaces)
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 83e396641110663d3c7bb25b9bc0c6a750359ecf
commit: ddb002d6d6af12c45dd9d565cadf0f40b36b7c25 MIPS: uaccess: Reduce number of nested macros
date: 10 months ago
config: mips-randconfig-s032-20220213 (https://download.01.org/0day-ci/archive/20220213/202202130432.4tPqXRgn-lk...)
compiler: mips64el-linux-gcc (GCC) 11.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.4-dirty
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit...
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout ddb002d6d6af12c45dd9d565cadf0f40b36b7c25
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=mips SHELL=/bin/bash arch/mips/sibyte/common/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
command-line: note: in included file:
builtin:1:9: sparse: sparse: preprocessor token __ATOMIC_ACQUIRE redefined
builtin:0:0: sparse: this was the original definition
builtin:1:9: sparse: sparse: preprocessor token __ATOMIC_SEQ_CST redefined
builtin:0:0: sparse: this was the original definition
builtin:1:9: sparse: sparse: preprocessor token __ATOMIC_ACQ_REL redefined
builtin:0:0: sparse: this was the original definition
builtin:1:9: sparse: sparse: preprocessor token __ATOMIC_RELEASE redefined
builtin:0:0: sparse: this was the original definition
arch/mips/sibyte/common/sb_tbprof.c:449:14: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const [noderef] __user *p @@ got char *buf @@
arch/mips/sibyte/common/sb_tbprof.c:449:14: sparse: expected void const [noderef] __user *p
arch/mips/sibyte/common/sb_tbprof.c:449:14: sparse: got char *buf
arch/mips/sibyte/common/sb_tbprof.c:464:38: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void [noderef] __user *to @@ got char *dest @@
arch/mips/sibyte/common/sb_tbprof.c:464:38: sparse: expected void [noderef] __user *to
arch/mips/sibyte/common/sb_tbprof.c:464:38: sparse: got char *dest
>> arch/mips/sibyte/common/sb_tbprof.c:515:23: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected int [noderef] __user *__p @@ got int * @@
arch/mips/sibyte/common/sb_tbprof.c:515:23: sparse: expected int [noderef] __user *__p
arch/mips/sibyte/common/sb_tbprof.c:515:23: sparse: got int *
arch/mips/sibyte/common/sb_tbprof.c:531:27: sparse: sparse: incorrect type in initializer (incompatible argument 2 (different address spaces)) @@ expected long ( *read )( ... ) @@ got long ( * )( ... ) @@
arch/mips/sibyte/common/sb_tbprof.c:531:27: sparse: expected long ( *read )( ... )
arch/mips/sibyte/common/sb_tbprof.c:531:27: sparse: got long ( * )( ... )
vim +515 arch/mips/sibyte/common/sb_tbprof.c
^1da177e4c3f415 arch/mips/sibyte/sb1250/bcm1250_tbprof.c Linus Torvalds 2005-04-16 490
d619f38fdacb5ce arch/mips/sibyte/common/sb_tbprof.c Mark Mason 2007-03-29 491 static long sbprof_tb_ioctl(struct file *filp,
d619f38fdacb5ce arch/mips/sibyte/common/sb_tbprof.c Mark Mason 2007-03-29 492 unsigned int command,
^1da177e4c3f415 arch/mips/sibyte/sb1250/bcm1250_tbprof.c Linus Torvalds 2005-04-16 493 unsigned long arg)
^1da177e4c3f415 arch/mips/sibyte/sb1250/bcm1250_tbprof.c Linus Torvalds 2005-04-16 494 {
d619f38fdacb5ce arch/mips/sibyte/common/sb_tbprof.c Mark Mason 2007-03-29 495 int err = 0;
^1da177e4c3f415 arch/mips/sibyte/sb1250/bcm1250_tbprof.c Linus Torvalds 2005-04-16 496
^1da177e4c3f415 arch/mips/sibyte/sb1250/bcm1250_tbprof.c Linus Torvalds 2005-04-16 497 switch (command) {
^1da177e4c3f415 arch/mips/sibyte/sb1250/bcm1250_tbprof.c Linus Torvalds 2005-04-16 498 case SBPROF_ZBSTART:
bb9b813bb665cdb arch/mips/sibyte/sb1250/bcm1250_tbprof.c Ralf Baechle 2007-03-09 499 mutex_lock(&sbp.lock);
d619f38fdacb5ce arch/mips/sibyte/common/sb_tbprof.c Mark Mason 2007-03-29 500 err = sbprof_zbprof_start(filp);
bb9b813bb665cdb arch/mips/sibyte/sb1250/bcm1250_tbprof.c Ralf Baechle 2007-03-09 501 mutex_unlock(&sbp.lock);
^1da177e4c3f415 arch/mips/sibyte/sb1250/bcm1250_tbprof.c Linus Torvalds 2005-04-16 502 break;
bb9b813bb665cdb arch/mips/sibyte/sb1250/bcm1250_tbprof.c Ralf Baechle 2007-03-09 503
^1da177e4c3f415 arch/mips/sibyte/sb1250/bcm1250_tbprof.c Linus Torvalds 2005-04-16 504 case SBPROF_ZBSTOP:
bb9b813bb665cdb arch/mips/sibyte/sb1250/bcm1250_tbprof.c Ralf Baechle 2007-03-09 505 mutex_lock(&sbp.lock);
d619f38fdacb5ce arch/mips/sibyte/common/sb_tbprof.c Mark Mason 2007-03-29 506 err = sbprof_zbprof_stop();
bb9b813bb665cdb arch/mips/sibyte/sb1250/bcm1250_tbprof.c Ralf Baechle 2007-03-09 507 mutex_unlock(&sbp.lock);
^1da177e4c3f415 arch/mips/sibyte/sb1250/bcm1250_tbprof.c Linus Torvalds 2005-04-16 508 break;
bb9b813bb665cdb arch/mips/sibyte/sb1250/bcm1250_tbprof.c Ralf Baechle 2007-03-09 509
d619f38fdacb5ce arch/mips/sibyte/common/sb_tbprof.c Mark Mason 2007-03-29 510 case SBPROF_ZBWAITFULL: {
d619f38fdacb5ce arch/mips/sibyte/common/sb_tbprof.c Mark Mason 2007-03-29 511 err = wait_event_interruptible(sbp.tb_read, TB_FULL);
d619f38fdacb5ce arch/mips/sibyte/common/sb_tbprof.c Mark Mason 2007-03-29 512 if (err)
bb9b813bb665cdb arch/mips/sibyte/sb1250/bcm1250_tbprof.c Ralf Baechle 2007-03-09 513 break;
bb9b813bb665cdb arch/mips/sibyte/sb1250/bcm1250_tbprof.c Ralf Baechle 2007-03-09 514
d619f38fdacb5ce arch/mips/sibyte/common/sb_tbprof.c Mark Mason 2007-03-29 @515 err = put_user(TB_FULL, (int *) arg);
bb9b813bb665cdb arch/mips/sibyte/sb1250/bcm1250_tbprof.c Ralf Baechle 2007-03-09 516 break;
d619f38fdacb5ce arch/mips/sibyte/common/sb_tbprof.c Mark Mason 2007-03-29 517 }
bb9b813bb665cdb arch/mips/sibyte/sb1250/bcm1250_tbprof.c Ralf Baechle 2007-03-09 518
^1da177e4c3f415 arch/mips/sibyte/sb1250/bcm1250_tbprof.c Linus Torvalds 2005-04-16 519 default:
d619f38fdacb5ce arch/mips/sibyte/common/sb_tbprof.c Mark Mason 2007-03-29 520 err = -EINVAL;
^1da177e4c3f415 arch/mips/sibyte/sb1250/bcm1250_tbprof.c Linus Torvalds 2005-04-16 521 break;
^1da177e4c3f415 arch/mips/sibyte/sb1250/bcm1250_tbprof.c Linus Torvalds 2005-04-16 522 }
^1da177e4c3f415 arch/mips/sibyte/sb1250/bcm1250_tbprof.c Linus Torvalds 2005-04-16 523
d619f38fdacb5ce arch/mips/sibyte/common/sb_tbprof.c Mark Mason 2007-03-29 524 return err;
^1da177e4c3f415 arch/mips/sibyte/sb1250/bcm1250_tbprof.c Linus Torvalds 2005-04-16 525 }
^1da177e4c3f415 arch/mips/sibyte/sb1250/bcm1250_tbprof.c Linus Torvalds 2005-04-16 526
:::::: The code at line 515 was first introduced by commit
:::::: d619f38fdacb5cec0c841798bbadeaf903868852 [MIPS] Add bcm1480 ZBus trace support, fix wait related bugs
:::::: TO: Mark Mason <mmason(a)upwardaccess.com>
:::::: CC: Ralf Baechle <ralf(a)linux-mips.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
7 months, 1 week
Re: [PATCH V3] scsi: target: tcmu: Make cmd_ring_size changeable via configfs.
by kernel test robot
Hi Guixin,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on mkp-scsi/for-next]
[also build test WARNING on v5.17-rc4 next-20220215]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Guixin-Liu/scsi-target-tcmu-Make...
base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
config: x86_64-randconfig-a005-20220214 (https://download.01.org/0day-ci/archive/20220215/202202152239.8LJNreof-lk...)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 37f422f4ac31c8b8041c6b62065263314282dab6)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/7f77700542b8196c546ef10656dda7a10...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Guixin-Liu/scsi-target-tcmu-Make-cmd_ring_size-changeable-via-configfs/20220215-160505
git checkout 7f77700542b8196c546ef10656dda7a107d8d1ad
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/target/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/target/target_core_user.c:2628:9: warning: format specifies type 'unsigned int' but the argument has type 'unsigned long' [-Wformat]
(udev->cmdr_size + CMDR_OFF) >> 20);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/target/target_core_user.c:2744:4: warning: format specifies type 'unsigned int' but the argument has type 'unsigned long' [-Wformat]
(udev->cmdr_size + CMDR_OFF) >> 20);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2 warnings generated.
vim +2628 drivers/target/target_core_user.c
2616
2617 static ssize_t tcmu_show_configfs_dev_params(struct se_device *dev, char *b)
2618 {
2619 struct tcmu_dev *udev = TCMU_DEV(dev);
2620 ssize_t bl = 0;
2621
2622 bl = sprintf(b + bl, "Config: %s ",
2623 udev->dev_config[0] ? udev->dev_config : "NULL");
2624 bl += sprintf(b + bl, "Size: %llu ", udev->dev_size);
2625 bl += sprintf(b + bl, "MaxDataAreaMB: %u ", udev->data_area_mb);
2626 bl += sprintf(b + bl, "DataPagesPerBlk: %u", udev->data_pages_per_blk);
2627 bl += sprintf(b + bl, "CmdRingSizeMB: %u\n",
> 2628 (udev->cmdr_size + CMDR_OFF) >> 20);
2629
2630 return bl;
2631 }
2632
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
7 months, 1 week
[xilinx-xlnx:xlnx_rebase_v5.15_LTS 93/924] arc-elf-ld: fpga-mgr.c:undefined reference to `dma_buf_get'
by kernel test robot
tree: https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.15_LTS
head: 392586c95ba817468e81d14a767a94f3b43a2898
commit: 895021fc75c22703678f683052e95247269caf44 [93/924] fpga: support loading from a pre-allocated buffer
config: arc-randconfig-r043-20220214 (https://download.01.org/0day-ci/archive/20220215/202202152220.RBTD7ilF-lk...)
compiler: arc-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/Xilinx/linux-xlnx/commit/895021fc75c22703678f683052e95...
git remote add xilinx-xlnx https://github.com/Xilinx/linux-xlnx
git fetch --no-tags xilinx-xlnx xlnx_rebase_v5.15_LTS
git checkout 895021fc75c22703678f683052e95247269caf44
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arc SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
arc-elf-ld: drivers/fpga/fpga-mgr.o: in function `fpga_device_ioctl':
fpga-mgr.c:(.text+0x5ca): undefined reference to `dma_buf_get'
>> arc-elf-ld: fpga-mgr.c:(.text+0x5ca): undefined reference to `dma_buf_get'
arc-elf-ld: drivers/fpga/fpga-mgr.o: in function `fpga_mgr_load':
>> fpga-mgr.c:(.text+0xba2): undefined reference to `dma_buf_attach'
>> arc-elf-ld: fpga-mgr.c:(.text+0xba2): undefined reference to `dma_buf_attach'
>> arc-elf-ld: fpga-mgr.c:(.text+0xbc2): undefined reference to `dma_buf_map_attachment'
>> arc-elf-ld: fpga-mgr.c:(.text+0xbc2): undefined reference to `dma_buf_map_attachment'
>> arc-elf-ld: fpga-mgr.c:(.text+0xbe8): undefined reference to `dma_buf_unmap_attachment'
>> arc-elf-ld: fpga-mgr.c:(.text+0xbe8): undefined reference to `dma_buf_unmap_attachment'
>> arc-elf-ld: fpga-mgr.c:(.text+0xbf2): undefined reference to `dma_buf_detach'
>> arc-elf-ld: fpga-mgr.c:(.text+0xbf2): undefined reference to `dma_buf_detach'
>> arc-elf-ld: fpga-mgr.c:(.text+0xbfa): undefined reference to `dma_buf_put'
>> arc-elf-ld: fpga-mgr.c:(.text+0xbfa): undefined reference to `dma_buf_put'
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
7 months, 1 week
Re: [PATCH V6 3/6] mfd: pm8008: Add mfd cell struct to register LDOs
by kernel test robot
Hi Satya,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on next-20220214]
[also build test ERROR on v5.17-rc4]
[cannot apply to robh/for-next broonie-regulator/for-next lee-mfd/for-mfd-next v5.17-rc4 v5.17-rc3 v5.17-rc2]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Satya-Priya/Add-Qualcomm-Technol...
base: 259cbfc98c55ba3b6ef6e61fb7cfc3751dfded1e
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20220215/202202152228.Mmfx9SWj-lk...)
compiler: sh4-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/12b686033a10eae2956b1c8436bfaa8c4...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Satya-Priya/Add-Qualcomm-Technologies-Inc-PM8008-regulator-driver/20220215-165525
git checkout 12b686033a10eae2956b1c8436bfaa8c411baa92
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=sh SHELL=/bin/bash drivers/mfd/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> drivers/mfd/qcom-pm8008.c:272:1: error: expected ',' or ';' before 'static'
272 | static struct i2c_driver pm8008_mfd_driver = {
| ^~~~~~
In file included from drivers/mfd/qcom-pm8008.c:7:
drivers/mfd/qcom-pm8008.c: In function 'pm8008_mfd_driver_init':
>> drivers/mfd/qcom-pm8008.c:279:19: error: 'pm8008_mfd_driver' undeclared (first use in this function); did you mean 'pm8008_mfd_driver_init'?
279 | module_i2c_driver(pm8008_mfd_driver);
| ^~~~~~~~~~~~~~~~~
include/linux/i2c.h:886:42: note: in definition of macro 'i2c_add_driver'
886 | i2c_register_driver(THIS_MODULE, driver)
| ^~~~~~
include/linux/i2c.h:954:9: note: in expansion of macro 'module_driver'
954 | module_driver(__i2c_driver, i2c_add_driver, \
| ^~~~~~~~~~~~~
drivers/mfd/qcom-pm8008.c:279:1: note: in expansion of macro 'module_i2c_driver'
279 | module_i2c_driver(pm8008_mfd_driver);
| ^~~~~~~~~~~~~~~~~
drivers/mfd/qcom-pm8008.c:279:19: note: each undeclared identifier is reported only once for each function it appears in
279 | module_i2c_driver(pm8008_mfd_driver);
| ^~~~~~~~~~~~~~~~~
include/linux/i2c.h:886:42: note: in definition of macro 'i2c_add_driver'
886 | i2c_register_driver(THIS_MODULE, driver)
| ^~~~~~
include/linux/i2c.h:954:9: note: in expansion of macro 'module_driver'
954 | module_driver(__i2c_driver, i2c_add_driver, \
| ^~~~~~~~~~~~~
drivers/mfd/qcom-pm8008.c:279:1: note: in expansion of macro 'module_i2c_driver'
279 | module_i2c_driver(pm8008_mfd_driver);
| ^~~~~~~~~~~~~~~~~
In file included from include/linux/device.h:32,
from include/linux/acpi.h:15,
from include/linux/i2c.h:13,
from drivers/mfd/qcom-pm8008.c:7:
drivers/mfd/qcom-pm8008.c: In function 'pm8008_mfd_driver_exit':
drivers/mfd/qcom-pm8008.c:279:19: error: 'pm8008_mfd_driver' undeclared (first use in this function); did you mean 'pm8008_mfd_driver_exit'?
279 | module_i2c_driver(pm8008_mfd_driver);
| ^~~~~~~~~~~~~~~~~
include/linux/device/driver.h:267:24: note: in definition of macro 'module_driver'
267 | __unregister(&(__driver) , ##__VA_ARGS__); \
| ^~~~~~~~
drivers/mfd/qcom-pm8008.c:279:1: note: in expansion of macro 'module_i2c_driver'
279 | module_i2c_driver(pm8008_mfd_driver);
| ^~~~~~~~~~~~~~~~~
drivers/mfd/qcom-pm8008.c: In function 'pm8008_mfd_driver_init':
include/linux/device/driver.h:263:1: error: control reaches end of non-void function [-Werror=return-type]
263 | } \
| ^
include/linux/i2c.h:954:9: note: in expansion of macro 'module_driver'
954 | module_driver(__i2c_driver, i2c_add_driver, \
| ^~~~~~~~~~~~~
drivers/mfd/qcom-pm8008.c:279:1: note: in expansion of macro 'module_i2c_driver'
279 | module_i2c_driver(pm8008_mfd_driver);
| ^~~~~~~~~~~~~~~~~
At top level:
drivers/mfd/qcom-pm8008.c:230:12: warning: 'pm8008_probe' defined but not used [-Wunused-function]
230 | static int pm8008_probe(struct i2c_client *client)
| ^~~~~~~~~~~~
cc1: some warnings being treated as errors
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for SND_SOC_LPASS_RX_MACRO
Depends on SOUND && !UML && SND && SND_SOC && COMMON_CLK
Selected by
- SND_SOC_SC7280 && SOUND && !UML && SND && SND_SOC && SND_SOC_QCOM && (I2C && SOUNDWIRE || COMPILE_TEST
WARNING: unmet direct dependencies detected for SND_SOC_LPASS_TX_MACRO
Depends on SOUND && !UML && SND && SND_SOC && COMMON_CLK
Selected by
- SND_SOC_SC7280 && SOUND && !UML && SND && SND_SOC && SND_SOC_QCOM && (I2C && SOUNDWIRE || COMPILE_TEST
vim +272 drivers/mfd/qcom-pm8008.c
6b149f3310a466 Guru Das Srinagesh 2021-05-25 271
6b149f3310a466 Guru Das Srinagesh 2021-05-25 @272 static struct i2c_driver pm8008_mfd_driver = {
6b149f3310a466 Guru Das Srinagesh 2021-05-25 273 .driver = {
6b149f3310a466 Guru Das Srinagesh 2021-05-25 274 .name = "pm8008",
6b149f3310a466 Guru Das Srinagesh 2021-05-25 275 .of_match_table = pm8008_match,
6b149f3310a466 Guru Das Srinagesh 2021-05-25 276 },
6b149f3310a466 Guru Das Srinagesh 2021-05-25 277 .probe_new = pm8008_probe,
6b149f3310a466 Guru Das Srinagesh 2021-05-25 278 };
6b149f3310a466 Guru Das Srinagesh 2021-05-25 @279 module_i2c_driver(pm8008_mfd_driver);
6b149f3310a466 Guru Das Srinagesh 2021-05-25 280
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
7 months, 1 week
[luxis1999-iommufd:iommufd-v5.17-rc4 28/56] drivers/iommu/iommufd/selftest.c:198:31: warning: comparison of distinct pointer types lacks a cast
by kernel test robot
tree: https://github.com/luxis1999/iommufd iommufd-v5.17-rc4
head: 94542ac92f6f23784d73c13b39dc95cc4012181c
commit: 047031aaa50c5daed9c24fa0701f7016d4ff6934 [28/56] iommufd: Add a selftest
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20220215/202202152214.sfZjnb0v-lk...)
compiler: alpha-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/luxis1999/iommufd/commit/047031aaa50c5daed9c24fa0701f7...
git remote add luxis1999-iommufd https://github.com/luxis1999/iommufd
git fetch --no-tags luxis1999-iommufd iommufd-v5.17-rc4
git checkout 047031aaa50c5daed9c24fa0701f7016d4ff6934
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=alpha SHELL=/bin/bash drivers/iommu/iommufd/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
drivers/iommu/iommufd/selftest.c: In function 'mock_domain_alloc':
drivers/iommu/iommufd/selftest.c:69:26: error: assignment to 'const struct iommu_domain_ops *' from incompatible pointer type 'const struct iommu_ops *' [-Werror=incompatible-pointer-types]
69 | mock->domain.ops = &domain_mock_ops;
| ^
drivers/iommu/iommufd/selftest.c: At top level:
drivers/iommu/iommufd/selftest.c:180:10: error: 'const struct iommu_ops' has no member named 'domain_free'
180 | .domain_free = mock_domain_free,
| ^~~~~~~~~~~
drivers/iommu/iommufd/selftest.c:180:24: error: initialization of 'struct iommu_device * (*)(struct device *)' from incompatible pointer type 'void (*)(struct iommu_domain *)' [-Werror=incompatible-pointer-types]
180 | .domain_free = mock_domain_free,
| ^~~~~~~~~~~~~~~~
drivers/iommu/iommufd/selftest.c:180:24: note: (near initialization for 'domain_mock_ops.probe_device')
drivers/iommu/iommufd/selftest.c:181:10: error: 'const struct iommu_ops' has no member named 'map_pages'
181 | .map_pages = mock_domain_map_pages,
| ^~~~~~~~~
drivers/iommu/iommufd/selftest.c:181:22: error: initialization of 'void (*)(struct device *)' from incompatible pointer type 'int (*)(struct iommu_domain *, long unsigned int, phys_addr_t, size_t, size_t, int, gfp_t, size_t *)' {aka 'int (*)(struct iommu_domain *, long unsigned int, long long unsigned int, long unsigned int, long unsigned int, int, unsigned int, long unsigned int *)'} [-Werror=incompatible-pointer-types]
181 | .map_pages = mock_domain_map_pages,
| ^~~~~~~~~~~~~~~~~~~~~
drivers/iommu/iommufd/selftest.c:181:22: note: (near initialization for 'domain_mock_ops.release_device')
drivers/iommu/iommufd/selftest.c:182:10: error: 'const struct iommu_ops' has no member named 'unmap_pages'
182 | .unmap_pages = mock_domain_unmap_pages,
| ^~~~~~~~~~~
drivers/iommu/iommufd/selftest.c:182:24: error: initialization of 'void (*)(struct device *)' from incompatible pointer type 'size_t (*)(struct iommu_domain *, long unsigned int, size_t, size_t, struct iommu_iotlb_gather *)' {aka 'long unsigned int (*)(struct iommu_domain *, long unsigned int, long unsigned int, long unsigned int, struct iommu_iotlb_gather *)'} [-Werror=incompatible-pointer-types]
182 | .unmap_pages = mock_domain_unmap_pages,
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/iommu/iommufd/selftest.c:182:24: note: (near initialization for 'domain_mock_ops.probe_finalize')
drivers/iommu/iommufd/selftest.c:183:10: error: 'const struct iommu_ops' has no member named 'iova_to_phys'
183 | .iova_to_phys = mock_domain_iova_to_phys,
| ^~~~~~~~~~~~
drivers/iommu/iommufd/selftest.c:183:25: error: initialization of 'struct iommu_group * (*)(struct device *)' from incompatible pointer type 'phys_addr_t (*)(struct iommu_domain *, dma_addr_t)' {aka 'long long unsigned int (*)(struct iommu_domain *, long long unsigned int)'} [-Werror=incompatible-pointer-types]
183 | .iova_to_phys = mock_domain_iova_to_phys,
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/iommu/iommufd/selftest.c:183:25: note: (near initialization for 'domain_mock_ops.device_group')
drivers/iommu/iommufd/selftest.c: In function 'get_md_pagetable':
>> drivers/iommu/iommufd/selftest.c:198:31: warning: comparison of distinct pointer types lacks a cast
198 | if (hwpt->domain->ops != &domain_mock_ops) {
| ^~
cc1: some warnings being treated as errors
vim +198 drivers/iommu/iommufd/selftest.c
185
186 static inline struct iommufd_hw_pagetable *
187 get_md_pagetable(struct iommufd_ucmd *ucmd, u32 mockpt_id,
188 struct mock_iommu_domain **mock)
189 {
190 struct iommufd_hw_pagetable *hwpt;
191 struct iommufd_object *obj;
192
193 obj = iommufd_get_object(ucmd->ictx, mockpt_id,
194 IOMMUFD_OBJ_HW_PAGETABLE);
195 if (IS_ERR(obj))
196 return ERR_CAST(obj);
197 hwpt = container_of(obj, struct iommufd_hw_pagetable, obj);
> 198 if (hwpt->domain->ops != &domain_mock_ops) {
199 return ERR_PTR(-EINVAL);
200 iommufd_put_object(&hwpt->obj);
201 }
202 *mock = container_of(hwpt->domain, struct mock_iommu_domain, domain);
203 return hwpt;
204 }
205
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
7 months, 1 week
Re: [PATCH v2 2/2] drm/msm/dpu: Add SC8180x to hw catalog
by kernel test robot
Hi Bjorn,
I love your patch! Perhaps something to improve:
[auto build test WARNING on drm/drm-next]
[also build test WARNING on v5.17-rc4 next-20220215]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Bjorn-Andersson/drm-msm-dpu-Add-...
base: git://anongit.freedesktop.org/drm/drm drm-next
config: hexagon-allyesconfig (https://download.01.org/0day-ci/archive/20220215/202202152237.xcXTQpk6-lk...)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 37f422f4ac31c8b8041c6b62065263314282dab6)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/2ad34ad9a2871f13cf0948eecc12d7faa...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Bjorn-Andersson/drm-msm-dpu-Add-INTF_5-interrupts/20220215-123310
git checkout 2ad34ad9a2871f13cf0948eecc12d7faabcee788
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/gpu/drm/msm/ drivers/pwm/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c:1124:39: warning: excess elements in array initializer [-Wexcess-initializers]
.danger_lut_tbl = {0xf, 0xffff, 0x0, 0x0},
^~~
1 warning generated.
vim +1124 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
1117
1118 static const struct dpu_perf_cfg sc8180x_perf_data = {
1119 .max_bw_low = 9600000,
1120 .max_bw_high = 9600000,
1121 .min_core_ib = 2400000,
1122 .min_llcc_ib = 800000,
1123 .min_dram_ib = 800000,
> 1124 .danger_lut_tbl = {0xf, 0xffff, 0x0, 0x0},
1125 .qos_lut_tbl = {
1126 {.nentry = ARRAY_SIZE(sc8180x_qos_linear),
1127 .entries = sc8180x_qos_linear
1128 },
1129 {.nentry = ARRAY_SIZE(sc8180x_qos_macrotile),
1130 .entries = sc8180x_qos_macrotile
1131 },
1132 {.nentry = ARRAY_SIZE(sc7180_qos_nrt),
1133 .entries = sc7180_qos_nrt
1134 },
1135 /* TODO: macrotile-qseed is different from macrotile */
1136 },
1137 .cdp_cfg = {
1138 {.rd_enable = 1, .wr_enable = 1},
1139 {.rd_enable = 1, .wr_enable = 0}
1140 },
1141 .clk_inefficiency_factor = 105,
1142 .bw_inefficiency_factor = 120,
1143 };
1144
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
7 months, 1 week
Re: [PATCH 2/3] clk: Introduce 'critical-clocks' property
by kernel test robot
Hi Marek,
I love your patch! Perhaps something to improve:
[auto build test WARNING on clk/clk-next]
[also build test WARNING on v5.17-rc4 next-20220215]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Marek-Vasut/dt-bindings-clk-Intr...
base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
config: x86_64-randconfig-a002-20220214 (https://download.01.org/0day-ci/archive/20220215/202202152152.8a7M9Tkv-lk...)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 37f422f4ac31c8b8041c6b62065263314282dab6)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/aded04bc3dec13df3f940621d94d84e32...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Marek-Vasut/dt-bindings-clk-Introduce-critical-clocks-property/20220215-164757
git checkout aded04bc3dec13df3f940621d94d84e32ff8a5ea
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/clk/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/clk/clk.c:3881:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
int ret, i, index;
^
1 warning generated.
vim +/ret +3881 drivers/clk/clk.c
3874
3875 static void
3876 __clk_register_critical_clock(struct device_node *np, struct clk_core *core,
3877 struct clk_hw *hw)
3878 {
3879 struct of_phandle_args clkspec;
3880 u32 clksize, clktotal;
> 3881 int ret, i, index;
3882
3883 if (!np)
3884 return;
3885
3886 if (!core->ops->match_clkspec)
3887 return;
3888
3889 if (of_property_read_u32(np, "#clock-cells", &clksize))
3890 return;
3891
3892 /* Clock node with #clock-cells = <0> uses critical-clocks; */
3893 if (clksize == 0) {
3894 if (of_property_read_bool(np, "critical-clocks") &&
3895 !core->ops->match_clkspec(hw, &clkspec))
3896 core->flags |= CLK_IS_CRITICAL;
3897 return;
3898 }
3899
3900 clkspec.np = np;
3901 clktotal = of_property_count_u32_elems(np, "critical-clocks");
3902 clktotal /= clksize;
3903 for (index = 0; index < clktotal; index++) {
3904 for (i = 0; i < clksize; i++) {
3905 ret = of_property_read_u32_index(np, "critical-clocks",
3906 (index * clksize) + i,
3907 &(clkspec.args[i]));
3908 }
3909 if (!core->ops->match_clkspec(hw, &clkspec))
3910 core->flags |= CLK_IS_CRITICAL;
3911 }
3912 }
3913
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
7 months, 1 week
Re: [PATCH] crypto: crypto_xor - use helpers for unaligned accesses
by kernel test robot
Hi Ard,
I love your patch! Perhaps something to improve:
[auto build test WARNING on herbert-cryptodev-2.6/master]
[also build test WARNING on herbert-crypto-2.6/master v5.17-rc4 next-20220215]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Ard-Biesheuvel/crypto-crypto_xor...
base: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
config: arc-allyesconfig (https://download.01.org/0day-ci/archive/20220215/202202152134.HZ9sQwkL-lk...)
compiler: arceb-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/6ca2d09816a67230ab30f3c7e7d87815e...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Ard-Biesheuvel/crypto-crypto_xor-use-helpers-for-unaligned-accesses/20220215-185741
git checkout 6ca2d09816a67230ab30f3c7e7d87815e833d0af
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arc SHELL=/bin/bash drivers/md/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
In file included from arch/arc/include/asm/unaligned.h:11,
from arch/arc/include/asm/io.h:12,
from include/linux/io.h:13,
from include/linux/irq.h:20,
from include/asm-generic/hardirq.h:17,
from ./arch/arc/include/generated/asm/hardirq.h:1,
from include/linux/hardirq.h:11,
from include/linux/highmem.h:11,
from include/linux/bvec.h:10,
from include/linux/blk_types.h:10,
from include/linux/bio.h:10,
from drivers/md/dm-crypt.c:16:
In function 'crypto_xor_cpy',
inlined from 'crypt_iv_tcw_whitening.isra' at drivers/md/dm-crypt.c:645:2:
>> include/asm-generic/unaligned.h:14:15: warning: '*(const struct <anonymous> *)(&buf[0]).x' is used uninitialized [-Wuninitialized]
14 | __pptr->x; \
| ~~~~~~^~~
include/asm-generic/unaligned.h:22:33: note: in expansion of macro '__get_unaligned_t'
22 | #define get_unaligned(ptr) __get_unaligned_t(typeof(*(ptr)), (ptr))
| ^~~~~~~~~~~~~~~~~
include/crypto/algapi.h:183:29: note: in expansion of macro 'get_unaligned'
183 | l = get_unaligned(d) ^ get_unaligned(s1++)
| ^~~~~~~~~~~~~
drivers/md/dm-crypt.c: In function 'crypt_iv_tcw_whitening.isra':
drivers/md/dm-crypt.c:640:12: note: 'buf' declared here
640 | u8 buf[TCW_WHITENING_SIZE];
| ^~~
In file included from arch/arc/include/asm/unaligned.h:11,
from arch/arc/include/asm/io.h:12,
from include/linux/io.h:13,
from include/linux/irq.h:20,
from include/asm-generic/hardirq.h:17,
from ./arch/arc/include/generated/asm/hardirq.h:1,
from include/linux/hardirq.h:11,
from include/linux/highmem.h:11,
from include/linux/bvec.h:10,
from include/linux/blk_types.h:10,
from include/linux/bio.h:10,
from drivers/md/dm-crypt.c:16:
In function 'crypto_xor_cpy',
inlined from 'crypt_iv_tcw_whitening.isra' at drivers/md/dm-crypt.c:645:2:
include/asm-generic/unaligned.h:14:15: warning: '*(const struct <anonymous> *)(&buf[4]).x' is used uninitialized [-Wuninitialized]
14 | __pptr->x; \
| ~~~~~~^~~
include/asm-generic/unaligned.h:22:33: note: in expansion of macro '__get_unaligned_t'
22 | #define get_unaligned(ptr) __get_unaligned_t(typeof(*(ptr)), (ptr))
| ^~~~~~~~~~~~~~~~~
include/crypto/algapi.h:183:29: note: in expansion of macro 'get_unaligned'
183 | l = get_unaligned(d) ^ get_unaligned(s1++)
| ^~~~~~~~~~~~~
drivers/md/dm-crypt.c: In function 'crypt_iv_tcw_whitening.isra':
drivers/md/dm-crypt.c:640:12: note: 'buf' declared here
640 | u8 buf[TCW_WHITENING_SIZE];
| ^~~
In file included from arch/arc/include/asm/unaligned.h:11,
from arch/arc/include/asm/io.h:12,
from include/linux/io.h:13,
from include/linux/irq.h:20,
from include/asm-generic/hardirq.h:17,
from ./arch/arc/include/generated/asm/hardirq.h:1,
from include/linux/hardirq.h:11,
from include/linux/highmem.h:11,
from include/linux/bvec.h:10,
from include/linux/blk_types.h:10,
from include/linux/bio.h:10,
from drivers/md/dm-crypt.c:16:
In function 'crypto_xor_cpy',
inlined from 'crypt_iv_tcw_whitening.isra' at drivers/md/dm-crypt.c:646:2:
include/asm-generic/unaligned.h:14:15: warning: '*(const struct <anonymous> *)(&buf[8]).x' is used uninitialized [-Wuninitialized]
14 | __pptr->x; \
| ~~~~~~^~~
include/asm-generic/unaligned.h:22:33: note: in expansion of macro '__get_unaligned_t'
22 | #define get_unaligned(ptr) __get_unaligned_t(typeof(*(ptr)), (ptr))
| ^~~~~~~~~~~~~~~~~
include/crypto/algapi.h:183:29: note: in expansion of macro 'get_unaligned'
183 | l = get_unaligned(d) ^ get_unaligned(s1++)
| ^~~~~~~~~~~~~
drivers/md/dm-crypt.c: In function 'crypt_iv_tcw_whitening.isra':
drivers/md/dm-crypt.c:640:12: note: 'buf' declared here
640 | u8 buf[TCW_WHITENING_SIZE];
| ^~~
In file included from arch/arc/include/asm/unaligned.h:11,
from arch/arc/include/asm/io.h:12,
from include/linux/io.h:13,
from include/linux/irq.h:20,
from include/asm-generic/hardirq.h:17,
from ./arch/arc/include/generated/asm/hardirq.h:1,
from include/linux/hardirq.h:11,
from include/linux/highmem.h:11,
from include/linux/bvec.h:10,
from include/linux/blk_types.h:10,
from include/linux/bio.h:10,
from drivers/md/dm-crypt.c:16:
In function 'crypto_xor_cpy',
inlined from 'crypt_iv_tcw_whitening.isra' at drivers/md/dm-crypt.c:646:2:
include/asm-generic/unaligned.h:14:15: warning: '*(const struct <anonymous> *)(&buf[12]).x' is used uninitialized [-Wuninitialized]
14 | __pptr->x; \
| ~~~~~~^~~
include/asm-generic/unaligned.h:22:33: note: in expansion of macro '__get_unaligned_t'
22 | #define get_unaligned(ptr) __get_unaligned_t(typeof(*(ptr)), (ptr))
| ^~~~~~~~~~~~~~~~~
include/crypto/algapi.h:183:29: note: in expansion of macro 'get_unaligned'
183 | l = get_unaligned(d) ^ get_unaligned(s1++)
| ^~~~~~~~~~~~~
drivers/md/dm-crypt.c: In function 'crypt_iv_tcw_whitening.isra':
drivers/md/dm-crypt.c:640:12: note: 'buf' declared here
640 | u8 buf[TCW_WHITENING_SIZE];
| ^~~
vim +14 include/asm-generic/unaligned.h
aafe4dbed0bf6c Arnd Bergmann 2009-05-13 11
803f4e1eab7a89 Arnd Bergmann 2021-05-08 12 #define __get_unaligned_t(type, ptr) ({ \
803f4e1eab7a89 Arnd Bergmann 2021-05-08 13 const struct { type x; } __packed *__pptr = (typeof(__pptr))(ptr); \
803f4e1eab7a89 Arnd Bergmann 2021-05-08 @14 __pptr->x; \
803f4e1eab7a89 Arnd Bergmann 2021-05-08 15 })
803f4e1eab7a89 Arnd Bergmann 2021-05-08 16
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
7 months, 1 week