12:09 p.m.
Hi Dave,
I love your patch! Perhaps something to improve:
[auto build test WARNING on vkoul-dmaengine/next]
[also build test WARNING on v5.14-rc1 next-20210714]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Dave-Jiang/Fix-idxd-sub-drivers-...
base: https://git.kernel.org/pub/scm/linux/kernel/git/vkoul/dmaengine.git next
config: x86_64-randconfig-a006-20210714 (attached as .config)
compiler: gcc-10 (Debian 10.2.1-6) 10.2.1 20210110
reproduce (this is a W=1 build):
#
https://github.com/0day-ci/linux/commit/b3be8eaa8a16899b6c4084b14d5a2173b...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Dave-Jiang/Fix-idxd-sub-drivers-setup/20210715-072229
git checkout b3be8eaa8a16899b6c4084b14d5a2173b43299e5
# save the attached .config to linux build tree
make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
drivers/dma/idxd/init.c: In function 'idxd_alloc':
> drivers/dma/idxd/init.c:498:47: warning: implicit conversion from
'enum idxd_type' to 'enum idxd_dev_type' [-Wenum-conversion]
498 | idxd_dev_set_type(&idxd->idxd_dev, idxd->data->type);
| ~~~~~~~~~~^~~~~~
vim +498 drivers/dma/idxd/init.c
483
484 static struct idxd_device *idxd_alloc(struct pci_dev *pdev, struct idxd_driver_data
*data)
485 {
486 struct device *dev = &pdev->dev;
487 struct device *conf_dev;
488 struct idxd_device *idxd;
489 int rc;
490
491 idxd = kzalloc_node(sizeof(*idxd), GFP_KERNEL, dev_to_node(dev));
492 if (!idxd)
493 return NULL;
494
495 conf_dev = idxd_confdev(idxd);
496 idxd->pdev = pdev;
497 idxd->data = data;
498 idxd_dev_set_type(&idxd->idxd_dev,
idxd->data->type);
499 idxd->id = ida_alloc(&idxd_ida,
GFP_KERNEL);
500 if (idxd->id < 0)
501 return NULL;
502
503 device_initialize(conf_dev);
504 conf_dev->parent = dev;
505 conf_dev->bus = &dsa_bus_type;
506 conf_dev->type = idxd->data->dev_type;
507 rc = dev_set_name(conf_dev, "%s%d", idxd->data->name_prefix,
idxd->id);
508 if (rc < 0) {
509 put_device(conf_dev);
510 return NULL;
511 }
512
513 spin_lock_init(&idxd->dev_lock);
514 spin_lock_init(&idxd->cmd_lock);
515
516 return idxd;
517 }
518
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org