12:23 a.m.
tree: https://github.com/intel/linux-intel-lts.git 5.15/linux
head: 91b52769309e2c4d3d4230266426b5eb65418bef
commit: bb9ef3cb40b9748d9a676d8d381668f0ca3a9a9f [2470/2488] net/core: XDP metadata BTF
netlink API
config: m68k-randconfig-c024-20220213
(https://download.01.org/0day-ci/archive/20220213/202202132120.GBB9KEvk-lk...)
compiler: m68k-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/intel/linux-intel-lts/commit/bb9ef3cb40b9748d9a676d8d3...
git remote add intel-lts https://github.com/intel/linux-intel-lts.git
git fetch --no-tags intel-lts 5.15/linux
git checkout bb9ef3cb40b9748d9a676d8d381668f0ca3a9a9f
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir
ARCH=m68k SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
drivers/net/bonding/bond_main.c: In function 'bond_enslave':
> drivers/net/bonding/bond_main.c:2177:36: error: initialized field
overwritten [-Werror=override-init]
2177 | .extack =
extack,
| ^~~~~~
drivers/net/bonding/bond_main.c:2177:36: note: (near initialization for
'xdp.<anonymous>.extack')
In file included from include/uapi/linux/posix_types.h:5,
from include/uapi/linux/types.h:14,
from include/linux/types.h:6,
from include/linux/limits.h:6,
from include/linux/kernel.h:7,
from drivers/net/bonding/bond_main.c:34:
drivers/net/bonding/bond_main.c: In function '__bond_release_one':
> include/linux/stddef.h:8:14: error: initialized field overwritten
[-Werror=override-init]
8 | #define NULL ((void *)0)
| ^
drivers/net/bonding/bond_main.c:2321:36: note: in expansion of macro 'NULL'
2321 | .extack = NULL,
| ^~~~
include/linux/stddef.h:8:14: note: (near initialization for
'xdp.<anonymous>.extack')
8 | #define NULL ((void *)0)
| ^
drivers/net/bonding/bond_main.c:2321:36: note: in expansion of macro 'NULL'
2321 | .extack = NULL,
| ^~~~
drivers/net/bonding/bond_main.c: In function 'bond_xdp_set':
drivers/net/bonding/bond_main.c:5187:28: error: initialized field overwritten
[-Werror=override-init]
5187 | .extack = extack,
| ^~~~~~
drivers/net/bonding/bond_main.c:5187:28: note: (near initialization for
'xdp.<anonymous>.extack')
cc1: all warnings being treated as errors
vim +2177 drivers/net/bonding/bond_main.c
8a8efa22f51b3c Amerigo Wang 2011-02-17 2091
fbe168ba91f7c3 Michal Kubeček 2014-11-13 2092 if (!(bond_dev->features
& NETIF_F_LRO))
fbe168ba91f7c3 Michal Kubeček 2014-11-13 2093
dev_disable_lro(slave_dev);
fbe168ba91f7c3 Michal Kubeček 2014-11-13 2094
35d48903e97819 Jiri Pirko 2011-03-22 2095 res =
netdev_rx_handler_register(slave_dev, bond_handle_frame,
35d48903e97819 Jiri Pirko 2011-03-22 2096 new_slave);
35d48903e97819 Jiri Pirko 2011-03-22 2097 if (res) {
e2a7420df2e013 Jarod Wilson 2019-06-07 2098 slave_dbg(bond_dev,
slave_dev, "Error %d calling netdev_rx_handler_register\n", res);
5831d66e8097ae Veaceslav Falico 2013-09-25 2099 goto err_detach;
35d48903e97819 Jiri Pirko 2011-03-22 2100 }
35d48903e97819 Jiri Pirko 2011-03-22 2101
42ab19ee902929 David Ahern 2017-10-04 2102 res =
bond_master_upper_dev_link(bond, new_slave, extack);
1f718f0f4f9714 Veaceslav Falico 2013-09-25 2103 if (res) {
e2a7420df2e013 Jarod Wilson 2019-06-07 2104 slave_dbg(bond_dev,
slave_dev, "Error %d calling bond_master_upper_dev_link\n", res);
1f718f0f4f9714 Veaceslav Falico 2013-09-25 2105 goto err_unregister;
1f718f0f4f9714 Veaceslav Falico 2013-09-25 2106 }
1f718f0f4f9714 Veaceslav Falico 2013-09-25 2107
32d4c5647aad13 Tobias Waldekranz 2021-01-13 2108
bond_lower_state_changed(new_slave);
32d4c5647aad13 Tobias Waldekranz 2021-01-13 2109
07699f9a7c8d10 sfeldma(a)cumulusnetworks.com 2014-01-16 2110 res =
bond_sysfs_slave_add(new_slave);
07699f9a7c8d10 sfeldma(a)cumulusnetworks.com 2014-01-16 2111 if (res) {
e2a7420df2e013 Jarod Wilson 2019-06-07 2112 slave_dbg(bond_dev,
slave_dev, "Error %d calling bond_sysfs_slave_add\n", res);
07699f9a7c8d10 sfeldma(a)cumulusnetworks.com 2014-01-16 2113 goto err_upper_unlink;
07699f9a7c8d10 sfeldma(a)cumulusnetworks.com 2014-01-16 2114 }
07699f9a7c8d10 sfeldma(a)cumulusnetworks.com 2014-01-16 2115
ae42cc62a9f07f Xin Long 2018-03-26 2116 /* If the mode uses primary,
then the following is handled by
ae42cc62a9f07f Xin Long 2018-03-26 2117 *
bond_change_active_slave().
ae42cc62a9f07f Xin Long 2018-03-26 2118 */
ae42cc62a9f07f Xin Long 2018-03-26 2119 if
(!bond_uses_primary(bond)) {
ae42cc62a9f07f Xin Long 2018-03-26 2120 /* set promiscuity level to
new slave */
ae42cc62a9f07f Xin Long 2018-03-26 2121 if (bond_dev->flags
& IFF_PROMISC) {
ae42cc62a9f07f Xin Long 2018-03-26 2122 res =
dev_set_promiscuity(slave_dev, 1);
ae42cc62a9f07f Xin Long 2018-03-26 2123 if (res)
ae42cc62a9f07f Xin Long 2018-03-26 2124 goto err_sysfs_del;
ae42cc62a9f07f Xin Long 2018-03-26 2125 }
ae42cc62a9f07f Xin Long 2018-03-26 2126
ae42cc62a9f07f Xin Long 2018-03-26 2127 /* set allmulti level to
new slave */
ae42cc62a9f07f Xin Long 2018-03-26 2128 if (bond_dev->flags
& IFF_ALLMULTI) {
ae42cc62a9f07f Xin Long 2018-03-26 2129 res =
dev_set_allmulti(slave_dev, 1);
9f5a90c107741b Xin Long 2018-03-26 2130 if (res) {
9f5a90c107741b Xin Long 2018-03-26 2131 if (bond_dev->flags
& IFF_PROMISC)
9f5a90c107741b Xin Long 2018-03-26 2132
dev_set_promiscuity(slave_dev, -1);
ae42cc62a9f07f Xin Long 2018-03-26 2133 goto err_sysfs_del;
ae42cc62a9f07f Xin Long 2018-03-26 2134 }
9f5a90c107741b Xin Long 2018-03-26 2135 }
ae42cc62a9f07f Xin Long 2018-03-26 2136
ae42cc62a9f07f Xin Long 2018-03-26 2137
netif_addr_lock_bh(bond_dev);
ae42cc62a9f07f Xin Long 2018-03-26 2138
dev_mc_sync_multiple(slave_dev, bond_dev);
ae42cc62a9f07f Xin Long 2018-03-26 2139
dev_uc_sync_multiple(slave_dev, bond_dev);
ae42cc62a9f07f Xin Long 2018-03-26 2140
netif_addr_unlock_bh(bond_dev);
ae42cc62a9f07f Xin Long 2018-03-26 2141
ae42cc62a9f07f Xin Long 2018-03-26 2142 if (BOND_MODE(bond) ==
BOND_MODE_8023AD) {
ae42cc62a9f07f Xin Long 2018-03-26 2143 /* add lacpdu mc addr to
mc list */
ae42cc62a9f07f Xin Long 2018-03-26 2144 u8
lacpdu_multicast[ETH_ALEN] = MULTICAST_LACPDU_ADDR;
ae42cc62a9f07f Xin Long 2018-03-26 2145
ae42cc62a9f07f Xin Long 2018-03-26 2146 dev_mc_add(slave_dev,
lacpdu_multicast);
ae42cc62a9f07f Xin Long 2018-03-26 2147 }
ae42cc62a9f07f Xin Long 2018-03-26 2148 }
ae42cc62a9f07f Xin Long 2018-03-26 2149
5378c2e6ea236d Veaceslav Falico 2013-10-21 2150 bond->slave_cnt++;
5378c2e6ea236d Veaceslav Falico 2013-10-21 2151
bond_compute_features(bond);
5378c2e6ea236d Veaceslav Falico 2013-10-21 2152 bond_set_carrier(bond);
5378c2e6ea236d Veaceslav Falico 2013-10-21 2153
ec0865a94991d1 Veaceslav Falico 2014-05-15 2154 if (bond_uses_primary(bond))
{
f80889a5b79cae dingtianhong 2014-02-12 2155 block_netpoll_tx();
5378c2e6ea236d Veaceslav Falico 2013-10-21 2156
bond_select_active_slave(bond);
f80889a5b79cae dingtianhong 2014-02-12 2157 unblock_netpoll_tx();
5378c2e6ea236d Veaceslav Falico 2013-10-21 2158 }
1f718f0f4f9714 Veaceslav Falico 2013-09-25 2159
e79c1055749e31 Debabrata Banerjee 2018-05-14 2160 if
(bond_mode_can_use_xmit_hash(bond))
ee6377147409a0 Mahesh Bandewar 2014-10-04 2161 bond_update_slave_arr(bond,
NULL);
ee6377147409a0 Mahesh Bandewar 2014-10-04 2162
21706ee8a47d3e Debabrata Banerjee 2018-05-09 2163
9e2ee5c7e7c35d Jussi Maki 2021-07-31 2164 if
(!slave_dev->netdev_ops->ndo_bpf ||
9e2ee5c7e7c35d Jussi Maki 2021-07-31 2165
!slave_dev->netdev_ops->ndo_xdp_xmit) {
9e2ee5c7e7c35d Jussi Maki 2021-07-31 2166 if (bond->xdp_prog) {
6569fa2d4e0147 Jonathan Toppins 2021-08-10 2167 SLAVE_NL_ERR(bond_dev,
slave_dev, extack,
6569fa2d4e0147 Jonathan Toppins 2021-08-10 2168 "Slave does not
support XDP");
9e2ee5c7e7c35d Jussi Maki 2021-07-31 2169 res = -EOPNOTSUPP;
9e2ee5c7e7c35d Jussi Maki 2021-07-31 2170 goto err_sysfs_del;
9e2ee5c7e7c35d Jussi Maki 2021-07-31 2171 }
6d5f1ef838683e Jussi Maki 2021-09-06 2172 } else if
(bond->xdp_prog) {
9e2ee5c7e7c35d Jussi Maki 2021-07-31 2173 struct netdev_bpf xdp = {
9e2ee5c7e7c35d Jussi Maki 2021-07-31 2174 .command =
XDP_SETUP_PROG,
9e2ee5c7e7c35d Jussi Maki 2021-07-31 2175 .flags = 0,
9e2ee5c7e7c35d Jussi Maki 2021-07-31 2176 .prog =
bond->xdp_prog,
9e2ee5c7e7c35d Jussi Maki 2021-07-31 @2177 .extack = extack,
9e2ee5c7e7c35d Jussi Maki 2021-07-31 2178 };
9e2ee5c7e7c35d Jussi Maki 2021-07-31 2179
9e2ee5c7e7c35d Jussi Maki 2021-07-31 2180 if
(dev_xdp_prog_count(slave_dev) > 0) {
6569fa2d4e0147 Jonathan Toppins 2021-08-10 2181 SLAVE_NL_ERR(bond_dev,
slave_dev, extack,
9e2ee5c7e7c35d Jussi Maki 2021-07-31 2182 "Slave has XDP
program loaded, please unload before enslaving");
9e2ee5c7e7c35d Jussi Maki 2021-07-31 2183 res = -EOPNOTSUPP;
9e2ee5c7e7c35d Jussi Maki 2021-07-31 2184 goto err_sysfs_del;
9e2ee5c7e7c35d Jussi Maki 2021-07-31 2185 }
9e2ee5c7e7c35d Jussi Maki 2021-07-31 2186
9e2ee5c7e7c35d Jussi Maki 2021-07-31 2187 res =
slave_dev->netdev_ops->ndo_bpf(slave_dev, &xdp);
9e2ee5c7e7c35d Jussi Maki 2021-07-31 2188 if (res < 0) {
9e2ee5c7e7c35d Jussi Maki 2021-07-31 2189 /* ndo_bpf() sets extack
error message */
9e2ee5c7e7c35d Jussi Maki 2021-07-31 2190 slave_dbg(bond_dev,
slave_dev, "Error %d calling ndo_bpf\n", res);
9e2ee5c7e7c35d Jussi Maki 2021-07-31 2191 goto err_sysfs_del;
9e2ee5c7e7c35d Jussi Maki 2021-07-31 2192 }
9e2ee5c7e7c35d Jussi Maki 2021-07-31 2193 if (bond->xdp_prog)
9e2ee5c7e7c35d Jussi Maki 2021-07-31 2194
bpf_prog_inc(bond->xdp_prog);
9e2ee5c7e7c35d Jussi Maki 2021-07-31 2195 }
9e2ee5c7e7c35d Jussi Maki 2021-07-31 2196
e2a7420df2e013 Jarod Wilson 2019-06-07 2197 slave_info(bond_dev,
slave_dev, "Enslaving as %s interface with %s link\n",
90194264ceffdf Joe Perches 2014-02-15 2198
bond_is_active_slave(new_slave) ? "an active" : "a backup",
90194264ceffdf Joe Perches 2014-02-15 2199 new_slave->link !=
BOND_LINK_DOWN ? "an up" : "a down");
^1da177e4c3f41 Linus Torvalds 2005-04-16 2200
^1da177e4c3f41 Linus Torvalds 2005-04-16 2201 /* enslave is successful */
69e6113343cfe9 Moni Shoua 2015-02-03 2202
bond_queue_slave_event(new_slave);
^1da177e4c3f41 Linus Torvalds 2005-04-16 2203 return 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16 2204
:::::: The code at line 2177 was first introduced by commit
:::::: 9e2ee5c7e7c35d195e2aa0692a7241d47a433d1e net, bonding: Add XDP support to the
bonding driver
:::::: TO: Jussi Maki <joamaki(a)gmail.com>
:::::: CC: Daniel Borkmann <daniel(a)iogearbox.net>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org