From: kernel test robot <lkp(a)intel.com>
kernel/debug/debug_core.c:431:2-8: SUGGESTION: printk + WARN_ON_ONCE can be just
WARN_ONCE
Use WARN(1,...) rather than printk followed by WARN_ON(1)
Generated by: scripts/coccinelle/misc/warn.cocci
Fixes: 8214bf079208 ("scripts/dtc: Export YYLOC global declaration")
Reported-by: kernel test robot <lkp(a)intel.com>
Signed-off-by: kernel test robot <lkp(a)intel.com>
---
tree:
https://android.googlesource.com/kernel/goldfish android-3.18
head: dd54b61f1458c03f68fc019b4874d98f2f0ae3a5
commit: 8214bf079208b146e63cd0a3ce0ed335a87ce7b3 [396/1051] scripts/dtc: Export YYLOC
global declaration
:::::: branch date: 5 weeks ago
:::::: commit date: 3 months ago
debug_core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--- a/kernel/debug/debug_core.c
+++ b/kernel/debug/debug_core.c
@@ -428,9 +428,9 @@ static int kgdb_reenter_check(struct kgd
exception_level = 0;
kgdb_skipexception(ks->ex_vector, ks->linux_regs);
dbg_activate_sw_breakpoints();
- printk(KERN_CRIT "KGDB: re-enter error: breakpoint removed %lx\n",
- addr);
- WARN_ON_ONCE(1);
+ WARN_ONCE(1,
+ KERN_CRIT "KGDB: re-enter error: breakpoint removed %lx\n",
+ addr);
return 1;
}