2:22 p.m.
Hi Alexander,
Thanks for your patch! Perhaps something to improve:
[auto build test WARNING on drm-tip/drm-tip]
[also build test WARNING on next-20220209]
[cannot apply to drm-intel/for-linux-next char-misc/char-misc-testing linus/master
v5.17-rc3]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Alexander-Usyskin/Add-driver-for...
base: git://anongit.freedesktop.org/drm/drm-tip drm-tip
config: i386-randconfig-c001-20220207
(https://download.01.org/0day-ci/archive/20220209/202202092218.JQby54ao-lk...)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project
0d8850ae2cae85d49bea6ae0799fa41c7202c05c)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/3640b7d101ae88e367a0abc2cda8eb46d...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Alexander-Usyskin/Add-driver-for-GSC-controller/20220206-211428
git checkout 3640b7d101ae88e367a0abc2cda8eb46dbab2982
# save the config file to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=i386
clang-analyzer
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <yujie.liu(a)intel.com>
clang-analyzer warnings: (new ones prefixed by >>)
> drivers/gpu/drm/i915/gt/intel_gsc.c:109:3: warning: Value stored
to 'ret' is never read [clang-analyzer-deadcode.DeadStores]
ret = -ENOMEM;
^ ~~~~~~~
> drivers/gpu/drm/i915/gt/intel_gsc.c:112:2: warning: Value stored
to 'aux_dev' is never read [clang-analyzer-deadcode.DeadStores]
aux_dev = &adev->aux_dev;
^ ~~~~~~~~~~~~~~
vim +/ret +109 drivers/gpu/drm/i915/gt/intel_gsc.c
3640b7d101ae88 Tomas Winkler 2022-02-06 75
3640b7d101ae88 Tomas Winkler 2022-02-06 76 static void intel_gsc_init_one(struct
drm_i915_private *dev_priv,
3640b7d101ae88 Tomas Winkler 2022-02-06 77 struct intel_gsc_intf *intf,
3640b7d101ae88 Tomas Winkler 2022-02-06 78 unsigned int intf_id)
3640b7d101ae88 Tomas Winkler 2022-02-06 79 {
3640b7d101ae88 Tomas Winkler 2022-02-06 80 struct pci_dev *pdev =
to_pci_dev(dev_priv->drm.dev);
3640b7d101ae88 Tomas Winkler 2022-02-06 81 struct mei_aux_device *adev;
3640b7d101ae88 Tomas Winkler 2022-02-06 82 struct auxiliary_device *aux_dev;
3640b7d101ae88 Tomas Winkler 2022-02-06 83 const struct intel_gsc_def *def;
3640b7d101ae88 Tomas Winkler 2022-02-06 84 int ret;
3640b7d101ae88 Tomas Winkler 2022-02-06 85
3640b7d101ae88 Tomas Winkler 2022-02-06 86 intf->irq = -1;
3640b7d101ae88 Tomas Winkler 2022-02-06 87 intf->id = intf_id;
3640b7d101ae88 Tomas Winkler 2022-02-06 88
3640b7d101ae88 Tomas Winkler 2022-02-06 89 if (intf_id == 0 &&
!HAS_HECI_PXP(dev_priv))
3640b7d101ae88 Tomas Winkler 2022-02-06 90 return;
3640b7d101ae88 Tomas Winkler 2022-02-06 91
3640b7d101ae88 Tomas Winkler 2022-02-06 92 def = &intel_gsc_def_dg1[intf_id];
3640b7d101ae88 Tomas Winkler 2022-02-06 93
3640b7d101ae88 Tomas Winkler 2022-02-06 94 dev_dbg(&pdev->dev, "init gsc
one with id %d\n", intf_id);
3640b7d101ae88 Tomas Winkler 2022-02-06 95 intf->irq = irq_alloc_desc(0);
3640b7d101ae88 Tomas Winkler 2022-02-06 96 if (intf->irq < 0) {
3640b7d101ae88 Tomas Winkler 2022-02-06 97 dev_err(&pdev->dev, "gsc irq
error %d\n", intf->irq);
3640b7d101ae88 Tomas Winkler 2022-02-06 98 return;
3640b7d101ae88 Tomas Winkler 2022-02-06 99 }
3640b7d101ae88 Tomas Winkler 2022-02-06 100
3640b7d101ae88 Tomas Winkler 2022-02-06 101 ret = gsc_irq_init(dev_priv,
intf->irq);
3640b7d101ae88 Tomas Winkler 2022-02-06 102 if (ret < 0) {
3640b7d101ae88 Tomas Winkler 2022-02-06 103 dev_err(&pdev->dev, "gsc irq
init failed %d\n", ret);
3640b7d101ae88 Tomas Winkler 2022-02-06 104 goto fail;
3640b7d101ae88 Tomas Winkler 2022-02-06 105 }
3640b7d101ae88 Tomas Winkler 2022-02-06 106
3640b7d101ae88 Tomas Winkler 2022-02-06 107 adev = kzalloc(sizeof(*adev), GFP_KERNEL);
3640b7d101ae88 Tomas Winkler 2022-02-06 108 if (!adev) {
3640b7d101ae88 Tomas Winkler 2022-02-06 @109 ret = -ENOMEM;
3640b7d101ae88 Tomas Winkler 2022-02-06 110 goto fail;
3640b7d101ae88 Tomas Winkler 2022-02-06 111 }
3640b7d101ae88 Tomas Winkler 2022-02-06 @112 aux_dev = &adev->aux_dev;
3640b7d101ae88 Tomas Winkler 2022-02-06 113
3640b7d101ae88 Tomas Winkler 2022-02-06 114 adev->irq = intf->irq;
3640b7d101ae88 Tomas Winkler 2022-02-06 115 adev->bar.parent =
&pdev->resource[0];
3640b7d101ae88 Tomas Winkler 2022-02-06 116 adev->bar.start = def->bar +
pdev->resource[0].start;
3640b7d101ae88 Tomas Winkler 2022-02-06 117 adev->bar.end = adev->bar.start +
def->bar_size - 1;
3640b7d101ae88 Tomas Winkler 2022-02-06 118 adev->bar.flags = IORESOURCE_MEM;
3640b7d101ae88 Tomas Winkler 2022-02-06 119 adev->bar.desc = IORES_DESC_NONE;
3640b7d101ae88 Tomas Winkler 2022-02-06 120
3640b7d101ae88 Tomas Winkler 2022-02-06 121 aux_dev = &adev->aux_dev;
3640b7d101ae88 Tomas Winkler 2022-02-06 122 aux_dev->name = def->name;
3640b7d101ae88 Tomas Winkler 2022-02-06 123 aux_dev->id =
(pci_domain_nr(pdev->bus) << 16) |
3640b7d101ae88 Tomas Winkler 2022-02-06 124 PCI_DEVID(pdev->bus->number,
pdev->devfn);
3640b7d101ae88 Tomas Winkler 2022-02-06 125 aux_dev->dev.parent =
&pdev->dev;
3640b7d101ae88 Tomas Winkler 2022-02-06 126 aux_dev->dev.release =
intel_gsc_release_dev;
3640b7d101ae88 Tomas Winkler 2022-02-06 127
3640b7d101ae88 Tomas Winkler 2022-02-06 128 ret = auxiliary_device_init(aux_dev);
3640b7d101ae88 Tomas Winkler 2022-02-06 129 if (ret < 0) {
3640b7d101ae88 Tomas Winkler 2022-02-06 130 dev_err(&pdev->dev, "gsc aux
init failed %d\n", ret);
3640b7d101ae88 Tomas Winkler 2022-02-06 131 kfree(adev);
3640b7d101ae88 Tomas Winkler 2022-02-06 132 goto fail;
3640b7d101ae88 Tomas Winkler 2022-02-06 133 }
3640b7d101ae88 Tomas Winkler 2022-02-06 134
3640b7d101ae88 Tomas Winkler 2022-02-06 135 ret = auxiliary_device_add(aux_dev);
3640b7d101ae88 Tomas Winkler 2022-02-06 136 if (ret < 0) {
3640b7d101ae88 Tomas Winkler 2022-02-06 137 dev_err(&pdev->dev, "gsc aux
add failed %d\n", ret);
3640b7d101ae88 Tomas Winkler 2022-02-06 138 /* adev will be freed with the
put_device() and .release sequence */
3640b7d101ae88 Tomas Winkler 2022-02-06 139 auxiliary_device_uninit(aux_dev);
3640b7d101ae88 Tomas Winkler 2022-02-06 140 goto fail;
3640b7d101ae88 Tomas Winkler 2022-02-06 141 }
3640b7d101ae88 Tomas Winkler 2022-02-06 142 intf->adev = adev;
3640b7d101ae88 Tomas Winkler 2022-02-06 143
3640b7d101ae88 Tomas Winkler 2022-02-06 144 dev_dbg(&pdev->dev, "gsc init
one done\n");
3640b7d101ae88 Tomas Winkler 2022-02-06 145 return;
3640b7d101ae88 Tomas Winkler 2022-02-06 146 fail:
3640b7d101ae88 Tomas Winkler 2022-02-06 147 intel_gsc_destroy_one(intf);
3640b7d101ae88 Tomas Winkler 2022-02-06 148 }
3640b7d101ae88 Tomas Winkler 2022-02-06 149
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org