4:28 a.m.
On Fri, Mar 19, 2021 at 6:12 PM kernel test robot <lkp(a)intel.com> wrote:
Hi Eric,
I love your patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Eric-Dumazet/net-add-CONFIG_PCPU...
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
38cb57602369cf194556460a52bd18e53c76e13d
config: arm-randconfig-r014-20210318 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project
fcc1ce00931751ac02498986feb37744e9ace8de)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
#
https://github.com/0day-ci/linux/commit/684c34243e0c84e496aa426734df321b7...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Eric-Dumazet/net-add-CONFIG_PCPU_DEV_REFCNT/20210319-230417
git checkout 684c34243e0c84e496aa426734df321b7ebc088b
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> net/core/dev.c:10752:1: warning: unused label 'free_dev'
[-Wunused-label]
free_dev:
^~~~~~~~~
Great, I will add the following diff to v2
diff --git a/net/core/dev.c b/net/core/dev.c
index edde830df1a483535372014034d5b1ee1ff6210a..be941ed754ac71d0839604bcfdd8ab67c339d27f
100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -10748,8 +10748,8 @@ struct net_device *alloc_netdev_mqs(int
sizeof_priv, const char *name,
free_pcpu:
#ifdef CONFIG_PCPU_DEV_REFCNT
free_percpu(dev->pcpu_refcnt);
-#endif
free_dev:
+#endif
netdev_freemem(dev);
return NULL;
}