[kbuild-all] Re: [PATCH v2 13/13] security/integrity/ima: converts stats to seqnum_ops

Hi Shuah, I love your patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] [also build test ERROR on integrity/next-integrity char-misc/char-misc-testing usb/usb-testing linus/master v5.10-rc3 next-20201113] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Shuah-Khan/Introduce-seqnum_ops/... base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git f4acd33c446b2ba97f1552a4da90050109d01ca7 config: nios2-randconfig-r023-20201114 (attached as .config) compiler: nios2-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/b86077d3629fe6d16070d95b833134425... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Shuah-Khan/Introduce-seqnum_ops/20201114-014959 git checkout b86077d3629fe6d16070d95b8331344258dcaed2 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nios2 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All error/warnings (new ones prefixed by >>): In file included from security/integrity/ima/ima_fs.c:26: security/integrity/ima/ima.h:178:18: error: field 'len' has incomplete type 178 | struct seqnum64 len; /* number of stored measurements in the list */ | ^~~ security/integrity/ima/ima.h:179:18: error: field 'violations' has incomplete type 179 | struct seqnum64 violations; | ^~~~~~~~~~ security/integrity/ima/ima_fs.c: In function 'ima_show_htable_value': 48 | len = scnprintf(tmpbuf, sizeof(tmpbuf), "%llu\n", seqnum64_fetch(val)); | ^~~~~~~~~~~~~~ | seqnum32_fetch 48 | len = scnprintf(tmpbuf, sizeof(tmpbuf), "%llu\n", seqnum64_fetch(val)); | ~~~^ ~~~~~~~~~~~~~~~~~~~ | | | | | int | long long unsigned int | %u security/integrity/ima/ima_fs.c: In function 'ima_show_htable_violations': security/integrity/ima/ima_fs.c:57:1: error: control reaches end of non-void function [-Werror=return-type] 57 | } | ^ security/integrity/ima/ima_fs.c: In function 'ima_show_measurements_count': security/integrity/ima/ima_fs.c:70:1: error: control reaches end of non-void function [-Werror=return-type] 70 | } | ^ cc1: some warnings being treated as errors -- In file included from security/integrity/ima/ima_queue.c:21: security/integrity/ima/ima.h:178:18: error: field 'len' has incomplete type 178 | struct seqnum64 len; /* number of stored measurements in the list */ | ^~~ security/integrity/ima/ima.h:179:18: error: field 'violations' has incomplete type 179 | struct seqnum64 violations; | ^~~~~~~~~~ In file included from security/integrity/ima/ima_queue.c:20: include/linux/seqnum_ops.h:40:27: error: field name not in record or union initializer 40 | #define SEQNUM_INIT(i) { .seqnum = ATOMIC_INIT(i) } | ^ security/integrity/ima/ima_queue.c:37:9: note: in expansion of macro 'SEQNUM_INIT' 37 | .len = SEQNUM_INIT(0), | ^~~~~~~~~~~ include/linux/seqnum_ops.h:40:27: note: (near initialization for 'ima_htable.len') 40 | #define SEQNUM_INIT(i) { .seqnum = ATOMIC_INIT(i) } | ^ security/integrity/ima/ima_queue.c:37:9: note: in expansion of macro 'SEQNUM_INIT' 37 | .len = SEQNUM_INIT(0), | ^~~~~~~~~~~ include/linux/seqnum_ops.h:40:27: error: field name not in record or union initializer 40 | #define SEQNUM_INIT(i) { .seqnum = ATOMIC_INIT(i) } | ^ security/integrity/ima/ima_queue.c:38:16: note: in expansion of macro 'SEQNUM_INIT' 38 | .violations = SEQNUM_INIT(0), | ^~~~~~~~~~~ include/linux/seqnum_ops.h:40:27: note: (near initialization for 'ima_htable.violations') 40 | #define SEQNUM_INIT(i) { .seqnum = ATOMIC_INIT(i) } | ^ security/integrity/ima/ima_queue.c:38:16: note: in expansion of macro 'SEQNUM_INIT' 38 | .violations = SEQNUM_INIT(0), | ^~~~~~~~~~~ security/integrity/ima/ima_queue.c: In function 'ima_add_digest_entry': 110 | seqnum64_inc_return(&ima_htable.len); | ^~~~~~~~~~~~~~~~~~~ | seqnum32_inc_return cc1: some warnings being treated as errors -- In file included from security/integrity/ima/ima_api.c:19: security/integrity/ima/ima.h:178:18: error: field 'len' has incomplete type 178 | struct seqnum64 len; /* number of stored measurements in the list */ | ^~~ security/integrity/ima/ima.h:179:18: error: field 'violations' has incomplete type 179 | struct seqnum64 violations; | ^~~~~~~~~~ security/integrity/ima/ima_api.c: In function 'ima_add_violation': 148 | seqnum64_inc_return(&ima_htable.violations); | ^~~~~~~~~~~~~~~~~~~ | seqnum32_inc_return cc1: some warnings being treated as errors vim +48 security/integrity/ima/ima_fs.c 41 42 static ssize_t ima_show_htable_value(char __user *buf, size_t count, 43 loff_t *ppos, struct seqnum64 *val) 44 { 45 char tmpbuf[32]; /* greater than largest 'long' string value */ 46 ssize_t len; 47 49 return simple_read_from_buffer(buf, count, ppos, tmpbuf, len); 50 } 51 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org