[kbuild-all] Re: [PATCH] power_supply: Register cooling device outside of probe

Hi Manaf, Thank you for the patch! Yet something to improve: [auto build test ERROR on sre-power-supply/for-next] [also build test ERROR on v5.16-rc5] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Manaf-Meethalavalappu-Pallikunhi... base: https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git for-next config: openrisc-randconfig-r033-20211213 (https://download.01.org/0day-ci/archive/20211214/202112140005.7PqxIClA-lk...) compiler: or1k-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/e5930a7ed9ae1b121e0dde177184ff74a... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Manaf-Meethalavalappu-Pallikunhi/power_supply-Register-cooling-device-outside-of-probe/20211213-191238 git checkout e5930a7ed9ae1b121e0dde177184ff74abbf0371 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=openrisc SHELL=/bin/bash drivers/power/supply/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All error/warnings (new ones prefixed by >>): 1086 | static int psy_register_cooler(struct power_supply *psy) | ^~~~~~~~~~~~~~~~~~~ drivers/power/supply/power_supply_core.c:129:12: note: previous declaration of 'psy_register_cooler' with type 'int(struct device *, struct power_supply *)' 129 | static int psy_register_cooler(struct device *dev, struct power_supply *psy); | ^~~~~~~~~~~~~~~~~~~ drivers/power/supply/power_supply_core.c:1086:12: warning: 'psy_register_cooler' defined but not used [-Wunused-function] 1086 | static int psy_register_cooler(struct power_supply *psy) | ^~~~~~~~~~~~~~~~~~~ vim +1086 drivers/power/supply/power_supply_core.c 952aeeb3ee28bc drivers/power/power_supply_core.c Ramakrishna Pallala 2012-10-09 1085 952aeeb3ee28bc drivers/power/power_supply_core.c Ramakrishna Pallala 2012-10-09 @1086 static int psy_register_cooler(struct power_supply *psy) 952aeeb3ee28bc drivers/power/power_supply_core.c Ramakrishna Pallala 2012-10-09 1087 { 952aeeb3ee28bc drivers/power/power_supply_core.c Ramakrishna Pallala 2012-10-09 1088 /* Register for cooling device if psy can control charging */ 9ba533eb99bb2a drivers/power/supply/power_supply_core.c Matthias Kaehlcke 2021-09-01 1089 if (psy_has_property(psy->desc, POWER_SUPPLY_PROP_CHARGE_CONTROL_LIMIT)) { 952aeeb3ee28bc drivers/power/power_supply_core.c Ramakrishna Pallala 2012-10-09 1090 psy->tcd = thermal_cooling_device_register( 297d716f6260cc drivers/power/power_supply_core.c Krzysztof Kozlowski 2015-03-12 1091 (char *)psy->desc->name, 952aeeb3ee28bc drivers/power/power_supply_core.c Ramakrishna Pallala 2012-10-09 1092 psy, &psy_tcd_ops); 9d2410c79b5b2d drivers/power/power_supply_core.c Viresh Kumar 2014-09-04 1093 return PTR_ERR_OR_ZERO(psy->tcd); 952aeeb3ee28bc drivers/power/power_supply_core.c Ramakrishna Pallala 2012-10-09 1094 } 9ba533eb99bb2a drivers/power/supply/power_supply_core.c Matthias Kaehlcke 2021-09-01 1095 952aeeb3ee28bc drivers/power/power_supply_core.c Ramakrishna Pallala 2012-10-09 1096 return 0; 952aeeb3ee28bc drivers/power/power_supply_core.c Ramakrishna Pallala 2012-10-09 1097 } 952aeeb3ee28bc drivers/power/power_supply_core.c Ramakrishna Pallala 2012-10-09 1098 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org