[kbuild-all] Re: [PATCH 2/2] iommu: Add gfp parameter to io_pgtable_ops->map()

Hi Baolin, I love your patch! Yet something to improve: [auto build test ERROR on iommu/next] [also build test ERROR on soc/for-next linus/master v5.7 next-20200605] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Baolin-Wang/Some-improvements-fo... base: https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next config: x86_64-allyesconfig (attached as .config) compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project e429cffd4f228f70c1d9df0e5d77c08590dd9766) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>, old ones prefixed by <<): IOMMU_CACHE)) ^ drivers/iommu/io-pgtable-arm-v7s.c:930:35: error: too few arguments to function call, expected 6, have 5 IOMMU_READ | IOMMU_NOEXEC)) ^ drivers/iommu/io-pgtable-arm-v7s.c:949:62: error: too few arguments to function call, expected 6, have 5 if (ops->map(ops, iova_start + size, size, size, IOMMU_READ)) ~~~~~~~~ ^ drivers/iommu/io-pgtable-arm-v7s.c:970:50: error: too few arguments to function call, expected 6, have 5 if (ops->map(ops, iova, iova, size, IOMMU_WRITE)) ~~~~~~~~ ^ 4 errors generated. -- IOMMU_CACHE)) ^ drivers/iommu/io-pgtable-arm.c:1186:36: error: too few arguments to function call, expected 6, have 5 IOMMU_READ | IOMMU_NOEXEC)) ^ drivers/iommu/io-pgtable-arm.c:1201:57: error: too few arguments to function call, expected 6, have 5 if (ops->map(ops, SZ_1G + size, size, size, IOMMU_READ)) ~~~~~~~~ ^ drivers/iommu/io-pgtable-arm.c:1219:51: error: too few arguments to function call, expected 6, have 5 if (ops->map(ops, iova, iova, size, IOMMU_WRITE)) ~~~~~~~~ ^ 4 errors generated. vim +925 drivers/iommu/io-pgtable-arm-v7s.c e5fc9753b1a831 Robin Murphy 2016-01-26 878 e5fc9753b1a831 Robin Murphy 2016-01-26 879 static int __init arm_v7s_do_selftests(void) e5fc9753b1a831 Robin Murphy 2016-01-26 880 { e5fc9753b1a831 Robin Murphy 2016-01-26 881 struct io_pgtable_ops *ops; e5fc9753b1a831 Robin Murphy 2016-01-26 882 struct io_pgtable_cfg cfg = { e5fc9753b1a831 Robin Murphy 2016-01-26 883 .tlb = &dummy_tlb_ops, e5fc9753b1a831 Robin Murphy 2016-01-26 884 .oas = 32, e5fc9753b1a831 Robin Murphy 2016-01-26 885 .ias = 32, 4f41845b340783 Will Deacon 2019-06-25 886 .coherent_walk = true, 4f41845b340783 Will Deacon 2019-06-25 887 .quirks = IO_PGTABLE_QUIRK_ARM_NS, e5fc9753b1a831 Robin Murphy 2016-01-26 888 .pgsize_bitmap = SZ_4K | SZ_64K | SZ_1M | SZ_16M, e5fc9753b1a831 Robin Murphy 2016-01-26 889 }; e5fc9753b1a831 Robin Murphy 2016-01-26 890 unsigned int iova, size, iova_start; e5fc9753b1a831 Robin Murphy 2016-01-26 891 unsigned int i, loopnr = 0; e5fc9753b1a831 Robin Murphy 2016-01-26 892 e5fc9753b1a831 Robin Murphy 2016-01-26 893 selftest_running = true; e5fc9753b1a831 Robin Murphy 2016-01-26 894 e5fc9753b1a831 Robin Murphy 2016-01-26 895 cfg_cookie = &cfg; e5fc9753b1a831 Robin Murphy 2016-01-26 896 e5fc9753b1a831 Robin Murphy 2016-01-26 897 ops = alloc_io_pgtable_ops(ARM_V7S, &cfg, &cfg); e5fc9753b1a831 Robin Murphy 2016-01-26 898 if (!ops) { e5fc9753b1a831 Robin Murphy 2016-01-26 899 pr_err("selftest: failed to allocate io pgtable ops\n"); e5fc9753b1a831 Robin Murphy 2016-01-26 900 return -EINVAL; e5fc9753b1a831 Robin Murphy 2016-01-26 901 } e5fc9753b1a831 Robin Murphy 2016-01-26 902 e5fc9753b1a831 Robin Murphy 2016-01-26 903 /* e5fc9753b1a831 Robin Murphy 2016-01-26 904 * Initial sanity checks. e5fc9753b1a831 Robin Murphy 2016-01-26 905 * Empty page tables shouldn't provide any translations. e5fc9753b1a831 Robin Murphy 2016-01-26 906 */ e5fc9753b1a831 Robin Murphy 2016-01-26 907 if (ops->iova_to_phys(ops, 42)) e5fc9753b1a831 Robin Murphy 2016-01-26 908 return __FAIL(ops); e5fc9753b1a831 Robin Murphy 2016-01-26 909 e5fc9753b1a831 Robin Murphy 2016-01-26 910 if (ops->iova_to_phys(ops, SZ_1G + 42)) e5fc9753b1a831 Robin Murphy 2016-01-26 911 return __FAIL(ops); e5fc9753b1a831 Robin Murphy 2016-01-26 912 e5fc9753b1a831 Robin Murphy 2016-01-26 913 if (ops->iova_to_phys(ops, SZ_2G + 42)) e5fc9753b1a831 Robin Murphy 2016-01-26 914 return __FAIL(ops); e5fc9753b1a831 Robin Murphy 2016-01-26 915 e5fc9753b1a831 Robin Murphy 2016-01-26 916 /* e5fc9753b1a831 Robin Murphy 2016-01-26 917 * Distinct mappings of different granule sizes. e5fc9753b1a831 Robin Murphy 2016-01-26 918 */ e5fc9753b1a831 Robin Murphy 2016-01-26 919 iova = 0; 4ae8a5c528c0b1 Kefeng Wang 2016-09-21 920 for_each_set_bit(i, &cfg.pgsize_bitmap, BITS_PER_LONG) { e5fc9753b1a831 Robin Murphy 2016-01-26 921 size = 1UL << i; e5fc9753b1a831 Robin Murphy 2016-01-26 922 if (ops->map(ops, iova, iova, size, IOMMU_READ | e5fc9753b1a831 Robin Murphy 2016-01-26 923 IOMMU_WRITE | e5fc9753b1a831 Robin Murphy 2016-01-26 924 IOMMU_NOEXEC | e5fc9753b1a831 Robin Murphy 2016-01-26 @925 IOMMU_CACHE)) :::::: The code at line 925 was first introduced by commit :::::: e5fc9753b1a831466be9b45d0bf926eeaa8b84a0 iommu/io-pgtable: Add ARMv7 short descriptor support :::::: TO: Robin Murphy <robin.murphy(a)arm.com&gt; :::::: CC: Will Deacon <will.deacon(a)arm.com&gt; --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org