Hi Will,
I love your patch! Perhaps something to improve:
[auto build test WARNING on arm/for-next]
[also build test WARNING on soc/for-next xlnx/master kvmarm/next]
[cannot apply to arm64/for-next/core v5.10-rc4 next-20201119]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Will-Deacon/arm64-Fix-issues-wit...
base: git://git.armlinux.org.uk/~rmk/linux-arm.git for-next
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/b994fd4f2e7cee6f64d38036bd76c6c96...
git remote add linux-review
https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Will-Deacon/arm64-Fix-issues-with-CPU-hotplug-and-RCU/20201109-092901
git checkout b994fd4f2e7cee6f64d38036bd76c6c9644cd2b1
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
arch/arm64/kernel/psci.c: In function 'cpu_psci_cpu_die':
> arch/arm64/kernel/psci.c:69:6: warning: variable 'ret'
set but not used [-Wunused-but-set-variable]
69 | int ret;
| ^~~
vim +/ret +69 arch/arm64/kernel/psci.c
831ccf79b46e02f Mark Rutland 2013-10-24 66
831ccf79b46e02f Mark Rutland 2013-10-24 67 static void cpu_psci_cpu_die(unsigned int
cpu)
831ccf79b46e02f Mark Rutland 2013-10-24 68 {
831ccf79b46e02f Mark Rutland 2013-10-24 @69 int ret;
831ccf79b46e02f Mark Rutland 2013-10-24 70 /*
831ccf79b46e02f Mark Rutland 2013-10-24 71 * There are no known implementations of
PSCI actually using the
831ccf79b46e02f Mark Rutland 2013-10-24 72 * power state field, pass a sensible
default for now.
831ccf79b46e02f Mark Rutland 2013-10-24 73 */
c8cc42737788537 Mark Rutland 2015-04-30 74 u32 state =
PSCI_POWER_STATE_TYPE_POWER_DOWN <<
c8cc42737788537 Mark Rutland 2015-04-30 75 PSCI_0_2_POWER_STATE_TYPE_SHIFT;
831ccf79b46e02f Mark Rutland 2013-10-24 76
831ccf79b46e02f Mark Rutland 2013-10-24 77 ret = psci_ops.cpu_off(state);
831ccf79b46e02f Mark Rutland 2013-10-24 78 }
c814ca029e1015b Ashwin Chaugule 2014-05-07 79
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org