11:57 a.m.
Hi Nobuhiro,
I love your patch! Yet something to improve:
[auto build test ERROR on pwm/for-next]
[also build test ERROR on robh/for-next v5.12-rc6 next-20210409]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Nobuhiro-Iwamatsu/pwm-visconti-A...
base: https://git.kernel.org/pub/scm/linux/kernel/git/thierry.reding/linux-pwm.git
for-next
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/f3151d1bb4deddd41bc536277a89f38b7...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Nobuhiro-Iwamatsu/pwm-visconti-Add-Toshiba-Visconti-SoC-PWM-support/20210410-070957
git checkout f3151d1bb4deddd41bc536277a89f38b712ac23b
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All error/warnings (new ones prefixed by >>):
drivers/pwm/pwm-visconti.c: In function 'visconti_pwm_get_state':
> drivers/pwm/pwm-visconti.c:109:35: error: implicit declaration of
function 'chip_to_priv' [-Werror=implicit-function-declaration]
109 |
struct visconti_pwm_chip *priv = chip_to_priv(chip);
| ^~~~~~~~~~~~
> drivers/pwm/pwm-visconti.c:109:35: warning: initialization of
'struct visconti_pwm_chip *' from 'int' makes pointer from integer without
a cast [-Wint-conversion]
cc1: some warnings being treated as errors
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_PDC
Depends on SOUND && !UML && SND && SND_SOC &&
SND_ATMEL_SOC && HAS_DMA
Selected by
- SND_ATMEL_SOC_SSC && SOUND && !UML && SND && SND_SOC
&& SND_ATMEL_SOC
- SND_ATMEL_SOC_SSC_PDC && SOUND && !UML && SND &&
SND_SOC && SND_ATMEL_SOC && ATMEL_SSC
vim +/chip_to_priv +109 drivers/pwm/pwm-visconti.c
105
106 static void visconti_pwm_get_state(struct pwm_chip *chip, struct pwm_device *pwm,
107 struct pwm_state *state)
108 {
109 struct visconti_pwm_chip *priv = chip_to_priv(chip);
110 u32 period, duty, pwmc0, pwmc0_clk;
111
112 period = readl(priv->base + PIPGM_PCSR(pwm->hwpwm));
113 if (period)
114 state->enabled = true;
115 else
116 state->enabled = false;
117
118 duty = readl(priv->base + PIPGM_PDUT(pwm->hwpwm));
119 pwmc0 = readl(priv->base + PIPGM_PWMC(pwm->hwpwm));
120 pwmc0_clk = pwmc0 & PIPGM_PWMC_CLK_MASK;
121
122 state->period = (period << pwmc0_clk) * NSEC_PER_USEC;
123 state->duty_cycle = (duty << pwmc0_clk) * NSEC_PER_USEC;
124 if (pwmc0 & PIPGM_PWMC_POLARITY_MASK)
125 state->polarity = PWM_POLARITY_INVERSED;
126 else
127 state->polarity = PWM_POLARITY_NORMAL;
128 }
129
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org