1:29 p.m.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git queue-4.4
head: aa64860149a00881a02b1c29d7d5a98191618d2e
commit: 3ec0d8625ae5864e719fda33311358d0366efa94 [5/7] xcopy: loop over devices using idr
helper
config: nios2-allyesconfig (attached as .config)
compiler: nios2-linux-gcc (GCC) 7.5.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git/c...
git remote add sashal-linux-stable
https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git
git fetch --no-tags sashal-linux-stable queue-4.4
git checkout 3ec0d8625ae5864e719fda33311358d0366efa94
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-7.5.0 make.cross ARCH=nios2
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Note: the sashal-linux-stable/queue-4.4 HEAD aa64860149a00881a02b1c29d7d5a98191618d2e
builds fine.
It only hurts bisectibility.
All errors (new ones prefixed by >>):
from include/linux/filter.h:16,
from include/net/sock.h:62,
from include/target/target_core_base.h:10,
from drivers/target/target_core_xcopy.c:31:
include/net/rtnetlink.h: In function 'rtnl_msg_family':
include/net/rtnetlink.h:20:21: warning: comparison between signed and unsigned integer
expressions [-Wsign-compare]
if (nlmsg_len(nlh) >= sizeof(struct rtgenmsg))
^~
In file included from include/asm-generic/bug.h:4:0,
from arch/nios2/include/generated/asm/bug.h:1,
from include/linux/bug.h:4,
from include/linux/mmdebug.h:4,
from include/linux/gfp.h:4,
from include/linux/slab.h:14,
from drivers/target/target_core_xcopy.c:24:
include/net/sch_generic.h: In function 'qdisc_cb_private_validate':
include/net/sch_generic.h:267:33: warning: comparison between signed and unsigned
integer expressions [-Wsign-compare]
BUILD_BUG_ON(sizeof(qcb->data) < sz);
^
include/linux/compiler.h:491:19: note: in definition of macro
'__compiletime_assert'
bool __cond = !(condition); \
^~~~~~~~~
include/linux/compiler.h:511:2: note: in expansion of macro
'_compiletime_assert'
_compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
^~~~~~~~~~~~~~~~~~~
include/linux/bug.h:50:37: note: in expansion of macro 'compiletime_assert'
#define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
^~~~~~~~~~~~~~~~~~
include/linux/bug.h:74:2: note: in expansion of macro 'BUILD_BUG_ON_MSG'
BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition)
^~~~~~~~~~~~~~~~
include/net/sch_generic.h:267:2: note: in expansion of macro 'BUILD_BUG_ON'
BUILD_BUG_ON(sizeof(qcb->data) < sz);
^~~~~~~~~~~~
In file included from include/net/sock.h:62:0,
from include/target/target_core_base.h:10,
from drivers/target/target_core_xcopy.c:31:
include/linux/filter.h: In function 'bpf_needs_clear_a':
include/linux/filter.h:517:16: warning: comparison between signed and unsigned integer
expressions [-Wsign-compare]
if (first->k == SKF_AD_OFF + SKF_AD_ALU_XOR_X)
^~
In file included from include/target/target_core_base.h:10:0,
from drivers/target/target_core_xcopy.c:31:
include/net/sock.h: In function 'skb_do_copy_data_nocache':
include/net/sock.h:1838:54: warning: comparison between signed and unsigned integer
expressions [-Wsign-compare]
if (csum_and_copy_from_iter(to, copy, &csum, from) != copy)
^~
include/net/sock.h:1842:46: warning: comparison between signed and unsigned integer
expressions [-Wsign-compare]
if (copy_from_iter_nocache(to, copy, from) != copy)
^~
include/net/sock.h:1844:44: warning: comparison between signed and unsigned integer
expressions [-Wsign-compare]
} else if (copy_from_iter(to, copy, from) != copy)
^~
In file included from include/linux/tcp.h:23:0,
from include/net/tcp.h:24,
from include/target/target_core_base.h:11,
from drivers/target/target_core_xcopy.c:31:
include/net/inet_connection_sock.h: In function
'inet_csk_reqsk_queue_is_full':
include/net/inet_connection_sock.h:294:38: warning: comparison between signed and
unsigned integer expressions [-Wsign-compare]
return inet_csk_reqsk_queue_len(sk) >= sk->sk_max_ack_backlog;
^~
In file included from include/target/target_core_base.h:11:0,
from drivers/target/target_core_xcopy.c:31:
include/net/tcp.h: In function 'tcp_out_of_memory':
include/net/tcp.h:321:25: warning: comparison between signed and unsigned integer
expressions [-Wsign-compare]
if (sk->sk_wmem_queued > SOCK_MIN_SNDBUF &&
^
include/net/tcp.h: In function 'tcp_slow_start_after_idle_check':
include/net/tcp.h:1201:12: warning: comparison between signed and unsigned integer
expressions [-Wsign-compare]
if (delta > inet_csk(sk)->icsk_rto)
^
include/net/tcp.h: In function 'keepalive_intvl_when':
include/net/tcp.h:1239:31: warning: signed and unsigned type in conditional expression
[-Wsign-compare]
return tp->keepalive_intvl ? : sysctl_tcp_keepalive_intvl;
^
include/net/tcp.h: In function 'keepalive_time_when':
include/net/tcp.h:1244:30: warning: signed and unsigned type in conditional expression
[-Wsign-compare]
return tp->keepalive_time ? : sysctl_tcp_keepalive_time;
^
In file included from include/asm-generic/bug.h:4:0,
from arch/nios2/include/generated/asm/bug.h:1,
from include/linux/bug.h:4,
from include/linux/mmdebug.h:4,
from include/linux/gfp.h:4,
from include/linux/slab.h:14,
from drivers/target/target_core_xcopy.c:24:
include/net/tcp.h: In function 'tcp_paws_check':
include/net/tcp.h:1276:29: warning: comparison between signed and unsigned integer
expressions [-Wsign-compare]
if (unlikely(get_seconds() >= rx_opt->ts_recent_stamp + TCP_PAWS_24DAYS))
^
include/linux/compiler.h:182:42: note: in definition of macro 'unlikely'
# define unlikely(x) __builtin_expect(!!(x), 0)
^
In file included from include/target/target_core_base.h:11:0,
from drivers/target/target_core_xcopy.c:31:
include/net/tcp.h: In function 'tcp_paws_reject':
include/net/tcp.h:1306:27: warning: comparison between signed and unsigned integer
expressions [-Wsign-compare]
if (rst && get_seconds() >= rx_opt->ts_recent_stamp + TCP_PAWS_MSL)
^~
drivers/target/target_core_xcopy.c: In function
'target_xcopy_locate_se_dev_e4':
> drivers/target/target_core_xcopy.c:101:8: error: implicit
declaration of function 'target_for_each_device'; did you mean
'target_free_device'? [-Werror=implicit-function-declaration]
ret =
target_for_each_device(target_xcopy_locate_se_dev_e4_iter, &info);
^~~~~~~~~~~~~~~~~~~~~~
target_free_device
cc1: some warnings being treated as errors
vim +101 drivers/target/target_core_xcopy.c
30
31 #include <target/target_core_base.h>
32 #include
<target/target_core_backend.h>
33 #include <target/target_core_fabric.h>
34
35 #include "target_core_internal.h"
36 #include "target_core_pr.h"
37 #include "target_core_ua.h"
38 #include "target_core_xcopy.h"
39
40 static struct workqueue_struct *xcopy_wq = NULL;
41
42 static int target_xcopy_gen_naa_ieee(struct se_device *dev, unsigned char *buf)
43 {
44 int off = 0;
45
46 buf[off++] = (0x6 << 4);
47 buf[off++] = 0x01;
48 buf[off++] = 0x40;
49 buf[off] = (0x5 << 4);
50
51 spc_parse_naa_6h_vendor_specific(dev, &buf[off]);
52 return 0;
53 }
54
55 struct xcopy_dev_search_info {
56 const unsigned char *dev_wwn;
57 struct se_device *found_dev;
58 };
59
60 static int target_xcopy_locate_se_dev_e4_iter(struct se_device *se_dev,
61 void *data)
62 {
63 struct xcopy_dev_search_info *info = data;
64 unsigned char tmp_dev_wwn[XCOPY_NAA_IEEE_REGEX_LEN];
65 int rc;
66
67 if (!se_dev->dev_attrib.emulate_3pc)
68 return 0;
69
70 memset(&tmp_dev_wwn[0], 0, XCOPY_NAA_IEEE_REGEX_LEN);
71 target_xcopy_gen_naa_ieee(se_dev, &tmp_dev_wwn[0]);
72
73 rc = memcmp(&tmp_dev_wwn[0], info->dev_wwn, XCOPY_NAA_IEEE_REGEX_LEN);
74 if (rc != 0)
75 return 0;
76
77 info->found_dev = se_dev;
78 pr_debug("XCOPY 0xe4: located se_dev: %p\n", se_dev);
79
80 rc = target_depend_item(&se_dev->dev_group.cg_item);
81 if (rc != 0) {
82 pr_err("configfs_depend_item attempt failed: %d for se_dev: %p\n",
83 rc, se_dev);
84 return rc;
85 }
86
87 pr_debug("Called configfs_depend_item for se_dev: %p se_dev->se_dev_group:
%p\n",
88 se_dev, &se_dev->dev_group);
89 return 1;
90 }
91
92 static int target_xcopy_locate_se_dev_e4(const unsigned char *dev_wwn,
93 struct se_device **found_dev)
94 {
95 struct xcopy_dev_search_info info;
96 int ret;
97
98 memset(&info, 0, sizeof(info));
99 info.dev_wwn = dev_wwn;
100
101 ret = target_for_each_device(target_xcopy_locate_se_dev_e4_iter,
&info);
102 if (ret == 1) {
103 *found_dev = info.found_dev;
104 return 0;
105 } else {
106 pr_debug_ratelimited("Unable to locate 0xe4 descriptor for
EXTENDED_COPY\n");
107 return -EINVAL;
108 }
109 }
110
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org