[kbuild-all] Re: [RFC PATCH v4 4/8] leds: trigger: netdev: rename and expose NETDEV trigger enum and struct

Hi Ansuel, [FYI, it's a private test report for your RFC patch.] [auto build test WARNING on net/master] [also build test WARNING on linus/master next-20211111] [cannot apply to pavel-leds/for-next robh/for-next net-next/master v5.15] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Ansuel-Smith/Adds-support-for-PH... base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git e5d5aadcf3cd59949316df49c27cb21788d7efe4 config: microblaze-buildonly-randconfig-r001-20211111 (attached as .config) compiler: microblaze-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/e8e8713b4128f4d9108d4326c95e2adc9... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Ansuel-Smith/Adds-support-for-PHY-LEDs-with-offload-triggers/20211111-093724 git checkout e8e8713b4128f4d9108d4326c95e2adc9b302971 # save the attached .config to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=microblaze SHELL=/bin/bash drivers/i2c/ drivers/leds/trigger/ kernel/bpf/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All warnings (new ones prefixed by >>): 45 | static void set_baseline_state(struct led_netdev_data *trigger_data) | ^~~~~~~~~~~~~~~ drivers/leds/trigger/ledtrig-netdev.c: In function 'set_baseline_state': drivers/leds/trigger/ledtrig-netdev.c:48:53: error: invalid use of undefined type 'struct led_netdev_data' 48 | struct led_classdev *led_cdev = trigger_data->led_cdev; | ^~ drivers/leds/trigger/ledtrig-netdev.c:56:26: error: invalid use of undefined type 'struct led_netdev_data' 56 | if (!trigger_data->carrier_link_up) { | ^~ drivers/leds/trigger/ledtrig-netdev.c:59:30: error: 'TRIGGER_NETDEV_LINK' undeclared (first use in this function) 59 | if (test_bit(TRIGGER_NETDEV_LINK, &trigger_data->mode)) | ^~~~~~~~~~~~~~~~~~~ drivers/leds/trigger/ledtrig-netdev.c:59:30: note: each undeclared identifier is reported only once for each function it appears in drivers/leds/trigger/ledtrig-netdev.c:59:64: error: invalid use of undefined type 'struct led_netdev_data' 59 | if (test_bit(TRIGGER_NETDEV_LINK, &trigger_data->mode)) | ^~ drivers/leds/trigger/ledtrig-netdev.c:68:30: error: 'TRIGGER_NETDEV_TX' undeclared (first use in this function) 68 | if (test_bit(TRIGGER_NETDEV_TX, &trigger_data->mode) || | ^~~~~~~~~~~~~~~~~ drivers/leds/trigger/ledtrig-netdev.c:68:62: error: invalid use of undefined type 'struct led_netdev_data' 68 | if (test_bit(TRIGGER_NETDEV_TX, &trigger_data->mode) || | ^~ drivers/leds/trigger/ledtrig-netdev.c:69:30: error: 'TRIGGER_NETDEV_RX' undeclared (first use in this function) 69 | test_bit(TRIGGER_NETDEV_RX, &trigger_data->mode)) | ^~~~~~~~~~~~~~~~~ drivers/leds/trigger/ledtrig-netdev.c:69:62: error: invalid use of undefined type 'struct led_netdev_data' 69 | test_bit(TRIGGER_NETDEV_RX, &trigger_data->mode)) | ^~ drivers/leds/trigger/ledtrig-netdev.c:70:60: error: invalid use of undefined type 'struct led_netdev_data' 70 | schedule_delayed_work(&trigger_data->work, 0); | ^~ drivers/leds/trigger/ledtrig-netdev.c: In function 'device_name_show': drivers/leds/trigger/ledtrig-netdev.c:80:35: error: invalid use of undefined type 'struct led_netdev_data' 80 | spin_lock_bh(&trigger_data->lock); | ^~ drivers/leds/trigger/ledtrig-netdev.c:81:48: error: invalid use of undefined type 'struct led_netdev_data' 81 | len = sprintf(buf, "%s\n", trigger_data->device_name); | ^~ drivers/leds/trigger/ledtrig-netdev.c:82:37: error: invalid use of undefined type 'struct led_netdev_data' 82 | spin_unlock_bh(&trigger_data->lock); | ^~ drivers/leds/trigger/ledtrig-netdev.c: In function 'device_name_store': drivers/leds/trigger/ledtrig-netdev.c:96:47: error: invalid use of undefined type 'struct led_netdev_data' 96 | cancel_delayed_work_sync(&trigger_data->work); | ^~ drivers/leds/trigger/ledtrig-netdev.c:98:35: error: invalid use of undefined type 'struct led_netdev_data' 98 | spin_lock_bh(&trigger_data->lock); | ^~ drivers/leds/trigger/ledtrig-netdev.c:100:25: error: invalid use of undefined type 'struct led_netdev_data' 100 | if (trigger_data->net_dev) { | ^~ drivers/leds/trigger/ledtrig-netdev.c:101:37: error: invalid use of undefined type 'struct led_netdev_data' 101 | dev_put(trigger_data->net_dev); | ^~ drivers/leds/trigger/ledtrig-netdev.c:102:29: error: invalid use of undefined type 'struct led_netdev_data' 102 | trigger_data->net_dev = NULL; | ^~ drivers/leds/trigger/ledtrig-netdev.c:105:28: error: invalid use of undefined type 'struct led_netdev_data' 105 | memcpy(trigger_data->device_name, buf, size); | ^~ drivers/leds/trigger/ledtrig-netdev.c:106:21: error: invalid use of undefined type 'struct led_netdev_data' 106 | trigger_data->device_name[size] = 0; | ^~ drivers/leds/trigger/ledtrig-netdev.c:107:37: error: invalid use of undefined type 'struct led_netdev_data' 107 | if (size > 0 && trigger_data->device_name[size - 1] == '\n') | ^~ drivers/leds/trigger/ledtrig-netdev.c:108:29: error: invalid use of undefined type 'struct led_netdev_data' 108 | trigger_data->device_name[size - 1] = 0; | ^~ drivers/leds/trigger/ledtrig-netdev.c:110:25: error: invalid use of undefined type 'struct led_netdev_data' 110 | if (trigger_data->device_name[0] != 0) | ^~ drivers/leds/trigger/ledtrig-netdev.c:111:29: error: invalid use of undefined type 'struct led_netdev_data' 111 | trigger_data->net_dev = | ^~ drivers/leds/trigger/ledtrig-netdev.c:112:60: error: invalid use of undefined type 'struct led_netdev_data' 112 | dev_get_by_name(&init_net, trigger_data->device_name); | ^~ drivers/leds/trigger/ledtrig-netdev.c:114:21: error: invalid use of undefined type 'struct led_netdev_data' 114 | trigger_data->carrier_link_up = false; | ^~ drivers/leds/trigger/ledtrig-netdev.c:115:25: error: invalid use of undefined type 'struct led_netdev_data' 115 | if (trigger_data->net_dev != NULL) | ^~ drivers/leds/trigger/ledtrig-netdev.c:116:29: error: invalid use of undefined type 'struct led_netdev_data' 116 | trigger_data->carrier_link_up = netif_carrier_ok(trigger_data->net_dev); | ^~ drivers/leds/trigger/ledtrig-netdev.c:116:78: error: invalid use of undefined type 'struct led_netdev_data' 116 | trigger_data->carrier_link_up = netif_carrier_ok(trigger_data->net_dev); | ^~ drivers/leds/trigger/ledtrig-netdev.c:118:21: error: invalid use of undefined type 'struct led_netdev_data' 118 | trigger_data->last_activity = 0; | ^~ drivers/leds/trigger/ledtrig-netdev.c:120:28: error: passing argument 1 of 'set_baseline_state' from incompatible pointer type [-Werror=incompatible-pointer-types] 120 | set_baseline_state(trigger_data); | ^~~~~~~~~~~~ | | | struct led_netdev_data * drivers/leds/trigger/ledtrig-netdev.c:45:56: note: expected 'struct led_netdev_data *' but argument is of type 'struct led_netdev_data *' 45 | static void set_baseline_state(struct led_netdev_data *trigger_data) vim +45 drivers/leds/trigger/ledtrig-netdev.c 06f502f57d0d77 Ben Whitten 2017-12-10 44 06f502f57d0d77 Ben Whitten 2017-12-10 @45 static void set_baseline_state(struct led_netdev_data *trigger_data) 06f502f57d0d77 Ben Whitten 2017-12-10 46 { 06f502f57d0d77 Ben Whitten 2017-12-10 47 int current_brightness; 06f502f57d0d77 Ben Whitten 2017-12-10 48 struct led_classdev *led_cdev = trigger_data->led_cdev; 06f502f57d0d77 Ben Whitten 2017-12-10 49 06f502f57d0d77 Ben Whitten 2017-12-10 50 current_brightness = led_cdev->brightness; 06f502f57d0d77 Ben Whitten 2017-12-10 51 if (current_brightness) 06f502f57d0d77 Ben Whitten 2017-12-10 52 led_cdev->blink_brightness = current_brightness; 06f502f57d0d77 Ben Whitten 2017-12-10 53 if (!led_cdev->blink_brightness) 06f502f57d0d77 Ben Whitten 2017-12-10 54 led_cdev->blink_brightness = led_cdev->max_brightness; 06f502f57d0d77 Ben Whitten 2017-12-10 55 a889cd6231ea62 Ansuel Smith 2021-11-11 56 if (!trigger_data->carrier_link_up) { 06f502f57d0d77 Ben Whitten 2017-12-10 57 led_set_brightness(led_cdev, LED_OFF); a889cd6231ea62 Ansuel Smith 2021-11-11 58 } else { e8e8713b4128f4 Ansuel Smith 2021-11-11 59 if (test_bit(TRIGGER_NETDEV_LINK, &trigger_data->mode)) 06f502f57d0d77 Ben Whitten 2017-12-10 60 led_set_brightness(led_cdev, 06f502f57d0d77 Ben Whitten 2017-12-10 61 led_cdev->blink_brightness); 06f502f57d0d77 Ben Whitten 2017-12-10 62 else 06f502f57d0d77 Ben Whitten 2017-12-10 63 led_set_brightness(led_cdev, LED_OFF); 06f502f57d0d77 Ben Whitten 2017-12-10 64 06f502f57d0d77 Ben Whitten 2017-12-10 65 /* If we are looking for RX/TX start periodically 06f502f57d0d77 Ben Whitten 2017-12-10 66 * checking stats 06f502f57d0d77 Ben Whitten 2017-12-10 67 */ e8e8713b4128f4 Ansuel Smith 2021-11-11 68 if (test_bit(TRIGGER_NETDEV_TX, &trigger_data->mode) || e8e8713b4128f4 Ansuel Smith 2021-11-11 69 test_bit(TRIGGER_NETDEV_RX, &trigger_data->mode)) 06f502f57d0d77 Ben Whitten 2017-12-10 70 schedule_delayed_work(&trigger_data->work, 0); 06f502f57d0d77 Ben Whitten 2017-12-10 71 } 06f502f57d0d77 Ben Whitten 2017-12-10 72 } 06f502f57d0d77 Ben Whitten 2017-12-10 73 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org