1:20 a.m.
Hi Alain,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on bluetooth-next/master]
[also build test ERROR on next-20200611]
[cannot apply to v5.7]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Alain-Michaud/sco-Add-support-fo...
base: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git
master
config: x86_64-randconfig-s022-20200611 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-250-g42323db3-dirty
# save the attached .config to linux build tree
make W=1 C=1 ARCH=x86_64 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
net/bluetooth/sco.c: In function 'sco_skb_put_cmsg':
> net/bluetooth/sco.c:456:36: error: passing argument 2 of
'test_bit' from incompatible pointer type [-Werror=incompatible-pointer-types]
456 | if (test_bit(SCO_CMSG_PKT_STATUS, &sco_pi(sk)->cmsg_mask))
| ^~~~~~~~~~~~~~~~~~~~~~
| |
| __u8 * {aka unsigned char *}
In file included from arch/x86/include/asm/bitops.h:392,
from include/linux/bitops.h:29,
from include/linux/kernel.h:12,
from include/linux/list.h:9,
from include/linux/module.h:12,
from net/bluetooth/sco.c:27:
include/asm-generic/bitops/instrumented-non-atomic.h:108:68: note: expected 'const
volatile long unsigned int *' but argument is of type '__u8 *' {aka
'unsigned char *'}
108 | static inline bool test_bit(long nr, const volatile unsigned long *addr)
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
net/bluetooth/sco.c: In function 'sco_sock_setsockopt':
> net/bluetooth/sco.c:868:33: error: passing argument 2 of
'set_bit' from incompatible pointer type [-Werror=incompatible-pointer-types]
868 | set_bit(SCO_CMSG_PKT_STATUS, &sco_pi(sk)->cmsg_mask);
| ^~~~~~~~~~~~~~~~~~~~~~
| |
| __u8 * {aka unsigned char *}
In file included from arch/x86/include/asm/bitops.h:391,
from include/linux/bitops.h:29,
from include/linux/kernel.h:12,
from include/linux/list.h:9,
from include/linux/module.h:12,
from net/bluetooth/sco.c:27:
include/asm-generic/bitops/instrumented-atomic.h:26:61: note: expected 'volatile long
unsigned int *' but argument is of type '__u8 *' {aka 'unsigned char
*'}
26 | static inline void set_bit(long nr, volatile unsigned long *addr)
| ~~~~~~~~~~~~~~~~~~~~~~~~^~~~
> net/bluetooth/sco.c:870:35: error: passing argument 2 of
'clear_bit' from incompatible pointer type [-Werror=incompatible-pointer-types]
870 | clear_bit(SCO_CMSG_PKT_STATUS, &sco_pi(sk)->cmsg_mask);
| ^~~~~~~~~~~~~~~~~~~~~~
| |
| __u8 * {aka unsigned char *}
In file included from arch/x86/include/asm/bitops.h:391,
from include/linux/bitops.h:29,
from include/linux/kernel.h:12,
from include/linux/list.h:9,
from include/linux/module.h:12,
from net/bluetooth/sco.c:27:
include/asm-generic/bitops/instrumented-atomic.h:39:63: note: expected 'volatile long
unsigned int *' but argument is of type '__u8 *' {aka 'unsigned char
*'}
39 | static inline void clear_bit(long nr, volatile unsigned long *addr)
| ~~~~~~~~~~~~~~~~~~~~~~~~^~~~
net/bluetooth/sco.c: In function 'sco_sock_getsockopt':
net/bluetooth/sco.c:999:11: error: passing argument 2 of 'test_bit' from
incompatible pointer type [-Werror=incompatible-pointer-types]
999 | &(sco_pi(sk)->cmsg_mask));
| ^~~~~~~~~~~~~~~~~~~~~~~~
| |
| __u8 * {aka unsigned char *}
In file included from arch/x86/include/asm/bitops.h:392,
from include/linux/bitops.h:29,
from include/linux/kernel.h:12,
from include/linux/list.h:9,
from include/linux/module.h:12,
from net/bluetooth/sco.c:27:
include/asm-generic/bitops/instrumented-non-atomic.h:108:68: note: expected 'const
volatile long unsigned int *' but argument is of type '__u8 *' {aka
'unsigned char *'}
108 | static inline bool test_bit(long nr, const volatile unsigned long *addr)
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
cc1: some warnings being treated as errors
sparse warnings: (new ones prefixed by >>)
> net/bluetooth/sco.c:456:44: sparse: sparse: incorrect type in
argument 2 (different type sizes) @@ expected unsigned long const volatile *addr @@
got unsigned char * @@
> net/bluetooth/sco.c:456:44: sparse: expected unsigned long const volatile *addr
> net/bluetooth/sco.c:456:44: sparse: got unsigned char *
> net/bluetooth/sco.c:868:55: sparse: sparse: incorrect type in argument 2 (different
type sizes) @@ expected unsigned long volatile *addr @@ got unsigned char * @@
> net/bluetooth/sco.c:868:55: sparse: expected unsigned long volatile *addr
net/bluetooth/sco.c:868:55: sparse: got unsigned char *
net/bluetooth/sco.c:870:57: sparse: sparse: incorrect type in argument 2 (different
type sizes) @@ expected unsigned long volatile *addr @@ got unsigned char * @@
net/bluetooth/sco.c:870:57: sparse: expected unsigned long volatile *addr
net/bluetooth/sco.c:870:57: sparse: got unsigned char *
net/bluetooth/sco.c:999:41: sparse: sparse: incorrect type in argument 2 (different
type sizes) @@ expected unsigned long const volatile *addr @@ got unsigned char *
@@
net/bluetooth/sco.c:999:41: sparse: expected unsigned long const volatile *addr
net/bluetooth/sco.c:999:41: sparse: got unsigned char *
vim +/test_bit +456 net/bluetooth/sco.c
452
453 static void sco_skb_put_cmsg(struct sk_buff *skb, struct msghdr *msg,
454 struct sock *sk)
455 {
456 if (test_bit(SCO_CMSG_PKT_STATUS,
&sco_pi(sk)->cmsg_mask))
457 put_cmsg(msg, SOL_BLUETOOTH,
BT_SCM_PKT_STATUS,
458 sizeof(bt_cb(skb)->sco.pkt_status),
459 &bt_cb(skb)->sco.pkt_status);
460 }
461
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org