[kbuild-all] Re: [PATCH v2 2/2] clk: qcom: Add clock driver for SM8450

Hi Vinod, I love your patch! Yet something to improve: [auto build test ERROR on clk/clk-next] [also build test ERROR on robh/for-next v5.16-rc4 next-20211208] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Vinod-Koul/clk-qcom-Add-clocks-f... base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next config: riscv-randconfig-c006-20211208 (https://download.01.org/0day-ci/archive/20211208/202112082235.Hpn8OyQQ-lk...) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 097a1cb1d5ebb3a0ec4bcaed8ba3ff6a8e33c00a) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install riscv cross compiling tool for clang build # apt-get install binutils-riscv64-linux-gnu # https://github.com/0day-ci/linux/commit/42c0d6d58aceb3d76e99fd9738235962a... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Vinod-Koul/clk-qcom-Add-clocks-for-SM8450-SoC/20211207-194218 git checkout 42c0d6d58aceb3d76e99fd9738235962ab7a8e87 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash drivers/clk/qcom/ drivers/iio/proximity/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>): .regs = clk_alpha_pll_regs[CLK_ALPHA_PLL_TYPE_LUCID_EVO], ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ CLK_ALPHA_PLL_TYPE_LUCID drivers/clk/qcom/clk-alpha-pll.h:17:2: note: 'CLK_ALPHA_PLL_TYPE_LUCID' declared here CLK_ALPHA_PLL_TYPE_LUCID = CLK_ALPHA_PLL_TYPE_TRION, ^ .ops = &clk_alpha_pll_fixed_lucid_evo_ops, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ clk_alpha_pll_fixed_lucid_5lpe_ops drivers/clk/qcom/clk-alpha-pll.h:149:29: note: 'clk_alpha_pll_fixed_lucid_5lpe_ops' declared here extern const struct clk_ops clk_alpha_pll_fixed_lucid_5lpe_ops; ^ drivers/clk/qcom/gcc-sm8450.c:66:29: error: use of undeclared identifier 'CLK_ALPHA_PLL_TYPE_LUCID_EVO'; did you mean 'CLK_ALPHA_PLL_TYPE_LUCID'? .regs = clk_alpha_pll_regs[CLK_ALPHA_PLL_TYPE_LUCID_EVO], ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ CLK_ALPHA_PLL_TYPE_LUCID drivers/clk/qcom/clk-alpha-pll.h:17:2: note: 'CLK_ALPHA_PLL_TYPE_LUCID' declared here CLK_ALPHA_PLL_TYPE_LUCID = CLK_ALPHA_PLL_TYPE_TRION, ^ .ops = &clk_alpha_pll_postdiv_lucid_evo_ops, ^ drivers/clk/qcom/gcc-sm8450.c:79:29: error: use of undeclared identifier 'CLK_ALPHA_PLL_TYPE_LUCID_EVO'; did you mean 'CLK_ALPHA_PLL_TYPE_LUCID'? .regs = clk_alpha_pll_regs[CLK_ALPHA_PLL_TYPE_LUCID_EVO], ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ CLK_ALPHA_PLL_TYPE_LUCID drivers/clk/qcom/clk-alpha-pll.h:17:2: note: 'CLK_ALPHA_PLL_TYPE_LUCID' declared here CLK_ALPHA_PLL_TYPE_LUCID = CLK_ALPHA_PLL_TYPE_TRION, ^ drivers/clk/qcom/gcc-sm8450.c:89:12: error: use of undeclared identifier 'clk_alpha_pll_fixed_lucid_evo_ops'; did you mean 'clk_alpha_pll_fixed_lucid_5lpe_ops'? .ops = &clk_alpha_pll_fixed_lucid_evo_ops, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ clk_alpha_pll_fixed_lucid_5lpe_ops drivers/clk/qcom/clk-alpha-pll.h:149:29: note: 'clk_alpha_pll_fixed_lucid_5lpe_ops' declared here extern const struct clk_ops clk_alpha_pll_fixed_lucid_5lpe_ops; ^ drivers/clk/qcom/gcc-sm8450.c:96:29: error: use of undeclared identifier 'CLK_ALPHA_PLL_TYPE_LUCID_EVO'; did you mean 'CLK_ALPHA_PLL_TYPE_LUCID'? .regs = clk_alpha_pll_regs[CLK_ALPHA_PLL_TYPE_LUCID_EVO], ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ CLK_ALPHA_PLL_TYPE_LUCID drivers/clk/qcom/clk-alpha-pll.h:17:2: note: 'CLK_ALPHA_PLL_TYPE_LUCID' declared here CLK_ALPHA_PLL_TYPE_LUCID = CLK_ALPHA_PLL_TYPE_TRION, ^ drivers/clk/qcom/gcc-sm8450.c:106:12: error: use of undeclared identifier 'clk_alpha_pll_fixed_lucid_evo_ops'; did you mean 'clk_alpha_pll_fixed_lucid_5lpe_ops'? .ops = &clk_alpha_pll_fixed_lucid_evo_ops, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ clk_alpha_pll_fixed_lucid_5lpe_ops drivers/clk/qcom/clk-alpha-pll.h:149:29: note: 'clk_alpha_pll_fixed_lucid_5lpe_ops' declared here extern const struct clk_ops clk_alpha_pll_fixed_lucid_5lpe_ops; ^ 8 errors generated. vim +40 drivers/clk/qcom/gcc-sm8450.c 37 38 static struct clk_alpha_pll gcc_gpll0 = { 39 .offset = 0x0, 41 .clkr = { 42 .enable_reg = 0x62018, 43 .enable_mask = BIT(0), 44 .hw.init = &(struct clk_init_data){ 45 .name = "gcc_gpll0", 46 .parent_data = &(const struct clk_parent_data){ 47 .fw_name = "bi_tcxo", 48 }, 49 .num_parents = 1, 51 }, 52 }, 53 }; 54 55 static const struct clk_div_table post_div_table_gcc_gpll0_out_even[] = { 56 { 0x1, 2 }, 57 { } 58 }; 59 60 static struct clk_alpha_pll_postdiv gcc_gpll0_out_even = { 61 .offset = 0x0, 62 .post_div_shift = 10, 63 .post_div_table = post_div_table_gcc_gpll0_out_even, 64 .num_post_div = ARRAY_SIZE(post_div_table_gcc_gpll0_out_even), 65 .width = 4, 66 .regs = clk_alpha_pll_regs[CLK_ALPHA_PLL_TYPE_LUCID_EVO], 67 .clkr.hw.init = &(struct clk_init_data){ 68 .name = "gcc_gpll0_out_even", 69 .parent_data = &(const struct clk_parent_data){ 70 .hw = &gcc_gpll0.clkr.hw, 71 }, 72 .num_parents = 1, 74 }, 75 }; 76 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org