10:38 p.m.
Hi Wendy,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on char-misc/char-misc-testing]
[also build test WARNING on robh/for-next soc/for-next linus/master v5.10-rc4
next-20201118]
[cannot apply to xlnx/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Wendy-Liang/Xilinx-AI-engine-ker...
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
93c69b2d17372463ae33b79b3002c22a208945b3
config: nds32-randconfig-r032-20201118 (attached as .config)
compiler: nds32le-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/2eb5a0f27fd7de45134177e5869e31b9a...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Wendy-Liang/Xilinx-AI-engine-kernel-driver/20201118-160902
git checkout 2eb5a0f27fd7de45134177e5869e31b9a8ccfff3
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nds32
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
| ^~~~~~
include/linux/firmware/xlnx-zynqmp.h: In function
'zynqmp_pm_get_pll_frac_data':
include/linux/firmware/xlnx-zynqmp.h:431:10: error: 'ENODEV' undeclared (first
use in this function)
431 | return -ENODEV;
| ^~~~~~
include/linux/firmware/xlnx-zynqmp.h: In function 'zynqmp_pm_set_sd_tapdelay':
include/linux/firmware/xlnx-zynqmp.h:435:10: error: 'ENODEV' undeclared (first
use in this function)
435 | return -ENODEV;
| ^~~~~~
include/linux/firmware/xlnx-zynqmp.h: In function 'zynqmp_pm_sd_dll_reset':
include/linux/firmware/xlnx-zynqmp.h:439:10: error: 'ENODEV' undeclared (first
use in this function)
439 | return -ENODEV;
| ^~~~~~
include/linux/firmware/xlnx-zynqmp.h: In function 'zynqmp_pm_reset_assert':
include/linux/firmware/xlnx-zynqmp.h:444:10: error: 'ENODEV' undeclared (first
use in this function)
444 | return -ENODEV;
| ^~~~~~
include/linux/firmware/xlnx-zynqmp.h: In function
'zynqmp_pm_reset_get_status':
include/linux/firmware/xlnx-zynqmp.h:449:10: error: 'ENODEV' undeclared (first
use in this function)
449 | return -ENODEV;
| ^~~~~~
include/linux/firmware/xlnx-zynqmp.h: In function 'zynqmp_pm_init_finalize':
include/linux/firmware/xlnx-zynqmp.h:453:10: error: 'ENODEV' undeclared (first
use in this function)
453 | return -ENODEV;
| ^~~~~~
include/linux/firmware/xlnx-zynqmp.h: In function
'zynqmp_pm_set_suspend_mode':
include/linux/firmware/xlnx-zynqmp.h:457:10: error: 'ENODEV' undeclared (first
use in this function)
457 | return -ENODEV;
| ^~~~~~
include/linux/firmware/xlnx-zynqmp.h: In function 'zynqmp_pm_request_node':
include/linux/firmware/xlnx-zynqmp.h:463:10: error: 'ENODEV' undeclared (first
use in this function)
463 | return -ENODEV;
| ^~~~~~
include/linux/firmware/xlnx-zynqmp.h: In function 'zynqmp_pm_release_node':
include/linux/firmware/xlnx-zynqmp.h:467:10: error: 'ENODEV' undeclared (first
use in this function)
467 | return -ENODEV;
| ^~~~~~
include/linux/firmware/xlnx-zynqmp.h: In function 'zynqmp_pm_set_requirement':
include/linux/firmware/xlnx-zynqmp.h:474:10: error: 'ENODEV' undeclared (first
use in this function)
474 | return -ENODEV;
| ^~~~~~
include/linux/firmware/xlnx-zynqmp.h: In function 'zynqmp_pm_aes_engine':
include/linux/firmware/xlnx-zynqmp.h:478:10: error: 'ENODEV' undeclared (first
use in this function)
478 | return -ENODEV;
| ^~~~~~
include/linux/firmware/xlnx-zynqmp.h: In function 'zynqmp_pm_fpga_load':
include/linux/firmware/xlnx-zynqmp.h:483:10: error: 'ENODEV' undeclared (first
use in this function)
483 | return -ENODEV;
| ^~~~~~
include/linux/firmware/xlnx-zynqmp.h: In function 'zynqmp_pm_fpga_get_status':
include/linux/firmware/xlnx-zynqmp.h:487:10: error: 'ENODEV' undeclared (first
use in this function)
487 | return -ENODEV;
| ^~~~~~
include/linux/firmware/xlnx-zynqmp.h: In function 'zynqmp_pm_write_ggs':
include/linux/firmware/xlnx-zynqmp.h:491:10: error: 'ENODEV' undeclared (first
use in this function)
491 | return -ENODEV;
| ^~~~~~
include/linux/firmware/xlnx-zynqmp.h: In function 'zynqmp_pm_read_ggs':
include/linux/firmware/xlnx-zynqmp.h:495:10: error: 'ENODEV' undeclared (first
use in this function)
495 | return -ENODEV;
| ^~~~~~
include/linux/firmware/xlnx-zynqmp.h: In function 'zynqmp_pm_write_pggs':
include/linux/firmware/xlnx-zynqmp.h:499:10: error: 'ENODEV' undeclared (first
use in this function)
499 | return -ENODEV;
| ^~~~~~
include/linux/firmware/xlnx-zynqmp.h: In function 'zynqmp_pm_read_pggs':
include/linux/firmware/xlnx-zynqmp.h:503:10: error: 'ENODEV' undeclared (first
use in this function)
503 | return -ENODEV;
| ^~~~~~
include/linux/firmware/xlnx-zynqmp.h: In function 'zynqmp_pm_system_shutdown':
include/linux/firmware/xlnx-zynqmp.h:507:10: error: 'ENODEV' undeclared (first
use in this function)
507 | return -ENODEV;
| ^~~~~~
include/linux/firmware/xlnx-zynqmp.h: In function
'zynqmp_pm_set_boot_health_status':
include/linux/firmware/xlnx-zynqmp.h:511:10: error: 'ENODEV' undeclared (first
use in this function)
511 | return -ENODEV;
| ^~~~~~
include/linux/firmware/xlnx-zynqmp.h: In function
'zynqmp_pm_clear_aie_npi_isr':
include/linux/firmware/xlnx-zynqmp.h:516:10: error: 'ENODEV' undeclared (first
use in this function)
516 | return -ENODEV;
| ^~~~~~
In file included from include/linux/rwsem.h:18,
from include/linux/mm_types.h:11,
from include/linux/mmzone.h:21,
from include/linux/topology.h:33,
from include/linux/irq.h:19,
from include/asm-generic/hardirq.h:13,
from ./arch/nds32/include/generated/asm/hardirq.h:1,
from include/linux/hardirq.h:10,
from include/linux/interrupt.h:11,
from drivers/misc/xilinx-ai-engine/ai-engine-interrupt.c:9:
include/linux/err.h: At top level:
include/linux/err.h:24:35: error: conflicting types for 'ERR_PTR'
24 | static inline void * __must_check ERR_PTR(long error)
| ^~~~~~~
In file included from drivers/misc/xilinx-ai-engine/ai-engine-interrupt.c:8:
include/linux/firmware/xlnx-zynqmp.h:366:9: note: previous implicit declaration of
'ERR_PTR' was here
366 | return ERR_PTR(-ENODEV);
| ^~~~~~~
drivers/misc/xilinx-ai-engine/ai-engine-interrupt.c: In function
'aie_l2_backtrack':
> drivers/misc/xilinx-ai-engine/ai-engine-interrupt.c:497:7:
warning: variable 'notify' set but not used [-Wunused-but-set-variable]
497 | bool notify = false, sched_work = false;
| ^~~~~~
In file included from drivers/misc/xilinx-ai-engine/ai-engine-interrupt.c:8:
include/linux/firmware/xlnx-zynqmp.h: In function
'zynqmp_pm_clear_aie_npi_isr':
include/linux/firmware/xlnx-zynqmp.h:517:1: error: control reaches end of non-void
function [-Werror=return-type]
517 | }
| ^
cc1: some warnings being treated as errors
vim +/notify +497 drivers/misc/xilinx-ai-engine/ai-engine-interrupt.c
484
485 /**
486 * aie_l2_backtrack() - iterate through each level 2 interrupt controller
487 * in a given partition and backtrack its
488 * corresponding level 1 interrupt controller.
489 * @apart: AIE partition pointer
490 */
491 static void aie_l2_backtrack(struct aie_partition *apart)
492 {
493 struct aie_location loc;
494 unsigned long l2_mask = 0;
495 u32 n, ttype, l2_bitmap_offset = 0;
496 int ret;
497 bool notify = false, sched_work = false;
498
499 ret = mutex_lock_interruptible(&apart->mlock);
500 if (ret) {
501 dev_err_ratelimited(&apart->dev,
502 "Failed to acquire lock. Process was interrupted by fatal
signals\n");
503 return;
504 }
505
506 for (loc.col = apart->range.start.col, loc.row = 0;
507 loc.col < apart->range.start.col + apart->range.size.col;
508 loc.col++) {
509 ttype = apart->adev->ops->get_tile_type(&loc);
510 if (ttype != AIE_TILE_TYPE_SHIMNOC)
511 continue;
512
513 aie_resource_cpy_to_arr32(&apart->l2_mask, l2_bitmap_offset *
514 32, (u32 *)&l2_mask, 32);
515 l2_bitmap_offset++;
516
517 for_each_set_bit(n, &l2_mask,
518 apart->adev->l2_ctrl->num_broadcasts) {
519 if (aie_l1_backtrack(apart, loc, n))
520 notify = true;
521 }
522
523 aie_enable_l2_ctrl(apart, &loc, l2_mask);
524 }
525
526 /*
527 * Level 2 interrupt registers are edge-triggered. As a result,
528 * re-enabling level 2 won't trigger an interrupt for the already
529 * latched interrupts at level 1 controller.
530 */
531 for (loc.col = apart->range.start.col, loc.row = 0;
532 loc.col < apart->range.start.col + apart->range.size.col;
533 loc.col++) {
534 if (aie_get_l1_status(apart, &loc, AIE_SHIM_SWITCH_A) ||
535 aie_get_l1_status(apart, &loc, AIE_SHIM_SWITCH_B)) {
536 mutex_unlock(&apart->mlock);
537 sched_work = true;
538 schedule_work(&apart->adev->backtrack);
539 break;
540 }
541 }
542
543 if (!sched_work)
544 mutex_unlock(&apart->mlock);
545 }
546
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org