[kbuild-all] [android-common:android12-5.10 9579/13747] mm/hmm.c:177:13: error: implicit declaration of function 'pmd_protnone'

Hi Jihan, First bad commit (maybe != root cause): tree: https://android.googlesource.com/kernel/common android12-5.10 head: fb247ebba9d30374c123eb875354aa991c98146a commit: 2ea27b7efa3f6fd0b4fab6a748ab08322280f29b [9579/13747] ANDROID: GKI: Kconfig.gki: enable CONFIG_HMM_MIRROR with HIDDEN GPU config: arm-randconfig-r004-20211019 (attached as .config) compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git remote add android-common https://android.googlesource.com/kernel/common git fetch --no-tags android-common android12-5.10 git checkout 2ea27b7efa3f6fd0b4fab6a748ab08322280f29b # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=arm If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All error/warnings (new ones prefixed by >>): mm/hmm.c: In function 'pmd_to_hmm_pfn_flags': 177 | if (pmd_protnone(pmd)) | ^~~~~~~~~~~~ 179 | return (pmd_write(pmd) ? (HMM_PFN_VALID | HMM_PFN_WRITE) : | ^~~~~~~~~ | pgd_write 181 | hmm_pfn_flags_order(PMD_SHIFT - PAGE_SHIFT); | ^~~~~~~~~ | PUD_SHIFT mm/hmm.c:181:36: note: each undeclared identifier is reported only once for each function it appears in mm/hmm.c: In function 'hmm_is_device_private_entry': 216 | return is_device_private_entry(entry) && | ^~~~~~~~~~~~~~~~~~~~~~~ | hmm_is_device_private_entry 217 | device_private_entry_to_page(entry)->pgmap->owner == | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ 217 | device_private_entry_to_page(entry)->pgmap->owner == | ^~ mm/hmm.c: In function 'pte_to_hmm_pfn_flags': 224 | if (pte_none(pte) || !pte_present(pte) || pte_protnone(pte)) | ^~~~~~~~ | p4d_none 224 | if (pte_none(pte) || !pte_present(pte) || pte_protnone(pte)) | ^~~~~~~~~~~ | p4d_present 224 | if (pte_none(pte) || !pte_present(pte) || pte_protnone(pte)) | ^~~~~~~~~~~~ 226 | return pte_write(pte) ? (HMM_PFN_VALID | HMM_PFN_WRITE) : HMM_PFN_VALID; | ^~~~~~~~~ | pgd_write mm/hmm.c: In function 'hmm_vma_handle_pte': 250 | swp_entry_t entry = pte_to_swp_entry(pte); | ^~~~~~~~~~~~~~~~ 258 | if (is_write_device_private_entry(entry)) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | hmm_is_device_private_entry 260 | *hmm_pfn = device_private_entry_to_pfn(entry) | | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ 272 | if (!non_swap_entry(entry)) | ^~~~~~~~~~~~~~ 275 | if (is_migration_entry(entry)) { | ^~~~~~~~~~~~~~~~~~ 276 | pte_unmap(ptep); | ^~~~~~~~~ | pte_devmap 278 | migration_entry_wait(walk->mm, pmdp, addr); | ^~~~~~~~~~~~~~~~~~~~ 297 | if (pte_special(pte) && !is_zero_pfn(pte_pfn(pte))) { | ^~~~~~~ mm/hmm.c: In function 'hmm_vma_walk_pmd': 331 | if (pmd_none(pmd)) | ^~~~~~~~ | p4d_none mm/hmm.c:334:42: error: implicit declaration of function 'is_pmd_migration_entry' [-Werror=implicit-function-declaration] 334 | if (thp_migration_supported() && is_pmd_migration_entry(pmd)) { | ^~~~~~~~~~~~~~~~~~~~~~ mm/hmm.c:337:25: error: implicit declaration of function 'pmd_migration_entry_wait' [-Werror=implicit-function-declaration] 337 | pmd_migration_entry_wait(walk->mm, pmdp); | ^~~~~~~~~~~~~~~~~~~~~~~~ mm/hmm.c:343:14: error: implicit declaration of function 'pmd_present'; did you mean 'p4d_present'? [-Werror=implicit-function-declaration] 343 | if (!pmd_present(pmd)) { | ^~~~~~~~~~~ | p4d_present mm/hmm.c:349:13: error: implicit declaration of function 'pmd_devmap'; did you mean 'pte_devmap'? [-Werror=implicit-function-declaration] 349 | if (pmd_devmap(pmd) || pmd_trans_huge(pmd)) { | ^~~~~~~~~~ | pte_devmap mm/hmm.c:349:32: error: implicit declaration of function 'pmd_trans_huge'; did you mean 'pmd_trans_huge_lock'? [-Werror=implicit-function-declaration] 349 | if (pmd_devmap(pmd) || pmd_trans_huge(pmd)) { | ^~~~~~~~~~~~~~ | pmd_trans_huge_lock mm/hmm.c:359:23: error: implicit declaration of function 'pmd_read_atomic' [-Werror=implicit-function-declaration] 359 | pmd = pmd_read_atomic(pmdp); | ^~~~~~~~~~~~~~~ mm/hmm.c:373:13: error: implicit declaration of function 'pmd_bad'; did you mean 'p4d_bad'? [-Werror=implicit-function-declaration] 373 | if (pmd_bad(pmd)) { | ^~~~~~~ | p4d_bad mm/hmm.c:379:16: error: implicit declaration of function 'pte_offset_map'; did you mean 'pte_offset_map_lock'? [-Werror=implicit-function-declaration] 379 | ptep = pte_offset_map(pmdp, addr); | ^~~~~~~~~~~~~~ | pte_offset_map_lock mm/hmm.c:379:14: warning: assignment to 'pte_t *' {aka 'long unsigned int *'} from 'int' makes pointer from integer without a cast [-Wint-conversion] 379 | ptep = pte_offset_map(pmdp, addr); | ^ mm/hmm.c: In function 'hmm_is_device_private_entry': mm/hmm.c:219:1: error: control reaches end of non-void function [-Werror=return-type] 219 | } | ^ cc1: some warnings being treated as errors Kconfig warnings: (for reference only) WARNING: unmet direct dependencies detected for WIRELESS_EXT Depends on NET && WIRELESS Selected by - GKI_LEGACY_WEXT_ALLCONFIG WARNING: unmet direct dependencies detected for SND_PCM_ELD Depends on SOUND && !UML && SND Selected by - GKI_HIDDEN_SND_CONFIGS WARNING: unmet direct dependencies detected for WEXT_PROC Depends on NET && WIRELESS && PROC_FS && WEXT_CORE Selected by - GKI_LEGACY_WEXT_ALLCONFIG WARNING: unmet direct dependencies detected for WEXT_PRIV Depends on NET && WIRELESS Selected by - GKI_LEGACY_WEXT_ALLCONFIG WARNING: unmet direct dependencies detected for PAGE_POOL Depends on NET Selected by - GKI_HIDDEN_NET_CONFIGS WARNING: unmet direct dependencies detected for BALLOON_COMPACTION Depends on COMPACTION && MEMORY_BALLOON Selected by - GKI_HIDDEN_MM_CONFIGS WARNING: unmet direct dependencies detected for WEXT_SPY Depends on NET && WIRELESS Selected by - GKI_LEGACY_WEXT_ALLCONFIG WARNING: unmet direct dependencies detected for WEXT_CORE Depends on NET && WIRELESS && (CFG80211_WEXT || WIRELESS_EXT Selected by - GKI_LEGACY_WEXT_ALLCONFIG WARNING: unmet direct dependencies detected for NET_PTP_CLASSIFY Depends on NET Selected by - GKI_HIDDEN_NET_CONFIGS WARNING: unmet direct dependencies detected for SND_VMASTER Depends on SOUND && !UML && SND Selected by - GKI_HIDDEN_SND_CONFIGS WARNING: unmet direct dependencies detected for SND_PCM_IEC958 Depends on SOUND && !UML && SND Selected by - GKI_HIDDEN_SND_SOC_CONFIGS WARNING: unmet direct dependencies detected for DRM_TTM Depends on HAS_IOMEM && DRM && MMU Selected by - GKI_HIDDEN_DRM_CONFIGS && HAS_IOMEM && DRM WARNING: unmet direct dependencies detected for SND_JACK Depends on SOUND && !UML && SND Selected by - GKI_HIDDEN_SND_CONFIGS WARNING: unmet direct dependencies detected for SND_JACK_INPUT_DEV Depends on SOUND && !UML && SND && SND_JACK Selected by - GKI_HIDDEN_SND_CONFIGS WARNING: unmet direct dependencies detected for HMM_MIRROR Depends on MMU Selected by - GKI_HIDDEN_GPU_CONFIGS vim +/pmd_protnone +177 mm/hmm.c 3b50a6e536d2d8 Ralph Campbell 2020-07-01 173 2733ea144dcce7 Jason Gunthorpe 2020-05-01 174 static inline unsigned long pmd_to_hmm_pfn_flags(struct hmm_range *range, 2733ea144dcce7 Jason Gunthorpe 2020-05-01 175 pmd_t pmd) 2aee09d8c11642 Jérôme Glisse 2018-04-10 176 { 2aee09d8c11642 Jérôme Glisse 2018-04-10 @177 if (pmd_protnone(pmd)) 2aee09d8c11642 Jérôme Glisse 2018-04-10 178 return 0; 3b50a6e536d2d8 Ralph Campbell 2020-07-01 @179 return (pmd_write(pmd) ? (HMM_PFN_VALID | HMM_PFN_WRITE) : 3b50a6e536d2d8 Ralph Campbell 2020-07-01 180 HMM_PFN_VALID) | 3b50a6e536d2d8 Ralph Campbell 2020-07-01 @181 hmm_pfn_flags_order(PMD_SHIFT - PAGE_SHIFT); da4c3c735ea4dc Jérôme Glisse 2017-09-08 182 } da4c3c735ea4dc Jérôme Glisse 2017-09-08 183 992de9a8b75116 Jérôme Glisse 2019-05-13 184 #ifdef CONFIG_TRANSPARENT_HUGEPAGE 9d3973d60f0abd Christoph Hellwig 2019-08-06 185 static int hmm_vma_handle_pmd(struct mm_walk *walk, unsigned long addr, 2733ea144dcce7 Jason Gunthorpe 2020-05-01 186 unsigned long end, unsigned long hmm_pfns[], 2733ea144dcce7 Jason Gunthorpe 2020-05-01 187 pmd_t pmd) 9d3973d60f0abd Christoph Hellwig 2019-08-06 188 { 74eee180b935fc Jérôme Glisse 2017-09-08 189 struct hmm_vma_walk *hmm_vma_walk = walk->private; f88a1e90c66540 Jérôme Glisse 2018-04-10 190 struct hmm_range *range = hmm_vma_walk->range; 2aee09d8c11642 Jérôme Glisse 2018-04-10 191 unsigned long pfn, npages, i; a3eb13c1579ba9 Jason Gunthorpe 2020-03-27 192 unsigned int required_fault; 2733ea144dcce7 Jason Gunthorpe 2020-05-01 193 unsigned long cpu_flags; da4c3c735ea4dc Jérôme Glisse 2017-09-08 194 2aee09d8c11642 Jérôme Glisse 2018-04-10 195 npages = (end - addr) >> PAGE_SHIFT; f88a1e90c66540 Jérôme Glisse 2018-04-10 196 cpu_flags = pmd_to_hmm_pfn_flags(range, pmd); a3eb13c1579ba9 Jason Gunthorpe 2020-03-27 197 required_fault = 2733ea144dcce7 Jason Gunthorpe 2020-05-01 198 hmm_range_need_fault(hmm_vma_walk, hmm_pfns, npages, cpu_flags); a3eb13c1579ba9 Jason Gunthorpe 2020-03-27 199 if (required_fault) a3eb13c1579ba9 Jason Gunthorpe 2020-03-27 200 return hmm_vma_fault(addr, end, required_fault, walk); 74eee180b935fc Jérôme Glisse 2017-09-08 201 309f9a4f5e1a23 Christoph Hellwig 2019-08-06 202 pfn = pmd_pfn(pmd) + ((addr & ~PMD_MASK) >> PAGE_SHIFT); 068354ade5dd9e Jason Gunthorpe 2020-03-27 203 for (i = 0; addr < end; addr += PAGE_SIZE, i++, pfn++) 2733ea144dcce7 Jason Gunthorpe 2020-05-01 204 hmm_pfns[i] = pfn | cpu_flags; da4c3c735ea4dc Jérôme Glisse 2017-09-08 205 return 0; da4c3c735ea4dc Jérôme Glisse 2017-09-08 206 } 9d3973d60f0abd Christoph Hellwig 2019-08-06 207 #else /* CONFIG_TRANSPARENT_HUGEPAGE */ 9d3973d60f0abd Christoph Hellwig 2019-08-06 208 /* stub to allow the code below to compile */ 9d3973d60f0abd Christoph Hellwig 2019-08-06 209 int hmm_vma_handle_pmd(struct mm_walk *walk, unsigned long addr, 2733ea144dcce7 Jason Gunthorpe 2020-05-01 210 unsigned long end, unsigned long hmm_pfns[], pmd_t pmd); 9d3973d60f0abd Christoph Hellwig 2019-08-06 211 #endif /* CONFIG_TRANSPARENT_HUGEPAGE */ da4c3c735ea4dc Jérôme Glisse 2017-09-08 212 08ddddda667b3b Christoph Hellwig 2020-03-16 213 static inline bool hmm_is_device_private_entry(struct hmm_range *range, 08ddddda667b3b Christoph Hellwig 2020-03-16 214 swp_entry_t entry) 08ddddda667b3b Christoph Hellwig 2020-03-16 215 { 08ddddda667b3b Christoph Hellwig 2020-03-16 @216 return is_device_private_entry(entry) && 08ddddda667b3b Christoph Hellwig 2020-03-16 @217 device_private_entry_to_page(entry)->pgmap->owner == 08ddddda667b3b Christoph Hellwig 2020-03-16 218 range->dev_private_owner; 08ddddda667b3b Christoph Hellwig 2020-03-16 219 } 08ddddda667b3b Christoph Hellwig 2020-03-16 220 2733ea144dcce7 Jason Gunthorpe 2020-05-01 221 static inline unsigned long pte_to_hmm_pfn_flags(struct hmm_range *range, 2733ea144dcce7 Jason Gunthorpe 2020-05-01 222 pte_t pte) 2aee09d8c11642 Jérôme Glisse 2018-04-10 223 { 789c2af88f24d1 Philip Yang 2019-05-23 @224 if (pte_none(pte) || !pte_present(pte) || pte_protnone(pte)) 2aee09d8c11642 Jérôme Glisse 2018-04-10 225 return 0; 2733ea144dcce7 Jason Gunthorpe 2020-05-01 @226 return pte_write(pte) ? (HMM_PFN_VALID | HMM_PFN_WRITE) : HMM_PFN_VALID; 2aee09d8c11642 Jérôme Glisse 2018-04-10 227 } 2aee09d8c11642 Jérôme Glisse 2018-04-10 228 53f5c3f489ecdd Jérôme Glisse 2018-04-10 229 static int hmm_vma_handle_pte(struct mm_walk *walk, unsigned long addr, 53f5c3f489ecdd Jérôme Glisse 2018-04-10 230 unsigned long end, pmd_t *pmdp, pte_t *ptep, 2733ea144dcce7 Jason Gunthorpe 2020-05-01 231 unsigned long *hmm_pfn) 53f5c3f489ecdd Jérôme Glisse 2018-04-10 232 { 53f5c3f489ecdd Jérôme Glisse 2018-04-10 233 struct hmm_vma_walk *hmm_vma_walk = walk->private; f88a1e90c66540 Jérôme Glisse 2018-04-10 234 struct hmm_range *range = hmm_vma_walk->range; a3eb13c1579ba9 Jason Gunthorpe 2020-03-27 235 unsigned int required_fault; 2733ea144dcce7 Jason Gunthorpe 2020-05-01 236 unsigned long cpu_flags; da4c3c735ea4dc Jérôme Glisse 2017-09-08 237 pte_t pte = *ptep; 2733ea144dcce7 Jason Gunthorpe 2020-05-01 238 uint64_t pfn_req_flags = *hmm_pfn; da4c3c735ea4dc Jérôme Glisse 2017-09-08 239 74eee180b935fc Jérôme Glisse 2017-09-08 240 if (pte_none(pte)) { 2733ea144dcce7 Jason Gunthorpe 2020-05-01 241 required_fault = 2733ea144dcce7 Jason Gunthorpe 2020-05-01 242 hmm_pte_need_fault(hmm_vma_walk, pfn_req_flags, 0); a3eb13c1579ba9 Jason Gunthorpe 2020-03-27 243 if (required_fault) 74eee180b935fc Jérôme Glisse 2017-09-08 244 goto fault; 2733ea144dcce7 Jason Gunthorpe 2020-05-01 245 *hmm_pfn = 0; 53f5c3f489ecdd Jérôme Glisse 2018-04-10 246 return 0; 74eee180b935fc Jérôme Glisse 2017-09-08 247 } 74eee180b935fc Jérôme Glisse 2017-09-08 248 74eee180b935fc Jérôme Glisse 2017-09-08 249 if (!pte_present(pte)) { 8d63e4cd62b258 Ralph Campbell 2018-01-31 @250 swp_entry_t entry = pte_to_swp_entry(pte); 74eee180b935fc Jérôme Glisse 2017-09-08 251 74eee180b935fc Jérôme Glisse 2017-09-08 252 /* 0cb80a2fb5bcd1 Randy Dunlap 2020-08-11 253 * Never fault in device private pages, but just report 17ffdc482982af Christoph Hellwig 2020-03-16 254 * the PFN even if not present. 74eee180b935fc Jérôme Glisse 2017-09-08 255 */ 08ddddda667b3b Christoph Hellwig 2020-03-16 256 if (hmm_is_device_private_entry(range, entry)) { 2733ea144dcce7 Jason Gunthorpe 2020-05-01 257 cpu_flags = HMM_PFN_VALID; 17ffdc482982af Christoph Hellwig 2020-03-16 @258 if (is_write_device_private_entry(entry)) 2733ea144dcce7 Jason Gunthorpe 2020-05-01 259 cpu_flags |= HMM_PFN_WRITE; 2733ea144dcce7 Jason Gunthorpe 2020-05-01 @260 *hmm_pfn = device_private_entry_to_pfn(entry) | 2733ea144dcce7 Jason Gunthorpe 2020-05-01 261 cpu_flags; 53f5c3f489ecdd Jérôme Glisse 2018-04-10 262 return 0; 53f5c3f489ecdd Jérôme Glisse 2018-04-10 263 } 53f5c3f489ecdd Jérôme Glisse 2018-04-10 264 2733ea144dcce7 Jason Gunthorpe 2020-05-01 265 required_fault = 2733ea144dcce7 Jason Gunthorpe 2020-05-01 266 hmm_pte_need_fault(hmm_vma_walk, pfn_req_flags, 0); 846babe85efdda Jason Gunthorpe 2020-03-27 267 if (!required_fault) { 2733ea144dcce7 Jason Gunthorpe 2020-05-01 268 *hmm_pfn = 0; 76612d6ce4ccd2 Jason Gunthorpe 2020-02-28 269 return 0; 846babe85efdda Jason Gunthorpe 2020-03-27 270 } 76612d6ce4ccd2 Jason Gunthorpe 2020-02-28 271 76612d6ce4ccd2 Jason Gunthorpe 2020-02-28 @272 if (!non_swap_entry(entry)) 76612d6ce4ccd2 Jason Gunthorpe 2020-02-28 273 goto fault; 76612d6ce4ccd2 Jason Gunthorpe 2020-02-28 274 53f5c3f489ecdd Jérôme Glisse 2018-04-10 @275 if (is_migration_entry(entry)) { 74eee180b935fc Jérôme Glisse 2017-09-08 @276 pte_unmap(ptep); 74eee180b935fc Jérôme Glisse 2017-09-08 277 hmm_vma_walk->last = addr; d2e8d551165ccb Ralph Campbell 2019-07-25 @278 migration_entry_wait(walk->mm, pmdp, addr); 73231612dc7c90 Jérôme Glisse 2019-05-13 279 return -EBUSY; 74eee180b935fc Jérôme Glisse 2017-09-08 280 } 53f5c3f489ecdd Jérôme Glisse 2018-04-10 281 53f5c3f489ecdd Jérôme Glisse 2018-04-10 282 /* Report error for everything else */ dfdc22078f3f06 Jason Gunthorpe 2020-02-28 283 pte_unmap(ptep); 53f5c3f489ecdd Jérôme Glisse 2018-04-10 284 return -EFAULT; da4c3c735ea4dc Jérôme Glisse 2017-09-08 285 } da4c3c735ea4dc Jérôme Glisse 2017-09-08 286 76612d6ce4ccd2 Jason Gunthorpe 2020-02-28 287 cpu_flags = pte_to_hmm_pfn_flags(range, pte); 2733ea144dcce7 Jason Gunthorpe 2020-05-01 288 required_fault = 2733ea144dcce7 Jason Gunthorpe 2020-05-01 289 hmm_pte_need_fault(hmm_vma_walk, pfn_req_flags, cpu_flags); a3eb13c1579ba9 Jason Gunthorpe 2020-03-27 290 if (required_fault) 74eee180b935fc Jérôme Glisse 2017-09-08 291 goto fault; 74eee180b935fc Jérôme Glisse 2017-09-08 292 ac541f25037229 Ralph Campbell 2019-10-23 293 /* 40550627492291 Jason Gunthorpe 2020-03-05 294 * Since each architecture defines a struct page for the zero page, just 40550627492291 Jason Gunthorpe 2020-03-05 295 * fall through and treat it like a normal page. ac541f25037229 Ralph Campbell 2019-10-23 296 */ 40550627492291 Jason Gunthorpe 2020-03-05 @297 if (pte_special(pte) && !is_zero_pfn(pte_pfn(pte))) { 2733ea144dcce7 Jason Gunthorpe 2020-05-01 298 if (hmm_pte_need_fault(hmm_vma_walk, pfn_req_flags, 0)) { 40550627492291 Jason Gunthorpe 2020-03-05 299 pte_unmap(ptep); 40550627492291 Jason Gunthorpe 2020-03-05 300 return -EFAULT; 40550627492291 Jason Gunthorpe 2020-03-05 301 } 2733ea144dcce7 Jason Gunthorpe 2020-05-01 302 *hmm_pfn = HMM_PFN_ERROR; 40550627492291 Jason Gunthorpe 2020-03-05 303 return 0; ac541f25037229 Ralph Campbell 2019-10-23 304 } 992de9a8b75116 Jérôme Glisse 2019-05-13 305 2733ea144dcce7 Jason Gunthorpe 2020-05-01 306 *hmm_pfn = pte_pfn(pte) | cpu_flags; 53f5c3f489ecdd Jérôme Glisse 2018-04-10 307 return 0; 74eee180b935fc Jérôme Glisse 2017-09-08 308 74eee180b935fc Jérôme Glisse 2017-09-08 309 fault: 74eee180b935fc Jérôme Glisse 2017-09-08 310 pte_unmap(ptep); 5504ed29692faa Jérôme Glisse 2018-04-10 311 /* Fault any virtual address we were asked to fault */ a3eb13c1579ba9 Jason Gunthorpe 2020-03-27 312 return hmm_vma_fault(addr, end, required_fault, walk); 53f5c3f489ecdd Jérôme Glisse 2018-04-10 313 } 53f5c3f489ecdd Jérôme Glisse 2018-04-10 314 53f5c3f489ecdd Jérôme Glisse 2018-04-10 315 static int hmm_vma_walk_pmd(pmd_t *pmdp, 53f5c3f489ecdd Jérôme Glisse 2018-04-10 316 unsigned long start, 53f5c3f489ecdd Jérôme Glisse 2018-04-10 317 unsigned long end, 53f5c3f489ecdd Jérôme Glisse 2018-04-10 318 struct mm_walk *walk) 53f5c3f489ecdd Jérôme Glisse 2018-04-10 319 { 53f5c3f489ecdd Jérôme Glisse 2018-04-10 320 struct hmm_vma_walk *hmm_vma_walk = walk->private; 53f5c3f489ecdd Jérôme Glisse 2018-04-10 321 struct hmm_range *range = hmm_vma_walk->range; 2733ea144dcce7 Jason Gunthorpe 2020-05-01 322 unsigned long *hmm_pfns = 2733ea144dcce7 Jason Gunthorpe 2020-05-01 323 &range->hmm_pfns[(start - range->start) >> PAGE_SHIFT]; 2288a9a68175ce Jason Gunthorpe 2020-03-05 324 unsigned long npages = (end - start) >> PAGE_SHIFT; 2288a9a68175ce Jason Gunthorpe 2020-03-05 325 unsigned long addr = start; 53f5c3f489ecdd Jérôme Glisse 2018-04-10 326 pte_t *ptep; d08faca018c461 Jérôme Glisse 2018-10-30 327 pmd_t pmd; 53f5c3f489ecdd Jérôme Glisse 2018-04-10 328 53f5c3f489ecdd Jérôme Glisse 2018-04-10 329 again: d08faca018c461 Jérôme Glisse 2018-10-30 330 pmd = READ_ONCE(*pmdp); d08faca018c461 Jérôme Glisse 2018-10-30 @331 if (pmd_none(pmd)) b7a16c7ad790d0 Steven Price 2020-02-03 332 return hmm_vma_walk_hole(start, end, -1, walk); 53f5c3f489ecdd Jérôme Glisse 2018-04-10 333 d08faca018c461 Jérôme Glisse 2018-10-30 @334 if (thp_migration_supported() && is_pmd_migration_entry(pmd)) { 2733ea144dcce7 Jason Gunthorpe 2020-05-01 335 if (hmm_range_need_fault(hmm_vma_walk, hmm_pfns, npages, 0)) { d08faca018c461 Jérôme Glisse 2018-10-30 336 hmm_vma_walk->last = addr; d2e8d551165ccb Ralph Campbell 2019-07-25 @337 pmd_migration_entry_wait(walk->mm, pmdp); 73231612dc7c90 Jérôme Glisse 2019-05-13 338 return -EBUSY; d08faca018c461 Jérôme Glisse 2018-10-30 339 } 2733ea144dcce7 Jason Gunthorpe 2020-05-01 340 return hmm_pfns_fill(start, end, range, 0); 2288a9a68175ce Jason Gunthorpe 2020-03-05 341 } 2288a9a68175ce Jason Gunthorpe 2020-03-05 342 2288a9a68175ce Jason Gunthorpe 2020-03-05 @343 if (!pmd_present(pmd)) { 2733ea144dcce7 Jason Gunthorpe 2020-05-01 344 if (hmm_range_need_fault(hmm_vma_walk, hmm_pfns, npages, 0)) 2288a9a68175ce Jason Gunthorpe 2020-03-05 345 return -EFAULT; d28c2c9a487708 Ralph Campbell 2019-11-04 346 return hmm_pfns_fill(start, end, range, HMM_PFN_ERROR); 2288a9a68175ce Jason Gunthorpe 2020-03-05 347 } d08faca018c461 Jérôme Glisse 2018-10-30 348 d08faca018c461 Jérôme Glisse 2018-10-30 @349 if (pmd_devmap(pmd) || pmd_trans_huge(pmd)) { 53f5c3f489ecdd Jérôme Glisse 2018-04-10 350 /* d2e8d551165ccb Ralph Campbell 2019-07-25 351 * No need to take pmd_lock here, even if some other thread 53f5c3f489ecdd Jérôme Glisse 2018-04-10 352 * is splitting the huge pmd we will get that event through 53f5c3f489ecdd Jérôme Glisse 2018-04-10 353 * mmu_notifier callback. 53f5c3f489ecdd Jérôme Glisse 2018-04-10 354 * d2e8d551165ccb Ralph Campbell 2019-07-25 355 * So just read pmd value and check again it's a transparent 53f5c3f489ecdd Jérôme Glisse 2018-04-10 356 * huge or device mapping one and compute corresponding pfn 53f5c3f489ecdd Jérôme Glisse 2018-04-10 357 * values. 53f5c3f489ecdd Jérôme Glisse 2018-04-10 358 */ 53f5c3f489ecdd Jérôme Glisse 2018-04-10 @359 pmd = pmd_read_atomic(pmdp); 53f5c3f489ecdd Jérôme Glisse 2018-04-10 360 barrier(); 53f5c3f489ecdd Jérôme Glisse 2018-04-10 361 if (!pmd_devmap(pmd) && !pmd_trans_huge(pmd)) 53f5c3f489ecdd Jérôme Glisse 2018-04-10 362 goto again; 53f5c3f489ecdd Jérôme Glisse 2018-04-10 363 2733ea144dcce7 Jason Gunthorpe 2020-05-01 364 return hmm_vma_handle_pmd(walk, addr, end, hmm_pfns, pmd); 53f5c3f489ecdd Jérôme Glisse 2018-04-10 365 } 53f5c3f489ecdd Jérôme Glisse 2018-04-10 366 d08faca018c461 Jérôme Glisse 2018-10-30 367 /* d2e8d551165ccb Ralph Campbell 2019-07-25 368 * We have handled all the valid cases above ie either none, migration, d08faca018c461 Jérôme Glisse 2018-10-30 369 * huge or transparent huge. At this point either it is a valid pmd d08faca018c461 Jérôme Glisse 2018-10-30 370 * entry pointing to pte directory or it is a bad pmd that will not d08faca018c461 Jérôme Glisse 2018-10-30 371 * recover. d08faca018c461 Jérôme Glisse 2018-10-30 372 */ 2288a9a68175ce Jason Gunthorpe 2020-03-05 @373 if (pmd_bad(pmd)) { 2733ea144dcce7 Jason Gunthorpe 2020-05-01 374 if (hmm_range_need_fault(hmm_vma_walk, hmm_pfns, npages, 0)) 2288a9a68175ce Jason Gunthorpe 2020-03-05 375 return -EFAULT; d28c2c9a487708 Ralph Campbell 2019-11-04 376 return hmm_pfns_fill(start, end, range, HMM_PFN_ERROR); 2288a9a68175ce Jason Gunthorpe 2020-03-05 377 } 53f5c3f489ecdd Jérôme Glisse 2018-04-10 378 53f5c3f489ecdd Jérôme Glisse 2018-04-10 379 ptep = pte_offset_map(pmdp, addr); 2733ea144dcce7 Jason Gunthorpe 2020-05-01 380 for (; addr < end; addr += PAGE_SIZE, ptep++, hmm_pfns++) { 53f5c3f489ecdd Jérôme Glisse 2018-04-10 381 int r; 53f5c3f489ecdd Jérôme Glisse 2018-04-10 382 2733ea144dcce7 Jason Gunthorpe 2020-05-01 383 r = hmm_vma_handle_pte(walk, addr, end, pmdp, ptep, hmm_pfns); 53f5c3f489ecdd Jérôme Glisse 2018-04-10 384 if (r) { dfdc22078f3f06 Jason Gunthorpe 2020-02-28 385 /* hmm_vma_handle_pte() did pte_unmap() */ 53f5c3f489ecdd Jérôme Glisse 2018-04-10 386 return r; 53f5c3f489ecdd Jérôme Glisse 2018-04-10 387 } da4c3c735ea4dc Jérôme Glisse 2017-09-08 388 } da4c3c735ea4dc Jérôme Glisse 2017-09-08 389 pte_unmap(ptep - 1); da4c3c735ea4dc Jérôme Glisse 2017-09-08 390 return 0; da4c3c735ea4dc Jérôme Glisse 2017-09-08 391 } da4c3c735ea4dc Jérôme Glisse 2017-09-08 392 :::::: The code at line 177 was first introduced by commit :::::: 2aee09d8c1164219971c7b396f2235bd5334018c mm/hmm: change hmm_vma_fault() to allow write fault on page basis :::::: TO: Jérôme Glisse <jglisse(a)redhat.com&gt; :::::: CC: Linus Torvalds <torvalds(a)linux-foundation.org&gt; --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org