[kbuild-all] [djwong-xfs:btree-bulk-loading-5.7 78/87] include/asm-generic/page.h:93:50: error: ordered comparison of pointer with null pointer

tree: https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git btree-bulk-loading-5.7 head: 163cf69683aaf1a947d31ba732a17650071780d5 commit: 34b77474267d2c3ee0b3d64e0352d37344fccd16 [78/87] xfs: don't crash with assfail config: h8300-randconfig-a001-20200317 (attached as .config) compiler: h8300-linux-gcc (GCC) 9.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout 34b77474267d2c3ee0b3d64e0352d37344fccd16 # save the attached .config to linux build tree GCC_VERSION=9.2.0 make.cross ARCH=h8300 If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp(a)intel.com&gt; All error/warnings (new ones prefixed by >>): In file included from include/linux/string.h:6, from fs/open.c:8: include/linux/scatterlist.h: In function 'sg_set_buf': 93 | #define virt_addr_valid(kaddr) (((void *)(kaddr) >= (void *)PAGE_OFFSET) && \ | ^~ include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ include/linux/scatterlist.h:143:2: note: in expansion of macro 'BUG_ON' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~ include/linux/scatterlist.h:143:10: note: in expansion of macro 'virt_addr_valid' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~~~~~~~~~~ cc1: all warnings being treated as errors -- In file included from include/linux/init.h:5, from fs/namei.c:18: include/linux/scatterlist.h: In function 'sg_set_buf': 93 | #define virt_addr_valid(kaddr) (((void *)(kaddr) >= (void *)PAGE_OFFSET) && \ | ^~ include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ include/linux/scatterlist.h:143:2: note: in expansion of macro 'BUG_ON' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~ include/linux/scatterlist.h:143:10: note: in expansion of macro 'virt_addr_valid' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~~~~~~~~~~ In file included from arch/h8300/include/asm/bug.h:8, from include/linux/bug.h:5, from include/linux/mmdebug.h:5, from include/linux/gfp.h:5, from include/linux/slab.h:15, from fs/namei.c:21: include/linux/dma-mapping.h: In function 'dma_map_resource': include/asm-generic/page.h:91:32: error: comparison of unsigned expression >= 0 is always true [-Werror=type-limits] 91 | #define pfn_valid(pfn) ((pfn) >= ARCH_PFN_OFFSET && ((pfn) - ARCH_PFN_OFFSET) < max_mapnr) | ^~ include/asm-generic/bug.h:139:27: note: in definition of macro 'WARN_ON_ONCE' 139 | int __ret_warn_once = !!(condition); \ | ^~~~~~~~~ include/linux/dma-mapping.h:352:19: note: in expansion of macro 'pfn_valid' 352 | if (WARN_ON_ONCE(pfn_valid(PHYS_PFN(phys_addr)))) | ^~~~~~~~~ cc1: all warnings being treated as errors -- In file included from include/linux/kernel.h:11, from include/linux/list.h:9, from include/linux/preempt.h:11, from include/linux/spinlock.h:51, from include/linux/seqlock.h:36, from include/linux/time.h:6, from fs/ext4/balloc.c:15: include/linux/scatterlist.h: In function 'sg_set_buf': 93 | #define virt_addr_valid(kaddr) (((void *)(kaddr) >= (void *)PAGE_OFFSET) && \ | ^~ include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ include/linux/scatterlist.h:143:2: note: in expansion of macro 'BUG_ON' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~ include/linux/scatterlist.h:143:10: note: in expansion of macro 'virt_addr_valid' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~~~~~~~~~~ -- In file included from include/linux/kernel.h:11, from include/linux/list.h:9, from include/linux/module.h:12, from fs/ext4/super.c:20: include/linux/scatterlist.h: In function 'sg_set_buf': 93 | #define virt_addr_valid(kaddr) (((void *)(kaddr) >= (void *)PAGE_OFFSET) && \ | ^~ include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ include/linux/scatterlist.h:143:2: note: in expansion of macro 'BUG_ON' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~ include/linux/scatterlist.h:143:10: note: in expansion of macro 'virt_addr_valid' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~~~~~~~~~~ fs/ext4/super.c: In function 'ext4_remount': fs/ext4/super.c:5342:6: warning: variable 'enable_quota' set but not used [-Wunused-but-set-variable] 5342 | int enable_quota = 0; | ^~~~~~~~~~~~ -- In file included from include/linux/string.h:6, from include/linux/uuid.h:12, from fs/xfs/xfs_linux.h:10, from fs/xfs/xfs.h:22, from fs/xfs/libxfs/xfs_bmap.c:6: include/linux/scatterlist.h: In function 'sg_set_buf': 93 | #define virt_addr_valid(kaddr) (((void *)(kaddr) >= (void *)PAGE_OFFSET) && \ | ^~ include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ include/linux/scatterlist.h:143:2: note: in expansion of macro 'BUG_ON' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~ include/linux/scatterlist.h:143:10: note: in expansion of macro 'virt_addr_valid' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~~~~~~~~~~ fs/xfs/libxfs/xfs_bmap.c: In function 'xfs_bmap_del_extent_real': fs/xfs/libxfs/xfs_bmap.c:5091:17: warning: variable 'bno' set but not used [-Wunused-but-set-variable] 5091 | xfs_fsblock_t bno; | ^~~ fs/xfs/libxfs/xfs_bmap.c:5279:58: warning: suggest braces around empty body in an 'if' statement [-Wempty-body] 5279 | xfs_trans_mod_dquot_byino(tp, ip, qfield, (long)-nblks); | ^ -- In file included from include/linux/string.h:6, from include/linux/uuid.h:12, from fs/xfs/xfs_linux.h:10, from fs/xfs/xfs.h:22, from fs/xfs/xfs_ioctl.c:6: include/linux/scatterlist.h: In function 'sg_set_buf': 93 | #define virt_addr_valid(kaddr) (((void *)(kaddr) >= (void *)PAGE_OFFSET) && \ | ^~ include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ include/linux/scatterlist.h:143:2: note: in expansion of macro 'BUG_ON' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~ include/linux/scatterlist.h:143:10: note: in expansion of macro 'virt_addr_valid' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~~~~~~~~~~ fs/xfs/xfs_ioctl.c: In function 'xfs_ioctl_setattr': fs/xfs/xfs_ioctl.c:1519:20: warning: variable 'olddquot' set but not used [-Wunused-but-set-variable] 1519 | struct xfs_dquot *olddquot = NULL; | ^~~~~~~~ -- In file included from include/linux/string.h:6, from include/linux/uuid.h:12, from fs/xfs/xfs_linux.h:10, from fs/xfs/xfs.h:22, from fs/xfs/xfs_super.c:7: include/linux/scatterlist.h: In function 'sg_set_buf': 93 | #define virt_addr_valid(kaddr) (((void *)(kaddr) >= (void *)PAGE_OFFSET) && \ | ^~ include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ include/linux/scatterlist.h:143:2: note: in expansion of macro 'BUG_ON' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~ include/linux/scatterlist.h:143:10: note: in expansion of macro 'virt_addr_valid' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~~~~~~~~~~ fs/xfs/xfs_super.c: In function 'xfs_fs_statfs': fs/xfs/xfs_super.c:781:28: warning: suggest braces around empty body in an 'if' statement [-Wempty-body] 781 | xfs_qm_statvfs(ip, statp); | ^ -- In file included from include/linux/string.h:6, from include/linux/uuid.h:12, from fs/xfs/xfs_linux.h:10, from fs/xfs/xfs.h:22, from fs/xfs/xfs_iops.c:6: include/linux/scatterlist.h: In function 'sg_set_buf': 93 | #define virt_addr_valid(kaddr) (((void *)(kaddr) >= (void *)PAGE_OFFSET) && \ | ^~ include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ include/linux/scatterlist.h:143:2: note: in expansion of macro 'BUG_ON' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~ include/linux/scatterlist.h:143:10: note: in expansion of macro 'virt_addr_valid' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~~~~~~~~~~ fs/xfs/xfs_iops.c: In function 'xfs_setattr_nonsize': fs/xfs/xfs_iops.c:664:39: warning: variable 'olddquot2' set but not used [-Wunused-but-set-variable] 664 | struct xfs_dquot *olddquot1 = NULL, *olddquot2 = NULL; | ^~~~~~~~~ fs/xfs/xfs_iops.c:664:20: warning: variable 'olddquot1' set but not used [-Wunused-but-set-variable] 664 | struct xfs_dquot *olddquot1 = NULL, *olddquot2 = NULL; | ^~~~~~~~~ -- In file included from include/linux/kernel.h:11, from include/linux/list.h:9, from include/linux/module.h:12, from fs//ext4/super.c:20: include/linux/scatterlist.h: In function 'sg_set_buf': 93 | #define virt_addr_valid(kaddr) (((void *)(kaddr) >= (void *)PAGE_OFFSET) && \ | ^~ include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ include/linux/scatterlist.h:143:2: note: in expansion of macro 'BUG_ON' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~ include/linux/scatterlist.h:143:10: note: in expansion of macro 'virt_addr_valid' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~~~~~~~~~~ fs//ext4/super.c: In function 'ext4_remount': fs//ext4/super.c:5342:6: warning: variable 'enable_quota' set but not used [-Wunused-but-set-variable] 5342 | int enable_quota = 0; | ^~~~~~~~~~~~ -- In file included from include/linux/string.h:6, from include/linux/uuid.h:12, from fs//xfs/xfs_linux.h:10, from fs//xfs/xfs.h:22, from fs//xfs/libxfs/xfs_bmap.c:6: include/linux/scatterlist.h: In function 'sg_set_buf': 93 | #define virt_addr_valid(kaddr) (((void *)(kaddr) >= (void *)PAGE_OFFSET) && \ | ^~ include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ include/linux/scatterlist.h:143:2: note: in expansion of macro 'BUG_ON' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~ include/linux/scatterlist.h:143:10: note: in expansion of macro 'virt_addr_valid' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~~~~~~~~~~ fs//xfs/libxfs/xfs_bmap.c: In function 'xfs_bmap_del_extent_real': fs//xfs/libxfs/xfs_bmap.c:5091:17: warning: variable 'bno' set but not used [-Wunused-but-set-variable] 5091 | xfs_fsblock_t bno; | ^~~ fs//xfs/libxfs/xfs_bmap.c:5279:58: warning: suggest braces around empty body in an 'if' statement [-Wempty-body] 5279 | xfs_trans_mod_dquot_byino(tp, ip, qfield, (long)-nblks); | ^ -- In file included from include/linux/string.h:6, from include/linux/uuid.h:12, from fs//xfs/xfs_linux.h:10, from fs//xfs/xfs.h:22, from fs//xfs/xfs_ioctl.c:6: include/linux/scatterlist.h: In function 'sg_set_buf': 93 | #define virt_addr_valid(kaddr) (((void *)(kaddr) >= (void *)PAGE_OFFSET) && \ | ^~ include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ include/linux/scatterlist.h:143:2: note: in expansion of macro 'BUG_ON' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~ include/linux/scatterlist.h:143:10: note: in expansion of macro 'virt_addr_valid' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~~~~~~~~~~ fs//xfs/xfs_ioctl.c: In function 'xfs_ioctl_setattr': fs//xfs/xfs_ioctl.c:1519:20: warning: variable 'olddquot' set but not used [-Wunused-but-set-variable] 1519 | struct xfs_dquot *olddquot = NULL; | ^~~~~~~~ .. vim +93 include/asm-generic/page.h 5c01b46bb6bb8f Arnd Bergmann 2009-05-13 92 5c01b46bb6bb8f Arnd Bergmann 2009-05-13 @93 #define virt_addr_valid(kaddr) (((void *)(kaddr) >= (void *)PAGE_OFFSET) && \ 5c01b46bb6bb8f Arnd Bergmann 2009-05-13 94 ((void *)(kaddr) < (void *)memory_end)) 5c01b46bb6bb8f Arnd Bergmann 2009-05-13 95 :::::: The code at line 93 was first introduced by commit :::::: 5c01b46bb6bb8f2662573c05c87b5d68fa25af89 asm-generic: add generic NOMMU versions of some headers :::::: TO: Arnd Bergmann <arnd(a)arndb.de&gt; :::::: CC: Arnd Bergmann <arnd(a)klappe2.(none)&gt; --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org