8:23 p.m.
Hi Florian,
I love your patch! Perhaps something to improve:
url:
https://github.com/0day-ci/linux/commits/Florian-Westphal/netfilter-ctnet...
base: https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git master
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
smatch warnings:
net/netfilter/nf_conntrack_netlink.c:537 ctnetlink_dump_info() warn: if statement not
indented
# https://github.com/0day-ci/linux/commit/c8040548c0416425c95ae3b7008ef5d82...
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout c8040548c0416425c95ae3b7008ef5d829168d3b
vim +537 net/netfilter/nf_conntrack_netlink.c
c8040548c04164 Florian Westphal 2019-10-14 527 static int ctnetlink_dump_info(struct
sk_buff *skb, struct nf_conn *ct)
c8040548c04164 Florian Westphal 2019-10-14 528 {
c8040548c04164 Florian Westphal 2019-10-14 529 if (ctnetlink_dump_status(skb, ct) <
0 ||
c8040548c04164 Florian Westphal 2019-10-14 530 ctnetlink_dump_mark(skb, ct) < 0
||
c8040548c04164 Florian Westphal 2019-10-14 531 ctnetlink_dump_secctx(skb, ct) <
0 ||
c8040548c04164 Florian Westphal 2019-10-14 532 ctnetlink_dump_id(skb, ct) < 0
||
c8040548c04164 Florian Westphal 2019-10-14 533 ctnetlink_dump_use(skb, ct) < 0
||
c8040548c04164 Florian Westphal 2019-10-14 534 ctnetlink_dump_master(skb, ct) <
0)
c8040548c04164 Florian Westphal 2019-10-14 535 return -1;
c8040548c04164 Florian Westphal 2019-10-14 536
c8040548c04164 Florian Westphal 2019-10-14 @537 if (!test_bit(IPS_OFFLOAD_BIT,
&ct->status) &&
c8040548c04164 Florian Westphal 2019-10-14 538 (ctnetlink_dump_timeout(skb, ct)
< 0 ||
c8040548c04164 Florian Westphal 2019-10-14 539 ctnetlink_dump_protoinfo(skb, ct)
< 0))
Part of the "return -EINVAL;" commit must be missing. This should
generate a compile warning about reaching the end of a non-void
function.
c8040548c04164 Florian Westphal 2019-10-14 540
c8040548c04164 Florian Westphal 2019-10-14 541 return 0;
c8040548c04164 Florian Westphal 2019-10-14 542 }
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation