12:28 a.m.
tree: yhuang/random-r0.2-all
head: 4dc9ebb4880415aa517cbfa02ccb3e630c9328fc
commit: 6da469dc4ed8417b53535ce7772aa30754a57dd2 [45/46] migrate_balanced_pgdat: Use
zone_watermark_ok_safe()
config: x86_64-rhel-7.2-aep (attached as .config)
compiler: gcc-7 (Debian 7.4.0-13) 7.4.0
reproduce:
git checkout 6da469dc4ed8417b53535ce7772aa30754a57dd2
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
mm/migrate.c: In function 'migrate_balanced_pgdat':
> mm/migrate.c:1970:8: error: too many arguments to function
'zone_watermark_ok_safe'
if (!zone_watermark_ok_safe(zone, order,
wmark,
^~~~~~~~~~~~~~~~~~~~~~
In file included from include/linux/gfp.h:6:0,
from include/linux/mm.h:10,
from include/linux/migrate.h:5,
from mm/migrate.c:16:
include/linux/mmzone.h:849:6: note: declared here
bool zone_watermark_ok_safe(struct zone *z, unsigned int order,
^~~~~~~~~~~~~~~~~~~~~~
vim +/zone_watermark_ok_safe +1970 mm/migrate.c
1943
1944 #ifdef CONFIG_NUMA_BALANCING
1945 /*
1946 * Returns true if this is a safe migration target node for misplaced NUMA
1947 * pages. Currently it only checks the watermarks which crude
1948 */
1949 static bool migrate_balanced_pgdat(struct pglist_data *pgdat, int order)
1950 {
1951 int z;
1952
1953 for (z = pgdat->nr_zones - 1; z >= 0; z--) {
1954 unsigned long wmark;
1955 struct zone *zone = pgdat->node_zones + z;
1956
1957 if (!populated_zone(zone))
1958 continue;
1959
1960 /* Avoid waking kswapd by allocating pages_to_migrate pages. */
1961 wmark = high_wmark_pages(zone);
1962 /*
1963 * For hierarchy memory system, kswapd will
1964 * periodically migrate cold pages to slower memory
1965 * node. And the half of the high watermark is used
1966 * to allocate promoted pages.
1967 */
1968 if (sysctl_numa_balancing_mode & NUMA_BALANCING_HMEM)
1969 wmark = (wmark + low_wmark_pages(zone)) / 2;
1970 if (!zone_watermark_ok_safe(zone, order, wmark,
1971 ZONE_MOVABLE, 0))
1972 continue;
1973 return true;
1974 }
1975 return false;
1976 }
1977
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation