Hi Pablo,
I love your patch! Yet something to improve:
[auto build test ERROR on nf/master]
[also build test ERROR on nf-next/master v5.13-rc5 next-20210607]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Pablo-Neira-Ayuso/netfilter-nf_t...
base:
https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git master
config: x86_64-rhel-8.3-kselftests (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
#
https://github.com/0day-ci/linux/commit/b2cb4b60adb3205aad6e4a0637fff3220...
git remote add linux-review
https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Pablo-Neira-Ayuso/netfilter-nf_tables-add-last-expression/20210607-180754
git checkout b2cb4b60adb3205aad6e4a0637fff3220420dcf0
# save the attached .config to linux build tree
make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
ld: net/netfilter/nft_last.o: in function `nft_last_module_init':
> net/netfilter/nft_last.c:78: multiple definition of
`init_module'; net/netfilter/nf_tables_api.o:net/netfilter/nf_tables_api.c:9703: first
defined here
ld: net/netfilter/nft_last.o: in function
`nft_last_module_exit':
> net/netfilter/nft_last.c:84: multiple definition of
`cleanup_module'; net/netfilter/nf_tables_api.o:net/netfilter/nf_tables_api.c:9762:
first defined here
vim +78 net/netfilter/nft_last.c
76
77 static int __init nft_last_module_init(void)
78 {
79 return nft_register_expr(&nft_last_type);
80 }
81
82 static void __exit nft_last_module_exit(void)
83 {
84 nft_unregister_expr(&nft_last_type);
85 }
86
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org