[kbuild-all] Re: [RFC PATCH v2 5/9] ext4: add freespace tree optimizations

Hi Harshad, [FYI, it's a private test report for your RFC patch.] [auto build test WARNING on ext4/dev] [also build test WARNING on next-20200821] [cannot apply to tip/perf/core v5.9-rc1] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Harshad-Shirwadkar/ext4-add-free... base: https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev config: x86_64-randconfig-r036-20200820 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project b587ca93be114d07ec3bf654add97d7872325281) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All warnings (new ones prefixed by >>): void ext4_mb_frsp_meta_reinsert(struct super_block *sb, ^ fs/ext4/mballoc.c:808:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void ext4_mb_frsp_meta_reinsert(struct super_block *sb, ^ static fs/ext4/mballoc.c:890:6: warning: no previous prototype for function 'ext4_mb_frsp_free_tree' [-Wmissing-prototypes] void ext4_mb_frsp_free_tree(struct super_block *sb, struct ext4_frsp_tree *tree) ^ fs/ext4/mballoc.c:890:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void ext4_mb_frsp_free_tree(struct super_block *sb, struct ext4_frsp_tree *tree) ^ static fs/ext4/mballoc.c:920:24: warning: no previous prototype for function 'ext4_mb_frsp_search_by_off' [-Wmissing-prototypes] struct ext4_frsp_node *ext4_mb_frsp_search_by_off(struct super_block *sb, ^ fs/ext4/mballoc.c:920:1: note: declare 'static' if the function is not intended to be used outside of this translation unit struct ext4_frsp_node *ext4_mb_frsp_search_by_off(struct super_block *sb, ^ static fs/ext4/mballoc.c:945:5: warning: no previous prototype for function 'ext4_mb_frsp_node_can_merge' [-Wmissing-prototypes] int ext4_mb_frsp_node_can_merge(struct super_block *sb, ^ fs/ext4/mballoc.c:945:1: note: declare 'static' if the function is not intended to be used outside of this translation unit int ext4_mb_frsp_node_can_merge(struct super_block *sb, ^ static fs/ext4/mballoc.c:962:5: warning: no previous prototype for function 'ext4_mb_frsp_add_region' [-Wmissing-prototypes] int ext4_mb_frsp_add_region(struct super_block *sb, struct ext4_frsp_tree *tree, ^ fs/ext4/mballoc.c:962:1: note: declare 'static' if the function is not intended to be used outside of this translation unit int ext4_mb_frsp_add_region(struct super_block *sb, struct ext4_frsp_tree *tree, ^ static fs/ext4/mballoc.c:1014:5: warning: no previous prototype for function 'ext4_mb_frsp_free_blocks' [-Wmissing-prototypes] int ext4_mb_frsp_free_blocks(struct super_block *sb, ext4_group_t group, ^ fs/ext4/mballoc.c:1014:1: note: declare 'static' if the function is not intended to be used outside of this translation unit int ext4_mb_frsp_free_blocks(struct super_block *sb, ext4_group_t group, ^ static fs/ext4/mballoc.c:1034:5: warning: no previous prototype for function 'ext4_mb_frsp_bb_to_tree' [-Wmissing-prototypes] int ext4_mb_frsp_bb_to_tree(struct ext4_buddy *e4b, ext4_group_t group, ^ fs/ext4/mballoc.c:1034:1: note: declare 'static' if the function is not intended to be used outside of this translation unit int ext4_mb_frsp_bb_to_tree(struct ext4_buddy *e4b, ext4_group_t group, ^ static fs/ext4/mballoc.c:1066:5: warning: no previous prototype for function 'ext4_mb_frsp_load' [-Wmissing-prototypes] int ext4_mb_frsp_load(struct ext4_buddy *e4b) ^ fs/ext4/mballoc.c:1066:1: note: declare 'static' if the function is not intended to be used outside of this translation unit int ext4_mb_frsp_load(struct ext4_buddy *e4b) ^ static int ext4_mb_frsp_optimize(struct ext4_allocation_context *ac, int *tree_idx) ^ fs/ext4/mballoc.c:1366:1: note: declare 'static' if the function is not intended to be used outside of this translation unit int ext4_mb_frsp_optimize(struct ext4_allocation_context *ac, int *tree_idx) ^ static fs/ext4/mballoc.c:1587:5: warning: no previous prototype for function 'ext4_mb_init_freespace_trees' [-Wmissing-prototypes] int ext4_mb_init_freespace_trees(struct super_block *sb) ^ fs/ext4/mballoc.c:1587:1: note: declare 'static' if the function is not intended to be used outside of this translation unit int ext4_mb_init_freespace_trees(struct super_block *sb) ^ static fs/ext4/mballoc.c:411:28: warning: unused function 'ext4_flex_offset_to_blkno' [-Wunused-function] static inline ext4_fsblk_t ext4_flex_offset_to_blkno(struct super_block *sb, ^ 11 warnings generated. # https://github.com/0day-ci/linux/commit/832851db4656a8d433083fc076a53db95... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Harshad-Shirwadkar/ext4-add-free-space-extent-based-allocator/20200821-095647 git checkout 832851db4656a8d433083fc076a53db955d43020 vim +/ext4_mb_frsp_meta_reinsert +808 fs/ext4/mballoc.c 807 809 struct ext4_frsp_tree *tree) 810 { 811 struct ext4_sb_info *sbi = EXT4_SB(sb); 812 struct ext4_frsp_node *node; 813 struct rb_node *first = rb_first_cached(&tree->frsp_len_root); 814 struct rb_root_cached *meta_root = &EXT4_SB(sb)->s_mb_frsp_meta_tree; 815 int expected_len = 0; 816 817 if (!(tree->frsp_flags & EXT4_MB_FRSP_FLAG_LOADED)) 818 return; 819 820 if (first) { 821 node = rb_entry(first, struct ext4_frsp_node, frsp_len_node); 822 expected_len = node->frsp_len; 823 } 824 825 if (tree->frsp_max_free_len == expected_len) 826 return; 827 828 write_lock(&sbi->s_mb_frsp_lock); 829 tree->frsp_max_free_len = expected_len; 830 rb_erase_cached(&tree->frsp_len_node, &sbi->s_mb_frsp_meta_tree); 831 RB_CLEAR_NODE(&tree->frsp_len_node); 832 ext4_mb_rb_insert(meta_root, tree, struct ext4_frsp_tree, frsp_len_node, 833 ext4_mb_frsp_meta_cmp); 834 write_unlock(&sbi->s_mb_frsp_lock); 835 } 836 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org