6:05 p.m.
Hi Uwe,
I love your patch! Perhaps something to improve:
[auto build test WARNING on clk/clk-next]
[also build test WARNING on linux/master linus/master v5.14-rc6
next-20210818]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Uwe-Kleine-K-nig/clk-expand-clk_...
base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git
clk-next
:::::: branch date: 7 hours ago
:::::: commit date: 7 hours ago
compiler: xtensa-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
cppcheck possible warnings: (new ones prefixed by >>, may not real problems)
> drivers/clk/clk.c:1315:12: warning: Expression is always false
because 'else if' condition matches previous condition at line 1312.
[multiCondition]
} else if (clk_ignore_unused) {
^
vim +1315 drivers/clk/clk.c
7ec986efed0208c Dong Aisheng 2016-06-30 1307
564f86d384755e3 Rasmus Villemoes 2019-10-04 1308 static int __init
clk_disable_unused(void)
7ec986efed0208c Dong Aisheng 2016-06-30 1309 {
7ec986efed0208c Dong Aisheng 2016-06-30 1310 struct clk_core *core;
7ec986efed0208c Dong Aisheng 2016-06-30 1311
7ec986efed0208c Dong Aisheng 2016-06-30 @1312 if (clk_ignore_unused) {
7ec986efed0208c Dong Aisheng 2016-06-30 1313 pr_warn("clk: Not
disabling unused clocks\n");
7ec986efed0208c Dong Aisheng 2016-06-30 1314 return 0;
bef2d694904f8db Uwe Kleine-König 2021-08-18 @1315 } else if
(clk_ignore_unused) {
bef2d694904f8db Uwe Kleine-König 2021-08-18 1316 pr_warn("clk: Not
disabling %u unused clocks\n", clk_ignore_unused);
7ec986efed0208c Dong Aisheng 2016-06-30 1317 }
7ec986efed0208c Dong Aisheng 2016-06-30 1318
7ec986efed0208c Dong Aisheng 2016-06-30 1319 clk_prepare_lock();
7ec986efed0208c Dong Aisheng 2016-06-30 1320
7ec986efed0208c Dong Aisheng 2016-06-30 1321
hlist_for_each_entry(core, &clk_root_list, child_node)
7ec986efed0208c Dong Aisheng 2016-06-30 1322
clk_disable_unused_subtree(core);
7ec986efed0208c Dong Aisheng 2016-06-30 1323
7ec986efed0208c Dong Aisheng 2016-06-30 1324
hlist_for_each_entry(core, &clk_orphan_list, child_node)
7ec986efed0208c Dong Aisheng 2016-06-30 1325
clk_disable_unused_subtree(core);
7ec986efed0208c Dong Aisheng 2016-06-30 1326
7ec986efed0208c Dong Aisheng 2016-06-30 1327
hlist_for_each_entry(core, &clk_root_list, child_node)
7ec986efed0208c Dong Aisheng 2016-06-30 1328
clk_unprepare_unused_subtree(core);
7ec986efed0208c Dong Aisheng 2016-06-30 1329
7ec986efed0208c Dong Aisheng 2016-06-30 1330
hlist_for_each_entry(core, &clk_orphan_list, child_node)
7ec986efed0208c Dong Aisheng 2016-06-30 1331
clk_unprepare_unused_subtree(core);
7ec986efed0208c Dong Aisheng 2016-06-30 1332
7ec986efed0208c Dong Aisheng 2016-06-30 1333 clk_prepare_unlock();
7ec986efed0208c Dong Aisheng 2016-06-30 1334
7ec986efed0208c Dong Aisheng 2016-06-30 1335 return 0;
7ec986efed0208c Dong Aisheng 2016-06-30 1336 }
7ec986efed0208c Dong Aisheng 2016-06-30 1337
late_initcall_sync(clk_disable_unused);
7ec986efed0208c Dong Aisheng 2016-06-30 1338
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
_______________________________________________
kbuild mailing list -- kbuild(a)lists.01.org
To unsubscribe send an email to kbuild-leave(a)lists.01.org