12:50 a.m.
Hi Sai,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on bluetooth-next/master]
[also build test WARNING on linux/master linus/master v5.16-rc4 next-20211208]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Sai-Teja-Aluvala/Bluetooth-btqca...
base: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git
master
config: x86_64-randconfig-a015-20211207
(https://download.01.org/0day-ci/archive/20211208/202112082116.coCA1rOT-lk...)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project
097a1cb1d5ebb3a0ec4bcaed8ba3ff6a8e33c00a)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/1d58d86c5374c4c82aa1ec8638036667c...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Sai-Teja-Aluvala/Bluetooth-btqca-sequential-validation/20211208-162834
git checkout 1d58d86c5374c4c82aa1ec8638036667c114f83e
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir
ARCH=x86_64 SHELL=/bin/bash drivers/bluetooth/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
> drivers/bluetooth/btqca.c:144:5: warning: no previous prototype
for function 'qca_send_patch_config_cmd' [-Wmissing-prototypes]
int
qca_send_patch_config_cmd(struct hci_dev *hdev, enum qca_btsoc_type soc_type)
^
drivers/bluetooth/btqca.c:144:1: note: declare 'static' if the function is not
intended to be used outside of this translation unit
int qca_send_patch_config_cmd(struct hci_dev *hdev, enum qca_btsoc_type soc_type)
^
static
1 warning generated.
vim +/qca_send_patch_config_cmd +144 drivers/bluetooth/btqca.c
143
144 int qca_send_patch_config_cmd(struct hci_dev *hdev, enum
qca_btsoc_type soc_type)
145 {
146 struct sk_buff *skb;
147 int err = 0;
148 u8 cmd[5] = {EDL_PATCH_CONFIG_CMD, 0x01, 0, 0, 0};
149 u8 rlen = 0x02;
150 struct edl_event_hdr *edl;
151 u8 rtype = EDL_PATCH_CONFIG_CMD;
152
153 bt_dev_dbg(hdev, "QCA Patch config");
154
155 skb = __hci_cmd_sync_ev(hdev, EDL_PATCH_CMD_OPCODE, EDL_PATCH_CONFIG_CMD_LEN,
156 cmd, HCI_EV_VENDOR, HCI_INIT_TIMEOUT);
157 if (IS_ERR(skb)) {
158 err = PTR_ERR(skb);
159 bt_dev_err(hdev, "Sending QCA Patch config failed (%d)", err);
160 return err;
161 }
162 if (skb->len != rlen) {
163 bt_dev_err(hdev, "QCA Patch config cmd size mismatch len %d",
skb->len);
164 err = -EILSEQ;
165 goto out;
166 }
167 edl = (struct edl_event_hdr *)(skb->data);
168 if (!edl) {
169 bt_dev_err(hdev, "QCA Patch config with no header");
170 err = -EILSEQ;
171 goto out;
172 }
173 if (edl->cresp != EDL_PATCH_CONFIG_RES_EVT || edl->rtype != rtype) {
174 bt_dev_err(hdev, "QCA Wrong packet received %d %d", edl->cresp,
175 edl->rtype);
176 err = -EIO;
177 goto out;
178 }
179 out:
180 kfree(skb);
181 if (err)
182 bt_dev_err(hdev, "QCA Patch config cmd failed (%d)", err);
183
184 return err;
185 }
186
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org